Repository navigation
test(agent): harden PM-1954 composer regression test - #20143
christian-byrne wants to merge 1 commit into
Conversation
The existing case asserted the posted content equalled the typed text, but attachments are inlined as @[Image: ...] references, so it failed against its own fix. Assert the text is contained, that all 36 references and all 36 attachment refs survive the send, and that a wheel over the capped chip area actually scrolls it — an overflow-hidden cap would hide the overflow instead of making it reachable, and passes every other assertion here.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The CodeRabbit comment above is a review-skipped status message, not review feedback — it declined because the base branch is not the repository default. No findings were raised, so there is no code change to make in response. The non-default base is deliberate: this PR only modifies the test file introduced by #20129, and its assertions are designed to fail without that PR's layout fix. Retargeting at Requesting a review anyway so the change still gets one. @coderabbitai review |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1bf13110e06f14a30bfda0408dfac69c70380d15
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2197 passed, 0 failed📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-05T00:21:19.573Z",
"gitSha": "19f8a4081e64e4b3003adc9eae80aedd0c6a6c3d",
"branch": "glary/pm1954-composer-test-hardening",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.2259999999792,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.7610000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.281,
"heapDeltaBytes": 572528,
"heapUsedBytes": 67423700,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.274000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2009.2270000000099,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.5920000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.991,
"heapDeltaBytes": 494432,
"heapUsedBytes": 68387940,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.044999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1769.350999999972,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.447000000000003,
"layouts": 12,
"layoutDurationMs": 4.256,
"taskDurationMs": 770.609,
"heapDeltaBytes": -2486968,
"heapUsedBytes": 65439160,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 159.315,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849052,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1812.5680000000557,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.875,
"layouts": 12,
"layoutDurationMs": 4.403,
"taskDurationMs": 795.4999999999999,
"heapDeltaBytes": -2486548,
"heapUsedBytes": 65387552,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 168.184,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666972477064217,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1698.7199999999802,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.387,
"layouts": 6,
"layoutDurationMs": 1.117,
"taskDurationMs": 326.885,
"heapDeltaBytes": 3376588,
"heapUsedBytes": 71338792,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.064000000000004,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.6469999999754,
"styleRecalcs": 32,
"styleRecalcDurationMs": 8.356999999999998,
"layouts": 6,
"layoutDurationMs": 1.0769999999999997,
"taskDurationMs": 329.75199999999995,
"heapDeltaBytes": 3301364,
"heapUsedBytes": 71160844,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.826000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 661.7369999999596,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.3939999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.817,
"heapDeltaBytes": -8093764,
"heapUsedBytes": 59208284,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 168.199,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 691.351999999938,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.7890000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.171,
"heapDeltaBytes": -7852588,
"heapUsedBytes": 60010160,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 171.578,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536566,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1168.3539999999653,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 822.0219999999999,
"heapDeltaBytes": 15938748,
"heapUsedBytes": 85486384,
"domNodes": 0,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 68.81799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 540,
"frameDurationMs": 34.31176470588234,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1157.7140000000554,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 799.566,
"heapDeltaBytes": 15351560,
"heapUsedBytes": 85372188,
"domNodes": 0,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 72.08299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 516,
"frameDurationMs": 33.82058823529413,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.1110000000076,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.33399999999983,
"heapDeltaBytes": 17526056,
"heapUsedBytes": 104260712,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 165.35000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 873.0489999999236,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.8280000000004,
"heapDeltaBytes": 17616184,
"heapUsedBytes": 105059864,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 169.04400000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 223,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10015.548999999994,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.49800000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9073.031,
"heapDeltaBytes": 15602740,
"heapUsedBytes": 93380352,
"domNodes": -142,
"jsHeapTotalBytes": -11145216,
"scriptDurationMs": 7524.293999999999,
"eventListeners": -78,
"totalBlockingTimeMs": 1072,
"frameDurationMs": 33.611409395973155,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9922.923999999966,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.061999999999999555,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9023.896999999999,
"heapDeltaBytes": 7425296,
"heapUsedBytes": 91903404,
"domNodes": -142,
"jsHeapTotalBytes": -11145216,
"scriptDurationMs": 7458.188,
"eventListeners": -74,
"totalBlockingTimeMs": 825,
"frameDurationMs": 32.195454545454545,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8939.828999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8220.802000000001,
"heapDeltaBytes": 3007220,
"heapUsedBytes": 81080456,
"domNodes": -143,
"jsHeapTotalBytes": -9834496,
"scriptDurationMs": 6734.888,
"eventListeners": -82,
"totalBlockingTimeMs": 635,
"frameDurationMs": 32.72161172161172,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10018.654000000082,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.2399999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9185.687,
"heapDeltaBytes": 15756684,
"heapUsedBytes": 93523664,
"domNodes": -142,
"jsHeapTotalBytes": -7737344,
"scriptDurationMs": 7650.528,
"eventListeners": -74,
"totalBlockingTimeMs": 964,
"frameDurationMs": 33.27674418604651,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-graph-idle",
"durationMs": 2023.6080000000243,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.596,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.9619999999999,
"heapDeltaBytes": -10534964,
"heapUsedBytes": 78138372,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 31.841,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2019.8100000000068,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.4850000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.024,
"heapDeltaBytes": -10852264,
"heapUsedBytes": 78294688,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 31.869999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2338.5640000000194,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.447,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1553.6659999999997,
"heapDeltaBytes": -18731548,
"heapUsedBytes": 70341784,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 844.837,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78489208633093,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2277.8050000000576,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.976999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1554.9050000000002,
"heapDeltaBytes": -20531600,
"heapUsedBytes": 69272144,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 846.0680000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.788235294117644,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3583.2110000000057,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.099000000000002,
"layouts": 60,
"layoutDurationMs": 13.547,
"taskDurationMs": 1614.001,
"heapDeltaBytes": 1528228,
"heapUsedBytes": 70130016,
"domNodes": 24,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 779.893,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6660465116279,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3533.1489999999803,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.322000000000001,
"layouts": 60,
"layoutDurationMs": 13.804,
"taskDurationMs": 1606.816,
"heapDeltaBytes": 1623528,
"heapUsedBytes": 69396976,
"domNodes": 24,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 779.412,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3087.4670000000037,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.103999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1864.4530000000002,
"heapDeltaBytes": 3894008,
"heapUsedBytes": 72717444,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 1008.8540000000002,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756830601092897,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3102.216999999996,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.6979999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1821.138,
"heapDeltaBytes": 4135980,
"heapUsedBytes": 73215676,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 967.2939999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.847282608695654,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2015.3369999999882,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.1009999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.81600000000014,
"heapDeltaBytes": -10783680,
"heapUsedBytes": 79072980,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 29.386999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.648999999944,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.2960000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.8640000000001,
"heapDeltaBytes": -10754524,
"heapUsedBytes": 79505348,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 35.257999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.6399999999794,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.136000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.477,
"heapDeltaBytes": -11590224,
"heapUsedBytes": 58245208,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 144.399,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567588,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.4699999999775,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.67699999999996,
"heapDeltaBytes": 10344284,
"heapUsedBytes": 74221692,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 146.269,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2011.9270000000142,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.061,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.427,
"heapDeltaBytes": 680420,
"heapUsedBytes": 70180764,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.9590000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.6879999999164,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.494999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.638,
"heapDeltaBytes": 1004916,
"heapUsedBytes": 69957216,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.841999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.4340000000152,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.686,
"layouts": 16,
"layoutDurationMs": 5.306,
"taskDurationMs": 707.428,
"heapDeltaBytes": 16156768,
"heapUsedBytes": 78333964,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 109.21799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.2209999999377,
"styleRecalcs": 77,
"styleRecalcDurationMs": 17.209000000000003,
"layouts": 16,
"layoutDurationMs": 5.237,
"taskDurationMs": 708.4010000000001,
"heapDeltaBytes": -6284496,
"heapUsedBytes": 63461004,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 107.03099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.6649999999995,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.21700000000001,
"layouts": 5,
"layoutDurationMs": 14.828000000000001,
"taskDurationMs": 951.0660000000001,
"heapDeltaBytes": 1378072,
"heapUsedBytes": 92502120,
"domNodes": 14227,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 30.142000000000003,
"eventListeners": 2463,
"totalBlockingTimeMs": 132,
"frameDurationMs": 19.368918918918922,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8395.200999999986,
"styleRecalcs": 250,
"styleRecalcDurationMs": 33.635999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5484.567,
"heapDeltaBytes": -19430440,
"heapUsedBytes": 69479120,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2788.295,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69920477137177,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8529.694999999947,
"styleRecalcs": 251,
"styleRecalcDurationMs": 34.128,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5610.326,
"heapDeltaBytes": -16464264,
"heapUsedBytes": 71391316,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2887.4399999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698823529411765,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17996.824000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17207.911000000004,
"heapDeltaBytes": -41673200,
"heapUsedBytes": 179658520,
"domNodes": -3045,
"jsHeapTotalBytes": 1679360,
"scriptDurationMs": 273.536,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.222857142857148,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 18109.447000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17137.317,
"heapDeltaBytes": -36209284,
"heapUsedBytes": 179614920,
"domNodes": -3045,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 275.887,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.073756432247,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 21239.90699999996,
"styleRecalcs": 176,
"styleRecalcDurationMs": 17.88200000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20784.158000000003,
"heapDeltaBytes": -45451672,
"heapUsedBytes": 167403880,
"domNodes": -3045,
"jsHeapTotalBytes": 6115328,
"scriptDurationMs": 842.094,
"eventListeners": -14915,
"totalBlockingTimeMs": 52,
"frameDurationMs": 37.60902654867257,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 22672.534999999923,
"styleRecalcs": 182,
"styleRecalcDurationMs": 20.98500000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22280.095,
"heapDeltaBytes": -16254480,
"heapUsedBytes": 194544540,
"domNodes": -3045,
"jsHeapTotalBytes": 5312512,
"scriptDurationMs": 899.3409999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.959090909090904,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6388.026000000025,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.729,
"layouts": 20,
"layoutDurationMs": 23.661,
"taskDurationMs": 6265.719,
"heapDeltaBytes": -13036928,
"heapUsedBytes": 214024864,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 106.75300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.99464285714286,
"p95FrameDurationMs": 66.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6431.526000000076,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.26400000000004,
"layouts": 20,
"layoutDurationMs": 24.728000000000012,
"taskDurationMs": 6321.916,
"heapDeltaBytes": 556572,
"heapUsedBytes": 214102576,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 108.957,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.52095808383233,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8729.622000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8400.712,
"heapDeltaBytes": -19599396,
"heapUsedBytes": 181277792,
"domNodes": -3045,
"jsHeapTotalBytes": 9490432,
"scriptDurationMs": 132.36700000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.546779661016945,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9383.550000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8856.364000000001,
"heapDeltaBytes": -47582104,
"heapUsedBytes": 165791600,
"domNodes": -3045,
"jsHeapTotalBytes": 6115328,
"scriptDurationMs": 147.27699999999993,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.486577181208055,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 462.2999999999138,
"styleRecalcs": 13,
"styleRecalcDurationMs": 16.162999999999997,
"layouts": 4,
"layoutDurationMs": 1.9959999999999996,
"taskDurationMs": 117.986,
"heapDeltaBytes": 5686500,
"heapUsedBytes": 70866188,
"domNodes": 104,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.846000000000002,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285693,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 478.8620000000492,
"styleRecalcs": 15,
"styleRecalcDurationMs": 20.094,
"layouts": 3,
"layoutDurationMs": 1.006,
"taskDurationMs": 124.053,
"heapDeltaBytes": 5636824,
"heapUsedBytes": 71146080,
"domNodes": 101,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.160999999999998,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285693,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 963.9939999999569,
"styleRecalcs": 78,
"styleRecalcDurationMs": 107.879,
"layouts": 76,
"layoutDurationMs": 31.691999999999997,
"taskDurationMs": 935.847,
"heapDeltaBytes": 18534160,
"heapUsedBytes": 84799848,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 383.053,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 854.5589999999947,
"styleRecalcs": 78,
"styleRecalcDurationMs": 100.96900000000001,
"layouts": 76,
"layoutDurationMs": 29.571,
"taskDurationMs": 829.0790000000001,
"heapDeltaBytes": -8331720,
"heapUsedBytes": 80570204,
"domNodes": 76,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 338.891,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384603,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1459.444000000076,
"styleRecalcs": 78,
"styleRecalcDurationMs": 264.64500000000004,
"layouts": 76,
"layoutDurationMs": 33.873,
"taskDurationMs": 1435.928,
"heapDeltaBytes": 8766900,
"heapUsedBytes": 114361124,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 481.103,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.88536585365854,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1488.8160000000425,
"styleRecalcs": 78,
"styleRecalcDurationMs": 281.48400000000004,
"layouts": 76,
"layoutDurationMs": 34.657000000000004,
"taskDurationMs": 1470.901,
"heapDeltaBytes": 8279968,
"heapUsedBytes": 114831412,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 495.846,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.748749999999994,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
|
Closing alongside #20129. This PR hardens #20129's spec/behavior, and #20129 is closed: a red/green check showed the footer delta it depends on is unnecessary. |
PR Created by the Glary-Bot Agent
Targets
program/op470-pm1954-composerrepair(#20129), notmain— it only touches that PR's test file and depends on its layout fix.#20129's test does not pass against its own fix. It asserts
but
agentComposerStore.addAttachmentinserts each attachment as an inline reference, andcomposerPromptForSendserializes those intocontent. The posted value is'Use these images@[Image: attachment-01.png] @[Image: attachment-02.png] …', andtoMatchObjectcompares string properties exactly. Verified by running the spec from #20129 verbatim against #20129's own build:Changes
contentcontains the typed text, and that all 36@[Image: …]references survive the send.attachmentsarray has 36 refs. That is the field the backend consumes (useAgentSession.ts:869postsattachments: attachments?.map(a => a.ref)); a regression that kept the inline mentions but dropped the refs passed the old assertion.scrollTopactually moves.max-h-32alone is only a fix if the chips it pushes out of sight stay reachable — swappingoverflow-y-autoforoverflow-hiddenkeeps Send on screen and passes every other assertion in the file, but strands the overflow.{ timeout: 30_000 }from the chip-count assertion. Thecloudproject setstimeout: 15000, which overrides it, so it could never elapse; it only turned a crisp count mismatch into an opaque hard timeout.useAttachment.addFilesstages every chip synchronously before uploads start, so the default 5 s is ample.Verification
Run against a
DISTRIBUTION=cloudbuild served by a local ComfyUI backend (--front-end-root), matching how CI runs thecloudproject.viewport ratio 0overflow-y-auto→overflow-hiddenon the chip areascrollTopstays0while Send still passesAlso ran the surrounding agent suites against this base — 27 passed, no regressions from the layout change:
agentComposerManyAttachments,agentAttachmentUpload,agentComposerAssetDrop,agentComposerPaste,agentComposerAttachmentSurvivesFailedSend,agentInlineReferences,agentPanel(incl. composer sizing),agentUxScenarios(480px/640px panel widths).pnpm typecheck:browser,pnpm lint:unstaged, andoxfmt --checkare clean.Root cause, for the record
Two independent causes behind the one report:
composer-asset-sectionhad no height cap, insideAgentPanel'sshrink-0footer, inside aflex h-full flex-col overflow-hiddenpanel. At 1280×720 with 36 chips the composer measured 1086px inside a 664px panel, putting Send 589px below the panel's bottom edge — withscrollHeight === clientHeighteverywhere, so nothing could scroll to it.useComposer.canSendis false while any attachment hasuploading: true, anduseAttachmentrunsMAX_CONCURRENT_UPLOADS = 3, so dozens of files serialize into a window that scales with attachment count.onEntercallspreventDefault()before thecanSendcheck, so during that window Enter produces no send, no newline, and no feedback. This PR's fix addresses (1); (2) is unaddressed and tracked in the PM-1954 discussion.Relates to PM-1954.
Screenshots