Repository navigation
test(agent): prove PM-1875 visible progress - #20097
christian-byrne wants to merge 6 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-23T12:52:42.250Z",
"gitSha": "ec28312fb6940281a8789803fe8eb1c7b00bf5c7",
"branch": "test/pm1875-visible-progress-proof",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.2199999999807,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.2209999999999996,
"layouts": 9,
"layoutDurationMs": 2.9440000000000004,
"taskDurationMs": 550.243,
"heapDeltaBytes": 3656744,
"heapUsedBytes": 79215592,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 9.694999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2022.4469999999428,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.6249999999999996,
"layouts": 9,
"layoutDurationMs": 2.5100000000000002,
"taskDurationMs": 535.5139999999999,
"heapDeltaBytes": 3599032,
"heapUsedBytes": 78322772,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 7.901999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.606999999964,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.041000000000002,
"layouts": 10,
"layoutDurationMs": 2.4610000000000003,
"taskDurationMs": 873.6969999999999,
"heapDeltaBytes": -4815424,
"heapUsedBytes": 69774712,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 157.784,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1755.914999999959,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.495000000000001,
"layouts": 10,
"layoutDurationMs": 2.5759999999999996,
"taskDurationMs": 868.933,
"heapDeltaBytes": -4742096,
"heapUsedBytes": 70066660,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 157.662,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1806.3830000000394,
"styleRecalcs": 20,
"styleRecalcDurationMs": 5.755999999999999,
"layouts": 11,
"layoutDurationMs": 3.09,
"taskDurationMs": 464.5609999999999,
"heapDeltaBytes": -2244508,
"heapUsedBytes": 72652704,
"domNodes": 56,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 11.962,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66481481481481,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1790.2230000000827,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.756999999999999,
"layouts": 11,
"layoutDurationMs": 3.0750000000000006,
"taskDurationMs": 435.3550000000001,
"heapDeltaBytes": -1850476,
"heapUsedBytes": 72998296,
"domNodes": 56,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 9.987999999999996,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666355140186912,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 728.320999999994,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.6,
"layouts": 8,
"layoutDurationMs": 2.338,
"taskDurationMs": 510.292,
"heapDeltaBytes": 3168092,
"heapUsedBytes": 77943300,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 175.627,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 667.536000000041,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.909,
"layouts": 9,
"layoutDurationMs": 2.4999999999999996,
"taskDurationMs": 490.654,
"heapDeltaBytes": 2374584,
"heapUsedBytes": 77971060,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 167.70700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102556,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1146.649000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 827.6850000000001,
"heapDeltaBytes": 20167220,
"heapUsedBytes": 98798028,
"domNodes": 0,
"jsHeapTotalBytes": 19562496,
"scriptDurationMs": 62.96099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 514,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1129.4540000000097,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 824.9439999999998,
"heapDeltaBytes": 19988948,
"heapUsedBytes": 98517184,
"domNodes": 0,
"jsHeapTotalBytes": 19562496,
"scriptDurationMs": 65.581,
"eventListeners": 0,
"totalBlockingTimeMs": 508,
"frameDurationMs": 34.34545454545454,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.6310000000162,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.9830000000002,
"heapDeltaBytes": -4188920,
"heapUsedBytes": 86453484,
"domNodes": 0,
"jsHeapTotalBytes": 3936256,
"scriptDurationMs": 167.69299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 223,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.3389999999908,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.9090000000003,
"heapDeltaBytes": -3464356,
"heapUsedBytes": 85386684,
"domNodes": 0,
"jsHeapTotalBytes": 3674112,
"scriptDurationMs": 162.18099999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11873.734000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11001.301000000001,
"heapDeltaBytes": -12613160,
"heapUsedBytes": 78288092,
"domNodes": -141,
"jsHeapTotalBytes": 10350592,
"scriptDurationMs": 9031.056999999999,
"eventListeners": -49,
"totalBlockingTimeMs": 1547,
"frameDurationMs": 32.42131147540984,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10198.546000000078,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9363.327000000001,
"heapDeltaBytes": -3660616,
"heapUsedBytes": 87239832,
"domNodes": -141,
"jsHeapTotalBytes": 8515584,
"scriptDurationMs": 7573.895,
"eventListeners": -53,
"totalBlockingTimeMs": 926,
"frameDurationMs": 31.04542682926829,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10051.448999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9206.347999999998,
"heapDeltaBytes": -2382436,
"heapUsedBytes": 88058816,
"domNodes": -141,
"jsHeapTotalBytes": 7467008,
"scriptDurationMs": 7417.251,
"eventListeners": -49,
"totalBlockingTimeMs": 783,
"frameDurationMs": 31.4046875,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10003.207999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9163.046999999999,
"heapDeltaBytes": -17630820,
"heapUsedBytes": 73373308,
"domNodes": -141,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 7347.656000000001,
"eventListeners": -53,
"totalBlockingTimeMs": 670,
"frameDurationMs": 31.2484375,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 232.63700000001108,
"styleRecalcs": 22,
"styleRecalcDurationMs": 15.588000000000001,
"layouts": 11,
"layoutDurationMs": 3.3209999999999997,
"taskDurationMs": 176.604,
"heapDeltaBytes": 14527900,
"heapUsedBytes": 89864284,
"domNodes": 936,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 8.286,
"eventListeners": 205,
"totalBlockingTimeMs": 6,
"frameDurationMs": 25.922222222222143,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 222.25299999990966,
"styleRecalcs": 22,
"styleRecalcDurationMs": 14.201,
"layouts": 11,
"layoutDurationMs": 3.185,
"taskDurationMs": 170.13,
"heapDeltaBytes": 14594200,
"heapUsedBytes": 89243004,
"domNodes": 936,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 8.055,
"eventListeners": 205,
"totalBlockingTimeMs": 8,
"frameDurationMs": 25.922222222222242,
"p95FrameDurationMs": 100
},
{
"name": "large-graph-idle",
"durationMs": 2023.6280000000306,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.606,
"layouts": 9,
"layoutDurationMs": 2.294,
"taskDurationMs": 617.9800000000001,
"heapDeltaBytes": -6841744,
"heapUsedBytes": 85747556,
"domNodes": 0,
"jsHeapTotalBytes": 5279744,
"scriptDurationMs": 32.154,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2024.505999999974,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6319999999999997,
"layouts": 8,
"layoutDurationMs": 2.1060000000000003,
"taskDurationMs": 604.288,
"heapDeltaBytes": -8331044,
"heapUsedBytes": 84372828,
"domNodes": 0,
"jsHeapTotalBytes": 5279744,
"scriptDurationMs": 32.74800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2516.845999999987,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.583,
"layouts": 6,
"layoutDurationMs": 1.8390000000000004,
"taskDurationMs": 1688.8169999999998,
"heapDeltaBytes": -4606828,
"heapUsedBytes": 88443732,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 819.256,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.776666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2637.271000000055,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.642999999999999,
"layouts": 7,
"layoutDurationMs": 1.7209999999999999,
"taskDurationMs": 1742.6819999999998,
"heapDeltaBytes": 17475844,
"heapUsedBytes": 89665100,
"domNodes": 0,
"jsHeapTotalBytes": 4419584,
"scriptDurationMs": 886.82,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.880128205128205,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3839.1619999999875,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.488,
"layouts": 64,
"layoutDurationMs": 10.495000000000001,
"taskDurationMs": 1784.773,
"heapDeltaBytes": 5664692,
"heapUsedBytes": 79823176,
"domNodes": 24,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 808.929,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666521739130438,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3716.9569999999794,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.123,
"layouts": 63,
"layoutDurationMs": 9.874,
"taskDurationMs": 1744.8899999999999,
"heapDeltaBytes": 6782104,
"heapUsedBytes": 79211892,
"domNodes": 24,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 798.955,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66591928251121,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3027.473999999984,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.385000000000001,
"layouts": 5,
"layoutDurationMs": 1.3699999999999997,
"taskDurationMs": 1999.0100000000002,
"heapDeltaBytes": 22840332,
"heapUsedBytes": 96058972,
"domNodes": 0,
"jsHeapTotalBytes": 4349952,
"scriptDurationMs": 969.536,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.945251396648043,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3015.3289999999515,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.953,
"layouts": 4,
"layoutDurationMs": 1.0379999999999998,
"taskDurationMs": 1972.9439999999997,
"heapDeltaBytes": 20822292,
"heapUsedBytes": 94396296,
"domNodes": 0,
"jsHeapTotalBytes": 4874240,
"scriptDurationMs": 971.8899999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.04237288135593,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3058.162999999979,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.4580000000000002,
"layouts": 5,
"layoutDurationMs": 1.277,
"taskDurationMs": 738.2509999999999,
"heapDeltaBytes": 25560780,
"heapUsedBytes": 97333392,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 352.775,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75737704918033,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3048.810000000003,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.5860000000000005,
"layouts": 5,
"layoutDurationMs": 1.398,
"taskDurationMs": 747.6439999999999,
"heapDeltaBytes": 3472988,
"heapUsedBytes": 97924792,
"domNodes": 0,
"jsHeapTotalBytes": 6066176,
"scriptDurationMs": 361.12300000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75714285714286,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2014.156000000014,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.05,
"layouts": 7,
"layoutDurationMs": 2.1179999999999994,
"taskDurationMs": 614.0260000000001,
"heapDeltaBytes": 15638168,
"heapUsedBytes": 88516004,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 38.74,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2020.8279999999377,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.326999999999999,
"layouts": 8,
"layoutDurationMs": 2.3249999999999997,
"taskDurationMs": 591.444,
"heapDeltaBytes": 15862836,
"heapUsedBytes": 88053320,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 29.637000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2875.41200000004,
"styleRecalcs": 25,
"styleRecalcDurationMs": 12.548,
"layouts": 6,
"layoutDurationMs": 1.3699999999999997,
"taskDurationMs": 575.8319999999999,
"heapDeltaBytes": 3484392,
"heapUsedBytes": 76020868,
"domNodes": 19,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 188.02799999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665697674418606,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2742.195000000038,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.585,
"layouts": 7,
"layoutDurationMs": 1.6810000000000003,
"taskDurationMs": 577.1639999999999,
"heapDeltaBytes": 3831212,
"heapUsedBytes": 76338556,
"domNodes": 19,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 197.925,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3249.9969999999507,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.844,
"layouts": 6,
"layoutDurationMs": 1.6,
"taskDurationMs": 913.4930000000002,
"heapDeltaBytes": 5265240,
"heapUsedBytes": 77520568,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 374.00700000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.838860103626942,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3268.0070000000114,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7410000000000003,
"layouts": 7,
"layoutDurationMs": 1.555,
"taskDurationMs": 901.4739999999999,
"heapDeltaBytes": 12189236,
"heapUsedBytes": 84594936,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 370.901,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666326530612245,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 713.3610000000203,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.725,
"layouts": 9,
"layoutDurationMs": 2.952,
"taskDurationMs": 496.525,
"heapDeltaBytes": -1702968,
"heapUsedBytes": 74851680,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 151.441,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 591.1879999999883,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.3180000000000005,
"layouts": 11,
"layoutDurationMs": 2.72,
"taskDurationMs": 439.052,
"heapDeltaBytes": -2162340,
"heapUsedBytes": 74380840,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 146.03500000000003,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2021.4619999999854,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.865,
"layouts": 10,
"layoutDurationMs": 2.816,
"taskDurationMs": 551.883,
"heapDeltaBytes": 3094916,
"heapUsedBytes": 79740384,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 9.468999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.4959999999464,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8539999999999996,
"layouts": 10,
"layoutDurationMs": 2.823,
"taskDurationMs": 535.342,
"heapDeltaBytes": 2699996,
"heapUsedBytes": 79907772,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 8.324,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1891.6700000000333,
"styleRecalcs": 82,
"styleRecalcDurationMs": 15.272,
"layouts": 10,
"layoutDurationMs": 2.826,
"taskDurationMs": 1038.313,
"heapDeltaBytes": -8130844,
"heapUsedBytes": 68648012,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 114.96400000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665486725663715,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1974.4339999999738,
"styleRecalcs": 87,
"styleRecalcDurationMs": 13.950999999999999,
"layouts": 10,
"layoutDurationMs": 2.4019999999999997,
"taskDurationMs": 1086.4279999999999,
"heapDeltaBytes": -8105512,
"heapUsedBytes": 68722184,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 111.17600000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665254237288135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1453.6229999999932,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.207999999999995,
"layouts": 5,
"layoutDurationMs": 16.514,
"taskDurationMs": 1065.577,
"heapDeltaBytes": 8806588,
"heapUsedBytes": 109646148,
"domNodes": 16030,
"jsHeapTotalBytes": 17174528,
"scriptDurationMs": 30.329,
"eventListeners": 3246,
"totalBlockingTimeMs": 166,
"frameDurationMs": 19.81891891891891,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10718.164,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.958,
"layouts": 8,
"layoutDurationMs": 2.1460000000000004,
"taskDurationMs": 6267.683,
"heapDeltaBytes": -23785536,
"heapUsedBytes": 68370092,
"domNodes": -141,
"jsHeapTotalBytes": 6979584,
"scriptDurationMs": 2802.555,
"eventListeners": -47,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.717757009345792,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9693.349000000013,
"styleRecalcs": 249,
"styleRecalcDurationMs": 29.214,
"layouts": 7,
"layoutDurationMs": 1.9619999999999997,
"taskDurationMs": 5996.044,
"heapDeltaBytes": -14265220,
"heapUsedBytes": 78419960,
"domNodes": -141,
"jsHeapTotalBytes": 6123520,
"scriptDurationMs": 2709.845,
"eventListeners": -47,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.694645941278065,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 22897.662000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22318.438000000002,
"heapDeltaBytes": -21576796,
"heapUsedBytes": 263744480,
"domNodes": -3245,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 326.04900000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.076962457337885,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 22920.597000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22478.560999999998,
"heapDeltaBytes": -19527536,
"heapUsedBytes": 265406296,
"domNodes": -3245,
"jsHeapTotalBytes": 20971520,
"scriptDurationMs": 311.259,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.17247863247863,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 28340.483000000007,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.875999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27978.303000000004,
"heapDeltaBytes": -12945980,
"heapUsedBytes": 281388612,
"domNodes": -3245,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 917.4180000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 8,
"frameDurationMs": 53.45716981132075,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 27722.097000000074,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.988000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27274.915999999997,
"heapDeltaBytes": -14650392,
"heapUsedBytes": 265878380,
"domNodes": -3245,
"jsHeapTotalBytes": 21757952,
"scriptDurationMs": 895.347,
"eventListeners": -651,
"totalBlockingTimeMs": 34,
"frameDurationMs": 50.8543119266055,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8142.822000000024,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.00599999999999,
"layouts": 20,
"layoutDurationMs": 23.40700000000001,
"taskDurationMs": 8009.304999999999,
"heapDeltaBytes": 425856,
"heapUsedBytes": 285141904,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 127.21099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.30511363636364,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8019.281999999976,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.25300000000001,
"layouts": 20,
"layoutDurationMs": 22.921999999999997,
"taskDurationMs": 7891.814,
"heapDeltaBytes": 15379116,
"heapUsedBytes": 296082484,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 120.48900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.80491803278688,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11652.873,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11161.026,
"heapDeltaBytes": -43675764,
"heapUsedBytes": 262709648,
"domNodes": -3245,
"jsHeapTotalBytes": 26738688,
"scriptDurationMs": 189.348,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.22390572390572,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11668.072000000051,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11306.583000000002,
"heapDeltaBytes": -39474556,
"heapUsedBytes": 266319984,
"domNodes": -3245,
"jsHeapTotalBytes": 26476544,
"scriptDurationMs": 156.52999999999994,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.41283783783784,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 135.59199999997418,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.264999999999999,
"layouts": 8,
"layoutDurationMs": 3.934,
"taskDurationMs": 97.876,
"heapDeltaBytes": 4951020,
"heapUsedBytes": 77874324,
"domNodes": 129,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.338000000000001,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.675000000000068,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 112.97700000000077,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.15,
"layouts": 8,
"layoutDurationMs": 2.4730000000000003,
"taskDurationMs": 85.34099999999998,
"heapDeltaBytes": 4677520,
"heapUsedBytes": 77636476,
"domNodes": 98,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.372,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142844,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 411.55300000002626,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.733,
"layouts": 76,
"layoutDurationMs": 13.892,
"taskDurationMs": 361.84499999999997,
"heapDeltaBytes": 11048992,
"heapUsedBytes": 52595056,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 168.507,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667999999999992,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 493.01900000000387,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.708,
"layouts": 76,
"layoutDurationMs": 15.347,
"taskDurationMs": 453.45599999999996,
"heapDeltaBytes": -4109088,
"heapUsedBytes": 39408152,
"domNodes": 4,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 220.027,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 501.24800000003233,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.643,
"layouts": 76,
"layoutDurationMs": 14.22,
"taskDurationMs": 457.195,
"heapDeltaBytes": 309920,
"heapUsedBytes": 91170300,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 181.411,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 593.4489999999641,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.869,
"layouts": 76,
"layoutDurationMs": 15.504,
"taskDurationMs": 552.507,
"heapDeltaBytes": 1527872,
"heapUsedBytes": 92345472,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 229.684,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.142857142857142,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2193 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since ecd1b25ccc2aeb2761be013c76a739890b4a1c4f
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (156)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 3 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 2 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## test/pm1875-agent-local-run-client-id-blackbox #20097 +/- ##
==================================================================================
- Coverage 85.75% 85.75% -0.01%
==================================================================================
Files 2430 2430
Lines 138814 138815 +1
Branches 37655 35713 -1942
==================================================================================
- Hits 119043 119040 -3
- Misses 19396 19400 +4
Partials 375 375
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
… of two
`toContainText('25%')` on the whole progress overlay could not tell the
overlay's two percentages apart: it renders a whole-run total next to the
current node's figure, so the match was satisfied by either. Measured against
the live overlay, a run stalled mid-node reads
`Total: 0%Current node:-25%`, and forcing the regression the report
describes - current node stuck at 0% while the total reads 25% - left the old
assertion green. `toContainText` also only waits for attachment, so text
hidden by the overlay's `v-show` wrapper satisfied it too.
Scope it instead to the current-node percentage, by test id, and require it
visible. The test id is new on that span; `QueueOverlayActive`'s own unit test
now locates by it so losing the affordance fails there first.
Derive the expected figure from the frame the fixture sends rather than
hard-coding 25%, which depended silently on `stallJob`'s defaults, and guard
that the stalled step is a strict partial one - deriving it is what would
otherwise let a step of 0 quietly turn the assertion into "render whatever was
sent".
Also correct the comment: the queue overlay is a second view over the same
`executionStore` progress state the canvas outline reads, not a second delivery
path, so what this assertion adds is the value and not extra coverage of the
client-id routing.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…5) (#20090) *PR Created by the Glary-Bot Agent* --- ## Why ComfyUI delivers a prompt's execution events only to the socket that submitted it. A local run the agent starts on our behalf is submitted by comfy-cli under its own freshly-minted id, so this tab is never told anything: no node highlights, no progress, and nothing in the Save node. Root cause for [PM-1875](https://linear.app/comfyorg/issue/PM-1875/local-no-canvas-highlights-showing-where-the-agent-is-in-the-workflow). ## What Send `api.clientId` as `client_id` on the turn POST, so the agent can submit those runs as this tab. Read ambiently in the REST client rather than threaded through `PostMessageInput` like every neighbouring field: it belongs to the socket, not to the message. It is `undefined` until the socket's first `status` frame, which `withoutUndefined` then omits — so a turn posted before the handshake simply behaves as it does today. Three lines of real change. `client_id` is in the cloud `openapi.yaml` (see the companion PR) and is typed locally only until the next `@comfyorg/ingest-types` release carries it; `client_message_id` is not in that spec at all and stays local, which the old comment implied otherwise. ## Verification - `agentRestClient.test.ts`: 75 passed, including two new cases — the id is on the wire when the socket has reported one, and the key is absent before it has. - Whole agent subtree: 2664 passed. The one failure (`agentSubgraphDefinitions.test.ts`, a lib0 stack-depth test) reproduces identically on `main`. - `oxfmt`, `oxlint --type-aware`, `eslint`, and `pnpm typecheck:app` all clean (pre-commit hook). - The cloud repo's cross-repo contract check (`scripts/check-ingest-fe-types.sh`) regenerated `@comfyorg/ingest-types` from the updated spec and typechecked this whole frontend against it: clean. End-to-end against a live local ComfyUI, submitting under the tab's own client id reproduces exactly what the agent will now do — the green running-node outline mid-run, and the images on the Save Image node afterwards. Screenshots below; the first is the current behaviour for comparison. ## Known limitation (pre-existing, not introduced here) The frontend applies `executed` against whatever graph the tab currently shows — `app.ts` has no `prompt_id`→workflow guard, and `executionStore.storeJob` is only called from our own `queuePrompt`, so an agent-submitted prompt is never bound to a workflow. Consequences: `isActiveWorkflowRunning` stays false for the run (one consumer — `LinearProgressBar` opacity), and switching tabs mid-run can land outputs on the wrong canvas. This is existing behaviour for any queued prompt, but agent turns are long, so the switch window is much wider. Worth a PM-1875 follow-up; deliberately out of scope here since fixing it means changing shared execution plumbing that governs native Run-button runs too. Part of a three-repo change with `Comfy-Org/comfy-cli#970` and `Comfy-Org/cloud#11874`. ## Screenshots    --- ## Rebased onto main (2026-10-20) Conflict resolved, behaviour unchanged. Generated `AgentPostMessageRequest` now has `client_id`, so the local type widening is gone. <details><summary>Full context for agent readers</summary> - Old head `4ae69b3559`, conflicting with `main`. Rebased onto `9725d28172`; the change is now one wire line (`client_id: api.clientId`) plus two unit cases and a per-test `clientId` reset (`mockReset` does not clear plain fields). - The docs-only commit `4ae69b3559` was dropped: the `TurnPostBody` comment it corrected no longer exists on `main`. The "typed locally" paragraph above is therefore historical. - `agentRestClient.test.ts`: 126 passed. Removing the wire line fails the new positive case. - Pre-commit task set run over the diff (`lint-staged --diff=origin/main...HEAD`: oxfmt, oxlint, eslint, server-facts, `typecheck:app`): clean. - Black-box: the stacked spec from #20091/#20097 (`browser_tests/tests/agent/agentLocalRunClientId.spec.ts`), applied on this head with two fixture adaptations for changes on `main`, passes 3/3 locally (`--project=cloud`). With the wire line removed it fails at the `client_id` wire assertion. Those adaptations belong to the dependents, not this PR. - The empty commit after it only re-fires CI: the first run after the rebase received the pre-rebase base SHA, so the server-fact gate diffed all of `main` since 2026-10-04. </details> --------- Co-authored-by: glary <glary@comfy.org>
…leanly Mechanical step with no net effect on the final tree; the six files come back two commits later, adapted to the parent. The parent branch has moved twice since this branch left it at d9e8a04: once for `fb7363829b`, which added turn-body schema validation and a stalled-run boundary to the two files this branch also edits, and once for the merge of origin/main that carried 257 commits of drift through all six. Merging that into this branch directly conflicts on every one of them. It also cannot be committed. The pre-commit hook hands lint-staged the whole merge result, lint-staged runs twelve concurrent `oxlint --type-aware` chunks, and the host's OOM killer takes tsgolint. Parking these six at the merge base makes the parent merge conflict-free, and git runs no pre-commit hook for a merge it commits itself — so the hook only ever sees this branch's own files.
… of two Re-applies this branch's own six-file delta on top of the merged parent, adapted. The parent's later work is kept intact: its turn-body schema validation, its `settleExecutionFrames` helper and its `COMFY_SOCKET_SID` rename are all left as the parent has them. This branch predates them and must not be read as reverting them. PM-1875 reported two symptoms, and the parent's spec only pins the first. The running outline says *which* node the agent's run has reached; the report was also about a number, progress "stuck at 0%". So the figure the queue overlay prints for that node is pinned here. The overlay prints two percentages — a whole-run total and the current node — and a text match on the overlay cannot tell them apart, which is why this needs a test id rather than `getByText`. `data-testid` is added to the current-node span, registered in `TestIds.queue`, and exposed as a scoped locator on QueuePanel. The expected figure is derived from the frame the fixture sends rather than hard-coded, so retuning the stall moves the expectation with it instead of failing with a figure that points nowhere. `STALLED_NODE_PROGRESS` makes `stallJob`'s existing defaults explicit at the call site for exactly that reason — the values are identical, so run behaviour is unchanged. The spec then asserts the step is a strict partial one, because a step of 0 would derive the expectation to the reported symptom itself and a step of `max` to a finished node. The unit test is moved onto the same test id, so deleting the attribute fails cheaply in vitest before it fails as a Playwright timeout. Proven rather than assumed: dropping the attribute from the component fails QueueOverlayActive.test.ts (1 failed / 3 passed) and restoring it passes 4/4. typecheck:browser is clean.
|
Superseded for the Agent test-only campaign by #21919, merged on main as 78492d6. The current browser_tests/tests/agent/agentLocalRunClientId.spec.ts now asserts the visible Current node progress state (25%) before completion, preserving this carrier’s distinct user-visible proof without retaining its conflicting stacked branch. |
Summary
PM-1875 was two symptoms in one report: a local run the agent starts leaves no running highlight on this canvas, and its progress sits at 0%. #20091 covers the highlight and the final output. This adds the number, so the 0% half of the report is pinned too.
Changes
data-testid="queue-progress-current-node-percent"on the span that prints it, because the overlay also prints a whole-run total and a text match on the overlay cannot tell the two figures apart. No behaviour change.QueueOverlayActive's unit test now locates by that id so removing it fails there first.Review Focus
Whether the assertion is worth its line, since the queue overlay reads the same
executionStoreprogress state the canvas outline reads. It is a second view over one delivery path, not a second path, so what it adds is the value rather than more coverage of the routing.Measured, not assumed. A run stalled mid-node reads
Total: 0%Current node:—25%, so an overlay-wide match on25%was satisfied by either figure, and it stayed green when the current node was forced to0%while the total read25%. The scoped assertion fails there withExpected: "25%" / Received: "0%". With the per-node figure dropped to 0 it fails the same way, which is the reported symptom.With #20090's line reverted the suite is red, but at the wire-identity assertion near the top of the test, not here. An earlier version of this description said it fails at this assertion, which was wrong.