Repository navigation
feat(agent): send this tab's ComfyUI client id with each turn (PM-1875) - #20090
Conversation
📦 Bundle: 11.6 MB gzip 🟢 -1 BDetailsSummary
Category Glance App Entry Points — 6.92 kB (baseline 6.92 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 3.4 MB (baseline 3.4 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 3 unchanged Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 783 kB (baseline 783 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 2 added / 2 removed / 32 unchanged User & Accounts — 155 kB (baseline 155 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 17 unchanged Editors & Dialogs — 366 kB (baseline 366 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 13 unchanged UI Components — 225 kB (baseline 225 kB) • ⚪ 0 BReusable component library chunks Status: 30 unchanged Data & Services — 1.21 MB (baseline 1.21 MB) • 🔴 +28 BStores, services, APIs, and repositories
Status: 1 added / 1 removed / 42 unchanged Utilities & Hooks — 1.02 MB (baseline 1.02 MB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 77 unchanged Vendor & Third-Party — 24.7 MB (baseline 24.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 20.6 MB (baseline 20.6 MB) • ⚪ 0 BBundles that do not match a named category
Status: 2 added / 2 removed / 685 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-20T16:51:19.573Z",
"gitSha": "1f3e5801651e8fe3b757a0718a9ad0d7379c0974",
"branch": "glary/agent-send-client-id",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.5169999999935,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.1759999999999997,
"layouts": 10,
"layoutDurationMs": 2.7860000000000005,
"taskDurationMs": 416.885,
"heapDeltaBytes": 11302252,
"heapUsedBytes": 109010412,
"domNodes": -180,
"jsHeapTotalBytes": 1925120,
"scriptDurationMs": 9.160000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2028.105000000096,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.894,
"layouts": 10,
"layoutDurationMs": 2.6750000000000003,
"taskDurationMs": 575.6479999999999,
"heapDeltaBytes": 21055904,
"heapUsedBytes": 118926676,
"domNodes": -200,
"jsHeapTotalBytes": 2764800,
"scriptDurationMs": 9.286000000000003,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1692.4579999999878,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.447,
"layouts": 9,
"layoutDurationMs": 2.3910000000000005,
"taskDurationMs": 747.672,
"heapDeltaBytes": -5644856,
"heapUsedBytes": 98504684,
"domNodes": -206,
"jsHeapTotalBytes": 3760128,
"scriptDurationMs": 138.959,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1710.328000000004,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.91,
"layouts": 9,
"layoutDurationMs": 2.396,
"taskDurationMs": 753.963,
"heapDeltaBytes": -943504,
"heapUsedBytes": 103298188,
"domNodes": -200,
"jsHeapTotalBytes": 2449408,
"scriptDurationMs": 141.999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1808.4819999999695,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.188000000000001,
"layouts": 12,
"layoutDurationMs": 3.099,
"taskDurationMs": 472.60999999999996,
"heapDeltaBytes": 409560,
"heapUsedBytes": 104087448,
"domNodes": 49,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 11.41,
"eventListeners": 42,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871556,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1699.3300000000318,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.529000000000001,
"layouts": 10,
"layoutDurationMs": 2.4699999999999998,
"taskDurationMs": 285.026,
"heapDeltaBytes": 22524284,
"heapUsedBytes": 120231068,
"domNodes": 49,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 10.655999999999999,
"eventListeners": 42,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 583.9750000000095,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.654,
"layouts": 9,
"layoutDurationMs": 2.5300000000000002,
"taskDurationMs": 418.734,
"heapDeltaBytes": 3640556,
"heapUsedBytes": 100694280,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 164.192,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 585.0639999999885,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.8080000000000003,
"layouts": 10,
"layoutDurationMs": 2.9319999999999995,
"taskDurationMs": 426.558,
"heapDeltaBytes": 4317812,
"heapUsedBytes": 110638472,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 165.353,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1118.5389999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 741.3779999999999,
"heapDeltaBytes": 22330140,
"heapUsedBytes": 127757960,
"domNodes": 0,
"jsHeapTotalBytes": 14843904,
"scriptDurationMs": 57.36199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 491,
"frameDurationMs": 32.844117647058816,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1123.5419999999863,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 791.32,
"heapDeltaBytes": 41073756,
"heapUsedBytes": 139558612,
"domNodes": 0,
"jsHeapTotalBytes": 15892480,
"scriptDurationMs": 56.67900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 479,
"frameDurationMs": 32.841176470588245,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.5240000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.9499999999999,
"heapDeltaBytes": -3262496,
"heapUsedBytes": 102716728,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 138.45499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 215,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 831.9730000000618,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.8599999999998,
"heapDeltaBytes": -3537476,
"heapUsedBytes": 103454056,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 130.81199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 207,
"frameDurationMs": 24.50882352941177,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8839.549000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7862.945,
"heapDeltaBytes": 10085076,
"heapUsedBytes": 121660532,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 6534.563999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 234,
"frameDurationMs": 28.4016077170418,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9072.475000000053,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8300.867999999999,
"heapDeltaBytes": 1757492,
"heapUsedBytes": 113089056,
"domNodes": 0,
"jsHeapTotalBytes": 17825792,
"scriptDurationMs": 6502.356,
"eventListeners": 0,
"totalBlockingTimeMs": 154,
"frameDurationMs": 27.60759878419453,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9286.828000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8481.534,
"heapDeltaBytes": 28657828,
"heapUsedBytes": 149786512,
"domNodes": -276,
"jsHeapTotalBytes": 30416896,
"scriptDurationMs": 6679.762999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 158,
"frameDurationMs": 28.25091463414634,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9193.70200000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8536.623000000001,
"heapDeltaBytes": 37520644,
"heapUsedBytes": 158850096,
"domNodes": -276,
"jsHeapTotalBytes": 32251904,
"scriptDurationMs": 6718.409000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 122,
"frameDurationMs": 29.007278481012655,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 274.2199999999855,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.655000000000001,
"layouts": 11,
"layoutDurationMs": 3.531,
"taskDurationMs": 250.74099999999999,
"heapDeltaBytes": -21523528,
"heapUsedBytes": 99013296,
"domNodes": -2363,
"jsHeapTotalBytes": -4313088,
"scriptDurationMs": 9.683,
"eventListeners": -633,
"totalBlockingTimeMs": 8,
"frameDurationMs": 24.23636363636359,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 261.3020000000006,
"styleRecalcs": 23,
"styleRecalcDurationMs": 15.442999999999998,
"layouts": 13,
"layoutDurationMs": 4.282,
"taskDurationMs": 242.587,
"heapDeltaBytes": -21449420,
"heapUsedBytes": 100172764,
"domNodes": -2363,
"jsHeapTotalBytes": -4218880,
"scriptDurationMs": 12.376000000000001,
"eventListeners": -633,
"totalBlockingTimeMs": 8,
"frameDurationMs": 24.23636363636359,
"p95FrameDurationMs": 99.90000000000055
},
{
"name": "large-graph-idle",
"durationMs": 2106.435000000033,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.526,
"layouts": 8,
"layoutDurationMs": 2.38,
"taskDurationMs": 680.8440000000002,
"heapDeltaBytes": -30735064,
"heapUsedBytes": 99741444,
"domNodes": -297,
"jsHeapTotalBytes": -1789952,
"scriptDurationMs": 34.861999999999995,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665079365079368,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2010.9170000000631,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.48000000000000037,
"layouts": 2,
"layoutDurationMs": 0.43999999999999984,
"taskDurationMs": 575.431,
"heapDeltaBytes": 12817172,
"heapUsedBytes": 105090340,
"domNodes": -296,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.89999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2218.6009999999783,
"styleRecalcs": 63,
"styleRecalcDurationMs": 7.606,
"layouts": 2,
"layoutDurationMs": 0.36399999999999977,
"taskDurationMs": 1565.098,
"heapDeltaBytes": 15803940,
"heapUsedBytes": 109380908,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 754.165,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666165413533836,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2131.219999999985,
"styleRecalcs": 64,
"styleRecalcDurationMs": 8.13,
"layouts": 2,
"layoutDurationMs": 0.5249999999999999,
"taskDurationMs": 1365.8300000000002,
"heapDeltaBytes": 16550208,
"heapUsedBytes": 110158660,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 776.7239999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666141732283467,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3475.584000000026,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.335999999999999,
"layouts": 62,
"layoutDurationMs": 10.152000000000001,
"taskDurationMs": 1485.659,
"heapDeltaBytes": 819436,
"heapUsedBytes": 95593844,
"domNodes": -272,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 744.118,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665865384615383,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3464.144000000033,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.043999999999999,
"layouts": 64,
"layoutDurationMs": 10.825,
"taskDurationMs": 1543.3500000000001,
"heapDeltaBytes": -16794092,
"heapUsedBytes": 94035184,
"domNodes": -272,
"jsHeapTotalBytes": -5402624,
"scriptDurationMs": 740.783,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.747087378640774,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3037.3050000000035,
"styleRecalcs": 40,
"styleRecalcDurationMs": 3.9569999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1920.127,
"heapDeltaBytes": 17938128,
"heapUsedBytes": 113296212,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 982.3789999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.851111111111116,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2947.065000000066,
"styleRecalcs": 41,
"styleRecalcDurationMs": 4.3870000000000005,
"layouts": 2,
"layoutDurationMs": 0.46699999999999997,
"taskDurationMs": 1904.252,
"heapDeltaBytes": 18380020,
"heapUsedBytes": 113657752,
"domNodes": -296,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 964.327,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.761142857142858,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2069.6250000000305,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.1510000000000002,
"layouts": 9,
"layoutDurationMs": 5.297000000000001,
"taskDurationMs": 508.9429999999999,
"heapDeltaBytes": -29979460,
"heapUsedBytes": 101063892,
"domNodes": -276,
"jsHeapTotalBytes": -5365760,
"scriptDurationMs": 34.446,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66532258064516,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2072.5009999999884,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.535,
"layouts": 7,
"layoutDurationMs": 2.6699999999999995,
"taskDurationMs": 666.693,
"heapDeltaBytes": -30232332,
"heapUsedBytes": 102061852,
"domNodes": -296,
"jsHeapTotalBytes": -2314240,
"scriptDurationMs": 33.1,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.801626016260165,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.3260000000182,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.300999999999999,
"layouts": 10,
"layoutDurationMs": 2.8310000000000004,
"taskDurationMs": 386.246,
"heapDeltaBytes": -137708,
"heapUsedBytes": 106094072,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 150.88100000000003,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 578.1559999999217,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.944999999999999,
"layouts": 9,
"layoutDurationMs": 2.2849999999999997,
"taskDurationMs": 424.705,
"heapDeltaBytes": -531036,
"heapUsedBytes": 105645212,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 142.109,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2024.0940000000478,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.621,
"layouts": 9,
"layoutDurationMs": 2.4659999999999997,
"taskDurationMs": 428.90000000000003,
"heapDeltaBytes": 7714280,
"heapUsedBytes": 107412532,
"domNodes": -218,
"jsHeapTotalBytes": 2449408,
"scriptDurationMs": 8.266,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2026.1780000000726,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.491,
"layouts": 9,
"layoutDurationMs": 2.3430000000000004,
"taskDurationMs": 404.80100000000004,
"heapDeltaBytes": -18592228,
"heapUsedBytes": 87709356,
"domNodes": -198,
"jsHeapTotalBytes": 2449408,
"scriptDurationMs": 8.108,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.65800000001,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.822000000000001,
"layouts": 8,
"layoutDurationMs": 2.1,
"taskDurationMs": 832.317,
"heapDeltaBytes": 922372,
"heapUsedBytes": 98650748,
"domNodes": -198,
"jsHeapTotalBytes": -266240,
"scriptDurationMs": 98.78700000000002,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.2279999999919,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.186,
"layouts": 10,
"layoutDurationMs": 2.563,
"taskDurationMs": 849.375,
"heapDeltaBytes": -1846800,
"heapUsedBytes": 107674960,
"domNodes": -218,
"jsHeapTotalBytes": 3289088,
"scriptDurationMs": 103.11,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1435.5540000000246,
"styleRecalcs": 18,
"styleRecalcDurationMs": 25.345,
"layouts": 5,
"layoutDurationMs": 15.017,
"taskDurationMs": 1021.4140000000002,
"heapDeltaBytes": 13863672,
"heapUsedBytes": 144560056,
"domNodes": 16030,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 32.596,
"eventListeners": 3244,
"totalBlockingTimeMs": 141,
"frameDurationMs": 19.594594594594607,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8487.96299999998,
"styleRecalcs": 246,
"styleRecalcDurationMs": 30.791,
"layouts": 4,
"layoutDurationMs": 1.1140000000000003,
"taskDurationMs": 5593.079000000001,
"heapDeltaBytes": 16456600,
"heapUsedBytes": 109652904,
"domNodes": -276,
"jsHeapTotalBytes": 1503232,
"scriptDurationMs": 2545.794,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698818897637796,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8370.438000000035,
"styleRecalcs": 250,
"styleRecalcDurationMs": 31.4,
"layouts": 8,
"layoutDurationMs": 2.259,
"taskDurationMs": 5662.362,
"heapDeltaBytes": -34608584,
"heapUsedBytes": 94821556,
"domNodes": -296,
"jsHeapTotalBytes": -1265664,
"scriptDurationMs": 2515.605,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699201596806386,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 22918.360000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22573.146999999997,
"heapDeltaBytes": -21683744,
"heapUsedBytes": 294667204,
"domNodes": -3343,
"jsHeapTotalBytes": 5492736,
"scriptDurationMs": 328.163,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.363898916967514,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 16512.142999999924,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15489.232999999998,
"heapDeltaBytes": -14690608,
"heapUsedBytes": 296769612,
"domNodes": -3343,
"jsHeapTotalBytes": 8900608,
"scriptDurationMs": 250.26500000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.426678141135977,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 28192.413999999986,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.61500000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27773.424,
"heapDeltaBytes": -17832940,
"heapUsedBytes": 307514332,
"domNodes": -3343,
"jsHeapTotalBytes": 10403840,
"scriptDurationMs": 891.126,
"eventListeners": -651,
"totalBlockingTimeMs": 29,
"frameDurationMs": 52.60970149253731,
"p95FrameDurationMs": 116.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 20066.622000000054,
"styleRecalcs": 162,
"styleRecalcDurationMs": 16.473000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19635.459000000003,
"heapDeltaBytes": -25473520,
"heapUsedBytes": 299612172,
"domNodes": -3343,
"jsHeapTotalBytes": 19386368,
"scriptDurationMs": 827.9319999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 4,
"frameDurationMs": 36.95377532228361,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8262.229000000047,
"styleRecalcs": 20,
"styleRecalcDurationMs": 57.55299999999999,
"layouts": 20,
"layoutDurationMs": 22.31699999999999,
"taskDurationMs": 8129.075999999999,
"heapDeltaBytes": -30969340,
"heapUsedBytes": 280078500,
"domNodes": -3343,
"jsHeapTotalBytes": 4706304,
"scriptDurationMs": 128.979,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.419780219780215,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 6036.698000000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.262999999999984,
"layouts": 20,
"layoutDurationMs": 23.23,
"taskDurationMs": 5892.386,
"heapDeltaBytes": -36002544,
"heapUsedBytes": 274629304,
"domNodes": -3343,
"jsHeapTotalBytes": 4444160,
"scriptDurationMs": 105.92999999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.911309523809514,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8247.635000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7801.482000000002,
"heapDeltaBytes": -8679240,
"heapUsedBytes": 284304676,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 126.77,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.96474576271187,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11419.72199999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11160.753999999999,
"heapDeltaBytes": 14767332,
"heapUsedBytes": 295830380,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.40699999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.23092783505154,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "workflow-execution",
"durationMs": 132.89300000002413,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.933,
"layouts": 10,
"layoutDurationMs": 4.251,
"taskDurationMs": 99.54100000000001,
"heapDeltaBytes": 4899080,
"heapUsedBytes": 106266996,
"domNodes": 109,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.732999999999997,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 98.32500000004529,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.984999999999999,
"layouts": 7,
"layoutDurationMs": 1.917,
"taskDurationMs": 68.626,
"heapDeltaBytes": 4668232,
"heapUsedBytes": 102438600,
"domNodes": 98,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.7120000000000015,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 416.14400000003116,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.725,
"layouts": 76,
"layoutDurationMs": 14.519,
"taskDurationMs": 376.839,
"heapDeltaBytes": -14262260,
"heapUsedBytes": 78715480,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 176.784,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 463.9720000000125,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.857,
"layouts": 76,
"layoutDurationMs": 14.734,
"taskDurationMs": 417.09799999999996,
"heapDeltaBytes": -13930212,
"heapUsedBytes": 80208692,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 198.61599999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241396,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 463.87700000002496,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.7440000000000002,
"layouts": 76,
"layoutDurationMs": 13.078,
"taskDurationMs": 425.77299999999997,
"heapDeltaBytes": -79876,
"heapUsedBytes": 118038888,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.517,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 489.99400000002424,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.759,
"layouts": 76,
"layoutDurationMs": 14.252,
"taskDurationMs": 446.61,
"heapDeltaBytes": 424432,
"heapUsedBytes": 119266544,
"domNodes": 4,
"jsHeapTotalBytes": 1961984,
"scriptDurationMs": 172.61499999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.24482758620691,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 64.0% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2962 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1562a796d270d8ac18243e9ea7ee80cf5be31afd
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (115)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20090 +/- ##
==========================================
+ Coverage 86.51% 87.46% +0.95%
==========================================
Files 3876 2713 -1163
Lines 180447 150297 -30150
Branches 47829 41358 -6471
==========================================
- Hits 156106 131458 -24648
+ Misses 22075 18316 -3759
+ Partials 2266 523 -1743
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1170 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Thanks for the review. No inline findings came through on my side, and I'm declining the two optional "Finishing Touches" — auto-generated docstrings and tests would duplicate what's already here deliberately: the one comment on the new field exists to distinguish Re-verified against the final commit after your run:
One thing worth a reviewer's eye, since it is the real limitation of this approach rather than of this diff: routing an agent run's events to the tab means they are interpreted against whatever graph the tab currently shows. Companion PRs: |
ComfyUI delivers a prompt's execution events only to the socket that submitted it. A local run the agent starts on our behalf is submitted by comfy-cli under its own id, so the canvas shows no node highlights, no progress and no outputs for it (PM-1875). Send api.clientId on the turn POST so the agent can submit those runs as this tab. Read ambiently in the REST client rather than threaded through PostMessageInput: it belongs to the socket, not to the message, and it is undefined until the socket's first status frame, which withoutUndefined then omits. The generated AgentPostMessageRequest already carries client_id, so no local type widening is needed.
4ae69b3 to
92985f3
Compare
This comment has been minimized.
This comment has been minimized.
The force-pushed conflict resolution fired its pull_request event with the PR's pre-rebase base SHA, so the server-fact gate diffed all of main since 2026-10-04 and flagged files this PR does not touch.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit d63e2f1 has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
## Summary Adapts the black-box PM-1875 regression pin from Comfy-Org#20091 onto current `main`, preserving the existing agent execution helpers while proving that a local Agent-started run is addressed to the initiating tab's current socket ID. The visible contract is exercised across two independently connected canvases: both retain the queue record, while only the addressed canvas shows the executing outline and final output. This is test and harness coverage only; the product fix is already on `main` from Comfy-Org#20090. It supersedes the conflicted carrier Comfy-Org#20091. ## Verification - Fresh mutation check on `e910ac2e8e`: temporarily removing `client_id: api.clientId` from `agentRestClient.ts` made the two-canvas `agentLocalRunClientId.spec.ts` case fail at the wire assertion because `client_id` was absent; restoring the line made the same case pass (1/1). - Targeted black-box run: `PLAYWRIGHT_SETUP_API_URL=http://localhost:8194 PLAYWRIGHT_TEST_URL=http://localhost:6244 DISTRIBUTION=cloud pnpm exec playwright test browser_tests/tests/agent/agentLocalRunClientId.spec.ts --project=cloud --workers=1 --repeat-each=3` — 9 passed. - Shared-helper coverage after routing `deliverOutput()` through the same address check: `agentExecutionLifecycle.spec.ts`, `agentGoldenPathRunIt.spec.ts`, `agentJobReopenedAsWorkflow.spec.ts`, and `agentRunOutputsStayOnOwnerTab.spec.ts` — 7 passed. - `pnpm typecheck:browser` — passed. - Commit and push hooks — passed, including formatting, type-aware lint, server-facts, browser typecheck, dependency-cruiser, knip, and changed-file fallow audit. - Original proof from Comfy-Org#20091: the case was red at both canvas assertions and its wire assertion on merge-base `e019a32c93`, then green 3/3 on the Comfy-Org#20090 fix head `4ae69b35`; changing the request back to `api.clientId ?? api.initialClientId` made the stale-ID case red. Environment: Linux x86_64, Node 26.10.0, pnpm 11.13.1, frontend source base `e910ac2e8ed05ebf5d5cd6fb79025e9e5d8fc625`. This used the mocked frontend black-box Agent harness; no packaged Agent build or real Agent turn was exercised.
PR Created by the Glary-Bot Agent
Why
ComfyUI delivers a prompt's execution events only to the socket that submitted it. A local run the agent starts on our behalf is submitted by comfy-cli under its own freshly-minted id, so this tab is never told anything: no node highlights, no progress, and nothing in the Save node. Root cause for PM-1875.
What
Send
api.clientIdasclient_idon the turn POST, so the agent can submit those runs as this tab.Read ambiently in the REST client rather than threaded through
PostMessageInputlike every neighbouring field: it belongs to the socket, not to the message. It isundefineduntil the socket's firststatusframe, whichwithoutUndefinedthen omits — so a turn posted before the handshake simply behaves as it does today.Three lines of real change.
client_idis in the cloudopenapi.yaml(see the companion PR) and is typed locally only until the next@comfyorg/ingest-typesrelease carries it;client_message_idis not in that spec at all and stays local, which the old comment implied otherwise.Verification
agentRestClient.test.ts: 75 passed, including two new cases — the id is on the wire when the socket has reported one, and the key is absent before it has.agentSubgraphDefinitions.test.ts, a lib0 stack-depth test) reproduces identically onmain.oxfmt,oxlint --type-aware,eslint, andpnpm typecheck:appall clean (pre-commit hook).scripts/check-ingest-fe-types.sh) regenerated@comfyorg/ingest-typesfrom the updated spec and typechecked this whole frontend against it: clean.End-to-end against a live local ComfyUI, submitting under the tab's own client id reproduces exactly what the agent will now do — the green running-node outline mid-run, and the images on the Save Image node afterwards. Screenshots below; the first is the current behaviour for comparison.
Known limitation (pre-existing, not introduced here)
The frontend applies
executedagainst whatever graph the tab currently shows —app.tshas noprompt_id→workflow guard, andexecutionStore.storeJobis only called from our ownqueuePrompt, so an agent-submitted prompt is never bound to a workflow. Consequences:isActiveWorkflowRunningstays false for the run (one consumer —LinearProgressBaropacity), and switching tabs mid-run can land outputs on the wrong canvas. This is existing behaviour for any queued prompt, but agent turns are long, so the switch window is much wider. Worth a PM-1875 follow-up; deliberately out of scope here since fixing it means changing shared execution plumbing that governs native Run-button runs too.Part of a three-repo change with
Comfy-Org/comfy-cli#970andComfy-Org/cloud#11874.Screenshots
Rebased onto main (2026-10-20)
Conflict resolved, behaviour unchanged. Generated
AgentPostMessageRequestnow hasclient_id, so the local type widening is gone.Full context for agent readers
4ae69b3559, conflicting withmain. Rebased onto9725d28172; the change is now one wire line (client_id: api.clientId) plus two unit cases and a per-testclientIdreset (mockResetdoes not clear plain fields).4ae69b3559was dropped: theTurnPostBodycomment it corrected no longer exists onmain. The "typed locally" paragraph above is therefore historical.agentRestClient.test.ts: 126 passed. Removing the wire line fails the new positive case.lint-staged --diff=origin/main...HEAD: oxfmt, oxlint, eslint, server-facts,typecheck:app): clean.browser_tests/tests/agent/agentLocalRunClientId.spec.ts), applied on this head with two fixture adaptations for changes onmain, passes 3/3 locally (--project=cloud). With the wire line removed it fails at theclient_idwire assertion. Those adaptations belong to the dependents, not this PR.mainsince 2026-10-04.