Repository navigation
[backport cloud/1.55] fix(litegraph): recover graph ID allocation safely (#19239) - #20093
Conversation
Restores safe graph-ID allocation through `Number.MAX_SAFE_INTEGER` while preserving collision checks and atomic clipboard/subgraph paste behavior. This head is based on current `main`; the merge required no manual resolution, and the follow-up commits add no production delta relative to current `main`. - Removes the former fixed ID ceiling without changing the reserved-ID partition. - Keeps collision recovery across root graphs and subgraphs for nodes, links, groups, and reroutes. - Preserves atomic paste rollback and arbitrary thrown JavaScript values across operation and finalization failures. - Consolidates the safe-ID regression fixtures and strengthens the boundary/collision assertions. Please verify allocation at the final safe integer, forward collision recovery from high counters, and atomic rollback around lifecycle failures. The retained fixture is a synthetic reproducer around two observed high-range values; it does not claim to reproduce a complete production graph or establish telemetry provenance. Local validation on Node 26.10.0 at `39d8e611acc71cbda701564432c41ed0b8f2b769`: ```sh NODE_OPTIONS=--no-experimental-webstorage pnpm vitest run \ src/composables/useCopy.test.ts src/composables/usePaste.test.ts \ src/extensions/core/groupNode.test.ts src/extensions/core/widgetInputs.test.ts \ src/lib/litegraph/src/LGraph.failedConfigure.test.ts src/lib/litegraph/src/LGraph.test.ts \ src/lib/litegraph/src/LGraphCanvas.clipboard.test.ts src/lib/litegraph/src/canvas/linkBadges.test.ts \ src/lib/litegraph/src/idAllocation.property.test.ts src/lib/litegraph/src/idAllocation.test.ts \ src/lib/litegraph/src/subgraph/subgraphDeduplication.test.ts \ src/platform/workflow/validation/schemas/workflowSchema.test.ts \ src/stores/entityIdStore.test.ts ``` 13 files, 430 tests passed. ```sh PLAYWRIGHT_TEST_URL=http://localhost:6255 pnpm exec playwright test \ browser_tests/tests/subgraph/subgraphNested.spec.ts --project=chromium \ -g 'Loads and queues without nested promotion resolution failures' ``` 1 test passed against a containerized ComfyUI backend. The full spec discovers 8 Chromium tests. `pnpm typecheck:app` and `pnpm typecheck:browser` passed. Targeted ESLint reported 0 errors and 10 inherited `import-x/no-restricted-paths` warnings in `LGraph.test.ts`. - Reintroducing the historical `1e15` ceiling made the reserved-range configure regression and the exact collision-recovery property fail with `Node ID space exhausted`; both pass after restoring production code. - Mutating collision recovery to return `1` made the property fail (`expected lastId + 2, received 1`); it passes after restoring forward recovery. - The original parent/main comparison remains author-reported: before the fix, the high-counter workflow aborted during ID remapping; at this head the Chromium queueing case passes. --------- Co-authored-by: Amp <amp@ampcode.com> (cherry picked from commit ec90e0a)
Release-line adaptation only. No change to ID allocation semantics, to the reserved-mint recovery behaviour, or to any assertion carried from #19239. Four divergences between `main` and `cloud/1.55`, each resolved toward the release line rather than by importing unrelated `main` content: - `LGraphCanvas.ts`: drop the `SelectionView` / `SelectionViewCache` declarations. They belong to `main`'s selection-store refactor, which this line does not have; `SelectedItemsView` is undefined here. The PR-authored `InitializedClipboardItems` and `ClipboardPasteContext` are kept, as the rewritten paste path uses them. - `LGraphCanvas.ts`: drop `surface: 'graph'` from the two `reportError` calls in `rollbackClipboardPaste`. `surface` is a required field of `ReportErrorOptions` on `main` only — it does not exist on this line's `src/platform/telemetry/reportError.ts`. Rollback behaviour is unchanged; only a telemetry dimension this line does not model is omitted. - `usePaste.test.ts` / `groupNode.test.ts`: drop the `pastedClipboard`, `mountRichTextEditor`, `readFileSync` and `join` helpers. Their consuming cases are not on this line, so they are unused here. `clipboardHtml` is kept (6 call sites). Two files in #19239 do not exist on `cloud/1.55` and were resolved as deleted; both changes were incidental to this fix (a `try`/`finally` around `use(page)` in `webSessionFixture.ts`, and zod `TWidgetValue` typing in `templateInputService.ts`).
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2150 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (39 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since dc3c557066caede3ea7a7e8f768b8025445b0ee1
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-04T11:15:17.357Z",
"gitSha": "3b51d5e65be7ab366a2f3507fcfb2386c49de6f3",
"branch": "backport-19239-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.5380000000441,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.651999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 350.783,
"heapDeltaBytes": -7821560,
"heapUsedBytes": 60980868,
"domNodes": -259,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.245000000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 1991.5090000000646,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.276,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 238.447,
"heapDeltaBytes": -1007764,
"heapUsedBytes": 61179604,
"domNodes": 21,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 5.043000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1707.5929999999744,
"styleRecalcs": 47,
"styleRecalcDurationMs": 15.499999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 620.2749999999999,
"heapDeltaBytes": 8859960,
"heapUsedBytes": 77542648,
"domNodes": -259,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 122.84899999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1692.9859999999053,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.592999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.4959999999999,
"heapDeltaBytes": -8741856,
"heapUsedBytes": 60015652,
"domNodes": -257,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 101.023,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.6010000000028,
"styleRecalcs": 30,
"styleRecalcDurationMs": 20.613,
"layouts": 6,
"layoutDurationMs": 1.1329999999999998,
"taskDurationMs": 301.951,
"heapDeltaBytes": 3329564,
"heapUsedBytes": 72205772,
"domNodes": 79,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 15.578,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1691.9450000000325,
"styleRecalcs": 28,
"styleRecalcDurationMs": 14.923,
"layouts": 6,
"layoutDurationMs": 1.0769999999999997,
"taskDurationMs": 259.96000000000004,
"heapDeltaBytes": 3321260,
"heapUsedBytes": 71882124,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.738999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 514.7590000000264,
"styleRecalcs": 15,
"styleRecalcDurationMs": 8.796,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 349.49699999999996,
"heapDeltaBytes": 18506136,
"heapUsedBytes": 86596884,
"domNodes": 21,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 121.02499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 444.88699999999426,
"styleRecalcs": 16,
"styleRecalcDurationMs": 8.685,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 296.10800000000006,
"heapDeltaBytes": 18199636,
"heapUsedBytes": 86601756,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 109.167,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 922.5759999999923,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 561.8960000000001,
"heapDeltaBytes": 25516668,
"heapUsedBytes": 96990944,
"domNodes": -292,
"jsHeapTotalBytes": 20598784,
"scriptDurationMs": 37.526999999999994,
"eventListeners": -217,
"totalBlockingTimeMs": 312,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 919.0820000000031,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.895,
"heapDeltaBytes": 26173920,
"heapUsedBytes": 97682132,
"domNodes": -291,
"jsHeapTotalBytes": 20598784,
"scriptDurationMs": 35.504999999999995,
"eventListeners": -217,
"totalBlockingTimeMs": 308,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 700.7409999999936,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 330.34799999999984,
"heapDeltaBytes": 14871304,
"heapUsedBytes": 91509488,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 107.39400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 92,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 687.4990000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 252.21099999999996,
"heapDeltaBytes": 14784140,
"heapUsedBytes": 90867168,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 86.612,
"eventListeners": 0,
"totalBlockingTimeMs": 84,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6771.5059999999885,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.1030000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5762.777,
"heapDeltaBytes": -8286604,
"heapUsedBytes": 71437988,
"domNodes": -272,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 4522.125,
"eventListeners": -174,
"totalBlockingTimeMs": 40,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6072.3520000000235,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.2840000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4834.6720000000005,
"heapDeltaBytes": 4167596,
"heapUsedBytes": 85565580,
"domNodes": -14,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 3852.375,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6533.838000000003,
"styleRecalcs": 3,
"styleRecalcDurationMs": 6.364999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5405.679999999999,
"heapDeltaBytes": 1853228,
"heapUsedBytes": 81368040,
"domNodes": -269,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 4172.5289999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6239.968999999974,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.2040000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4984.71,
"heapDeltaBytes": -8467468,
"heapUsedBytes": 73380380,
"domNodes": -14,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 3998.88,
"eventListeners": 0,
"totalBlockingTimeMs": 10,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2026.141999999993,
"styleRecalcs": 10,
"styleRecalcDurationMs": 12.242,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.14099999999996,
"heapDeltaBytes": -23340192,
"heapUsedBytes": 66466964,
"domNodes": -250,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 35.12199999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2016.4969999999585,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.550999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 303.732,
"heapDeltaBytes": -15445336,
"heapUsedBytes": 73381292,
"domNodes": -236,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 22.361999999999995,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2166.8019999999615,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.402,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1210.45,
"heapDeltaBytes": 1128408,
"heapUsedBytes": 91787692,
"domNodes": -251,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 599.7479999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2134.315000000015,
"styleRecalcs": 71,
"styleRecalcDurationMs": 16.151,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1067.281,
"heapDeltaBytes": -3024544,
"heapUsedBytes": 80075464,
"domNodes": -254,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 560.757,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3123.962000000006,
"styleRecalcs": 71,
"styleRecalcDurationMs": 15.488999999999999,
"layouts": 60,
"layoutDurationMs": 15.262999999999998,
"taskDurationMs": 1173.065,
"heapDeltaBytes": 135500,
"heapUsedBytes": 65950040,
"domNodes": 36,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 529.172,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3173.0159999999614,
"styleRecalcs": 74,
"styleRecalcDurationMs": 17.108999999999998,
"layouts": 60,
"layoutDurationMs": 16.464,
"taskDurationMs": 1210.1290000000001,
"heapDeltaBytes": -12565924,
"heapUsedBytes": 72191804,
"domNodes": -233,
"jsHeapTotalBytes": 5009408,
"scriptDurationMs": 570.3180000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2306.5540000000055,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1442.6839999999997,
"heapDeltaBytes": -16567796,
"heapUsedBytes": 76618852,
"domNodes": 16,
"jsHeapTotalBytes": 8687616,
"scriptDurationMs": 746.5860000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2146.8150000000605,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.612000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1131.486,
"heapDeltaBytes": 6681864,
"heapUsedBytes": 72856444,
"domNodes": 12,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 656.27,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2036.0579999999686,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.189,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.712,
"heapDeltaBytes": -23683040,
"heapUsedBytes": 67842732,
"domNodes": -249,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 30.976000000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.9429999999884,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.578999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.69,
"heapDeltaBytes": -24285440,
"heapUsedBytes": 67121084,
"domNodes": -253,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 29.185000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 445.3889999999774,
"styleRecalcs": 49,
"styleRecalcDurationMs": 11.447999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 287.97700000000003,
"heapDeltaBytes": 12916376,
"heapUsedBytes": 83840828,
"domNodes": 23,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 101.538,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 426.93599999995513,
"styleRecalcs": 50,
"styleRecalcDurationMs": 11.924999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 284.355,
"heapDeltaBytes": 13901044,
"heapUsedBytes": 84472216,
"domNodes": 25,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 100.922,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1991.072000000031,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.884,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.19499999999994,
"heapDeltaBytes": 8900136,
"heapUsedBytes": 79470456,
"domNodes": -275,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.578,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2005.0599999999577,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.492000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 295.48699999999997,
"heapDeltaBytes": -10630876,
"heapUsedBytes": 60574264,
"domNodes": -272,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 5.292,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.3609999999621,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.848,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.0110000000001,
"heapDeltaBytes": 18592812,
"heapUsedBytes": 81871832,
"domNodes": 19,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 94.69800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.2100000000592,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.985999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.45700000000005,
"heapDeltaBytes": -10871536,
"heapUsedBytes": 59882964,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 75.384,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 751.1380000000258,
"styleRecalcs": 19,
"styleRecalcDurationMs": 17.820000000000004,
"layouts": 5,
"layoutDurationMs": 7.532000000000001,
"taskDurationMs": 530.99,
"heapDeltaBytes": 20151484,
"heapUsedBytes": 103400740,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 17.723999999999997,
"eventListeners": 2383,
"totalBlockingTimeMs": 53,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8272.804000000007,
"styleRecalcs": 250,
"styleRecalcDurationMs": 45.449999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4168.047,
"heapDeltaBytes": -1007804,
"heapUsedBytes": 87994756,
"domNodes": -238,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 2052.345,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8207.464999999956,
"styleRecalcs": 250,
"styleRecalcDurationMs": 47.24,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3772.582,
"heapDeltaBytes": -16636760,
"heapUsedBytes": 65779888,
"domNodes": -253,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 1911.848,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 11913.160000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11711.696999999998,
"heapDeltaBytes": -27212700,
"heapUsedBytes": 198722988,
"domNodes": -8062,
"jsHeapTotalBytes": -17379328,
"scriptDurationMs": 172.67100000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12581.847000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12369.795000000002,
"heapDeltaBytes": -58188324,
"heapUsedBytes": 182310420,
"domNodes": -8062,
"jsHeapTotalBytes": -14798848,
"scriptDurationMs": 184.03799999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14488.445000000012,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.964000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14359.979,
"heapDeltaBytes": -22311736,
"heapUsedBytes": 197321928,
"domNodes": -8062,
"jsHeapTotalBytes": -10039296,
"scriptDurationMs": 639.7429999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 31,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14439.190999999937,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.978999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14293.043000000001,
"heapDeltaBytes": -48418608,
"heapUsedBytes": 177963504,
"domNodes": -8062,
"jsHeapTotalBytes": -16785408,
"scriptDurationMs": 622.073,
"eventListeners": -14928,
"totalBlockingTimeMs": 2,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4420.400000000029,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.41299999999998,
"layouts": 20,
"layoutDurationMs": 24.117,
"taskDurationMs": 4384.654000000001,
"heapDeltaBytes": -48189292,
"heapUsedBytes": 171715652,
"domNodes": -8062,
"jsHeapTotalBytes": 8118272,
"scriptDurationMs": 71.974,
"eventListeners": -14928,
"totalBlockingTimeMs": 124,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3832.4969999999894,
"styleRecalcs": 20,
"styleRecalcDurationMs": 57.093,
"layouts": 20,
"layoutDurationMs": 25.64999999999999,
"taskDurationMs": 3784.562,
"heapDeltaBytes": -33546436,
"heapUsedBytes": 200527108,
"domNodes": -8062,
"jsHeapTotalBytes": 19279872,
"scriptDurationMs": 69.69099999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 55,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6182.070000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6084.763000000001,
"heapDeltaBytes": 13097508,
"heapUsedBytes": 191270948,
"domNodes": -4,
"jsHeapTotalBytes": -24117248,
"scriptDurationMs": 90.304,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5964.767000000052,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5861.193,
"heapDeltaBytes": -17185552,
"heapUsedBytes": 185580656,
"domNodes": 0,
"jsHeapTotalBytes": -33292288,
"scriptDurationMs": 85.17000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 414.8050000000012,
"styleRecalcs": 16,
"styleRecalcDurationMs": 17.396,
"layouts": 3,
"layoutDurationMs": 0.925,
"taskDurationMs": 83.183,
"heapDeltaBytes": 5036200,
"heapUsedBytes": 71464408,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.231000000000002,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 420.46400000003814,
"styleRecalcs": 15,
"styleRecalcDurationMs": 18.026,
"layouts": 3,
"layoutDurationMs": 0.909,
"taskDurationMs": 88.177,
"heapDeltaBytes": 4992576,
"heapUsedBytes": 71634748,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.349999999999998,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.55 #20093 +/- ##
=============================================
Coverage ? 84.94%
=============================================
Files ? 2327
Lines ? 133458
Branches ? 36067
=============================================
Hits ? 113367
Misses ? 19729
Partials ? 362
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Release-backport review at exact head 5befe57 under program/release-backport-authority.md: compared the live 35-file carrier with merged source #19239 and the documented five-file conflict adaptation. The release-only divergences drop main-only selection-store, telemetry-type, unused-helper, and absent-file hunks without changing safe-ID allocation semantics or weakening the red-on-parent browser proof. Required checks test, lint-and-format, and e2e-status pass; the target-aware gate reports cloud/1.55@dc3c557066caede3ea7a7e8f768b8025445b0ee1 is an ancestor of this head, all 119 statuses are terminal non-adverse, and there are no unresolved reviewer objections.
…ly (#19239) (#20132) ## Summary Backports [#19239](#19239) (restores safe graph-ID allocation through `Number.MAX_SAFE_INTEGER`) to `core/1.55`. This carries the release-adapted implementation already merged into [`cloud/1.55` via #20093](#20093). The cherry-pick applied cleanly to the current `core/1.55` branch. ## Verification - focused graph allocation, paste, subgraph, workflow-schema, and entity-ID suite: 13 files, 424 tests passed - pre-push Knip gate passed Tracked by [FE-3007](https://linear.app/comfyorg/issue/FE-3007/e15-node-id-space-exhausted-explains-the-intermittent-cloud-copy-paste). Justification: release backport of the reviewed safe-ID fix, using the release-adapted implementation already running on `cloud/1.55`. --------- Co-authored-by: Amp <amp@ampcode.com>
Why
cloud/1.55is the line production runs, and it still throwsNode ID space exhausted.#19239 fixed this on
mainon2026-10-01, but all four backports failed on cherry-pick conflicts the same minute it merged
(bot comments at 16:43:57Z–16:44:02Z), and the manual handoff those comments asked for was never
picked up. Three days later the defect is still live: a fresh
cloud-frontend-prodalert fired at2026-10-04T10:22:51Z on release 1.55.16
(Sentry
CLOUD-FRONTEND-PROD-225, event2cdb104c0d5649daa34f7d9bb6195edf), terminating at the samefindNextAvailableIdthrow site asthe rest of the family.
The conflict was partly the stacking conflict the bot guessed at — the five PRs it named have all
merged since, which cut the conflict set from ~15 files to 5. The remaining 5 are real and resolved
by hand here.
What this is
A
-xcherry-pick ofec90e0aplus one clearly-scoped adaptation commit. No change to IDallocation semantics, to reserved-mint recovery, or to any assertion carried from #19239.
Four
main-only divergences, each resolved toward the release line rather than by importingunrelated
maincontent:SelectionView/SelectionViewCacheinLGraphCanvas.tsmain's selection-store refactor, absent here;SelectedItemsViewis undefined on this line. The PR-authoredInitializedClipboardItemsandClipboardPasteContextare kept, as the rewritten paste path uses them.surface: 'graph'on tworeportErrorcalls inrollbackClipboardPastesurfaceis a required field ofReportErrorOptionsonmainonly. Rollback behaviour unchanged; only a telemetry dimension this line does not model is omitted.pastedClipboard,mountRichTextEditor,readFileSync,jointest helpersclipboardHtmlis kept (6 call sites).webSessionFixture.ts,templateInputService.tscloud/1.55; resolved as deleted. Both of #19239's changes to them were incidental to this fix (atry/finallyarounduse(page); zodTWidgetValuetyping).Verification on the exact head (
5befe57)pnpm typecheck— 0 errors.idAllocation,idAllocation.property,subgraphDeduplication,LGraph,LGraph.failedConfigure,LGraphCanvas.clipboard,usePaste,useCopy,groupNode,widgetInputs,entityIdStore,linkBadges,workflowSchema).eslinton every changed file — 0 errors (58 inherited layer warnings, matching fix(litegraph): recover graph ID allocation safely #19239).Red proof on the parent, using the real production IDs. On pristine
origin/cloud/1.55a graphwhose counters sit at the two IDs that actually appear in
cloud-frontend-prodtelemetry for thisfamily —
4462758126524329(appcrdt-disjointmint, bit 41) and7729209487955825(agent2**40 | random52mint, bit 40) — throwsNode ID space exhausted. On this branch the equivalentcase asserts
.not.toThrow()and passes as part of the 425.The black-box regression proof is preserved:
browser_tests/assets/subgraphs/subgraph-nested-duplicate-ids.jsoncarries those same two IDs as
last_node_id/last_link_id, and is consumed bysubgraphNested.spec.tsandsubgraphSerialization.spec.ts.Scope
cloud/1.55only — the line production runs and the line the live alert came from.cloud/1.54,core/1.54andcore/1.55still carry the ceiling (MAX_ID = 100_000_000atsrc/lib/litegraph/src/subgraph/subgraphDeduplication.ts:32) and need the same treatment; theirconflict sets differ per branch.
Tracked by FE-3007.
Justification: Production release backport of the human-reviewed #19239 safe-ID fix after all automated backports failed — scope is limited to cloud/1.55, the release adaptations preserve semantics and assertions, the production-ID browser regression proof is retained, and all exact-head required checks plus the target-aware gate pass.