Repository navigation
[backport core/1.55] fix(litegraph): recover graph ID allocation safely (#19239) - #20132
Conversation
…ely (#19239) (#20093) ## Why `cloud/1.55` is the line production runs, and it still throws `Node ID space exhausted`. [#19239](#19239) fixed this on `main` on 2026-10-01, but **all four backports failed on cherry-pick conflicts** the same minute it merged (bot comments at 16:43:57Z–16:44:02Z), and the manual handoff those comments asked for was never picked up. Three days later the defect is still live: a fresh `cloud-frontend-prod` alert fired at **2026-10-04T10:22:51Z** on release **1.55.16** ([Sentry `CLOUD-FRONTEND-PROD-225`](https://comfy-org.sentry.io/issues/7772166974/), event `2cdb104c0d5649daa34f7d9bb6195edf`), terminating at the same `findNextAvailableId` throw site as the rest of the family. The conflict was partly the stacking conflict the bot guessed at — the five PRs it named have all merged since, which cut the conflict set from ~15 files to 5. The remaining 5 are real and resolved by hand here. ## What this is A `-x` cherry-pick of `ec90e0a` plus one clearly-scoped adaptation commit. **No change to ID allocation semantics, to reserved-mint recovery, or to any assertion carried from #19239.** Four `main`-only divergences, each resolved toward the release line rather than by importing unrelated `main` content: | Divergence | Resolution | |---|---| | `SelectionView` / `SelectionViewCache` in `LGraphCanvas.ts` | Dropped — they belong to `main`'s selection-store refactor, absent here; `SelectedItemsView` is undefined on this line. The PR-authored `InitializedClipboardItems` and `ClipboardPasteContext` are kept, as the rewritten paste path uses them. | | `surface: 'graph'` on two `reportError` calls in `rollbackClipboardPaste` | Dropped — `surface` is a required field of `ReportErrorOptions` on `main` only. Rollback behaviour unchanged; only a telemetry dimension this line does not model is omitted. | | `pastedClipboard`, `mountRichTextEditor`, `readFileSync`, `join` test helpers | Dropped — their consuming cases are not on this line, so they are unused here. `clipboardHtml` is kept (6 call sites). | | `webSessionFixture.ts`, `templateInputService.ts` | Do not exist on `cloud/1.55`; resolved as deleted. Both of #19239's changes to them were incidental to this fix (a `try`/`finally` around `use(page)`; zod `TWidgetValue` typing). | ## Verification on the exact head (`5befe57`) - `pnpm typecheck` — **0 errors**. - Focused suite — **13 files, 425 tests, all passing** (`idAllocation`, `idAllocation.property`, `subgraphDeduplication`, `LGraph`, `LGraph.failedConfigure`, `LGraphCanvas.clipboard`, `usePaste`, `useCopy`, `groupNode`, `widgetInputs`, `entityIdStore`, `linkBadges`, `workflowSchema`). - `eslint` on every changed file — **0 errors** (58 inherited layer warnings, matching #19239). **Red proof on the parent, using the real production IDs.** On pristine `origin/cloud/1.55` a graph whose counters sit at the two IDs that actually appear in `cloud-frontend-prod` telemetry for this family — `4462758126524329` (app `crdt-disjoint` mint, bit 41) and `7729209487955825` (agent `2**40 | random52` mint, bit 40) — throws `Node ID space exhausted`. On this branch the equivalent case asserts `.not.toThrow()` and passes as part of the 425. The black-box regression proof is preserved: `browser_tests/assets/subgraphs/subgraph-nested-duplicate-ids.json` carries those same two IDs as `last_node_id` / `last_link_id`, and is consumed by `subgraphNested.spec.ts` and `subgraphSerialization.spec.ts`. ## Scope `cloud/1.55` only — the line production runs and the line the live alert came from. `cloud/1.54`, `core/1.54` and `core/1.55` still carry the ceiling (`MAX_ID = 100_000_000` at `src/lib/litegraph/src/subgraph/subgraphDeduplication.ts:32`) and need the same treatment; their conflict sets differ per branch. Tracked by [FE-3007](https://linear.app/comfyorg/issue/FE-3007/e15-node-id-space-exhausted-explains-the-intermittent-cloud-copy-paste). Justification: Production release backport of the human-reviewed #19239 safe-ID fix after all automated backports failed — scope is limited to cloud/1.55, the release adaptations preserve semantics and assertions, the production-ID browser regression proof is retained, and all exact-head required checks plus the target-aware gate pass. --------- Co-authored-by: Amp <amp@ampcode.com> (cherry picked from commit b6c760c)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2149 passed, 0 failed · 1 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (39 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 21a2405b142dbe2f233b7f112a0cbcbe7dcd2c03
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-04T23:33:11.359Z",
"gitSha": "6b033e8694b57f951306dc10870c3b4ed0efdd33",
"branch": "bp19239-core155",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1990.774999999985,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.253000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 296.235,
"heapDeltaBytes": 7251088,
"heapUsedBytes": 75950560,
"domNodes": -257,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.507999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1990.600000000029,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.831000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.37,
"heapDeltaBytes": -12012228,
"heapUsedBytes": 56749264,
"domNodes": -259,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 11.134000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.3899999999985,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.244,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.91,
"heapDeltaBytes": -8809764,
"heapUsedBytes": 59852732,
"domNodes": -255,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 106.669,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1692.32199999999,
"styleRecalcs": 47,
"styleRecalcDurationMs": 16.821,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 674.996,
"heapDeltaBytes": -5524224,
"heapUsedBytes": 57243136,
"domNodes": -259,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 127.29599999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1692.2859999999673,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.575,
"layouts": 6,
"layoutDurationMs": 1.0550000000000002,
"taskDurationMs": 238.193,
"heapDeltaBytes": 3251760,
"heapUsedBytes": 71933996,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.39,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.3520000000617,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.573,
"layouts": 6,
"layoutDurationMs": 1.0819999999999999,
"taskDurationMs": 277.90700000000004,
"heapDeltaBytes": 3215752,
"heapUsedBytes": 71802576,
"domNodes": 79,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 14.186999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 426.45900000002257,
"styleRecalcs": 16,
"styleRecalcDurationMs": 8.209,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 292.971,
"heapDeltaBytes": 17808352,
"heapUsedBytes": 86560368,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 103.666,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 527.0060000000285,
"styleRecalcs": 16,
"styleRecalcDurationMs": 9.5,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 340.48,
"heapDeltaBytes": 17816380,
"heapUsedBytes": 86544228,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 116.56800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 895.5359999999928,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.396,
"heapDeltaBytes": -18861972,
"heapUsedBytes": 72567908,
"domNodes": -294,
"jsHeapTotalBytes": 21102592,
"scriptDurationMs": 40.821000000000005,
"eventListeners": -217,
"totalBlockingTimeMs": 281,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 908.3009999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.3969999999999,
"heapDeltaBytes": 38575584,
"heapUsedBytes": 107656364,
"domNodes": 0,
"jsHeapTotalBytes": 19820544,
"scriptDurationMs": 38.691,
"eventListeners": 0,
"totalBlockingTimeMs": 310,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 688.1750000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 269.65199999999976,
"heapDeltaBytes": 13708068,
"heapUsedBytes": 90233948,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 95.44,
"eventListeners": 0,
"totalBlockingTimeMs": 90,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 698.3189999999695,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 303.96599999999995,
"heapDeltaBytes": 14876552,
"heapUsedBytes": 90243248,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 102.17399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 95,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5815.579000000014,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.4440000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4645.477000000001,
"heapDeltaBytes": -1636248,
"heapUsedBytes": 77385800,
"domNodes": -258,
"jsHeapTotalBytes": 2875392,
"scriptDurationMs": 3821.177,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6402.349000000015,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.9739999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5354.861,
"heapDeltaBytes": -8997472,
"heapUsedBytes": 72391652,
"domNodes": -14,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 4194.701999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6351.110000000006,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.019000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5004.434000000001,
"heapDeltaBytes": -10663572,
"heapUsedBytes": 69922100,
"domNodes": -12,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 4002.281,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6618.340000000046,
"styleRecalcs": 4,
"styleRecalcDurationMs": 6.392000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5508.487999999999,
"heapDeltaBytes": 21750360,
"heapUsedBytes": 86196996,
"domNodes": -269,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 4285.366,
"eventListeners": -174,
"totalBlockingTimeMs": 25,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2009.1330000000198,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.652000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.421,
"heapDeltaBytes": -23326432,
"heapUsedBytes": 64818124,
"domNodes": -252,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 32.396,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2025.288000000046,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.419,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.784,
"heapDeltaBytes": 4370228,
"heapUsedBytes": 86350452,
"domNodes": -256,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 36.854000000000006,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2074.2740000000026,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.270999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1055.628,
"heapDeltaBytes": 85820,
"heapUsedBytes": 64636096,
"domNodes": 14,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 561.384,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2165.9199999999714,
"styleRecalcs": 70,
"styleRecalcDurationMs": 17.939999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1222.273,
"heapDeltaBytes": -3010536,
"heapUsedBytes": 79936048,
"domNodes": -252,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 603.801,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3081.5470000000005,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.889,
"layouts": 60,
"layoutDurationMs": 14.140999999999998,
"taskDurationMs": 1087.618,
"heapDeltaBytes": 24959208,
"heapUsedBytes": 90339740,
"domNodes": -217,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 505.864,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3223.4680000000253,
"styleRecalcs": 73,
"styleRecalcDurationMs": 18.594,
"layouts": 60,
"layoutDurationMs": 15.896,
"taskDurationMs": 1274.596,
"heapDeltaBytes": 2294240,
"heapUsedBytes": 93235556,
"domNodes": 40,
"jsHeapTotalBytes": 5541888,
"scriptDurationMs": 579.227,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2222.315999999978,
"styleRecalcs": 49,
"styleRecalcDurationMs": 10.688,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1241.0759999999998,
"heapDeltaBytes": 13198076,
"heapUsedBytes": 99186608,
"domNodes": 18,
"jsHeapTotalBytes": 5697536,
"scriptDurationMs": 647.3,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2536.5240000000995,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.785,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1422.425,
"heapDeltaBytes": -17381448,
"heapUsedBytes": 74758724,
"domNodes": 16,
"jsHeapTotalBytes": 7114752,
"scriptDurationMs": 739.5590000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2021.4390000000435,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.489,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.458,
"heapDeltaBytes": -24048980,
"heapUsedBytes": 67409688,
"domNodes": -251,
"jsHeapTotalBytes": 3174400,
"scriptDurationMs": 32.66799999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2035.6190000001106,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.133000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.15099999999995,
"heapDeltaBytes": -22878852,
"heapUsedBytes": 68378340,
"domNodes": -247,
"jsHeapTotalBytes": 3174400,
"scriptDurationMs": 33.355,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 412.7030000000218,
"styleRecalcs": 49,
"styleRecalcDurationMs": 12.596000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 274.251,
"heapDeltaBytes": 13117388,
"heapUsedBytes": 84027712,
"domNodes": 23,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 97.16900000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 460.0560000000087,
"styleRecalcs": 49,
"styleRecalcDurationMs": 13.162,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 303.71400000000006,
"heapDeltaBytes": 13533644,
"heapUsedBytes": 83968460,
"domNodes": 24,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 104.266,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1992.3400000000129,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.004000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 269.928,
"heapDeltaBytes": -2281360,
"heapUsedBytes": 61408740,
"domNodes": -272,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 5.796000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1993.8619999999787,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.93,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.468,
"heapDeltaBytes": -7613388,
"heapUsedBytes": 63273716,
"domNodes": -273,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.433000000000002,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1675.8849999999939,
"styleRecalcs": 47,
"styleRecalcDurationMs": 14.688,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.8589999999999,
"heapDeltaBytes": -12529344,
"heapUsedBytes": 58250592,
"domNodes": -273,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 83.186,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1676.1089999999967,
"styleRecalcs": 47,
"styleRecalcDurationMs": 15.588000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 561.109,
"heapDeltaBytes": -8613716,
"heapUsedBytes": 62083132,
"domNodes": -273,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 87.52600000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 783.6279999999647,
"styleRecalcs": 19,
"styleRecalcDurationMs": 20.695000000000004,
"layouts": 5,
"layoutDurationMs": 8.457,
"taskDurationMs": 573.4010000000001,
"heapDeltaBytes": 20171068,
"heapUsedBytes": 103319324,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 21.615000000000002,
"eventListeners": 2383,
"totalBlockingTimeMs": 76,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8272.812000000045,
"styleRecalcs": 251,
"styleRecalcDurationMs": 44.477000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3866.5720000000006,
"heapDeltaBytes": 3273384,
"heapUsedBytes": 92021640,
"domNodes": -234,
"jsHeapTotalBytes": -532480,
"scriptDurationMs": 1963.743,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8341.446000000018,
"styleRecalcs": 251,
"styleRecalcDurationMs": 47.824000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4362.08,
"heapDeltaBytes": -4505116,
"heapUsedBytes": 84889048,
"domNodes": -246,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 2109.629,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12205.232000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12016.592,
"heapDeltaBytes": -34593192,
"heapUsedBytes": 193870388,
"domNodes": -8062,
"jsHeapTotalBytes": -23531520,
"scriptDurationMs": 190.431,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12110.585000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11825.96,
"heapDeltaBytes": -32957316,
"heapUsedBytes": 182425292,
"domNodes": -8062,
"jsHeapTotalBytes": -9494528,
"scriptDurationMs": 189.1,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14136.689999999988,
"styleRecalcs": 67,
"styleRecalcDurationMs": 15.007000000000021,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14039.635,
"heapDeltaBytes": -31963656,
"heapUsedBytes": 187357480,
"domNodes": -8062,
"jsHeapTotalBytes": -13344768,
"scriptDurationMs": 612.399,
"eventListeners": -14928,
"totalBlockingTimeMs": 1,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14644.206999999937,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.485,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14498.645,
"heapDeltaBytes": -54039060,
"heapUsedBytes": 165468196,
"domNodes": -8062,
"jsHeapTotalBytes": -20717568,
"scriptDurationMs": 699.058,
"eventListeners": -14928,
"totalBlockingTimeMs": 46,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 4376.5489999999545,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.64099999999999,
"layouts": 20,
"layoutDurationMs": 24.391999999999996,
"taskDurationMs": 4345.231,
"heapDeltaBytes": -15336752,
"heapUsedBytes": 204465300,
"domNodes": -8062,
"jsHeapTotalBytes": 16699392,
"scriptDurationMs": 67.08200000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 89,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4317.5540000000865,
"styleRecalcs": 20,
"styleRecalcDurationMs": 55.806999999999995,
"layouts": 20,
"layoutDurationMs": 23.085000000000008,
"taskDurationMs": 4291.268,
"heapDeltaBytes": -41354344,
"heapUsedBytes": 178759504,
"domNodes": -8062,
"jsHeapTotalBytes": 17588224,
"scriptDurationMs": 66.587,
"eventListeners": -14928,
"totalBlockingTimeMs": 77,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5993.478999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5895.842,
"heapDeltaBytes": 8377996,
"heapUsedBytes": 171320864,
"domNodes": 0,
"jsHeapTotalBytes": -20971520,
"scriptDurationMs": 84.07599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6068.37900000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5975.667999999999,
"heapDeltaBytes": 11817300,
"heapUsedBytes": 191210192,
"domNodes": 0,
"jsHeapTotalBytes": -20447232,
"scriptDurationMs": 86.12399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 91.47600000000011,
"styleRecalcs": 8,
"styleRecalcDurationMs": 13.404,
"layouts": 3,
"layoutDurationMs": 0.9509999999999998,
"taskDurationMs": 68.407,
"heapDeltaBytes": 3213736,
"heapUsedBytes": 69841408,
"domNodes": 110,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.787999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 90.51499999998214,
"styleRecalcs": 7,
"styleRecalcDurationMs": 16.648,
"layouts": 4,
"layoutDurationMs": 1.835,
"taskDurationMs": 71.384,
"heapDeltaBytes": 3098744,
"heapUsedBytes": 69375056,
"domNodes": 132,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.341000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.55 #20132 +/- ##
=============================================
- Coverage 84.88% 84.87% -0.02%
=============================================
Files 2327 2327
Lines 132831 132939 +108
Branches 35521 35558 +37
=============================================
+ Hits 112750 112827 +77
- Misses 19719 19750 +31
Partials 362 362
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
There was a problem hiding this comment.
Verdict: Request changes. The #19239 carry is faithful apart from one dropped import line in groupNode.test.ts.
I compared against #19239's merge commit ec90e0ac049a6aef212e550ec703c7100e887270. This PR is a cherry-pick of the cloud/1.55 carrier #20093 (b6c760c1a1), and its diff is identical to that commit. 32 of the 35 files carry exactly the source's added and removed lines. That covers idAllocation.ts and its property and unit tests, LGraph.ts, the clipboard and subgraph-deduplication changes, workflowSchema.ts, useCopy/usePaste, and copyPaste.spec.ts.
Accounted for by the target:
LGraphCanvas.tsdropssurface: 'graph'from the two clipboard-rollbackreportErrorcalls, becauseReportErrorOptionsoncore/1.55has nosurfacefield. Otherwise the file carries the source's lines, aligned differently by the diff.- The source's edits to
browser_tests/fixtures/webSessionFixture.tsandsrc/platform/workflow/templates/services/templateInputService.tsare left out because neither file exists oncore/1.55.
Divergence, commented inline: groupNode.test.ts uses test.for in the carried "rejects …" case, but this branch does not carry the source's import change (import { describe, expect, it, test, vi } from 'vitest'). #20093 had the same gap on cloud/1.55. It still runs and typechecks only because globals: true and vitest/globals are enabled. Every other test file in the repository imports its Vitest API explicitly, so please carry that line as the source has it.
Checks: the 13 touched Vitest files pass locally at this head (424 tests). vue-tsc --noEmit and pnpm typecheck:browser pass. Hosted lint-and-format, test and e2e-status are green at 5724f23. I expect to approve once the import is restored.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 4 |
| 🟡 Medium | 6 |
Panel: 8/8 reviewers contributed findings.
There was a problem hiding this comment.
Verdict: Request changes. 0212876 made this a faithful #19239 backport, but the new head d604716 adds a clipboard-schema change that is not on main.
The review I was asked for at 0212876 was superseded while I checked it: d604716 was pushed, and the hosted test and e2e-status runs at 0212876 were cancelled as a result. I am reviewing the current head instead.
I compared against #19239's merge commit ec90e0ac049a6aef212e550ec703c7100e887270. Up to 0212876 the branch matches the source in every file it touches. The only exceptions are adaptations accounted for by core/1.55:
LGraphCanvas.tsdropssurface: 'graph'from the two clipboard-rollbackreportErrorcalls, becauseReportErrorOptionshere has nosurfacefield.- The edits to
webSessionFixture.tsandtemplateInputService.tsare left out because neither file exists on this branch.
0212876 restores the source's explicit test import in groupNode.test.ts, which resolves my previous finding. At that commit, groupNode.test.ts passes locally (28 tests), and lint-and-format and typecheck were green.
Divergence, commented inline: d604716 tightens hasSupportedClipboardWidgetValuesLength to reject negative and non-integer lengths. It also adds isArrayLikeWidgetValues, so a named widget called length stays a named value, and adds two test rows and a test for those cases. None of this is in #19239, and main's workflowSchema.ts still has the source's version of both functions. It answers an automated review finding on this PR. If the fix is wanted, it should land on main first and be backported to both release branches. Please drop d604716 from this backport.
Addresses review feedback: #20132 (comment)
Addresses review feedback: #20132 (comment)
There was a problem hiding this comment.
Verdict: Approve. At edb790b this is a faithful backport of #19239. The only adaptations are the ones core/1.55 requires.
I compared against #19239's merge commit ec90e0ac049a6aef212e550ec703c7100e887270. 0b35b37 and edb790b revert d604716, so the release-only clipboard-schema change I flagged is gone, and the head tree is identical to 0212876. Every file the branch touches carries the source's added and removed lines. That includes idAllocation.ts and its property and unit tests, LGraph.ts, the clipboard paste and subgraph-deduplication changes, workflowSchema.ts and its tests, useCopy/usePaste, groupNode.test.ts with its explicit test import, and copyPaste.spec.ts.
Adaptations, each accounted for by core/1.55:
LGraphCanvas.tsomitssurface: 'graph'from the two clipboard-rollbackreportErrorcalls, becauseReportErrorOptionson this branch has nosurfacefield.- The source's edits to
browser_tests/fixtures/webSessionFixture.tsandsrc/platform/workflow/templates/services/templateInputService.tsare left out because neither file exists oncore/1.55.
Checks: the 13 touched Vitest files pass locally at this head (424 tests). vue-tsc --noEmit and pnpm typecheck:browser passed earlier on this same content, apart from the one-line import change. Hosted CI at edb790b is green, including lint-and-format, typecheck, test and e2e-status.
Summary
Backports #19239 (restores safe graph-ID allocation through
Number.MAX_SAFE_INTEGER) tocore/1.55.This carries the release-adapted implementation already merged into
cloud/1.55via #20093. The cherry-pick applied cleanly to the currentcore/1.55branch.Verification
Tracked by FE-3007.
Justification: release backport of the reviewed safe-ID fix, using the release-adapted implementation already running on
cloud/1.55.