Repository navigation
test(agent): black-box case for a human node add the doc host refuses - #20038
Conversation
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-11T17:43:10.226Z",
"gitSha": "398d1bd18d87b7414020f75e8f83bcbc48906cc8",
"branch": "test/fe18210-rejected-node-add-blackbox",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.3470000000384,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.346999999999999,
"layouts": 9,
"layoutDurationMs": 3.2239999999999998,
"taskDurationMs": 469.442,
"heapDeltaBytes": 2766940,
"heapUsedBytes": 70401608,
"domNodes": -162,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.450000000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2022.354000000064,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.346,
"layouts": 11,
"layoutDurationMs": 2.3190000000000004,
"taskDurationMs": 524.5930000000001,
"heapDeltaBytes": -1335412,
"heapUsedBytes": 66363592,
"domNodes": -162,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 7.758999999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1758.6369999999647,
"styleRecalcs": 72,
"styleRecalcDurationMs": 17.358999999999998,
"layouts": 10,
"layoutDurationMs": 2.5509999999999997,
"taskDurationMs": 812.5360000000001,
"heapDeltaBytes": 1822088,
"heapUsedBytes": 69534600,
"domNodes": -162,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 172.37800000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1807.847000000038,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.904000000000002,
"layouts": 10,
"layoutDurationMs": 2.8320000000000003,
"taskDurationMs": 882.4540000000001,
"heapDeltaBytes": 1933300,
"heapUsedBytes": 69596284,
"domNodes": -162,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 158.815,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66574074074074,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.229000000013,
"styleRecalcs": 18,
"styleRecalcDurationMs": 7.1499999999999995,
"layouts": 13,
"layoutDurationMs": 3.2050000000000005,
"taskDurationMs": 286.488,
"heapDeltaBytes": 18533056,
"heapUsedBytes": 86157348,
"domNodes": 47,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 10.274999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.3549999999404,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.784999999999999,
"layouts": 11,
"layoutDurationMs": 2.8420000000000005,
"taskDurationMs": 396.521,
"heapDeltaBytes": 20196236,
"heapUsedBytes": 87909764,
"domNodes": 47,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.030000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 642.7930000000401,
"styleRecalcs": 13,
"styleRecalcDurationMs": 4.160999999999999,
"layouts": 9,
"layoutDurationMs": 2.556,
"taskDurationMs": 443.73900000000003,
"heapDeltaBytes": 1164632,
"heapUsedBytes": 68910360,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 169.32500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 632.9959999999346,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.366,
"layouts": 11,
"layoutDurationMs": 3.077,
"taskDurationMs": 488.82599999999996,
"heapDeltaBytes": 5302596,
"heapUsedBytes": 79823148,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 168.68800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1237.57999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 946.729,
"heapDeltaBytes": 21432,
"heapUsedBytes": 81273816,
"domNodes": -192,
"jsHeapTotalBytes": 15212544,
"scriptDurationMs": 74.325,
"eventListeners": -106,
"totalBlockingTimeMs": 543,
"frameDurationMs": 33.32972972972975,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1179.081999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 835.247,
"heapDeltaBytes": -11956452,
"heapUsedBytes": 81069804,
"domNodes": -192,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 66.103,
"eventListeners": -106,
"totalBlockingTimeMs": 522,
"frameDurationMs": 32.86944444444445,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 877.868000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.5830000000001,
"heapDeltaBytes": -4013808,
"heapUsedBytes": 76852268,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 170.076,
"eventListeners": 0,
"totalBlockingTimeMs": 227,
"frameDurationMs": 24.536111111111115,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.2980000000707,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.8509999999996,
"heapDeltaBytes": -3670644,
"heapUsedBytes": 76367596,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 153.729,
"eventListeners": 0,
"totalBlockingTimeMs": 209,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10802.976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9913.299,
"heapDeltaBytes": 18282624,
"heapUsedBytes": 96993928,
"domNodes": -258,
"jsHeapTotalBytes": -659456,
"scriptDurationMs": 7983.803,
"eventListeners": -68,
"totalBlockingTimeMs": 999,
"frameDurationMs": 31.99673590504451,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9914.136999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9124.66,
"heapDeltaBytes": 1058680,
"heapUsedBytes": 96793920,
"domNodes": -258,
"jsHeapTotalBytes": 1437696,
"scriptDurationMs": 7418.782999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 674,
"frameDurationMs": 32.195454545454545,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10343.06399999997,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.08799999999999954,
"layouts": 1,
"layoutDurationMs": 0.3579999999999998,
"taskDurationMs": 9575.822,
"heapDeltaBytes": -4450820,
"heapUsedBytes": 74894632,
"domNodes": -258,
"jsHeapTotalBytes": 1175552,
"scriptDurationMs": 7705.387,
"eventListeners": -68,
"totalBlockingTimeMs": 1078,
"frameDurationMs": 31.217522658610278,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8820.733000000018,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.41000000000000064,
"layouts": 2,
"layoutDurationMs": 0.7789999999999994,
"taskDurationMs": 8094.238,
"heapDeltaBytes": 21101652,
"heapUsedBytes": 100122152,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 6813.271000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 680,
"frameDurationMs": 32.41323529411765,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 284.1280000000097,
"styleRecalcs": 28,
"styleRecalcDurationMs": 18.136,
"layouts": 12,
"layoutDurationMs": 3.472,
"taskDurationMs": 244.971,
"heapDeltaBytes": -8684836,
"heapUsedBytes": 84138548,
"domNodes": 917,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.6,
"eventListeners": 195,
"totalBlockingTimeMs": 5,
"frameDurationMs": 20,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 257.3859999999968,
"styleRecalcs": 26,
"styleRecalcDurationMs": 15.430000000000001,
"layouts": 12,
"layoutDurationMs": 3.4779999999999998,
"taskDurationMs": 214.558,
"heapDeltaBytes": -8224176,
"heapUsedBytes": 85467324,
"domNodes": 917,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 8.469,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.833333333333332,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2073.4879999999976,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.747,
"layouts": 9,
"layoutDurationMs": 3.095,
"taskDurationMs": 699.035,
"heapDeltaBytes": -5205876,
"heapUsedBytes": 92981408,
"domNodes": -258,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 38.001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66532258064516,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2023.8809999999603,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.3620000000000005,
"layouts": 8,
"layoutDurationMs": 2.4939999999999998,
"taskDurationMs": 464.0200000000001,
"heapDeltaBytes": -3034412,
"heapUsedBytes": 80511336,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 32.66499999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2305.0360000000296,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.976000000000001,
"layouts": 9,
"layoutDurationMs": 2.6140000000000003,
"taskDurationMs": 1601.179,
"heapDeltaBytes": -4044820,
"heapUsedBytes": 80030512,
"domNodes": -258,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 870.738,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78759124087591,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2686.2129999999524,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.468,
"layouts": 9,
"layoutDurationMs": 2.9180000000000006,
"taskDurationMs": 1780.3210000000004,
"heapDeltaBytes": -6445868,
"heapUsedBytes": 71064188,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 885.9879999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666459627329193,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3830.2659999999946,
"styleRecalcs": 72,
"styleRecalcDurationMs": 8.94,
"layouts": 66,
"layoutDurationMs": 12.152999999999999,
"taskDurationMs": 1806.1829999999998,
"heapDeltaBytes": 2477344,
"heapUsedBytes": 87922304,
"domNodes": 24,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 808.3580000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666086956521735,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3823.937000000001,
"styleRecalcs": 72,
"styleRecalcDurationMs": 8.053999999999998,
"layouts": 66,
"layoutDurationMs": 11.348,
"taskDurationMs": 1772.484,
"heapDeltaBytes": 6532624,
"heapUsedBytes": 84626676,
"domNodes": -234,
"jsHeapTotalBytes": 2486272,
"scriptDurationMs": 775.5889999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.738596491228073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3171.2340000000268,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.3870000000000005,
"layouts": 6,
"layoutDurationMs": 1.7789999999999997,
"taskDurationMs": 2043.504,
"heapDeltaBytes": -4716348,
"heapUsedBytes": 74244568,
"domNodes": 0,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 1013.121,
"eventListeners": 182,
"totalBlockingTimeMs": 38,
"frameDurationMs": 17.114516129032253,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2969.098000000031,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.0779999999999985,
"layouts": 7,
"layoutDurationMs": 2.129,
"taskDurationMs": 1939.992,
"heapDeltaBytes": 12357604,
"heapUsedBytes": 100049980,
"domNodes": 0,
"jsHeapTotalBytes": 5660672,
"scriptDurationMs": 960.379,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.855681818181814,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2071.124999999995,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.6919999999999993,
"layouts": 9,
"layoutDurationMs": 2.766,
"taskDurationMs": 697.4359999999999,
"heapDeltaBytes": 12322428,
"heapUsedBytes": 89812860,
"domNodes": -258,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 35.004,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.8919999999944,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.0809999999999995,
"layouts": 8,
"layoutDurationMs": 2.0640000000000005,
"taskDurationMs": 623.4329999999999,
"heapDeltaBytes": -3374556,
"heapUsedBytes": 82645396,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 30.963000000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 657.7909999999747,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.702000000000001,
"layouts": 12,
"layoutDurationMs": 3.6,
"taskDurationMs": 475.561,
"heapDeltaBytes": 22766220,
"heapUsedBytes": 89485812,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 143.502,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102556,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 608.3550000000741,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.715,
"layouts": 10,
"layoutDurationMs": 2.515,
"taskDurationMs": 429.69100000000003,
"heapDeltaBytes": 22902792,
"heapUsedBytes": 91135420,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 142.491,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2022.0999999999663,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.8069999999999995,
"layouts": 11,
"layoutDurationMs": 3.9859999999999998,
"taskDurationMs": 473.52700000000004,
"heapDeltaBytes": 3097956,
"heapUsedBytes": 70679664,
"domNodes": -180,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 10.893,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2024.000000000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.19,
"layouts": 10,
"layoutDurationMs": 2.154,
"taskDurationMs": 524.7219999999999,
"heapDeltaBytes": -5722900,
"heapUsedBytes": 71569392,
"domNodes": -180,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 7.034999999999999,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667213114754095,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1891.428000000019,
"styleRecalcs": 60,
"styleRecalcDurationMs": 17.7,
"layouts": 11,
"layoutDurationMs": 3.136,
"taskDurationMs": 1025.2240000000002,
"heapDeltaBytes": -1825232,
"heapUsedBytes": 66201492,
"domNodes": -172,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 115.60399999999998,
"eventListeners": -112,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66548672566372,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1794.1809999999805,
"styleRecalcs": 61,
"styleRecalcDurationMs": 15.588000000000001,
"layouts": 12,
"layoutDurationMs": 2.7689999999999997,
"taskDurationMs": 777.618,
"heapDeltaBytes": 128296,
"heapUsedBytes": 68026168,
"domNodes": -172,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 107.33800000000001,
"eventListeners": -112,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66574074074074,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1451.3200000000097,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.953999999999994,
"layouts": 5,
"layoutDurationMs": 16.257,
"taskDurationMs": 1029.1019999999999,
"heapDeltaBytes": 35993204,
"heapUsedBytes": 117187040,
"domNodes": 15956,
"jsHeapTotalBytes": 16130048,
"scriptDurationMs": 42.94400000000001,
"eventListeners": 3244,
"totalBlockingTimeMs": 158,
"frameDurationMs": 20.091780821917805,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8255.599000000018,
"styleRecalcs": 251,
"styleRecalcDurationMs": 20.334999999999997,
"layouts": 10,
"layoutDurationMs": 2.4760000000000004,
"taskDurationMs": 5117.615,
"heapDeltaBytes": 10232500,
"heapUsedBytes": 93267784,
"domNodes": -258,
"jsHeapTotalBytes": 5332992,
"scriptDurationMs": 2683.1400000000003,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666060606060608,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8274.64800000007,
"styleRecalcs": 251,
"styleRecalcDurationMs": 19.702,
"layouts": 9,
"layoutDurationMs": 2.4799999999999995,
"taskDurationMs": 5019.646,
"heapDeltaBytes": 9713988,
"heapUsedBytes": 92750708,
"domNodes": -258,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 2607.5840000000003,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.733198380566805,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16753.544999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15865.987,
"heapDeltaBytes": -32904824,
"heapUsedBytes": 262215932,
"domNodes": -3330,
"jsHeapTotalBytes": 8245248,
"scriptDurationMs": 249.12999999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.7295025728988,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 23387.379000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22849.494,
"heapDeltaBytes": -4721352,
"heapUsedBytes": 275600240,
"domNodes": -3330,
"jsHeapTotalBytes": 12308480,
"scriptDurationMs": 345.797,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.17594501718213,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 29616.579,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.076000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 29270.502000000004,
"heapDeltaBytes": 27664444,
"heapUsedBytes": 277356208,
"domNodes": 0,
"jsHeapTotalBytes": -2883584,
"scriptDurationMs": 883.081,
"eventListeners": 2,
"totalBlockingTimeMs": 16,
"frameDurationMs": 54.54051565377533,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 28713.72999999994,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.934000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28336.189000000006,
"heapDeltaBytes": -48158016,
"heapUsedBytes": 253109516,
"domNodes": -3330,
"jsHeapTotalBytes": 7852032,
"scriptDurationMs": 931.023,
"eventListeners": -651,
"totalBlockingTimeMs": 2,
"frameDurationMs": 53.27569573283859,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8780.666999999994,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.564,
"layouts": 20,
"layoutDurationMs": 21.910000000000014,
"taskDurationMs": 8677.988,
"heapDeltaBytes": -29303028,
"heapUsedBytes": 268851264,
"domNodes": -3330,
"jsHeapTotalBytes": 11993088,
"scriptDurationMs": 128.99300000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 50.47701149425287,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 8693.70200000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.904,
"layouts": 20,
"layoutDurationMs": 26.474999999999998,
"taskDurationMs": 8520.857,
"heapDeltaBytes": -31771824,
"heapUsedBytes": 266547556,
"domNodes": -3330,
"jsHeapTotalBytes": 7798784,
"scriptDurationMs": 132.13400000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 49.33465909090909,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11588.674999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11332.671000000002,
"heapDeltaBytes": 73796,
"heapUsedBytes": 279638972,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 150.34599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.86116838487972,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11519.481999999925,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11338.826000000001,
"heapDeltaBytes": 8949388,
"heapUsedBytes": 275840764,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 164.06999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.42553956834532,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 465.9480000000258,
"styleRecalcs": 14,
"styleRecalcDurationMs": 11.825999999999999,
"layouts": 13,
"layoutDurationMs": 4.034000000000001,
"taskDurationMs": 114.653,
"heapDeltaBytes": 6766816,
"heapUsedBytes": 73457828,
"domNodes": 98,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 10.421,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285715,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 149.38599999993585,
"styleRecalcs": 10,
"styleRecalcDurationMs": 13.421999999999999,
"layouts": 10,
"layoutDurationMs": 4.1770000000000005,
"taskDurationMs": 103.90599999999999,
"heapDeltaBytes": 4427276,
"heapUsedBytes": 77364992,
"domNodes": 120,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.209999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.750000000000057,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 499.5689999999513,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.072,
"layouts": 76,
"layoutDurationMs": 15.313,
"taskDurationMs": 452.021,
"heapDeltaBytes": 11474596,
"heapUsedBytes": 83812532,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 215.545,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 564.5250000000033,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.3190000000000002,
"layouts": 76,
"layoutDurationMs": 16.556,
"taskDurationMs": 509.0060000000001,
"heapDeltaBytes": 12278472,
"heapUsedBytes": 90450440,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 246.806,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 579.4970000000603,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.352,
"layouts": 76,
"layoutDurationMs": 14.248000000000001,
"taskDurationMs": 539.722,
"heapDeltaBytes": 12602324,
"heapUsedBytes": 193834352,
"domNodes": 4,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 195.14100000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.15882352941178,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 647.9669999999942,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.46,
"layouts": 76,
"layoutDurationMs": 16.122999999999998,
"taskDurationMs": 619.057,
"heapDeltaBytes": 814416,
"heapUsedBytes": 119608532,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 234.851,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102556,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2262 passed, 0 failed · 1 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 38ef604bd5fc04076b090f859b398c9d316ed883
Full docs: ADR-DEVEX-LINT-0015 |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 6 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
| 🟢 Low | 2 |
| ⚪ Nit | 3 |
Panel: 8/8 reviewers contributed findings.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20038 +/- ##
==========================================
+ Coverage 86.08% 86.87% +0.79%
==========================================
Files 3638 2588 -1050
Lines 173746 145533 -28213
Branches 47902 39864 -8038
==========================================
- Hits 149565 126437 -23128
+ Misses 22172 18710 -3462
+ Partials 2009 386 -1623
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Extracted from superseded #18210, whose pending-ledger/full-reconcile implementation #18700 deleted. One user story in it survives the pivot and had no black-box owner on `main`: a human node add the doc host REFUSES must leave the canvas and tell the person it was refused. `main` covers the two halves separately and below the UI only — `useAgentCrdtFollower.rejectedHumanAdd.test.ts` for the telemetry report and `agentCrdtProjection.localEdits.test.ts` for `revertRejected` through the graph API. The one existing black-box rejection case, `agentDuplicateInsertOpaqueWidgetWrite.spec.ts`, covers a refused `set_widget`: different op, different notice copy, no node removal. The rejection is the real applier's own verdict, not an injected wire frame: the fake host's pinned catalog omits `CLIPTextEncode`, `wireNodeSnapshot` mints name-keyed `widgets_values` for a non-virtual class, and `rejectUnprojectableWidgets` raises `uncatalogued_widget_write`. The batch is parked (`humanOpsHost: 'hold'`) so the added node is observable before the verdict, then released down the same relay/applier/verdict path — #18210's version raced its own assertion because the rejection landed synchronously. No `pendingOpTracker`, `pendingOpRevert`, layout-actor suppression or reconcile pass is reconstructed. Mutation-proved red against `useAgentCrdtFollower.ts` on current main: dropping `revertRejectedOps(outcome)` fails the canvas-removal assertion; dropping `rejectedOpNotifier.notify(...)` fails the toast assertion. Green 4/4 under `--repeat-each=4`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
0f8c3e6 to
d1c56ac
Compare
d1c56ac to
9bfaa32
Compare
All six open findings from the cursor-review panel, after a rebase onto current main: - Medium (r4175203798): `heldClientOps()` flattens every held batch while `releaseHeldClientOps()` judges only the oldest, so `.not.toEqual([])` was satisfied by any batch queued ahead of the add. The released batch is now asserted to contain the `add_node`. - Low (r4175203802): the rejection notice carries `life: NOTICE_LIFE_MS` (10s) and its clock starts at verdict time, so the three default-5s canvas assertions could expire it first. The toast step now runs before the canvas step. - Low (r4175203803): dropped the `host.projection()` assertion. The applier only commits accepted ops, so it could not fail; the canvas side is already covered by the `nodeIdsOfType` poll. - Nit (r4175203806): the empty-canvas guard now bounds `point.x` against the viewport width as well, and reports the aimed point rather than the node's lower edge. - Nit (r4175203807): `addThroughSearchBox` derives the expected result text from `nodeDefs[type].display_name` instead of hard-coding one class's display name. - Nit (r4175203811): narrowed the "and nothing else" claim to what is actually checked — the seed node survived — rather than implying its widget values and position are covered. Also replaces `new ToastHelper(page)` with the `toast` fixture, which current main's oxlint `no-restricted-imports` rule requires; that rule landed after this branch was authored and was the only lint error after the rebase.
This comment has been minimized.
This comment has been minimized.
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit 894e8bb has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
… the Agent boundary (#21479) (#21629) ## Summary Backport of #21479 to `cloud/1.56` (FE-3470). A human-added node whose class the doc host's pinned catalog lacks is no longer refused; the Agent minter declares `widgets_values_form` from the live widget order. - `cherry-pick -x` of c5b5521. Minter, minter unit tests and the new round-trip spec apply cleanly. - Two release resolutions, both test-only: - `agentCrdtRejectedNodeAdd.spec.ts` is not on `cloud/1.56` (it came with #20038, not carried here), so its edit is dropped. - The round-trip spec reads the host projection through `hostNode()`, which came with #18934. A second commit adds only that five-line reader. - Builds on #21336 (the PM-2003 backport of #21245), already on `cloud/1.56`. `@comfyorg/comfy-multi-player` is `0.3.10` here, as at the source merge, so no pin change is bundled. <details><summary>Full context for agent readers</summary> - Source: #21479 by @DrJKL, merged 2026-10-20T21:41:40Z. Sibling carriers already merged: #21533 (`core/1.57`), #21534 (`cloud/1.57`), #21544 (`cloud/1.58`). - Target tip at cherry-pick: `7c07d06f34`. No earlier carrier for #21479 targeted `cloud/1.56` (searched open and closed). - `core/1.56` is deliberately not carried: it pins comfy-multi-player 0.3.6, which has no `widgets_values_form` support (the A24 reader arrived in 0.3.9), and it never received the #21245 basis. - Moving the pin to 0.3.12 is #21535's job and stays gated on production Cloud serving cloud#14458. It is not part of this backport. - The posted turn draft still carries no form (separate client-seed recapture ticket), as on `main`. ### Verification on this head (local, `--project=cloud`, own ComfyUI container) - Red on the parent: with the new spec and fixture on `cloud/1.56` and the old minter, `agentWidgetFormRoundTrip.spec.ts` fails 2 of 2. The host refuses the add, the node leaves the canvas, and the panel shows "Your edit was rejected and was not saved." - Green on this head: the same spec passes. On repeats the final tab-return step fails about 1 run in 5. The same tab-switch helper also flakes in the unchanged `agentHumanAddTabSwitch.spec.ts` on the untouched `cloud/1.56` parent (1 of 21 there), so the flake is already on this branch, not caused by this change. - Sweep with one retry, covering draft-matches-canvas, opaque-write, dynamic-combo, human-add reload, human-add tab-switch, overflow, ghost-flag, remote-edit undo, undo/redo and widget-form round trip: 18 passed, 1 flaky (the ghost-flag tab switch, same helper). - Vitest `src/workbench/extensions/agent/`: 2958 passed. One unrelated timer test failed once and passed on rerun. `docOpMinter.test.ts` 87/87. - `typecheck`, `typecheck:browser`, eslint and the commit hooks pass. Carried under the program's standing Agent backport authority for the current `cloud/1.56` train. </details> --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
Summary
Adds the one durable black-box case extracted from superseded #18210: a human node add that the agent doc host refuses must leave the canvas and tell the person it was refused.
Changes
browser_tests/tests/agent/agentCrdtRejectedNodeAdd.spec.ts. No production code, no fixture changes.#18210's implementation was the pre-pivot pending-ledger / full-reconcile design that #18700 deliberately deleted, and it should not be rebased or merged. But one user story in it survives the pivot unchanged and had no black-box owner on
main. The two halves are covered separately and below the UI only:useAgentCrdtFollower.rejectedHumanAdd.test.tsasserts the telemetry report for a refusedadd_node.agentCrdtProjection.localEdits.test.tsassertsrevertRejectedgoes through the graph API.agentDuplicateInsertOpaqueWidgetWrite.spec.tsis the only black-box rejection case, and it covers a refusedset_widget— different op, different notice copy, value rollback rather than node removal.Nothing asserted that the person watching the canvas sees the node go away, or that they are told why.
Nothing from #18210's machinery is reconstructed: no
pendingOpTracker, nopendingOpRevert, no layout-actor suppression, no reconcile pass.Review Focus
The rejection is the real applier's verdict, not an injected wire frame. The fake host's pinned catalog describes
KSamplerand omitsCLIPTextEncode;wireNodeSnapshotmints NAME-KEYEDwidgets_valuesfor any non-virtual class;rejectUnprojectableWidgetsthen raisesuncatalogued_widget_writebecause accepting it would make the whole document unprojectable on every later read. A browser talking to a newer server than the sha-pinned catalog is the real-world shape of that gap. The spec asserts the code on the outcome, so a future applier change that stops rejecting this payload surfaces here rather than silently passing.Why the batch is parked rather than judged on arrival.
humanOpsHost: 'hold'keeps the page'sdoc_opsin flight so the added node is observable on the canvas before the verdict lands, thenreleaseHeldClientOps()sends it down the identical path (relay gate → real applier → verdict frame → delta). #18210's version of this case judged at send time and raced its own assertion — its comment says so: "the synchronous rejection can remove the node before it is observable."Coordinates are measured, not hard-coded.
loadIntoBootWorkflowrunsFitView, and a single seed node fits by filling the viewport, so a fixed screen point lands on the seed node's ownseedwidget. The spec pins the canvas transform after the panel has taken its side of the window, then derives the search-box point from the node's measured box and throws if no empty canvas is left.Assertions are user-visible only: the node's DOM presence on canvas, the seed node still being there, the host projection agreeing with the canvas again, and the graph-edit rejection toast (not the widget-write copy —
rejectedOpNoticereserves that for a refusedset_widget).Evidence
Against current
main(edbc7def50d0ddbf2aa8056f1c1f10e65da732d1),--project=cloud:--repeat-each=4.revertRejectedOps(outcome)inuseAgentCrdtFollower.ts→expect(locator).toBeHidden()fails, the refused node stays visible.rejectedOpNotifier.notify(...)→ the toast assertion fails, element not found.Local run:
DISTRIBUTION=clouddev server on 6210 against a ComfyUI e2e container on 8190, perdocs/env-and-harness-traps.md.Suggested disposition for #18210
Close it as superseded, pointing at #18700 and this PR. The rest of its behaviours are either already consolidated on
mainor belong to the deleted seam.