Repository navigation
[backport cloud/1.54] fix(agent): preserve skill names on completion (#19726) - #19989
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1990 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-03T18:25:57.937Z",
"gitSha": "0fcff0c74f859372d1f56e71436fd7f421163364",
"branch": "backport-19726-followup-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2117.0009999999593,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.573,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 621.277,
"heapDeltaBytes": -3427396,
"heapUsedBytes": 69857408,
"domNodes": -281,
"jsHeapTotalBytes": 4755456,
"scriptDurationMs": 12.754000000000001,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2051.8730000000005,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.129,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.62,
"heapDeltaBytes": -13859356,
"heapUsedBytes": 57235580,
"domNodes": 3,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.026,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2075.61800000002,
"styleRecalcs": 78,
"styleRecalcDurationMs": 37.659,
"layouts": 14,
"layoutDurationMs": 4.106999999999999,
"taskDurationMs": 1067.352,
"heapDeltaBytes": -13008800,
"heapUsedBytes": 58861332,
"domNodes": -284,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 176.995,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1843.0819999999812,
"styleRecalcs": 75,
"styleRecalcDurationMs": 28.514999999999997,
"layouts": 14,
"layoutDurationMs": 4.121,
"taskDurationMs": 871.4920000000001,
"heapDeltaBytes": -9564444,
"heapUsedBytes": 64074884,
"domNodes": -280,
"jsHeapTotalBytes": 2920448,
"scriptDurationMs": 160.804,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1756.9500000000176,
"styleRecalcs": 31,
"styleRecalcDurationMs": 22.290999999999997,
"layouts": 6,
"layoutDurationMs": 1.2100000000000002,
"taskDurationMs": 395.219,
"heapDeltaBytes": 4659284,
"heapUsedBytes": 78221680,
"domNodes": 76,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 12.804,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.0439999999826,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.203999999999997,
"layouts": 6,
"layoutDurationMs": 1.1300000000000001,
"taskDurationMs": 386.20300000000003,
"heapDeltaBytes": 4484968,
"heapUsedBytes": 75650120,
"domNodes": 76,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 12.468,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 674.7439999999756,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.167,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.10200000000003,
"heapDeltaBytes": -7825288,
"heapUsedBytes": 63296324,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 161.23399999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 718.7149999999747,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.082,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.01800000000003,
"heapDeltaBytes": 18165804,
"heapUsedBytes": 89062308,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 165.48100000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2039.1559999999913,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.8020000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 607.4709999999999,
"heapDeltaBytes": -7649468,
"heapUsedBytes": 69988956,
"domNodes": -283,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 39.54200000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2037.4100000000226,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.62,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 587.5509999999999,
"heapDeltaBytes": -3852492,
"heapUsedBytes": 76530856,
"domNodes": -266,
"jsHeapTotalBytes": -2846720,
"scriptDurationMs": 33.215,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2210.9850000000506,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.45,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1600.536,
"heapDeltaBytes": -9520776,
"heapUsedBytes": 68648668,
"domNodes": -282,
"jsHeapTotalBytes": 4091904,
"scriptDurationMs": 809.528,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2359.3230000000176,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.710999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1713.5950000000003,
"heapDeltaBytes": 7507744,
"heapUsedBytes": 86126708,
"domNodes": -284,
"jsHeapTotalBytes": 385024,
"scriptDurationMs": 861.468,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3756.1900000000037,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.754999999999999,
"layouts": 60,
"layoutDurationMs": 12.570000000000002,
"taskDurationMs": 1857.3179999999998,
"heapDeltaBytes": -1532244,
"heapUsedBytes": 78779884,
"domNodes": -262,
"jsHeapTotalBytes": 2781184,
"scriptDurationMs": 836.1429999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3621.097999999961,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.021,
"layouts": 60,
"layoutDurationMs": 12.161000000000001,
"taskDurationMs": 1767.218,
"heapDeltaBytes": -8541396,
"heapUsedBytes": 71059756,
"domNodes": -265,
"jsHeapTotalBytes": 3043328,
"scriptDurationMs": 804.299,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3083.9839999999867,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.855999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1897.5090000000002,
"heapDeltaBytes": 7631464,
"heapUsedBytes": 75799100,
"domNodes": 0,
"jsHeapTotalBytes": 1503232,
"scriptDurationMs": 983.9050000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3089.9910000000546,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.974000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1934.6029999999998,
"heapDeltaBytes": 16514788,
"heapUsedBytes": 84695092,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 988.8530000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.5470000000228,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.526999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.706,
"heapDeltaBytes": -9958016,
"heapUsedBytes": 69579696,
"domNodes": -284,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 34.82500000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2012.2539999999844,
"styleRecalcs": 3,
"styleRecalcDurationMs": 4.4270000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.68100000000004,
"heapDeltaBytes": 11220328,
"heapUsedBytes": 77451740,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.734,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 605.021000000022,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.341,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.14700000000005,
"heapDeltaBytes": -10653132,
"heapUsedBytes": 65430244,
"domNodes": 20,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 142.642,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 592.5389999999879,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.835000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.20000000000005,
"heapDeltaBytes": -10645468,
"heapUsedBytes": 65452188,
"domNodes": 20,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 145.227,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.3839999999645,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.867999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.985,
"heapDeltaBytes": -11215420,
"heapUsedBytes": 61142340,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.701999999999998,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.304999999984,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.558000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.024,
"heapDeltaBytes": 7787392,
"heapUsedBytes": 83484116,
"domNodes": -296,
"jsHeapTotalBytes": 4231168,
"scriptDurationMs": 10.234,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.658000000038,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.519,
"layouts": 18,
"layoutDurationMs": 4.574,
"taskDurationMs": 838.3680000000002,
"heapDeltaBytes": -13792184,
"heapUsedBytes": 62007504,
"domNodes": -297,
"jsHeapTotalBytes": 5541888,
"scriptDurationMs": 109.929,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1794.181999999978,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.355999999999998,
"layouts": 18,
"layoutDurationMs": 4.577999999999999,
"taskDurationMs": 868.644,
"heapDeltaBytes": -17710888,
"heapUsedBytes": 58124820,
"domNodes": -295,
"jsHeapTotalBytes": 4755456,
"scriptDurationMs": 122.098,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.525999999998,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.260999999999996,
"layouts": 15,
"layoutDurationMs": 15.764000000000003,
"taskDurationMs": 912.4010000000003,
"heapDeltaBytes": -5078284,
"heapUsedBytes": 85546568,
"domNodes": 13831,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 29.405,
"eventListeners": 2385,
"totalBlockingTimeMs": 142,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8611.500999999975,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6079.685,
"heapDeltaBytes": -7439676,
"heapUsedBytes": 69982700,
"domNodes": -280,
"jsHeapTotalBytes": 3829760,
"scriptDurationMs": 2938.6810000000005,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8313.967999999932,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.899,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5647.838,
"heapDeltaBytes": -12536940,
"heapUsedBytes": 67797212,
"domNodes": -267,
"jsHeapTotalBytes": -1273856,
"scriptDurationMs": 2707.4880000000003,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17200.924000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16695.472999999998,
"heapDeltaBytes": -51528308,
"heapUsedBytes": 178128092,
"domNodes": -8068,
"jsHeapTotalBytes": -20623360,
"scriptDurationMs": 343.55,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17291.054999999913,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16751.814,
"heapDeltaBytes": -50592684,
"heapUsedBytes": 178743884,
"domNodes": -8068,
"jsHeapTotalBytes": -18526208,
"scriptDurationMs": 267.70000000000005,
"eventListeners": -14929,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20898.207000000013,
"styleRecalcs": 173,
"styleRecalcDurationMs": 17.891999999999964,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20468.212,
"heapDeltaBytes": -52955124,
"heapUsedBytes": 166768828,
"domNodes": -8068,
"jsHeapTotalBytes": -12705792,
"scriptDurationMs": 891.2379999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 129,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21214.080999999966,
"styleRecalcs": 167,
"styleRecalcDurationMs": 18.479000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20818.010000000002,
"heapDeltaBytes": -31854008,
"heapUsedBytes": 194137244,
"domNodes": -8068,
"jsHeapTotalBytes": -15675392,
"scriptDurationMs": 969.22,
"eventListeners": -14923,
"totalBlockingTimeMs": 78,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6242.756000000043,
"styleRecalcs": 20,
"styleRecalcDurationMs": 90.416,
"layouts": 20,
"layoutDurationMs": 33.749999999999986,
"taskDurationMs": 6089.228,
"heapDeltaBytes": -47586920,
"heapUsedBytes": 176444048,
"domNodes": -8068,
"jsHeapTotalBytes": 3866624,
"scriptDurationMs": 105.58300000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 399,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6261.627999999973,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.50199999999997,
"layouts": 20,
"layoutDurationMs": 23.74699999999999,
"taskDurationMs": 6141.353,
"heapDeltaBytes": -33439524,
"heapUsedBytes": 189216628,
"domNodes": -8068,
"jsHeapTotalBytes": 10739712,
"scriptDurationMs": 105.731,
"eventListeners": -14927,
"totalBlockingTimeMs": 527,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8615.482000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8421.128999999999,
"heapDeltaBytes": 1864600,
"heapUsedBytes": 179172564,
"domNodes": 0,
"jsHeapTotalBytes": -22020096,
"scriptDurationMs": 139.276,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8689.154000000031,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8445.490999999998,
"heapDeltaBytes": 19013144,
"heapUsedBytes": 179732516,
"domNodes": 0,
"jsHeapTotalBytes": -10747904,
"scriptDurationMs": 135.18200000000002,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 111.70999999990272,
"styleRecalcs": 6,
"styleRecalcDurationMs": 15.046999999999999,
"layouts": 2,
"layoutDurationMs": 1.42,
"taskDurationMs": 74.17199999999998,
"heapDeltaBytes": 3039104,
"heapUsedBytes": 71797200,
"domNodes": 130,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.803000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 91.94999999999709,
"styleRecalcs": 8,
"styleRecalcDurationMs": 13.989999999999998,
"layouts": 2,
"layoutDurationMs": 1.0530000000000002,
"taskDurationMs": 66.721,
"heapDeltaBytes": 2986520,
"heapUsedBytes": 74910148,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.721999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 4 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 2 |
| 🟢 Low | 1 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #19989 +/- ##
=============================================
Coverage ? 84.25%
=============================================
Files ? 2131
Lines ? 127977
Branches ? 34746
=============================================
Hits ? 107826
Misses ? 19970
Partials ? 181
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
c3484e7 to
59013a1
Compare
There was a problem hiding this comment.
Verdict: Request changes. The live-frame part of #19726 is carried, but this PR drops one behavior hunk and two source tests, and it adds a pre-slice and a test that are not in the source.
I compared against #19726's merge commit 2409252b6459542be6493f05f27305b53f5df829, on top of #19705 (8a160ce919), which already carried an earlier revision to cloud/1.54.
Accounted for by the target: the persisted-skill half of #19726 is left out. That covers zPersistedToolCallSummary.skill, zAgentMessageContent.tool_calls, parseToolCallEntry and the "keeps a whole transcript readable" case. On cloud/1.54, zPersistedToolCallSummary has no skill field and parseToolCallEntry never reads one, so there is no persisted path for the clamp to protect. The zSkillName live-frame change, updateSkill, the last-outcome-wins fold, and the null-skill and Unicode-boundary cases match the source.
Divergences, each commented inline:
- 59013a1 adds
skill.slice(0, SKILL_NAME_MAX * 2)before the code-point clamp. #19726 does not have it. It answers an automated review finding and should land onmainfirst if it is wanted. foldActivitystill folds onprevious.skill === part.skillfor every tool (line 27). #19726 makes skill identity matter only forload_skill, so the fold no longer splits other tools on skill metadata they never display. It also adds the test "ignores skill metadata for tools that do not display it". Both are missing. This is a behavior change, not a review-only refactor, and #19727 carried it tocloud/1.55.agentActivityRows.test.tskeeps the old name "latches a failure and an in-flight call across the fold" on a test that now checks last-outcome-wins. The source renames it to "uses the latest settled outcome and retains the in-flight state". The PR also adds "uses the latest outcome across repeated retries", which is not in the source.agentApiSchema.test.tsfolds the source's "clamps an over-long skill instead of dropping the tool-call frame" case into the Unicode case. Please carry both source cases as written.agentEventTransport.test.tslikewise rewrites the source'sit.for([null, ''])case into a different shape. The source version uses onlydrive,toolPartsandzAgentWsEvent, which exist on this branch, so it should carry verbatim.
CI at 59013a1 is green (lint-and-format, test, e2e-status, typecheck).
Follow-up to #19989 after its post-merge review. - restores the skill-name completion fix on the current release branch - matches source clamping without the release-only pre-slice - folds non-`load_skill` activity independently of unused skill metadata - carries the source-equivalent schema, folding, and completion regressions Local commit hooks passed formatting, lint, and application typecheck. Focused Vitest collection was attempted, but this host injects an invalid `--localstorage-file` value and fails every suite in global setup; hosted CI is the authoritative test run. Related: #19726
Summary
Incremental backport of #19726 for
cloud/1.54after its original carrier #19705 landed.nullcompletion skill values without dropping the tool-call framenullor an empty stringValidation
git diff --check origin/cloud/1.54..HEADExcluded
Persisted-skill hydration is deliberately excluded because the earlier cloud/1.54 carrier retained this branch's older transcript contract. Review-only refactors and selector cleanup are also omitted.
Backport of #19726.