Skip to content

[backport cloud/1.54] fix(agent): preserve skill names on completion (#19726) - #19989

Merged
christian-byrne merged 2 commits into
cloud/1.54from
backport-19726-followup-to-cloud-1.54
Oct 3, 2026
Merged

christian-byrne merged 2 commits into
cloud/1.54from
backport-19726-followup-to-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Incremental backport of #19726 for cloud/1.54 after its original carrier #19705 landed.

  • accepts null completion skill values without dropping the tool-call frame
  • preserves an existing skill name when completion sends null or an empty string
  • clamps long names by Unicode code point
  • lets a later successful retry replace an earlier failed folded outcome

Validation

  • adds focused schema, event-transport, and activity-folding regression tests
  • git diff --check origin/cloud/1.54..HEAD
  • full agent unit and browser gates run in PR CI

Excluded

Persisted-skill hydration is deliberately excluded because the earlier cloud/1.54 carrier retained this branch's older transcript contract. Review-only refactors and selector cleanup are also omitted.

Backport of #19726.

@vercel

vercel Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 3, 2026 6:14pm UTC
billing-web-test Ignored Ignored Oct 3, 2026 6:14pm UTC

Request Review

@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR labels Oct 3, 2026
@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 75ba38cc-e400-4da6-a53d-0578beaf49c8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/03/2026, 06:16:28 PM UTC

Links

🎭 Playwright: ✅ 1990 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1969 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.4 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.5 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.0 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.3 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 142ms TBT · 81.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.7 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.2 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 104ms TBT · 172.1 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 463ms TBT · 174.4 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.0 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 557ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 60.6 MB
canvas-idle: DOM nodes -139
canvas-idle: event listeners -195
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 33ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 969ms
canvas-mouse-sweep: script duration 169ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 58.6 MB
canvas-mouse-sweep: DOM nodes -282
canvas-mouse-sweep: event listeners -165
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 20ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 391ms
canvas-zoom-sweep: script duration 13ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 73.4 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 21
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 457ms
dom-widget-clipping: script duration 163ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.7 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 598ms
large-graph-idle: script duration 36ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 69.9 MB
large-graph-idle: DOM nodes -275
large-graph-idle: event listeners -177
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1657ms
large-graph-pan: script duration 835ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 73.8 MB
large-graph-pan: DOM nodes -283
large-graph-pan: event listeners -192
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 68
large-graph-zoom: task duration 1812ms
large-graph-zoom: script duration 820ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 71.4 MB
large-graph-zoom: DOM nodes -264
large-graph-zoom: event listeners -181
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1916ms
legacy-node-drag: script duration 986ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 76.5 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 536ms
minimap-idle: script duration 37ms
minimap-idle: TBT 0ms
minimap-idle: heap used 70.1 MB
minimap-idle: DOM nodes -279
minimap-idle: event listeners -177
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 423ms
subgraph-dom-widget-clipping: script duration 144ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 62.4 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 10ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 536ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 69.0 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -226
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 28ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 854ms
subgraph-mouse-sweep: script duration 116ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 57.3 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -210
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 912ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 142ms
subgraph-transition-enter: heap used 81.6 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 38ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 5864ms
viewport-pan-sweep: script duration 2823ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 65.7 MB
viewport-pan-sweep: DOM nodes -274
viewport-pan-sweep: event listeners -162
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16724ms
vue-large-graph-idle: script duration 306ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.2 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14931
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 170
vue-large-graph-pan: task duration 20643ms
vue-large-graph-pan: script duration 930ms
vue-large-graph-pan: TBT 104ms
vue-large-graph-pan: heap used 172.1 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14925
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 29ms
vue-node-resize-workload: style recalc duration 88ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6115ms
vue-node-resize-workload: script duration 106ms
vue-node-resize-workload: TBT 463ms
vue-node-resize-workload: heap used 174.4 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8433ms
vue-zoom-out-idle: script duration 137ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 171.1 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 2
workflow-execution: style recalc count 7
workflow-execution: task duration 70ms
workflow-execution: script duration 5ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.0 MB
workflow-execution: DOM nodes 128
workflow-execution: event listeners 17
Raw data
{
  "timestamp": "2026-10-03T18:25:57.937Z",
  "gitSha": "0fcff0c74f859372d1f56e71436fd7f421163364",
  "branch": "backport-19726-followup-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2117.0009999999593,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.573,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 621.277,
      "heapDeltaBytes": -3427396,
      "heapUsedBytes": 69857408,
      "domNodes": -281,
      "jsHeapTotalBytes": 4755456,
      "scriptDurationMs": 12.754000000000001,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2051.8730000000005,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.129,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 493.62,
      "heapDeltaBytes": -13859356,
      "heapUsedBytes": 57235580,
      "domNodes": 3,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 9.026,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2075.61800000002,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 37.659,
      "layouts": 14,
      "layoutDurationMs": 4.106999999999999,
      "taskDurationMs": 1067.352,
      "heapDeltaBytes": -13008800,
      "heapUsedBytes": 58861332,
      "domNodes": -284,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 176.995,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1843.0819999999812,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 28.514999999999997,
      "layouts": 14,
      "layoutDurationMs": 4.121,
      "taskDurationMs": 871.4920000000001,
      "heapDeltaBytes": -9564444,
      "heapUsedBytes": 64074884,
      "domNodes": -280,
      "jsHeapTotalBytes": 2920448,
      "scriptDurationMs": 160.804,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1756.9500000000176,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 22.290999999999997,
      "layouts": 6,
      "layoutDurationMs": 1.2100000000000002,
      "taskDurationMs": 395.219,
      "heapDeltaBytes": 4659284,
      "heapUsedBytes": 78221680,
      "domNodes": 76,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 12.804,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1722.0439999999826,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.203999999999997,
      "layouts": 6,
      "layoutDurationMs": 1.1300000000000001,
      "taskDurationMs": 386.20300000000003,
      "heapDeltaBytes": 4484968,
      "heapUsedBytes": 75650120,
      "domNodes": 76,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 12.468,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 674.7439999999756,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 8.167,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 456.10200000000003,
      "heapDeltaBytes": -7825288,
      "heapUsedBytes": 63296324,
      "domNodes": 18,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 161.23399999999998,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 718.7149999999747,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 8.082,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 458.01800000000003,
      "heapDeltaBytes": 18165804,
      "heapUsedBytes": 89062308,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 165.48100000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2039.1559999999913,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.8020000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 607.4709999999999,
      "heapDeltaBytes": -7649468,
      "heapUsedBytes": 69988956,
      "domNodes": -283,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 39.54200000000001,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2037.4100000000226,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.62,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 587.5509999999999,
      "heapDeltaBytes": -3852492,
      "heapUsedBytes": 76530856,
      "domNodes": -266,
      "jsHeapTotalBytes": -2846720,
      "scriptDurationMs": 33.215,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2210.9850000000506,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.45,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1600.536,
      "heapDeltaBytes": -9520776,
      "heapUsedBytes": 68648668,
      "domNodes": -282,
      "jsHeapTotalBytes": 4091904,
      "scriptDurationMs": 809.528,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2359.3230000000176,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.710999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1713.5950000000003,
      "heapDeltaBytes": 7507744,
      "heapUsedBytes": 86126708,
      "domNodes": -284,
      "jsHeapTotalBytes": 385024,
      "scriptDurationMs": 861.468,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3756.1900000000037,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 14.754999999999999,
      "layouts": 60,
      "layoutDurationMs": 12.570000000000002,
      "taskDurationMs": 1857.3179999999998,
      "heapDeltaBytes": -1532244,
      "heapUsedBytes": 78779884,
      "domNodes": -262,
      "jsHeapTotalBytes": 2781184,
      "scriptDurationMs": 836.1429999999999,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3621.097999999961,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.021,
      "layouts": 60,
      "layoutDurationMs": 12.161000000000001,
      "taskDurationMs": 1767.218,
      "heapDeltaBytes": -8541396,
      "heapUsedBytes": 71059756,
      "domNodes": -265,
      "jsHeapTotalBytes": 3043328,
      "scriptDurationMs": 804.299,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3083.9839999999867,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.855999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1897.5090000000002,
      "heapDeltaBytes": 7631464,
      "heapUsedBytes": 75799100,
      "domNodes": 0,
      "jsHeapTotalBytes": 1503232,
      "scriptDurationMs": 983.9050000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3089.9910000000546,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.974000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1934.6029999999998,
      "heapDeltaBytes": 16514788,
      "heapUsedBytes": 84695092,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 988.8530000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2044.5470000000228,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.526999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 565.706,
      "heapDeltaBytes": -9958016,
      "heapUsedBytes": 69579696,
      "domNodes": -284,
      "jsHeapTotalBytes": -1150976,
      "scriptDurationMs": 34.82500000000001,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2012.2539999999844,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 4.4270000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 506.68100000000004,
      "heapDeltaBytes": 11220328,
      "heapUsedBytes": 77451740,
      "domNodes": -273,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 39.734,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 605.021000000022,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.341,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 420.14700000000005,
      "heapDeltaBytes": -10653132,
      "heapUsedBytes": 65430244,
      "domNodes": 20,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 142.642,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 592.5389999999879,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.835000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 425.20000000000005,
      "heapDeltaBytes": -10645468,
      "heapUsedBytes": 65452188,
      "domNodes": 20,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 145.227,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2023.3839999999645,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.867999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 531.985,
      "heapDeltaBytes": -11215420,
      "heapUsedBytes": 61142340,
      "domNodes": -297,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 9.701999999999998,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.304999999984,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.558000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 539.024,
      "heapDeltaBytes": 7787392,
      "heapUsedBytes": 83484116,
      "domNodes": -296,
      "jsHeapTotalBytes": 4231168,
      "scriptDurationMs": 10.234,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1719.658000000038,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 27.519,
      "layouts": 18,
      "layoutDurationMs": 4.574,
      "taskDurationMs": 838.3680000000002,
      "heapDeltaBytes": -13792184,
      "heapUsedBytes": 62007504,
      "domNodes": -297,
      "jsHeapTotalBytes": 5541888,
      "scriptDurationMs": 109.929,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1794.181999999978,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 28.355999999999998,
      "layouts": 18,
      "layoutDurationMs": 4.577999999999999,
      "taskDurationMs": 868.644,
      "heapDeltaBytes": -17710888,
      "heapUsedBytes": 58124820,
      "domNodes": -295,
      "jsHeapTotalBytes": 4755456,
      "scriptDurationMs": 122.098,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1367.525999999998,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 32.260999999999996,
      "layouts": 15,
      "layoutDurationMs": 15.764000000000003,
      "taskDurationMs": 912.4010000000003,
      "heapDeltaBytes": -5078284,
      "heapUsedBytes": 85546568,
      "domNodes": 13831,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 29.405,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 142,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8611.500999999975,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 39.998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6079.685,
      "heapDeltaBytes": -7439676,
      "heapUsedBytes": 69982700,
      "domNodes": -280,
      "jsHeapTotalBytes": 3829760,
      "scriptDurationMs": 2938.6810000000005,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8313.967999999932,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 36.899,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5647.838,
      "heapDeltaBytes": -12536940,
      "heapUsedBytes": 67797212,
      "domNodes": -267,
      "jsHeapTotalBytes": -1273856,
      "scriptDurationMs": 2707.4880000000003,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17200.924000000043,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16695.472999999998,
      "heapDeltaBytes": -51528308,
      "heapUsedBytes": 178128092,
      "domNodes": -8068,
      "jsHeapTotalBytes": -20623360,
      "scriptDurationMs": 343.55,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17291.054999999913,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16751.814,
      "heapDeltaBytes": -50592684,
      "heapUsedBytes": 178743884,
      "domNodes": -8068,
      "jsHeapTotalBytes": -18526208,
      "scriptDurationMs": 267.70000000000005,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20898.207000000013,
      "styleRecalcs": 173,
      "styleRecalcDurationMs": 17.891999999999964,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20468.212,
      "heapDeltaBytes": -52955124,
      "heapUsedBytes": 166768828,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12705792,
      "scriptDurationMs": 891.2379999999999,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 129,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21214.080999999966,
      "styleRecalcs": 167,
      "styleRecalcDurationMs": 18.479000000000024,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20818.010000000002,
      "heapDeltaBytes": -31854008,
      "heapUsedBytes": 194137244,
      "domNodes": -8068,
      "jsHeapTotalBytes": -15675392,
      "scriptDurationMs": 969.22,
      "eventListeners": -14923,
      "totalBlockingTimeMs": 78,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6242.756000000043,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 90.416,
      "layouts": 20,
      "layoutDurationMs": 33.749999999999986,
      "taskDurationMs": 6089.228,
      "heapDeltaBytes": -47586920,
      "heapUsedBytes": 176444048,
      "domNodes": -8068,
      "jsHeapTotalBytes": 3866624,
      "scriptDurationMs": 105.58300000000001,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 399,
      "frameDurationMs": 18.889999999999965,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6261.627999999973,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 85.50199999999997,
      "layouts": 20,
      "layoutDurationMs": 23.74699999999999,
      "taskDurationMs": 6141.353,
      "heapDeltaBytes": -33439524,
      "heapUsedBytes": 189216628,
      "domNodes": -8068,
      "jsHeapTotalBytes": 10739712,
      "scriptDurationMs": 105.731,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 527,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8615.482000000044,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8421.128999999999,
      "heapDeltaBytes": 1864600,
      "heapUsedBytes": 179172564,
      "domNodes": 0,
      "jsHeapTotalBytes": -22020096,
      "scriptDurationMs": 139.276,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8689.154000000031,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8445.490999999998,
      "heapDeltaBytes": 19013144,
      "heapUsedBytes": 179732516,
      "domNodes": 0,
      "jsHeapTotalBytes": -10747904,
      "scriptDurationMs": 135.18200000000002,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 111.70999999990272,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 15.046999999999999,
      "layouts": 2,
      "layoutDurationMs": 1.42,
      "taskDurationMs": 74.17199999999998,
      "heapDeltaBytes": 3039104,
      "heapUsedBytes": 71797200,
      "domNodes": 130,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.803000000000001,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 91.94999999999709,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 13.989999999999998,
      "layouts": 2,
      "layoutDurationMs": 1.0530000000000002,
      "taskDurationMs": 66.721,
      "heapDeltaBytes": 2986520,
      "heapUsedBytes": 74910148,
      "domNodes": 126,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.721999999999999,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 51043 76357 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1173
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.7% 255
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 4 finding(s).

Severity Count
🟡 Medium 2
🟢 Low 1
⚪ Nit 1

Panel: 8/8 reviewers contributed findings.

@codecov

codecov Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #19989   +/-   ##
=============================================
  Coverage              ?   84.25%           
=============================================
  Files                 ?     2131           
  Lines                 ?   127977           
  Branches              ?    34746           
=============================================
  Hits                  ?   107826           
  Misses                ?    19970           
  Partials              ?      181           
Flag Coverage Δ
e2e 66.90% <ø> (?)
unit 79.54% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rkbench/extensions/agent/schemas/agentApiSchema.ts 100.00% <100.00%> (ø)
...tensions/agent/services/agent/agentActivityRows.ts 100.00% <100.00%> (ø)
...nsions/agent/services/agent/agentEventTransport.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 3, 2026
@christian-byrne
christian-byrne force-pushed the backport-19726-followup-to-cloud-1.54 branch from c3484e7 to 59013a1 Compare October 3, 2026 18:14
@mrseek-reviews
mrseek-reviews Bot requested a review from DrJKL October 3, 2026 19:26

@mrseek-reviews mrseek-reviews Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: Request changes. The live-frame part of #19726 is carried, but this PR drops one behavior hunk and two source tests, and it adds a pre-slice and a test that are not in the source.

I compared against #19726's merge commit 2409252b6459542be6493f05f27305b53f5df829, on top of #19705 (8a160ce919), which already carried an earlier revision to cloud/1.54.

Accounted for by the target: the persisted-skill half of #19726 is left out. That covers zPersistedToolCallSummary.skill, zAgentMessageContent.tool_calls, parseToolCallEntry and the "keeps a whole transcript readable" case. On cloud/1.54, zPersistedToolCallSummary has no skill field and parseToolCallEntry never reads one, so there is no persisted path for the clamp to protect. The zSkillName live-frame change, updateSkill, the last-outcome-wins fold, and the null-skill and Unicode-boundary cases match the source.

Divergences, each commented inline:

  1. 59013a1 adds skill.slice(0, SKILL_NAME_MAX * 2) before the code-point clamp. #19726 does not have it. It answers an automated review finding and should land on main first if it is wanted.
  2. foldActivity still folds on previous.skill === part.skill for every tool (line 27). #19726 makes skill identity matter only for load_skill, so the fold no longer splits other tools on skill metadata they never display. It also adds the test "ignores skill metadata for tools that do not display it". Both are missing. This is a behavior change, not a review-only refactor, and #19727 carried it to cloud/1.55.
  3. agentActivityRows.test.ts keeps the old name "latches a failure and an in-flight call across the fold" on a test that now checks last-outcome-wins. The source renames it to "uses the latest settled outcome and retains the in-flight state". The PR also adds "uses the latest outcome across repeated retries", which is not in the source.
  4. agentApiSchema.test.ts folds the source's "clamps an over-long skill instead of dropping the tool-call frame" case into the Unicode case. Please carry both source cases as written. agentEventTransport.test.ts likewise rewrites the source's it.for([null, '']) case into a different shape. The source version uses only drive, toolParts and zAgentWsEvent, which exist on this branch, so it should carry verbatim.

CI at 59013a1 is green (lint-and-format, test, e2e-status, typecheck).

@christian-byrne christian-byrne removed the cursor-review Trigger multi-model Cursor agent review on this PR label Oct 3, 2026
@christian-byrne
christian-byrne merged commit c263490 into cloud/1.54 Oct 3, 2026
116 checks passed
@christian-byrne
christian-byrne deleted the backport-19726-followup-to-cloud-1.54 branch October 3, 2026 22:12
christian-byrne added a commit that referenced this pull request Oct 3, 2026
Follow-up to #19989 after its post-merge review.

- restores the skill-name completion fix on the current release branch
- matches source clamping without the release-only pre-slice
- folds non-`load_skill` activity independently of unused skill metadata
- carries the source-equivalent schema, folding, and completion
regressions

Local commit hooks passed formatting, lint, and application typecheck.
Focused Vitest collection was attempted, but this host injects an
invalid `--localstorage-file` value and fails every suite in global
setup; hosted CI is the authoritative test run.

Related: #19726
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants