Skip to content

fix(agent): restore skill-name parity on cloud/1.54 - #20041

Merged
christian-byrne merged 1 commit into
cloud/1.54from
christian/followup-19989-cloud-1.54
Oct 3, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.54from
christian/followup-19989-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Follow-up to #19989 after its post-merge review.

  • restores the skill-name completion fix on the current release branch
  • matches source clamping without the release-only pre-slice
  • folds non-load_skill activity independently of unused skill metadata
  • carries the source-equivalent schema, folding, and completion regressions

Local commit hooks passed formatting, lint, and application typecheck. Focused Vitest collection was attempted, but this host injects an invalid --localstorage-file value and fails every suite in global setup; hosted CI is the authoritative test run.

Related: #19726

@vercel

vercel Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 3, 2026 10:43pm UTC
billing-web-test Ignored Ignored Oct 3, 2026 10:43pm UTC

Request Review

@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned) labels Oct 3, 2026
@christian-byrne christian-byrne self-assigned this Oct 3, 2026
@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: cd9a310d-99da-462d-a652-f858671bccc1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions
github-actions Bot requested a review from ryan-di October 3, 2026 22:42
@christian-byrne
christian-byrne force-pushed the christian/followup-19989-cloud-1.54 branch from a02afae to 87c1b2d Compare October 3, 2026 22:43
@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/03/2026, 10:45:39 PM UTC

Links

🎭 Playwright: ✅ 1988 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1967 / ❌ 0 / ⚠️ 2 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.9 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.4 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 94ms TBT · 85.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 88.2 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.1 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 15ms TBT · 171.8 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 305ms TBT · 171.9 MB heap
vue-zoom-out-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 173.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 450ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 66.3 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -165
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 23ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 717ms
canvas-mouse-sweep: script duration 121ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 62.0 MB
canvas-mouse-sweep: DOM nodes -283
canvas-mouse-sweep: event listeners -195
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 14ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 324ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 73.5 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 6ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 373ms
dom-widget-clipping: script duration 132ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 74.1 MB
dom-widget-clipping: DOM nodes 16
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 446ms
large-graph-idle: script duration 29ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 73.4 MB
large-graph-idle: DOM nodes -267
large-graph-idle: event listeners -161
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1301ms
large-graph-pan: script duration 648ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 79.9 MB
large-graph-pan: DOM nodes -282
large-graph-pan: event listeners -190
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 70
large-graph-zoom: task duration 1408ms
large-graph-zoom: script duration 642ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 80.9 MB
large-graph-zoom: DOM nodes 34
large-graph-zoom: event listeners 8
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 1541ms
legacy-node-drag: script duration 777ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 78.4 MB
legacy-node-drag: DOM nodes -120
legacy-node-drag: event listeners 87
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 7
minimap-idle: task duration 552ms
minimap-idle: script duration 35ms
minimap-idle: TBT 0ms
minimap-idle: heap used 78.3 MB
minimap-idle: DOM nodes -283
minimap-idle: event listeners -190
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 361ms
subgraph-dom-widget-clipping: script duration 123ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.4 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 422ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 62.5 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -210
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 24ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 682ms
subgraph-mouse-sweep: script duration 88ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 73.4 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -225
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 26ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 787ms
subgraph-transition-enter: script duration 26ms
subgraph-transition-enter: TBT 94ms
subgraph-transition-enter: heap used 85.6 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 40ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4672ms
viewport-pan-sweep: script duration 2185ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 88.2 MB
viewport-pan-sweep: DOM nodes -279
viewport-pan-sweep: event listeners -175
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 14753ms
vue-large-graph-idle: script duration 226ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.1 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14931
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 132
vue-large-graph-pan: task duration 17634ms
vue-large-graph-pan: script duration 778ms
vue-large-graph-pan: TBT 15ms
vue-large-graph-pan: heap used 171.8 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14930
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 65ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5476ms
vue-node-resize-workload: script duration 106ms
vue-node-resize-workload: TBT 305ms
vue-node-resize-workload: heap used 171.9 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7444ms
vue-zoom-out-idle: script duration 117ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 173.1 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -11
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 11ms
workflow-execution: layout count 2
workflow-execution: style recalc count 6
workflow-execution: task duration 55ms
workflow-execution: script duration 5ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.5 MB
workflow-execution: DOM nodes 115
workflow-execution: event listeners 25
Raw data
{
  "timestamp": "2026-10-03T22:53:42.815Z",
  "gitSha": "1ad8415ae4f50315308faeb6ce4bf34ffa3e26fd",
  "branch": "christian/followup-19989-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2070.6969999999956,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.814,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 457.4219999999999,
      "heapDeltaBytes": -6813780,
      "heapUsedBytes": 66431280,
      "domNodes": -280,
      "jsHeapTotalBytes": 3969024,
      "scriptDurationMs": 8.291999999999998,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2024.904000000106,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.949999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 442.72900000000004,
      "heapDeltaBytes": 1591648,
      "heapUsedBytes": 72604468,
      "domNodes": -281,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.898,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1743.312000000003,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 21.887,
      "layouts": 14,
      "layoutDurationMs": 3.3899999999999997,
      "taskDurationMs": 702.6779999999999,
      "heapDeltaBytes": -10147124,
      "heapUsedBytes": 60593772,
      "domNodes": -283,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 119.155,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1757.788000000005,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 23.982999999999997,
      "layouts": 14,
      "layoutDurationMs": 3.945,
      "taskDurationMs": 730.533,
      "heapDeltaBytes": -3938908,
      "heapUsedBytes": 69368684,
      "domNodes": -282,
      "jsHeapTotalBytes": 4231168,
      "scriptDurationMs": 121.86899999999999,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1669.1180000000259,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 12.726999999999999,
      "layouts": 6,
      "layoutDurationMs": 0.885,
      "taskDurationMs": 288.588,
      "heapDeltaBytes": 4425664,
      "heapUsedBytes": 76103100,
      "domNodes": 77,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 9.646,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1657.4360000000752,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 14.992,
      "layouts": 6,
      "layoutDurationMs": 1.1159999999999999,
      "taskDurationMs": 359.805,
      "heapDeltaBytes": 4857492,
      "heapUsedBytes": 77951760,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 13.441,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 528.0210000000238,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 4.999999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 365.313,
      "heapDeltaBytes": -7465104,
      "heapUsedBytes": 66456944,
      "domNodes": 14,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 130.554,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 547.819000000004,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 6.694999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 381.459,
      "heapDeltaBytes": 17926388,
      "heapUsedBytes": 89031520,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 132.722,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2034.9239999999895,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 7.325,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 438.612,
      "heapDeltaBytes": -3318700,
      "heapUsedBytes": 77140376,
      "domNodes": -267,
      "jsHeapTotalBytes": -2584576,
      "scriptDurationMs": 28.613,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2022.4050000000489,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.132999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 452.40899999999993,
      "heapDeltaBytes": -3151376,
      "heapUsedBytes": 76781540,
      "domNodes": -267,
      "jsHeapTotalBytes": -2584576,
      "scriptDurationMs": 30.067000000000004,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2166.603000000009,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.712,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1286.094,
      "heapDeltaBytes": -1186360,
      "heapUsedBytes": 77319540,
      "domNodes": -285,
      "jsHeapTotalBytes": 3792896,
      "scriptDurationMs": 640.0389999999999,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2152.1189999999706,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.770000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1316.47,
      "heapDeltaBytes": 8905388,
      "heapUsedBytes": 90274348,
      "domNodes": -279,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 655.3359999999999,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3153.8400000000024,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 13.924999999999999,
      "layouts": 60,
      "layoutDurationMs": 11.821,
      "taskDurationMs": 1344.363,
      "heapDeltaBytes": 4849348,
      "heapUsedBytes": 84664924,
      "domNodes": 34,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 616.1229999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3302.6230000000396,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 15.347,
      "layouts": 60,
      "layoutDurationMs": 12.722000000000001,
      "taskDurationMs": 1471.5060000000003,
      "heapDeltaBytes": 5218396,
      "heapUsedBytes": 84903152,
      "domNodes": 34,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 667.51,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2269.7069999999826,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 7.791000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1515.4709999999998,
      "heapDeltaBytes": 13986568,
      "heapUsedBytes": 96688152,
      "domNodes": 10,
      "jsHeapTotalBytes": 5660672,
      "scriptDurationMs": 772.41,
      "eventListeners": 184,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2243.4729999999945,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 8.703000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1566.8519999999999,
      "heapDeltaBytes": -17832664,
      "heapUsedBytes": 67721432,
      "domNodes": -250,
      "jsHeapTotalBytes": -1273856,
      "scriptDurationMs": 781.76,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2015.2289999999766,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.393000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 472.1099999999999,
      "heapDeltaBytes": 12929400,
      "heapUsedBytes": 92521720,
      "domNodes": -284,
      "jsHeapTotalBytes": -1150976,
      "scriptDurationMs": 28.762000000000004,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2084.2269999999417,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.045000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 631.8290000000001,
      "heapDeltaBytes": -10500748,
      "heapUsedBytes": 71635984,
      "domNodes": -281,
      "jsHeapTotalBytes": -1011712,
      "scriptDurationMs": 40.718,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 530.4109999999582,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 8.565999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 323.146,
      "heapDeltaBytes": 14021292,
      "heapUsedBytes": 86724204,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 112.48100000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 589.603000000011,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.618,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 398.30299999999994,
      "heapDeltaBytes": 14841884,
      "heapUsedBytes": 88180032,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 133.216,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.7569999999796,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.813999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 425.15400000000005,
      "heapDeltaBytes": -10787144,
      "heapUsedBytes": 64136148,
      "domNodes": -297,
      "jsHeapTotalBytes": 4231168,
      "scriptDurationMs": 8.193999999999999,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.7270000000453,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.971000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 419.64199999999994,
      "heapDeltaBytes": -8769720,
      "heapUsedBytes": 66934616,
      "domNodes": -296,
      "jsHeapTotalBytes": 4493312,
      "scriptDurationMs": 8.149999999999999,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1704.0099999999825,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 24.368,
      "layouts": 18,
      "layoutDurationMs": 4.294,
      "taskDurationMs": 679.723,
      "heapDeltaBytes": 9036224,
      "heapUsedBytes": 82542640,
      "domNodes": -295,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 87.065,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1725.8419999999433,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 23.946,
      "layouts": 18,
      "layoutDurationMs": 4.007000000000001,
      "taskDurationMs": 683.37,
      "heapDeltaBytes": -4637916,
      "heapUsedBytes": 71378748,
      "domNodes": -295,
      "jsHeapTotalBytes": 5279744,
      "scriptDurationMs": 88.94000000000001,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1084.9130000000287,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 26.350999999999992,
      "layouts": 15,
      "layoutDurationMs": 12.046999999999999,
      "taskDurationMs": 787.1670000000001,
      "heapDeltaBytes": -5126700,
      "heapUsedBytes": 89743196,
      "domNodes": 13831,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 25.90900000000001,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 94,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8193.62000000001,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 39.902,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4484.201000000001,
      "heapDeltaBytes": 5735520,
      "heapUsedBytes": 86127448,
      "domNodes": -276,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 2150.9300000000003,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8328.204000000027,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 40.368,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4859.447,
      "heapDeltaBytes": 21343616,
      "heapUsedBytes": 98752580,
      "domNodes": -281,
      "jsHeapTotalBytes": 122880,
      "scriptDurationMs": 2219.46,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14879.226000000017,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14411.551,
      "heapDeltaBytes": -33094296,
      "heapUsedBytes": 179521004,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12304384,
      "scriptDurationMs": 220.11999999999998,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15464.566999999988,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15094.233000000002,
      "heapDeltaBytes": -40870160,
      "heapUsedBytes": 179342400,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11530240,
      "scriptDurationMs": 232.55600000000004,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.33666666666662,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17784.09099999999,
      "styleRecalcs": 136,
      "styleRecalcDurationMs": 15.759000000000023,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17464.571,
      "heapDeltaBytes": -37746744,
      "heapUsedBytes": 180262608,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12840960,
      "scriptDurationMs": 760.798,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 10,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17908.07100000006,
      "styleRecalcs": 127,
      "styleRecalcDurationMs": 17.77200000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17803.867000000002,
      "heapDeltaBytes": -54906572,
      "heapUsedBytes": 180039072,
      "domNodes": -8068,
      "jsHeapTotalBytes": -14639104,
      "scriptDurationMs": 795.2819999999999,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 19,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5461.799000000042,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 60.301999999999964,
      "layouts": 20,
      "layoutDurationMs": 21.917999999999992,
      "taskDurationMs": 5401.9490000000005,
      "heapDeltaBytes": -40247744,
      "heapUsedBytes": 177736612,
      "domNodes": -8068,
      "jsHeapTotalBytes": 10706944,
      "scriptDurationMs": 115.63299999999998,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 248,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5604.070999999976,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 68.93400000000003,
      "layouts": 20,
      "layoutDurationMs": 24.985000000000007,
      "taskDurationMs": 5549.362,
      "heapDeltaBytes": -51077040,
      "heapUsedBytes": 182667012,
      "domNodes": -8068,
      "jsHeapTotalBytes": 9453568,
      "scriptDurationMs": 97.16999999999999,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 361,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7498.097999999914,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7384.075000000001,
      "heapDeltaBytes": -1019120,
      "heapUsedBytes": 170141572,
      "domNodes": 0,
      "jsHeapTotalBytes": -3932160,
      "scriptDurationMs": 115.42199999999997,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7663.813000000005,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7504.071999999999,
      "heapDeltaBytes": 24112436,
      "heapUsedBytes": 192812128,
      "domNodes": 0,
      "jsHeapTotalBytes": -20971520,
      "scriptDurationMs": 119.33600000000006,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 68.9630000000534,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 9.408000000000001,
      "layouts": 2,
      "layoutDurationMs": 0.5719999999999998,
      "taskDurationMs": 52.329999999999984,
      "heapDeltaBytes": 3107620,
      "heapUsedBytes": 72841264,
      "domNodes": 105,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 5.612000000000001,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "workflow-execution",
      "durationMs": 81.93800000003648,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 12.901,
      "layouts": 2,
      "layoutDurationMs": 1.0010000000000001,
      "taskDurationMs": 57.51199999999999,
      "heapDeltaBytes": 2973740,
      "heapUsedBytes": 74946204,
      "domNodes": 124,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 4.519,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 51030 76357 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1173
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.7% 255
src/scripts/pnginfo.ts 21.4% 221

@codecov

codecov Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #20041   +/-   ##
=============================================
  Coverage              ?   84.24%           
=============================================
  Files                 ?     2131           
  Lines                 ?   127979           
  Branches              ?    34747           
=============================================
  Hits                  ?   107822           
  Misses                ?    19976           
  Partials              ?      181           
Flag Coverage Δ
e2e 66.88% <ø> (?)
unit 79.54% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rkbench/extensions/agent/schemas/agentApiSchema.ts 100.00% <100.00%> (ø)
...tensions/agent/services/agent/agentActivityRows.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne merged commit 3242b4f into cloud/1.54 Oct 3, 2026
95 checks passed
@christian-byrne
christian-byrne deleted the christian/followup-19989-cloud-1.54 branch October 3, 2026 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant