Repository navigation
fix(agent): complete persisted skill coverage on cloud/1.55 - #20032
Conversation
Addresses review feedback: #19987 (comment)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2145 passed, 0 failed · 2 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 49fbd54429a0e7cab957204860ee8661e4650c97
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-03T22:28:20.915Z",
"gitSha": "f5f7b6c5acde59356b3eebb60defe263f23ac7f3",
"branch": "christian/followup-19987-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2006.7869999999743,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.5729999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.78099999999995,
"heapDeltaBytes": 2732208,
"heapUsedBytes": 71565332,
"domNodes": -260,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.729999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1992.9270000000088,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.914999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.9339999999999,
"heapDeltaBytes": 3793636,
"heapUsedBytes": 72591684,
"domNodes": -262,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.411999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1724.3680000000268,
"styleRecalcs": 45,
"styleRecalcDurationMs": 13.487000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 734.287,
"heapDeltaBytes": -3994428,
"heapUsedBytes": 65116752,
"domNodes": -260,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 131.495,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1739.6290000000363,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.102999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 732.629,
"heapDeltaBytes": -7485740,
"heapUsedBytes": 61602484,
"domNodes": -261,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 131.50900000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1691.071000000079,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.062,
"layouts": 6,
"layoutDurationMs": 1.2870000000000001,
"taskDurationMs": 305.32000000000005,
"heapDeltaBytes": 2486908,
"heapUsedBytes": 65328736,
"domNodes": 76,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.995000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1698.028000000022,
"styleRecalcs": 30,
"styleRecalcDurationMs": 12.565,
"layouts": 6,
"layoutDurationMs": 1.0279999999999998,
"taskDurationMs": 315.31100000000004,
"heapDeltaBytes": 3314152,
"heapUsedBytes": 71733636,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.186,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 591.9140000000311,
"styleRecalcs": 14,
"styleRecalcDurationMs": 7.464000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.69,
"heapDeltaBytes": -7654888,
"heapUsedBytes": 61377828,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 146.444,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 601.9119999999702,
"styleRecalcs": 15,
"styleRecalcDurationMs": 7.006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.22499999999997,
"heapDeltaBytes": -7967676,
"heapUsedBytes": 61110976,
"domNodes": 22,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 143.58700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1144.6209999999724,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 830.297,
"heapDeltaBytes": -18426516,
"heapUsedBytes": 73016092,
"domNodes": -296,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 55.469,
"eventListeners": -217,
"totalBlockingTimeMs": 487,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1112.6390000000583,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 756.787,
"heapDeltaBytes": 12102552,
"heapUsedBytes": 83924964,
"domNodes": 0,
"jsHeapTotalBytes": 20606976,
"scriptDurationMs": 53.736999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 493,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 761.9019999999637,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.6389999999996,
"heapDeltaBytes": 15196088,
"heapUsedBytes": 90695052,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 122.083,
"eventListeners": 0,
"totalBlockingTimeMs": 149,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 778.5369999999148,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.90199999999976,
"heapDeltaBytes": 16142180,
"heapUsedBytes": 91563624,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 123.46200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 155,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7837.392000000023,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.573999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6948.282000000001,
"heapDeltaBytes": 5677216,
"heapUsedBytes": 85059064,
"domNodes": -263,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 5737.921,
"eventListeners": -174,
"totalBlockingTimeMs": 189,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.20000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7737.792000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6837.126,
"heapDeltaBytes": -11506668,
"heapUsedBytes": 69581768,
"domNodes": -16,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 5397.283,
"eventListeners": 0,
"totalBlockingTimeMs": 55,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8361.647000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7476.463000000001,
"heapDeltaBytes": -8128584,
"heapUsedBytes": 73111376,
"domNodes": -14,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 5947.043000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 132,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7143.0509999999,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.6439999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6516.197,
"heapDeltaBytes": -6267392,
"heapUsedBytes": 72865324,
"domNodes": -263,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 5351.426,
"eventListeners": -174,
"totalBlockingTimeMs": 73,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2040.0869999999713,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.179999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.521,
"heapDeltaBytes": -23622024,
"heapUsedBytes": 65877156,
"domNodes": -253,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 35.023999999999994,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2031.1289999999644,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.412999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.6229999999998,
"heapDeltaBytes": -23668784,
"heapUsedBytes": 65604340,
"domNodes": -253,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 31.909999999999993,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2162.943000000041,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.719999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1426.1770000000001,
"heapDeltaBytes": -7548804,
"heapUsedBytes": 76021404,
"domNodes": -260,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 707.1370000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2156.0329999999794,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.315999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1409.4540000000002,
"heapDeltaBytes": 347768,
"heapUsedBytes": 64989080,
"domNodes": -245,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 736.071,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3373.3589999999367,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.808999999999997,
"layouts": 60,
"layoutDurationMs": 14.47,
"taskDurationMs": 1468.13,
"heapDeltaBytes": -657936,
"heapUsedBytes": 65265728,
"domNodes": 32,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 670.058,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3500.9810000000243,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.274000000000003,
"layouts": 60,
"layoutDurationMs": 15.315999999999999,
"taskDurationMs": 1498.1409999999998,
"heapDeltaBytes": -282392,
"heapUsedBytes": 65978592,
"domNodes": 30,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 697.487,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2946.1000000000013,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.657999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1748.4959999999999,
"heapDeltaBytes": -17496792,
"heapUsedBytes": 76103316,
"domNodes": 14,
"jsHeapTotalBytes": 7114752,
"scriptDurationMs": 895.359,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333326,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2885.4570000000876,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.2989999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1711.2340000000002,
"heapDeltaBytes": 7489520,
"heapUsedBytes": 73232144,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 901.655,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2032.2759999999107,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.297999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.3589999999999,
"heapDeltaBytes": -23828848,
"heapUsedBytes": 67350236,
"domNodes": -254,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 37.78699999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2043.2399999999689,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.480000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.721,
"heapDeltaBytes": -24160864,
"heapUsedBytes": 67362764,
"domNodes": -257,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 32.203,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 547.2340000000031,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.226999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 357.53799999999995,
"heapDeltaBytes": 12939468,
"heapUsedBytes": 83767264,
"domNodes": 22,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 121.45100000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 565.072999999984,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.793000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 357.55800000000005,
"heapDeltaBytes": 13220164,
"heapUsedBytes": 83928128,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 123.39299999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2002.4119999999925,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.722,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.018,
"heapDeltaBytes": -2526892,
"heapUsedBytes": 68149604,
"domNodes": -272,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 7.808999999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2003.5030000000233,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.189000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 350.43899999999996,
"heapDeltaBytes": -7236140,
"heapUsedBytes": 63380756,
"domNodes": -273,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.033999999999997,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.4210000000203,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.569999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 587.5160000000001,
"heapDeltaBytes": -9587472,
"heapUsedBytes": 61298308,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 84.088,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1671.5110000000095,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.94,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 670.0630000000001,
"heapDeltaBytes": -12295028,
"heapUsedBytes": 58593216,
"domNodes": -275,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 84.184,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 966.6580000000522,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.879000000000005,
"layouts": 5,
"layoutDurationMs": 9.858999999999998,
"taskDurationMs": 789.042,
"heapDeltaBytes": 20141208,
"heapUsedBytes": 103914132,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 24.095000000000006,
"eventListeners": 2383,
"totalBlockingTimeMs": 133,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8197.894000000018,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.497,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4836.330999999999,
"heapDeltaBytes": 3039460,
"heapUsedBytes": 91892140,
"domNodes": -237,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 2303.446,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8189.02700000001,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.742,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4938.745000000001,
"heapDeltaBytes": -8548196,
"heapUsedBytes": 80940492,
"domNodes": -251,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 2379.9509999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14456.522999999946,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13778.537999999999,
"heapDeltaBytes": -59128392,
"heapUsedBytes": 181931556,
"domNodes": -8061,
"jsHeapTotalBytes": -21172224,
"scriptDurationMs": 255.562,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14529.01099999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14004.966,
"heapDeltaBytes": -59229620,
"heapUsedBytes": 182055344,
"domNodes": -8061,
"jsHeapTotalBytes": -19861504,
"scriptDurationMs": 226.84199999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17960.73899999999,
"styleRecalcs": 148,
"styleRecalcDurationMs": 18.985000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17701.3,
"heapDeltaBytes": -71341660,
"heapUsedBytes": 169681184,
"domNodes": -8066,
"jsHeapTotalBytes": -20385792,
"scriptDurationMs": 885.6729999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 27,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17586.15199999997,
"styleRecalcs": 131,
"styleRecalcDurationMs": 18.634999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17411.977,
"heapDeltaBytes": -38829272,
"heapUsedBytes": 182191028,
"domNodes": -8062,
"jsHeapTotalBytes": -19861504,
"scriptDurationMs": 869.2500000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 74,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4053.134,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.82699999999997,
"layouts": 20,
"layoutDurationMs": 24.913000000000004,
"taskDurationMs": 3945.2669999999994,
"heapDeltaBytes": -46877648,
"heapUsedBytes": 194120668,
"domNodes": -8062,
"jsHeapTotalBytes": 11595776,
"scriptDurationMs": 79.005,
"eventListeners": -14927,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5234.336999999982,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.327,
"layouts": 20,
"layoutDurationMs": 26.038000000000004,
"taskDurationMs": 5197.056,
"heapDeltaBytes": -46726020,
"heapUsedBytes": 194387064,
"domNodes": -8062,
"jsHeapTotalBytes": 10285056,
"scriptDurationMs": 89.422,
"eventListeners": -14928,
"totalBlockingTimeMs": 323,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7297.083999999927,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7018.862999999999,
"heapDeltaBytes": -29033076,
"heapUsedBytes": 169832000,
"domNodes": 0,
"jsHeapTotalBytes": -24903680,
"scriptDurationMs": 115.27100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7297.927999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7044.431999999999,
"heapDeltaBytes": -21151092,
"heapUsedBytes": 176570972,
"domNodes": 0,
"jsHeapTotalBytes": -26476544,
"scriptDurationMs": 116.10100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 432.9169999999749,
"styleRecalcs": 15,
"styleRecalcDurationMs": 18.271,
"layouts": 3,
"layoutDurationMs": 0.882,
"taskDurationMs": 104.552,
"heapDeltaBytes": 4914436,
"heapUsedBytes": 71428092,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.503999999999998,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 99.65899999997418,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.566999999999998,
"layouts": 3,
"layoutDurationMs": 1.096,
"taskDurationMs": 76.23500000000003,
"heapDeltaBytes": 3052228,
"heapUsedBytes": 69473304,
"domNodes": 106,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 6.784000000000002,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
This comment has been minimized.
This comment has been minimized.
Addresses review feedback: #19987 (comment)
39a26e1 to
037137d
Compare
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Exact-head review: 037137db703db41ca2f241b310eaadf43e8ca33e is substantively ready from my review; no code findings.
I compared this follow-up against merged source #19726 (2409252b6459) and merged cloud/1.55 carrier #19987 (49fbd54429a0). The first commit removes #19987’s source-divergent UTF-16 pre-slice and restores the source’s code-point clamp exactly. The second restores the durable user-visible proof omitted from #19987: complete a load_skill turn, reload the persisted transcript, expand Work Summary, and assert the named skill remains visible. Its spec differs from the source only by using an inferred literal type because this release branch does not export the source type; the behavior and assertion are unchanged. The fixture additions match the source and preserve the target branch’s already-present panel helpers.
Hosted lint, typecheck, browser shards (including the cloud distribution), and the new-test video check are green at this head. The binding target-aware gate currently refuses only because aggregate test is still in progress, so this is not yet a merge-ready receipt. Remaining gates: terminal exact-head checks, the required owning-team approval (Alex/DrJKL is requested), then rerun scripts/check-merge-ready.sh Comfy-Org/ComfyUI_frontend 20032 --target-branch cloud/1.55. Do not infer readiness from the release label or this author-account comment.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #20032 +/- ##
=============================================
Coverage ? 84.94%
=============================================
Files ? 2327
Lines ? 133257
Branches ? 33816
=============================================
Hits ? 113194
Misses ? 19701
Partials ? 362
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Summary
Follow-up to post-merge review on #19987.
Testing
vitestfocused schema and transcript suites: 73 passedBase branch:
cloud/1.55