Skip to content

[backport cloud/1.54] refactor(canvas): centralize viewport lifecycle and framing - #19963

Merged
comfy-pr-bot merged 15 commits into
cloud/1.54from
backport-11420-to-cloud-1.54
Oct 3, 2026
Merged

comfy-pr-bot merged 15 commits into
cloud/1.54from
backport-11420-to-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backports PR #11420 to cloud/1.54 after the automatic cherry-pick conflicted with release-branch test infrastructure and APIs introduced after 1.54.

The release adaptation preserves the viewport/DPR lifecycle, hidden-canvas scheduler, camera framing, App Mode transition coverage, and ADR while retaining the 1.54-native selection and link-presentation test infrastructure.

Validation:

  • application typecheck passed
  • browser-test typecheck passed
  • ADR validation passed
  • formatting, lint, and unused-code checks passed
  • all 41 changed unit-test files: 829 passed, 1 skipped

- make CanvasViewport the authority for CSS size, backing-store size,
and DPR
- serialize visibility-sensitive camera work through an identity-aware
CanvasScheduler
- reject malformed saved camera state and stale graph/subgraph
operations
- use one visible viewport rectangle for immediate and animated
panel-aware framing
- migrate litegraph, minimap, layout, hit testing, and canvas-center
consumers to the applied DPR
- cover the real App Mode template-loading product path

This incorporates the viewport migration from [merged PR
supersedes the remaining work in [PR
[PR #19095](#19095).
Those two fallback PRs will be closed after this PR merges. The panel
work is adapted to the existing `visibleCanvasViewport` contract rather
than introducing a second inset API.

Related to #11154:
Fit View now excludes the docked agent panel, but it still does not
subtract the right-side parameters panel, so that issue stays open.

- application and browser-test typechecks passed
- ADR validation, formatting, and changed-file lint passed
- production build passed
- pre-commit and pre-push formatting, lint, knip, and changed-file
fallow gates passed
- [exact-head
CI](https://github.com/Comfy-Org/ComfyUI_frontend/commit/a558de2719aff8b5546cb25f2b2ad413420928a5/checks)
passed with 105 successful checks, 19 expected skips, and no failures
- Playwright product-path and 0.5x DPR regressions passed in the hosted
browser matrix

The lifecycle is measure, apply atomically to both canvases, then frame
and draw. Scheduled operations carry both a semantic key and an
ownership predicate, so stale loads cannot clear or replace current
camera work. Panel-aware fitting consumes a usable rectangle in CSS
pixels, shared by immediate and animated paths.

---------

Co-authored-by: Alexander Brown <drjkl@comfy.org>
@vercel

vercel Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 3, 2026 3:37am UTC
billing-web-test Ignored Ignored Oct 3, 2026 3:37am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 0462816d-4363-4037-9758-4e061081d90d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Oct 2, 2026
@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/03/2026, 03:40:35 AM UTC

Links

🎭 Playwright: ✅ 1990 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1969 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.2 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 90.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.1 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 136ms TBT · 101.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
vue-large-graph-idle: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 173.4 MB heap
vue-large-graph-pan: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 166.1 MB heap
vue-node-resize-workload: · 58.1 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 9ms TBT · 170.0 MB heap
vue-zoom-out-idle: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.0 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 419ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 66.3 MB
canvas-idle: DOM nodes -130
canvas-idle: event listeners -96
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 20ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 699ms
canvas-mouse-sweep: script duration 108ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 67.8 MB
canvas-mouse-sweep: DOM nodes -279
canvas-mouse-sweep: event listeners -181
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 11ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 286ms
canvas-zoom-sweep: script duration 8ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.3 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 6ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 335ms
dom-widget-clipping: script duration 113ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 61.9 MB
dom-widget-clipping: DOM nodes 20
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 8
large-graph-idle: task duration 465ms
large-graph-idle: script duration 25ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 79.1 MB
large-graph-idle: DOM nodes -274
large-graph-idle: event listeners -176
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 8ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1207ms
large-graph-pan: script duration 584ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 69.6 MB
large-graph-pan: DOM nodes -283
large-graph-pan: event listeners -192
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 9ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 69
large-graph-zoom: task duration 1222ms
large-graph-zoom: script duration 541ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 81.2 MB
large-graph-zoom: DOM nodes 31
large-graph-zoom: event listeners 8
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 46
legacy-node-drag: task duration 1330ms
legacy-node-drag: script duration 658ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 90.3 MB
legacy-node-drag: DOM nodes 11
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 7
minimap-idle: task duration 455ms
minimap-idle: script duration 22ms
minimap-idle: TBT 0ms
minimap-idle: heap used 75.9 MB
minimap-idle: DOM nodes -277
minimap-idle: event listeners -161
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 8ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 314ms
subgraph-dom-widget-clipping: script duration 102ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 73.4 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 6ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 414ms
subgraph-idle: script duration 6ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 68.6 MB
subgraph-idle: DOM nodes -298
subgraph-idle: event listeners -242
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 18ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 579ms
subgraph-mouse-sweep: script duration 69ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 59.1 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -226
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 27ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 748ms
subgraph-transition-enter: script duration 22ms
subgraph-transition-enter: TBT 136ms
subgraph-transition-enter: heap used 101.3 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 22ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 4293ms
viewport-pan-sweep: script duration 2065ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 83.9 MB
viewport-pan-sweep: DOM nodes -256
viewport-pan-sweep: event listeners -161
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 10651ms
vue-large-graph-idle: script duration 134ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 173.4 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14931
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 11ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 68
vue-large-graph-pan: task duration 13457ms
vue-large-graph-pan: script duration 658ms
vue-large-graph-pan: TBT 0ms
vue-large-graph-pan: heap used 166.1 MB
vue-large-graph-pan: DOM nodes -8083
vue-large-graph-pan: event listeners -14932
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 19ms
vue-node-resize-workload: style recalc duration 60ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4073ms
vue-node-resize-workload: script duration 71ms
vue-node-resize-workload: TBT 9ms
vue-node-resize-workload: heap used 170.0 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14932
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 5557ms
vue-zoom-out-idle: script duration 86ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 170.0 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -8
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 20ms
workflow-execution: layout count 5
workflow-execution: style recalc count 14
workflow-execution: task duration 84ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 71.6 MB
workflow-execution: DOM nodes 136
workflow-execution: event listeners 42
Raw data
{
  "timestamp": "2026-10-03T03:48:07.164Z",
  "gitSha": "90331d7cdef8ba6c869ac38696f4dbbc687b104a",
  "branch": "backport-11420-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2021.4359999999942,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.565,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 410.90000000000003,
      "heapDeltaBytes": 1621872,
      "heapUsedBytes": 72166968,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 6.997,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2020.1729999999998,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.8069999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 426.83700000000005,
      "heapDeltaBytes": -6468192,
      "heapUsedBytes": 66789280,
      "domNodes": -280,
      "jsHeapTotalBytes": 4493312,
      "scriptDurationMs": 6.667999999999998,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1768.9720000000193,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 21.912999999999997,
      "layouts": 14,
      "layoutDurationMs": 2.748,
      "taskDurationMs": 723.2689999999999,
      "heapDeltaBytes": 10796800,
      "heapUsedBytes": 82368700,
      "domNodes": -281,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 107.53800000000001,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1705.1529999999957,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 18.323000000000004,
      "layouts": 14,
      "layoutDurationMs": 2.6029999999999998,
      "taskDurationMs": 675.1729999999999,
      "heapDeltaBytes": -10977084,
      "heapUsedBytes": 59847480,
      "domNodes": -277,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 108.72100000000002,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1657.0300000000202,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 11.153999999999998,
      "layouts": 6,
      "layoutDurationMs": 0.835,
      "taskDurationMs": 282.86699999999996,
      "heapDeltaBytes": 4255104,
      "heapUsedBytes": 75751252,
      "domNodes": 77,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 7.791999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1683.7489999999207,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 11.184,
      "layouts": 6,
      "layoutDurationMs": 0.8200000000000001,
      "taskDurationMs": 289.57099999999997,
      "heapDeltaBytes": 4505232,
      "heapUsedBytes": 75890700,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 8.142000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 538.5729999999853,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 5.816,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 340.515,
      "heapDeltaBytes": -7487056,
      "heapUsedBytes": 66417768,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 115.40800000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 523.0650000000878,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 5.336,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 329.829,
      "heapDeltaBytes": -8311232,
      "heapUsedBytes": 63329916,
      "domNodes": 20,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 111.054,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2013.2849999999962,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 4.812,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 441.15700000000004,
      "heapDeltaBytes": -3216620,
      "heapUsedBytes": 77306988,
      "domNodes": -266,
      "jsHeapTotalBytes": -1798144,
      "scriptDurationMs": 24.011,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2025.9939999999688,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 4.572,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 487.954,
      "heapDeltaBytes": 11432392,
      "heapUsedBytes": 88647848,
      "domNodes": -282,
      "jsHeapTotalBytes": -888832,
      "scriptDurationMs": 25.008000000000003,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2190.8050000000117,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 8.269999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1211.599,
      "heapDeltaBytes": -10075400,
      "heapUsedBytes": 68219176,
      "domNodes": -283,
      "jsHeapTotalBytes": 3305472,
      "scriptDurationMs": 590.835,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2187.2900000000755,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 8.664000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1202.492,
      "heapDeltaBytes": -515436,
      "heapUsedBytes": 77701180,
      "domNodes": -282,
      "jsHeapTotalBytes": 3268608,
      "scriptDurationMs": 577.874,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3071.0730000000126,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 10.321000000000002,
      "layouts": 60,
      "layoutDurationMs": 8.525,
      "taskDurationMs": 1206.8490000000002,
      "heapDeltaBytes": 4701080,
      "heapUsedBytes": 84685784,
      "domNodes": 34,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 525.798,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3137.4479999999494,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 9.247,
      "layouts": 60,
      "layoutDurationMs": 8.776,
      "taskDurationMs": 1237.902,
      "heapDeltaBytes": 5270212,
      "heapUsedBytes": 85534336,
      "domNodes": 28,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 556.9909999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2164.461000000017,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 4.934000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1330.1159999999998,
      "heapDeltaBytes": 9932788,
      "heapUsedBytes": 92639992,
      "domNodes": 8,
      "jsHeapTotalBytes": 5398528,
      "scriptDurationMs": 653.68,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2241.5659999999207,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 6.736999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1330.3780000000002,
      "heapDeltaBytes": 14258976,
      "heapUsedBytes": 96687280,
      "domNodes": 14,
      "jsHeapTotalBytes": 5136384,
      "scriptDurationMs": 663.2520000000001,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2033.4210000000326,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 4.268999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 472.86499999999995,
      "heapDeltaBytes": 2742944,
      "heapUsedBytes": 82244720,
      "domNodes": -285,
      "jsHeapTotalBytes": 1470464,
      "scriptDurationMs": 20.461,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2013.1340000000364,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 3.9629999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 437.3950000000001,
      "heapDeltaBytes": -5467320,
      "heapUsedBytes": 76853588,
      "domNodes": -269,
      "jsHeapTotalBytes": -3371008,
      "scriptDurationMs": 24.054,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 512.6679999999624,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 6.848,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 294.59999999999997,
      "heapDeltaBytes": -10560012,
      "heapUsedBytes": 65453992,
      "domNodes": 20,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 94.903,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 539.2819999999574,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 8.224000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 333.60499999999996,
      "heapDeltaBytes": 14626592,
      "heapUsedBytes": 88382204,
      "domNodes": 22,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 109.957,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1992.2819999999888,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.904,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 420.521,
      "heapDeltaBytes": -5653464,
      "heapUsedBytes": 69610524,
      "domNodes": -299,
      "jsHeapTotalBytes": 4231168,
      "scriptDurationMs": 6.1209999999999996,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2019.6389999999838,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.521,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 406.917,
      "heapDeltaBytes": 964208,
      "heapUsedBytes": 74223888,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 6.2269999999999985,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1690.2540000000386,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 17.918999999999997,
      "layouts": 18,
      "layoutDurationMs": 2.957,
      "taskDurationMs": 620.2890000000001,
      "heapDeltaBytes": -11325792,
      "heapUsedBytes": 62130864,
      "domNodes": -293,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 68.972,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1694.8429999999917,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 17.122,
      "layouts": 18,
      "layoutDurationMs": 2.955,
      "taskDurationMs": 537.6670000000001,
      "heapDeltaBytes": -13890112,
      "heapUsedBytes": 61896656,
      "domNodes": -297,
      "jsHeapTotalBytes": 4755456,
      "scriptDurationMs": 68.78899999999999,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 949.0100000000439,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 27.213,
      "layouts": 16,
      "layoutDurationMs": 11.705,
      "taskDurationMs": 748.0020000000001,
      "heapDeltaBytes": 22022616,
      "heapUsedBytes": 106225836,
      "domNodes": 13831,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 21.858000000000004,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 136,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8206.999999999993,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 22.253000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4367.857000000001,
      "heapDeltaBytes": 24700284,
      "heapUsedBytes": 103046136,
      "domNodes": -244,
      "jsHeapTotalBytes": 2482176,
      "scriptDurationMs": 2106.716,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8118.630000000053,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 21.211000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4218.442000000001,
      "heapDeltaBytes": 7520768,
      "heapUsedBytes": 72835580,
      "domNodes": -268,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 2023.866,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 11278.54400000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10582.530999999999,
      "heapDeltaBytes": -40325072,
      "heapUsedBytes": 179023916,
      "domNodes": -8068,
      "jsHeapTotalBytes": -13889536,
      "scriptDurationMs": 124.43200000000002,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 11401.260000000093,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10720.29,
      "heapDeltaBytes": -32960788,
      "heapUsedBytes": 184635956,
      "domNodes": -8067,
      "jsHeapTotalBytes": -2355200,
      "scriptDurationMs": 143.915,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14024.186999999984,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 11.050000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13409.245000000003,
      "heapDeltaBytes": -49654548,
      "heapUsedBytes": 167619296,
      "domNodes": -8097,
      "jsHeapTotalBytes": -11673600,
      "scriptDurationMs": 634.294,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333326,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14200.913000000015,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 11.482999999999993,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13503.946,
      "heapDeltaBytes": -24270676,
      "heapUsedBytes": 180631000,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11268096,
      "scriptDurationMs": 682.501,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4528.455999999949,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 60.95899999999999,
      "layouts": 20,
      "layoutDurationMs": 18.02300000000001,
      "taskDurationMs": 4067.086,
      "heapDeltaBytes": -31425852,
      "heapUsedBytes": 177805472,
      "domNodes": -8068,
      "jsHeapTotalBytes": 4476928,
      "scriptDurationMs": 68.397,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 9,
      "frameDurationMs": 17.223333333333297,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4213.368999999943,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 59.616,
      "layouts": 20,
      "layoutDurationMs": 19.230999999999998,
      "taskDurationMs": 4079.1730000000007,
      "heapDeltaBytes": -39446876,
      "heapUsedBytes": 178814580,
      "domNodes": -8068,
      "jsHeapTotalBytes": 10735616,
      "scriptDurationMs": 74.234,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 9,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5983.854000000008,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5584.624999999999,
      "heapDeltaBytes": 7202628,
      "heapUsedBytes": 179013648,
      "domNodes": 0,
      "jsHeapTotalBytes": -25690112,
      "scriptDurationMs": 68.37699999999997,
      "eventListeners": -6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6012.535999999955,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5529.713000000001,
      "heapDeltaBytes": -306296,
      "heapUsedBytes": 177507848,
      "domNodes": 0,
      "jsHeapTotalBytes": -26476544,
      "scriptDurationMs": 103.92300000000004,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 476.43300000004274,
      "styleRecalcs": 22,
      "styleRecalcDurationMs": 29.842,
      "layouts": 6,
      "layoutDurationMs": 2.401,
      "taskDurationMs": 122.164,
      "heapDeltaBytes": 5162876,
      "heapUsedBytes": 77097860,
      "domNodes": 151,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 10.738,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 71.2109999999484,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 9.399000000000001,
      "layouts": 3,
      "layoutDurationMs": 1.0639999999999998,
      "taskDurationMs": 45.623,
      "heapDeltaBytes": 2924812,
      "heapUsedBytes": 73097972,
      "domNodes": 121,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 3.0959999999999996,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999998,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 51028 76357 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1173
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.7% 255
src/scripts/pnginfo.ts 21.4% 221

@christian-byrne christian-byrne added cursor-review Trigger multi-model Cursor agent review on this PR greenlight labels Oct 2, 2026
@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Oct 3, 2026
@datadog-official

This comment has been minimized.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 10 finding(s).

Severity Count
🟠 High 3
🟡 Medium 5
🟢 Low 2

Panel: 6/8 reviewers contributed findings.

Reviewers that did not contribute: kimi-k3-max:adversarial (error), kimi-k3-max:edge-case (error)

Comment thread src/scripts/app.ts Resolved
Comment thread src/lib/litegraph/src/LGraphCanvas.ts Resolved
Comment thread src/scripts/app.ts Resolved
Comment thread src/stores/subgraphNavigationStore.ts Resolved
Comment thread src/scripts/app.ts Resolved
Comment thread src/scripts/app.ts Resolved
@codecov

codecov Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.01198% with 20 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/lib/litegraph/src/LGraphCanvas.ts 54.16% 11 Missing ⚠️
src/lib/litegraph/src/DragAndScale.ts 87.50% 2 Missing ⚠️
src/renderer/core/canvas/canvasViewport.ts 97.82% 2 Missing ⚠️
src/utils/__tests__/canvasTestUtils.ts 95.45% 2 Missing ⚠️
src/renderer/core/layout/store/layoutStore.ts 50.00% 1 Missing ⚠️
src/scripts/app.ts 98.21% 1 Missing ⚠️
src/utils/__tests__/stubPath2D.ts 83.33% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #19963   +/-   ##
=============================================
  Coverage              ?   84.24%           
=============================================
  Files                 ?     2131           
  Lines                 ?   127970           
  Branches              ?    32563           
=============================================
  Hits                  ?   107810           
  Misses                ?    19979           
  Partials              ?      181           
Flag Coverage Δ
e2e 66.88% <82.52%> (?)
unit 79.54% <94.69%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/node/NodePreviewCard.vue 97.82% <ø> (ø)
src/composables/canvas/visibleCanvasViewport.ts 100.00% <100.00%> (ø)
src/renderer/core/canvas/cameraState.ts 100.00% <100.00%> (ø)
src/renderer/core/canvas/useCanvasScheduler.ts 100.00% <100.00%> (ø)
...tensions/minimap/composables/useMinimapViewport.ts 98.50% <100.00%> (ø)
...tensions/vueNodes/components/LGraphNodePreview.vue 91.89% <ø> (ø)
src/scripts/changeTracker.ts 94.52% <100.00%> (ø)
src/services/litegraphService.ts 71.55% <100.00%> (ø)
src/stores/queueStore.ts 82.38% <100.00%> (ø)
src/stores/subgraphNavigationStore.ts 99.37% <100.00%> (ø)
... and 8 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…statuses

The `cloud/1.54` carrier changed `visibleCanvasViewport` to read the applied
CSS viewport off `canvas.ds.getViewportSize()` instead of the backing store
off `canvas.canvas.width`, but only updated that composable's own test. Four
callers' fixtures still stubbed `{ canvas: { width, height } }` with no `ds`,
so framing threw `Cannot read properties of undefined (reading
'getViewportSize')` across 19 cases in agentNodeSelectionStore,
ErrorGroupList, AgentPanelRoot and agentPanelStoreId. The equivalent
`cloud/1.55` and `core/1.55` carriers already ship these fixture updates;
this carries them, keeping every existing viewport assertion and its
dimensions unchanged.

Also revert two early returns that arrived with the backport but belong to an
upstream `TemplateLoadResult` refactor that was not carried to this branch.
With no `TemplateLoadResult` type, no `updateTemplateEducation` helper and no
consumer that reads either status, `return 'not-started'` only had the effect
of skipping `educationStore.dismissCard()`, leaving a stale partner-education
card up when a template load activated no workflow. `return 'graph-failed'`
was inert here, since the baseline already returned a truthy value on that
path. The file is now byte-identical to the `cloud/1.54` baseline.
@comfy-pr-bot
comfy-pr-bot merged commit 2764dea into cloud/1.54 Oct 3, 2026
96 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-11420-to-cloud-1.54 branch October 3, 2026 04:47
christian-byrne added a commit that referenced this pull request Oct 3, 2026
christian-byrne added a commit that referenced this pull request Oct 3, 2026
christian-byrne added a commit that referenced this pull request Oct 3, 2026
christian-byrne added a commit that referenced this pull request Oct 3, 2026
christian-byrne added a commit that referenced this pull request Oct 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR greenlight risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants