Repository navigation
[backport cloud/1.54] refactor(canvas): centralize viewport lifecycle and framing - #19963
Conversation
- make CanvasViewport the authority for CSS size, backing-store size, and DPR - serialize visibility-sensitive camera work through an identity-aware CanvasScheduler - reject malformed saved camera state and stale graph/subgraph operations - use one visible viewport rectangle for immediate and animated panel-aware framing - migrate litegraph, minimap, layout, hit testing, and canvas-center consumers to the applied DPR - cover the real App Mode template-loading product path This incorporates the viewport migration from [merged PR supersedes the remaining work in [PR [PR #19095](#19095). Those two fallback PRs will be closed after this PR merges. The panel work is adapted to the existing `visibleCanvasViewport` contract rather than introducing a second inset API. Related to #11154: Fit View now excludes the docked agent panel, but it still does not subtract the right-side parameters panel, so that issue stays open. - application and browser-test typechecks passed - ADR validation, formatting, and changed-file lint passed - production build passed - pre-commit and pre-push formatting, lint, knip, and changed-file fallow gates passed - [exact-head CI](https://github.com/Comfy-Org/ComfyUI_frontend/commit/a558de2719aff8b5546cb25f2b2ad413420928a5/checks) passed with 105 successful checks, 19 expected skips, and no failures - Playwright product-path and 0.5x DPR regressions passed in the hosted browser matrix The lifecycle is measure, apply atomically to both canvases, then frame and draw. Scheduled operations carry both a semantic key and an ownership predicate, so stale loads cannot clear or replace current camera work. Panel-aware fitting consumes a usable rectangle in CSS pixels, shared by immediate and animated paths. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1990 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-03T03:48:07.164Z",
"gitSha": "90331d7cdef8ba6c869ac38696f4dbbc687b104a",
"branch": "backport-11420-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.4359999999942,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.565,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.90000000000003,
"heapDeltaBytes": 1621872,
"heapUsedBytes": 72166968,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 6.997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2020.1729999999998,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.8069999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.83700000000005,
"heapDeltaBytes": -6468192,
"heapUsedBytes": 66789280,
"domNodes": -280,
"jsHeapTotalBytes": 4493312,
"scriptDurationMs": 6.667999999999998,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1768.9720000000193,
"styleRecalcs": 74,
"styleRecalcDurationMs": 21.912999999999997,
"layouts": 14,
"layoutDurationMs": 2.748,
"taskDurationMs": 723.2689999999999,
"heapDeltaBytes": 10796800,
"heapUsedBytes": 82368700,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 107.53800000000001,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1705.1529999999957,
"styleRecalcs": 74,
"styleRecalcDurationMs": 18.323000000000004,
"layouts": 14,
"layoutDurationMs": 2.6029999999999998,
"taskDurationMs": 675.1729999999999,
"heapDeltaBytes": -10977084,
"heapUsedBytes": 59847480,
"domNodes": -277,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 108.72100000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1657.0300000000202,
"styleRecalcs": 31,
"styleRecalcDurationMs": 11.153999999999998,
"layouts": 6,
"layoutDurationMs": 0.835,
"taskDurationMs": 282.86699999999996,
"heapDeltaBytes": 4255104,
"heapUsedBytes": 75751252,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7.791999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1683.7489999999207,
"styleRecalcs": 31,
"styleRecalcDurationMs": 11.184,
"layouts": 6,
"layoutDurationMs": 0.8200000000000001,
"taskDurationMs": 289.57099999999997,
"heapDeltaBytes": 4505232,
"heapUsedBytes": 75890700,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 8.142000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 538.5729999999853,
"styleRecalcs": 14,
"styleRecalcDurationMs": 5.816,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 340.515,
"heapDeltaBytes": -7487056,
"heapUsedBytes": 66417768,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 115.40800000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 523.0650000000878,
"styleRecalcs": 14,
"styleRecalcDurationMs": 5.336,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.829,
"heapDeltaBytes": -8311232,
"heapUsedBytes": 63329916,
"domNodes": 20,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 111.054,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2013.2849999999962,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.812,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.15700000000004,
"heapDeltaBytes": -3216620,
"heapUsedBytes": 77306988,
"domNodes": -266,
"jsHeapTotalBytes": -1798144,
"scriptDurationMs": 24.011,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2025.9939999999688,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.572,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.954,
"heapDeltaBytes": 11432392,
"heapUsedBytes": 88647848,
"domNodes": -282,
"jsHeapTotalBytes": -888832,
"scriptDurationMs": 25.008000000000003,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2190.8050000000117,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.269999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1211.599,
"heapDeltaBytes": -10075400,
"heapUsedBytes": 68219176,
"domNodes": -283,
"jsHeapTotalBytes": 3305472,
"scriptDurationMs": 590.835,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2187.2900000000755,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.664000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1202.492,
"heapDeltaBytes": -515436,
"heapUsedBytes": 77701180,
"domNodes": -282,
"jsHeapTotalBytes": 3268608,
"scriptDurationMs": 577.874,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3071.0730000000126,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.321000000000002,
"layouts": 60,
"layoutDurationMs": 8.525,
"taskDurationMs": 1206.8490000000002,
"heapDeltaBytes": 4701080,
"heapUsedBytes": 84685784,
"domNodes": 34,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 525.798,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3137.4479999999494,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.247,
"layouts": 60,
"layoutDurationMs": 8.776,
"taskDurationMs": 1237.902,
"heapDeltaBytes": 5270212,
"heapUsedBytes": 85534336,
"domNodes": 28,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 556.9909999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2164.461000000017,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.934000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1330.1159999999998,
"heapDeltaBytes": 9932788,
"heapUsedBytes": 92639992,
"domNodes": 8,
"jsHeapTotalBytes": 5398528,
"scriptDurationMs": 653.68,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2241.5659999999207,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.736999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1330.3780000000002,
"heapDeltaBytes": 14258976,
"heapUsedBytes": 96687280,
"domNodes": 14,
"jsHeapTotalBytes": 5136384,
"scriptDurationMs": 663.2520000000001,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2033.4210000000326,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.268999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.86499999999995,
"heapDeltaBytes": 2742944,
"heapUsedBytes": 82244720,
"domNodes": -285,
"jsHeapTotalBytes": 1470464,
"scriptDurationMs": 20.461,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2013.1340000000364,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.9629999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.3950000000001,
"heapDeltaBytes": -5467320,
"heapUsedBytes": 76853588,
"domNodes": -269,
"jsHeapTotalBytes": -3371008,
"scriptDurationMs": 24.054,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 512.6679999999624,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.848,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 294.59999999999997,
"heapDeltaBytes": -10560012,
"heapUsedBytes": 65453992,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 94.903,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 539.2819999999574,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.224000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 333.60499999999996,
"heapDeltaBytes": 14626592,
"heapUsedBytes": 88382204,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 109.957,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.2819999999888,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.904,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.521,
"heapDeltaBytes": -5653464,
"heapUsedBytes": 69610524,
"domNodes": -299,
"jsHeapTotalBytes": 4231168,
"scriptDurationMs": 6.1209999999999996,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2019.6389999999838,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.521,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.917,
"heapDeltaBytes": 964208,
"heapUsedBytes": 74223888,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 6.2269999999999985,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.2540000000386,
"styleRecalcs": 79,
"styleRecalcDurationMs": 17.918999999999997,
"layouts": 18,
"layoutDurationMs": 2.957,
"taskDurationMs": 620.2890000000001,
"heapDeltaBytes": -11325792,
"heapUsedBytes": 62130864,
"domNodes": -293,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 68.972,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.8429999999917,
"styleRecalcs": 77,
"styleRecalcDurationMs": 17.122,
"layouts": 18,
"layoutDurationMs": 2.955,
"taskDurationMs": 537.6670000000001,
"heapDeltaBytes": -13890112,
"heapUsedBytes": 61896656,
"domNodes": -297,
"jsHeapTotalBytes": 4755456,
"scriptDurationMs": 68.78899999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 949.0100000000439,
"styleRecalcs": 20,
"styleRecalcDurationMs": 27.213,
"layouts": 16,
"layoutDurationMs": 11.705,
"taskDurationMs": 748.0020000000001,
"heapDeltaBytes": 22022616,
"heapUsedBytes": 106225836,
"domNodes": 13831,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 21.858000000000004,
"eventListeners": 2385,
"totalBlockingTimeMs": 136,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8206.999999999993,
"styleRecalcs": 249,
"styleRecalcDurationMs": 22.253000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4367.857000000001,
"heapDeltaBytes": 24700284,
"heapUsedBytes": 103046136,
"domNodes": -244,
"jsHeapTotalBytes": 2482176,
"scriptDurationMs": 2106.716,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8118.630000000053,
"styleRecalcs": 248,
"styleRecalcDurationMs": 21.211000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4218.442000000001,
"heapDeltaBytes": 7520768,
"heapUsedBytes": 72835580,
"domNodes": -268,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 2023.866,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11278.54400000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10582.530999999999,
"heapDeltaBytes": -40325072,
"heapUsedBytes": 179023916,
"domNodes": -8068,
"jsHeapTotalBytes": -13889536,
"scriptDurationMs": 124.43200000000002,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11401.260000000093,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10720.29,
"heapDeltaBytes": -32960788,
"heapUsedBytes": 184635956,
"domNodes": -8067,
"jsHeapTotalBytes": -2355200,
"scriptDurationMs": 143.915,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14024.186999999984,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.050000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13409.245000000003,
"heapDeltaBytes": -49654548,
"heapUsedBytes": 167619296,
"domNodes": -8097,
"jsHeapTotalBytes": -11673600,
"scriptDurationMs": 634.294,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14200.913000000015,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.482999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13503.946,
"heapDeltaBytes": -24270676,
"heapUsedBytes": 180631000,
"domNodes": -8068,
"jsHeapTotalBytes": -11268096,
"scriptDurationMs": 682.501,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4528.455999999949,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.95899999999999,
"layouts": 20,
"layoutDurationMs": 18.02300000000001,
"taskDurationMs": 4067.086,
"heapDeltaBytes": -31425852,
"heapUsedBytes": 177805472,
"domNodes": -8068,
"jsHeapTotalBytes": 4476928,
"scriptDurationMs": 68.397,
"eventListeners": -14931,
"totalBlockingTimeMs": 9,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4213.368999999943,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.616,
"layouts": 20,
"layoutDurationMs": 19.230999999999998,
"taskDurationMs": 4079.1730000000007,
"heapDeltaBytes": -39446876,
"heapUsedBytes": 178814580,
"domNodes": -8068,
"jsHeapTotalBytes": 10735616,
"scriptDurationMs": 74.234,
"eventListeners": -14933,
"totalBlockingTimeMs": 9,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5983.854000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5584.624999999999,
"heapDeltaBytes": 7202628,
"heapUsedBytes": 179013648,
"domNodes": 0,
"jsHeapTotalBytes": -25690112,
"scriptDurationMs": 68.37699999999997,
"eventListeners": -6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6012.535999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5529.713000000001,
"heapDeltaBytes": -306296,
"heapUsedBytes": 177507848,
"domNodes": 0,
"jsHeapTotalBytes": -26476544,
"scriptDurationMs": 103.92300000000004,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 476.43300000004274,
"styleRecalcs": 22,
"styleRecalcDurationMs": 29.842,
"layouts": 6,
"layoutDurationMs": 2.401,
"taskDurationMs": 122.164,
"heapDeltaBytes": 5162876,
"heapUsedBytes": 77097860,
"domNodes": 151,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.738,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 71.2109999999484,
"styleRecalcs": 6,
"styleRecalcDurationMs": 9.399000000000001,
"layouts": 3,
"layoutDurationMs": 1.0639999999999998,
"taskDurationMs": 45.623,
"heapDeltaBytes": 2924812,
"heapUsedBytes": 73097972,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 3.0959999999999996,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 3 |
| 🟡 Medium | 5 |
| 🟢 Low | 2 |
Panel: 6/8 reviewers contributed findings.
Reviewers that did not contribute: kimi-k3-max:adversarial (error), kimi-k3-max:edge-case (error)
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.54 #19963 +/- ##
=============================================
Coverage ? 84.24%
=============================================
Files ? 2131
Lines ? 127970
Branches ? 32563
=============================================
Hits ? 107810
Misses ? 19979
Partials ? 181
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…statuses
The `cloud/1.54` carrier changed `visibleCanvasViewport` to read the applied
CSS viewport off `canvas.ds.getViewportSize()` instead of the backing store
off `canvas.canvas.width`, but only updated that composable's own test. Four
callers' fixtures still stubbed `{ canvas: { width, height } }` with no `ds`,
so framing threw `Cannot read properties of undefined (reading
'getViewportSize')` across 19 cases in agentNodeSelectionStore,
ErrorGroupList, AgentPanelRoot and agentPanelStoreId. The equivalent
`cloud/1.55` and `core/1.55` carriers already ship these fixture updates;
this carries them, keeping every existing viewport assertion and its
dimensions unchanged.
Also revert two early returns that arrived with the backport but belong to an
upstream `TemplateLoadResult` refactor that was not carried to this branch.
With no `TemplateLoadResult` type, no `updateTemplateEducation` helper and no
consumer that reads either status, `return 'not-started'` only had the effect
of skipping `educationStore.dismissCard()`, leaving a stale partner-education
card up when a template load activated no workflow. `return 'graph-failed'`
was inert here, since the baseline already returned a truthy value on that
path. The file is now byte-identical to the `cloud/1.54` baseline.
Addresses review feedback: #19963 (comment)
Addresses review feedback: #19963 (comment)
Addresses review feedback: #19963 (comment)
Addresses review feedback: #19963 (comment)
Addresses review feedback: #19963 (comment)
Addresses review feedback: #19963 (comment)
Addresses review feedback: #19963 (comment)
Addresses review feedback: #19963 (comment)
Backports PR #11420 to
cloud/1.54after the automatic cherry-pick conflicted with release-branch test infrastructure and APIs introduced after 1.54.The release adaptation preserves the viewport/DPR lifecycle, hidden-canvas scheduler, camera framing, App Mode transition coverage, and ADR while retaining the 1.54-native selection and link-presentation test infrastructure.
Validation: