Repository navigation
[backport core/1.54] refactor(canvas): centralize viewport lifecycle and framing - #19962
Conversation
- make CanvasViewport the authority for CSS size, backing-store size, and DPR - serialize visibility-sensitive camera work through an identity-aware CanvasScheduler - reject malformed saved camera state and stale graph/subgraph operations - use one visible viewport rectangle for immediate and animated panel-aware framing - migrate litegraph, minimap, layout, hit testing, and canvas-center consumers to the applied DPR - cover the real App Mode template-loading product path This incorporates the viewport migration from [merged PR supersedes the remaining work in [PR [PR #19095](#19095). Those two fallback PRs will be closed after this PR merges. The panel work is adapted to the existing `visibleCanvasViewport` contract rather than introducing a second inset API. Related to #11154: Fit View now excludes the docked agent panel, but it still does not subtract the right-side parameters panel, so that issue stays open. - application and browser-test typechecks passed - ADR validation, formatting, and changed-file lint passed - production build passed - pre-commit and pre-push formatting, lint, knip, and changed-file fallow gates passed - [exact-head CI](https://github.com/Comfy-Org/ComfyUI_frontend/commit/a558de2719aff8b5546cb25f2b2ad413420928a5/checks) passed with 105 successful checks, 19 expected skips, and no failures - Playwright product-path and 0.5x DPR regressions passed in the hosted browser matrix The lifecycle is measure, apply atomically to both canvases, then frame and draw. Scheduled operations carry both a semantic key and an ownership predicate, so stale loads cannot clear or replace current camera work. Panel-aware fitting consumes a usable rectangle in CSS pixels, shared by immediate and animated paths. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1980 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-03T11:53:41.143Z",
"gitSha": "106d99783f40db1e6051a456f6592c2700381587",
"branch": "backport-11420-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2161.946000000029,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.407999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 663.902,
"heapDeltaBytes": -10292800,
"heapUsedBytes": 61250244,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 16.810000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2039.4400000000132,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.521,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 540.733,
"heapDeltaBytes": -5278148,
"heapUsedBytes": 68927824,
"domNodes": -283,
"jsHeapTotalBytes": 3444736,
"scriptDurationMs": 10.418999999999997,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1877.2989999999936,
"styleRecalcs": 75,
"styleRecalcDurationMs": 30.013000000000005,
"layouts": 14,
"layoutDurationMs": 4.3709999999999996,
"taskDurationMs": 932.3489999999999,
"heapDeltaBytes": -6368112,
"heapUsedBytes": 65636460,
"domNodes": -283,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 156.769,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1841.6999999999462,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.182999999999996,
"layouts": 14,
"layoutDurationMs": 4.227999999999999,
"taskDurationMs": 904.7009999999999,
"heapDeltaBytes": -12511368,
"heapUsedBytes": 59184044,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 143.508,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.6430000000055,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.692,
"layouts": 6,
"layoutDurationMs": 1.1869999999999998,
"taskDurationMs": 391.35900000000004,
"heapDeltaBytes": 4909124,
"heapUsedBytes": 78192128,
"domNodes": 75,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 13.031999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.2440000000088,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.727,
"layouts": 6,
"layoutDurationMs": 1.367,
"taskDurationMs": 392.70399999999995,
"heapDeltaBytes": 4516484,
"heapUsedBytes": 74905304,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.404,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 716.9739999999933,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.013999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.48400000000004,
"heapDeltaBytes": 17920276,
"heapUsedBytes": 88731416,
"domNodes": 14,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 162.98800000000003,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 719.2670000000021,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.388000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.60400000000004,
"heapDeltaBytes": -8052640,
"heapUsedBytes": 63572424,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 160.74999999999997,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2025.260000000003,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.863000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.0590000000001,
"heapDeltaBytes": -961236,
"heapUsedBytes": 77026384,
"domNodes": -272,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 36.333999999999996,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2012.5889999999913,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.316999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 607.7200000000001,
"heapDeltaBytes": 15322304,
"heapUsedBytes": 92158188,
"domNodes": -285,
"jsHeapTotalBytes": -626688,
"scriptDurationMs": 33.331,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2255.3629999999885,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.38,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1600.4300000000003,
"heapDeltaBytes": 1957312,
"heapUsedBytes": 80901864,
"domNodes": -281,
"jsHeapTotalBytes": 385024,
"scriptDurationMs": 785.4380000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2378.0849999999987,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.158000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1625.9969999999998,
"heapDeltaBytes": -10889780,
"heapUsedBytes": 67428248,
"domNodes": -272,
"jsHeapTotalBytes": -364544,
"scriptDurationMs": 804.268,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3674.6080000000347,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.777000000000003,
"layouts": 60,
"layoutDurationMs": 12.957999999999998,
"taskDurationMs": 1710.209,
"heapDeltaBytes": 3734500,
"heapUsedBytes": 86287064,
"domNodes": 32,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 785.095,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3688.284000000067,
"styleRecalcs": 71,
"styleRecalcDurationMs": 16.961000000000002,
"layouts": 60,
"layoutDurationMs": 12.789,
"taskDurationMs": 1785.802,
"heapDeltaBytes": -4540724,
"heapUsedBytes": 74985460,
"domNodes": -264,
"jsHeapTotalBytes": 3305472,
"scriptDurationMs": 782.5020000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3184.4619999999964,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.798,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1962.4109999999998,
"heapDeltaBytes": -11076428,
"heapUsedBytes": 71324896,
"domNodes": 10,
"jsHeapTotalBytes": 5402624,
"scriptDurationMs": 975.138,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3144.9969999999894,
"styleRecalcs": 42,
"styleRecalcDurationMs": 10.439,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1958.653,
"heapDeltaBytes": -11245536,
"heapUsedBytes": 71672840,
"domNodes": -284,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 962.3770000000001,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2005.61799999997,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.29,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.8790000000001,
"heapDeltaBytes": 10867224,
"heapUsedBytes": 77017632,
"domNodes": -269,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.306,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2009.539000000018,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.635000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 614.959,
"heapDeltaBytes": 12373376,
"heapUsedBytes": 91924112,
"domNodes": -283,
"jsHeapTotalBytes": -888832,
"scriptDurationMs": 39.107,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 643.18099999997,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.557000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.55699999999996,
"heapDeltaBytes": 14759616,
"heapUsedBytes": 88255384,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 142.566,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 663.2789999999886,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.171999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.22800000000007,
"heapDeltaBytes": 14830008,
"heapUsedBytes": 88461740,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 138.17100000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2015.467000000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.081999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.04799999999994,
"heapDeltaBytes": 1049664,
"heapUsedBytes": 74683688,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.207999999999998,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2039.3810000000485,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.258000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.872,
"heapDeltaBytes": -15601216,
"heapUsedBytes": 58102268,
"domNodes": -298,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 10.059999999999997,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1753.4029999999916,
"styleRecalcs": 78,
"styleRecalcDurationMs": 26.23,
"layouts": 18,
"layoutDurationMs": 4.502000000000001,
"taskDurationMs": 827.1760000000002,
"heapDeltaBytes": 9239232,
"heapUsedBytes": 82819572,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 97.996,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.349000000018,
"styleRecalcs": 78,
"styleRecalcDurationMs": 26.916,
"layouts": 18,
"layoutDurationMs": 4.813,
"taskDurationMs": 879.973,
"heapDeltaBytes": -7952728,
"heapUsedBytes": 65746892,
"domNodes": -295,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 103.91600000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.3880000000167,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.095999999999997,
"layouts": 13,
"layoutDurationMs": 13.779,
"taskDurationMs": 919.7200000000001,
"heapDeltaBytes": 22813780,
"heapUsedBytes": 105965524,
"domNodes": 13831,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 30.804,
"eventListeners": 2387,
"totalBlockingTimeMs": 139,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8539.857999999982,
"styleRecalcs": 246,
"styleRecalcDurationMs": 34.616,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5702.098,
"heapDeltaBytes": 27158772,
"heapUsedBytes": 92648568,
"domNodes": -270,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 2683.973,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8505.675999999994,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.302,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5792.291,
"heapDeltaBytes": 11980484,
"heapUsedBytes": 88986944,
"domNodes": -282,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 2668.384,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15707.611999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15133.056000000002,
"heapDeltaBytes": -33927924,
"heapUsedBytes": 178137000,
"domNodes": -8068,
"jsHeapTotalBytes": -15667200,
"scriptDurationMs": 310.377,
"eventListeners": -14935,
"totalBlockingTimeMs": 7,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15621.127,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15173.91,
"heapDeltaBytes": -40752688,
"heapUsedBytes": 182377180,
"domNodes": -8068,
"jsHeapTotalBytes": -8626176,
"scriptDurationMs": 244.103,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18447.59099999999,
"styleRecalcs": 130,
"styleRecalcDurationMs": 16.354000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18246.113,
"heapDeltaBytes": -34583272,
"heapUsedBytes": 191627724,
"domNodes": -8068,
"jsHeapTotalBytes": -14848000,
"scriptDurationMs": 851.972,
"eventListeners": -14929,
"totalBlockingTimeMs": 29,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 19206.680000000008,
"styleRecalcs": 145,
"styleRecalcDurationMs": 18.441000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18913.502,
"heapDeltaBytes": -24699212,
"heapUsedBytes": 194059492,
"domNodes": -8068,
"jsHeapTotalBytes": -9781248,
"scriptDurationMs": 911.813,
"eventListeners": -14931,
"totalBlockingTimeMs": 36,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5591.043000000013,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.13400000000004,
"layouts": 20,
"layoutDurationMs": 26.402999999999995,
"taskDurationMs": 5521.171999999999,
"heapDeltaBytes": -23009736,
"heapUsedBytes": 182174556,
"domNodes": -8068,
"jsHeapTotalBytes": 16240640,
"scriptDurationMs": 98.686,
"eventListeners": -14931,
"totalBlockingTimeMs": 247,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5710.432000000083,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.26699999999997,
"layouts": 20,
"layoutDurationMs": 24.250999999999994,
"taskDurationMs": 5634.527,
"heapDeltaBytes": -61095516,
"heapUsedBytes": 171386244,
"domNodes": -8069,
"jsHeapTotalBytes": 17289216,
"scriptDurationMs": 105.339,
"eventListeners": -14931,
"totalBlockingTimeMs": 231,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7989.878000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7676.042,
"heapDeltaBytes": 21513284,
"heapUsedBytes": 179151368,
"domNodes": 0,
"jsHeapTotalBytes": -5767168,
"scriptDurationMs": 153.23299999999995,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7830.096000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7551.093,
"heapDeltaBytes": 21670480,
"heapUsedBytes": 178990016,
"domNodes": 0,
"jsHeapTotalBytes": -7340032,
"scriptDurationMs": 121.71200000000005,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 482.1010000000001,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.483,
"layouts": 3,
"layoutDurationMs": 1.708,
"taskDurationMs": 132.01000000000002,
"heapDeltaBytes": 5015704,
"heapUsedBytes": 76882416,
"domNodes": 149,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.433,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 116.21600000000853,
"styleRecalcs": 8,
"styleRecalcDurationMs": 17.141,
"layouts": 2,
"layoutDurationMs": 1.3880000000000001,
"taskDurationMs": 87.205,
"heapDeltaBytes": 2928404,
"heapUsedBytes": 74768044,
"domNodes": 127,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.916999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.54 #19962 +/- ##
=============================================
+ Coverage 84.35% 84.38% +0.02%
=============================================
Files 2120 2125 +5
Lines 127115 127382 +267
Branches 32330 32497 +167
=============================================
+ Hits 107233 107490 +257
- Misses 19694 19704 +10
Partials 188 188
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 3 |
| 🟡 Medium | 5 |
| 🟢 Low | 2 |
Panel: 6/8 reviewers contributed findings.
Reviewers that did not contribute: kimi-k3-max:adversarial (error), kimi-k3-max:edge-case (error)
#11420 replaced the first-visit `requestAnimationFrame` fit with a synchronous `canvasScheduler` op. That is correct on main, where node layout is measured synchronously, but on this release line the Vue node layout settles a frame later, so the fit measured stale bounds and left the subgraph interior outside the viewport. Fifteen Playwright tests then timed out clicking widgets that were rendered off-screen. Keep the scheduler -- it is what makes the fit survive a hidden canvas, which is the point of #11420 -- and hop one frame inside `run` so the measurement reads settled layout. The viewport test keeps its own rAF capture, as it had on this branch before the backport, so the hop stays explicit rather than hidden behind a synchronous stub.
#11420 changed `visibleCanvasViewport` to measure through `canvas.ds.getViewportSize()` instead of `canvas.canvas.width` over the device pixel ratio. Four canvas stubs on this release line still carried only the element, so framing threw `Cannot read properties of undefined (reading 'getViewportSize')` and took 18 tests across four files with it. Point each stub at `createTestDragAndScale` -- the helper #11420 added and uses in `visibleCanvasViewport.test.ts` -- at the same surface the stub already declared. Every assertion is unchanged; only the fixture that encoded the old measurement source moves.
…hat activated nothing #11420 widened `loadGraphData` to return `undefined" for a load that was superseded before it began, and added `return 'not-started'` for it. The card-retirement test on this release line used `undefined" as its stand-in for "loaded, but activated no workflow", so the new early return skipped the dismiss it asserts. `true` is what that outcome actually returns (`activatedWorkflow ?? true"), so the fixture moves to it and keeps asserting the card is retired. A second case pins the new outcome: a load that never started leaves the card alone. Removing the production guard turns that case red.
#11420 carried two changes to `LGraphNodePreview.vue" on main: the `node-preview-body` test id, and -- from earlier main work -- rendering a COMBO widget for a COMFY_DYNAMICCOMBO_V3 input via `dynamicComboOptionKeys`. Only the test id is in #11420's diff, so only it was backported, but the spec assertions covering the widget came across with the spec. `dynamicComboOptionKeys" lives in `inputSpecTree.ts`, which does not exist on this branch, so those two assertions could never pass here. Keep the test id, the inputs-section assertion and the page-error check. Porting the widget behaviour itself is out of scope for a viewport backport and would add a main-only capability to a release line.
The release line carried a `- 5` in `SideToolbar.vue`'s `fpsInfoLocation` to compensate for litegraph's `renderInfo` drawing its text at a 5px inset that main had already removed. The comment on it said to drop the `- 5` once that litegraph change landed here. #11420 landed it -- `x = x || 15` with `fillText(..., 0, ...)` replacing `x = x || 10` with `fillText(..., 5, ...)` -- but the compensation stayed, so the two subtractions stacked and the whole HUD text block moved 5px left. Measured off the CI artifacts for shard 2: realigning the actual by exactly +5px makes the T/I/N/V lines pixel-identical to the committed baseline, and leaves only the varying FPS digit at 20-63px against the spec's maxDiffPixels of 100. canvasSettings.spec.ts:32 "toggles the bottom-left HUD" was the only remaining failure on this carrier.
…statuses
The `cloud/1.54` carrier changed `visibleCanvasViewport` to read the applied
CSS viewport off `canvas.ds.getViewportSize()` instead of the backing store
off `canvas.canvas.width`, but only updated that composable's own test. Four
callers' fixtures still stubbed `{ canvas: { width, height } }` with no `ds`,
so framing threw `Cannot read properties of undefined (reading
'getViewportSize')` across 19 cases in agentNodeSelectionStore,
ErrorGroupList, AgentPanelRoot and agentPanelStoreId. The equivalent
`cloud/1.55` and `core/1.55` carriers already ship these fixture updates;
this carries them, keeping every existing viewport assertion and its
dimensions unchanged.
Also revert two early returns that arrived with the backport but belong to an
upstream `TemplateLoadResult` refactor that was not carried to this branch.
With no `TemplateLoadResult` type, no `updateTemplateEducation` helper and no
consumer that reads either status, `return 'not-started'` only had the effect
of skipping `educationStore.dismissCard()`, leaving a stale partner-education
card up when a template load activated no workflow. `return 'graph-failed'`
was inert here, since the baseline already returned a truthy value on that
path. The file is now byte-identical to the `cloud/1.54` baseline.
Addresses review feedback: #19963 (comment)
Addresses review feedback: #19963 (comment)
`resizes both canvas layers in device pixels and redraws immediately` could not fail on either dimension assertion. `createTestCanvasElement` defaults the backing store to 800x600, and the expected result is exactly 400x300 CSS at DPR 2 -- also 800x600 -- so both layers already reported the asserted size before `resizeCanvas` ran. Verified by mutation: applying the viewport to the foreground only, and to the background only, both left the test green. The remaining assertions (`dpr`, `setViewportSize`, `draw`) do fail under mutation, so only the "both canvas layers" claim in the name was unproven. Start both layers at 1x1 so 800x600 can only come from the resize. Both mutations are red now and the unmutated test is green.
|
Exact-head source audit found and fixed a release-specific A→B→A viewport race at |
christian-byrne
left a comment
There was a problem hiding this comment.
Exact-head review at 382be7d6bb93af7248a6ec46b5eb207ea8439cee for the core/1.54 landing gate. Posting as a COMMENT rather than an approval because GitHub cannot accept an author approving their own PR; the release-backport grant permits the merge without manufacturing an approval record.
New delta since the last reviewed head. bf9a6c4b6e → 62524b169d is one commit, fix(backport): fence deferred subgraph fits by arrival, and unlike the preceding two it is production (subgraphNavigationStore.ts +8/−1), so it was reviewed as a behaviour change rather than re-run as a test refresh.
The race it fixes is real and release-specific. Once the keyed scheduler has run the first-visit fit, the item has left the queue and lives only in the pending requestAnimationFrame; returning to the original graph before that frame fired made getActiveGraphId() === graphId true again, so the stale fit overwrote the just-restored cached camera. This cannot happen on main — main's restoreViewport has no frame hop and calls fitView() synchronously inside flush(), so the item is either current when it runs or dropped by isStale. The rAF hop is the release-line adaptation that lets this branch's node layout settle before the fit measures it, and it is what opened the window. fix(backport): is the correct scope.
Mutation evidence. The commit installs two independent fences: the sequence check inside the frame callback, and canvasScheduler.cancel plus the isCurrent sequence term. Reverting the frame fence alone turns the new case red; reverting the whole commit turns it red; reverting either fence alone leaves it green, because on the queued path either fence alone produces the correct outcome. So the single-line survivors are genuine defence-in-depth, not a vacuous assertion, and the committed case is load-bearing. Re-verified at this head.
Behavioural camera invariant preserved. browser_tests/tests/appModeTemplateViewport.product.spec.ts still asserts framing behaviourally — canvas hidden, template loaded, canvas shown, view settled, getVisibleNodeCount() === 7 — not exact legacy camera pixels. No assertion was removed, relaxed, or renamed anywhere in this delta.
Target refresh. The carrier was one commit behind at review start and was refreshed twice under exact leases via update-branch (no force-push, no rewrite). The second target commit, 90fc21519693, overlapped the carrier on AgentPanelRoot.test.ts, so the merge was performed locally and the merged file run before the head was moved: 283/283 pass, the two changes being textually disjoint and semantically independent (renderWithSelectedTarget() does not call the setupNodeSelectionCanvas() helper this backport changes). The pushed head's tree is byte-identical to the locally tested tree (a5f67c72cb22cb14485c0e23b83f355a1aae395e). The carrier's own 80-file delta is unchanged by both refreshes.
Gates at this exact head: 92 checks completed, success/neutral/skipped only, zero pending and zero adverse; all three commit statuses green, including Vercel – billing-web-test, so the standing branch-wide waiver for it is not being invoked here; 10 review threads, 0 unresolved; no human CHANGES_REQUESTED; merge-base equals the live core/1.54 tip. Local: focused suites 6 files / 243 pass, AgentPanelRoot.test.ts 283 pass, vue-tsc --noEmit clean.
Merging under the Agent 1.54/1.55 release-backport authority (Christian, September 16, extended September 27), which covers core/1.54 and requires the target-aware exact-head procedure rather than a separate human approval, with unresolved human objections remaining blocking — there are none.
|
Correcting one claim in my exact-head review above, and recording a cross-line gap found while reconciling this source's dispositions. Neither changes the merge decision — the fence is correct and required on this line either way — but the claim as written would mislead whoever reads it next. Correction. I wrote that the race "cannot happen on The accurate split is two variants of one race:
That is why Cross-line gap, for whoever owns the cloud line. I am not opening that work from this row; recording it here so it is not lost between the four carriers of this source, all of which are now merged. |
Backports PR #11420 to
core/1.54after the automatic cherry-pick conflicted with release-branch test infrastructure and APIs introduced after 1.54.The release adaptation preserves the viewport/DPR lifecycle, hidden-canvas scheduler, camera framing, App Mode transition coverage, and ADR while retaining the 1.54-native selection and link-presentation test infrastructure.
Validation: