Repository navigation
[backport cloud/1.55] fix(agent): reconcile a hydrated streaming turn from REST after a refresh - #19847
Conversation
…resh (#18154) - Adds a cloud Playwright regression proving a turn that finishes only in REST history unlocks after a browser refresh. - Preserves locally streamed reply parts when a terminal history row is temporarily empty instead of replacing the visible reply with nothing. - Keeps recovery-map cleanup ownership-safe so an older job cannot evict a successor controller. The broader hydrated-turn recovery now already exists on `main` through [#18152](#18152) (socket-drop recovery) and [#19053](#19053) (panel-remount restoration). This PR was rebuilt on current `main` to retain only the still-additive hardening and black-box refresh coverage. - `useAgentSession.test.ts`: 201 passed, including the new empty-terminal-row regression. - Application and browser TypeScript checks passed. - Changed-file ESLint and Oxlint passed. - The Playwright case is collected as a cloud test. Its local run reached application startup but could not complete with the ad-hoc frontend-only server because the standard ComfyUI devtools backend was absent; hosted browser CI supplies that harness. Fixes the refresh half of [PM-1199](https://linear.app/comfyorg/issue/PM-1199/fix-agent-stream-drops-mid-turn-with-no-refresh-leaving-no-working) (an in-flight agent turn could remain locked after refresh). (cherry picked from commit ea63d4a)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2142 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since fb2506c9554c25281e6c71c1caa6847690b60b2d
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-02T02:26:03.944Z",
"gitSha": "2da9d978390731c6217a08425e94e199aa29f1a6",
"branch": "backport-18154-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1989.994999999908,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.534000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.16700000000003,
"heapDeltaBytes": 7622608,
"heapUsedBytes": 75770488,
"domNodes": -260,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.425000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2001.9710000001396,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.959999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.41599999999994,
"heapDeltaBytes": -7584236,
"heapUsedBytes": 55031276,
"domNodes": 20,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.288999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1741.6980000000422,
"styleRecalcs": 47,
"styleRecalcDurationMs": 14.140000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 765.009,
"heapDeltaBytes": 11192316,
"heapUsedBytes": 78938148,
"domNodes": -258,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 143.982,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.3320000000858,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.244,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 791.101,
"heapDeltaBytes": 9160404,
"heapUsedBytes": 76985948,
"domNodes": -257,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 146.48600000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.1579999997848,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.711,
"layouts": 6,
"layoutDurationMs": 1.129,
"taskDurationMs": 337.1139999999999,
"heapDeltaBytes": 3098796,
"heapUsedBytes": 70870652,
"domNodes": 79,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.303,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.577999999634,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.659999999999998,
"layouts": 6,
"layoutDurationMs": 1.266,
"taskDurationMs": 321.18199999999996,
"heapDeltaBytes": 3064024,
"heapUsedBytes": 71178996,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.754,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 649.9180000000706,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.078999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.94599999999997,
"heapDeltaBytes": 19015640,
"heapUsedBytes": 86792044,
"domNodes": 22,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 161.299,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 644.0870000001269,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.722000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.62999999999994,
"heapDeltaBytes": 18948372,
"heapUsedBytes": 86795832,
"domNodes": 24,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 164.03300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1195.2809999997953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 846.187,
"heapDeltaBytes": -17304312,
"heapUsedBytes": 72995108,
"domNodes": -297,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 64.11399999999999,
"eventListeners": -217,
"totalBlockingTimeMs": 537,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1195.1159999998708,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 877.841,
"heapDeltaBytes": -17587112,
"heapUsedBytes": 72820448,
"domNodes": -292,
"jsHeapTotalBytes": 20054016,
"scriptDurationMs": 64.35599999999998,
"eventListeners": -217,
"totalBlockingTimeMs": 526,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.1480000000611,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.0380000000004,
"heapDeltaBytes": 16623956,
"heapUsedBytes": 91668504,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 144.42499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 219,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 865.5969999999797,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.09900000000005,
"heapDeltaBytes": 14489200,
"heapUsedBytes": 90500332,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 147.242,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9437.88799999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8459.608,
"heapDeltaBytes": -11064828,
"heapUsedBytes": 72192248,
"domNodes": -16,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 6818.264,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8434.660999999778,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7723.987,
"heapDeltaBytes": 1283524,
"heapUsedBytes": 83854612,
"domNodes": -16,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 6455.219,
"eventListeners": 0,
"totalBlockingTimeMs": 440,
"frameDurationMs": 19.440000000000023,
"p95FrameDurationMs": 33.5
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9151.611000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8340.548999999999,
"heapDeltaBytes": 9723524,
"heapUsedBytes": 86845412,
"domNodes": -12,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 6752.657999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 224,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9131.597000000056,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8268.494999999999,
"heapDeltaBytes": 10504820,
"heapUsedBytes": 93251356,
"domNodes": -14,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 6695.657,
"eventListeners": 0,
"totalBlockingTimeMs": 103,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2030.7869999999184,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.619000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.369,
"heapDeltaBytes": -4022444,
"heapUsedBytes": 83574780,
"domNodes": -244,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 33.14199999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2025.974000000133,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.887,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.3199999999998,
"heapDeltaBytes": -3196616,
"heapUsedBytes": 83498336,
"domNodes": -240,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 34.21199999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2120.286999999962,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.541000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1555.1860000000001,
"heapDeltaBytes": 15749716,
"heapUsedBytes": 80121156,
"domNodes": -246,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 783.9359999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2176.643999999669,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.797,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1554.533,
"heapDeltaBytes": 20129276,
"heapUsedBytes": 84564420,
"domNodes": -252,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 791.628,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3501.0310000000118,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.486999999999998,
"layouts": 60,
"layoutDurationMs": 14.182,
"taskDurationMs": 1690.5169999999998,
"heapDeltaBytes": -16123496,
"heapUsedBytes": 74068112,
"domNodes": -254,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 779.6800000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3459.3469999999797,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.901,
"layouts": 60,
"layoutDurationMs": 13.935,
"taskDurationMs": 1640.677,
"heapDeltaBytes": 9093748,
"heapUsedBytes": 74736536,
"domNodes": -251,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 759.802,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3133.448000000044,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.323,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1955.8990000000001,
"heapDeltaBytes": -4307580,
"heapUsedBytes": 87446568,
"domNodes": -226,
"jsHeapTotalBytes": 2019328,
"scriptDurationMs": 988.883,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3176.603000000341,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.3,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1912.521,
"heapDeltaBytes": -9009796,
"heapUsedBytes": 82785720,
"domNodes": -226,
"jsHeapTotalBytes": 1495040,
"scriptDurationMs": 973.517,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.9270000001998,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.953,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.13,
"heapDeltaBytes": -4788480,
"heapUsedBytes": 83915104,
"domNodes": -246,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 34.62000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2000.604999999723,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.723,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.4909999999999,
"heapDeltaBytes": 20089544,
"heapUsedBytes": 84901056,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.336999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 561.4610000000084,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.328,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.915,
"heapDeltaBytes": 13683952,
"heapUsedBytes": 83859292,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 143.7,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 578.8779999998042,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.644000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.53100000000006,
"heapDeltaBytes": 13795604,
"heapUsedBytes": 83919524,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 144.639,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1989.5409999999174,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.169999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.99899999999997,
"heapDeltaBytes": -8747288,
"heapUsedBytes": 55435984,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.497,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2003.4279999999853,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.473999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.42299999999994,
"heapDeltaBytes": -5377236,
"heapUsedBytes": 64711884,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.509999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.3089999998992,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.431999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 703.136,
"heapDeltaBytes": -8481604,
"heapUsedBytes": 61581436,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 92.861,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.9929999998312,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.096000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 687.155,
"heapDeltaBytes": 9601776,
"heapUsedBytes": 79760712,
"domNodes": -275,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 91.76100000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1368.3799999998882,
"styleRecalcs": 16,
"styleRecalcDurationMs": 27.061,
"layouts": 5,
"layoutDurationMs": 11.586999999999998,
"taskDurationMs": 882.6500000000002,
"heapDeltaBytes": 20238396,
"heapUsedBytes": 103928680,
"domNodes": 13667,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 29.68,
"eventListeners": 2383,
"totalBlockingTimeMs": 125,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8212.782000000061,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.302,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5529.161,
"heapDeltaBytes": -6547048,
"heapUsedBytes": 80699308,
"domNodes": -246,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 2618.29,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8270.468000000164,
"styleRecalcs": 251,
"styleRecalcDurationMs": 40.24700000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5516.116,
"heapDeltaBytes": 11803080,
"heapUsedBytes": 99207936,
"domNodes": -219,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 2639.905,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13100.191999999879,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12733.592999999999,
"heapDeltaBytes": -18067476,
"heapUsedBytes": 202723132,
"domNodes": -8061,
"jsHeapTotalBytes": -11403264,
"scriptDurationMs": 223.41,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17411.638999999923,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16943.182,
"heapDeltaBytes": -35355164,
"heapUsedBytes": 191318532,
"domNodes": -8062,
"jsHeapTotalBytes": -14757888,
"scriptDurationMs": 284.432,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20920.639000000392,
"styleRecalcs": 154,
"styleRecalcDurationMs": 18.38300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20713.115999999998,
"heapDeltaBytes": -52844280,
"heapUsedBytes": 181727776,
"domNodes": -8061,
"jsHeapTotalBytes": -13148160,
"scriptDurationMs": 876.047,
"eventListeners": -14928,
"totalBlockingTimeMs": 69,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20614.11700000008,
"styleRecalcs": 145,
"styleRecalcDurationMs": 17.28999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20422.394999999997,
"heapDeltaBytes": -39304192,
"heapUsedBytes": 181887936,
"domNodes": -8062,
"jsHeapTotalBytes": -19099648,
"scriptDurationMs": 861.576,
"eventListeners": -14928,
"totalBlockingTimeMs": 69,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4828.335000000152,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.10900000000001,
"layouts": 20,
"layoutDurationMs": 24.407999999999998,
"taskDurationMs": 4778.143999999999,
"heapDeltaBytes": -39201856,
"heapUsedBytes": 187717412,
"domNodes": -8062,
"jsHeapTotalBytes": 17977344,
"scriptDurationMs": 91.226,
"eventListeners": -14928,
"totalBlockingTimeMs": 178,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6214.807000000292,
"styleRecalcs": 20,
"styleRecalcDurationMs": 91.11600000000003,
"layouts": 20,
"layoutDurationMs": 24.882,
"taskDurationMs": 6166.627,
"heapDeltaBytes": -66525644,
"heapUsedBytes": 162644712,
"domNodes": -8061,
"jsHeapTotalBytes": 2293760,
"scriptDurationMs": 115.62899999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 620,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8901.519000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8518.504000000003,
"heapDeltaBytes": 18790620,
"heapUsedBytes": 198756464,
"domNodes": 0,
"jsHeapTotalBytes": -11534336,
"scriptDurationMs": 139.10100000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8526.000000000295,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8341.327,
"heapDeltaBytes": 24599468,
"heapUsedBytes": 190649628,
"domNodes": 0,
"jsHeapTotalBytes": -14417920,
"scriptDurationMs": 132.07999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 474.81599999991886,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.787999999999997,
"layouts": 4,
"layoutDurationMs": 1.9879999999999998,
"taskDurationMs": 137.024,
"heapDeltaBytes": 5386176,
"heapUsedBytes": 67611780,
"domNodes": 151,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 15.763,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 101.79500000003827,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.285,
"layouts": 2,
"layoutDurationMs": 1.4120000000000001,
"taskDurationMs": 71.08899999999998,
"heapDeltaBytes": 2984256,
"heapUsedBytes": 68696284,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.2570000000000014,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
|
@coderabbitai review |
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 4 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 1 |
| 🟢 Low | 2 |
Panel: 8/8 reviewers contributed findings.
(cherry picked from commit 76233a6)
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #19847 +/- ##
=============================================
Coverage ? 84.91%
=============================================
Files ? 2318
Lines ? 132754
Branches ? 35531
=============================================
Hits ? 112728
Misses ? 19665
Partials ? 361
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Addresses review feedback: #19850 (comment) #19850 (comment) #19850 (comment) #19850 (comment) #19850 (comment) (cherry picked from commit 9303bd4)
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
|
Post-merge |
Summary
Backports #18154 so a refreshed or remounted Agent session immediately reconciles a persisted streaming turn instead of waiting for a socket transition. It also preserves locally streamed parts when the terminal persisted row is empty and covers the refresh journey in Playwright.
The automated backport conflicted only with a test file absent from this release branch; that unrelated file remains absent.
Related: PM-1776, PM-1682, PM-1199.
Validation