Repository navigation
[backport core/1.55] fix(agent): reconcile a hydrated streaming turn from REST after a refresh - #19846
Conversation
…resh (#18154) - Adds a cloud Playwright regression proving a turn that finishes only in REST history unlocks after a browser refresh. - Preserves locally streamed reply parts when a terminal history row is temporarily empty instead of replacing the visible reply with nothing. - Keeps recovery-map cleanup ownership-safe so an older job cannot evict a successor controller. The broader hydrated-turn recovery now already exists on `main` through [#18152](#18152) (socket-drop recovery) and [#19053](#19053) (panel-remount restoration). This PR was rebuilt on current `main` to retain only the still-additive hardening and black-box refresh coverage. - `useAgentSession.test.ts`: 201 passed, including the new empty-terminal-row regression. - Application and browser TypeScript checks passed. - Changed-file ESLint and Oxlint passed. - The Playwright case is collected as a cloud test. Its local run reached application startup but could not complete with the ad-hoc frontend-only server because the standard ComfyUI devtools backend was absent; hosted browser CI supplies that harness. Fixes the refresh half of [PM-1199](https://linear.app/comfyorg/issue/PM-1199/fix-agent-stream-drops-mid-turn-with-no-refresh-leaving-no-working) (an in-flight agent turn could remain locked after refresh). (cherry picked from commit ea63d4a)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2146 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (10 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 00be58054da44b193f1fa203423e132aa6d59a2d
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-02T02:26:18.271Z",
"gitSha": "197cf1bd35defe2e0d00885878ffca0da6bae27f",
"branch": "backport-18154-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1991.9610000000034,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.787999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.019,
"heapDeltaBytes": 9603320,
"heapUsedBytes": 77268844,
"domNodes": -259,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.088000000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2015.8720000000585,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.204000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.82199999999995,
"heapDeltaBytes": 2173104,
"heapUsedBytes": 69852260,
"domNodes": -257,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.784,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1802.3719999999912,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.446,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 817.618,
"heapDeltaBytes": -1594080,
"heapUsedBytes": 66088040,
"domNodes": -260,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 168.06,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1760.003000000097,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.537000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 722.3779999999999,
"heapDeltaBytes": 8168620,
"heapUsedBytes": 75801624,
"domNodes": -259,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 165.412,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1663.8829999999984,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.511999999999999,
"layouts": 6,
"layoutDurationMs": 1.13,
"taskDurationMs": 354.54299999999995,
"heapDeltaBytes": 3050124,
"heapUsedBytes": 70792584,
"domNodes": 77,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 12.065,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.2089999999307,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.685000000000002,
"layouts": 6,
"layoutDurationMs": 1.071,
"taskDurationMs": 334.605,
"heapDeltaBytes": 3139972,
"heapUsedBytes": 70969248,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.565999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 629.1540000000282,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.51,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.70799999999997,
"heapDeltaBytes": 18291264,
"heapUsedBytes": 80887932,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 168.315,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 645.1190000000224,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.997000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.094,
"heapDeltaBytes": 18902024,
"heapUsedBytes": 86615624,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 169.511,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1279.4260000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 961.779,
"heapDeltaBytes": -16928952,
"heapUsedBytes": 73963732,
"domNodes": -295,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 84.544,
"eventListeners": -217,
"totalBlockingTimeMs": 578,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1182.5359999999137,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 840.5759999999999,
"heapDeltaBytes": 35435824,
"heapUsedBytes": 103018556,
"domNodes": 0,
"jsHeapTotalBytes": 19558400,
"scriptDurationMs": 72.184,
"eventListeners": 0,
"totalBlockingTimeMs": 575,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 848.611999999946,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.14299999999974,
"heapDeltaBytes": 14654612,
"heapUsedBytes": 90866184,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 168.4,
"eventListeners": 0,
"totalBlockingTimeMs": 230,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 879.8669999999902,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.9300000000003,
"heapDeltaBytes": 14714308,
"heapUsedBytes": 91259756,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 176.12299999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 232,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10349.293000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9414.767999999998,
"heapDeltaBytes": -8969436,
"heapUsedBytes": 73251332,
"domNodes": -18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8037.972,
"eventListeners": 0,
"totalBlockingTimeMs": 1277,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10433.89400000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9571.314,
"heapDeltaBytes": -1645744,
"heapUsedBytes": 80813660,
"domNodes": -16,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7935.053000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1026,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10460.17599999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9645.471000000001,
"heapDeltaBytes": 11644704,
"heapUsedBytes": 93394556,
"domNodes": -16,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7976.702000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1075,
"frameDurationMs": 19.996666666666716,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10371.939999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9521.739,
"heapDeltaBytes": -9308340,
"heapUsedBytes": 72835120,
"domNodes": -14,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7858.154,
"eventListeners": 0,
"totalBlockingTimeMs": 1042,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2020.85900000003,
"styleRecalcs": 7,
"styleRecalcDurationMs": 9.832,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 568.2360000000001,
"heapDeltaBytes": -3687176,
"heapUsedBytes": 83624144,
"domNodes": -241,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 33.274,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2031.2139999999772,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.786999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.809,
"heapDeltaBytes": -3880452,
"heapUsedBytes": 83207348,
"domNodes": -240,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 34.149,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2195.695999999998,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.783000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1620.177,
"heapDeltaBytes": 14445436,
"heapUsedBytes": 79640464,
"domNodes": 10,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 829.004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2248.5789999999497,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.670000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1628.845,
"heapDeltaBytes": 15387720,
"heapUsedBytes": 79977652,
"domNodes": -247,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 845.379,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3552.254000000005,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.524000000000001,
"layouts": 60,
"layoutDurationMs": 13.378,
"taskDurationMs": 1678.1920000000002,
"heapDeltaBytes": 9891056,
"heapUsedBytes": 75015152,
"domNodes": -252,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 788.7959999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3601.5919999999824,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.615000000000004,
"layouts": 60,
"layoutDurationMs": 13.16,
"taskDurationMs": 1759.0119999999997,
"heapDeltaBytes": -15526452,
"heapUsedBytes": 73870236,
"domNodes": -255,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 797.8770000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3172.9230000000257,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.825999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1947.315,
"heapDeltaBytes": 787780,
"heapUsedBytes": 66716328,
"domNodes": 6,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 1014.899,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3163.5299999999233,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.373999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2022.3500000000004,
"heapDeltaBytes": -893124,
"heapUsedBytes": 90634944,
"domNodes": -253,
"jsHeapTotalBytes": 1232896,
"scriptDurationMs": 1019.3109999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.8429999999898,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.333999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 558.3240000000001,
"heapDeltaBytes": -4848540,
"heapUsedBytes": 84369796,
"domNodes": -247,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 35.94499999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2016.9369999999844,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.216000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.3409999999999,
"heapDeltaBytes": 20231344,
"heapUsedBytes": 84693732,
"domNodes": -248,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.48000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 548.9190000000121,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.398,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.37600000000003,
"heapDeltaBytes": 14071408,
"heapUsedBytes": 83824408,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 147.276,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 568.712000000005,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.861000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.18699999999995,
"heapDeltaBytes": 13988560,
"heapUsedBytes": 84026560,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 146.383,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2019.5420000000013,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.085,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.31199999999995,
"heapDeltaBytes": -1552184,
"heapUsedBytes": 68471124,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.237000000000002,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.1939999999468,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.681000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.611,
"heapDeltaBytes": -5826132,
"heapUsedBytes": 64145308,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.298,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.9090000000056,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.085999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 728.707,
"heapDeltaBytes": 8100696,
"heapUsedBytes": 77057416,
"domNodes": -275,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 104.05199999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.0330000000813,
"styleRecalcs": 45,
"styleRecalcDurationMs": 13.238,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 742.579,
"heapDeltaBytes": 8107692,
"heapUsedBytes": 77991408,
"domNodes": -278,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 108.28599999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.534999999967,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.391000000000002,
"layouts": 5,
"layoutDurationMs": 14.027000000000001,
"taskDurationMs": 923.4440000000002,
"heapDeltaBytes": 20214580,
"heapUsedBytes": 104103316,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 30.829,
"eventListeners": 2383,
"totalBlockingTimeMs": 146,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8434.96700000003,
"styleRecalcs": 251,
"styleRecalcDurationMs": 38.334999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5927.914000000001,
"heapDeltaBytes": -10730716,
"heapUsedBytes": 76534776,
"domNodes": -241,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 2878.842,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8455.179999999928,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.225,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5847.935,
"heapDeltaBytes": -10547504,
"heapUsedBytes": 76502476,
"domNodes": -242,
"jsHeapTotalBytes": 483328,
"scriptDurationMs": 2802.0490000000004,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17087.129000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16669.269,
"heapDeltaBytes": -22495588,
"heapUsedBytes": 191649236,
"domNodes": -8061,
"jsHeapTotalBytes": -12902400,
"scriptDurationMs": 269.594,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17096.78800000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16647.762,
"heapDeltaBytes": -48154296,
"heapUsedBytes": 172285000,
"domNodes": -8061,
"jsHeapTotalBytes": -14835712,
"scriptDurationMs": 278.11699999999996,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21016.143999999942,
"styleRecalcs": 161,
"styleRecalcDurationMs": 18.939999999999955,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20811.964,
"heapDeltaBytes": -47342876,
"heapUsedBytes": 193777208,
"domNodes": -8061,
"jsHeapTotalBytes": -15601664,
"scriptDurationMs": 935.8829999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 117,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20520.73299999995,
"styleRecalcs": 154,
"styleRecalcDurationMs": 19.87799999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20303.13,
"heapDeltaBytes": -66702272,
"heapUsedBytes": 170460988,
"domNodes": -8061,
"jsHeapTotalBytes": -12107776,
"scriptDurationMs": 957.9060000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 179,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6272.7160000000595,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.38899999999998,
"layouts": 20,
"layoutDurationMs": 22.921999999999997,
"taskDurationMs": 6150.48,
"heapDeltaBytes": -50361900,
"heapUsedBytes": 175383332,
"domNodes": -8061,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 104.57600000000002,
"eventListeners": -14927,
"totalBlockingTimeMs": 451,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6154.549000000088,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.45900000000003,
"layouts": 20,
"layoutDurationMs": 23.467000000000002,
"taskDurationMs": 6089.206,
"heapDeltaBytes": -33774908,
"heapUsedBytes": 184280472,
"domNodes": -8061,
"jsHeapTotalBytes": 16580608,
"scriptDurationMs": 109.37,
"eventListeners": -14928,
"totalBlockingTimeMs": 394,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6494.145000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6276.64,
"heapDeltaBytes": -12681364,
"heapUsedBytes": 178278052,
"domNodes": 0,
"jsHeapTotalBytes": -11534336,
"scriptDurationMs": 131.00100000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8587.37700000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8396.448999999999,
"heapDeltaBytes": -13534336,
"heapUsedBytes": 169517124,
"domNodes": 0,
"jsHeapTotalBytes": -33554432,
"scriptDurationMs": 158.715,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 118.62200000007306,
"styleRecalcs": 7,
"styleRecalcDurationMs": 16.284,
"layouts": 3,
"layoutDurationMs": 1.6679999999999997,
"taskDurationMs": 93.12099999999998,
"heapDeltaBytes": 3168756,
"heapUsedBytes": 68899740,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.780000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 114.96299999998882,
"styleRecalcs": 8,
"styleRecalcDurationMs": 21.487999999999996,
"layouts": 4,
"layoutDurationMs": 2.267,
"taskDurationMs": 90.02300000000002,
"heapDeltaBytes": 3011556,
"heapUsedBytes": 69010640,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.165999999999998,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
@coderabbitai review |
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 3 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 2 |
| 🟡 Medium | 1 |
Panel: 8/8 reviewers contributed findings.
(cherry picked from commit 76233a6)
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.55 #19846 +/- ##
============================================
Coverage 84.70% 84.70%
============================================
Files 2315 2315
Lines 132027 132081 +54
Branches 33370 35268 +1898
============================================
+ Hits 111828 111882 +54
Misses 19840 19840
Partials 359 359
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Addresses review feedback: #19850 (comment) #19850 (comment) #19850 (comment) #19850 (comment) #19850 (comment) (cherry picked from commit 9303bd4)
Summary
Backports #18154 so a refreshed or remounted Agent session immediately reconciles a persisted streaming turn instead of waiting for a socket transition. It also preserves locally streamed parts when the terminal persisted row is empty and covers the refresh journey in Playwright.
The automated backport conflicted only with a test file absent from this release branch; that unrelated file remains absent.
Related: PM-1776, PM-1682, PM-1199.
Validation