Skip to content

[backport cloud/1.54] fix(agent): reconcile a hydrated streaming turn from REST after a refresh - #19845

Merged
christian-byrne merged 5 commits into
cloud/1.54from
backport-18154-to-cloud-1.54
Oct 2, 2026
Merged

christian-byrne merged 5 commits into
cloud/1.54from
backport-18154-to-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Backports #18154 so a refreshed or remounted Agent session immediately reconciles a persisted streaming turn instead of waiting for a socket transition. It also preserves locally streamed parts when the terminal persisted row is empty and covers the refresh journey in Playwright.

The automated backport conflicted only with a test file absent from this release branch; that unrelated file remains absent.

Related: PM-1776, PM-1682, PM-1199.

Validation

  • focused useAgentSession unit suite passes on the release families
  • browser TypeScript check passes
  • source PR full CI and Playwright passed

…resh (#18154)

- Adds a cloud Playwright regression proving a turn that finishes only
in REST history unlocks after a browser refresh.
- Preserves locally streamed reply parts when a terminal history row is
temporarily empty instead of replacing the visible reply with nothing.
- Keeps recovery-map cleanup ownership-safe so an older job cannot evict
a successor controller.

The broader hydrated-turn recovery now already exists on `main` through
[#18152](#18152)
(socket-drop recovery) and
[#19053](#19053)
(panel-remount restoration). This PR was rebuilt on current `main` to
retain only the still-additive hardening and black-box refresh coverage.

- `useAgentSession.test.ts`: 201 passed, including the new
empty-terminal-row regression.
- Application and browser TypeScript checks passed.
- Changed-file ESLint and Oxlint passed.
- The Playwright case is collected as a cloud test. Its local run
reached application startup but could not complete with the ad-hoc
frontend-only server because the standard ComfyUI devtools backend was
absent; hosted browser CI supplies that harness.

Fixes the refresh half of
[PM-1199](https://linear.app/comfyorg/issue/PM-1199/fix-agent-stream-drops-mid-turn-with-no-refresh-leaving-no-working)
(an in-flight agent turn could remain locked after refresh).

(cherry picked from commit ea63d4a)
@vercel

vercel Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 2, 2026 2:12am UTC
billing-web-test Ignored Ignored Oct 2, 2026 2:12am UTC

Request Review

@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate cloud/1.54 Backport PRs for cloud 1.54 cursor-review Trigger multi-model Cursor agent review on this PR greenlight labels Oct 2, 2026
@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 0cd66f13-bc71-49d0-8fc3-3860068c8a30

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/02/2026, 02:13:59 AM UTC

Links

🎭 Playwright: ✅ 1983 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1962 / ❌ 0 / ⚠️ 2 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.9 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.8 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.7 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.1 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.1 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.7 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 142ms TBT · 102.1 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.8 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.2 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 90ms TBT · 160.7 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 373ms TBT · 168.9 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.8 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 549ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 63.9 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -181
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 28ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 902ms
canvas-mouse-sweep: script duration 169ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 61.0 MB
canvas-mouse-sweep: DOM nodes -277
canvas-mouse-sweep: event listeners -180
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 359ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.1 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 460ms
dom-widget-clipping: script duration 167ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.8 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 630ms
large-graph-idle: script duration 35ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 80.7 MB
large-graph-idle: DOM nodes -274
large-graph-idle: event listeners -193
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1600ms
large-graph-pan: script duration 839ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 82.1 MB
large-graph-pan: DOM nodes -282
large-graph-pan: event listeners -93
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1798ms
large-graph-zoom: script duration 799ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 68.1 MB
large-graph-zoom: DOM nodes -288
large-graph-zoom: event listeners -197
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1998ms
legacy-node-drag: script duration 1000ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 86.7 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 547ms
minimap-idle: script duration 31ms
minimap-idle: TBT 0ms
minimap-idle: heap used 84.1 MB
minimap-idle: DOM nodes -275
minimap-idle: event listeners -80
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 423ms
subgraph-dom-widget-clipping: script duration 147ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.4 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 484ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 61.4 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -225
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 26ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 813ms
subgraph-mouse-sweep: script duration 111ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 59.7 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -242
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 967ms
subgraph-transition-enter: script duration 31ms
subgraph-transition-enter: TBT 142ms
subgraph-transition-enter: heap used 102.1 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 6017ms
viewport-pan-sweep: script duration 2787ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 75.8 MB
viewport-pan-sweep: DOM nodes -276
viewport-pan-sweep: event listeners -162
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16564ms
vue-large-graph-idle: script duration 288ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.2 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14931
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 176
vue-large-graph-pan: task duration 20639ms
vue-large-graph-pan: script duration 930ms
vue-large-graph-pan: TBT 90ms
vue-large-graph-pan: heap used 160.7 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14927
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 79ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6020ms
vue-node-resize-workload: script duration 113ms
vue-node-resize-workload: TBT 373ms
vue-node-resize-workload: heap used 168.9 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14929
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8295ms
vue-zoom-out-idle: script duration 145ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 169.6 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -13
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 14ms
workflow-execution: layout count 2
workflow-execution: style recalc count 9
workflow-execution: task duration 74ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.8 MB
workflow-execution: DOM nodes 119
workflow-execution: event listeners 25
Raw data
{
  "timestamp": "2026-10-02T02:23:42.262Z",
  "gitSha": "de66a9d78d255765ef09ee63ef9780ba8e946f0d",
  "branch": "backport-18154-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2121.974000000023,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.843000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 606.779,
      "heapDeltaBytes": -2603532,
      "heapUsedBytes": 67192532,
      "domNodes": -280,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 8.627000000000002,
      "eventListeners": -168,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2037.826999999993,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.359999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 491.043,
      "heapDeltaBytes": -4674160,
      "heapUsedBytes": 66898788,
      "domNodes": -282,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 10.420000000000002,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1832.3009999999158,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 27.651,
      "layouts": 14,
      "layoutDurationMs": 3.596,
      "taskDurationMs": 930.322,
      "heapDeltaBytes": -10961244,
      "heapUsedBytes": 60074400,
      "domNodes": -277,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 175.93,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1826.5529999999899,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 28.499000000000002,
      "layouts": 14,
      "layoutDurationMs": 3.6240000000000006,
      "taskDurationMs": 873.5459999999999,
      "heapDeltaBytes": -1936252,
      "heapUsedBytes": 67821180,
      "domNodes": -277,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 161.129,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1661.9220000000041,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.638,
      "layouts": 6,
      "layoutDurationMs": 0.909,
      "taskDurationMs": 371.43799999999993,
      "heapDeltaBytes": 4692588,
      "heapUsedBytes": 75764764,
      "domNodes": 76,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 10.922999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1722.14699999995,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 16.546,
      "layouts": 6,
      "layoutDurationMs": 1.0130000000000001,
      "taskDurationMs": 346.78600000000006,
      "heapDeltaBytes": 4637960,
      "heapUsedBytes": 75358060,
      "domNodes": 79,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.434000000000003,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 725.6869999999935,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.284999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 465.71100000000007,
      "heapDeltaBytes": 18716940,
      "heapUsedBytes": 89349332,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 168.045,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 673.3990000000176,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.313999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 454.058,
      "heapDeltaBytes": -7536084,
      "heapUsedBytes": 63393304,
      "domNodes": 16,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 165.94299999999998,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2071.845999999937,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.153,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 649.296,
      "heapDeltaBytes": 9955536,
      "heapUsedBytes": 86101076,
      "domNodes": -267,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 38.010000000000005,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2068.508999999949,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.914999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 610.8099999999998,
      "heapDeltaBytes": 6128524,
      "heapUsedBytes": 83089080,
      "domNodes": -281,
      "jsHeapTotalBytes": -1150976,
      "scriptDurationMs": 32.33699999999999,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2287.625999999932,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.975000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1602.9430000000002,
      "heapDeltaBytes": -4028,
      "heapUsedBytes": 77616724,
      "domNodes": -284,
      "jsHeapTotalBytes": 647168,
      "scriptDurationMs": 862.185,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2187.227000000007,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 7.493999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1596.514,
      "heapDeltaBytes": 28170088,
      "heapUsedBytes": 94459244,
      "domNodes": -280,
      "jsHeapTotalBytes": 487424,
      "scriptDurationMs": 815.392,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3634.6609999999373,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 14.213,
      "layouts": 60,
      "layoutDurationMs": 12.761999999999999,
      "taskDurationMs": 1818.988,
      "heapDeltaBytes": -7583564,
      "heapUsedBytes": 71569480,
      "domNodes": -288,
      "jsHeapTotalBytes": 4091904,
      "scriptDurationMs": 805.322,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3671.6579999999794,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 14.184000000000003,
      "layouts": 60,
      "layoutDurationMs": 11.948,
      "taskDurationMs": 1777.198,
      "heapDeltaBytes": -7286716,
      "heapUsedBytes": 71209324,
      "domNodes": -287,
      "jsHeapTotalBytes": 3567616,
      "scriptDurationMs": 791.782,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3192.091000000005,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.995999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2084.53,
      "heapDeltaBytes": 25644212,
      "heapUsedBytes": 92957820,
      "domNodes": 0,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 1036.012,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3116.7279999999664,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.893999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1910.778,
      "heapDeltaBytes": 20752476,
      "heapUsedBytes": 88829320,
      "domNodes": 0,
      "jsHeapTotalBytes": 1990656,
      "scriptDurationMs": 963.262,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2030.4740000000265,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.2199999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 566.5440000000002,
      "heapDeltaBytes": 10168856,
      "heapUsedBytes": 87894248,
      "domNodes": -275,
      "jsHeapTotalBytes": -2199552,
      "scriptDurationMs": 33.10199999999999,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2004.9289999999473,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.2630000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 528.391,
      "heapDeltaBytes": 21800292,
      "heapUsedBytes": 88428972,
      "domNodes": -275,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 29.38500000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 589.7790000000214,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.875,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 427.61899999999997,
      "heapDeltaBytes": 15510792,
      "heapUsedBytes": 88629952,
      "domNodes": 20,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 148.954,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 614.4319999999652,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.684000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 418.67900000000003,
      "heapDeltaBytes": 14795044,
      "heapUsedBytes": 88466036,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 144.88199999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2012.9400000000714,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.027,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 487.85099999999994,
      "heapDeltaBytes": -3194860,
      "heapUsedBytes": 69877496,
      "domNodes": -298,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 7.92,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.370999999921,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.996000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 480.90000000000003,
      "heapDeltaBytes": -14691560,
      "heapUsedBytes": 58829060,
      "domNodes": -293,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.280000000000002,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1724.3080000000646,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 27.852,
      "layouts": 18,
      "layoutDurationMs": 4.681,
      "taskDurationMs": 820.277,
      "heapDeltaBytes": -9099112,
      "heapUsedBytes": 63335156,
      "domNodes": -297,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 113.156,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1723.9299999999957,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 25.022000000000002,
      "layouts": 18,
      "layoutDurationMs": 5.072,
      "taskDurationMs": 805.239,
      "heapDeltaBytes": -11157900,
      "heapUsedBytes": 61893340,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 108.048,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1401.766000000066,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 31.370000000000008,
      "layouts": 15,
      "layoutDurationMs": 15.657999999999998,
      "taskDurationMs": 967.249,
      "heapDeltaBytes": 22128000,
      "heapUsedBytes": 107037456,
      "domNodes": 13831,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 30.65099999999999,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 142,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9003.565999999977,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 37.55,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6203.617,
      "heapDeltaBytes": 14675668,
      "heapUsedBytes": 91016028,
      "domNodes": -270,
      "jsHeapTotalBytes": -172032,
      "scriptDurationMs": 2820.923,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8387.744999999995,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 36.571,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5830.378,
      "heapDeltaBytes": -8710372,
      "heapUsedBytes": 67990132,
      "domNodes": -281,
      "jsHeapTotalBytes": 1470464,
      "scriptDurationMs": 2752.997,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17151.606000000014,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16682.37,
      "heapDeltaBytes": -62451200,
      "heapUsedBytes": 177029136,
      "domNodes": -8068,
      "jsHeapTotalBytes": -20086784,
      "scriptDurationMs": 300.361,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17087.237000000074,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16445.197999999997,
      "heapDeltaBytes": -56657560,
      "heapUsedBytes": 182059380,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12746752,
      "scriptDurationMs": 276.165,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21153.207000000068,
      "styleRecalcs": 177,
      "styleRecalcDurationMs": 18.789,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20750.753,
      "heapDeltaBytes": -47786432,
      "heapUsedBytes": 170626224,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10002432,
      "scriptDurationMs": 938.0399999999998,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 54,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20937.977000000046,
      "styleRecalcs": 175,
      "styleRecalcDurationMs": 17.571999999999978,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20527.172,
      "heapDeltaBytes": -52652504,
      "heapUsedBytes": 166478908,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10280960,
      "scriptDurationMs": 921.62,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 125,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6145.336000000043,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.76500000000003,
      "layouts": 20,
      "layoutDurationMs": 22.786000000000016,
      "taskDurationMs": 6016.338999999999,
      "heapDeltaBytes": -41661904,
      "heapUsedBytes": 177162932,
      "domNodes": -8068,
      "jsHeapTotalBytes": 9379840,
      "scriptDurationMs": 112.79000000000002,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 351,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6131.324999999947,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 79.401,
      "layouts": 20,
      "layoutDurationMs": 22.85099999999998,
      "taskDurationMs": 6023.694999999999,
      "heapDeltaBytes": -46273080,
      "heapUsedBytes": 177118008,
      "domNodes": -8068,
      "jsHeapTotalBytes": 10199040,
      "scriptDurationMs": 113.075,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 395,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8501.67399999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8219.969000000001,
      "heapDeltaBytes": 20702188,
      "heapUsedBytes": 178528660,
      "domNodes": 0,
      "jsHeapTotalBytes": -11272192,
      "scriptDurationMs": 133.714,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8595.405000000028,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8369.616000000002,
      "heapDeltaBytes": 3497844,
      "heapUsedBytes": 177240208,
      "domNodes": 0,
      "jsHeapTotalBytes": -14680064,
      "scriptDurationMs": 156.76800000000003,
      "eventListeners": -13,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 107.358999999974,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 15.444999999999999,
      "layouts": 2,
      "layoutDurationMs": 0.5940000000000001,
      "taskDurationMs": 84.01899999999999,
      "heapDeltaBytes": 3148204,
      "heapUsedBytes": 72132732,
      "domNodes": 112,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.232,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 95.64699999998538,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 11.897000000000002,
      "layouts": 1,
      "layoutDurationMs": 0.678,
      "taskDurationMs": 64.05499999999999,
      "heapDeltaBytes": 3005720,
      "heapUsedBytes": 72067320,
      "domNodes": 126,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 4.688,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50912 76205 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.3% 253
src/scripts/pnginfo.ts 21.4% 221

@christian-byrne

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 4 finding(s).

Severity Count
🟠 High 1
🟡 Medium 1
🟢 Low 2

Panel: 8/8 reviewers contributed findings.

@codecov

codecov Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #19845   +/-   ##
=============================================
  Coverage              ?   84.23%           
=============================================
  Files                 ?     2126           
  Lines                 ?   127701           
  Branches              ?    32754           
=============================================
  Hits                  ?   107564           
  Misses                ?    19956           
  Partials              ?      181           
Flag Coverage Δ
e2e 66.86% <ø> (?)
unit 79.49% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ensions/agent/composables/agent/useAgentSession.ts 98.68% <100.00%> (ø)
...sions/agent/stores/agent/agentConversationStore.ts 95.85% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 2, 2026
@christian-byrne
christian-byrne merged commit 7eff88c into cloud/1.54 Oct 2, 2026
96 checks passed
@christian-byrne
christian-byrne deleted the backport-18154-to-cloud-1.54 branch October 2, 2026 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate cloud/1.54 Backport PRs for cloud 1.54 cursor-review Trigger multi-model Cursor agent review on this PR greenlight risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants