Repository navigation
[backport cloud/1.54] feat: cancel cloud asset downloads (#19281) - #19835
Conversation
Justification: Alex reviewed exact head b3485a7 and explicitly recorded “ready to approve”; all required exact-head checks are terminal green, every substantive thread is resolved, and the seven-commit main delta has zero file overlap with this PR. Applying the documented selective stale-approval exception; post-merge peer review remains routed to Alex.
Adjudicates the ten Cursor review findings on #19739 against source. All ten are substantiated; nine are fixed here and one is answered on the thread. A pending cancellation had no exit other than a terminal WS message or a successful poll, and `pollSingleDownload` collapsed every `getTask` failure into "retry later" - including a 404, which proves the task row is gone. A purged task therefore re-polled every 10s for the life of the page and stayed `cancellation_pending`, which is not a finished status, so the dialog withheld its only Close control and the toast was pinned open until a reload. A 404 now settles the cancellation, and an unconfirmed one settles after a bounded number of reconciliation attempts. `cancelled` is still replaceable by an authoritative `completed`, so the PM-1302 recovery premise is unchanged. `getTask` narrowed the shared `/tasks` response's `result` to the download-file shape, so an export task carrying `export_name`/`assets_total` failed `safeParse` and returned `ok: false`, making export reconciliation unreachable. `result` goes back to the generated opaque record and is parsed per task type at the call site. Export polling also gains the identity guard its download counterpart has - without it a poll resolving after a dismissal re-inserted the export with `downloadTriggered: false` and downloaded the archive twice - and now reconciles a server-side `cancelled` export instead of polling it forever. The upload wizard stopped watching at `failed` and `cancelled`, both of which the download store deliberately leaves recoverable, so a recovered import read as a failure and skipped `refreshModelCaches()`. It now stops only on `completed`, the one status the store treats as immutable. Two smaller repairs: `cancelTask` no longer interpolates an unbounded response body into an error that reaches a toast and telemetry, and it reports 404 and 409 as distinct outcomes so a refusal reconciles the row's real status instead of being a silent no-op. Reconciling to `cancelled` routes through `handleAssetDownload` rather than mutating in place, which drops the stale error a premature message left attached. Not fixed: cancellation is still only permitted from `created`/`running`. Allowing it from `failed` needs a Cancel affordance on a failed row, which is a product decision rather than a mechanical fix, and is answered on the thread.
Widening `AssetExport.status` to include `cancelled` left the export dialog without a branch for it, so a cancelled export fell through to the final `v-else` and rendered "Pending", and a cancelled-only set produced an "All exports completed" footer. Both now mirror the download dialog's existing cancelled treatment. Found by reviewing the reconciliation fix's own blast radius rather than by a review comment; the new component test is red on the prior component.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1983 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-02T00:38:07.920Z",
"gitSha": "a72b2fedcb571c9f6bc1ebdf5a3284155dd66cb0",
"branch": "backport-19281-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2137.964000000011,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.0440000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.956,
"heapDeltaBytes": 1740940,
"heapUsedBytes": 71701832,
"domNodes": 12,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.142,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2070.0180000000046,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.653000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.83600000000007,
"heapDeltaBytes": 3235920,
"heapUsedBytes": 73631016,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.104999999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1910.1570000000265,
"styleRecalcs": 74,
"styleRecalcDurationMs": 30.193,
"layouts": 14,
"layoutDurationMs": 4.309,
"taskDurationMs": 967.5840000000001,
"heapDeltaBytes": -7718648,
"heapUsedBytes": 62512724,
"domNodes": -281,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 159.606,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1789.4390000000158,
"styleRecalcs": 74,
"styleRecalcDurationMs": 26.031,
"layouts": 14,
"layoutDurationMs": 3.9779999999999998,
"taskDurationMs": 846.818,
"heapDeltaBytes": -11185412,
"heapUsedBytes": 59447944,
"domNodes": -283,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 141.303,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1660.3589999999713,
"styleRecalcs": 29,
"styleRecalcDurationMs": 13.979999999999999,
"layouts": 6,
"layoutDurationMs": 1.0250000000000001,
"taskDurationMs": 350.507,
"heapDeltaBytes": 4627008,
"heapUsedBytes": 75534940,
"domNodes": 76,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 10.242,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1747.427000000016,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.973,
"layouts": 6,
"layoutDurationMs": 1.1449999999999998,
"taskDurationMs": 344.72700000000003,
"heapDeltaBytes": 4622956,
"heapUsedBytes": 74865620,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.447999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 685.8179999999265,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.752999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.51399999999995,
"heapDeltaBytes": 18419780,
"heapUsedBytes": 89299320,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 156.228,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 647.6360000000341,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.4339999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.48300000000006,
"heapDeltaBytes": -7895416,
"heapUsedBytes": 63166800,
"domNodes": 18,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 158.325,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2034.1270000000122,
"styleRecalcs": 4,
"styleRecalcDurationMs": 6.229000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 602.8390000000002,
"heapDeltaBytes": 10480980,
"heapUsedBytes": 87006324,
"domNodes": -274,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 34.651,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2019.945000000007,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.060000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 670.4920000000001,
"heapDeltaBytes": 11937232,
"heapUsedBytes": 88810092,
"domNodes": -284,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 37.56999999999999,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2187.7170000000206,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.809000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1569.1350000000002,
"heapDeltaBytes": 23996868,
"heapUsedBytes": 90217072,
"domNodes": -277,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 755.405,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2359.1969999999947,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.926999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1719.4199999999998,
"heapDeltaBytes": 12776588,
"heapUsedBytes": 90285496,
"domNodes": -279,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 807.6070000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3536.183000000051,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.931000000000003,
"layouts": 60,
"layoutDurationMs": 13.168000000000001,
"taskDurationMs": 1723.515,
"heapDeltaBytes": 8207584,
"heapUsedBytes": 76352452,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 770.057,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3504.711999999927,
"styleRecalcs": 63,
"styleRecalcDurationMs": 14.053000000000003,
"layouts": 60,
"layoutDurationMs": 12.725999999999997,
"taskDurationMs": 1715.9430000000002,
"heapDeltaBytes": -3148112,
"heapUsedBytes": 75923172,
"domNodes": -279,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 755.765,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3054.9970000000712,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.457,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1909.5,
"heapDeltaBytes": 25089512,
"heapUsedBytes": 93232348,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 951.9219999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2999.1209999999455,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.318000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1865.695,
"heapDeltaBytes": 20689024,
"heapUsedBytes": 88106684,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 940.9989999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2059.449000000086,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.6000000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 622.166,
"heapDeltaBytes": 5468880,
"heapUsedBytes": 83281764,
"domNodes": -278,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 32.864,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2003.4910000001673,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.4509999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 537.848,
"heapDeltaBytes": 21864824,
"heapUsedBytes": 88720100,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.689000000000007,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.430000000083,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.252,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.164,
"heapDeltaBytes": 14771600,
"heapUsedBytes": 81174704,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 138.176,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.8239999999369,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.104000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.835,
"heapDeltaBytes": 14400720,
"heapUsedBytes": 86822924,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 148.584,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.5760000000719,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.2970000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.62999999999994,
"heapDeltaBytes": -10321264,
"heapUsedBytes": 62123720,
"domNodes": -300,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 7.2410000000000005,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2038.7230000000045,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.401999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.3109999999999,
"heapDeltaBytes": -7446592,
"heapUsedBytes": 65350684,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.668999999999999,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1777.3270000000139,
"styleRecalcs": 76,
"styleRecalcDurationMs": 29.132,
"layouts": 18,
"layoutDurationMs": 5.43,
"taskDurationMs": 839.189,
"heapDeltaBytes": -13409512,
"heapUsedBytes": 59821348,
"domNodes": -298,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 115.046,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1858.4640000000263,
"styleRecalcs": 76,
"styleRecalcDurationMs": 31.019000000000002,
"layouts": 18,
"layoutDurationMs": 5.823999999999999,
"taskDurationMs": 929.519,
"heapDeltaBytes": -8927528,
"heapUsedBytes": 63804872,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 124.93199999999999,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.6959999999626,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.293,
"layouts": 14,
"layoutDurationMs": 13.657000000000002,
"taskDurationMs": 917.303,
"heapDeltaBytes": 22097864,
"heapUsedBytes": 106801964,
"domNodes": 13831,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 28.544,
"eventListeners": 2387,
"totalBlockingTimeMs": 129,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8610.568999999941,
"styleRecalcs": 247,
"styleRecalcDurationMs": 39.394,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6013.25,
"heapDeltaBytes": 19457676,
"heapUsedBytes": 95824292,
"domNodes": -271,
"jsHeapTotalBytes": 385024,
"scriptDurationMs": 2798.286,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8419.605000000047,
"styleRecalcs": 248,
"styleRecalcDurationMs": 38.22,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5799.612,
"heapDeltaBytes": 3438748,
"heapUsedBytes": 80070656,
"domNodes": -285,
"jsHeapTotalBytes": 909312,
"scriptDurationMs": 2693.228,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18364.22499999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17837.637000000002,
"heapDeltaBytes": -71625676,
"heapUsedBytes": 167424580,
"domNodes": -8068,
"jsHeapTotalBytes": -17215488,
"scriptDurationMs": 325.03099999999995,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17847.152999999933,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17123.071,
"heapDeltaBytes": -59863016,
"heapUsedBytes": 178214792,
"domNodes": -8068,
"jsHeapTotalBytes": -18526208,
"scriptDurationMs": 323.788,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22605.528999999933,
"styleRecalcs": 171,
"styleRecalcDurationMs": 22.544000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22340.371,
"heapDeltaBytes": -42060440,
"heapUsedBytes": 184597492,
"domNodes": -8068,
"jsHeapTotalBytes": -16183296,
"scriptDurationMs": 945.223,
"eventListeners": -14929,
"totalBlockingTimeMs": 159,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-large-graph-pan",
"durationMs": 21939.558000000034,
"styleRecalcs": 168,
"styleRecalcDurationMs": 19.648999999999972,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21541.733,
"heapDeltaBytes": -57776224,
"heapUsedBytes": 170852656,
"domNodes": -8068,
"jsHeapTotalBytes": -20385792,
"scriptDurationMs": 953.21,
"eventListeners": -14927,
"totalBlockingTimeMs": 149,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6393.385999999964,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.92500000000003,
"layouts": 20,
"layoutDurationMs": 23.902999999999995,
"taskDurationMs": 6287.652999999999,
"heapDeltaBytes": -48667976,
"heapUsedBytes": 184836188,
"domNodes": -8068,
"jsHeapTotalBytes": 19648512,
"scriptDurationMs": 119.565,
"eventListeners": -14931,
"totalBlockingTimeMs": 393,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6342.8429999999025,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.99700000000004,
"layouts": 20,
"layoutDurationMs": 24.186,
"taskDurationMs": 6244.838,
"heapDeltaBytes": -44424960,
"heapUsedBytes": 184121452,
"domNodes": -8068,
"jsHeapTotalBytes": 6602752,
"scriptDurationMs": 117.98700000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 543,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8741.438000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8499.315,
"heapDeltaBytes": 8167500,
"heapUsedBytes": 178990968,
"domNodes": 0,
"jsHeapTotalBytes": -10223616,
"scriptDurationMs": 144.21300000000002,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8799.657000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8444.479,
"heapDeltaBytes": 19670556,
"heapUsedBytes": 177261432,
"domNodes": 0,
"jsHeapTotalBytes": -11796480,
"scriptDurationMs": 170.6500000000001,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 87.69599999993716,
"styleRecalcs": 7,
"styleRecalcDurationMs": 12.203000000000001,
"layouts": 2,
"layoutDurationMs": 1,
"taskDurationMs": 64.61600000000001,
"heapDeltaBytes": 3036948,
"heapUsedBytes": 71712508,
"domNodes": 123,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.216999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 452.30800000013005,
"styleRecalcs": 13,
"styleRecalcDurationMs": 17.787000000000003,
"layouts": 2,
"layoutDurationMs": 0.485,
"taskDurationMs": 96.91700000000002,
"heapDeltaBytes": 4878300,
"heapUsedBytes": 76313504,
"domNodes": 119,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 8.27,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.54 #19835 +/- ##
=============================================
Coverage ? 84.20%
=============================================
Files ? 2123
Lines ? 127623
Branches ? 32425
=============================================
Hits ? 107466
Misses ? 19976
Partials ? 181
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 3 |
| 🟢 Low | 6 |
Panel: 8/8 reviewers contributed findings.
| } | ||
| return | ||
| } | ||
| noteUnresolvedCancellation(download) |
There was a problem hiding this comment.
🟠 High — Any non-404 getTask failure — offline, 5xx, or a zod parse error — increments cancellationReconcileAttempts exactly like an authoritative "still running" answer, so roughly 60s of backend trouble reaches finalizeCancellation and flips the row to cancelled while the task may still be running. cancelled is excluded from recheckableStatuses and shouldIgnoreDownloadUpdate drops every later status except completed, so a download that actually failed or is still going can report "Cancelled" permanently. Count only polls that were actually answered (or use a wall-clock deadline) instead of charging transport failures against the bound. Raised by 5 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max edge-case).
| @@ -153,35 +284,7 @@ export const useAssetDownloadStore = defineStore('assetDownload', () => { | |||
|
|
|||
| if (staleDownloads.length === 0) return | |||
|
|
|||
There was a problem hiding this comment.
🟡 Medium — pollStaleDownloads is launched by useIntervalFn with no in-flight guard, and noteUnresolvedCancellation never refreshes lastUpdate, so every 10s tick fires another getTask for the same stale row while earlier ones are still outstanding (up to the 60s fetch timeout). Because entering cancellation_pending mutates the same object rather than replacing it, those pre-cancellation requests still pass the identity guard on line 250 and each burns one of the six attempts, so the bound can be exhausted in far less than the intended 60s. Skipping a tick while a poll is in flight, or versioning the entry on the state transition, addresses both. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, gpt-5.6-sol-max edge-case).
| stopAsyncWatch = undefined | ||
| } else if (status === 'failed') { | ||
| watchState.resolved = true | ||
| } else if ( |
There was a problem hiding this comment.
🟡 Medium — This branch no longer calls stopAsyncWatch(), so a genuinely terminal failed/cancelled leaves the watcher subscribed forever. It is created after awaits inside uploadModel(), so it is outside the component's effect scope and is never auto-disposed, and closing the dialog does not call resetWizard() — each failed or cancelled import leaks a watcher that re-scans downloadList on every store mutation and can still fire refreshModelCaches() for a dialog the user closed long ago. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial).
| `${TASKS_ENDPOINT}/${encodeURIComponent(taskId)}`, | ||
| { method: 'DELETE' } | ||
| ) | ||
| if (res.status === 404) return { ok: true, value: 'missing' } |
There was a problem hiding this comment.
🟡 Medium — A 404 here is read as "the row existed and is now gone", but the same status comes back from a backend that does not implement DELETE /tasks/{id} at all, and from a row purged after the task already completed or failed. cancelDownload maps 'missing' straight to finalizeCancellation, so on either path the user is told "Cancelled" while the download is still running or has already produced an asset; getTask's TaskNotFoundError settles a pending cancellation with the same ambiguity. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max adversarial).
|
|
||
| <Button | ||
| v-if="!isInProgress" | ||
| v-if="!isInProgress && !assetDownloadStore.hasPendingCancellation" |
There was a problem hiding this comment.
🟢 Low — hasPendingCancellation is store-wide, so one unconfirmed cancellation removes the Close control for the whole toast, blocking dismissal of unrelated completed/failed rows for up to MAX_CANCELLATION_RECONCILE_ATTEMPTS * POLL_INTERVAL_MS (~60s, longer in a throttled background tab). Gate the control on the specific row, or keep Close enabled and have clearFinishedDownloads skip pending entries. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case).
|
|
||
| async function cancelDownload(taskId: TaskId) { | ||
| const result = await assetDownloadStore.cancelDownload(taskId) | ||
| if (result.ok) return |
There was a problem hiding this comment.
🟢 Low — A refused or no-op cancellation returns { ok: true, value: false }, which this returns on silently — the Cancel button simply re-enables with no explanation. The store's 'not-cancellable' branch re-reads the task to compensate, but if that getTask also fails transiently reconcileDownload changes nothing (the row is still running, so noteUnresolvedCancellation no-ops), producing exactly the silent no-op the comment above reconcileDownload(current) says it is preventing. Raised by 2 of 8 reviewers (kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case).
| if (!result.ok) return result | ||
|
|
||
| const current = downloads.value.get(taskId) | ||
| if (!current || finishedStatuses.has(current.status)) { |
There was a problem hiding this comment.
🟢 Low — finishedStatuses includes failed, but this store deliberately treats failed as recoverable because the backend may still be retrying. If a premature failed message lands while the DELETE is in flight, the accepted cancellation returns here without entering cancellation_pending, so the row stays dismissible and the bounded reconciliation never runs. Only completed/cancelled should short-circuit this transition. Raised by 1 of 8 reviewers (gpt-5.6-sol-max edge-case).
| if ( | ||
| cancellingTaskIds.value.has(taskId) || | ||
| !download || | ||
| !activeStatuses.has(download.status) |
There was a problem hiding this comment.
🟢 Low — Cancellation is only permitted from created/running, and ProgressToastItem likewise renders the button only for those. Since the premise of this PR is that a failed download may still be running under a silent backend retry, there is no way to stop one once that premature failed arrives — the user can only dismiss the row while the download keeps consuming bandwidth and storage. Raised by 1 of 8 reviewers (gpt-5.6-sol-max adversarial).
| status === 'cancellation_pending' || | ||
| status === 'cancelled' | ||
| ) { | ||
| // Keep watching: the download store leaves `failed` recheckable |
There was a problem hiding this comment.
🟢 Low — The comment is right that the store can recover, but there is no branch for the status going back to created/running, and shouldIgnoreDownloadUpdate explicitly allows failed -> running. During the silent backend retry this PR is built around, the wizard stays pinned on the error screen with stale "Download failed" text while the download streams progress; resetting uploadStatus to 'processing' on an active status closes the gap. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
| comfyExpect as expect | ||
| } from '@e2e/fixtures/ComfyPage' | ||
|
|
||
| test.describe('Model import progress toast', { tag: ['@screenshot'] }, () => { |
There was a problem hiding this comment.
🟢 Low — The moved spec dropped the @cloud tag the deleted file carried, which shifts this PM-1302 coverage out of the cloud project and into the grep-inverted chromium project. The directory move also changes the toHaveScreenshot baseline path (new -snapshots directory plus project suffix), so confirm model-import-progress-toast-recovered-completed.png was relocated/regenerated and that dropping cloud-distribution coverage was intentional. Raised by 1 of 8 reviewers (kimi-k3-max edge-case).
Summary
Backports #19281 to
cloud/1.54, including the release-line compatibility fixes already validated on thecloud/1.55backport.Validation
pnpm typecheck:apppnpm typecheck:browserBackport of #19281.