Repository navigation
[backport core/1.54] feat: cancel cloud asset downloads (#19281) - #19791
Conversation
Justification: Alex reviewed exact head b3485a7 and explicitly recorded “ready to approve”; all required exact-head checks are terminal green, every substantive thread is resolved, and the seven-commit main delta has zero file overlap with this PR. Applying the documented selective stale-approval exception; post-merge peer review remains routed to Alex.
Adjudicates the ten Cursor review findings on #19739 against source. All ten are substantiated; nine are fixed here and one is answered on the thread. A pending cancellation had no exit other than a terminal WS message or a successful poll, and `pollSingleDownload` collapsed every `getTask` failure into "retry later" - including a 404, which proves the task row is gone. A purged task therefore re-polled every 10s for the life of the page and stayed `cancellation_pending`, which is not a finished status, so the dialog withheld its only Close control and the toast was pinned open until a reload. A 404 now settles the cancellation, and an unconfirmed one settles after a bounded number of reconciliation attempts. `cancelled` is still replaceable by an authoritative `completed`, so the PM-1302 recovery premise is unchanged. `getTask` narrowed the shared `/tasks` response's `result` to the download-file shape, so an export task carrying `export_name`/`assets_total` failed `safeParse` and returned `ok: false`, making export reconciliation unreachable. `result` goes back to the generated opaque record and is parsed per task type at the call site. Export polling also gains the identity guard its download counterpart has - without it a poll resolving after a dismissal re-inserted the export with `downloadTriggered: false` and downloaded the archive twice - and now reconciles a server-side `cancelled` export instead of polling it forever. The upload wizard stopped watching at `failed` and `cancelled`, both of which the download store deliberately leaves recoverable, so a recovered import read as a failure and skipped `refreshModelCaches()`. It now stops only on `completed`, the one status the store treats as immutable. Two smaller repairs: `cancelTask` no longer interpolates an unbounded response body into an error that reaches a toast and telemetry, and it reports 404 and 409 as distinct outcomes so a refusal reconciles the row's real status instead of being a silent no-op. Reconciling to `cancelled` routes through `handleAssetDownload` rather than mutating in place, which drops the stale error a premature message left attached. Not fixed: cancellation is still only permitted from `created`/`running`. Allowing it from `failed` needs a Cancel affordance on a failed row, which is a product decision rather than a mechanical fix, and is answered on the thread.
Widening `AssetExport.status` to include `cancelled` left the export dialog without a branch for it, so a cancelled export fell through to the final `v-else` and rendered "Pending", and a cancelled-only set produced an "All exports completed" footer. Both now mirror the download dialog's existing cancelled treatment. Found by reviewing the reconciliation fix's own blast radius rather than by a review comment; the new component test is red on the prior component.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1983 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-01T18:24:32.225Z",
"gitSha": "1f87aac2b631c272b2f169cd261a8c62931f93d8",
"branch": "backport-19281-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2050.1809999999523,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.287000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.2860000000001,
"heapDeltaBytes": 8545284,
"heapUsedBytes": 78753712,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 11.067999999999998,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2038.0870000000186,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.5040000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.1569999999999,
"heapDeltaBytes": -12072476,
"heapUsedBytes": 57776092,
"domNodes": -282,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 12.937000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1982.0960000000696,
"styleRecalcs": 74,
"styleRecalcDurationMs": 33.632999999999996,
"layouts": 14,
"layoutDurationMs": 4.738,
"taskDurationMs": 978.8140000000001,
"heapDeltaBytes": -5722936,
"heapUsedBytes": 64688068,
"domNodes": -285,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 161.138,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1725.0409999999192,
"styleRecalcs": 73,
"styleRecalcDurationMs": 24.201999999999998,
"layouts": 14,
"layoutDurationMs": 3.842,
"taskDurationMs": 757.119,
"heapDeltaBytes": -4216468,
"heapUsedBytes": 66645972,
"domNodes": -279,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 127.29500000000002,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1665.0660000000244,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.630999999999998,
"layouts": 6,
"layoutDurationMs": 1.0259999999999998,
"taskDurationMs": 356.236,
"heapDeltaBytes": 4531780,
"heapUsedBytes": 75004376,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.046000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1670.3640000000632,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.86,
"layouts": 6,
"layoutDurationMs": 0.9649999999999997,
"taskDurationMs": 317.27500000000003,
"heapDeltaBytes": 4653660,
"heapUsedBytes": 76019172,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.171000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 558.1409999999778,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.638999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.6259999999999,
"heapDeltaBytes": 17799500,
"heapUsedBytes": 82680076,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 131.652,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 563.8449999999011,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.973999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.198,
"heapDeltaBytes": 18700852,
"heapUsedBytes": 89142256,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 129.61499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2052.077000000054,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.3420000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 678.315,
"heapDeltaBytes": 5961516,
"heapUsedBytes": 82164580,
"domNodes": -282,
"jsHeapTotalBytes": -888832,
"scriptDurationMs": 38.47899999999999,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2051.988999999935,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.161,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 654.0759999999999,
"heapDeltaBytes": 9402584,
"heapUsedBytes": 85543876,
"domNodes": -272,
"jsHeapTotalBytes": -626688,
"scriptDurationMs": 33.52300000000001,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2300.4789999999957,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.712,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1547.11,
"heapDeltaBytes": -575856,
"heapUsedBytes": 76252248,
"domNodes": -280,
"jsHeapTotalBytes": 909312,
"scriptDurationMs": 709.7789999999999,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2254.1740000000345,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.789000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1409.145,
"heapDeltaBytes": 23091816,
"heapUsedBytes": 89697156,
"domNodes": -270,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 674.5759999999999,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3505.9009999999944,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.808999999999996,
"layouts": 60,
"layoutDurationMs": 12.612,
"taskDurationMs": 1604.473,
"heapDeltaBytes": 11108908,
"heapUsedBytes": 77870756,
"domNodes": -279,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 717.8749999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3337.611000000038,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.65,
"layouts": 60,
"layoutDurationMs": 12.328999999999999,
"taskDurationMs": 1521.415,
"heapDeltaBytes": 10206348,
"heapUsedBytes": 77932360,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 687.9789999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2467.2819999999547,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.825000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1603.111,
"heapDeltaBytes": 17249832,
"heapUsedBytes": 97635460,
"domNodes": 12,
"jsHeapTotalBytes": 6447104,
"scriptDurationMs": 823.9369999999999,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2336.892999999918,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.423999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1601.7780000000005,
"heapDeltaBytes": 17561488,
"heapUsedBytes": 85933940,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 767.756,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2001.4199999999391,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.307999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.523,
"heapDeltaBytes": 21885548,
"heapUsedBytes": 87912284,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.93600000000001,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2031.3559999999597,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.260999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 635.75,
"heapDeltaBytes": 4907104,
"heapUsedBytes": 82432788,
"domNodes": -279,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 39.31,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 556.7020000000866,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.595000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.0640000000001,
"heapDeltaBytes": 13803376,
"heapUsedBytes": 86482484,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 121.91799999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 514.2029999999522,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.954,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 351.729,
"heapDeltaBytes": 14146116,
"heapUsedBytes": 86911336,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 117.69200000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1989.7639999999228,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.547,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.661,
"heapDeltaBytes": -13526100,
"heapUsedBytes": 59783384,
"domNodes": -296,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.581000000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2006.40599999997,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.832999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.965,
"heapDeltaBytes": -7480180,
"heapUsedBytes": 65103392,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.526,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1720.2539999999544,
"styleRecalcs": 76,
"styleRecalcDurationMs": 24.847999999999995,
"layouts": 18,
"layoutDurationMs": 4.322,
"taskDurationMs": 751.717,
"heapDeltaBytes": -7528700,
"heapUsedBytes": 64703020,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 95.541,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.3879999999526,
"styleRecalcs": 79,
"styleRecalcDurationMs": 25.023000000000003,
"layouts": 18,
"layoutDurationMs": 4.253,
"taskDurationMs": 721.4300000000001,
"heapDeltaBytes": -3443252,
"heapUsedBytes": 69132636,
"domNodes": -294,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 94.113,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1335.3419999999687,
"styleRecalcs": 21,
"styleRecalcDurationMs": 28.946999999999992,
"layouts": 17,
"layoutDurationMs": 13.773999999999997,
"taskDurationMs": 879.2260000000001,
"heapDeltaBytes": -6987768,
"heapUsedBytes": 82990948,
"domNodes": 13831,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 28.299999999999997,
"eventListeners": 2387,
"totalBlockingTimeMs": 132,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8636.046999999962,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.2,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5131.562000000001,
"heapDeltaBytes": -13408912,
"heapUsedBytes": 89398268,
"domNodes": -264,
"jsHeapTotalBytes": -102400,
"scriptDurationMs": 2238.366,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8442.745999999943,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.489,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4993.309,
"heapDeltaBytes": 9043364,
"heapUsedBytes": 85689220,
"domNodes": -268,
"jsHeapTotalBytes": 385024,
"scriptDurationMs": 2183.739,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15766.985000000092,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15091.294000000002,
"heapDeltaBytes": -38974452,
"heapUsedBytes": 179275036,
"domNodes": -8068,
"jsHeapTotalBytes": -10219520,
"scriptDurationMs": 235.88899999999995,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15332.441000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14831.104,
"heapDeltaBytes": -43787932,
"heapUsedBytes": 182683004,
"domNodes": -8068,
"jsHeapTotalBytes": -11325440,
"scriptDurationMs": 228.26000000000002,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 18442.136000000006,
"styleRecalcs": 130,
"styleRecalcDurationMs": 18.513999999999974,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18220.150999999998,
"heapDeltaBytes": -41433492,
"heapUsedBytes": 183362804,
"domNodes": -8068,
"jsHeapTotalBytes": -18292736,
"scriptDurationMs": 814.322,
"eventListeners": -14929,
"totalBlockingTimeMs": 34,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 17934.844999999994,
"styleRecalcs": 126,
"styleRecalcDurationMs": 16.28099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17669.796,
"heapDeltaBytes": -39144440,
"heapUsedBytes": 180457728,
"domNodes": -8068,
"jsHeapTotalBytes": -11825152,
"scriptDurationMs": 758.547,
"eventListeners": -14931,
"totalBlockingTimeMs": 14,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5540.397999999982,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.63199999999999,
"layouts": 20,
"layoutDurationMs": 23.02599999999999,
"taskDurationMs": 5514.739999999999,
"heapDeltaBytes": -32333280,
"heapUsedBytes": 185799868,
"domNodes": -8068,
"jsHeapTotalBytes": 19148800,
"scriptDurationMs": 95.82300000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 294,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5536.062000000015,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.493999999999964,
"layouts": 20,
"layoutDurationMs": 22.082000000000004,
"taskDurationMs": 5474.407,
"heapDeltaBytes": -33172820,
"heapUsedBytes": 186774164,
"domNodes": -8068,
"jsHeapTotalBytes": 22642688,
"scriptDurationMs": 98.291,
"eventListeners": -14929,
"totalBlockingTimeMs": 233,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7661.094000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7500.908,
"heapDeltaBytes": 17756904,
"heapUsedBytes": 193892764,
"domNodes": 0,
"jsHeapTotalBytes": -15204352,
"scriptDurationMs": 117.54700000000001,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7743.841999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7445.384000000001,
"heapDeltaBytes": 19728200,
"heapUsedBytes": 182914296,
"domNodes": 0,
"jsHeapTotalBytes": -12845056,
"scriptDurationMs": 114.31599999999997,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 134.49899999989157,
"styleRecalcs": 9,
"styleRecalcDurationMs": 14.179999999999998,
"layouts": 2,
"layoutDurationMs": 1.009,
"taskDurationMs": 73.04200000000002,
"heapDeltaBytes": 3136548,
"heapUsedBytes": 72561236,
"domNodes": 138,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.365999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999995,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 81.80499999991753,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.85,
"layouts": 1,
"layoutDurationMs": 0.629,
"taskDurationMs": 48.402,
"heapDeltaBytes": 2948396,
"heapUsedBytes": 71456688,
"domNodes": 123,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 3.049999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 4 |
| 🟢 Low | 5 |
Panel: 6/8 reviewers contributed findings.
Reviewers that did not contribute: gemini-3.1-pro:adversarial (error), gemini-3.1-pro:edge-case (error)
|
|
||
| // The task row is gone, so the cancellation is as settled as it will get. | ||
| if (result.value === 'missing') { | ||
| finalizeCancellation(current) |
There was a problem hiding this comment.
🟠 High — A 404 from DELETE /tasks/{id} is treated as proof the cancellation won, but it is equally what a backend that does not yet route that method returns (precisely the skew this file's own comment anticipates) and what a reaped row returns after a missed terminal message. finalizeCancellation then pins the entry to cancelled, which is absent from recheckableStatuses, so polling stops and a still-running or already-completed download reads as "Cancelled" permanently while lastCompletedDownload never fires to refresh the model cache. The sibling 409 branch verifies with reconcileDownload before settling; this branch should too. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case, kimi-k3-max adversarial).
| } | ||
| return | ||
| } | ||
| noteUnresolvedCancellation(download) |
There was a problem hiding this comment.
🟡 Medium — Transient getTask failures (503s, offline, aborted fetches, the 60s fetchApi timeout, malformed-response validation errors) increment the same counter as "the backend says the task is still running", so roughly a minute of network trouble exhausts the bound and finalizeCancellation asserts cancelled while clearing download.error. If the task actually failed or is still downloading, the user is shown a fabricated "Cancelled" with the real error discarded, and since cancelled is not recheckable the entry never reconciles again. Only a reachable-but-unconfirmed task should count against a bound whose purpose is "the DELETE was accepted but no terminal status arrives". Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case).
| status === 'cancellation_pending' || | ||
| status === 'cancelled' | ||
| ) { | ||
| // Keep watching: the download store leaves `failed` recheckable |
There was a problem hiding this comment.
🟡 Medium — The terminal-error branch no longer sets watchState.resolved nor calls stopAsyncWatch?.(), and this watch is created after two awaits inside uploadModel, so no effect scope is active and Vue will never dispose it on unmount. UploadModelDialog.handleClose only closes the dialog without calling resetWizard, so every failed or cancelled import leaves a live watcher subscribed to assetDownloadStore.downloadList that keeps writing uploadStatus/uploadError for a discarded wizard, accumulating over a session. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max adversarial).
| // cancellation has nothing left to wait for. Any other failure is | ||
| // transient and only counts against the attempt bound. | ||
| if (result.error instanceof TaskNotFoundError) { | ||
| if (download.status === 'cancellation_pending') { |
There was a problem hiding this comment.
🟡 Medium — The authoritative 404 only settles a cancellation_pending entry; a created/running/failed download whose task row provably no longer exists keeps its status and is re-polled every 10s for the life of the page with no termination condition (the new test "keeps re-polling a running download whose task lookup 404s" pins this). For an active status isInProgress stays true, so ModelImportProgressDialog renders no Close control and that toast cannot be dismissed at all. Since a 404 means no terminal status can ever arrive, these entries should also be settled or at least dropped from polling. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case).
|
|
||
| // A cancelled export is only superseded by an authoritative completion; | ||
| // a stale progress message must not revive it and resume polling. | ||
| if (existing?.status === 'cancelled' && data.status !== 'completed') return |
There was a problem hiding this comment.
🟡 Medium — Adding cancelled to the export WS enum makes a completed-but-undownloaded export clobberable: the guard above only short-circuits when existing.downloadTriggered is true, and triggerDownload resets it to false when the archive fetch fails. A late cancelled message for that task then passes both guards and overwrites the completed entry, which removes the retry-download button in AssetExportProgressDialog and strands a finished archive the user can no longer fetch. completed should be immutable here the way it is in assetDownloadStore.shouldIgnoreDownloadUpdate. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case).
| @@ -153,35 +284,7 @@ export const useAssetDownloadStore = defineStore('assetDownload', () => { | |||
|
|
|||
| if (staleDownloads.length === 0) return | |||
|
|
|||
There was a problem hiding this comment.
🟢 Low — useIntervalFn does not await pollStaleDownloads, and because STALE_THRESHOLD_MS equals POLL_INTERVAL_MS while lastUpdate is only refreshed on a terminal status, each tick re-issues getTask for the same download even when the previous request is still outstanding. On the transient-failure and non-reconcilable paths the map entry is never replaced, so the identity guard passes for every overlapping call and each increments cancellationReconcileAttempts — the six-attempt bound can be consumed by concurrent duplicates well inside the intended ~60s grace. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
|
|
||
| <Button | ||
| v-if="!isInProgress" | ||
| v-if="!isInProgress && !assetDownloadStore.hasPendingCancellation" |
There was a problem hiding this comment.
🟢 Low — hasPendingCancellation is store-wide, so one provisionally cancelled download removes the only Close control for the entire toast, including unrelated completed and failed rows the user may want to dismiss. Since each of the six reconcile attempts can take up to the 60s fetchApi timeout, a slow backend can leave the toast undismissable for minutes; gate per-row instead of on any pending cancellation anywhere in the store. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| // dismissed the toast re-inserts the export with `downloadTriggered` | ||
| // false, which resurrects it and downloads the archive a second time. | ||
| if (exports.value.get(exp.taskId) !== exp) return | ||
| if (!result.ok) return |
There was a problem hiding this comment.
🟢 Low — if (!result.ok) return discards TaskNotFoundError along with transient failures, so an export whose task row was purged (for example after a server-side cancellation, since DELETE /tasks/{id} is task-type agnostic) stays running forever: it never reaches finishedExportStatuses, is re-polled every 10s for the life of the page, and clearFinishedExports can never remove it from the dialog. The download store already distinguishes this case. Raised by 2 of 8 reviewers (gpt-5.6-sol-max edge-case, gpt-5.6-sol-max adversarial).
| if (currentStatus === 'completed') return true | ||
| if (currentStatus === 'cancelled') return nextStatus !== 'completed' | ||
| if (currentStatus === 'cancellation_pending') { | ||
| return !reconcilableTaskStatuses.has(nextStatus) |
There was a problem hiding this comment.
🟢 Low — reconcilableTaskStatuses includes failed, so a cancellation_pending entry accepts exactly the premature terminal failed broadcast this change exists to work around (PM-1302): the user's cancellation is discarded and the row is relabelled failed with the backend's stale error text. Since failed is treated as untrustworthy everywhere else in this file, it should not be authoritative enough to resolve a pending cancellation. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
| asset_id: result?.asset_id ?? download.assetId, | ||
| asset_name: result?.filename ?? download.assetName, | ||
| bytes_total: download.bytesTotal, | ||
| bytes_downloaded: result?.bytes_downloaded ?? download.bytesDownloaded, |
There was a problem hiding this comment.
🟢 Low — The bytes_downloaded fallback changed from download.bytesTotal to download.bytesDownloaded, but the line below still forces progress: 100 for a reconciled completed task. A task result lacking bytes_downloaded therefore produces an internally inconsistent row: 100% progress next to the stale partial byte count (e.g. 200 of 1000) from the last WS message. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.54 #19791 +/- ##
=============================================
+ Coverage 84.18% 84.34% +0.15%
=============================================
Files 2113 2113
Lines 126811 126927 +116
Branches 32245 34150 +1905
=============================================
+ Hits 106758 107056 +298
+ Misses 19867 19683 -184
- Partials 186 188 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backports #19281 (adds user cancellation for queued and running asset downloads) to
core/1.54after the automated cherry-pick conflicted. The browser spec and snapshots follow their release-branch directory, obsolete execution types stay removed, and download/export websocket schemas gain thecancelledterminal state. It also carries the validated release fixes from the cloud/1.55 carrier: compatible telemetry, bounded cancellation reconciliation, and cancelled export rendering.Validation:
pnpm typecheck:apppnpm typecheck:browserOriginal merge:
c1d9a51466a16987e802ebb3682f19211ed744b5.