Repository navigation
[backport core/1.54] fix: harden task cancellation reconciliation (#20031) - #20048
Conversation
- bound cancelled-task reconciliation and validate task statuses/results before restoring state - keep download/export cancellation rendering and close behavior consistent while polling is in flight - stop upload-wizard watchers when their owning scope is disposed - preserve export download URL behavior while adding regression coverage for malformed, mixed-shape, cancelled, and stale task responses This lands the hardening identified during the final review of #19858 (the `core/1.55` backport of #19281) on `main` first so release branches can consume it through normal backports. - `pnpm vitest run src/stores/assetDownloadStore.test.ts src/stores/assetExportStore.test.ts src/platform/tasks/services/taskService.test.ts src/platform/assets/components/ModelImportProgressDialog.test.ts src/platform/assets/components/AssetExportProgressDialog.test.ts src/platform/assets/composables/useUploadModelWizard.test.ts` (85 passed, 1 expected failure) - `pnpm typecheck:app` - `pnpm typecheck:browser` - targeted `oxfmt --check` - pre-push `knip` and changed-file `fallow audit`
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1980 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-03T23:34:21.171Z",
"gitSha": "79c631543665bee32f20a96828e052512aec8bd9",
"branch": "backport-20031-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2061.0490000000254,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.286,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 574.3960000000001,
"heapDeltaBytes": -5855776,
"heapUsedBytes": 67305488,
"domNodes": -283,
"jsHeapTotalBytes": 3969024,
"scriptDurationMs": 12.954,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2054.8129999999674,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.267000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.068,
"heapDeltaBytes": 2785960,
"heapUsedBytes": 73598464,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 12.175000000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2272.416000000021,
"styleRecalcs": 83,
"styleRecalcDurationMs": 41.063,
"layouts": 14,
"layoutDurationMs": 4.460000000000001,
"taskDurationMs": 1169.1309999999999,
"heapDeltaBytes": 12015228,
"heapUsedBytes": 82819216,
"domNodes": -281,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 192.469,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1867.0510000000604,
"styleRecalcs": 74,
"styleRecalcDurationMs": 29.115000000000002,
"layouts": 14,
"layoutDurationMs": 3.688,
"taskDurationMs": 910.9509999999999,
"heapDeltaBytes": -4487924,
"heapUsedBytes": 69307632,
"domNodes": -281,
"jsHeapTotalBytes": 3969024,
"scriptDurationMs": 164.048,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.2220000000116,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.139000000000003,
"layouts": 6,
"layoutDurationMs": 1.1100000000000003,
"taskDurationMs": 361.32400000000007,
"heapDeltaBytes": 4520624,
"heapUsedBytes": 76134316,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.274,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.9119999999803,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.732,
"layouts": 6,
"layoutDurationMs": 1.1460000000000001,
"taskDurationMs": 374.5249999999999,
"heapDeltaBytes": 4546064,
"heapUsedBytes": 76350096,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.015,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 716.9529999999895,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.544,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.333,
"heapDeltaBytes": -7746292,
"heapUsedBytes": 63211276,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 169.192,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 692.8989999998976,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.176,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.874,
"heapDeltaBytes": -7266628,
"heapUsedBytes": 66733364,
"domNodes": 16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 167.09099999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2016.6389999999978,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.164,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.584,
"heapDeltaBytes": -1454628,
"heapUsedBytes": 76677144,
"domNodes": -271,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 32.412,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2010.0109999999631,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.04,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 583.0809999999999,
"heapDeltaBytes": -10686692,
"heapUsedBytes": 67334964,
"domNodes": -282,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 36.013,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2256.2689999999748,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.699,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1668.994,
"heapDeltaBytes": -1771132,
"heapUsedBytes": 76599072,
"domNodes": -281,
"jsHeapTotalBytes": 385024,
"scriptDurationMs": 830.309,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2303.9669999999433,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.952000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1645.6970000000001,
"heapDeltaBytes": 10740456,
"heapUsedBytes": 88753636,
"domNodes": -281,
"jsHeapTotalBytes": 1171456,
"scriptDurationMs": 835.3389999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3489.7659999999746,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.296000000000001,
"layouts": 60,
"layoutDurationMs": 12.122000000000002,
"taskDurationMs": 1676.456,
"heapDeltaBytes": -595488,
"heapUsedBytes": 67165460,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 795.3730000000002,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3677.9109999999946,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.177,
"layouts": 60,
"layoutDurationMs": 12.651000000000002,
"taskDurationMs": 1773.4870000000003,
"heapDeltaBytes": -5389360,
"heapUsedBytes": 74765476,
"domNodes": -265,
"jsHeapTotalBytes": 3043328,
"scriptDurationMs": 804.1579999999999,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3122.1029999999814,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.563000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1985.643,
"heapDeltaBytes": -13578984,
"heapUsedBytes": 69170292,
"domNodes": 6,
"jsHeapTotalBytes": 5140480,
"scriptDurationMs": 1033.201,
"eventListeners": 188,
"totalBlockingTimeMs": 15,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3079.5100000000275,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.055000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1876.4070000000002,
"heapDeltaBytes": 13654692,
"heapUsedBytes": 81748852,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 953.293,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2027.8579999999806,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.684000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.787,
"heapDeltaBytes": -13748184,
"heapUsedBytes": 66230808,
"domNodes": -285,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 34.114999999999995,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2045.8579999999529,
"styleRecalcs": 6,
"styleRecalcDurationMs": 9.341999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.3600000000001,
"heapDeltaBytes": -10268760,
"heapUsedBytes": 72069832,
"domNodes": -278,
"jsHeapTotalBytes": -1273856,
"scriptDurationMs": 32.654,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 610.9549999999899,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.457,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.13500000000005,
"heapDeltaBytes": 14815916,
"heapUsedBytes": 87960768,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 142.738,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 605.6979999999612,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.629999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.24899999999997,
"heapDeltaBytes": 14032420,
"heapUsedBytes": 89970872,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 146.447,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.154999999998,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.358000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.045,
"heapDeltaBytes": -10255520,
"heapUsedBytes": 62858220,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.241,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2017.9709999999886,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.617999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.99500000000006,
"heapDeltaBytes": -15404716,
"heapUsedBytes": 57227236,
"domNodes": -299,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.896,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1736.6389999999683,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.531,
"layouts": 18,
"layoutDurationMs": 4.585000000000001,
"taskDurationMs": 835.0219999999999,
"heapDeltaBytes": -14627400,
"heapUsedBytes": 58818460,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 112.20899999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1766.6039999999157,
"styleRecalcs": 76,
"styleRecalcDurationMs": 33.318,
"layouts": 18,
"layoutDurationMs": 4.66,
"taskDurationMs": 870.506,
"heapDeltaBytes": -9369208,
"heapUsedBytes": 63406148,
"domNodes": -297,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 116.51400000000001,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.6669999999376,
"styleRecalcs": 19,
"styleRecalcDurationMs": 33.644,
"layouts": 15,
"layoutDurationMs": 16.101,
"taskDurationMs": 992.9749999999997,
"heapDeltaBytes": 22139080,
"heapUsedBytes": 106594684,
"domNodes": 13831,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 30.861000000000008,
"eventListeners": 2385,
"totalBlockingTimeMs": 149,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8337.484000000019,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.138999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5695.1,
"heapDeltaBytes": -9561124,
"heapUsedBytes": 67965628,
"domNodes": -282,
"jsHeapTotalBytes": 3567616,
"scriptDurationMs": 2770.3740000000003,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8367.203999999901,
"styleRecalcs": 248,
"styleRecalcDurationMs": 38.082,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5726.489,
"heapDeltaBytes": 14931460,
"heapUsedBytes": 92999372,
"domNodes": -267,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 2743.95,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17902.92499999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17056.943,
"heapDeltaBytes": -36779976,
"heapUsedBytes": 181927896,
"domNodes": -8098,
"jsHeapTotalBytes": -8138752,
"scriptDurationMs": 314.5,
"eventListeners": -14987,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17462.85599999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16890.446,
"heapDeltaBytes": -39765948,
"heapUsedBytes": 178843212,
"domNodes": -8068,
"jsHeapTotalBytes": -9449472,
"scriptDurationMs": 282.12199999999996,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21607.304999999997,
"styleRecalcs": 168,
"styleRecalcDurationMs": 19.955999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21270.416,
"heapDeltaBytes": -43672472,
"heapUsedBytes": 180362640,
"domNodes": -8068,
"jsHeapTotalBytes": -15007744,
"scriptDurationMs": 1003.716,
"eventListeners": -14929,
"totalBlockingTimeMs": 74,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20982.083999999988,
"styleRecalcs": 173,
"styleRecalcDurationMs": 16.97399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20621.532000000003,
"heapDeltaBytes": -56087024,
"heapUsedBytes": 166807740,
"domNodes": -8068,
"jsHeapTotalBytes": -16261120,
"scriptDurationMs": 958.696,
"eventListeners": -14929,
"totalBlockingTimeMs": 99,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6275.462999999945,
"styleRecalcs": 20,
"styleRecalcDurationMs": 95.56900000000002,
"layouts": 20,
"layoutDurationMs": 35.13899999999999,
"taskDurationMs": 6213.609999999999,
"heapDeltaBytes": -43659576,
"heapUsedBytes": 179160488,
"domNodes": -8068,
"jsHeapTotalBytes": 7098368,
"scriptDurationMs": 153.68300000000002,
"eventListeners": -14929,
"totalBlockingTimeMs": 423,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6235.722999999894,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.19999999999999,
"layouts": 20,
"layoutDurationMs": 23.032999999999998,
"taskDurationMs": 6093.308,
"heapDeltaBytes": -40690404,
"heapUsedBytes": 178129132,
"domNodes": -8068,
"jsHeapTotalBytes": 10428416,
"scriptDurationMs": 129.318,
"eventListeners": -14931,
"totalBlockingTimeMs": 422,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8898.415,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8523.628999999999,
"heapDeltaBytes": 14841172,
"heapUsedBytes": 177581284,
"domNodes": 0,
"jsHeapTotalBytes": -16777216,
"scriptDurationMs": 174.06199999999993,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8904.295999999931,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8512.915,
"heapDeltaBytes": 7337396,
"heapUsedBytes": 178820012,
"domNodes": 0,
"jsHeapTotalBytes": -7602176,
"scriptDurationMs": 143.09700000000004,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 111.23799999995754,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.476000000000003,
"layouts": 2,
"layoutDurationMs": 0.689,
"taskDurationMs": 79.637,
"heapDeltaBytes": 2985568,
"heapUsedBytes": 72217036,
"domNodes": 108,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.92,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 90.87799999997515,
"styleRecalcs": 6,
"styleRecalcDurationMs": 12.908999999999999,
"layouts": 2,
"layoutDurationMs": 0.9810000000000001,
"taskDurationMs": 63.22300000000001,
"heapDeltaBytes": 2965396,
"heapUsedBytes": 72706348,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.602000000000002,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #20048 +/- ##
==========================================
Coverage 84.38% 84.38%
==========================================
Files 2125 2125
Lines 127382 127471 +89
Branches 34325 34352 +27
==========================================
+ Hits 107489 107572 +83
- Misses 19705 19711 +6
Partials 188 188
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 3 |
| 🟡 Medium | 3 |
| 🟢 Low | 3 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
There was a problem hiding this comment.
Verdict: Approve. This backport brings the files #20031 touches on core/1.54 to their content on main after #20031. The only differences are this branch's WebSocket type location and reportError options.
I compared against #20031's merge commit d23d7802f5680f647a10d3620b61f63a7800ab01. core/1.54 already carried #19281 through #19791 (7bbe053df7), which also included part of the follow-up hardening (the opaque task result, the cancelled export row, and the export store changes). So the per-hunk delta here is smaller than the source diff. I checked the end state instead: at this head, each file #20031 touches matches main after #20031, apart from the two adaptations below. AssetExportProgressDialog.vue/.test.ts and taskService.ts already matched through #19791, so this PR leaves them alone.
Adaptations, each accounted for by core/1.54:
AssetDownloadWsMessageandAssetExportWsMessageare imported from@/schemas/apiSchema, becausesrc/platform/remote/comfyui/execution/types.tsdoes not exist on this branch. The source's widening ofAssetExportWsMessage.statusto includecancelledis not needed, becausezAssetExportWsMessagehere already acceptscancelled.ModelImportProgressDialog.vueand its test keeptags: { surface: 'assets' }, becauseReportErrorOptionsoncore/1.54has nosurfacefield.- The remaining lines that go beyond the source hunks (mock declaration style in
useUploadModelWizard.test.ts, comment wording and a test name inassetDownloadStore.test.ts, the Close-button assertions and the superseded reconciliation code from #19791) are where #19791's earlier carrier differed frommain. Resolving them tomain's content is the right conflict resolution.
Checks: the six touched and adjacent Vitest files pass locally at this head (93 passed, 1 expected failure). vue-tsc --noEmit and pnpm typecheck:browser pass. Hosted CI at 1ef3e01 passes lint-and-format, test and e2e-status. The only non-green runs are the two cancelled pr-risk jobs, which are not required.
## Summary Follow-up to #20031 and its release backports. This closes the post-merge review gaps by: - tombstoning dismissed pending downloads so late WebSocket frames cannot reopen the toast, while still refreshing model caches after a hidden completion - settling malformed authoritative completions instead of polling forever - confirming DELETE 404 outcomes without falsely presenting a still-running task as cancelled - bounding task-not-found reconciliation and stopping unconfirmed cancellation polling - preserving late export names, validating export URL schemes, and retrying transient export 404s - preventing async upload watchers from outliving reset/disposal ## Validation - Targeted Vitest: 74 passed, 1 expected failure - App typecheck - Targeted lint: 0 errors - Diff whitespace check Closes the actionable review findings raised on #20044, #20047, #20048, and #20049.
Backports #20031 to
core/1.54.This adapts the canonical cancellation hardening to the branch's existing validated WebSocket schemas. It adds bounded and serialized reconciliation, terminal-state preservation, dismissible unconfirmed cancellations, upload-watcher isolation, and regression coverage.
Validation:
pnpm typecheck:app