Repository navigation
FE-2900 fix(cloud): a workspace token never outlives the scope it was minted for - #19755
Conversation
workspaceToken(scope) checks the captured scope once the mint resolves: no session fails NO_SESSION, a moved identity epoch fails IDENTITY_CHANGED. The session token mint reports NO_SESSION instead of IDENTITY_CHANGED when the session ended while it was in flight.
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 6f723d2c8414360faad5072829cd5bd54ea652f2
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
🎭 Playwright: ✅ 2184 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 10.1 MB gzip 🔴 +426 kBDetailsSummary
Category Glance App Entry Points — 3.89 kB (baseline 3.73 kB) • 🔴 +154 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.47 MB (baseline 1.43 MB) • 🔴 +41.7 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 135 kB (baseline 124 kB) • 🔴 +10.9 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 645 kB (baseline 621 kB) • 🔴 +23.6 kBConfiguration panels, inspectors, and settings screens
Status: 28 added / 27 removed User & Accounts — 53.6 kB (baseline 27.8 kB) • 🔴 +25.8 kBAuthentication, profile, and account management bundles
Status: 14 added / 10 removed / 1 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +648 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 184 kB (baseline 117 kB) • 🔴 +67.1 kBReusable component library chunks
Status: 18 added / 15 removed Data & Services — 4.11 MB (baseline 3.6 MB) • 🔴 +511 kBStores, services, APIs, and repositories
Status: 14 added / 16 removed Utilities & Hooks — 586 kB (baseline 559 kB) • 🔴 +26.9 kBHelpers, composables, and utility bundles
Status: 33 added / 31 removed / 5 unchanged Vendor & Third-Party — 17.2 MB (baseline 18.1 MB) • 🟢 -866 kBExternal libraries and shared vendor chunks
Status: 14 added / 14 removed / 4 unchanged Other — 18.3 MB (baseline 16.4 MB) • 🔴 +1.89 MBBundles that do not match a named category
Status: 184 added / 175 removed / 121 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-01T13:37:10.142Z",
"gitSha": "496b6a38696fd17b4e46cfdebd33fea973d69b6e",
"branch": "dante01yoon/fe-2900-f9-workspace-token-scope",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.224000000041,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.5860000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.74000000000007,
"heapDeltaBytes": 22314724,
"heapUsedBytes": 75904460,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.904999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2023.4850000000506,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.8190000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.573,
"heapDeltaBytes": 22278544,
"heapUsedBytes": 75880208,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.042999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1781.7340000000286,
"styleRecalcs": 52,
"styleRecalcDurationMs": 17.116,
"layouts": 12,
"layoutDurationMs": 4.991,
"taskDurationMs": 814.768,
"heapDeltaBytes": 19463000,
"heapUsedBytes": 73040980,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 156.056,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66542056074767,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1813.6650000000145,
"styleRecalcs": 76,
"styleRecalcDurationMs": 19.417,
"layouts": 12,
"layoutDurationMs": 4.688,
"taskDurationMs": 783.848,
"heapDeltaBytes": 19492260,
"heapUsedBytes": 73145740,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 151.393,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666972477064228,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.8019999999638,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.186,
"layouts": 6,
"layoutDurationMs": 1.153,
"taskDurationMs": 366.47799999999995,
"heapDeltaBytes": 3490988,
"heapUsedBytes": 69407088,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.020999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.7960000000594,
"styleRecalcs": 34,
"styleRecalcDurationMs": 9.965,
"layouts": 6,
"layoutDurationMs": 1.2290000000000003,
"taskDurationMs": 356.43800000000005,
"heapDeltaBytes": 25313608,
"heapUsedBytes": 78699076,
"domNodes": -177,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.957,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 730.039999999974,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.835000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.87600000000003,
"heapDeltaBytes": 14550048,
"heapUsedBytes": 67583548,
"domNodes": -232,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 159.78799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66744186046511,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 745.1609999999391,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.9909999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.284,
"heapDeltaBytes": 15217300,
"heapUsedBytes": 74582704,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.123,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909075,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1146.8130000000087,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 835.491,
"heapDeltaBytes": 15442372,
"heapUsedBytes": 83780728,
"domNodes": 0,
"jsHeapTotalBytes": 6717440,
"scriptDurationMs": 60.628000000000014,
"eventListeners": 0,
"totalBlockingTimeMs": 525,
"frameDurationMs": 34.84545454545454,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1156.099999999924,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 816.243,
"heapDeltaBytes": 15122620,
"heapUsedBytes": 92737992,
"domNodes": 0,
"jsHeapTotalBytes": 6979584,
"scriptDurationMs": 58.644,
"eventListeners": 0,
"totalBlockingTimeMs": 516,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 880.0029999999879,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.0779999999998,
"heapDeltaBytes": 18195476,
"heapUsedBytes": 120894892,
"domNodes": 0,
"jsHeapTotalBytes": 2887680,
"scriptDurationMs": 154.45199999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 25.23999999999999,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.6090000000204,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.92599999999976,
"heapDeltaBytes": 17642412,
"heapUsedBytes": 104206292,
"domNodes": 0,
"jsHeapTotalBytes": 1052672,
"scriptDurationMs": 149.104,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9542.081000000053,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8626.122000000001,
"heapDeltaBytes": 5876072,
"heapUsedBytes": 82235216,
"domNodes": -142,
"jsHeapTotalBytes": -4853760,
"scriptDurationMs": 6915.154,
"eventListeners": -78,
"totalBlockingTimeMs": 350,
"frameDurationMs": 30.35987261146497,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8577.383999999938,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7767.585999999999,
"heapDeltaBytes": 11277668,
"heapUsedBytes": 92245188,
"domNodes": 0,
"jsHeapTotalBytes": -11534336,
"scriptDurationMs": 6400.179999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 244,
"frameDurationMs": 31.26386861313869,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9197.09499999999,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.8290000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8311.471999999998,
"heapDeltaBytes": 10937504,
"heapUsedBytes": 85936416,
"domNodes": -142,
"jsHeapTotalBytes": -7213056,
"scriptDurationMs": 6640.44,
"eventListeners": -74,
"totalBlockingTimeMs": 184,
"frameDurationMs": 29.52700964630225,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9171.501000000035,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.4940000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8317.698,
"heapDeltaBytes": 4410596,
"heapUsedBytes": 81467372,
"domNodes": -143,
"jsHeapTotalBytes": -6688768,
"scriptDurationMs": 6616.584000000001,
"eventListeners": -82,
"totalBlockingTimeMs": 281,
"frameDurationMs": 29.955228758169934,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2012.5700000000393,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.738000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 629.926,
"heapDeltaBytes": 2319076,
"heapUsedBytes": 85799224,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 44.143,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.1059999999998,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.6760000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 628.2010000000001,
"heapDeltaBytes": -40542740,
"heapUsedBytes": 82822220,
"domNodes": -328,
"jsHeapTotalBytes": -3768320,
"scriptDurationMs": 33.789,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2255.901999999992,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.647,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1589.301,
"heapDeltaBytes": 22111876,
"heapUsedBytes": 85243412,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 770.761,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665925925925922,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2337.5389999999925,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.540999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1603.4939999999997,
"heapDeltaBytes": 20710816,
"heapUsedBytes": 83498548,
"domNodes": -328,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 771.318,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665467625899282,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3804.251000000022,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.004,
"layouts": 60,
"layoutDurationMs": 18.194,
"taskDurationMs": 1861.112,
"heapDeltaBytes": -11773020,
"heapUsedBytes": 76942424,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 843.8140000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.888444444444445,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3870.064999999954,
"styleRecalcs": 66,
"styleRecalcDurationMs": 14.003000000000002,
"layouts": 60,
"layoutDurationMs": 15.924999999999999,
"taskDurationMs": 1804.24,
"heapDeltaBytes": -11418220,
"heapUsedBytes": 68306072,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 825.837,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665665236051503,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3161.056999999971,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.643,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1969.4189999999999,
"heapDeltaBytes": 23102164,
"heapUsedBytes": 87824700,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 995.361,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75531914893617,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3140.502999999967,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.5059999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1988.2470000000003,
"heapDeltaBytes": 4795904,
"heapUsedBytes": 92068764,
"domNodes": 0,
"jsHeapTotalBytes": 1765376,
"scriptDurationMs": 1007.926,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755080213903746,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2058.1359999999904,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.626,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 675.0970000000001,
"heapDeltaBytes": -41159152,
"heapUsedBytes": 83482388,
"domNodes": -328,
"jsHeapTotalBytes": -1671168,
"scriptDurationMs": 37.407999999999994,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2007.154000000014,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.2090000000000019,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.88,
"heapDeltaBytes": 20682288,
"heapUsedBytes": 84138324,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.695,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 623.7649999999917,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.323000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.106,
"heapDeltaBytes": 10523720,
"heapUsedBytes": 73413088,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 146.817,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66216216216216,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 624.8819999999569,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.418000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.05199999999996,
"heapDeltaBytes": 9581188,
"heapUsedBytes": 63132852,
"domNodes": -250,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 146.646,
"eventListeners": -204,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2015.5619999999885,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.0529999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.574,
"heapDeltaBytes": 419556,
"heapUsedBytes": 69311304,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.503000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.2830000000295,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.1880000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.02700000000004,
"heapDeltaBytes": 21973348,
"heapUsedBytes": 75359036,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.845999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1720.22800000002,
"styleRecalcs": 78,
"styleRecalcDurationMs": 18.854000000000003,
"layouts": 16,
"layoutDurationMs": 5.816,
"taskDurationMs": 766.317,
"heapDeltaBytes": -6487976,
"heapUsedBytes": 62749072,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 114.82699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66699029126214,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1747.6110000000062,
"styleRecalcs": 79,
"styleRecalcDurationMs": 20.322,
"layouts": 16,
"layoutDurationMs": 6.595,
"taskDurationMs": 792.2010000000001,
"heapDeltaBytes": -36640584,
"heapUsedBytes": 67980460,
"domNodes": -250,
"jsHeapTotalBytes": -3670016,
"scriptDurationMs": 112.402,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1419.7040000000243,
"styleRecalcs": 15,
"styleRecalcDurationMs": 29.048,
"layouts": 5,
"layoutDurationMs": 12.328,
"taskDurationMs": 976.1339999999998,
"heapDeltaBytes": 23930700,
"heapUsedBytes": 110098868,
"domNodes": 13747,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 30.24299999999999,
"eventListeners": 2383,
"totalBlockingTimeMs": 140,
"frameDurationMs": 19.908333333333328,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8509.212999999989,
"styleRecalcs": 251,
"styleRecalcDurationMs": 40.101,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5850.244,
"heapDeltaBytes": -8036424,
"heapUsedBytes": 78437292,
"domNodes": -143,
"jsHeapTotalBytes": -9605120,
"scriptDurationMs": 2687.8199999999997,
"eventListeners": -82,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698821218074656,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8727.259000000004,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.12800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6017.038,
"heapDeltaBytes": -3993456,
"heapUsedBytes": 82602316,
"domNodes": -143,
"jsHeapTotalBytes": -10391552,
"scriptDurationMs": 2783.515,
"eventListeners": -82,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665774378585084,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17558.34900000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16868.791,
"heapDeltaBytes": -45170984,
"heapUsedBytes": 163423604,
"domNodes": -3045,
"jsHeapTotalBytes": 6311936,
"scriptDurationMs": 284.269,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.92186948853615,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 18022.182000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17343.869,
"heapDeltaBytes": -29430584,
"heapUsedBytes": 176992148,
"domNodes": -3045,
"jsHeapTotalBytes": 10231808,
"scriptDurationMs": 287.22400000000005,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.800706713780915,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 21773.732999999993,
"styleRecalcs": 170,
"styleRecalcDurationMs": 22.804999999999964,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21421.01,
"heapDeltaBytes": -19104416,
"heapUsedBytes": 191323208,
"domNodes": -3045,
"jsHeapTotalBytes": 6307840,
"scriptDurationMs": 866.521,
"eventListeners": -14915,
"totalBlockingTimeMs": 66,
"frameDurationMs": 40.71476635514019,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 21390.84300000002,
"styleRecalcs": 171,
"styleRecalcDurationMs": 20.614000000000022,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21067.328,
"heapDeltaBytes": -20115504,
"heapUsedBytes": 179358100,
"domNodes": -3045,
"jsHeapTotalBytes": 8134656,
"scriptDurationMs": 851.932,
"eventListeners": -14915,
"totalBlockingTimeMs": 46,
"frameDurationMs": 39.77546468401487,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6631.034,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.17699999999999,
"layouts": 20,
"layoutDurationMs": 26.565000000000005,
"taskDurationMs": 6533.664000000001,
"heapDeltaBytes": 17947464,
"heapUsedBytes": 225856100,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 122.39500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.850555555555545,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6438.78600000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.41399999999999,
"layouts": 20,
"layoutDurationMs": 27.560000000000002,
"taskDurationMs": 6311.610999999999,
"heapDeltaBytes": 211412,
"heapUsedBytes": 202466896,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 118.628,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.84176470588237,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9135.076000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8834.885999999999,
"heapDeltaBytes": -23732844,
"heapUsedBytes": 180966296,
"domNodes": -3045,
"jsHeapTotalBytes": 5685248,
"scriptDurationMs": 149.71,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.09964788732394,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8733.336000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8396.243,
"heapDeltaBytes": -42709944,
"heapUsedBytes": 189832540,
"domNodes": -3046,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 136.925,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.603389830508476,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "workflow-execution",
"durationMs": 135.7189999999946,
"styleRecalcs": 11,
"styleRecalcDurationMs": 21.557,
"layouts": 5,
"layoutDurationMs": 2.9040000000000004,
"taskDurationMs": 109.87799999999997,
"heapDeltaBytes": 4146124,
"heapUsedBytes": 57492768,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.274,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 462.4659999999494,
"styleRecalcs": 12,
"styleRecalcDurationMs": 12.025,
"layouts": 3,
"layoutDurationMs": 0.8369999999999999,
"taskDurationMs": 102.22899999999998,
"heapDeltaBytes": 5512856,
"heapUsedBytes": 69644440,
"domNodes": 99,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.953999999999997,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285717,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 812.3679999999922,
"styleRecalcs": 78,
"styleRecalcDurationMs": 105.619,
"layouts": 76,
"layoutDurationMs": 25.399,
"taskDurationMs": 782.712,
"heapDeltaBytes": 17158084,
"heapUsedBytes": 85350332,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 304.236,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667346938775506,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 922.6360000000113,
"styleRecalcs": 78,
"styleRecalcDurationMs": 110.675,
"layouts": 76,
"layoutDurationMs": 26.911,
"taskDurationMs": 888.563,
"heapDeltaBytes": 18211152,
"heapUsedBytes": 87259324,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 361.308,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66545454545455,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1397.4279999999908,
"styleRecalcs": 78,
"styleRecalcDurationMs": 276.144,
"layouts": 76,
"layoutDurationMs": 30.038,
"taskDurationMs": 1369.038,
"heapDeltaBytes": -19042324,
"heapUsedBytes": 109266440,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 439.94,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.5,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1380.9870000000046,
"styleRecalcs": 78,
"styleRecalcDurationMs": 275.981,
"layouts": 76,
"layoutDurationMs": 29.47,
"taskDurationMs": 1363.715,
"heapDeltaBytes": -19271104,
"heapUsedBytes": 109320740,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 436.411,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.73333333333334,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (3)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughMint completion and workspace-token requests now distinguish a missing session from an identity change. Tests cover session changes during pending mint requests and stale workspace-token request scopes. ChangesSession token race handling
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change rejects tokens after sign-out or account changes while preserving same-user refresh behavior. No merge-blocking issue was identified; merge after normal checks pass. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change strengthens account isolation by refusing token results for an expired identity scope. No introduced authorization bypass was observed. Confidence remains bounded by static inspection: the separate resource-header path is unchanged and does not receive the same scope validation. Retained concerns Security review detailsSecurity Blast Radius
Security Findings and Attack Paths
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The PR uses bug-fix language in the title: “fix(cloud)”. It changes application files under
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #19755 +/- ##
=========================================
Coverage 84.71% 84.71%
=========================================
Files 3397 3397
Lines 163004 163014 +10
Branches 42486 44415 +1929
=========================================
+ Hits 138084 138093 +9
- Misses 22996 22997 +1
Partials 1924 1924
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Verified at cffdccc997c30d3122220c27bc1ba1892cbdc171.
- A delayed mint can no longer return a token after sign-out or an account-epoch change.
- The same-user session reread remains valid, while account changes fail closed.
- Exact-head CI is settled green and all review threads are resolved.
Full context for agent readers
The token-mint primitive now distinguishes a missing session from a changed identity before committing a result. The Cloud adapter additionally compares the request scope's captured identity epoch after mint completion, which closes the switch-away-and-back race without changing tab-local workspace selection.
…e a password change (Comfy-Org#19759) ## Why With `unified_web_session` on, a Cloud tab can be signed in on the web session alone, with no Firebase login on cloud.comfy.org (Comfy-Org#19615). Changing the password still goes through the Firebase SDK, which needs a Firebase user on this origin. TDD §18 says a user who reached a site by session only has to sign in there once for such actions. Today, on that tab: - the Update Password control is hidden, because `isEmailProvider` reads only the Firebase user; - if the dialog is reached some other way, `authStore.updatePassword` throws `userNotAuthenticated`. Update Password is the only user-triggered action in the app that needs a Firebase user. The rest were checked: - password reset and sign-out already work without one; - there is no profile, photo or email-verification action; - account deletion is a "contact support" line; - invite accept is a request rail, F1. ## Root cause - `useCurrentUser.isEmailProvider` only reads the Firebase user's `providerData`, so a session-only tab never sees the control. - Nothing tells the panel that the tab lacks the Firebase login a password change needs. ## How - **`useCurrentUser`** - New `needsFirebaseSignIn`: true when a session user exists but no matching Firebase user. - `isEmailProvider` falls back to the session's `signInProvider` only when no matching Firebase user exists. With a Firebase user it is unchanged. - **`UserPanel`** - Clicking Update Password on a session-only tab opens the existing "Re-authentication Required" confirm. On confirm, the tab goes to `cloud-login` with `switchAccount=true` and `previousFullPath`, the same query the router already uses to send a session-only tab to Firebase sign-in, so the user returns to the same page. - It uses a full page load, like `logout()`, so the open Settings dialog doesn't stay on top. - Declining does nothing. - The icon-only button gains an `aria-label`. - No new i18n strings. Flag off is unchanged: `sessionUser` is undefined, so `needsFirebaseSignIn` is always false. **Open for review** - The prompt reuses `auth.reauthRequired.title`/`message`, and `confirm()` labels the button "Confirm". A dedicated "Sign in again to continue" string plus a "Sign In Again" button would need a small `confirm()` option. - The full page load relies on draft persistence for unsaved workflow edits. It doesn't apply the logout flow's unsaved-changes confirm. - On session-only tabs the avatar stays hidden: the session contract has no photo field, which would be a backend addition. ## Tests - **`UserPanel.test.ts` (new)**: - with a Firebase login, the button opens the password dialog; - on a session-only tab, it prompts, then navigates to `/cloud/login?switchAccount=true&previousFullPath=…`; - declining doesn't navigate. - **`useCurrentUser.test.ts`**: a table of session-only email, session-only Google, a session with a different Firebase user, a session with its own Firebase user, and Firebase-only rows. - **`webSessionFlagOff.test.ts`**: with the flag off, `needsFirebaseSignIn` is always false and `isEmailProvider` is unchanged, with `unified_cloud_auth` off and on. - **Mutation check**: 10 mutants were applied to the gate, decline, query params, the provider fallback and the label. All were caught. ## AS IS / TO BE AS IS (session-only tab, no Firebase login): Settings > User <img width="600" alt="AS IS User panel without the Update Password button" src="https://github.com/user-attachments/assets/67dd13f6-0f50-4370-8305-c8f2b18b5504" /> The provider reads "password" but there is no Update Password pen button. TO BE (same tab and account): Settings > User, then the pen button <img width="600" alt="TO BE User panel with the Update Password button" src="https://github.com/user-attachments/assets/b8fb5f87-1d34-469d-8497-a8be90acf6ec" /> <img width="600" alt="TO BE Re-authentication Required confirm" src="https://github.com/user-attachments/assets/27b0b156-0482-4438-8d32-b619a31778f2" /> The pen button is shown; clicking it opens the "Re-authentication Required" confirm. The session reports `sign_in_provider: "password"`. ## Plan position | Slice | Ticket | PR | Status | |---|---|---|---| | F2 session-first boot | FE-3104 | Comfy-Org#19615 | merged | | F2b billing on session-only tabs | FE-2900 | Comfy-Org#19753 | in review | | F2c billing SDK rails on the session | FE-2900 | Comfy-Org#19757 | in review | | F9 workspace token scope check | FE-2900 | Comfy-Org#19755 | in review | | **Sign in again for Firebase-only actions** | **FE-3104 follow-up** | **this PR** | **in review** | | F1 `acceptInvite` on the session | FE-3079 follow-up | — | backend-gated | ```mermaid graph LR F2["FE-3104 boot (Comfy-Org#19615) merged"] --> F2b["F2b billing (Comfy-Org#19753)"] F2b --> F2c["F2c billing SDK (Comfy-Org#19757)"] F2 --> F9["F9 scope (Comfy-Org#19755)"] F2 --> RA["sign in again (this PR)"] F2 --> F1["F1 acceptInvite (BE-gated)"] style RA fill:#f9d71c,stroke:Comfy-Org#333,stroke-width:2px ```
…on (Comfy-Org#19757) ## Why With `unified_web_session` on, a Cloud tab can be signed in on the web session with no Firebase login (Comfy-Org#19615). The billing SDK rails (`billing_sdk_topup_rail`, `billing_sdk_subscription_rail`) don't work on that tab: every billing read and top-up returns `NOT_AUTHENTICATED`. This is slice F2c, which follows F2b (Comfy-Org#19753). ## Root cause `billingSdkStore` always builds the SDK on `workspaceAuthStore.getUnifiedSessionClient()`, the Cloud JWT client minted from the Firebase ID token. The SDK's scope also comes from the token that client last minted. On a session-only tab there is no Firebase user, so that client never mints. As a result there is no scope and no token. ## How - **`webSessionBillingSession.ts` (new):** a `BillingSession` and `BillingScopeSource` for a tab signed in on the web session. - **Scope:** the session user plus the selected workspace (`workspaceAuthStore.currentWorkspace`). Both are known before anything is minted, so the first billing read after the store is created doesn't fail. - **Tokens:** `ensureFresh` and `remint` go through the existing session mint (`WebSessionRequests.workspaceToken` / `remintWorkspaceToken`). There is no second token cache. Mint failures map onto the SDK's session error codes. `IDENTITY_CHANGED` drops the request, the same way the Firebase path handles a user change. - **`billingSdkStore`:** uses this adapter when `webSessionRequests()` is set. Otherwise the code path is exactly as before. - **`createBillingSdk`:** takes an optional `scopeSource`. Without it, the existing default applies. - **account-core `createSessionTokenMint`:** gains `remint(workspaceId?)`. It skips the cached token for that workspace and joins a mint already in flight. It is used once on a 401. Backend: billing routes (`ProtectedSession`, which includes `AllowCloudJWT`) accept the session-minted Cloud JWT. Owner-only routes keep the same rule as on the Firebase path. ## Tests - **`webSessionFlagOn.test.ts`**, new describe "billing SDK rails on a tab that arrived by session", with `currentUser === null`: - reads in the personal and the team workspace send `Bearer session-jwt-1`; - a top-up and every other billing call carry the session token; - a 401 triggers exactly one re-mint and one retry (`session-jwt-1`, then `session-jwt-2`); - after a workspace switch, the next call is minted for, and authorized with, the new workspace. - **`webSessionFlagOff.test.ts`**: with `unified_web_session` absent and with it false, billing goes out on the Firebase-minted `Bearer cloud-jwt-N`, and a 401 re-mints once through Firebase. - **account-core**: `remint` replaces the cached token and keeps the other workspaces' tokens; concurrent remints share one request. - **Mutation check**: seven mutants all fail at least one row each: inverted seam, cached remint, ignored scope source, workspace-pinned scope, and others. ## AS IS / TO BE AS IS (session-only tab, SDK rail flags forced on): Plan & Credits, then top-up <img width="600" alt="AS IS Plan & Credits" src="https://github.com/user-attachments/assets/8acade84-9cde-4cf4-9be8-421f6cef0066" /> <img width="600" alt="AS IS top-up" src="https://github.com/user-attachments/assets/11b16205-9c64-4004-8618-ee13a3d8cc76" /> No `/api/billing/*` request is sent: the billing context fails with `NOT_AUTHENTICATED` before any request goes out, with no `Bearer`; Plan & Credits shows "We couldn't load your plan details". TO BE (same tab and account): Plan & Credits, then top-up <img width="600" alt="TO BE Plan & Credits" src="https://github.com/user-attachments/assets/5b81b097-0baf-47c6-b110-3e371ee34af4" /> <img width="600" alt="TO BE top-up" src="https://github.com/user-attachments/assets/4558ced7-d5df-4f83-ba0b-26c33952f547" /> `POST /api/auth/token` returns 200, then `/api/billing/status`, `/balance` and `/plans` return 200 on a `Bearer` session token; Plan & Credits shows the Free plan and a balance of 0. A "User not authenticated" toast still appears from the legacy subscription refresh, and the top-up dialog did not open. ## Plan position | Slice | Ticket | PR | Status | |---|---|---|---| | F2 session-first boot | FE-3104 | Comfy-Org#19615 | merged | | F2b billing on session-only tabs | FE-2900 | Comfy-Org#19753 | in review | | **F2c billing SDK rails on the session** | **FE-2900** | **this PR** | **in review** | | F9 workspace token scope check | FE-2900 | Comfy-Org#19755 | in review | | F1 `acceptInvite` on the session | FE-3079 follow-up | — | backend-gated | ```mermaid graph LR F2["FE-3104 boot (Comfy-Org#19615) merged"] --> F2b["F2b billing (Comfy-Org#19753)"] F2b --> F2c["F2c billing SDK rails (this PR)"] F2 --> F9["F9 workspaceToken scope (Comfy-Org#19755)"] F2 --> F1["F1 acceptInvite (BE-gated)"] style F2c fill:#f9d71c,stroke:Comfy-Org#333,stroke-width:2px ``` F9 (Comfy-Org#19755) also touches `sessionTokenMint.ts`, in a different function. Whichever lands second merges main. Part of FE-2900.
Why
With
unified_web_sessionon, a Run token comes fromworkspaceToken(scope). The caller captures the scope, which is the session and its identity epoch, before the mint starts. Two things go wrong when the account changes while the mint is in flight:Root cause
cloudWebSessionStoreimplemented the port asworkspaceToken: ({ workspaceId }) => mint.mint(workspaceId). It dropped the capturedepoch, so these cases returned a token:createSessionTokenMintdecided the result withgetSession()?.user.id !== userId. That check is also true when the session is gone, so a sign-out was reported asIDENTITY_CHANGED.How
workspaceToken(scope)checks the scope once the mint resolves:NO_SESSION;identity.getEpoch() !== scope.epoch→IDENTITY_CHANGED;It reuses the existing identity epoch, which moves on every account change, and adds no new counter.
The session token mint returns
NO_SESSIONwhen the session ended while the mint was in flight, and still returnsIDENTITY_CHANGEDwhen another user holds the session.Both codes are in
LIFECYCLE_RACES, so neither is reported as an error.Flag-off is unchanged: the port is only reachable on the web session.
webSessionFlagOff.test.tspasses without edits.Tests
sessionTokenMint.test.ts: a mint that resolves after the session ended →NO_SESSION; after another user took the session →IDENTITY_CHANGED; after the same user re-read it → token.webSessionFlagOn.test.ts:workspaceTokenheld, then a sign-out (NO_SESSION, "session ended") or a user switch (IDENTITY_CHANGED);AS IS / TO BE
This race only shows in a held mint, so it is pinned by the tests above. On screen, the only visible change is the toast text when a sign-out lands during a mint: "Your session changed. Reload to continue." becomes "Your session ended. Sign in again to continue."
Plan position
acceptInviteon the sessionPart of FE-2900.