Repository navigation
FE-3104 feat(cloud): prompt a session-only tab to sign in again before a password change - #19759
Conversation
…word change A tab signed in on the web session alone has no Firebase login, so the password change it needs would fail. The Update Password control now shows for a password session and, on click, asks the user to sign in again on Cloud and returns them to the same page.
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 2e2885b9b0598676620f93de3d6a21e8da5e87fe
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2186 passed, 0 failed📊 Browser Reports
📦 Bundle: 10.1 MB gzipDetailsSummary
Category Glance App Entry Points — 3.89 kBMain entry bundles and manifests
Status: 1 added Graph Workspace — 1.47 MBGraph editor runtime, canvas, workflow orchestration
Status: 3 added Views & Navigation — 135 kBTop-level views, pages, and routed surfaces
Status: 18 added Panels & Settings — 646 kBConfiguration panels, inspectors, and settings screens
Status: 28 added User & Accounts — 53.6 kBAuthentication, profile, and account management bundles
Status: 15 added Editors & Dialogs — 126 kBModals, dialogs, drawers, and in-app editors
Status: 8 added UI Components — 184 kBReusable component library chunks
Status: 18 added Data & Services — 4.11 MBStores, services, APIs, and repositories
Status: 14 added Utilities & Hooks — 586 kBHelpers, composables, and utility bundles
Status: 38 added Vendor & Third-Party — 17.2 MBExternal libraries and shared vendor chunks
Status: 18 added Other — 18.3 MBBundles that do not match a named category
Status: 305 added ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-01T14:01:59.365Z",
"gitSha": "7d21117a42d64abf622ad470f7026634f121fdef",
"branch": "dante01yoon/fe-3104-firebase-only-reauth",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2029.3669999999793,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.8649999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.90599999999995,
"heapDeltaBytes": 22341916,
"heapUsedBytes": 75674640,
"domNodes": -232,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.100999999999999,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2025.1719999999978,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.804,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.7429999999999,
"heapDeltaBytes": 330848,
"heapUsedBytes": 66812628,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.446,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1857.8249999999912,
"styleRecalcs": 75,
"styleRecalcDurationMs": 20.283,
"layouts": 12,
"layoutDurationMs": 4.415,
"taskDurationMs": 906.512,
"heapDeltaBytes": -2979756,
"heapUsedBytes": 63908844,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 178.483,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665765765765762,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1855.6459999999788,
"styleRecalcs": 53,
"styleRecalcDurationMs": 17.932000000000002,
"layouts": 12,
"layoutDurationMs": 4.335999999999999,
"taskDurationMs": 887.894,
"heapDeltaBytes": 19103332,
"heapUsedBytes": 72066496,
"domNodes": -232,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 172.858,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1698.6749999999802,
"styleRecalcs": 30,
"styleRecalcDurationMs": 11.438999999999998,
"layouts": 6,
"layoutDurationMs": 1.371,
"taskDurationMs": 373.115,
"heapDeltaBytes": 3506208,
"heapUsedBytes": 69931284,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.157000000000004,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.361999999981,
"styleRecalcs": 30,
"styleRecalcDurationMs": 12.402000000000001,
"layouts": 6,
"layoutDurationMs": 1.678,
"taskDurationMs": 437.15400000000005,
"heapDeltaBytes": 3494088,
"heapUsedBytes": 69869144,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 17.963999999999995,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6673076923077,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 750.2680000000055,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.282000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.9239999999999,
"heapDeltaBytes": -8356560,
"heapUsedBytes": 58656468,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 184.00699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 755.076000000031,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.988000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.64700000000005,
"heapDeltaBytes": -7286504,
"heapUsedBytes": 59099868,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 180.215,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1216.2660000000187,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 888.319,
"heapDeltaBytes": 13703876,
"heapUsedBytes": 93047196,
"domNodes": 0,
"jsHeapTotalBytes": 6717440,
"scriptDurationMs": 73.569,
"eventListeners": 0,
"totalBlockingTimeMs": 577,
"frameDurationMs": 35.782352941176455,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1310.938999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1019.8520000000002,
"heapDeltaBytes": 15506156,
"heapUsedBytes": 83611720,
"domNodes": 0,
"jsHeapTotalBytes": 7503872,
"scriptDurationMs": 77.552,
"eventListeners": 0,
"totalBlockingTimeMs": 675,
"frameDurationMs": 39.39393939393939,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.6980000000135,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.6700000000002,
"heapDeltaBytes": 15535780,
"heapUsedBytes": 93630756,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 180.41000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 234,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.5429999999069,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.8949999999995,
"heapDeltaBytes": 17700292,
"heapUsedBytes": 104322440,
"domNodes": 0,
"jsHeapTotalBytes": 1052672,
"scriptDurationMs": 162.99400000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10922.98199999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9848.488,
"heapDeltaBytes": 563228,
"heapUsedBytes": 81605720,
"domNodes": 0,
"jsHeapTotalBytes": -12582912,
"scriptDurationMs": 7997.990000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1292,
"frameDurationMs": 32.48869047619048,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11712.62200000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10618.061,
"heapDeltaBytes": 11480296,
"heapUsedBytes": 87569804,
"domNodes": -142,
"jsHeapTotalBytes": -3280896,
"scriptDurationMs": 8731.593,
"eventListeners": -78,
"totalBlockingTimeMs": 1627,
"frameDurationMs": 33.049717514124296,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10763.92999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9786.84,
"heapDeltaBytes": 10552000,
"heapUsedBytes": 91566024,
"domNodes": 0,
"jsHeapTotalBytes": -16252928,
"scriptDurationMs": 8015.264,
"eventListeners": 0,
"totalBlockingTimeMs": 1136,
"frameDurationMs": 31.947477744807124,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11753.401999999936,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10621.44,
"heapDeltaBytes": -8716156,
"heapUsedBytes": 67739564,
"domNodes": -142,
"jsHeapTotalBytes": -7475200,
"scriptDurationMs": 8690.762,
"eventListeners": -78,
"totalBlockingTimeMs": 1447,
"frameDurationMs": 32.501108033240996,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2022.2520000000372,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.0750000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 696.975,
"heapDeltaBytes": 2310456,
"heapUsedBytes": 85377396,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 38.506999999999984,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2020.4029999999875,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.8200000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 695.09,
"heapDeltaBytes": -777304,
"heapUsedBytes": 84826152,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 41.25699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3074.464999999975,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.290000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1855.1009999999999,
"heapDeltaBytes": 4188464,
"heapUsedBytes": 78686196,
"domNodes": 0,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 931.0889999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666304347826088,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 3108.04399999995,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.450000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1821.9640000000002,
"heapDeltaBytes": -36295948,
"heapUsedBytes": 87524140,
"domNodes": -328,
"jsHeapTotalBytes": -2494464,
"scriptDurationMs": 895.594,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576086956522,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3887.085000000013,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.311999999999998,
"layouts": 60,
"layoutDurationMs": 15.331000000000001,
"taskDurationMs": 1842.9650000000001,
"heapDeltaBytes": -11064004,
"heapUsedBytes": 76281380,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 843.7439999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666094420600853,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4022.3219999999174,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.724000000000002,
"layouts": 60,
"layoutDurationMs": 15.917999999999997,
"taskDurationMs": 2009.0020000000002,
"heapDeltaBytes": 10395956,
"heapUsedBytes": 74592096,
"domNodes": -328,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 900.558,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66597510373444,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3199.089000000015,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.394000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2150.499,
"heapDeltaBytes": 26208260,
"heapUsedBytes": 93406400,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 1076.249,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84157894736842,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3220.8409999999503,
"styleRecalcs": 45,
"styleRecalcDurationMs": 7.552,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2274.648,
"heapDeltaBytes": 6278048,
"heapUsedBytes": 87373180,
"domNodes": 0,
"jsHeapTotalBytes": 978944,
"scriptDurationMs": 1141.0880000000002,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.840837696335075,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2020.5209999999738,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 595.401,
"heapDeltaBytes": -583872,
"heapUsedBytes": 86489664,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 42.22200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2020.4569999999649,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.5330000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 712.546,
"heapDeltaBytes": -1537368,
"heapUsedBytes": 77439364,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 41.925000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 638.1150000000275,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.963,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.12000000000006,
"heapDeltaBytes": -11811788,
"heapUsedBytes": 56992068,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 147.299,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 744.4610000000011,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.558000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.50800000000004,
"heapDeltaBytes": -41638508,
"heapUsedBytes": 62830080,
"domNodes": -250,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 150.222,
"eventListeners": -204,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2019.6510000000103,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.2200000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.358,
"heapDeltaBytes": 692504,
"heapUsedBytes": 69076628,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.57499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2050.4190000000335,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.177000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.1049999999999,
"heapDeltaBytes": 21997024,
"heapUsedBytes": 75792616,
"domNodes": -249,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.288999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.8280000000354,
"styleRecalcs": 77,
"styleRecalcDurationMs": 22.17,
"layouts": 16,
"layoutDurationMs": 6.9350000000000005,
"taskDurationMs": 858.313,
"heapDeltaBytes": 16628336,
"heapUsedBytes": 79812680,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 127.89200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1713.310999999976,
"styleRecalcs": 77,
"styleRecalcDurationMs": 21.01,
"layouts": 16,
"layoutDurationMs": 6.502000000000001,
"taskDurationMs": 861.458,
"heapDeltaBytes": -6395448,
"heapUsedBytes": 62859404,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 125.45499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1402.4840000000722,
"styleRecalcs": 16,
"styleRecalcDurationMs": 32.553,
"layouts": 5,
"layoutDurationMs": 14.237000000000004,
"taskDurationMs": 1038.571,
"heapDeltaBytes": 24052804,
"heapUsedBytes": 108268632,
"domNodes": 13747,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 34.998000000000005,
"eventListeners": 2383,
"totalBlockingTimeMs": 148,
"frameDurationMs": 19.676388888888898,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9487.97099999996,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.504999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6243.989,
"heapDeltaBytes": -11902220,
"heapUsedBytes": 73758392,
"domNodes": -142,
"jsHeapTotalBytes": -9080832,
"scriptDurationMs": 2933.503,
"eventListeners": -78,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.695246478873237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10278.42499999997,
"styleRecalcs": 247,
"styleRecalcDurationMs": 37.492,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6454.3550000000005,
"heapDeltaBytes": -40170960,
"heapUsedBytes": 83018736,
"domNodes": -328,
"jsHeapTotalBytes": -2265088,
"scriptDurationMs": 2937.625,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571428,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17919.775000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17144.457,
"heapDeltaBytes": -28523424,
"heapUsedBytes": 179999372,
"domNodes": -3045,
"jsHeapTotalBytes": 12079104,
"scriptDurationMs": 289.947,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.33779661016949,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 18485.007999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17447.214000000004,
"heapDeltaBytes": -27164312,
"heapUsedBytes": 195624220,
"domNodes": -3045,
"jsHeapTotalBytes": 5066752,
"scriptDurationMs": 299.763,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.379456706281832,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 22301.67799999998,
"styleRecalcs": 172,
"styleRecalcDurationMs": 23.553999999999963,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21826.751,
"heapDeltaBytes": -31278912,
"heapUsedBytes": 180637364,
"domNodes": -3045,
"jsHeapTotalBytes": 3284992,
"scriptDurationMs": 926.3280000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 53,
"frameDurationMs": 40.915596330275235,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 23408.186,
"styleRecalcs": 181,
"styleRecalcDurationMs": 28.083999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23052.823,
"heapDeltaBytes": -36660304,
"heapUsedBytes": 169537712,
"domNodes": -3045,
"jsHeapTotalBytes": 8204288,
"scriptDurationMs": 961.9590000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 34,
"frameDurationMs": 42.88589743589744,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6650.548000000015,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.49500000000005,
"layouts": 20,
"layoutDurationMs": 28.692999999999998,
"taskDurationMs": 6544.981,
"heapDeltaBytes": -5814992,
"heapUsedBytes": 204974808,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 128.248,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.22989130434783,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6789.019000000053,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.17599999999997,
"layouts": 20,
"layoutDurationMs": 30.799999999999994,
"taskDurationMs": 6667.383,
"heapDeltaBytes": -18903992,
"heapUsedBytes": 206001280,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 125.357,
"eventListeners": 0,
"totalBlockingTimeMs": 10,
"frameDurationMs": 37.47569060773481,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9531.270000000062,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9163.938000000002,
"heapDeltaBytes": -40562196,
"heapUsedBytes": 181039408,
"domNodes": -3046,
"jsHeapTotalBytes": 3547136,
"scriptDurationMs": 160.69200000000006,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.98615916955017,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9425.84599999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9001.838000000002,
"heapDeltaBytes": -19531852,
"heapUsedBytes": 181000076,
"domNodes": -3045,
"jsHeapTotalBytes": 7086080,
"scriptDurationMs": 162.42199999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.58482758620689,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 144.49000000001888,
"styleRecalcs": 10,
"styleRecalcDurationMs": 12.586000000000002,
"layouts": 3,
"layoutDurationMs": 1.7760000000000002,
"taskDurationMs": 100.33299999999998,
"heapDeltaBytes": 3873468,
"heapUsedBytes": 68721412,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.339,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 498.3439999999746,
"styleRecalcs": 16,
"styleRecalcDurationMs": 22.975999999999996,
"layouts": 4,
"layoutDurationMs": 2.501,
"taskDurationMs": 147.444,
"heapDeltaBytes": 5661532,
"heapUsedBytes": 70339456,
"domNodes": 101,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.72100000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1222.0089999999573,
"styleRecalcs": 78,
"styleRecalcDurationMs": 120.532,
"layouts": 76,
"layoutDurationMs": 31.823999999999998,
"taskDurationMs": 1193.011,
"heapDeltaBytes": -5544776,
"heapUsedBytes": 65190200,
"domNodes": 76,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 506.049,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66712328767123,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1069.374000000039,
"styleRecalcs": 78,
"styleRecalcDurationMs": 113.104,
"layouts": 76,
"layoutDurationMs": 30.155,
"taskDurationMs": 1037.0400000000002,
"heapDeltaBytes": 18969576,
"heapUsedBytes": 89662356,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 421.94,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6640625,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1613.4630000000243,
"styleRecalcs": 78,
"styleRecalcDurationMs": 313.90299999999996,
"layouts": 76,
"layoutDurationMs": 31.977999999999998,
"taskDurationMs": 1586.127,
"heapDeltaBytes": 8458844,
"heapUsedBytes": 113218728,
"domNodes": 76,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 533.143,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.95802469135803,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1480.2210000000287,
"styleRecalcs": 78,
"styleRecalcDurationMs": 288.503,
"layouts": 76,
"layoutDurationMs": 31.786,
"taskDurationMs": 1461.1689999999999,
"heapDeltaBytes": 8428236,
"heapUsedBytes": 111655648,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 517.4250000000001,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.54000000000001,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (6)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe current-user composable exposes whether a session user needs Firebase sign-in. The settings panel uses this state to choose between opening the password-update dialog and requesting confirmation before navigating to cloud login. ChangesPassword update flow
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
actor User
participant UserPanel
participant ConfirmationDialog
participant Router
User->>UserPanel: Select Update Password
alt Firebase sign-in not needed
UserPanel->>UserPanel: Open password-update dialog
else Firebase sign-in needed
UserPanel->>ConfirmationDialog: Request confirmation
alt Confirm
UserPanel->>Router: Navigate to cloud login with account switching and prior path
else Decline
ConfirmationDialog-->>UserPanel: Decline
end
end
Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change prompts session-only users to sign in before changing their password while preserving the existing flow for Firebase-authenticated users. No actionable merge-blocking risk is established; merge after normal checks pass. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The flow retains sign-in requirements and validated return navigation. No new authentication bypass was established, but failed or interrupted sign-in can require recovery, and end-to-end failure containment was not fully verified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #19759 +/- ##
==========================================
- Coverage 85.56% 85.48% -0.09%
==========================================
Files 2467 2389 -78
Lines 138969 136625 -2344
Branches 35721 36882 +1161
==========================================
- Hits 118913 116795 -2118
+ Misses 19576 19466 -110
+ Partials 480 364 -116
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 92 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
The exact-head password re-authentication flow is sound.
- Password-session users retain the Update Password control even when the tab has no matching Firebase identity.
- Session-only and identity-mismatch tabs confirm before redirecting to Cloud sign-in, preserving the current route for return.
- Existing Firebase-only behavior remains unchanged when the web-session flag is off.
Full context for agent readers
Reviewed exact head 33b9a0464dc9827291ca3a69d3b0e864389cb81b. Provider detection comes from the matching Firebase identity when present and otherwise from the web session; the re-authentication branch is limited to sessions without a matching Firebase user. Focused component, composable, and flag-off coverage is present. All checks are settled green and no review thread is unresolved.
…te (Comfy-Org#21363) ## Summary A cloud tab can be signed in with no Firebase user: by its web session cookie alone, or by a stored API key. When such a user opened an invite link, the app showed "Failed to Accept Invite" with "User not authenticated" and deleted the invite token. Now the app shows a "Sign in to accept this invite" toast with a Sign in button. After sign-in, the app returns to the invite link and accepts it. The invite accept endpoint takes only a Firebase login. The backend refuses a non-SSO web session with `auth_type_not_allowed` (ingest `openapi.yaml`, `/api/invites/{token}/accept`). Accepting on the session ("F1" in Comfy-Org#19759) stays a backend-gated follow-up. Fixes CLOUD-FRONTEND-PROD-2TV ## Changes Invite loader: - `loadInviteFromUrl` in `useInviteUrlLoader.ts` now has one branch for `authStore.currentUser === null`. An SSO session still gets the "Ask your admin to add you" toast. Every other tab gets `offerSignInAgain`, and then the loader removes the token from the URL and the stash, as the SSO case does. - `offerSignInAgain` shows an info toast. Its action opens `cloud-login` with `switchAccount=true` and `previousFullPath` set to the invite URL, which is the round trip the password-change flow uses in `UserPanel.vue` (Comfy-Org#19759). - The PR removes the comments in `loadInviteFromUrl`, as `AGENTS.md` requires for a modified function. Copy: - Three new strings in `src/locales/en/main.json`: `workspace.inviteNeedsSignIn`, `workspace.inviteNeedsSignInDetail` and `workspace.inviteSignIn`. Tests: - The vue-router mock now tracks the route through `replace`, so a test can start from the preserved query. The tests read the real en strings, and the session table has a row for an API-key login with no web session. ## QA Focus - [x] Run `pnpm exec vitest run src/platform/workspace/composables/useInviteUrlLoader.test.ts`. Expected: 28 tests pass. Author: tested, 28 pass. - [x] Put back the `origin/main` version of `useInviteUrlLoader.ts` and run the same file. Expected: the new tests do not pass. Author: tested, 5 failed and 23 passed. - [x] Move the `router.resolve` call in `offerSignInAgain` up to composable setup and run the same file. Expected: the preserved-query row does not pass, because the link then loses the invite. Author: tested, 1 failed and 27 passed. - [x] Run `pnpm exec vitest run src/platform/workspace/composables/ src/composables/useUrlActionLoaders.test.ts`. Expected: all pass. Author: tested, 30 files and 1404 tests pass. - [x] Run `pnpm fallow:audit` with the pre-push hook's `--diff-file`. Expected: no issues in the changed files. Author: tested, "No issues in 3 changed files". - [x] On cloud, sign in with email or Google. Then delete the Firebase entries in local storage and IndexedDB, keep the session cookie, and open an invite link. Expected: the "Sign in to accept this invite" toast shows with a Sign in button. Author: not tested, because this machine has no cloud backend with web sessions. - [x] In that state, click Sign in and sign in with the invited account. Expected: the app returns to the invite link and shows "Invite Accepted". Author: not tested in a browser, same reason. A review probe ran the real vue-router, the real cloud routes and the real preserved-query tracker, and the exact token came back in 14 of 14 cases, including hostile tokens. The probe ran on 7ca0eab. The later commits change the copy, the comments and the branch shape, not the link. - [x] Open an invite link in a tab that has a Firebase user. Expected: the invite is accepted with no sign-in toast, as before. Author: tested by the unit test rows that have a Firebase login and by the review probe. ## Risky areas - `useInviteUrlLoader.ts`: every cloud invite link runs through this check. Any tab with no Firebase user now gets the sign-in toast in place of the error toast. That includes an API-key login, which has a test row. `main.ts` starts a desktop host session only off cloud, and the invite loader runs only on cloud, so a desktop host tab does not reach this check. - The sign-in round trip depends on `switchAccount` on `cloud-login` and on `previousFullPath` in `usePostAuthRedirect.ts`. The password-change flow already uses both. A review probe ran them with the real router for 16 crafted links, and every redirect stayed on the origin. - The loader removes the token from the URL and the stash when it shows the toast. If the user closes the toast, the invite is gone from this tab, and the user must open the link again. The SSO case works the same way. - The `error_accepting_workspace_invite` report no longer fires for these tabs, because the failure is expected. No other signal counts how often the case occurs, and that count is the evidence for F1. - Not covered: a tab with a Firebase user whose token refresh does not succeed on the network still gets "User not authenticated". `getFirebaseIdToken` in `authStore.ts` returns no token in that case. The Sentry event does not show which of the two causes occurred. --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Why
With
unified_web_sessionon, a Cloud tab can be signed in on the web session alone, with no Firebase login on cloud.comfy.org (#19615). Changing the password still goes through the Firebase SDK, which needs a Firebase user on this origin. TDD §18 says a user who reached a site by session only has to sign in there once for such actions.Today, on that tab:
isEmailProviderreads only the Firebase user;authStore.updatePasswordthrowsuserNotAuthenticated.Update Password is the only user-triggered action in the app that needs a Firebase user. The rest were checked:
Root cause
useCurrentUser.isEmailProvideronly reads the Firebase user'sproviderData, so a session-only tab never sees the control.How
useCurrentUserneedsFirebaseSignIn: true when a session user exists but no matching Firebase user.isEmailProviderfalls back to the session'ssignInProvideronly when no matching Firebase user exists. With a Firebase user it is unchanged.UserPanelcloud-loginwithswitchAccount=trueandpreviousFullPath, the same query the router already uses to send a session-only tab to Firebase sign-in, so the user returns to the same page.logout(), so the open Settings dialog doesn't stay on top.aria-label.sessionUseris undefined, soneedsFirebaseSignInis always false.Open for review
auth.reauthRequired.title/message, andconfirm()labels the button "Confirm". A dedicated "Sign in again to continue" string plus a "Sign In Again" button would need a smallconfirm()option.Tests
UserPanel.test.ts(new):/cloud/login?switchAccount=true&previousFullPath=…;useCurrentUser.test.ts: a table of session-only email, session-only Google, a session with a different Firebase user, a session with its own Firebase user, and Firebase-only rows.webSessionFlagOff.test.ts: with the flag off,needsFirebaseSignInis always false andisEmailProvideris unchanged, withunified_cloud_authoff and on.AS IS / TO BE
AS IS (session-only tab, no Firebase login): Settings > User
The provider reads "password" but there is no Update Password pen button.
TO BE (same tab and account): Settings > User, then the pen button
The pen button is shown; clicking it opens the "Re-authentication Required" confirm.
The session reports
sign_in_provider: "password".Plan position
acceptInviteon the session