Skip to content

[backport cloud/1.55] test: restore abandoned-slice browser coverage (#18840) - #19703

Merged
christian-byrne merged 3 commits into
cloud/1.55from
christian-byrne/backport-18840-cloud-1.55
Oct 1, 2026
Merged

christian-byrne merged 3 commits into
cloud/1.55from
christian-byrne/backport-18840-cloud-1.55

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Manual backport of #18840 to cloud/1.55. The change restores ten browser tests stranded behind abandoned slice pull requests and carries the Agent panel and Load3D workspace-inset fixes into the 1.55 cloud release line.

agentPanelViewportDrag.spec.ts was already removed from the target branch, so that modify/delete conflict was resolved by keeping it absent. The full Agent/Load3D integration scenario and focused composable/component regressions are retained.

Validation

  • git diff --check
  • Manual conflict review against cloud/1.55
  • Full repository CI pending

Backport of #18840.

`browser_tests` carried 10 tests parked behind `test.fixme(true,
'Activates after slice PR 1618x merges')`. All four gating PRs were
closed unmerged on 2026-09-14, so their activation condition could never
be met.

| File | Tests | Gate |
|---|---:|---|
| `browser_tests/tests/topbar/workflowTabs.spec.ts` | 4 | #16184 —
closed unmerged |
| `browser_tests/tests/agent/slice03CanvasPrimitives.spec.ts` | 4 |
| `browser_tests/tests/billingFacadeConsumers.spec.ts` | 1 | #16185 —
closed unmerged |
| `browser_tests/tests/load3d/load3dViewer.spec.ts` | 1 | #16187 —
closed unmerged |

- Remove all 10 gates and the stale slice-PR comments.
- Rename `slice03CanvasPrimitives.spec.ts` to
`agentCanvasPrimitives.spec.ts` and remove slice numbering from its
suite names.
- Move reusable canvas operations into their fixture owners and make the
centering and fit tests establish that a viewport change is required
before checking the result.
- Make the full-screen Load3D viewer respect the right workspace inset
published by the Agent panel.
- Preserve the widest active inset publisher during graph/linear host
switches.
- Keep Agent usable as a viewport-width overlay when the dock cannot
fit, while publishing zero workspace inset so portaled dialogs retain
positive width.

Production changes span `ViewerControls.vue`, `load3dViewerDialog.ts`,
`useWorkspaceInset.ts`, `load3d.ts`, `DockedAgentPanel.vue`, and
`agentPanelStore.ts`, with focused component/composable and cloud
browser coverage.

8 of the 10 tests passed on their first run. The two failures were fixed
rather than pinned:

- **Load3D workspace geometry:** the full-screen viewer was centered and
sized against the whole viewport, so it rendered beneath the Agent dock.
The cloud case now opens the real Agent panel and checks both docked and
400px overlay geometry in `load3dAgentUpdate.spec.ts` through
`load3dAgentFixture`.
- **Canvas primitive oracle:** `graph.serialize()` includes viewport
state in `extra.ds`, so comparing the whole serialization incorrectly
treated `centerOnNode()` doing its job as graph mutation. The test now
compares graph data without viewport state.

The centering test first shifts the viewport 400×250 away and proves the
node is off-center. The fit test first zooms to 3× and proves a node is
outside the canvas. Both then assert the requested operation changes the
viewport; the centering test also verifies that graph data is unchanged.

- Fixes #18918

---------

Co-authored-by: Amp <amp@ampcode.com>
@christian-byrne
christian-byrne requested review from a team and jtydhr88 as code owners October 1, 2026 04:59
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 7b333512-6a48-460f-a7f2-47aff4fef768

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/01/2026, 07:57:26 AM UTC

Links

🎭 Playwright: ✅ 2138 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2117 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 829fb7ef819f1ddc1d34d35d392a75b373b4c123

Full docs: ADR-DEVEX-LINT-0015

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.0 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.6 MB heap
dom-widget-order-dense-n200-w200-i120: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 793ms TBT · 99.0 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 215ms TBT · 87.0 MB heap
extension-clean-combined-draw: · 52.2 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 1741ms TBT · 86.1 MB heap
extension-rgthree-prototype-draw: · 51.4 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 1639ms TBT · 68.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.1 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 3ms TBT · 81.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.1 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 186ms TBT · 78.1 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 88.3 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 184.3 MB heap
vue-large-graph-pan: · 54.6 avg FPS · 39.8 P5 FPS ❌ (target: ≥52) · 204ms TBT · 170.5 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 321ms TBT · 168.8 MB heap
vue-zoom-out-idle: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.0 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.7 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 14ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 729ms
canvas-idle: script duration 18ms
canvas-idle: TBT 0ms
canvas-idle: heap used 73.0 MB
canvas-idle: DOM nodes -261
canvas-idle: event listeners -152
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 0ms
canvas-mouse-sweep: style recalc duration 22ms
canvas-mouse-sweep: layout count 0
canvas-mouse-sweep: style recalc count 43
canvas-mouse-sweep: task duration 1203ms
canvas-mouse-sweep: script duration 205ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 69.8 MB
canvas-mouse-sweep: DOM nodes -265
canvas-mouse-sweep: event listeners -163
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 2ms
canvas-zoom-sweep: style recalc duration 21ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 543ms
canvas-zoom-sweep: script duration 21ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 67.6 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 11ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 644ms
dom-widget-clipping: script duration 214ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 82.6 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 17ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 1183ms
dom-widget-order-dense-n200-w200-i120: script duration 78ms
dom-widget-order-dense-n200-w200-i120: TBT 793ms
dom-widget-order-dense-n200-w200-i120: heap used 99.0 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -150
dom-widget-order-dense-n200-w200-i120: event listeners -98
dom-widget-order-sparse-n1000-w20-i120: avg frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 517ms
dom-widget-order-sparse-n1000-w20-i120: script duration 168ms
dom-widget-order-sparse-n1000-w20-i120: TBT 215ms
dom-widget-order-sparse-n1000-w20-i120: heap used 87.0 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 19ms
extension-clean-combined-draw: p95 frame time 50ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 11179ms
extension-clean-combined-draw: script duration 8727ms
extension-clean-combined-draw: TBT 1741ms
extension-clean-combined-draw: heap used 86.1 MB
extension-clean-combined-draw: DOM nodes -12
extension-clean-combined-draw: event listeners 0
extension-rgthree-prototype-draw: avg frame time 19ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 0
extension-rgthree-prototype-draw: task duration 10507ms
extension-rgthree-prototype-draw: script duration 8381ms
extension-rgthree-prototype-draw: TBT 1639ms
extension-rgthree-prototype-draw: heap used 68.5 MB
extension-rgthree-prototype-draw: DOM nodes -16
extension-rgthree-prototype-draw: event listeners 0
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 883ms
large-graph-idle: script duration 48ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 80.0 MB
large-graph-idle: DOM nodes -249
large-graph-idle: event listeners -152
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 64
large-graph-pan: task duration 2267ms
large-graph-pan: script duration 1077ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 84.0 MB
large-graph-pan: DOM nodes -262
large-graph-pan: event listeners 0
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 20ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 2219ms
large-graph-zoom: script duration 1033ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 71.1 MB
large-graph-zoom: DOM nodes -129
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 2846ms
legacy-node-drag: script duration 1418ms
legacy-node-drag: TBT 3ms
legacy-node-drag: heap used 81.3 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 864ms
minimap-idle: script duration 61ms
minimap-idle: TBT 0ms
minimap-idle: heap used 80.0 MB
minimap-idle: DOM nodes -253
minimap-idle: event listeners -163
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 16ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 568ms
subgraph-dom-widget-clipping: script duration 182ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 80.1 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 13ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 725ms
subgraph-idle: script duration 17ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 63.2 MB
subgraph-idle: DOM nodes -288
subgraph-idle: event listeners -198
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 0ms
subgraph-mouse-sweep: style recalc duration 23ms
subgraph-mouse-sweep: layout count 0
subgraph-mouse-sweep: style recalc count 45
subgraph-mouse-sweep: task duration 1074ms
subgraph-mouse-sweep: script duration 147ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 73.9 MB
subgraph-mouse-sweep: DOM nodes -278
subgraph-mouse-sweep: event listeners -198
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 16
subgraph-transition-enter: task duration 1174ms
subgraph-transition-enter: script duration 45ms
subgraph-transition-enter: TBT 186ms
subgraph-transition-enter: heap used 78.1 MB
subgraph-transition-enter: DOM nodes 13667
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 57ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 8041ms
viewport-pan-sweep: script duration 3727ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 88.3 MB
viewport-pan-sweep: DOM nodes -247
viewport-pan-sweep: event listeners -152
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 18111ms
vue-large-graph-idle: script duration 361ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 184.3 MB
vue-large-graph-idle: DOM nodes -8061
vue-large-graph-idle: event listeners -14928
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 25ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 37ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 177
vue-large-graph-pan: task duration 23679ms
vue-large-graph-pan: script duration 1180ms
vue-large-graph-pan: TBT 204ms
vue-large-graph-pan: heap used 170.5 MB
vue-large-graph-pan: DOM nodes -8061
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 38ms
vue-node-resize-workload: style recalc duration 87ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6001ms
vue-node-resize-workload: script duration 146ms
vue-node-resize-workload: TBT 321ms
vue-node-resize-workload: heap used 168.8 MB
vue-node-resize-workload: DOM nodes -8061
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7867ms
vue-zoom-out-idle: script duration 158ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 170.0 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 3ms
workflow-execution: style recalc duration 26ms
workflow-execution: layout count 4
workflow-execution: style recalc count 12
workflow-execution: task duration 153ms
workflow-execution: script duration 19ms
workflow-execution: TBT 0ms
workflow-execution: heap used 66.7 MB
workflow-execution: DOM nodes 135
workflow-execution: event listeners 41
Raw data
{
  "timestamp": "2026-10-01T08:10:55.004Z",
  "gitSha": "a8e07e5be11ae05ed93c891e9e3fc764fd08df87",
  "branch": "christian-byrne/backport-18840-cloud-1.55",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2073.7780000000043,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 16.198,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 725.919,
      "heapDeltaBytes": 8646448,
      "heapUsedBytes": 76377700,
      "domNodes": -262,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 18.340000000000003,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2038.9749999999367,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 12.286999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 732.7370000000001,
      "heapDeltaBytes": 9331552,
      "heapUsedBytes": 76773400,
      "domNodes": -259,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 17.087999999999997,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2173.6819999999852,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 23.951,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1218.188,
      "heapDeltaBytes": 9114088,
      "heapUsedBytes": 76888516,
      "domNodes": -265,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 207.90900000000002,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2149.2259999999987,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 20.799000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1187.535,
      "heapDeltaBytes": 2038192,
      "heapUsedBytes": 69445852,
      "domNodes": -264,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 201.55599999999998,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1749.804999999924,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 20.098000000000003,
      "layouts": 6,
      "layoutDurationMs": 2.038,
      "taskDurationMs": 540.824,
      "heapDeltaBytes": 3127384,
      "heapUsedBytes": 71141180,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 21.83,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1745.7510000000411,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 21.647000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.7910000000000001,
      "taskDurationMs": 545.7959999999999,
      "heapDeltaBytes": 2722744,
      "heapUsedBytes": 70545760,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 20.810000000000002,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 891.9449999999642,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 12.020999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 646.7700000000001,
      "heapDeltaBytes": 18939956,
      "heapUsedBytes": 86659988,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 214.88500000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 897.6749999999356,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.543000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 640.799,
      "heapDeltaBytes": 18965240,
      "heapUsedBytes": 86649804,
      "domNodes": 16,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 213.367,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1380.1010000000247,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1144.5500000000002,
      "heapDeltaBytes": 35827128,
      "heapUsedBytes": 103520872,
      "domNodes": 0,
      "jsHeapTotalBytes": 19296256,
      "scriptDurationMs": 81.77700000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 752,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1477.4830000000065,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1222.305,
      "heapDeltaBytes": 13363460,
      "heapUsedBytes": 104000880,
      "domNodes": -299,
      "jsHeapTotalBytes": 23482368,
      "scriptDurationMs": 74.24700000000001,
      "eventListeners": -195,
      "totalBlockingTimeMs": 833,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 846.9050000000493,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 503.4510000000001,
      "heapDeltaBytes": 14363612,
      "heapUsedBytes": 90717152,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 168.63300000000004,
      "eventListeners": 0,
      "totalBlockingTimeMs": 216,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 830.0069999999096,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 530.5020000000003,
      "heapDeltaBytes": 14909632,
      "heapUsedBytes": 91712372,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 167.16199999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 213,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 12500.783000000012,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11231.746000000001,
      "heapDeltaBytes": 4229284,
      "heapUsedBytes": 85702484,
      "domNodes": -10,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 8761.858,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1734,
      "frameDurationMs": 19.446666666666594,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 12351.019000000066,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11125.847,
      "heapDeltaBytes": 12807572,
      "heapUsedBytes": 94937992,
      "domNodes": -14,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 8691.737,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1748,
      "frameDurationMs": 18.886666666666617,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 12225.874999999975,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11006.886,
      "heapDeltaBytes": -8367676,
      "heapUsedBytes": 74048740,
      "domNodes": -18,
      "jsHeapTotalBytes": 9961472,
      "scriptDurationMs": 8850.031,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1994,
      "frameDurationMs": 20.003333333333284,
      "p95FrameDurationMs": 49.900000000001455
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 11310.668999999962,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10007.518000000002,
      "heapDeltaBytes": -12726532,
      "heapUsedBytes": 69566856,
      "domNodes": -14,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 7911.176000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1284,
      "frameDurationMs": 18.890000000000025,
      "p95FrameDurationMs": 49.900000000001455
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2042.3699999999485,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 6.1389999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 872.1630000000001,
      "heapDeltaBytes": 20583452,
      "heapUsedBytes": 84111332,
      "domNodes": -248,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 48.340999999999994,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2059.1120000000274,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.357999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 892.9659999999999,
      "heapDeltaBytes": -3253448,
      "heapUsedBytes": 83744984,
      "domNodes": -249,
      "jsHeapTotalBytes": -495616,
      "scriptDurationMs": 48.652999999999984,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3207.357000000002,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 15.512999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2289.629,
      "heapDeltaBytes": 19761692,
      "heapUsedBytes": 84509784,
      "domNodes": -270,
      "jsHeapTotalBytes": 1273856,
      "scriptDurationMs": 1081.665,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3150.0499999999647,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 13.132000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2244.9009999999994,
      "heapDeltaBytes": 26389288,
      "heapUsedBytes": 91583748,
      "domNodes": -254,
      "jsHeapTotalBytes": 1536000,
      "scriptDurationMs": 1071.8529999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4181.010000000015,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 15.303999999999998,
      "layouts": 60,
      "layoutDurationMs": 20.407999999999998,
      "taskDurationMs": 2190.479,
      "heapDeltaBytes": 8137432,
      "heapUsedBytes": 74431872,
      "domNodes": -258,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 1011.9040000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4300.4680000000235,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 15.333000000000004,
      "layouts": 60,
      "layoutDurationMs": 20.157,
      "taskDurationMs": 2247.6859999999997,
      "heapDeltaBytes": 8972228,
      "heapUsedBytes": 74745540,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 1054.176,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 4112.391000000002,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 7.932000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2849.109,
      "heapDeltaBytes": 4726916,
      "heapUsedBytes": 70626928,
      "domNodes": 0,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 1412.609,
      "eventListeners": 180,
      "totalBlockingTimeMs": 2,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 4152.098999999907,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 7.979999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2843.2149999999997,
      "heapDeltaBytes": 33478264,
      "heapUsedBytes": 99958960,
      "domNodes": 0,
      "jsHeapTotalBytes": 3825664,
      "scriptDurationMs": 1423.6930000000002,
      "eventListeners": 180,
      "totalBlockingTimeMs": 4,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2066.1039999999957,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 7.2799999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 869.5229999999999,
      "heapDeltaBytes": -5359332,
      "heapUsedBytes": 83565928,
      "domNodes": -254,
      "jsHeapTotalBytes": -757760,
      "scriptDurationMs": 51.391000000000005,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2055.04099999996,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 4.245000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 858.256,
      "heapDeltaBytes": -4214880,
      "heapUsedBytes": 84237968,
      "domNodes": -251,
      "jsHeapTotalBytes": -495616,
      "scriptDurationMs": 70.54800000000002,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 820.0549999999112,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 15.099000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 566.851,
      "heapDeltaBytes": 14073352,
      "heapUsedBytes": 83772296,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 180.571,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 832.6789999999846,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 15.922000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 568.789,
      "heapDeltaBytes": 14035212,
      "heapUsedBytes": 84109740,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 183.89899999999997,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2048.628000000008,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 15.511000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 735.325,
      "heapDeltaBytes": -13905080,
      "heapUsedBytes": 56060500,
      "domNodes": -277,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 16.592000000000002,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2051.552000000015,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 9.795000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 713.97,
      "heapDeltaBytes": 5651516,
      "heapUsedBytes": 76495632,
      "domNodes": -299,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 17.281,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1932.3739999999816,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 21.201999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1119.4250000000002,
      "heapDeltaBytes": 6913300,
      "heapUsedBytes": 76632132,
      "domNodes": -279,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 144.64900000000003,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1949.0169999999125,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 24.247000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1029.276,
      "heapDeltaBytes": 8018596,
      "heapUsedBytes": 78280112,
      "domNodes": -276,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 149.611,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1530.2130000000034,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 32.227999999999994,
      "layouts": 5,
      "layoutDurationMs": 14.046000000000003,
      "taskDurationMs": 1173.5380000000002,
      "heapDeltaBytes": -6345612,
      "heapUsedBytes": 81848272,
      "domNodes": 13667,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 44.577000000000005,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 186,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 12216.735999999968,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 57.661,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7663.727000000001,
      "heapDeltaBytes": 1983880,
      "heapUsedBytes": 88655364,
      "domNodes": -249,
      "jsHeapTotalBytes": 1531904,
      "scriptDurationMs": 3656.0570000000002,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 12382.475999999997,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 56.545,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8418.733,
      "heapDeltaBytes": 9690996,
      "heapUsedBytes": 96611836,
      "domNodes": -244,
      "jsHeapTotalBytes": 483328,
      "scriptDurationMs": 3797.624,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999952,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18070.107000000007,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17953.23,
      "heapDeltaBytes": -42725804,
      "heapUsedBytes": 198793276,
      "domNodes": -8061,
      "jsHeapTotalBytes": -14356480,
      "scriptDurationMs": 356.38499999999993,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18408.097999999994,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18268.068999999996,
      "heapDeltaBytes": -20037108,
      "heapUsedBytes": 187795728,
      "domNodes": -8061,
      "jsHeapTotalBytes": -9973760,
      "scriptDurationMs": 365.921,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23533.429999999953,
      "styleRecalcs": 176,
      "styleRecalcDurationMs": 36.64299999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 23453.905,
      "heapDeltaBytes": -65520264,
      "heapUsedBytes": 168692200,
      "domNodes": -8061,
      "jsHeapTotalBytes": -11284480,
      "scriptDurationMs": 1166.295,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 193,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23973.64899999991,
      "styleRecalcs": 177,
      "styleRecalcDurationMs": 37.39300000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 23904.937,
      "heapDeltaBytes": -51232908,
      "heapUsedBytes": 188845204,
      "domNodes": -8061,
      "jsHeapTotalBytes": -16703488,
      "scriptDurationMs": 1194.2939999999999,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 214,
      "frameDurationMs": 18.886666666666617,
      "p95FrameDurationMs": 33.400000000001455
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5256.974000000014,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 87.44999999999997,
      "layouts": 20,
      "layoutDurationMs": 37.82299999999998,
      "taskDurationMs": 5230.362999999999,
      "heapDeltaBytes": -65686252,
      "heapUsedBytes": 169003700,
      "domNodes": -8061,
      "jsHeapTotalBytes": 7880704,
      "scriptDurationMs": 122.44099999999999,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 176,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6802.612000000067,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 86.25500000000002,
      "layouts": 20,
      "layoutDurationMs": 37.73999999999998,
      "taskDurationMs": 6771.803999999999,
      "heapDeltaBytes": -49149584,
      "heapUsedBytes": 185087096,
      "domNodes": -8061,
      "jsHeapTotalBytes": 2084864,
      "scriptDurationMs": 169.695,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 466,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6866.283000000067,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6772.590000000001,
      "heapDeltaBytes": -9544612,
      "heapUsedBytes": 180391644,
      "domNodes": 0,
      "jsHeapTotalBytes": -7077888,
      "scriptDurationMs": 148.90499999999994,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9002.883999999995,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8961.585,
      "heapDeltaBytes": 7940816,
      "heapUsedBytes": 176168500,
      "domNodes": 0,
      "jsHeapTotalBytes": -6815744,
      "scriptDurationMs": 167.709,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 519.5929999999862,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 30.122000000000003,
      "layouts": 5,
      "layoutDurationMs": 3.0440000000000005,
      "taskDurationMs": 189.00099999999998,
      "heapDeltaBytes": 5212168,
      "heapUsedBytes": 70932224,
      "domNodes": 143,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 26.237999999999996,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 156.83799999999337,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 21.668,
      "layouts": 3,
      "layoutDurationMs": 2.7310000000000003,
      "taskDurationMs": 117.95699999999998,
      "heapDeltaBytes": 3044284,
      "heapUsedBytes": 69040224,
      "domNodes": 126,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 11.747,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 52452 79392 66.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.8% 1153
src/LGraphNode.ts 70.5% 382
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/platform/workspace/stores/billingOperationStore.ts 8.0% 332
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/LGraph.ts 79.2% 267
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/core/billing/operationLifecycle.ts 1.2% 252
src/scripts/app.ts 73.2% 252
src/scripts/pnginfo.ts 20.7% 222

@christian-byrne christian-byrne added greenlight cursor-review Trigger multi-model Cursor agent review on this PR labels Oct 1, 2026
@christian-byrne
christian-byrne enabled auto-merge (squash) October 1, 2026 05:00
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 1, 2026
@christian-byrne
christian-byrne requested a review from DrJKL October 1, 2026 05:12
@christian-byrne
christian-byrne removed the request for review from DrJKL October 1, 2026 05:20

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 10 finding(s).

Severity Count
🟠 High 2
🟡 Medium 4
🟢 Low 4

Panel: 8/8 reviewers contributed findings.

'border-l border-interface-stroke bg-base-background'
'docked-agent-panel pointer-events-auto shrink-0 overflow-hidden [anchor-name:--docked-agent-panel]',
isOverlay
? 'fixed inset-y-0 right-0 z-1100 max-w-full bg-base-background shadow-lg'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High — The overlay teleports to body at z-1100, painting over the top-bar AgentEntryButton — the only toggle outside the panel — while rendering no backdrop, no inert on the covered workspace, and no Escape handler, so obscured controls stay focusable and activatable by keyboard. If AgentPanelRoot's async chunk is slow or fails (AgentPanelLoadError renders no close action) there is then no reachable dismiss control at all, and because the panel's open state is persisted the lockout survives a reload. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case).

)
const isOverlay = computed(
() =>
windowWidth.value <= requestedWidth.value + reservedWorkspaceWidth.value

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High — isOverlay compares against requestedWidth, which is PANEL_MAX_WIDTH (960) whenever maximized, so with the sidebar open (reserved 368) any window under 1328px — including common 1280px laptops — turns a click on Maximize into a full-height fixed overlay instead of clamping to the available width as before. The same threshold is reachable by dragging (≥656px on a 1024px window), and since the resize handle is v-if="!isOverlay" there is then no way to drag back out of overlay mode without resizing the window. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, claude-opus-5-thinking-max adversarial).

const { width: viewportWidth } = useWindowSize()
const panelWidth = computed(() =>
Math.min(
isOverlay.value ? requestedWidth.value : width.value,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — In overlay mode the rendered panelWidth is min(requestedWidth, viewportWidth) while agentPanelStore.width keeps the docked clamp (windowWidth - reservedWorkspaceWidth), and visibleCanvasViewport() still subtracts width. On a 400px viewport the overlay covers all 400px but width reports 32px, so Fit View (useCoreCommands), useFocusNode, and agentNodeSelectionStore all under-report the covered area and centre content underneath the overlay. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case).

>
<div
class="size-full overflow-hidden rounded-lg border border-interface-stroke"
v-if="!isOverlay"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — Crossing the docked-to-overlay threshold mid-drag unmounts the element carrying @​lostpointercapture, which releases pointer capture and removes that listener with it. If the pointer is then released outside the document — a natural gesture when widening toward the window edge — neither the new pointerup nor pointercancel fallback fires, so isResizing stays true and the panel keeps resizing on bare hover because the pointermove handler never checks e.buttons. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial).

@@ -0,0 +1,2 @@
export const LOAD3D_VIEWER_CONTENT_CLASS =
'w-[80vw] max-w-[min(80vw,calc(100vw-var(--workspace-inset-right,0px)-1rem))] h-[80vh] max-h-[80vh]'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — The max-width has no lower bound: with the default 420px dock on a 500px viewport it limits the viewer to 500 - 420 - 16 = 64px (and ~41px just above the overlay threshold), even though Load3dViewerContent contains a 288px w-72 sidebar plus the canvas, so the dialog collapses or overflows on plausible narrow viewports. Floor the subtraction (e.g. max(360px, calc(...))) so the viewer stays usable. Raised by 2 of 8 reviewers (gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max adversarial).

)
)
useWorkspaceInsetRight(() =>
docked.value && !isOverlay.value ? width.value : 0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — The inset drops to 0 as soon as isOverlay is true, even though the overlay still occupies panelWidth pixels. Around 1200–1328px with the sidebar open and the panel maximized the overlay is 960px wide and 240–368px of workspace remains visible, yet every body-portaled dialog reverts to centring on the raw viewport and lands behind the panel; publishing min(panelWidth, viewportWidth) would keep them positioned. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).

insetPublishers.set(publisher, widthPx())
publishCurrentInset()
})
onScopeDispose(() => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — onScopeDispose only fires inside an active effect scope — called from a Pinia store setup or module scope it merely warns — and the entry then stays in the module-level insetPublishers map forever. Combined with Math.max, one leaked publisher pins --workspace-inset-right at a stale width for the whole session, where the previous implementation self-corrected because the next publisher simply overwrote the property; consider guarding with getCurrentScope() or returning an explicit disposer. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max adversarial).

document.documentElement.style.removeProperty(WORKSPACE_INSET_RIGHT)
return
}
const width = Math.max(...widths)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — Math.max reports the widest single publisher, not the total width consumed on the right, which is what the variable documents and what consumers such as dialog.variants.ts subtract. It is the right behaviour for the mount-overlap handover the new tests cover, but two simultaneously docked right-hand surfaces would under-report and portaled dialogs would overlap the inner one — worth a comment stating the intent, or keying publishers so stacked surfaces sum. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).

@@ -147,21 +148,7 @@ test.describe(

await page.setViewportSize({ width: 900, height: 900 })

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — This swaps the rail-relative guard for an assertion that the panel now owns the entire 900px viewport. The deleted code existed precisely because, as its comment said, "a panel that ignored the sidebar and took all 900px would satisfy every bound above" — so nothing now catches the panel occluding the toolbar rail and the top-bar Agent toggle, which is the lockout path flagged on DockedAgentPanel.vue. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).

@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.55   #19703   +/-   ##
=============================================
  Coverage              ?   84.62%           
=============================================
  Files                 ?     2315           
  Lines                 ?   131847           
  Branches              ?    35497           
=============================================
  Hits                  ?   111575           
  Misses                ?    19912           
  Partials              ?      360           
Flag Coverage Δ
e2e 66.10% <100.00%> (?)
unit 80.56% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/load3d/controls/ViewerControls.vue 100.00% <ø> (ø)
src/components/load3d/load3dViewerDialog.ts 100.00% <100.00%> (ø)
src/composables/useWorkspaceInset.ts 100.00% <100.00%> (ø)
src/extensions/core/load3d.ts 79.94% <ø> (ø)
...nsions/agent/components/agent/DockedAgentPanel.vue 100.00% <100.00%> (ø)
...h/extensions/agent/stores/agent/agentPanelStore.ts 96.51% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-official

This comment has been minimized.

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Playwright videos for new tests

Download the recorded videos and HTML report

Recorded projects: chromium cloud

Recorded test titles:

  • all tests in browser_tests/tests/agent/agentCanvasPrimitives.spec.ts
  • all tests in browser_tests/tests/agent/agentConsent.spec.ts
  • all tests in browser_tests/tests/agent/agentPanelLifecycle.spec.ts
  • all tests in browser_tests/tests/billingFacadeConsumers.spec.ts
  • all tests in browser_tests/tests/load3d/load3dAgentUpdate.spec.ts
  • all tests in browser_tests/tests/load3d/load3dViewer.spec.ts
  • all tests in browser_tests/tests/topbar/workflowTabs.spec.ts

@DrJKL
DrJKL self-requested a review October 1, 2026 05:48
@christian-byrne
christian-byrne removed the request for review from DrJKL October 1, 2026 07:35

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: Approve. This is a faithful backport of #18840 to cloud/1.55, with two adaptations, each accounted for by the target.

I compared this branch, at 9fd7e33 against its merge base 27c2559, with #18840's merged diff (3f266cb). Nineteen of the source's 21 files carry exactly the source's added and removed lines. That includes the production changes, their unit tests, load3dAgentFixture.ts, and the load3dAgentUpdate.spec.ts case that the source moves out of load3dViewer.spec.ts.

Adaptations:

  • agentPanelViewportDrag.spec.ts does not exist on cloud/1.55, so the source's two test.fail removals there have no target.
  • In browser_tests/fixtures/components/AgentPanel.ts, closeButton is scoped to the panel header. With the source's unscoped locator, the cloud run of agentConsent.spec.ts "keeps the docs link and actions fully visible and in keyboard order" (fr, widths 608 and 672) failed at 0bcf6ae with a strict-mode violation: two "Fermer" buttons inside #agent-panel-root on this branch. PanelHeader.vue renders the panel's own close control inside its <header>, so scoping there selects the intended button. It is the smallest change that lets the source's switch to new AgentPanel(page).close() in requestConsentFromOpenPanel pass on this branch.

Checks:

  • At 9fd7e33: vitest run over useWorkspaceInset.test.ts, DockedAgentPanel.test.ts, stores/agent/, and src/components/load3d/ passed 454/454 across 46 files, and pnpm typecheck:browser passed.
  • All hosted checks at this head passed, including playwright-tests (cloud, frontend-dist-cloud) and playwright-video-new-tests, which had failed on the unscoped locator.

@DrJKL DrJKL assigned christian-byrne and unassigned DrJKL Oct 1, 2026
@christian-byrne
christian-byrne merged commit 8be3aff into cloud/1.55 Oct 1, 2026
105 checks passed
@christian-byrne
christian-byrne deleted the christian-byrne/backport-18840-cloud-1.55 branch October 1, 2026 08:29
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 3, 2026
## Summary

- route every Load3D and HDR viewer through one inset-aware dialog
configuration
- remove raw-viewport centering overrides that let the docked Agent
panel cover viewer content
- keep the responsive 80vw cap paired with the full-size dialog variant

This follows up on findings from the merged [core/1.55
backport](Comfy-Org#19702 (comment))
and [cloud/1.55
backport](Comfy-Org#19703 (comment)).

## Changes

- apply the shared configuration to HDR, Agent reply, Assets, Job
History, node, and viewer-control entry points
- centralize `renderer`, `size`, `contentClass`, and `maximizable` so
responsive geometry cannot drift across callers
- remove brittle class-token assertions; browser coverage measures the
visible viewer geometry

## Review Focus

- confirm the shared `sm:max-w` override remains paired with `size:
full`
- confirm viewers with custom `onClose` behavior preserve it when
spreading the shared configuration

## Validation

- `oxfmt --check` passed for all nine changed files
- `git diff --check` passed
- the focused Vitest runner stalled before producing output in this
workspace; CI is rerunning the affected suites
christian-byrne added a commit that referenced this pull request Oct 4, 2026
## Summary

- route every Load3D and HDR viewer through one inset-aware dialog
configuration
- remove raw-viewport centering overrides that let the docked Agent
panel cover viewer content
- keep the responsive 80vw cap paired with the full-size dialog variant

This follows up on findings from the merged [core/1.55
backport](#19702 (comment))
and [cloud/1.55
backport](#19703 (comment)).

## Changes

- apply the shared configuration to HDR, Agent reply, Assets, Job
History, node, and viewer-control entry points
- centralize `renderer`, `size`, `contentClass`, and `maximizable` so
responsive geometry cannot drift across callers
- remove brittle class-token assertions; browser coverage measures the
visible viewer geometry

## Review Focus

- confirm the shared `sm:max-w` override remains paired with `size:
full`
- confirm viewers with custom `onClose` behavior preserve it when
spreading the shared configuration

## Validation

- `oxfmt --check` passed for all nine changed files
- `git diff --check` passed
- the focused Vitest runner stalled before producing output in this
workspace; CI is rerunning the affected suites

(cherry picked from commit 3c4030d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor agent review on this PR greenlight risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants