Skip to content

[backport cloud/1.55] fix(agent): keep the turn live across a socket reconnect - #19695

Merged
comfy-pr-bot merged 2 commits into
cloud/1.55from
backport-18152-to-cloud-1.55
Oct 1, 2026
Merged

comfy-pr-bot merged 2 commits into
cloud/1.55from
backport-18152-to-cloud-1.55

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Manual backport of #18152 to cloud/1.55. Preserves an active Agent turn across a transient socket disconnect and reconciles its outcome from persisted REST history.

onStatus(false) now only records a drop. onStatus(true) after a drop starts one bounded recovery job per live turn: poll rest.getMessages on a 0/1/2/4/8/16-second backoff under a 60-second whole-job deadline, keep polling while the row is streaming, settle when terminal, forget the thread on a repeated 404, one notice then keep polling on other REST errors. agentConversationStore gains liveTurns() / settleTurn(); agentTranscript hydrates any still-streaming assistant row as pending.

Why this was re-done

The previous head cherry-picked useAgentSession.ts, agentTranscript.ts and agentConversationStore.ts largely as they stand on main, which pulled in main-only drift the reconnect fix does not need — workspace-scoped agent thread storage, trackAgentStopClicked/trackAgentWorkflowBound telemetry, ReportErrorOptions.surface, the turnStartedAt timing rework. That is what the 16 typecheck errors were, and the earlier repair attempt answered them by deleting 1 223 lines of the reconnect regression coverage.

This head is a fresh cherry-pick of #18152's own delta onto cloud/1.55, resolved against the APIs this branch actually has. useAgentSession.ts is +252/-32 here against +223/-26 upstream; the other nine files are byte-identical to the upstream delta apart from the adaptations below. Every regression pin from #18152 is restored: the three test.fail() pins in agentTurnSurvivesSocketDrop.spec.ts and the remaining pin in agentApprovalSurvivesSocketDrop.spec.ts are un-failed, and the new (g3)–(g22) unit cases are present.

Deliberate adaptations

  • Thread storage. Kept this branch's module-local THREAD_STORAGE_KEY. Workspace-scoped StorageKeys.agentThread() and the clearLegacyAgentStorage() migration are an unrelated main-only change, so forgetDeletedThread clears the unscoped key.
  • Error reporting. The recovery job's reportError omits surface, which is not a field of this branch's ReportErrorOptions; it matches the other call site in the same file.
  • start() / hydrateFromServer(). Release signatures kept. Only the everLive → connection state machine and the reconcileLiveTurns() call are taken — readyThreadId, the restore option, initializeWorkflowContext and the workflow.restored boolean contract are main-only and are context lines in fix(agent): keep the turn live across a socket reconnect and reconcile from REST (PM-1199) #18152's diff, not part of it.
  • handleMessageDone(event.data) → markStoppedTurnReady(turn), so the websocket path and the reconcile path share one gate, as on main.
  • Omitted: main-only stop/workflow-bound telemetry and their tests.
  • Cloud-only pin. This branch had already replaced the second approval case's body-level test.fail() with a try/catch soft pin around the visibility assertion. Both forms are removed, so a regression there reddens instead of reading as expected.
  • Added release coverage: (g15) now asserts this branch's observables for a deleted thread — thread id cleared, workflow binding dropped, Comfy.Agent.ThreadId removed, next send opens a new thread — in place of main's workspace-scoping and onThreadActivated assertions.

Verification

Run locally at 48cad21ba on Node 26:

  • pnpm typecheck — pass (was 16 errors)
  • pnpm lint — pass, 0 problems
  • pnpm knip — pass
  • pnpm format — no changes
  • pnpm vitest run src/workbench/extensions/agent — 127 files, 2 170 passed, 2 expected-fail (pre-existing CRDT pins, unrelated)
  • Playwright pins need the cloud fixture and were not run locally.

Original: #18152

@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR greenlight labels Oct 1, 2026
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 397c613e-0c4c-4dc1-a333-ba364652ef41

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/01/2026, 08:40:53 AM UTC

Links

🎭 Playwright: ✅ 2140 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2119 / ❌ 0 / ⚠️ 0 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 8be3aff783d2cd1d386d7b9e74611672ae21097b

Full docs: ADR-DEVEX-LINT-0015

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.5 MB heap
dom-widget-order-dense-n200-w200-i120: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 543ms TBT · 102.0 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 229ms TBT · 86.3 MB heap
extension-clean-combined-draw: · 50.0 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 1048ms TBT · 69.7 MB heap
extension-rgthree-prototype-draw: · 51.4 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 1192ms TBT · 79.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.4 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.5 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.4 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 141ms TBT · 99.1 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.0 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 159.2 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 84ms TBT · 167.5 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 254ms TBT · 172.9 MB heap
vue-zoom-out-idle: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 180.3 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.0 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 399ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 70.6 MB
canvas-idle: DOM nodes -261
canvas-idle: event listeners -152
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 0ms
canvas-mouse-sweep: style recalc duration 14ms
canvas-mouse-sweep: layout count 0
canvas-mouse-sweep: style recalc count 45
canvas-mouse-sweep: task duration 782ms
canvas-mouse-sweep: script duration 160ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 67.0 MB
canvas-mouse-sweep: DOM nodes -261
canvas-mouse-sweep: event listeners -163
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 15ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 267ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 67.5 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 428ms
dom-widget-clipping: script duration 168ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 82.5 MB
dom-widget-clipping: DOM nodes 21
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 17ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 789ms
dom-widget-order-dense-n200-w200-i120: script duration 68ms
dom-widget-order-dense-n200-w200-i120: TBT 543ms
dom-widget-order-dense-n200-w200-i120: heap used 102.0 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 473ms
dom-widget-order-sparse-n1000-w20-i120: script duration 165ms
dom-widget-order-sparse-n1000-w20-i120: TBT 229ms
dom-widget-order-sparse-n1000-w20-i120: heap used 86.3 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 20ms
extension-clean-combined-draw: p95 frame time 50ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 9413ms
extension-clean-combined-draw: script duration 7752ms
extension-clean-combined-draw: TBT 1048ms
extension-clean-combined-draw: heap used 69.7 MB
extension-clean-combined-draw: DOM nodes -14
extension-clean-combined-draw: event listeners 0
extension-rgthree-prototype-draw: avg frame time 19ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 0
extension-rgthree-prototype-draw: task duration 9673ms
extension-rgthree-prototype-draw: script duration 8173ms
extension-rgthree-prototype-draw: TBT 1192ms
extension-rgthree-prototype-draw: heap used 79.9 MB
extension-rgthree-prototype-draw: DOM nodes -9
extension-rgthree-prototype-draw: event listeners 0
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 567ms
large-graph-idle: script duration 35ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 79.9 MB
large-graph-idle: DOM nodes -242
large-graph-idle: event listeners -163
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 70
large-graph-pan: task duration 1595ms
large-graph-pan: script duration 855ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 74.4 MB
large-graph-pan: DOM nodes -244
large-graph-pan: event listeners -163
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 64
large-graph-zoom: task duration 1692ms
large-graph-zoom: script duration 777ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 70.5 MB
large-graph-zoom: DOM nodes -254
large-graph-zoom: event listeners -87
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 43
legacy-node-drag: task duration 1941ms
legacy-node-drag: script duration 998ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 75.4 MB
legacy-node-drag: DOM nodes 5
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 8ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 590ms
minimap-idle: script duration 34ms
minimap-idle: TBT 0ms
minimap-idle: heap used 77.3 MB
minimap-idle: DOM nodes -248
minimap-idle: event listeners -174
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 392ms
subgraph-dom-widget-clipping: script duration 142ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 80.0 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 444ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 58.4 MB
subgraph-idle: DOM nodes -277
subgraph-idle: event listeners -209
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 0ms
subgraph-mouse-sweep: style recalc duration 15ms
subgraph-mouse-sweep: layout count 0
subgraph-mouse-sweep: style recalc count 46
subgraph-mouse-sweep: task duration 672ms
subgraph-mouse-sweep: script duration 104ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 65.4 MB
subgraph-mouse-sweep: DOM nodes -276
subgraph-mouse-sweep: event listeners -209
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 29ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 17
subgraph-transition-enter: task duration 892ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 141ms
subgraph-transition-enter: heap used 99.1 MB
subgraph-transition-enter: DOM nodes 13667
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 36ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 5862ms
viewport-pan-sweep: script duration 2886ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 78.0 MB
viewport-pan-sweep: DOM nodes -241
viewport-pan-sweep: event listeners -152
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16277ms
vue-large-graph-idle: script duration 248ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 159.2 MB
vue-large-graph-idle: DOM nodes -8061
vue-large-graph-idle: event listeners -14928
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 151
vue-large-graph-pan: task duration 20029ms
vue-large-graph-pan: script duration 960ms
vue-large-graph-pan: TBT 84ms
vue-large-graph-pan: heap used 167.5 MB
vue-large-graph-pan: DOM nodes -8062
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 80ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5264ms
vue-node-resize-workload: script duration 101ms
vue-node-resize-workload: TBT 254ms
vue-node-resize-workload: heap used 172.9 MB
vue-node-resize-workload: DOM nodes -8061
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8109ms
vue-zoom-out-idle: script duration 127ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 180.3 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 22ms
workflow-execution: layout count 4
workflow-execution: style recalc count 14
workflow-execution: task duration 112ms
workflow-execution: script duration 12ms
workflow-execution: TBT 0ms
workflow-execution: heap used 67.0 MB
workflow-execution: DOM nodes 140
workflow-execution: event listeners 49
Raw data
{
  "timestamp": "2026-10-01T08:52:38.907Z",
  "gitSha": "24210a806dc0023963d376decb398dcd9ac0a5ce",
  "branch": "backport-18152-to-cloud-1.55",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 1991.2459999999896,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.796,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 352.9129999999999,
      "heapDeltaBytes": 8762116,
      "heapUsedBytes": 76290200,
      "domNodes": -259,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.700000000000002,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2017.4090000000433,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.320999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 445.208,
      "heapDeltaBytes": 4041020,
      "heapUsedBytes": 71813020,
      "domNodes": -262,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 8.333,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1735.7269999999971,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 13.302000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 774.341,
      "heapDeltaBytes": 10654064,
      "heapUsedBytes": 78272948,
      "domNodes": -262,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 160.251,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1741.6629999999031,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 14.383,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 790.3039999999999,
      "heapDeltaBytes": -5553360,
      "heapUsedBytes": 62187000,
      "domNodes": -260,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 159.53199999999998,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1709.2839999999683,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 13.13,
      "layouts": 6,
      "layoutDurationMs": 1.0270000000000001,
      "taskDurationMs": 253.37699999999995,
      "heapDeltaBytes": 3131352,
      "heapUsedBytes": 70756156,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.496000000000002,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1724.7830000000022,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.596,
      "layouts": 6,
      "layoutDurationMs": 1.3000000000000003,
      "taskDurationMs": 281.436,
      "heapDeltaBytes": 3154224,
      "heapUsedBytes": 70835988,
      "domNodes": 79,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 12.216000000000005,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 607.6819999999543,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 9.376000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 410.235,
      "heapDeltaBytes": 18956824,
      "heapUsedBytes": 86725548,
      "domNodes": 22,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 167.44899999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 633.6679999999433,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.452,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 445.202,
      "heapDeltaBytes": 18641092,
      "heapUsedBytes": 86375028,
      "domNodes": 20,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 169.31,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1159.2389999999568,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 814.354,
      "heapDeltaBytes": 38193320,
      "heapUsedBytes": 107809620,
      "domNodes": 0,
      "jsHeapTotalBytes": 19034112,
      "scriptDurationMs": 67.94600000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 548,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1178.2359999999699,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 763.6379999999999,
      "heapDeltaBytes": 34381632,
      "heapUsedBytes": 106113508,
      "domNodes": 0,
      "jsHeapTotalBytes": 18247680,
      "scriptDurationMs": 67.609,
      "eventListeners": 0,
      "totalBlockingTimeMs": 538,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 861.7939999999749,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 479.67199999999985,
      "heapDeltaBytes": 14668888,
      "heapUsedBytes": 91100780,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 163.63,
      "eventListeners": 0,
      "totalBlockingTimeMs": 232,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 847.4889999999959,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 465.77799999999934,
      "heapDeltaBytes": 14926468,
      "heapUsedBytes": 89986904,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 166.97,
      "eventListeners": 0,
      "totalBlockingTimeMs": 225,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10666.839999999978,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9765.234,
      "heapDeltaBytes": -9115076,
      "heapUsedBytes": 72779564,
      "domNodes": -14,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 8079.689,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1227,
      "frameDurationMs": 19.996666666666716,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9984.243000000106,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9061.025,
      "heapDeltaBytes": -8296248,
      "heapUsedBytes": 73418828,
      "domNodes": -14,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 7423.776,
      "eventListeners": 0,
      "totalBlockingTimeMs": 869,
      "frameDurationMs": 20,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 10889.60499999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9922.383,
      "heapDeltaBytes": 8454464,
      "heapUsedBytes": 82999904,
      "domNodes": -4,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 8534.339,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1471,
      "frameDurationMs": 18.886666666666677,
      "p95FrameDurationMs": 49.89999999999782
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 10249.865999999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9423.096,
      "heapDeltaBytes": 2307696,
      "heapUsedBytes": 84534604,
      "domNodes": -14,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 7811.843000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 913,
      "frameDurationMs": 20,
      "p95FrameDurationMs": 50
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2037.5549999999976,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.011999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 587.0920000000001,
      "heapDeltaBytes": -3746692,
      "heapUsedBytes": 83671600,
      "domNodes": -240,
      "jsHeapTotalBytes": -1019904,
      "scriptDurationMs": 38.469,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2013.7640000000374,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.5230000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 547.687,
      "heapDeltaBytes": -3372584,
      "heapUsedBytes": 83805436,
      "domNodes": -243,
      "jsHeapTotalBytes": -495616,
      "scriptDurationMs": 30.688999999999993,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2242.287000000033,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.879000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1485.824,
      "heapDeltaBytes": 12062364,
      "heapUsedBytes": 76347012,
      "domNodes": -242,
      "jsHeapTotalBytes": 1536000,
      "scriptDurationMs": 844.299,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2273.1280000000424,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 15.012,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1703.4750000000001,
      "heapDeltaBytes": -8055564,
      "heapUsedBytes": 79685492,
      "domNodes": -246,
      "jsHeapTotalBytes": 1302528,
      "scriptDurationMs": 865.232,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3484.4039999999836,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 11.250000000000004,
      "layouts": 60,
      "layoutDurationMs": 12.715999999999998,
      "taskDurationMs": 1654.2389999999998,
      "heapDeltaBytes": 8418836,
      "heapUsedBytes": 74263460,
      "domNodes": -254,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 773.514,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3511.6729999999734,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 14.299999999999997,
      "layouts": 60,
      "layoutDurationMs": 12.81,
      "taskDurationMs": 1729.781,
      "heapDeltaBytes": -15858500,
      "heapUsedBytes": 73496352,
      "domNodes": -254,
      "jsHeapTotalBytes": -495616,
      "scriptDurationMs": 779.7610000000001,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3158.2670000000235,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 6.286,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1948.645,
      "heapDeltaBytes": -2223640,
      "heapUsedBytes": 66054356,
      "domNodes": 6,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 997.113,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3141.9199999999137,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 6.459999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1932.843,
      "heapDeltaBytes": 25554104,
      "heapUsedBytes": 92031908,
      "domNodes": 4,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 998.927,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2056.498999999974,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.558999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 599.829,
      "heapDeltaBytes": -6454388,
      "heapUsedBytes": 82507672,
      "domNodes": -245,
      "jsHeapTotalBytes": 28672,
      "scriptDurationMs": 35.001000000000005,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2029.9300000000358,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.074000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 579.908,
      "heapDeltaBytes": -9965652,
      "heapUsedBytes": 79635664,
      "domNodes": -250,
      "jsHeapTotalBytes": -233472,
      "scriptDurationMs": 32.014,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 560.3909999999814,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.445999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 390.353,
      "heapDeltaBytes": 14089292,
      "heapUsedBytes": 84116640,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 142.399,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 575.2229999999372,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.781000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 394.419,
      "heapDeltaBytes": 13959508,
      "heapUsedBytes": 83706448,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 142.042,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1998.4170000000177,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.923000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 436.384,
      "heapDeltaBytes": -13885328,
      "heapUsedBytes": 55979972,
      "domNodes": -277,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 6.784999999999999,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1989.908000000014,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.142999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 451.63000000000005,
      "heapDeltaBytes": -3608452,
      "heapUsedBytes": 66505512,
      "domNodes": -276,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 6.634000000000001,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1690.8179999999788,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 15.889000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 718.955,
      "heapDeltaBytes": -9215088,
      "heapUsedBytes": 59924424,
      "domNodes": -276,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 104.13,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1693.3370000000423,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 14.701,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 625.217,
      "heapDeltaBytes": 7583632,
      "heapUsedBytes": 77306268,
      "domNodes": -276,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 103.735,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1401.0430000000724,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 29.083000000000006,
      "layouts": 5,
      "layoutDurationMs": 13.203,
      "taskDurationMs": 892.367,
      "heapDeltaBytes": 20270128,
      "heapUsedBytes": 103925904,
      "domNodes": 13667,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 29.077999999999992,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 141,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8326.784999999973,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 34.948,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5716.062,
      "heapDeltaBytes": -10076272,
      "heapUsedBytes": 77012900,
      "domNodes": -242,
      "jsHeapTotalBytes": 1007616,
      "scriptDurationMs": 2782.5370000000003,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8555.202000000008,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 37.442,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6007.446,
      "heapDeltaBytes": -779604,
      "heapUsedBytes": 86545124,
      "domNodes": -240,
      "jsHeapTotalBytes": 1531904,
      "scriptDurationMs": 2989.082,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16783.85300000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16303.097999999998,
      "heapDeltaBytes": -72703868,
      "heapUsedBytes": 165625276,
      "domNodes": -8061,
      "jsHeapTotalBytes": -16187392,
      "scriptDurationMs": 251.31199999999998,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16802.430000000073,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16251.750000000002,
      "heapDeltaBytes": -57761548,
      "heapUsedBytes": 168206900,
      "domNodes": -8061,
      "jsHeapTotalBytes": -9445376,
      "scriptDurationMs": 245.547,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20374.124999999993,
      "styleRecalcs": 143,
      "styleRecalcDurationMs": 20.551999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20185.293999999998,
      "heapDeltaBytes": -60821504,
      "heapUsedBytes": 181496276,
      "domNodes": -8061,
      "jsHeapTotalBytes": -18526208,
      "scriptDurationMs": 982.933,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 129,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20166.976999999973,
      "styleRecalcs": 158,
      "styleRecalcDurationMs": 16.239000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19872.642000000003,
      "heapDeltaBytes": -71673176,
      "heapUsedBytes": 169809536,
      "domNodes": -8062,
      "jsHeapTotalBytes": -17764352,
      "scriptDurationMs": 936.555,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 39,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6079.132999999956,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 81.82699999999998,
      "layouts": 20,
      "layoutDurationMs": 23.94700000000001,
      "taskDurationMs": 5969.562000000001,
      "heapDeltaBytes": -65459456,
      "heapUsedBytes": 175117840,
      "domNodes": -8061,
      "jsHeapTotalBytes": 11554816,
      "scriptDurationMs": 109.98399999999998,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 380,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4649.566999999934,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 79.07000000000001,
      "layouts": 20,
      "layoutDurationMs": 23.28699999999999,
      "taskDurationMs": 4557.907999999999,
      "heapDeltaBytes": -29297736,
      "heapUsedBytes": 187404064,
      "domNodes": -8061,
      "jsHeapTotalBytes": 22695936,
      "scriptDurationMs": 92.31800000000001,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 128,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8329.054000000042,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8177.1500000000015,
      "heapDeltaBytes": 19204720,
      "heapUsedBytes": 198736960,
      "domNodes": 0,
      "jsHeapTotalBytes": -12058624,
      "scriptDurationMs": 130.37499999999991,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8309.212000000003,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8039.852000000002,
      "heapDeltaBytes": 20556352,
      "heapUsedBytes": 179461088,
      "domNodes": 0,
      "jsHeapTotalBytes": -12320768,
      "scriptDurationMs": 124.4059999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 478.48099999998794,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 27.601,
      "layouts": 4,
      "layoutDurationMs": 2.1879999999999997,
      "taskDurationMs": 147.12800000000001,
      "heapDeltaBytes": 5417500,
      "heapUsedBytes": 71413168,
      "domNodes": 153,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 18.417999999999996,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 99.38399999998637,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 16.585,
      "layouts": 3,
      "layoutDurationMs": 1.692,
      "taskDurationMs": 77.49399999999999,
      "heapDeltaBytes": 3032184,
      "heapUsedBytes": 69064928,
      "domNodes": 126,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 5.994999999999998,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 52478 79392 66.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.8% 1153
src/LGraphNode.ts 70.5% 382
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/platform/workspace/stores/billingOperationStore.ts 8.0% 332
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/LGraph.ts 79.2% 267
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/core/billing/operationLifecycle.ts 1.2% 252
src/scripts/app.ts 73.2% 252
src/scripts/pnginfo.ts 20.7% 222

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

@github-actions
github-actions Bot requested a review from ryan-di October 1, 2026 04:50
@datadog-official

This comment has been minimized.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 1, 2026
@christian-byrne
christian-byrne requested a review from DrJKL October 1, 2026 05:12
…e from REST (PM-1199) (#18152)

Manual backport of #18152 to cloud/1.55.

A transient websocket reconnect no longer abandons the running agent turn;
the client keeps the turn live and reconciles its outcome from REST once the
socket is back, within a bounded recovery job (six polls on a 0/1/2/4/8/16-second
backoff under a 60-second whole-job deadline); past that window the live socket
is trusted to deliver the terminal event.

Release-branch adaptations (cloud/1.55 lacks the main-only APIs #18152 was
written against):

- Thread storage stays on this branch's module-local `THREAD_STORAGE_KEY`.
  Workspace-scoped `StorageKeys.agentThread()` and the `clearLegacyAgentStorage()`
  migration are an unrelated main-only change, so `forgetDeletedThread` clears
  the unscoped key.
- `reportError` for a failed recovery job omits `surface`, which is not a field
  of this branch's `ReportErrorOptions`; it matches the other call sites in this
  file.
- `start()` and `hydrateFromServer()` keep their release signatures. Only the
  `everLive` -> `connection` state machine and the `reconcileLiveTurns()` call
  are taken; `readyThreadId`, the `restore` option, `initializeWorkflowContext`
  and the `workflow.restored` boolean contract are main-only.
- `handleMessageDone(event.data)` becomes `markStoppedTurnReady(turn)` so the WS
  path and the reconcile path share one gate, as on main.
- Main-only `trackAgentStopClicked`/`trackAgentWorkflowBound` telemetry and the
  `turnStartedAt` timing rework are not brought along, and their tests are
  omitted.
- (g15) asserts the release branch's observables for a deleted thread — thread
  id cleared, workflow binding dropped, `Comfy.Agent.ThreadId` removed, next
  send opens a new thread — in place of main's workspace-scoping and
  `onThreadActivated` assertions.
- Cloud-only: the second approval spec case guarded its visibility assertion
  with a try/catch `test.fail()` soft pin instead of main's body-level
  `test.fail()`. Both are removed, so a regression there reddens rather than
  reading as expected.

Original: #18152

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 10 finding(s).

Severity Count
🟠 High 4
🟡 Medium 6

Panel: 8/8 reviewers contributed findings.

)
accepted = true
if (generation !== loadGeneration) return true
if (generation !== loadGeneration) return false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High — performSend now returns false even when the server accepted the turn: this post-ack generation guard used to return true, and the new catch at line 853 returns false unconditionally — including when accepted is true or isUnreadableAckFailure(error) holds. useAgentDraftSubmission reads sent === false as a failed submission, so it restores the prompt (inviting a duplicate POST that hits the 409 single-active-turn lock) and skips its sent && stopRequested branch, silently discarding a Stop clicked during the POST while the accepted turn keeps running untracked.

Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case).

)
return false
if (priorVisible === true || (priorVisible === false && !visible)) return
malformedStreamReports.set(turnId, visible)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High — This dedupe map lost both of its guards: the 32-entry size cap and the conversationStore.hasPendingTurn(turnId) validation that kept unrecognised ids out of reportedTurnId. Keys are now raw wire message_id strings cleared only on newChat/loadThread, so a buggy or hostile stream of malformed frames with distinct ids grows the map without bound and emits one reportError plus one trackAgentError per id — and the diff deletes the test that pinned exactly this (does not trust attacker-controlled message ids as telemetry keys). Reinstate a size cap and/or validate the id before using it as a key.

Raised by 5 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).

conversationStore.setThreadId(ack.thread_id)
localStorage.setItem(THREAD_STORAGE_KEY, ack.thread_id)
onThreadActivated?.(ack.thread_id)
localStorage.setItem(threadStorageKey, ack.thread_id)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High — This persistence write runs before recordUser/startTurn, so if setItem throws (quota exceeded, storage disabled, private mode) the exception escapes acceptTurn into performSend's catch and the acknowledged turn is never registered locally: every WS frame for it is dropped and the client holds no id to cancel it with, while the server keeps running the turn. The diff's own test change (expect(ok).toBe(true) → toBe(false) under a throwing setItem) locks that in; make the write best-effort, after the turn bookkeeping.

Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, gemini-3.1-pro adversarial).

// A live `agent_tool_call` frame keys its update on `tool_call_id`, so a
// restored part uses the same id to match a live frame that arrives for
// it later.
callId: toolCallId,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High — Dropping the ?? id fallback while zPersistedToolCallSummary.tool_call_id remains z.string().optional() yields callId: undefined, which violates ToolPart.callId: string and makes parseToolCalls key every legacy call in a row under the same undefined map entry, collapsing them into a single part. Either restore the ?? id fallback or make tool_call_id required in the schema so the type and the data agree.

Raised by 4 of 8 reviewers (gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).

if (turnId === undefined || turnId === conversationStore.activeTurnId) {
forgetActiveTurnStartedAt()
conversationStore.abortActiveTurn()
pushError(i18n.global.t('agent.malformedEvent'))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — pushError is now unconditional for every malformed agent_message_done, where it previously only ran when trackMalformedStreamEvent reported the event as not already deduped. AgentPanelRoot watches notices and surfaces each new entry, so a backend schema drift that malforms this frame type raises one error overlay per frame and grows notices without bound; the diff deletes the expect(session.notices.value).toHaveLength(2) assertion from the 20-frame test rather than preserving the bound.

Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case, kimi-k3-max edge-case).

message
}))
}
context: { issues: cause.issues }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — The entire ZodError issue tree now goes to the error sinks (reportError forwards context into Sentry extra and datadogRum.addError), replacing a projection that capped at 10 issues and kept only {code, path, message}. Zod issues carry the offending value in received and, for a discriminated union like zAgentWsEvent, nested unionErrors, so unbounded unsanitized agent-stream content now leaves the browser; the deleted assertion expect(Object.keys(issue).sort()).toEqual(['code','message','path']) existed to hold that projection in place.

Raised by 5 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).

duration_ms: true
})
.safeParse(entry)
const parsed = zPersistedToolCallSummary.safeParse(entry)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — Validating the whole zPersistedToolCallSummary instead of a .pick() of the five fields this function reads re-exposes every other field as a gate — the removed comment and agentApiSchema.ts both state the pick existed so that an unrelated strict field (e.g. a started_at/finished_at datetime) could never sink an otherwise-usable entry. A historical row that omits or mistypes one of those unread fields now fails safeParse, so its tool call vanishes silently from the restored transcript.

Raised by 4 of 8 reviewers (gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).

onAskResolved,
workflow
} = deps
const threadStorageKey = StorageKeys.agentThread(getWorkspaceId())

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — threadStorageKey is resolved once at composable construction, freezing the workspace scope for the session's whole lifetime, against getWorkspaceId's documented contract that it be read fresh because the workspace auth store may not have written sessionStorage yet. A panel constructed inside that window resolves to personal and then persists, restores, and deletes the team workspace's agent thread under the personal key — defeating the scoping this change adds — and an in-app workspace switch that does not remount the panel has the same effect.

Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case).

message.parts = message.parts.filter((part) => part.type !== 'runApproval')
return
}
message.parts = interleaveLocalParts(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — interleaveLocalParts replaces message.parts wholesale and anchorLocalParts re-anchors only the non-text, non-tool parts, so whatever fetchTurnOutcome returns becomes the entire reply. isTerminalTurnStatus accepts error and interrupted and appendAssistantContent pushes a text part only if (text), so a terminal row with no persisted content yields parts: [] and erases the partial reply the user was reading. The thread-missing path deliberately passes undefined to keep local parts; this path needs an equivalent guard against an empty persisted result.

Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).

): boolean | undefined {
if (state === 'streaming') return undefined
return status === 'success' || status === 'ok'
return status === 'success'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — Dropping the || status === 'ok' alias makes every historical row recorded with the older success value render as a failed tool call. zPersistedToolCallSummary.status is still z.string(), so those rows validate and reach this function, and the schema's doc comment still names 'ok' as an older success alias — so a past action that succeeded is now shown to the user as an error.

Raised by 4 of 8 reviewers (gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).

@christian-byrne
christian-byrne force-pushed the backport-18152-to-cloud-1.55 branch from 02b60f5 to 48cad21 Compare October 1, 2026 05:29
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Rebuilt this head from scratch rather than patching the previous one.

Root cause. The earlier cherry-pick resolved useAgentSession.ts, agentTranscript.ts and agentConversationStore.ts toward main's whole-file state instead of #18152's own delta, so it imported main-only drift the reconnect fix has no dependency on: workspace-scoped agent thread storage (StorageKeys.agentThread + clearLegacyAgentStorage), trackAgentStopClicked / trackAgentWorkflowBound, ReportErrorOptions.surface, and the turnStartedAt timing rework. Upstream changed useAgentSession.ts by +223/-26; that resolution changed it by +618/-240. All 16 typecheck errors were in that imported surface, none in the reconnect logic — a dependency-incomplete backport, not a flaky run.

What changed. Fresh cherry-pick of #18152 onto the release branch, resolved against the APIs the branch actually has. Nine of the eleven files are now byte-identical to the upstream delta; the two that differ do so only where the release branch's own API required it, enumerated in the PR body. The reconnect regression coverage the previous repair deleted is fully restored — all test.fail() pins un-failed and the (g3)–(g22) unit cases present — with (g15) rewritten to assert this branch's observables for a deleted thread instead of main's workspace-scoping.

Gates run locally. pnpm typecheck, pnpm lint (0 problems), pnpm knip, pnpm format (no changes) all pass, and pnpm vitest run src/workbench/extensions/agent is green across 127 files. The Playwright pins need the cloud fixture and were not run locally. Not merging while required checks are in flight.

@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.39655% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...sions/agent/stores/agent/agentConversationStore.ts 90.56% 10 Missing ⚠️
...ensions/agent/composables/agent/useAgentSession.ts 97.47% 3 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.55   #19695   +/-   ##
=============================================
  Coverage              ?   84.64%           
=============================================
  Files                 ?     2315           
  Lines                 ?   132048           
  Branches              ?    35280           
=============================================
  Hits                  ?   111767           
  Misses                ?    19921           
  Partials              ?      360           
Flag Coverage Δ
e2e 66.13% <ø> (?)
unit 80.59% <94.39%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...extensions/agent/services/agent/agentRestClient.ts 99.37% <100.00%> (ø)
...extensions/agent/services/agent/agentTranscript.ts 97.70% <100.00%> (ø)
...ensions/agent/composables/agent/useAgentSession.ts 98.43% <97.47%> (ø)
...sions/agent/stores/agent/agentConversationStore.ts 95.58% <90.56%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Playwright videos for new tests

Download the recorded videos and HTML report

Recorded projects: cloud

Recorded test titles:

  • all tests in browser_tests/tests/agent/agentApprovalSurvivesSocketDrop.spec.ts
  • all tests in browser_tests/tests/agent/agentTurnSurvivesSocketDrop.spec.ts

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: Request changes. The port of #18152 is faithful, with every adaptation accounted for, except that it drops the source's one-line SessionNotice un-export.

I compared this branch, against its merge base 829fb7e, with #18152's merged diff (d90c109 against its parent 1519cc0). The branch merges cleanly into the current cloud/1.55 tip, 931c6d1.

What matches:

  • Seven files carry exactly the source's added and removed lines: agentTurnLockFixture.ts, agentTurnSurvivesSocketDrop.spec.ts, agentRestClient.ts and its test, agentTranscript.test.ts, and agentConversationStore.ts and its test.
  • Every other difference is an adaptation I could tie to the target:
    • The unscoped THREAD_STORAGE_KEY replaces StorageKeys.agentThread(), because workspace-scoped thread storage is not on cloud/1.55.
    • onThreadActivated?.(null) and turnStartedAt.clear() are dropped, because neither exists here.
    • reportError omits surface, because this branch's ReportErrorOptions has no such field.
    • The release's handleMessageDone(event.data) becomes the source's markStoppedTurnReady(turn), with the same guard.
    • The toolCallPartState comment edit is applied to this branch's wording of that comment.
    • In the approval spec, the second case's soft pin is removed. This branch had a try/catch test.fail() there where main had a bare one.
    • (g15) asserts this branch's unscoped key in place of the workspace-scoped key and onThreadActivated.
  • All 22 source test additions are present, and the it.fails / test.fail pins are un-failed.
  • At 48cad21: vitest run over useAgentSession.test.ts, services/agent/, and stores/agent/ passed 520/520 across 22 files. All hosted checks at this head passed.

What diverges is inline.

import type { LiveTurn } from '../../stores/agent/agentConversationStore'
import { useAgentConversationStore } from '../../stores/agent/agentConversationStore'
import { useAgentWorkflowTabBindingStore } from '../../stores/agent/agentWorkflowTabBindingStore'
import type { WorkflowReference } from '../../types/workflowReference'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is about line 50, just outside this hunk. #18152 changes export interface SessionNotice to interface SessionNotice, and this branch keeps the export. On cloud/1.55, as on main, nothing outside useAgentSession.ts imports SessionNotice, so the target needs no change here. Please carry the un-export.

@christian-byrne christian-byrne Oct 1, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carried the visibility hunk in commit 4b50b4c.

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: Approve. This is a faithful backport of #18152 to cloud/1.55, with each adaptation accounted for by the target.

I compared this branch, at 4b50b4c against its merge base 829fb7e, with #18152's merged diff (d90c109 against its parent 1519cc0). The branch merges cleanly into the current cloud/1.55 tip, 8be3aff. 4b50b4c carries the SessionNotice un-export, which resolves my earlier comment.

Seven files carry exactly the source's added and removed lines: agentTurnLockFixture.ts, agentTurnSurvivesSocketDrop.spec.ts, agentRestClient.ts and its test, agentTranscript.test.ts, and agentConversationStore.ts and its test.

Adaptations:

  • The unscoped THREAD_STORAGE_KEY replaces StorageKeys.agentThread() in forgetDeletedThread, and (g15) asserts that key. Workspace-scoped thread storage is not on cloud/1.55.
  • onThreadActivated?.(null) is dropped, and so is the matching (g15) assertion, because that dependency does not exist here.
  • turnStartedAt.clear() is dropped, because that timing map is main-only.
  • The recovery job's reportError omits surface, because this branch's ReportErrorOptions has no such field.
  • The release's handleMessageDone(event.data) becomes the source's markStoppedTurnReady(turn), with the same thread and turn guard, called from the agent_message_done branch.
  • The toolCallPartState doc-comment edit is applied to this branch's wording of that comment.
  • In the approval spec, this branch's try/catch test.fail() soft pin in the second case is removed. main has a bare test.fail() there, and the source removes it.

All 22 source test additions are present, and the it.fails / test.fail pins are un-failed.

Checks: at 4b50b4c, vitest run over useAgentSession.test.ts, services/agent/, and stores/agent/ passed 520/520 across 22 files, and vue-tsc --noEmit passed. All hosted checks at this head passed.

@DrJKL DrJKL assigned christian-byrne and unassigned DrJKL Oct 1, 2026
@comfy-pr-bot
comfy-pr-bot merged commit 4698ff5 into cloud/1.55 Oct 1, 2026
105 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-18152-to-cloud-1.55 branch October 1, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR greenlight risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants