Repository navigation
[backport cloud/1.55] fix(agent): keep the turn live across a socket reconnect - #19695
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2140 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 8be3aff783d2cd1d386d7b9e74611672ae21097b
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-01T08:52:38.907Z",
"gitSha": "24210a806dc0023963d376decb398dcd9ac0a5ce",
"branch": "backport-18152-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1991.2459999999896,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.796,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.9129999999999,
"heapDeltaBytes": 8762116,
"heapUsedBytes": 76290200,
"domNodes": -259,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.700000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2017.4090000000433,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.320999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.208,
"heapDeltaBytes": 4041020,
"heapUsedBytes": 71813020,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.333,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1735.7269999999971,
"styleRecalcs": 45,
"styleRecalcDurationMs": 13.302000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 774.341,
"heapDeltaBytes": 10654064,
"heapUsedBytes": 78272948,
"domNodes": -262,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 160.251,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1741.6629999999031,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.383,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 790.3039999999999,
"heapDeltaBytes": -5553360,
"heapUsedBytes": 62187000,
"domNodes": -260,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 159.53199999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.2839999999683,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.13,
"layouts": 6,
"layoutDurationMs": 1.0270000000000001,
"taskDurationMs": 253.37699999999995,
"heapDeltaBytes": 3131352,
"heapUsedBytes": 70756156,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.496000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.7830000000022,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.596,
"layouts": 6,
"layoutDurationMs": 1.3000000000000003,
"taskDurationMs": 281.436,
"heapDeltaBytes": 3154224,
"heapUsedBytes": 70835988,
"domNodes": 79,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.216000000000005,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 607.6819999999543,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.376000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.235,
"heapDeltaBytes": 18956824,
"heapUsedBytes": 86725548,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 167.44899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 633.6679999999433,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.452,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.202,
"heapDeltaBytes": 18641092,
"heapUsedBytes": 86375028,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 169.31,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1159.2389999999568,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 814.354,
"heapDeltaBytes": 38193320,
"heapUsedBytes": 107809620,
"domNodes": 0,
"jsHeapTotalBytes": 19034112,
"scriptDurationMs": 67.94600000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 548,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1178.2359999999699,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 763.6379999999999,
"heapDeltaBytes": 34381632,
"heapUsedBytes": 106113508,
"domNodes": 0,
"jsHeapTotalBytes": 18247680,
"scriptDurationMs": 67.609,
"eventListeners": 0,
"totalBlockingTimeMs": 538,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 861.7939999999749,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.67199999999985,
"heapDeltaBytes": 14668888,
"heapUsedBytes": 91100780,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.63,
"eventListeners": 0,
"totalBlockingTimeMs": 232,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.4889999999959,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.77799999999934,
"heapDeltaBytes": 14926468,
"heapUsedBytes": 89986904,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 166.97,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10666.839999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9765.234,
"heapDeltaBytes": -9115076,
"heapUsedBytes": 72779564,
"domNodes": -14,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8079.689,
"eventListeners": 0,
"totalBlockingTimeMs": 1227,
"frameDurationMs": 19.996666666666716,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9984.243000000106,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9061.025,
"heapDeltaBytes": -8296248,
"heapUsedBytes": 73418828,
"domNodes": -14,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 7423.776,
"eventListeners": 0,
"totalBlockingTimeMs": 869,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10889.60499999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9922.383,
"heapDeltaBytes": 8454464,
"heapUsedBytes": 82999904,
"domNodes": -4,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 8534.339,
"eventListeners": 0,
"totalBlockingTimeMs": 1471,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 49.89999999999782
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10249.865999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9423.096,
"heapDeltaBytes": 2307696,
"heapUsedBytes": 84534604,
"domNodes": -14,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7811.843000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 913,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2037.5549999999976,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.011999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 587.0920000000001,
"heapDeltaBytes": -3746692,
"heapUsedBytes": 83671600,
"domNodes": -240,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 38.469,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2013.7640000000374,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.5230000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.687,
"heapDeltaBytes": -3372584,
"heapUsedBytes": 83805436,
"domNodes": -243,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 30.688999999999993,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2242.287000000033,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.879000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1485.824,
"heapDeltaBytes": 12062364,
"heapUsedBytes": 76347012,
"domNodes": -242,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 844.299,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2273.1280000000424,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1703.4750000000001,
"heapDeltaBytes": -8055564,
"heapUsedBytes": 79685492,
"domNodes": -246,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 865.232,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3484.4039999999836,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.250000000000004,
"layouts": 60,
"layoutDurationMs": 12.715999999999998,
"taskDurationMs": 1654.2389999999998,
"heapDeltaBytes": 8418836,
"heapUsedBytes": 74263460,
"domNodes": -254,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 773.514,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3511.6729999999734,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.299999999999997,
"layouts": 60,
"layoutDurationMs": 12.81,
"taskDurationMs": 1729.781,
"heapDeltaBytes": -15858500,
"heapUsedBytes": 73496352,
"domNodes": -254,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 779.7610000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3158.2670000000235,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.286,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1948.645,
"heapDeltaBytes": -2223640,
"heapUsedBytes": 66054356,
"domNodes": 6,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 997.113,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3141.9199999999137,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.459999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1932.843,
"heapDeltaBytes": 25554104,
"heapUsedBytes": 92031908,
"domNodes": 4,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 998.927,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2056.498999999974,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.558999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 599.829,
"heapDeltaBytes": -6454388,
"heapUsedBytes": 82507672,
"domNodes": -245,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 35.001000000000005,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2029.9300000000358,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.074000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.908,
"heapDeltaBytes": -9965652,
"heapUsedBytes": 79635664,
"domNodes": -250,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 32.014,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 560.3909999999814,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.445999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.353,
"heapDeltaBytes": 14089292,
"heapUsedBytes": 84116640,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 142.399,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.2229999999372,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.781000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.419,
"heapDeltaBytes": 13959508,
"heapUsedBytes": 83706448,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 142.042,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1998.4170000000177,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.923000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.384,
"heapDeltaBytes": -13885328,
"heapUsedBytes": 55979972,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.784999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1989.908000000014,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.142999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.63000000000005,
"heapDeltaBytes": -3608452,
"heapUsedBytes": 66505512,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.634000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.8179999999788,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.889000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 718.955,
"heapDeltaBytes": -9215088,
"heapUsedBytes": 59924424,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 104.13,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.3370000000423,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.701,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 625.217,
"heapDeltaBytes": 7583632,
"heapUsedBytes": 77306268,
"domNodes": -276,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 103.735,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.0430000000724,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.083000000000006,
"layouts": 5,
"layoutDurationMs": 13.203,
"taskDurationMs": 892.367,
"heapDeltaBytes": 20270128,
"heapUsedBytes": 103925904,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 29.077999999999992,
"eventListeners": 2383,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8326.784999999973,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.948,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5716.062,
"heapDeltaBytes": -10076272,
"heapUsedBytes": 77012900,
"domNodes": -242,
"jsHeapTotalBytes": 1007616,
"scriptDurationMs": 2782.5370000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8555.202000000008,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.442,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6007.446,
"heapDeltaBytes": -779604,
"heapUsedBytes": 86545124,
"domNodes": -240,
"jsHeapTotalBytes": 1531904,
"scriptDurationMs": 2989.082,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16783.85300000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16303.097999999998,
"heapDeltaBytes": -72703868,
"heapUsedBytes": 165625276,
"domNodes": -8061,
"jsHeapTotalBytes": -16187392,
"scriptDurationMs": 251.31199999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16802.430000000073,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16251.750000000002,
"heapDeltaBytes": -57761548,
"heapUsedBytes": 168206900,
"domNodes": -8061,
"jsHeapTotalBytes": -9445376,
"scriptDurationMs": 245.547,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20374.124999999993,
"styleRecalcs": 143,
"styleRecalcDurationMs": 20.551999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20185.293999999998,
"heapDeltaBytes": -60821504,
"heapUsedBytes": 181496276,
"domNodes": -8061,
"jsHeapTotalBytes": -18526208,
"scriptDurationMs": 982.933,
"eventListeners": -14928,
"totalBlockingTimeMs": 129,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20166.976999999973,
"styleRecalcs": 158,
"styleRecalcDurationMs": 16.239000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19872.642000000003,
"heapDeltaBytes": -71673176,
"heapUsedBytes": 169809536,
"domNodes": -8062,
"jsHeapTotalBytes": -17764352,
"scriptDurationMs": 936.555,
"eventListeners": -14928,
"totalBlockingTimeMs": 39,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6079.132999999956,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.82699999999998,
"layouts": 20,
"layoutDurationMs": 23.94700000000001,
"taskDurationMs": 5969.562000000001,
"heapDeltaBytes": -65459456,
"heapUsedBytes": 175117840,
"domNodes": -8061,
"jsHeapTotalBytes": 11554816,
"scriptDurationMs": 109.98399999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 380,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 4649.566999999934,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.07000000000001,
"layouts": 20,
"layoutDurationMs": 23.28699999999999,
"taskDurationMs": 4557.907999999999,
"heapDeltaBytes": -29297736,
"heapUsedBytes": 187404064,
"domNodes": -8061,
"jsHeapTotalBytes": 22695936,
"scriptDurationMs": 92.31800000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 128,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8329.054000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8177.1500000000015,
"heapDeltaBytes": 19204720,
"heapUsedBytes": 198736960,
"domNodes": 0,
"jsHeapTotalBytes": -12058624,
"scriptDurationMs": 130.37499999999991,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8309.212000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8039.852000000002,
"heapDeltaBytes": 20556352,
"heapUsedBytes": 179461088,
"domNodes": 0,
"jsHeapTotalBytes": -12320768,
"scriptDurationMs": 124.4059999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 478.48099999998794,
"styleRecalcs": 21,
"styleRecalcDurationMs": 27.601,
"layouts": 4,
"layoutDurationMs": 2.1879999999999997,
"taskDurationMs": 147.12800000000001,
"heapDeltaBytes": 5417500,
"heapUsedBytes": 71413168,
"domNodes": 153,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 18.417999999999996,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 99.38399999998637,
"styleRecalcs": 7,
"styleRecalcDurationMs": 16.585,
"layouts": 3,
"layoutDurationMs": 1.692,
"taskDurationMs": 77.49399999999999,
"heapDeltaBytes": 3032184,
"heapUsedBytes": 69064928,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.994999999999998,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
This comment has been minimized.
This comment has been minimized.
…e from REST (PM-1199) (#18152) Manual backport of #18152 to cloud/1.55. A transient websocket reconnect no longer abandons the running agent turn; the client keeps the turn live and reconciles its outcome from REST once the socket is back, within a bounded recovery job (six polls on a 0/1/2/4/8/16-second backoff under a 60-second whole-job deadline); past that window the live socket is trusted to deliver the terminal event. Release-branch adaptations (cloud/1.55 lacks the main-only APIs #18152 was written against): - Thread storage stays on this branch's module-local `THREAD_STORAGE_KEY`. Workspace-scoped `StorageKeys.agentThread()` and the `clearLegacyAgentStorage()` migration are an unrelated main-only change, so `forgetDeletedThread` clears the unscoped key. - `reportError` for a failed recovery job omits `surface`, which is not a field of this branch's `ReportErrorOptions`; it matches the other call sites in this file. - `start()` and `hydrateFromServer()` keep their release signatures. Only the `everLive` -> `connection` state machine and the `reconcileLiveTurns()` call are taken; `readyThreadId`, the `restore` option, `initializeWorkflowContext` and the `workflow.restored` boolean contract are main-only. - `handleMessageDone(event.data)` becomes `markStoppedTurnReady(turn)` so the WS path and the reconcile path share one gate, as on main. - Main-only `trackAgentStopClicked`/`trackAgentWorkflowBound` telemetry and the `turnStartedAt` timing rework are not brought along, and their tests are omitted. - (g15) asserts the release branch's observables for a deleted thread — thread id cleared, workflow binding dropped, `Comfy.Agent.ThreadId` removed, next send opens a new thread — in place of main's workspace-scoping and `onThreadActivated` assertions. - Cloud-only: the second approval spec case guarded its visibility assertion with a try/catch `test.fail()` soft pin instead of main's body-level `test.fail()`. Both are removed, so a regression there reddens rather than reading as expected. Original: #18152
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 4 |
| 🟡 Medium | 6 |
Panel: 8/8 reviewers contributed findings.
| ) | ||
| accepted = true | ||
| if (generation !== loadGeneration) return true | ||
| if (generation !== loadGeneration) return false |
There was a problem hiding this comment.
🟠 High — performSend now returns false even when the server accepted the turn: this post-ack generation guard used to return true, and the new catch at line 853 returns false unconditionally — including when accepted is true or isUnreadableAckFailure(error) holds. useAgentDraftSubmission reads sent === false as a failed submission, so it restores the prompt (inviting a duplicate POST that hits the 409 single-active-turn lock) and skips its sent && stopRequested branch, silently discarding a Stop clicked during the POST while the accepted turn keeps running untracked.
Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case).
| ) | ||
| return false | ||
| if (priorVisible === true || (priorVisible === false && !visible)) return | ||
| malformedStreamReports.set(turnId, visible) |
There was a problem hiding this comment.
🟠 High — This dedupe map lost both of its guards: the 32-entry size cap and the conversationStore.hasPendingTurn(turnId) validation that kept unrecognised ids out of reportedTurnId. Keys are now raw wire message_id strings cleared only on newChat/loadThread, so a buggy or hostile stream of malformed frames with distinct ids grows the map without bound and emits one reportError plus one trackAgentError per id — and the diff deletes the test that pinned exactly this (does not trust attacker-controlled message ids as telemetry keys). Reinstate a size cap and/or validate the id before using it as a key.
Raised by 5 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| conversationStore.setThreadId(ack.thread_id) | ||
| localStorage.setItem(THREAD_STORAGE_KEY, ack.thread_id) | ||
| onThreadActivated?.(ack.thread_id) | ||
| localStorage.setItem(threadStorageKey, ack.thread_id) |
There was a problem hiding this comment.
🟠 High — This persistence write runs before recordUser/startTurn, so if setItem throws (quota exceeded, storage disabled, private mode) the exception escapes acceptTurn into performSend's catch and the acknowledged turn is never registered locally: every WS frame for it is dropped and the client holds no id to cancel it with, while the server keeps running the turn. The diff's own test change (expect(ok).toBe(true) → toBe(false) under a throwing setItem) locks that in; make the write best-effort, after the turn bookkeeping.
Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, gemini-3.1-pro adversarial).
| // A live `agent_tool_call` frame keys its update on `tool_call_id`, so a | ||
| // restored part uses the same id to match a live frame that arrives for | ||
| // it later. | ||
| callId: toolCallId, |
There was a problem hiding this comment.
🟠 High — Dropping the ?? id fallback while zPersistedToolCallSummary.tool_call_id remains z.string().optional() yields callId: undefined, which violates ToolPart.callId: string and makes parseToolCalls key every legacy call in a row under the same undefined map entry, collapsing them into a single part. Either restore the ?? id fallback or make tool_call_id required in the schema so the type and the data agree.
Raised by 4 of 8 reviewers (gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| if (turnId === undefined || turnId === conversationStore.activeTurnId) { | ||
| forgetActiveTurnStartedAt() | ||
| conversationStore.abortActiveTurn() | ||
| pushError(i18n.global.t('agent.malformedEvent')) |
There was a problem hiding this comment.
🟡 Medium — pushError is now unconditional for every malformed agent_message_done, where it previously only ran when trackMalformedStreamEvent reported the event as not already deduped. AgentPanelRoot watches notices and surfaces each new entry, so a backend schema drift that malforms this frame type raises one error overlay per frame and grows notices without bound; the diff deletes the expect(session.notices.value).toHaveLength(2) assertion from the 20-frame test rather than preserving the bound.
Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case, kimi-k3-max edge-case).
| message | ||
| })) | ||
| } | ||
| context: { issues: cause.issues } |
There was a problem hiding this comment.
🟡 Medium — The entire ZodError issue tree now goes to the error sinks (reportError forwards context into Sentry extra and datadogRum.addError), replacing a projection that capped at 10 issues and kept only {code, path, message}. Zod issues carry the offending value in received and, for a discriminated union like zAgentWsEvent, nested unionErrors, so unbounded unsanitized agent-stream content now leaves the browser; the deleted assertion expect(Object.keys(issue).sort()).toEqual(['code','message','path']) existed to hold that projection in place.
Raised by 5 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| duration_ms: true | ||
| }) | ||
| .safeParse(entry) | ||
| const parsed = zPersistedToolCallSummary.safeParse(entry) |
There was a problem hiding this comment.
🟡 Medium — Validating the whole zPersistedToolCallSummary instead of a .pick() of the five fields this function reads re-exposes every other field as a gate — the removed comment and agentApiSchema.ts both state the pick existed so that an unrelated strict field (e.g. a started_at/finished_at datetime) could never sink an otherwise-usable entry. A historical row that omits or mistypes one of those unread fields now fails safeParse, so its tool call vanishes silently from the restored transcript.
Raised by 4 of 8 reviewers (gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| onAskResolved, | ||
| workflow | ||
| } = deps | ||
| const threadStorageKey = StorageKeys.agentThread(getWorkspaceId()) |
There was a problem hiding this comment.
🟡 Medium — threadStorageKey is resolved once at composable construction, freezing the workspace scope for the session's whole lifetime, against getWorkspaceId's documented contract that it be read fresh because the workspace auth store may not have written sessionStorage yet. A panel constructed inside that window resolves to personal and then persists, restores, and deletes the team workspace's agent thread under the personal key — defeating the scoping this change adds — and an in-app workspace switch that does not remount the panel has the same effect.
Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case).
| message.parts = message.parts.filter((part) => part.type !== 'runApproval') | ||
| return | ||
| } | ||
| message.parts = interleaveLocalParts( |
There was a problem hiding this comment.
🟡 Medium — interleaveLocalParts replaces message.parts wholesale and anchorLocalParts re-anchors only the non-text, non-tool parts, so whatever fetchTurnOutcome returns becomes the entire reply. isTerminalTurnStatus accepts error and interrupted and appendAssistantContent pushes a text part only if (text), so a terminal row with no persisted content yields parts: [] and erases the partial reply the user was reading. The thread-missing path deliberately passes undefined to keep local parts; this path needs an equivalent guard against an empty persisted result.
Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
| ): boolean | undefined { | ||
| if (state === 'streaming') return undefined | ||
| return status === 'success' || status === 'ok' | ||
| return status === 'success' |
There was a problem hiding this comment.
🟡 Medium — Dropping the || status === 'ok' alias makes every historical row recorded with the older success value render as a failed tool call. zPersistedToolCallSummary.status is still z.string(), so those rows validate and reach this function, and the schema's doc comment still names 'ok' as an older success alias — so a past action that succeeded is now shown to the user as an error.
Raised by 4 of 8 reviewers (gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
02b60f5 to
48cad21
Compare
|
Rebuilt this head from scratch rather than patching the previous one. Root cause. The earlier cherry-pick resolved What changed. Fresh cherry-pick of #18152 onto the release branch, resolved against the APIs the branch actually has. Nine of the eleven files are now byte-identical to the upstream delta; the two that differ do so only where the release branch's own API required it, enumerated in the PR body. The reconnect regression coverage the previous repair deleted is fully restored — all Gates run locally. |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.55 #19695 +/- ##
=============================================
Coverage ? 84.64%
=============================================
Files ? 2315
Lines ? 132048
Branches ? 35280
=============================================
Hits ? 111767
Misses ? 19921
Partials ? 360
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: Request changes. The port of #18152 is faithful, with every adaptation accounted for, except that it drops the source's one-line SessionNotice un-export.
I compared this branch, against its merge base 829fb7e, with #18152's merged diff (d90c109 against its parent 1519cc0). The branch merges cleanly into the current cloud/1.55 tip, 931c6d1.
What matches:
- Seven files carry exactly the source's added and removed lines:
agentTurnLockFixture.ts,agentTurnSurvivesSocketDrop.spec.ts,agentRestClient.tsand its test,agentTranscript.test.ts, andagentConversationStore.tsand its test. - Every other difference is an adaptation I could tie to the target:
- The unscoped
THREAD_STORAGE_KEYreplacesStorageKeys.agentThread(), because workspace-scoped thread storage is not oncloud/1.55. onThreadActivated?.(null)andturnStartedAt.clear()are dropped, because neither exists here.reportErroromitssurface, because this branch'sReportErrorOptionshas no such field.- The release's
handleMessageDone(event.data)becomes the source'smarkStoppedTurnReady(turn), with the same guard. - The
toolCallPartStatecomment edit is applied to this branch's wording of that comment. - In the approval spec, the second case's soft pin is removed. This branch had a try/catch
test.fail()there wheremainhad a bare one. (g15)asserts this branch's unscoped key in place of the workspace-scoped key andonThreadActivated.
- The unscoped
- All 22 source test additions are present, and the
it.fails/test.failpins are un-failed. - At 48cad21:
vitest runoveruseAgentSession.test.ts,services/agent/, andstores/agent/passed 520/520 across 22 files. All hosted checks at this head passed.
What diverges is inline.
| import type { LiveTurn } from '../../stores/agent/agentConversationStore' | ||
| import { useAgentConversationStore } from '../../stores/agent/agentConversationStore' | ||
| import { useAgentWorkflowTabBindingStore } from '../../stores/agent/agentWorkflowTabBindingStore' | ||
| import type { WorkflowReference } from '../../types/workflowReference' |
There was a problem hiding this comment.
This is about line 50, just outside this hunk. #18152 changes export interface SessionNotice to interface SessionNotice, and this branch keeps the export. On cloud/1.55, as on main, nothing outside useAgentSession.ts imports SessionNotice, so the target needs no change here. Please carry the un-export.
There was a problem hiding this comment.
Carried the visibility hunk in commit 4b50b4c.
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: Approve. This is a faithful backport of #18152 to cloud/1.55, with each adaptation accounted for by the target.
I compared this branch, at 4b50b4c against its merge base 829fb7e, with #18152's merged diff (d90c109 against its parent 1519cc0). The branch merges cleanly into the current cloud/1.55 tip, 8be3aff. 4b50b4c carries the SessionNotice un-export, which resolves my earlier comment.
Seven files carry exactly the source's added and removed lines: agentTurnLockFixture.ts, agentTurnSurvivesSocketDrop.spec.ts, agentRestClient.ts and its test, agentTranscript.test.ts, and agentConversationStore.ts and its test.
Adaptations:
- The unscoped
THREAD_STORAGE_KEYreplacesStorageKeys.agentThread()inforgetDeletedThread, and(g15)asserts that key. Workspace-scoped thread storage is not oncloud/1.55. onThreadActivated?.(null)is dropped, and so is the matching(g15)assertion, because that dependency does not exist here.turnStartedAt.clear()is dropped, because that timing map ismain-only.- The recovery job's
reportErroromitssurface, because this branch'sReportErrorOptionshas no such field. - The release's
handleMessageDone(event.data)becomes the source'smarkStoppedTurnReady(turn), with the same thread and turn guard, called from theagent_message_donebranch. - The
toolCallPartStatedoc-comment edit is applied to this branch's wording of that comment. - In the approval spec, this branch's try/catch
test.fail()soft pin in the second case is removed.mainhas a baretest.fail()there, and the source removes it.
All 22 source test additions are present, and the it.fails / test.fail pins are un-failed.
Checks: at 4b50b4c, vitest run over useAgentSession.test.ts, services/agent/, and stores/agent/ passed 520/520 across 22 files, and vue-tsc --noEmit passed. All hosted checks at this head passed.
Manual backport of #18152 to
cloud/1.55. Preserves an active Agent turn across a transient socket disconnect and reconciles its outcome from persisted REST history.onStatus(false)now only records a drop.onStatus(true)after a drop starts one bounded recovery job per live turn: pollrest.getMessageson a 0/1/2/4/8/16-second backoff under a 60-second whole-job deadline, keep polling while the row isstreaming, settle when terminal, forget the thread on a repeated 404, one notice then keep polling on other REST errors.agentConversationStoregainsliveTurns()/settleTurn();agentTranscripthydrates any still-streamingassistant row as pending.Why this was re-done
The previous head cherry-picked
useAgentSession.ts,agentTranscript.tsandagentConversationStore.tslargely as they stand onmain, which pulled in main-only drift the reconnect fix does not need — workspace-scoped agent thread storage,trackAgentStopClicked/trackAgentWorkflowBoundtelemetry,ReportErrorOptions.surface, theturnStartedAttiming rework. That is what the 16 typecheck errors were, and the earlier repair attempt answered them by deleting 1 223 lines of the reconnect regression coverage.This head is a fresh cherry-pick of #18152's own delta onto
cloud/1.55, resolved against the APIs this branch actually has.useAgentSession.tsis +252/-32 here against +223/-26 upstream; the other nine files are byte-identical to the upstream delta apart from the adaptations below. Every regression pin from #18152 is restored: the threetest.fail()pins inagentTurnSurvivesSocketDrop.spec.tsand the remaining pin inagentApprovalSurvivesSocketDrop.spec.tsare un-failed, and the new(g3)–(g22)unit cases are present.Deliberate adaptations
THREAD_STORAGE_KEY. Workspace-scopedStorageKeys.agentThread()and theclearLegacyAgentStorage()migration are an unrelated main-only change, soforgetDeletedThreadclears the unscoped key.reportErroromitssurface, which is not a field of this branch'sReportErrorOptions; it matches the other call site in the same file.start()/hydrateFromServer(). Release signatures kept. Only theeverLive→connectionstate machine and thereconcileLiveTurns()call are taken —readyThreadId, therestoreoption,initializeWorkflowContextand theworkflow.restoredboolean contract are main-only and are context lines in fix(agent): keep the turn live across a socket reconnect and reconcile from REST (PM-1199) #18152's diff, not part of it.handleMessageDone(event.data)→markStoppedTurnReady(turn), so the websocket path and the reconcile path share one gate, as onmain.test.fail()with a try/catch soft pin around the visibility assertion. Both forms are removed, so a regression there reddens instead of reading as expected.(g15)now asserts this branch's observables for a deleted thread — thread id cleared, workflow binding dropped,Comfy.Agent.ThreadIdremoved, next send opens a new thread — in place of main's workspace-scoping andonThreadActivatedassertions.Verification
Run locally at
48cad21baon Node 26:pnpm typecheck— pass (was 16 errors)pnpm lint— pass, 0 problemspnpm knip— passpnpm format— no changespnpm vitest run src/workbench/extensions/agent— 127 files, 2 170 passed, 2 expected-fail (pre-existing CRDT pins, unrelated)Original: #18152