Repository navigation
test(agent): keep canvas primitive targets actionable - #19679
Conversation
🎭 Playwright: ✅ 2176 passed, 0 failed · 1 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-30T23:54:45.049Z",
"gitSha": "a8285b1d5df96c587d476ed48c43356e0a4a92c1",
"branch": "testungate-mainrefresh-6-followup",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2029.9600000000169,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.869000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.077,
"heapDeltaBytes": -7287732,
"heapUsedBytes": 74797368,
"domNodes": -232,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.197000000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2014.8130000000037,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.259999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.16900000000004,
"heapDeltaBytes": 22353908,
"heapUsedBytes": 75888504,
"domNodes": -230,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.555000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1834.8239999999691,
"styleRecalcs": 79,
"styleRecalcDurationMs": 19.327,
"layouts": 12,
"layoutDurationMs": 4.556,
"taskDurationMs": 840.458,
"heapDeltaBytes": -10038648,
"heapUsedBytes": 71639764,
"domNodes": -232,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 165.96499999999997,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665454545454548,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1827.7570000000196,
"styleRecalcs": 78,
"styleRecalcDurationMs": 18.777999999999995,
"layouts": 12,
"layoutDurationMs": 4.893,
"taskDurationMs": 846.359,
"heapDeltaBytes": 18876540,
"heapUsedBytes": 72576432,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 175.051,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666363636363638,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.6979999999853,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.524999999999999,
"layouts": 6,
"layoutDurationMs": 1.193,
"taskDurationMs": 402.95699999999994,
"heapDeltaBytes": -4366476,
"heapUsedBytes": 77036592,
"domNodes": -179,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 13.898000000000003,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.827184466019414,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.5630000000074,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.213000000000001,
"layouts": 6,
"layoutDurationMs": 1.298,
"taskDurationMs": 319.704,
"heapDeltaBytes": -806536,
"heapUsedBytes": 57911624,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.100000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 711.0909999999535,
"styleRecalcs": 13,
"styleRecalcDurationMs": 4.018000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.796,
"heapDeltaBytes": 20478524,
"heapUsedBytes": 102730376,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 188.95000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667441860465132,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 755.963999999949,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.2429999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.201,
"heapDeltaBytes": -13513600,
"heapUsedBytes": 67472608,
"domNodes": -232,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 171.608,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664444444444456,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1146.0549999999898,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 811.755,
"heapDeltaBytes": 12420212,
"heapUsedBytes": 90876888,
"domNodes": 0,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 69.25900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 526,
"frameDurationMs": 34.84848484848485,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1170.4669999999169,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 827.688,
"heapDeltaBytes": 11325604,
"heapUsedBytes": 89941464,
"domNodes": 0,
"jsHeapTotalBytes": 8028160,
"scriptDurationMs": 67.36299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 526,
"frameDurationMs": 34.31176470588234,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 858.9329999999791,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.3190000000001,
"heapDeltaBytes": -14662336,
"heapUsedBytes": 82863896,
"domNodes": 0,
"jsHeapTotalBytes": 3149824,
"scriptDurationMs": 166.32300000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 233,
"frameDurationMs": 25.485294117647058,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 891.7660000000751,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 515.574,
"heapDeltaBytes": 17421040,
"heapUsedBytes": 117840552,
"domNodes": 0,
"jsHeapTotalBytes": 2625536,
"scriptDurationMs": 181.04000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9423.158999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8595.837,
"heapDeltaBytes": 3344060,
"heapUsedBytes": 83608476,
"domNodes": 0,
"jsHeapTotalBytes": -13893632,
"scriptDurationMs": 7201.887,
"eventListeners": 0,
"totalBlockingTimeMs": 1112,
"frameDurationMs": 35.26704119850187,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10705.426999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9768.813,
"heapDeltaBytes": -6510456,
"heapUsedBytes": 68592352,
"domNodes": 0,
"jsHeapTotalBytes": -4194304,
"scriptDurationMs": 7953.349,
"eventListeners": 0,
"totalBlockingTimeMs": 1112,
"frameDurationMs": 32.034730538922155,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9721.994999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8837.779999999999,
"heapDeltaBytes": 23012,
"heapUsedBytes": 81595992,
"domNodes": 0,
"jsHeapTotalBytes": -13369344,
"scriptDurationMs": 7171.777,
"eventListeners": 0,
"totalBlockingTimeMs": 763,
"frameDurationMs": 31.44401294498382,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10202.85100000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9308.068,
"heapDeltaBytes": 16210492,
"heapUsedBytes": 84531308,
"domNodes": -142,
"jsHeapTotalBytes": -4329472,
"scriptDurationMs": 7591.145,
"eventListeners": -70,
"totalBlockingTimeMs": 896,
"frameDurationMs": 32.17539432176656,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2015.9419999999955,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.292,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.5290000000001,
"heapDeltaBytes": -2152212,
"heapUsedBytes": 71586072,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.348,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2036.972999999989,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6939999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.784,
"heapDeltaBytes": -11862848,
"heapUsedBytes": 82734292,
"domNodes": -328,
"jsHeapTotalBytes": -1183744,
"scriptDurationMs": 31.704000000000004,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2381.102999999996,
"styleRecalcs": 66,
"styleRecalcDurationMs": 9.046,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1605.9009999999998,
"heapDeltaBytes": 20212764,
"heapUsedBytes": 82748728,
"domNodes": -328,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 818.896,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66619718309859,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2466.9920000000047,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.426000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1623.3809999999999,
"heapDeltaBytes": -12916292,
"heapUsedBytes": 83641236,
"domNodes": -328,
"jsHeapTotalBytes": 2187264,
"scriptDurationMs": 803.0210000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66598639455782,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3587.8739999999993,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.484000000000002,
"layouts": 60,
"layoutDurationMs": 13.99,
"taskDurationMs": 1691.1199999999997,
"heapDeltaBytes": 11855564,
"heapUsedBytes": 76348204,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 781.2429999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6662037037037,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3734.3740000000025,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.512999999999998,
"layouts": 60,
"layoutDurationMs": 13.955,
"taskDurationMs": 1750.289,
"heapDeltaBytes": 10730596,
"heapUsedBytes": 74361480,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 816.588,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571428,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3178.0089999999745,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.658,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2031.1240000000003,
"heapDeltaBytes": 27799484,
"heapUsedBytes": 91992740,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1012.1560000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84232804232804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3096.8039999999064,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.749999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1948.2489999999998,
"heapDeltaBytes": 23592152,
"heapUsedBytes": 88596968,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 968.8129999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.757065217391304,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2054.9949999999626,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.8280000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 646.3299999999999,
"heapDeltaBytes": -13878804,
"heapUsedBytes": 83528984,
"domNodes": -328,
"jsHeapTotalBytes": -397312,
"scriptDurationMs": 38.571999999999996,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66532258064516,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.7599999999957,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.288000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.8329999999999,
"heapDeltaBytes": 20763432,
"heapUsedBytes": 83425608,
"domNodes": -328,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.550999999999995,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.931999999972,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.8260000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.343,
"heapDeltaBytes": 9275392,
"heapUsedBytes": 62971340,
"domNodes": -249,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 143.62,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 628.2509999999775,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.085999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.18500000000006,
"heapDeltaBytes": -19840928,
"heapUsedBytes": 62901632,
"domNodes": -250,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 145.31900000000002,
"eventListeners": -204,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.6999999999766,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.7420000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.97099999999995,
"heapDeltaBytes": -3215376,
"heapUsedBytes": 57798680,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.1099999999999985,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2004.4149999999945,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.9980000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.63400000000007,
"heapDeltaBytes": 22290176,
"heapUsedBytes": 76148716,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.511,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1736.0519999999724,
"styleRecalcs": 79,
"styleRecalcDurationMs": 22.290999999999997,
"layouts": 16,
"layoutDurationMs": 6.203,
"taskDurationMs": 827.423,
"heapDeltaBytes": -15997088,
"heapUsedBytes": 66805744,
"domNodes": -250,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 113.184,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.8689999999497,
"styleRecalcs": 59,
"styleRecalcDurationMs": 19.138999999999996,
"layouts": 16,
"layoutDurationMs": 6.152,
"taskDurationMs": 747.7130000000001,
"heapDeltaBytes": 16080508,
"heapUsedBytes": 76544192,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 117.222,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.7300000000432,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.455000000000002,
"layouts": 5,
"layoutDurationMs": 13.343999999999998,
"taskDurationMs": 910.719,
"heapDeltaBytes": 23925260,
"heapUsedBytes": 108240460,
"domNodes": 13747,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 28.783999999999995,
"eventListeners": 2383,
"totalBlockingTimeMs": 131,
"frameDurationMs": 19.141891891891905,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8725.473000000022,
"styleRecalcs": 249,
"styleRecalcDurationMs": 33.582,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5863.517,
"heapDeltaBytes": -20180440,
"heapUsedBytes": 80942036,
"domNodes": -328,
"jsHeapTotalBytes": 880640,
"scriptDurationMs": 2778.532,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.729885057471265,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8521.52000000001,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.83599999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5806.411000000001,
"heapDeltaBytes": -11077132,
"heapUsedBytes": 83331952,
"domNodes": -328,
"jsHeapTotalBytes": -172032,
"scriptDurationMs": 2694.2870000000003,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698818897637796,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17485.138000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16745.286,
"heapDeltaBytes": -30295808,
"heapUsedBytes": 194284596,
"domNodes": -8043,
"jsHeapTotalBytes": 3547136,
"scriptDurationMs": 290.10999999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.03883161512028,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-idle",
"durationMs": 16700.940999999944,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15951.491,
"heapDeltaBytes": -49776736,
"heapUsedBytes": 175030256,
"domNodes": -3045,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 293.08500000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 3,
"frameDurationMs": 28.351952461799666,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 21441.258000000005,
"styleRecalcs": 177,
"styleRecalcDurationMs": 20.689000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21024.226,
"heapDeltaBytes": -16697084,
"heapUsedBytes": 191713704,
"domNodes": -3045,
"jsHeapTotalBytes": 5980160,
"scriptDurationMs": 884.1640000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 10,
"frameDurationMs": 38.92758620689656,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 20473.749999999996,
"styleRecalcs": 169,
"styleRecalcDurationMs": 17.38099999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19979.477,
"heapDeltaBytes": -33144044,
"heapUsedBytes": 191328728,
"domNodes": -3045,
"jsHeapTotalBytes": 5836800,
"scriptDurationMs": 852.382,
"eventListeners": -14915,
"totalBlockingTimeMs": 21,
"frameDurationMs": 37.346350364963506,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6328.980000000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.71499999999999,
"layouts": 20,
"layoutDurationMs": 25.448999999999998,
"taskDurationMs": 6190.521000000001,
"heapDeltaBytes": 7755408,
"heapUsedBytes": 208264684,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 111.663,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.69642857142856,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6197.131000000013,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.79799999999999,
"layouts": 20,
"layoutDurationMs": 24.22200000000001,
"taskDurationMs": 6032.586,
"heapDeltaBytes": 1057992,
"heapUsedBytes": 224548948,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 105.61999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.25303867403316,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8729.58600000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8417.632999999998,
"heapDeltaBytes": -15828628,
"heapUsedBytes": 189731512,
"domNodes": -3045,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 139.87599999999995,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.95292096219932,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8707.266000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8426.972,
"heapDeltaBytes": -45982916,
"heapUsedBytes": 182984980,
"domNodes": -3045,
"jsHeapTotalBytes": 5001216,
"scriptDurationMs": 141.48899999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.7931506849315,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "workflow-execution",
"durationMs": 498.88099999998303,
"styleRecalcs": 21,
"styleRecalcDurationMs": 22.421999999999997,
"layouts": 6,
"layoutDurationMs": 2.666,
"taskDurationMs": 152.36799999999997,
"heapDeltaBytes": 6106232,
"heapUsedBytes": 64160028,
"domNodes": 133,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 17.727,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 457.25900000002184,
"styleRecalcs": 14,
"styleRecalcDurationMs": 16.959000000000003,
"layouts": 4,
"layoutDurationMs": 1.9629999999999999,
"taskDurationMs": 118.811,
"heapDeltaBytes": 5578664,
"heapUsedBytes": 58881508,
"domNodes": 99,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.627999999999998,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285715,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 881.9650000000365,
"styleRecalcs": 78,
"styleRecalcDurationMs": 105.162,
"layouts": 76,
"layoutDurationMs": 26.498,
"taskDurationMs": 856.9639999999999,
"heapDeltaBytes": 17413484,
"heapUsedBytes": 85587860,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 347.66,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664814814814807,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 990.9799999999223,
"styleRecalcs": 78,
"styleRecalcDurationMs": 108.52499999999999,
"layouts": 76,
"layoutDurationMs": 27.867,
"taskDurationMs": 960.117,
"heapDeltaBytes": 18705464,
"heapUsedBytes": 89552076,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 403.89000000000004,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999996,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1449.0970000000516,
"styleRecalcs": 78,
"styleRecalcDurationMs": 277.921,
"layouts": 76,
"layoutDurationMs": 30.298,
"taskDurationMs": 1424.9279999999999,
"heapDeltaBytes": 8104620,
"heapUsedBytes": 112822084,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 474.928,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.56455696202532,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1476.9260000000486,
"styleRecalcs": 78,
"styleRecalcDurationMs": 269.716,
"layouts": 76,
"layoutDurationMs": 29.1,
"taskDurationMs": 1446.4669999999999,
"heapDeltaBytes": -19163368,
"heapUsedBytes": 109237328,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 489.784,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.51851851851852,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3f266cb4539cc600061a769636bdef8754ad6f8f
Full docs: ADR-DEVEX-LINT-0015 |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Repository guideline files applied to this review (4)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. 📝 WalkthroughWalkthroughTwo canvas tests now center the first node before capturing graph state or geometry and performing their actions. ChangesCanvas test setup
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change only adjusts browser-test setup; no actionable merge-blocking risk is evident. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
✅ No high-signal findings.
Panel: 8/8 reviewers contributed findings.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19679 +/- ##
==========================================
+ Coverage 84.53% 85.27% +0.73%
==========================================
Files 3364 2365 -999
Lines 161922 135686 -26236
Branches 42151 34659 -7492
==========================================
- Hits 136885 115705 -21180
+ Misses 23119 19619 -3500
+ Partials 1918 362 -1556
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…omfy-Org#17328) Tightens two agent canvas primitive e2e assertions that pass for a wrong implementation. The original goal of this PR, running the slice03 canvas primitive specs against main, landed separately in Comfy-Org#18840 (rename to `agentCanvasPrimitives.spec.ts`) and Comfy-Org#19679. Merging main brought those in and dropped the old `slice03CanvasPrimitives.spec.ts`. What remains here are the review findings that still applied to the landed file. - Select-only: assert `getSelectedNodeIds()` equals `[node.id]` instead of counting selected nodes, so selecting the wrong node fails. - Drag: also assert every other serialized node is unchanged, so a drag that moves the whole selection or graph fails. - Remove two explanatory comments; the assertion messages already state intent. Checks: `pnpm typecheck:browser`, `oxlint`, `oxfmt --check`, `playwright test --project=chromium --list` (4 tests). The runtime assertions are covered by the e2e CI shards. --------- Co-authored-by: Amp <amp@ampcode.com>
Summary
Follow-up to #18840, which merged while its current-main refresh was being prepared. Playwright 1.63/current main exposed two canvas pins whose raw title coordinates no longer hit the node unless the target is first brought into view.
Test plan
NODE_OPTIONS=--no-experimental-webstorage pnpm vitest run src/composables/useWorkspaceInset.test.ts src/workbench/extensions/agent/components/agent/DockedAgentPanel.test.ts(16/16)pnpm typecheck:browserNo product behavior or policy changed.