Repository navigation
FE-3019 fix(billing-web): render server-reported display prices and charge breakdown - #19814
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (3)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (14)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughBilling operation receipts now preserve charge breakdowns. Checkout success summaries use receipt-reported charges and deductions. Annual-plan summaries can show server-provided monthly pricing and monthly list prices. ChangesBilling checkout summaries
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant BillingOpStatusSchema
participant receiptOf
participant successBreakdown
participant FullPageCheckoutView
BillingOpStatusSchema->>receiptOf: validate and provide charge breakdown
receiptOf->>successBreakdown: provide operation receipt on checkout page
FullPageCheckoutView->>successBreakdown: pass page and ledger context
successBreakdown-->>FullPageCheckoutView: return formatted breakdown when eligible
Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable merge-blocking issue is established. The receipt-based charge display and server-provided annual pricing appear consistent with the intended behavior; merge after normal checks pass. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The inspected change adds billing receipt detail without giving the browser new payment or account authority. Existing validation and operation-state guards remain in place. Server-side authorization and end-to-end settlement recovery were not independently verified, so the assessment remains bounded. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The title and commit subject contain the bug-fix signal "fix". The PR changes frontend files under
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🌐 Website E2ETip All tests passed.
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 205b03a2e31ac131423939cbab40f4140313550b
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2185 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 10.1 MB gzip 🔴 +433 kBDetailsSummary
Category Glance App Entry Points — 3.89 kB (baseline 3.73 kB) • 🔴 +154 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.47 MB (baseline 1.43 MB) • 🔴 +41.7 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 135 kB (baseline 124 kB) • 🔴 +10.9 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 646 kB (baseline 621 kB) • 🔴 +24.5 kBConfiguration panels, inspectors, and settings screens
Status: 28 added / 27 removed User & Accounts — 53.6 kB (baseline 27.8 kB) • 🔴 +25.8 kBAuthentication, profile, and account management bundles
Status: 14 added / 10 removed / 1 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +648 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 184 kB (baseline 117 kB) • 🔴 +67.1 kBReusable component library chunks
Status: 18 added / 15 removed Data & Services — 4.13 MB (baseline 3.6 MB) • 🔴 +533 kBStores, services, APIs, and repositories
Status: 14 added / 16 removed Utilities & Hooks — 586 kB (baseline 559 kB) • 🔴 +27 kBHelpers, composables, and utility bundles
Status: 33 added / 31 removed / 5 unchanged Vendor & Third-Party — 17.2 MB (baseline 18.1 MB) • 🟢 -865 kBExternal libraries and shared vendor chunks
Status: 14 added / 14 removed / 4 unchanged Other — 18.3 MB (baseline 16.4 MB) • 🔴 +1.9 MBBundles that do not match a named category
Status: 184 added / 175 removed / 121 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-01T22:25:51.070Z",
"gitSha": "0fbb6ac05ba95c286739962a29499e2aafb18797",
"branch": "jaewon/fe-3019-render-server-display-prices",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2013.2520000000795,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6640000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.21500000000003,
"heapDeltaBytes": 22279180,
"heapUsedBytes": 76194212,
"domNodes": -231,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.914000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2018.6969999999747,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.184,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.997,
"heapDeltaBytes": 335056,
"heapUsedBytes": 67145592,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.257999999999992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1749.9910000000227,
"styleRecalcs": 51,
"styleRecalcDurationMs": 13.865,
"layouts": 12,
"layoutDurationMs": 4.358,
"taskDurationMs": 734.768,
"heapDeltaBytes": 19476016,
"heapUsedBytes": 73561716,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 155.462,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1836.8179999999938,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.394000000000002,
"layouts": 12,
"layoutDurationMs": 4.175,
"taskDurationMs": 859.2579999999999,
"heapDeltaBytes": -2948428,
"heapUsedBytes": 63530720,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 184.581,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.819266055045873,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.7840000000524,
"styleRecalcs": 28,
"styleRecalcDurationMs": 10.187999999999999,
"layouts": 6,
"layoutDurationMs": 1.306,
"taskDurationMs": 393.37000000000006,
"heapDeltaBytes": -26691072,
"heapUsedBytes": 75675688,
"domNodes": -199,
"jsHeapTotalBytes": -2883584,
"scriptDurationMs": 11.988000000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.826923076923077,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.6860000001197,
"styleRecalcs": 32,
"styleRecalcDurationMs": 12.199000000000002,
"layouts": 6,
"layoutDurationMs": 1.397,
"taskDurationMs": 378.69699999999995,
"heapDeltaBytes": 3449340,
"heapUsedBytes": 70497980,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.783000000000005,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 657.4090000000297,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6219999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.56399999999996,
"heapDeltaBytes": 14232756,
"heapUsedBytes": 68210088,
"domNodes": -231,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.548,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 744.4440000001578,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.518,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.6720000000001,
"heapDeltaBytes": -7699304,
"heapUsedBytes": 59132652,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 176.154,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1173.907999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 826.087,
"heapDeltaBytes": 13886384,
"heapUsedBytes": 91935684,
"domNodes": 0,
"jsHeapTotalBytes": 6193152,
"scriptDurationMs": 66.18099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 539,
"frameDurationMs": 34.31176470588236,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1194.7069999998803,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 823.036,
"heapDeltaBytes": 13725136,
"heapUsedBytes": 92681604,
"domNodes": 0,
"jsHeapTotalBytes": 6455296,
"scriptDurationMs": 73.79200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 573,
"frameDurationMs": 35.294117647058826,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 859.5370000000457,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.03300000000024,
"heapDeltaBytes": 17145116,
"heapUsedBytes": 103996952,
"domNodes": 0,
"jsHeapTotalBytes": 2101248,
"scriptDurationMs": 155.765,
"eventListeners": 0,
"totalBlockingTimeMs": 216,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.765999999785,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.49499999999966,
"heapDeltaBytes": -7078772,
"heapUsedBytes": 91382332,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 169.32600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 224,
"frameDurationMs": 24.76285714285711,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9105.72000000002,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5000000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8311.489,
"heapDeltaBytes": 16537868,
"heapUsedBytes": 92337556,
"domNodes": -142,
"jsHeapTotalBytes": -6164480,
"scriptDurationMs": 6980.695,
"eventListeners": -78,
"totalBlockingTimeMs": 864,
"frameDurationMs": 34.599239543726235,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8858.813999999938,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.42800000000000127,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8151.792,
"heapDeltaBytes": 7473044,
"heapUsedBytes": 84325612,
"domNodes": -142,
"jsHeapTotalBytes": -6950912,
"scriptDurationMs": 6838.243,
"eventListeners": -78,
"totalBlockingTimeMs": 685,
"frameDurationMs": 33.90651340996169,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10522.243000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9669.147,
"heapDeltaBytes": 5431176,
"heapUsedBytes": 81351156,
"domNodes": 0,
"jsHeapTotalBytes": -8126464,
"scriptDurationMs": 7994.19,
"eventListeners": 0,
"totalBlockingTimeMs": 1022,
"frameDurationMs": 32.76105919003115,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10264.132000000018,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.41000000000000064,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9344.312,
"heapDeltaBytes": -8653828,
"heapUsedBytes": 67624256,
"domNodes": -142,
"jsHeapTotalBytes": -7475200,
"scriptDurationMs": 7636.42,
"eventListeners": -74,
"totalBlockingTimeMs": 902,
"frameDurationMs": 32.385804416403786,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2007.1020000000317,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.221999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.7710000000001,
"heapDeltaBytes": -809580,
"heapUsedBytes": 85457028,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 31.142000000000017,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2020.2550000001338,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.5089999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 665.268,
"heapDeltaBytes": -991480,
"heapUsedBytes": 84456296,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 36.991,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2365.5519999999797,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.722,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1626.318,
"heapDeltaBytes": -4543888,
"heapUsedBytes": 83328152,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 850.646,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78368794326241,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2962.7839999998287,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.212,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1759.301,
"heapDeltaBytes": 3711024,
"heapUsedBytes": 90251520,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 890.743,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3587.7629999999954,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.102000000000002,
"layouts": 60,
"layoutDurationMs": 13.799,
"taskDurationMs": 1663.7689999999998,
"heapDeltaBytes": -11639152,
"heapUsedBytes": 76795076,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 774.951,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666046511627908,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3663.1830000001173,
"styleRecalcs": 64,
"styleRecalcDurationMs": 12.438,
"layouts": 60,
"layoutDurationMs": 14.814,
"taskDurationMs": 1648.2179999999998,
"heapDeltaBytes": 9127240,
"heapUsedBytes": 72786248,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 806.316,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666363636363638,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3146.5480000000525,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.854999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1914.7629999999997,
"heapDeltaBytes": 24017384,
"heapUsedBytes": 88743580,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 963.8420000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755080213903742,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3183.723999999984,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.513000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2065.434,
"heapDeltaBytes": -2411760,
"heapUsedBytes": 75203540,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 1034.694,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84232804232804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2038.501999999994,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.6359999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.7299999999999,
"heapDeltaBytes": -41310868,
"heapUsedBytes": 83284960,
"domNodes": -328,
"jsHeapTotalBytes": -3506176,
"scriptDurationMs": 30.878000000000004,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2042.8329999999733,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.062000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 667.5300000000001,
"heapDeltaBytes": -41063468,
"heapUsedBytes": 83377652,
"domNodes": -328,
"jsHeapTotalBytes": -3506176,
"scriptDurationMs": 37.482,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 584.2989999999872,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.66900000000004,
"heapDeltaBytes": 9673648,
"heapUsedBytes": 63597076,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 141.482,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66857142857142,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 645.3569999998763,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.594999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.856,
"heapDeltaBytes": -11661540,
"heapUsedBytes": 58722400,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 150.984,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.3319999999958,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.3200000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.25300000000004,
"heapDeltaBytes": 21972912,
"heapUsedBytes": 75967364,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.075000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.290999999972,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.845,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.775,
"heapDeltaBytes": -3775188,
"heapUsedBytes": 57016852,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.896999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1701.1780000000272,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.209,
"layouts": 16,
"layoutDurationMs": 5.321,
"taskDurationMs": 715.4929999999999,
"heapDeltaBytes": -7065680,
"heapUsedBytes": 60372228,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 110.972,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1703.6980000000312,
"styleRecalcs": 55,
"styleRecalcDurationMs": 16.709000000000003,
"layouts": 16,
"layoutDurationMs": 6.0040000000000004,
"taskDurationMs": 777.2030000000001,
"heapDeltaBytes": 14997104,
"heapUsedBytes": 68924880,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 118.55399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1402.0319999999629,
"styleRecalcs": 16,
"styleRecalcDurationMs": 29.043000000000006,
"layouts": 5,
"layoutDurationMs": 12.874999999999998,
"taskDurationMs": 935.9640000000003,
"heapDeltaBytes": 24002012,
"heapUsedBytes": 109722512,
"domNodes": 13747,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 30.715999999999994,
"eventListeners": 2383,
"totalBlockingTimeMs": 130,
"frameDurationMs": 19.406849315068502,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8393.075000000066,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.942,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5740.048000000001,
"heapDeltaBytes": -35321304,
"heapUsedBytes": 87055976,
"domNodes": -328,
"jsHeapTotalBytes": -3051520,
"scriptDurationMs": 2663.286,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699203187250998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9390.297000000146,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.181000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6174.356,
"heapDeltaBytes": -34728620,
"heapUsedBytes": 87844112,
"domNodes": -328,
"jsHeapTotalBytes": -3051520,
"scriptDurationMs": 2786.1440000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.695729537366546,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16919.87400000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16380.498000000003,
"heapDeltaBytes": -31247012,
"heapUsedBytes": 175304876,
"domNodes": -3046,
"jsHeapTotalBytes": 7086080,
"scriptDurationMs": 249.15099999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.065463917525772,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 17622.749000000113,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16860.824999999997,
"heapDeltaBytes": -12420168,
"heapUsedBytes": 183325392,
"domNodes": -3045,
"jsHeapTotalBytes": 7884800,
"scriptDurationMs": 286.222,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.636521739130433,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 21185.572999999975,
"styleRecalcs": 173,
"styleRecalcDurationMs": 20.813000000000027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20777.774,
"heapDeltaBytes": -9277256,
"heapUsedBytes": 192556928,
"domNodes": -3045,
"jsHeapTotalBytes": 7028736,
"scriptDurationMs": 915.7370000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 30,
"frameDurationMs": 38.654014598540144,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 22046.646999999895,
"styleRecalcs": 171,
"styleRecalcDurationMs": 24.615,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21619.9,
"heapDeltaBytes": -23500276,
"heapUsedBytes": 178268992,
"domNodes": -3045,
"jsHeapTotalBytes": 6049792,
"scriptDurationMs": 949.8870000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 60,
"frameDurationMs": 40.20510948905109,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-node-resize-workload",
"durationMs": 5998.710000000074,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.268,
"layouts": 20,
"layoutDurationMs": 23.313,
"taskDurationMs": 5876.552,
"heapDeltaBytes": 872080,
"heapUsedBytes": 209267872,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 100.51800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.583815028901725,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6489.937999999938,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.10900000000005,
"layouts": 20,
"layoutDurationMs": 25.986000000000008,
"taskDurationMs": 6342.186000000001,
"heapDeltaBytes": 14414664,
"heapUsedBytes": 225861156,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 123.31799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.0457142857143,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8569.746000000123,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8149.563999999999,
"heapDeltaBytes": -52111972,
"heapUsedBytes": 161937276,
"domNodes": -3045,
"jsHeapTotalBytes": 6868992,
"scriptDurationMs": 184.488,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.746308724832208,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9074.90299999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8728.242999999999,
"heapDeltaBytes": -37099768,
"heapUsedBytes": 163528428,
"domNodes": -3045,
"jsHeapTotalBytes": 8441856,
"scriptDurationMs": 153.204,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.120598006644528,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "workflow-execution",
"durationMs": 181.58900000003086,
"styleRecalcs": 14,
"styleRecalcDurationMs": 18.188,
"layouts": 4,
"layoutDurationMs": 1.7099999999999997,
"taskDurationMs": 152.42,
"heapDeltaBytes": -42191468,
"heapUsedBytes": 57014624,
"domNodes": -112,
"jsHeapTotalBytes": -2621440,
"scriptDurationMs": 17.107999999999997,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 139.0920000001188,
"styleRecalcs": 9,
"styleRecalcDurationMs": 14.616,
"layouts": 4,
"layoutDurationMs": 1.891,
"taskDurationMs": 98.44799999999998,
"heapDeltaBytes": 3911628,
"heapUsedBytes": 68874536,
"domNodes": 120,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.125999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.433333333333394,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1031.1420000000453,
"styleRecalcs": 78,
"styleRecalcDurationMs": 112.682,
"layouts": 76,
"layoutDurationMs": 28.461,
"taskDurationMs": 996.6279999999999,
"heapDeltaBytes": 18954660,
"heapUsedBytes": 87553024,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 413.763,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66721311475411,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1172.06299999998,
"styleRecalcs": 78,
"styleRecalcDurationMs": 119.909,
"layouts": 76,
"layoutDurationMs": 30.16,
"taskDurationMs": 1134.2810000000002,
"heapDeltaBytes": 19958832,
"heapUsedBytes": 90608420,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 469.423,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.15588235294117,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1472.974000000022,
"styleRecalcs": 78,
"styleRecalcDurationMs": 276.368,
"layouts": 76,
"layoutDurationMs": 29.525,
"taskDurationMs": 1443.247,
"heapDeltaBytes": -19065172,
"heapUsedBytes": 109068412,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 476.794,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333749999999988,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1484.2600000001767,
"styleRecalcs": 78,
"styleRecalcDurationMs": 290.617,
"layouts": 76,
"layoutDurationMs": 30.557000000000002,
"taskDurationMs": 1457.207,
"heapDeltaBytes": 8292616,
"heapUsedBytes": 113148920,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 478.144,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.54124999999999,
"p95FrameDurationMs": 33.399999999999636
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #19814 +/- ##
==========================================
- Coverage 84.73% 84.73% -0.01%
==========================================
Files 3408 3409 +1
Lines 163610 163611 +1
Branches 42681 42682 +1
==========================================
- Hits 138635 138632 -3
- Misses 23030 23032 +2
- Partials 1945 1947 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…harge breakdown The yearly summary reads monthly_price_cents / monthly_list_price_cents instead of comparing list_price_cents to price_cents, and the Success card lists the operation's charge_breakdown reasons instead of rebuilding them from the pre-payment quote. account-core keeps charge_breakdown on the operation receipt and shares one SubscriptionDiscount schema.
b580d28 to
6795b6e
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Approved: success and summary pricing now render the server-reported charge breakdown.
CI is settled at this exact head, and there are no unresolved review threads.
Full context for agent readers
The change keeps list price, monthly figures, discounts, account balance, proration, and the amount paid today distinct. Unit and end-to-end coverage include promo codes, recovered provider returns, and server-reported display values.
…omfy-Org#19878) ## Summary billing-web words a discount's term from the `term` the server reports on `SubscriptionDiscount`, instead of picking the copy on the client. Builds on Comfy-Org#19877 (merged). ## Why - The frontend must not derive copy from server metadata. The summary chose a discount's subline from `transition_type`, the plan duration and the coupon duration. - The summary and the Success card disagreed. A one-time code on a monthly plan change read "This payment only" on the summary and "First month" on Success. ## Root cause - `summaryLedger.ts` `discountTerm` mapped `duration: 'once'` to "This payment only" when `transition_type` was not `new_subscription` and the plan was monthly, otherwise to the plan's first period. - The op status has no `transition_type`, so `successBreakdown.ts` could only pass the plan duration, and the same code read "First month" there. ## How - [cloud#11446](Comfy-Org/cloud#11446) adds `term` (`this_payment`, `first_month`, `first_year`, `months`, `ongoing`) to `SubscriptionDiscount`, in both the preview's `discounts` and the op status `charge_breakdown` reasons. - `discountRow` looks the subline up in a `TERM_LINE` table keyed by `term`. `this_payment`, `first_month` and `first_year` reuse the existing keys, `months` uses the `forMonths` plural with `duration_in_months`, and `ongoing` or an absent term has no subline. The reads of `transition_type`, plan duration and `discount.duration`, `DeductionFormat.duration`, and `BY_DURATION.onceTerm` are deleted. The Success card shares `discountRow`, so it reads the same copy. - account-core. `SubscriptionDiscountSchema` extends the generated `zSubscriptionDiscount`, which already carries `term` as an optional strict enum, so the schema is not redeclared. A new `subscriptionDiscount.test.ts` pins the inferred type to the five values, parses each, and rejects an unknown term. ## Testing - Unit: billing-web 1344 passed, account-core 1468 passed (rebased on main). The new term table, the Success "This payment only" case, and a guard (same `term` across `new_subscription`, `upgrade`, `downgrade` and `duration_change` reads the same copy) fail 8 tests against the previous `summaryLedger.ts`/`successBreakdown.ts`. - Typecheck: root, billing-web and account-core are clean. oxlint, oxfmt and knip are clean. - billing-web e2e with `CI=1` and `--retries=0` on :4174: 127 passed. Scenario discounts now carry `term`, and the monthly-change test asserts "This payment only" on Success. ## Where this PR sits in Milestone 3 | Step | PR | State | | --- | --- | --- | | Server display fields, first pass | [PR 19672](Comfy-Org#19672) | merged | | Top-up on full-page checkout | [PR 19673](Comfy-Org#19673) | merged | | Per-month prices for yearly plans | [cloud 11318](Comfy-Org/cloud#11318) | merged | | Charge breakdown on succeeded ops | [cloud 11327](Comfy-Org/cloud#11327) | merged | | Ingest types sync | [PR 19526](Comfy-Org#19526) | merged | | Render display prices and breakdown | [PR 19814](Comfy-Org#19814) | merged | | Discount term | [cloud 11446](Comfy-Org/cloud#11446) | merged | | Ingest types sync (cloud@4b1fa05) | [PR 19877](Comfy-Org#19877) | merged | | **Render the server-reported discount term** | **this PR** | **open** | ```mermaid flowchart LR A["PR 19672 (merged)"] --> F["PR 19814 display prices (merged)"] B["PR 19673 (merged)"] --> F C["cloud 11318 (merged)"] --> E["PR 19526 ingest types (merged)"] D["cloud 11327 (merged)"] --> E E --> F G["cloud 11446 discount term (merged)"] --> H["PR 19877 ingest types sync (merged)"] F --> I["this PR"] H --> I style I fill:#f9d71c,stroke:Comfy-Org#333,stroke-width:3px ``` ## Screenshots | | AS IS (main) | TO BE (this PR) | | --- | --- | --- | | Success after a monthly plan change with a one-time code (`term: this_payment`) | <img width="420" alt="asis-success" src="https://github.com/user-attachments/assets/afaaf895-13f6-4c92-9cf2-885900575f5f" /> | <img width="420" alt="tobe-success" src="https://github.com/user-attachments/assets/9c0204b3-e31b-48db-94fb-8dd3edbea3ca" /> | Captured from the local billing-web production build (`vite build` and `vite preview` on :4174) against the e2e mock Cloud, with the same scenario on `main` and on this branch. The summary already read "This payment only" on `main`; Success read "First month".
Summary
billing-web renders the display prices and the charge breakdown the server now reports, instead of deriving them on the client.
Builds on #19526 (merged).
Why
Root cause
summaryLedger.tscomparedRateOfcomparedlist_price_centstoprice_cents.successBreakdown.tscompared the charge toprice_centsand rebuilt the reasons from the pre-payment quote (ChargeSource,quotedSource,opStatusSource, and a switch on the ledger family). On a provider return there is no quote, so there were no reasons.How
monthly_price_cents, struck againstmonthly_list_price_centswhen sent (cloud#11318). Other plans strike whenever the server sendslist_price_cents. No client comparison remains.charge_breakdown(cloud#11327): one row per reason (promo_code,subscription_discount,account_balance), "Paid today" fromamount_charged_cents, and the proration line fromprorated. There are no rows when the server reports no breakdown. The client comparisons,ChargeSourceand its helpers are deleted.charge_breakdown(wire cents coerced, unknown reason kinds rejected), the types are exported, and oneSubscriptionDiscountSchemais shared by the preview and the op status.packages/ingest-types.Testing
CI=1and--retries=0: 127 passed. The new provider-return test fails on the oldsuccessBreakdown(receivedPaid today$40.00with no reasons) and passed 10/10 with--repeat-each=10.Known follow-up
When cloud#11446 (
termonSubscriptionDiscount) merges,discountTermbecomes a plain lookup ondiscount.term, and the summary and Success card copy will match.Where this PR sits in Milestone 3
Screenshots
Captured from the local billing-web production build (
vite buildandvite previewon :4174) against the e2e mock Cloud, the same scenarios for both builds.