Repository navigation
[backport core/1.54] feat(agent): keep panel open through activation - #19634
comfy-pr-bot merged 3 commits into
Conversation
Keep the Agent panel open after the startup/onboarding decision across cloud and local sessions, while preserving authentication and consent at the first-send boundary. - **What**: Opens the panel from the approved activation flow, allows the pre-consent panel shell to render, and holds the submitted draft while the existing login/consent flow completes. - **What**: Keeps workflow-selection restoration consent-gated and records distinct `activation` / `first_message` telemetry sources. - **Dependencies**: None. Please verify the cloud/local × logged-in/logged-out × consent state matrix and that a first send resumes exactly once after the existing handoff. - `pnpm test:unit src/workbench/extensions/agent/stores/agent/agentPanelStore.test.ts src/extensions/core/agentPanel.test.ts src/components/topbar/WorkflowTabs.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.ts --testTimeout=30000` (454 passed) - `NODE_OPTIONS=--max-old-space-size=8192 pnpm typecheck` - changed-file ESLint and full format check --------- Co-authored-by: GitHub Action <action@github.com>
|
@christian-byrne is attempting to deploy a commit to the ComfyUI Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1958 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-30T16:41:30.391Z",
"gitSha": "a24a8d892f7c517a02e10f5340a40269f0421600",
"branch": "backport-19154-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2178.2650000000103,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.0360000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 694.792,
"heapDeltaBytes": 9837216,
"heapUsedBytes": 80624212,
"domNodes": -282,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 15.425999999999998,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2054.916999999989,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.114000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 564.616,
"heapDeltaBytes": -6125464,
"heapUsedBytes": 58973684,
"domNodes": -286,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 11.783999999999999,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1953.1829999999673,
"styleRecalcs": 77,
"styleRecalcDurationMs": 33.31,
"layouts": 14,
"layoutDurationMs": 4.628,
"taskDurationMs": 979.6,
"heapDeltaBytes": 2413320,
"heapUsedBytes": 73361032,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 184.946,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1935.5649999999969,
"styleRecalcs": 77,
"styleRecalcDurationMs": 31.868000000000002,
"layouts": 14,
"layoutDurationMs": 4.289000000000001,
"taskDurationMs": 939.3430000000001,
"heapDeltaBytes": -3144804,
"heapUsedBytes": 66887456,
"domNodes": -283,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 170.131,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1746.4309999999728,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.319999999999997,
"layouts": 6,
"layoutDurationMs": 1.0579999999999996,
"taskDurationMs": 438.4,
"heapDeltaBytes": 4359000,
"heapUsedBytes": 74498672,
"domNodes": 72,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 16.663999999999998,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1757.5950000000375,
"styleRecalcs": 31,
"styleRecalcDurationMs": 20.598000000000003,
"layouts": 6,
"layoutDurationMs": 1.306,
"taskDurationMs": 463.415,
"heapDeltaBytes": 4657664,
"heapUsedBytes": 75750744,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 16.802,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 737.7910000000156,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.586,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.215,
"heapDeltaBytes": -7561036,
"heapUsedBytes": 63527132,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 183.326,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 671.6870000000199,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.075999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.28000000000003,
"heapDeltaBytes": 18659392,
"heapUsedBytes": 88071900,
"domNodes": 16,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 165.958,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2061.6529999999784,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.37,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 803.559,
"heapDeltaBytes": 6577224,
"heapUsedBytes": 82722432,
"domNodes": -281,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 42.45800000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2073.1190000000197,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.612,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 660.0169999999998,
"heapDeltaBytes": 11348044,
"heapUsedBytes": 87165232,
"domNodes": -266,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 36.775000000000006,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2734.727000000021,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.248999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1857.825,
"heapDeltaBytes": 3766376,
"heapUsedBytes": 81368124,
"domNodes": -284,
"jsHeapTotalBytes": 647168,
"scriptDurationMs": 897.8699999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2369.226000000026,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.352,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1713.3089999999997,
"heapDeltaBytes": -15633980,
"heapUsedBytes": 88313304,
"domNodes": -273,
"jsHeapTotalBytes": -888832,
"scriptDurationMs": 835.4789999999999,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3955.9150000000045,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.836000000000002,
"layouts": 60,
"layoutDurationMs": 13.065999999999999,
"taskDurationMs": 1909.2579999999998,
"heapDeltaBytes": 7738532,
"heapUsedBytes": 75800732,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 854.989,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3764.1929999999775,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.407000000000004,
"layouts": 60,
"layoutDurationMs": 12.604000000000001,
"taskDurationMs": 1812.1680000000001,
"heapDeltaBytes": 8949584,
"heapUsedBytes": 76641444,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 826.2900000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3183.230999999978,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.949999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2072.063,
"heapDeltaBytes": 5444208,
"heapUsedBytes": 86936472,
"domNodes": -285,
"jsHeapTotalBytes": 577536,
"scriptDurationMs": 1013.1060000000001,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3157.342000000085,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.857999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2066.264,
"heapDeltaBytes": 27391076,
"heapUsedBytes": 95064756,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 1026.489,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2033.1490000000372,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.559999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 674.933,
"heapDeltaBytes": 9369288,
"heapUsedBytes": 87760712,
"domNodes": -269,
"jsHeapTotalBytes": -2723840,
"scriptDurationMs": 36.525,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2024.8109999999997,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.636,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 716.037,
"heapDeltaBytes": 9740872,
"heapUsedBytes": 87620984,
"domNodes": -271,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 37.940000000000005,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 624.2650000000367,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.143,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.106,
"heapDeltaBytes": 14606856,
"heapUsedBytes": 88022564,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 144.104,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 616.8579999999793,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.514,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.937,
"heapDeltaBytes": 13662228,
"heapUsedBytes": 79886548,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 143.605,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2015.4440000000022,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.094999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.337,
"heapDeltaBytes": 10719520,
"heapUsedBytes": 84021028,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.682999999999998,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2038.2100000000491,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.696000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.1220000000001,
"heapDeltaBytes": 2190604,
"heapUsedBytes": 74811364,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 11.823,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1756.1220000000048,
"styleRecalcs": 78,
"styleRecalcDurationMs": 30.308,
"layouts": 18,
"layoutDurationMs": 4.617000000000001,
"taskDurationMs": 891.596,
"heapDeltaBytes": -15161332,
"heapUsedBytes": 57969384,
"domNodes": -294,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 119.189,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1733.549000000039,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.253,
"layouts": 18,
"layoutDurationMs": 4.685,
"taskDurationMs": 863.809,
"heapDeltaBytes": -4831408,
"heapUsedBytes": 67716436,
"domNodes": -295,
"jsHeapTotalBytes": 7593984,
"scriptDurationMs": 118.085,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1450.353000000007,
"styleRecalcs": 19,
"styleRecalcDurationMs": 35.971000000000004,
"layouts": 15,
"layoutDurationMs": 16.889000000000003,
"taskDurationMs": 1052.7029999999997,
"heapDeltaBytes": 22150012,
"heapUsedBytes": 107201276,
"domNodes": 13831,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 36.126,
"eventListeners": 2387,
"totalBlockingTimeMs": 166,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9584.66999999996,
"styleRecalcs": 247,
"styleRecalcDurationMs": 38.982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6438.367,
"heapDeltaBytes": 9280136,
"heapUsedBytes": 85632260,
"domNodes": -251,
"jsHeapTotalBytes": -172032,
"scriptDurationMs": 2917.544,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10851.462999999967,
"styleRecalcs": 247,
"styleRecalcDurationMs": 39.246,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6910.666,
"heapDeltaBytes": 28057664,
"heapUsedBytes": 104790752,
"domNodes": -270,
"jsHeapTotalBytes": 7168000,
"scriptDurationMs": 3362.759,
"eventListeners": -140,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18055.375000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17513.031000000003,
"heapDeltaBytes": -41132996,
"heapUsedBytes": 178782304,
"domNodes": -8068,
"jsHeapTotalBytes": -11067392,
"scriptDurationMs": 303.58199999999994,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18368.006000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17616.854000000003,
"heapDeltaBytes": -57643492,
"heapUsedBytes": 179341924,
"domNodes": -8068,
"jsHeapTotalBytes": -19312640,
"scriptDurationMs": 306.70300000000003,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21494.781999999985,
"styleRecalcs": 167,
"styleRecalcDurationMs": 20.65800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21182.246,
"heapDeltaBytes": -53717968,
"heapUsedBytes": 169668020,
"domNodes": -8068,
"jsHeapTotalBytes": -15998976,
"scriptDurationMs": 927.77,
"eventListeners": -14927,
"totalBlockingTimeMs": 127,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21636.977000000003,
"styleRecalcs": 167,
"styleRecalcDurationMs": 21.20299999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21355.031,
"heapDeltaBytes": -34753816,
"heapUsedBytes": 183482624,
"domNodes": -8068,
"jsHeapTotalBytes": -11067392,
"scriptDurationMs": 947.675,
"eventListeners": -14927,
"totalBlockingTimeMs": 121,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6347.508000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.58300000000003,
"layouts": 20,
"layoutDurationMs": 36.256999999999984,
"taskDurationMs": 6265.677999999999,
"heapDeltaBytes": -55651688,
"heapUsedBytes": 176792276,
"domNodes": -8068,
"jsHeapTotalBytes": 4542464,
"scriptDurationMs": 117.35999999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 381,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6412.429999999972,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.818,
"layouts": 20,
"layoutDurationMs": 23.769,
"taskDurationMs": 6368.108000000001,
"heapDeltaBytes": -44109692,
"heapUsedBytes": 180406872,
"domNodes": -8068,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 114.507,
"eventListeners": -14931,
"totalBlockingTimeMs": 453,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9183.86300000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8848.399,
"heapDeltaBytes": 9320640,
"heapUsedBytes": 179066592,
"domNodes": 0,
"jsHeapTotalBytes": -7864320,
"scriptDurationMs": 155.79200000000003,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8942.230999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8580.248000000001,
"heapDeltaBytes": 5092152,
"heapUsedBytes": 179367840,
"domNodes": 0,
"jsHeapTotalBytes": -14155776,
"scriptDurationMs": 140.471,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 116.8920000000071,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.237000000000002,
"layouts": 2,
"layoutDurationMs": 1.0250000000000001,
"taskDurationMs": 78.36300000000001,
"heapDeltaBytes": 3016476,
"heapUsedBytes": 71583544,
"domNodes": 131,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.754,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 112.02700000001187,
"styleRecalcs": 9,
"styleRecalcDurationMs": 16.287000000000003,
"layouts": 2,
"layoutDurationMs": 1.425,
"taskDurationMs": 78.266,
"heapDeltaBytes": 2935684,
"heapUsedBytes": 71415256,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.373,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #19634 +/- ##
=============================================
- Coverage 84.18% 84.17% -0.02%
=============================================
Files 2112 2112
Lines 126488 126520 +32
Branches 34025 32164 -1861
=============================================
+ Hits 106482 106494 +12
- Misses 19820 19840 +20
Partials 186 186
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
…nd (#19645) ## Summary Backport merged #19619 onto `core/1.54` after prerequisite #19634 landed. ## Changes - **What**: Preserve activation-open consent timing, hold the first send through the Agent coach, and release it exactly once on finish, skip, or App Mode deferral. - **Dependencies**: #19634 / #19154 is already merged into the target. ## Review Focus Please verify the target-specific consent browser fixture adaptation and held-send cleanup when the panel closes during App Mode. Consent copy/policy, flags, billing, starter prompts, and backend behavior are unchanged. ## Verification - 408/408 focused consent/onboarding unit tests - 19/19 offline Cloud consent/onboarding browser tests - app and browser typecheck - changed-file format/lint - Cloud build
Backports #19154 to
core/1.54from merge commitbe3e1a1308.Preserves the approved panel activation and consent-held-send behavior while retaining the release branch’s deleted/reworked browser fixtures. Does not include #19619 or any billing, gratis, prompt, copy, flag, or exposure changes.
Verification:
NODE_OPTIONS=--max-old-space-size=8192 pnpm vitest run src/extensions/core/agentPanel.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.ts src/workbench/extensions/agent/stores/agent/agentPanelStore.test.ts src/components/LiteGraphCanvasSplitterOverlay.test.ts src/components/topbar/WorkflowTabs.test.ts --testTimeout=30000 --reporter=dot— 412/412 passedNODE_OPTIONS=--max-old-space-size=8192 pnpm build— passedpnpm typecheck:browser— passedBrowser note: the main-branch activation spec was exercised against the built
core/1.54app in the offline Cloud container, but all 4 cases stopped before the assertions because this target’s authenticated feature-flag harness did not render the Agent entry surface. The known-red main-only spec was therefore not added to the release branch; hosted CI remains the target browser verdict.