Repository navigation
[backport core/1.54] fix(agent): sequence consent tour before held send - #19645
Conversation
Keep a freshly activated Agent panel usable before consent, then resume its held first message exactly once after the user finishes or skips the Agent tour. - **What**: Defer the automatic consent card for activation-opened sessions, retain the existing first-message consent gate, and hold that submission until the newly required Agent coach finishes or is skipped. - This intentionally changes only activation-opened sessions: their automatic `first_load` offer is dropped for the page session so the user can type first; restored-open sessions retain the existing automatic offer. - Record that drop as `activation_opened_panel` on `agent_consent_offer_exited` so the funnel distinguishes it from an offer that was never owed. - Add finish and skip browser regressions covering consent persistence, exactly-once send, panel reopen without a consent loop, and cancellation if the panel closes during App Mode. Please verify the activation-only consent boundary, waiter initialization/cleanup across App Mode remounts, and held-send cancellation when the panel closes. Wording, flags, billing, starter prompts, and backend behavior are unchanged. - Focused AgentPanelRoot App Mode/close tests: 2/2 passed. - Focused agentPanel activation/telemetry tests: 2/2 passed. - Commit hooks passed formatting, changed-file lint, and app typecheck. - The previous head passed 11/11 focused Cloud browser scenarios; hosted CI is rerunning on the review-repair head.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1960 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-30T19:32:00.117Z",
"gitSha": "0a1a108d7b67dc4dd63008d98ef07a90c0d02718",
"branch": "backport-19619-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2053.859999999986,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.203000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.271,
"heapDeltaBytes": 3734328,
"heapUsedBytes": 74930624,
"domNodes": -282,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.405999999999997,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2017.5380000000018,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.692000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.171,
"heapDeltaBytes": 605788,
"heapUsedBytes": 64903560,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 8.333999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1951.037000000042,
"styleRecalcs": 79,
"styleRecalcDurationMs": 33.87499999999999,
"layouts": 14,
"layoutDurationMs": 4.011,
"taskDurationMs": 981.186,
"heapDeltaBytes": 13016268,
"heapUsedBytes": 84226776,
"domNodes": -283,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 176.174,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1869.655000000023,
"styleRecalcs": 75,
"styleRecalcDurationMs": 28.503000000000004,
"layouts": 14,
"layoutDurationMs": 3.841,
"taskDurationMs": 866.724,
"heapDeltaBytes": 13123348,
"heapUsedBytes": 83341396,
"domNodes": -283,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 161.469,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.7420000000393,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.68,
"layouts": 6,
"layoutDurationMs": 1.1319999999999997,
"taskDurationMs": 347.778,
"heapDeltaBytes": 4698388,
"heapUsedBytes": 75327556,
"domNodes": 75,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.146999999999997,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.0200000000195,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.27,
"layouts": 6,
"layoutDurationMs": 1.1000000000000003,
"taskDurationMs": 350.402,
"heapDeltaBytes": 4637492,
"heapUsedBytes": 75646112,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.140999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 653.6619999999971,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.964999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.79100000000005,
"heapDeltaBytes": -7900284,
"heapUsedBytes": 63270672,
"domNodes": 18,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 159.01900000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 646.9280000000026,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.515,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.079,
"heapDeltaBytes": -7262076,
"heapUsedBytes": 63645724,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 167.06099999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.0189999999725,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.8080000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 591.5129999999998,
"heapDeltaBytes": 10499368,
"heapUsedBytes": 87034488,
"domNodes": -271,
"jsHeapTotalBytes": -2461696,
"scriptDurationMs": 31.62899999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.2789999999886,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.462000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 628.1160000000001,
"heapDeltaBytes": 7563056,
"heapUsedBytes": 83090288,
"domNodes": -271,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 37.481,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2156.189999999981,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.608000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1595.148,
"heapDeltaBytes": 18919028,
"heapUsedBytes": 85160260,
"domNodes": -275,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 807.596,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2314.2460000000256,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.675999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1681.6599999999999,
"heapDeltaBytes": 3105908,
"heapUsedBytes": 80501396,
"domNodes": -274,
"jsHeapTotalBytes": -1449984,
"scriptDurationMs": 832.5350000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3449.085000000025,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.188000000000002,
"layouts": 60,
"layoutDurationMs": 11.397,
"taskDurationMs": 1659.3519999999996,
"heapDeltaBytes": 8185680,
"heapUsedBytes": 76564004,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 762.225,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3535.400999999979,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.804000000000002,
"layouts": 60,
"layoutDurationMs": 12.012,
"taskDurationMs": 1749.6960000000001,
"heapDeltaBytes": -12349932,
"heapUsedBytes": 65970680,
"domNodes": -289,
"jsHeapTotalBytes": 2781184,
"scriptDurationMs": 771.379,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3190.872000000013,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.128999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2024.4520000000002,
"heapDeltaBytes": 4784352,
"heapUsedBytes": 85285752,
"domNodes": -289,
"jsHeapTotalBytes": 839680,
"scriptDurationMs": 1001.4719999999999,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3102.843000000007,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.855000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1932.25,
"heapDeltaBytes": 22111384,
"heapUsedBytes": 90054144,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 959.5580000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2031.661999999983,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.5050000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.814,
"heapDeltaBytes": 9071696,
"heapUsedBytes": 87468432,
"domNodes": -273,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 37.354,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2004.3590000000222,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 533.084,
"heapDeltaBytes": 22084272,
"heapUsedBytes": 88937168,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.464000000000006,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 586.6959999999608,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.383000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.3450000000001,
"heapDeltaBytes": 15013736,
"heapUsedBytes": 88230228,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 142.57,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 584.4520000000557,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.115999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.108,
"heapDeltaBytes": 15028920,
"heapUsedBytes": 87844620,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 139.27,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2018.070000000023,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.874000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.11400000000003,
"heapDeltaBytes": -14446128,
"heapUsedBytes": 58503988,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.781,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2018.2719999999676,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.633000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.18399999999997,
"heapDeltaBytes": 5897036,
"heapUsedBytes": 79246576,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.018,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1757.5809999999592,
"styleRecalcs": 78,
"styleRecalcDurationMs": 29.484,
"layouts": 18,
"layoutDurationMs": 4.875,
"taskDurationMs": 831.623,
"heapDeltaBytes": -15193632,
"heapUsedBytes": 57733464,
"domNodes": -296,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 113.115,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1770.1520000000528,
"styleRecalcs": 77,
"styleRecalcDurationMs": 29.549,
"layouts": 18,
"layoutDurationMs": 4.624,
"taskDurationMs": 821.704,
"heapDeltaBytes": -4629820,
"heapUsedBytes": 67739744,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 108.78500000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1416.8860000000336,
"styleRecalcs": 20,
"styleRecalcDurationMs": 32.485,
"layouts": 16,
"layoutDurationMs": 16.062,
"taskDurationMs": 943.6490000000002,
"heapDeltaBytes": 21320576,
"heapUsedBytes": 110680532,
"domNodes": 13831,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 31.82900000000001,
"eventListeners": 2385,
"totalBlockingTimeMs": 145,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8340.72599999996,
"styleRecalcs": 247,
"styleRecalcDurationMs": 33.851,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5783.564,
"heapDeltaBytes": 9100468,
"heapUsedBytes": 85664016,
"domNodes": -271,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 2720.546,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8456.504999999994,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.574999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5847.781999999999,
"heapDeltaBytes": 8586820,
"heapUsedBytes": 85326572,
"domNodes": -271,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 2720.258,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16901.52999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16338.155,
"heapDeltaBytes": -39468904,
"heapUsedBytes": 179440764,
"domNodes": -8068,
"jsHeapTotalBytes": -11853824,
"scriptDurationMs": 261.799,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16967.591999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16435.623,
"heapDeltaBytes": -41986012,
"heapUsedBytes": 177050712,
"domNodes": -8068,
"jsHeapTotalBytes": -11329536,
"scriptDurationMs": 307.55,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20789.962000000003,
"styleRecalcs": 172,
"styleRecalcDurationMs": 17.863000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20435.417999999998,
"heapDeltaBytes": -31627156,
"heapUsedBytes": 195217340,
"domNodes": -8068,
"jsHeapTotalBytes": -16707584,
"scriptDurationMs": 968.393,
"eventListeners": -14927,
"totalBlockingTimeMs": 134,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20723.299999999996,
"styleRecalcs": 168,
"styleRecalcDurationMs": 17.678000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20308.309999999998,
"heapDeltaBytes": -50965716,
"heapUsedBytes": 189327396,
"domNodes": -8068,
"jsHeapTotalBytes": -19668992,
"scriptDurationMs": 1013.6959999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 33,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6161.7069999999785,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.47700000000002,
"layouts": 20,
"layoutDurationMs": 22.613000000000007,
"taskDurationMs": 6042.904000000001,
"heapDeltaBytes": -34881848,
"heapUsedBytes": 184151968,
"domNodes": -8068,
"jsHeapTotalBytes": 14884864,
"scriptDurationMs": 114.07700000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 381,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6197.618999999918,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.843,
"layouts": 20,
"layoutDurationMs": 24.232000000000003,
"taskDurationMs": 6069.583,
"heapDeltaBytes": -32715736,
"heapUsedBytes": 180799084,
"domNodes": -8068,
"jsHeapTotalBytes": 17338368,
"scriptDurationMs": 112.576,
"eventListeners": -14929,
"totalBlockingTimeMs": 405,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8526.091000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8306.672,
"heapDeltaBytes": 19352208,
"heapUsedBytes": 179164092,
"domNodes": -26,
"jsHeapTotalBytes": -13369344,
"scriptDurationMs": 126.10100000000001,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8723.678000000064,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8378.448,
"heapDeltaBytes": -12445620,
"heapUsedBytes": 178212112,
"domNodes": 0,
"jsHeapTotalBytes": -19660800,
"scriptDurationMs": 165.47299999999998,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 452.44900000000143,
"styleRecalcs": 14,
"styleRecalcDurationMs": 20.598,
"layouts": 4,
"layoutDurationMs": 1.6409999999999998,
"taskDurationMs": 103.63,
"heapDeltaBytes": 4852032,
"heapUsedBytes": 74029124,
"domNodes": 120,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 10.126,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 450.9770000000799,
"styleRecalcs": 13,
"styleRecalcDurationMs": 18.766000000000002,
"layouts": 3,
"layoutDurationMs": 1.0939999999999999,
"taskDurationMs": 99.36899999999999,
"heapDeltaBytes": 4756856,
"heapUsedBytes": 73299068,
"domNodes": 119,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.120000000000001,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #19645 +/- ##
==========================================
Coverage 84.17% 84.17%
==========================================
Files 2112 2112
Lines 126520 126574 +54
Branches 32164 32180 +16
==========================================
+ Hits 106495 106542 +47
- Misses 19839 19846 +7
Partials 186 186
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Backport merged #19619 onto
core/1.54after prerequisite #19634 landed.Changes
Review Focus
Please verify the target-specific consent browser fixture adaptation and held-send cleanup when the panel closes during App Mode. Consent copy/policy, flags, billing, starter prompts, and backend behavior are unchanged.
Verification