Repository navigation
[backport cloud/1.54] feat(agent): keep panel open through activation - #19633
comfy-pr-bot merged 2 commits into
Conversation
Keep the Agent panel open after the startup/onboarding decision across cloud and local sessions, while preserving authentication and consent at the first-send boundary. - **What**: Opens the panel from the approved activation flow, allows the pre-consent panel shell to render, and holds the submitted draft while the existing login/consent flow completes. - **What**: Keeps workflow-selection restoration consent-gated and records distinct `activation` / `first_message` telemetry sources. - **Dependencies**: None. Please verify the cloud/local × logged-in/logged-out × consent state matrix and that a first send resumes exactly once after the existing handoff. - `pnpm test:unit src/workbench/extensions/agent/stores/agent/agentPanelStore.test.ts src/extensions/core/agentPanel.test.ts src/components/topbar/WorkflowTabs.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.ts --testTimeout=30000` (454 passed) - `NODE_OPTIONS=--max-old-space-size=8192 pnpm typecheck` - changed-file ESLint and full format check --------- Co-authored-by: GitHub Action <action@github.com>
|
@christian-byrne is attempting to deploy a commit to the ComfyUI Team on Vercel. A member of the Team first needs to authorize it. |
🎭 Playwright: ✅ 1962 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-30T16:25:24.259Z",
"gitSha": "1e0d0ef6845e7f9e6eb2b861239b7f2a70436b98",
"branch": "backport-19154-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2069.896999999969,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.381,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.539,
"heapDeltaBytes": 10369420,
"heapUsedBytes": 80510580,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.029,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2037.5470000000178,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.846000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.6909999999999,
"heapDeltaBytes": 7050604,
"heapUsedBytes": 77515028,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.229999999999997,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2244.4550000000163,
"styleRecalcs": 76,
"styleRecalcDurationMs": 34.109,
"layouts": 14,
"layoutDurationMs": 4.584,
"taskDurationMs": 1183.348,
"heapDeltaBytes": 4952304,
"heapUsedBytes": 75433632,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 201.23499999999999,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1824.4119999999953,
"styleRecalcs": 75,
"styleRecalcDurationMs": 28.729000000000006,
"layouts": 14,
"layoutDurationMs": 4.166,
"taskDurationMs": 882.759,
"heapDeltaBytes": -11432236,
"heapUsedBytes": 59573144,
"domNodes": -280,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 163.253,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.604000000019,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.439000000000004,
"layouts": 6,
"layoutDurationMs": 1.2510000000000001,
"taskDurationMs": 354.81399999999996,
"heapDeltaBytes": 4605080,
"heapUsedBytes": 75668680,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.627000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.4849999999396,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.168,
"layouts": 6,
"layoutDurationMs": 1.0339999999999998,
"taskDurationMs": 360.40299999999996,
"heapDeltaBytes": 4251644,
"heapUsedBytes": 74811636,
"domNodes": 74,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.759,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 690.6599999999798,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.332,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.52099999999996,
"heapDeltaBytes": 18613908,
"heapUsedBytes": 89215320,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 168.743,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 700.2309999999738,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.229000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.411,
"heapDeltaBytes": -7825796,
"heapUsedBytes": 63641204,
"domNodes": 18,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 171.35699999999997,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2052.4449999999774,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.054,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 612.3899999999999,
"heapDeltaBytes": 10414680,
"heapUsedBytes": 86814728,
"domNodes": -268,
"jsHeapTotalBytes": -2461696,
"scriptDurationMs": 32.715999999999994,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2072.744999999941,
"styleRecalcs": 8,
"styleRecalcDurationMs": 10.315999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 636.824,
"heapDeltaBytes": 5721156,
"heapUsedBytes": 82658456,
"domNodes": -277,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 33.82399999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2312.009000000046,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.839,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1692.234,
"heapDeltaBytes": 19375868,
"heapUsedBytes": 85710092,
"domNodes": -276,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 847.5630000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2306.5520000000106,
"styleRecalcs": 64,
"styleRecalcDurationMs": 12.473999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1684.9700000000003,
"heapDeltaBytes": 22493516,
"heapUsedBytes": 88789688,
"domNodes": -276,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 849.842,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3658.736000000033,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.944000000000003,
"layouts": 60,
"layoutDurationMs": 12.732999999999997,
"taskDurationMs": 1794.0100000000002,
"heapDeltaBytes": -7405032,
"heapUsedBytes": 71240120,
"domNodes": -292,
"jsHeapTotalBytes": 3567616,
"scriptDurationMs": 796.226,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3713.7390000000323,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.587000000000002,
"layouts": 60,
"layoutDurationMs": 12.502,
"taskDurationMs": 1819.16,
"heapDeltaBytes": -3164128,
"heapUsedBytes": 75978808,
"domNodes": -289,
"jsHeapTotalBytes": 2256896,
"scriptDurationMs": 808.0350000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3202.4260000000027,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.9899999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2014.5560000000003,
"heapDeltaBytes": 23288160,
"heapUsedBytes": 90912216,
"domNodes": -279,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 1005.397,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3137.9699999999957,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.285000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2089.813,
"heapDeltaBytes": 30119340,
"heapUsedBytes": 97628556,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1053.782,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2008.0859999999916,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.7160000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.697,
"heapDeltaBytes": 22154452,
"heapUsedBytes": 88301756,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.389,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2070.997000000034,
"styleRecalcs": 6,
"styleRecalcDurationMs": 9.517000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 634.3449999999999,
"heapDeltaBytes": 6791388,
"heapUsedBytes": 85447720,
"domNodes": -273,
"jsHeapTotalBytes": -626688,
"scriptDurationMs": 37.51800000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.3689999999901,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.162,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.184,
"heapDeltaBytes": 15202480,
"heapUsedBytes": 88325564,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 143.57199999999997,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 630.1220000000285,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.636000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.5849999999999,
"heapDeltaBytes": 14657480,
"heapUsedBytes": 87374788,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 152.14600000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2022.3489999999629,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.158999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.464,
"heapDeltaBytes": -5770036,
"heapUsedBytes": 67675164,
"domNodes": -295,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 7.895,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.9379999999774,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.552999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.0330000000001,
"heapDeltaBytes": 1538564,
"heapUsedBytes": 74651324,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.412999999999999,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1748.5880000000407,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.453000000000007,
"layouts": 18,
"layoutDurationMs": 4.633,
"taskDurationMs": 844.8310000000001,
"heapDeltaBytes": -8338920,
"heapUsedBytes": 65312880,
"domNodes": -297,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 114.212,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.2679999999673,
"styleRecalcs": 78,
"styleRecalcDurationMs": 29.607999999999997,
"layouts": 18,
"layoutDurationMs": 5.087,
"taskDurationMs": 847.0740000000001,
"heapDeltaBytes": 9173468,
"heapUsedBytes": 82626360,
"domNodes": -293,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 115.43500000000002,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.3680000000104,
"styleRecalcs": 19,
"styleRecalcDurationMs": 34.437000000000005,
"layouts": 15,
"layoutDurationMs": 16.78,
"taskDurationMs": 950.2469999999998,
"heapDeltaBytes": -4956856,
"heapUsedBytes": 85400328,
"domNodes": 13831,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 33.061,
"eventListeners": 2385,
"totalBlockingTimeMs": 157,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8581.46499999998,
"styleRecalcs": 247,
"styleRecalcDurationMs": 38.047,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5961.483,
"heapDeltaBytes": 2428864,
"heapUsedBytes": 78365384,
"domNodes": -249,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 2791.601,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8686.76199999993,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.10099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6038.7880000000005,
"heapDeltaBytes": -35926952,
"heapUsedBytes": 68003668,
"domNodes": -269,
"jsHeapTotalBytes": -1114112,
"scriptDurationMs": 2781.0519999999997,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17917.29799999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17085.380999999998,
"heapDeltaBytes": -54715872,
"heapUsedBytes": 183906180,
"domNodes": -8072,
"jsHeapTotalBytes": -9613312,
"scriptDurationMs": 284.192,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17737.078999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16998.381,
"heapDeltaBytes": -54746232,
"heapUsedBytes": 179620964,
"domNodes": -8068,
"jsHeapTotalBytes": -16666624,
"scriptDurationMs": 283.47999999999996,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21790.51499999997,
"styleRecalcs": 169,
"styleRecalcDurationMs": 21.123000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21523.816,
"heapDeltaBytes": -51177288,
"heapUsedBytes": 171755712,
"domNodes": -8068,
"jsHeapTotalBytes": -14163968,
"scriptDurationMs": 979.5350000000001,
"eventListeners": -14923,
"totalBlockingTimeMs": 151,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21569.165999999997,
"styleRecalcs": 175,
"styleRecalcDurationMs": 18.784999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21310.023999999998,
"heapDeltaBytes": -48773964,
"heapUsedBytes": 179620584,
"domNodes": -8068,
"jsHeapTotalBytes": -16990208,
"scriptDurationMs": 966.8459999999999,
"eventListeners": -14925,
"totalBlockingTimeMs": 41,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6261.838000000012,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.08900000000003,
"layouts": 20,
"layoutDurationMs": 23.884000000000015,
"taskDurationMs": 6115.426,
"heapDeltaBytes": -33905276,
"heapUsedBytes": 185293972,
"domNodes": -8068,
"jsHeapTotalBytes": 20389888,
"scriptDurationMs": 115.10499999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 375,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6312.59,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.60699999999999,
"layouts": 20,
"layoutDurationMs": 24.598999999999997,
"taskDurationMs": 6196.704,
"heapDeltaBytes": -45185844,
"heapUsedBytes": 183263148,
"domNodes": -8068,
"jsHeapTotalBytes": 11845632,
"scriptDurationMs": 115.12899999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 476,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8924.335000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8547.523999999998,
"heapDeltaBytes": 20546772,
"heapUsedBytes": 177520024,
"domNodes": 0,
"jsHeapTotalBytes": -6553600,
"scriptDurationMs": 169.51700000000002,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8917.958999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8509.485999999999,
"heapDeltaBytes": 22359100,
"heapUsedBytes": 179182812,
"domNodes": -4998,
"jsHeapTotalBytes": -9175040,
"scriptDurationMs": 136.61100000000005,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 477.9229999999757,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.787000000000003,
"layouts": 4,
"layoutDurationMs": 2.1449999999999996,
"taskDurationMs": 132.43200000000002,
"heapDeltaBytes": 5130492,
"heapUsedBytes": 74473100,
"domNodes": 147,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 11.906000000000002,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 108.30299999997806,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.354000000000001,
"layouts": 2,
"layoutDurationMs": 1.3889999999999998,
"taskDurationMs": 74.216,
"heapDeltaBytes": 2999156,
"heapUsedBytes": 71577884,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.197,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #19633 +/- ##
=============================================
Coverage ? 84.01%
=============================================
Files ? 2121
Lines ? 126992
Branches ? 32485
=============================================
Hits ? 106687
Misses ? 20126
Partials ? 179
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
…end (#19619) (#19644) ## Summary Backports merged #19619 onto cloud/1.54 after prerequisite #19633 landed. ## Changes - **What**: Preserves activation-open consent timing, holds the first send through consent and coach completion, releases exactly once on Finish or Skip, cancels on panel close, and records the activation-owned automatic-offer exit. - **Dependencies**: Requires merged cloud/1.54 prerequisite #19633. ## Review Focus Review the target-specific telemetry adapter in agentPanel.ts and the desktop-login browser fixture adaptation. The product behavior otherwise matches merged #19619; the target-deleted consent-outcome spec remains deleted. Validation: 476 focused unit tests passed; 25 Cloud consent/onboarding browser tests passed; app typecheck, changed-file lint/format, Cloud build, commit hooks, and pre-push Knip passed. Source: #19619
Backports #19154 onto
cloud/1.54after the automated cherry-pick conflicted.Preserves the approved Cloud/local × login × consent × returning-session activation behavior while retaining release-branch-only browser coverage and deleted fixtures. No #19619 behavior is included.
Tests:
pnpm test:unit src/workbench/extensions/agent/stores/agent/agentPanelStore.test.ts src/extensions/core/agentPanel.test.ts src/components/topbar/WorkflowTabs.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.ts --testTimeout=30000(483 passed)NODE_OPTIONS=--max-old-space-size=8192 pnpm buildpnpm build:cloudagentActivationConsent.spec.ts+agentConsent.spec.ts(19 passed)