Skip to content

[backport cloud/1.54] feat(agent): keep panel open through activation - #19633

Merged
comfy-pr-bot merged 2 commits into
Comfy-Org:cloud/1.54from
christian-byrne:backport-19154-to-cloud-1.54
Sep 30, 2026
Merged

comfy-pr-bot merged 2 commits into
Comfy-Org:cloud/1.54from
christian-byrne:backport-19154-to-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backports #19154 onto cloud/1.54 after the automated cherry-pick conflicted.

Preserves the approved Cloud/local × login × consent × returning-session activation behavior while retaining release-branch-only browser coverage and deleted fixtures. No #19619 behavior is included.

Tests:

  • pnpm test:unit src/workbench/extensions/agent/stores/agent/agentPanelStore.test.ts src/extensions/core/agentPanel.test.ts src/components/topbar/WorkflowTabs.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.ts --testTimeout=30000 (483 passed)
  • NODE_OPTIONS=--max-old-space-size=8192 pnpm build
  • pnpm build:cloud
  • offline Cloud Playwright: agentActivationConsent.spec.ts + agentConsent.spec.ts (19 passed)
  • commit hooks: changed-file format/lint, app/browser typecheck, Knip

Keep the Agent panel open after the startup/onboarding decision across
cloud and local sessions, while preserving authentication and consent at
the first-send boundary.

- **What**: Opens the panel from the approved activation flow, allows
the pre-consent panel shell to render, and holds the submitted draft
while the existing login/consent flow completes.
- **What**: Keeps workflow-selection restoration consent-gated and
records distinct `activation` / `first_message` telemetry sources.
- **Dependencies**: None.

Please verify the cloud/local × logged-in/logged-out × consent state
matrix and that a first send resumes exactly once after the existing
handoff.

- `pnpm test:unit
src/workbench/extensions/agent/stores/agent/agentPanelStore.test.ts
src/extensions/core/agentPanel.test.ts
src/components/topbar/WorkflowTabs.test.ts
src/workbench/extensions/agent/AgentPanelRoot.test.ts
--testTimeout=30000` (454 passed)
- `NODE_OPTIONS=--max-old-space-size=8192 pnpm typecheck`
- changed-file ESLint and full format check

---------

Co-authored-by: GitHub Action <action@github.com>
@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Sep 30, 2026
@vercel

vercel Bot commented Sep 30, 2026

Copy link
Copy Markdown

@christian-byrne is attempting to deploy a commit to the ComfyUI Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1962 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1941 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/30/2026, 04:15:55 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.2 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 89.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.9 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.5 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 157ms TBT · 81.4 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.8 MB heap
vue-large-graph-idle: · 54.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 173.3 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 96ms TBT · 167.5 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 426ms TBT · 175.7 MB heap
vue-zoom-out-idle: · 55.4 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 11ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 547ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 75.4 MB
canvas-idle: DOM nodes -279
canvas-idle: event listeners -164
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 31ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 1033ms
canvas-mouse-sweep: script duration 182ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 64.4 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -165
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 358ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.8 MB
canvas-zoom-sweep: DOM nodes 75
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 468ms
dom-widget-clipping: script duration 170ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.9 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 8ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 625ms
large-graph-idle: script duration 33ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 80.8 MB
large-graph-idle: DOM nodes -273
large-graph-idle: event listeners -178
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 64
large-graph-pan: task duration 1689ms
large-graph-pan: script duration 849ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 83.2 MB
large-graph-pan: DOM nodes -276
large-graph-pan: event listeners -78
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 63
large-graph-zoom: task duration 1807ms
large-graph-zoom: script duration 802ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 70.2 MB
large-graph-zoom: DOM nodes -291
large-graph-zoom: event listeners -196
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 2052ms
legacy-node-drag: script duration 1030ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 89.9 MB
legacy-node-drag: DOM nodes -140
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 7ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 601ms
minimap-idle: script duration 35ms
minimap-idle: TBT 0ms
minimap-idle: heap used 82.9 MB
minimap-idle: DOM nodes -273
minimap-idle: event listeners -177
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 430ms
subgraph-dom-widget-clipping: script duration 148ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.8 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 11ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 501ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 67.9 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -240
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 29ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 846ms
subgraph-mouse-sweep: script duration 115ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 70.5 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -227
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 17ms
subgraph-transition-enter: style recalc duration 34ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 950ms
subgraph-transition-enter: script duration 33ms
subgraph-transition-enter: TBT 157ms
subgraph-transition-enter: heap used 81.4 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 6000ms
viewport-pan-sweep: script duration 2786ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 69.8 MB
viewport-pan-sweep: DOM nodes -259
viewport-pan-sweep: event listeners -161
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17042ms
vue-large-graph-idle: script duration 284ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 173.3 MB
vue-large-graph-idle: DOM nodes -8070
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 172
vue-large-graph-pan: task duration 21417ms
vue-large-graph-pan: script duration 973ms
vue-large-graph-pan: TBT 96ms
vue-large-graph-pan: heap used 167.5 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14924
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 83ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6156ms
vue-node-resize-workload: script duration 115ms
vue-node-resize-workload: TBT 426ms
vue-node-resize-workload: heap used 175.7 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14927
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8529ms
vue-zoom-out-idle: script duration 153ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 170.1 MB
vue-zoom-out-idle: DOM nodes -2499
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 21ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 103ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.6 MB
workflow-execution: DOM nodes 137
workflow-execution: event listeners 42
Raw data
{
  "timestamp": "2026-09-30T16:25:24.259Z",
  "gitSha": "1e0d0ef6845e7f9e6eb2b861239b7f2a70436b98",
  "branch": "backport-19154-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2069.896999999969,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.381,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 579.539,
      "heapDeltaBytes": 10369420,
      "heapUsedBytes": 80510580,
      "domNodes": -280,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 10.029,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2037.5470000000178,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 10.846000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 513.6909999999999,
      "heapDeltaBytes": 7050604,
      "heapUsedBytes": 77515028,
      "domNodes": -277,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.229999999999997,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2244.4550000000163,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 34.109,
      "layouts": 14,
      "layoutDurationMs": 4.584,
      "taskDurationMs": 1183.348,
      "heapDeltaBytes": 4952304,
      "heapUsedBytes": 75433632,
      "domNodes": -280,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 201.23499999999999,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1824.4119999999953,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 28.729000000000006,
      "layouts": 14,
      "layoutDurationMs": 4.166,
      "taskDurationMs": 882.759,
      "heapDeltaBytes": -11432236,
      "heapUsedBytes": 59573144,
      "domNodes": -280,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 163.253,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1740.604000000019,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.439000000000004,
      "layouts": 6,
      "layoutDurationMs": 1.2510000000000001,
      "taskDurationMs": 354.81399999999996,
      "heapDeltaBytes": 4605080,
      "heapUsedBytes": 75668680,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 11.627000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1720.4849999999396,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.168,
      "layouts": 6,
      "layoutDurationMs": 1.0339999999999998,
      "taskDurationMs": 360.40299999999996,
      "heapDeltaBytes": 4251644,
      "heapUsedBytes": 74811636,
      "domNodes": 74,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 10.759,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 690.6599999999798,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.332,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 471.52099999999996,
      "heapDeltaBytes": 18613908,
      "heapUsedBytes": 89215320,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 168.743,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 700.2309999999738,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.229000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 465.411,
      "heapDeltaBytes": -7825796,
      "heapUsedBytes": 63641204,
      "domNodes": 18,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 171.35699999999997,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2052.4449999999774,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.054,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 612.3899999999999,
      "heapDeltaBytes": 10414680,
      "heapUsedBytes": 86814728,
      "domNodes": -268,
      "jsHeapTotalBytes": -2461696,
      "scriptDurationMs": 32.715999999999994,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2072.744999999941,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 10.315999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 636.824,
      "heapDeltaBytes": 5721156,
      "heapUsedBytes": 82658456,
      "domNodes": -277,
      "jsHeapTotalBytes": -1150976,
      "scriptDurationMs": 33.82399999999999,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2312.009000000046,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 9.839,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1692.234,
      "heapDeltaBytes": 19375868,
      "heapUsedBytes": 85710092,
      "domNodes": -276,
      "jsHeapTotalBytes": 1011712,
      "scriptDurationMs": 847.5630000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2306.5520000000106,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 12.473999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1684.9700000000003,
      "heapDeltaBytes": 22493516,
      "heapUsedBytes": 88789688,
      "domNodes": -276,
      "jsHeapTotalBytes": 1011712,
      "scriptDurationMs": 849.842,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3658.736000000033,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 11.944000000000003,
      "layouts": 60,
      "layoutDurationMs": 12.732999999999997,
      "taskDurationMs": 1794.0100000000002,
      "heapDeltaBytes": -7405032,
      "heapUsedBytes": 71240120,
      "domNodes": -292,
      "jsHeapTotalBytes": 3567616,
      "scriptDurationMs": 796.226,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3713.7390000000323,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 13.587000000000002,
      "layouts": 60,
      "layoutDurationMs": 12.502,
      "taskDurationMs": 1819.16,
      "heapDeltaBytes": -3164128,
      "heapUsedBytes": 75978808,
      "domNodes": -289,
      "jsHeapTotalBytes": 2256896,
      "scriptDurationMs": 808.0350000000001,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3202.4260000000027,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.9899999999999975,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2014.5560000000003,
      "heapDeltaBytes": 23288160,
      "heapUsedBytes": 90912216,
      "domNodes": -279,
      "jsHeapTotalBytes": 1466368,
      "scriptDurationMs": 1005.397,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3137.9699999999957,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.285000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2089.813,
      "heapDeltaBytes": 30119340,
      "heapUsedBytes": 97628556,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 1053.782,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2008.0859999999916,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.7160000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 566.697,
      "heapDeltaBytes": 22154452,
      "heapUsedBytes": 88301756,
      "domNodes": -273,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 33.389,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2070.997000000034,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 9.517000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 634.3449999999999,
      "heapDeltaBytes": 6791388,
      "heapUsedBytes": 85447720,
      "domNodes": -273,
      "jsHeapTotalBytes": -626688,
      "scriptDurationMs": 37.51800000000001,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 574.3689999999901,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.162,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 419.184,
      "heapDeltaBytes": 15202480,
      "heapUsedBytes": 88325564,
      "domNodes": 18,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 143.57199999999997,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 630.1220000000285,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 12.636000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 441.5849999999999,
      "heapDeltaBytes": 14657480,
      "heapUsedBytes": 87374788,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 152.14600000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.3489999999629,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 11.158999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 504.464,
      "heapDeltaBytes": -5770036,
      "heapUsedBytes": 67675164,
      "domNodes": -295,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 7.895,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.9379999999774,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 10.552999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 497.0330000000001,
      "heapDeltaBytes": 1538564,
      "heapUsedBytes": 74651324,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.412999999999999,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1748.5880000000407,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 27.453000000000007,
      "layouts": 18,
      "layoutDurationMs": 4.633,
      "taskDurationMs": 844.8310000000001,
      "heapDeltaBytes": -8338920,
      "heapUsedBytes": 65312880,
      "domNodes": -297,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 114.212,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1742.2679999999673,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 29.607999999999997,
      "layouts": 18,
      "layoutDurationMs": 5.087,
      "taskDurationMs": 847.0740000000001,
      "heapDeltaBytes": 9173468,
      "heapUsedBytes": 82626360,
      "domNodes": -293,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 115.43500000000002,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1417.3680000000104,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 34.437000000000005,
      "layouts": 15,
      "layoutDurationMs": 16.78,
      "taskDurationMs": 950.2469999999998,
      "heapDeltaBytes": -4956856,
      "heapUsedBytes": 85400328,
      "domNodes": 13831,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 33.061,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 157,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8581.46499999998,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 38.047,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5961.483,
      "heapDeltaBytes": 2428864,
      "heapUsedBytes": 78365384,
      "domNodes": -249,
      "jsHeapTotalBytes": -401408,
      "scriptDurationMs": 2791.601,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8686.76199999993,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 36.10099999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6038.7880000000005,
      "heapDeltaBytes": -35926952,
      "heapUsedBytes": 68003668,
      "domNodes": -269,
      "jsHeapTotalBytes": -1114112,
      "scriptDurationMs": 2781.0519999999997,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17917.29799999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17085.380999999998,
      "heapDeltaBytes": -54715872,
      "heapUsedBytes": 183906180,
      "domNodes": -8072,
      "jsHeapTotalBytes": -9613312,
      "scriptDurationMs": 284.192,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17737.078999999994,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16998.381,
      "heapDeltaBytes": -54746232,
      "heapUsedBytes": 179620964,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16666624,
      "scriptDurationMs": 283.47999999999996,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.886666666666617,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21790.51499999997,
      "styleRecalcs": 169,
      "styleRecalcDurationMs": 21.123000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21523.816,
      "heapDeltaBytes": -51177288,
      "heapUsedBytes": 171755712,
      "domNodes": -8068,
      "jsHeapTotalBytes": -14163968,
      "scriptDurationMs": 979.5350000000001,
      "eventListeners": -14923,
      "totalBlockingTimeMs": 151,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21569.165999999997,
      "styleRecalcs": 175,
      "styleRecalcDurationMs": 18.784999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21310.023999999998,
      "heapDeltaBytes": -48773964,
      "heapUsedBytes": 179620584,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16990208,
      "scriptDurationMs": 966.8459999999999,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 41,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6261.838000000012,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 81.08900000000003,
      "layouts": 20,
      "layoutDurationMs": 23.884000000000015,
      "taskDurationMs": 6115.426,
      "heapDeltaBytes": -33905276,
      "heapUsedBytes": 185293972,
      "domNodes": -8068,
      "jsHeapTotalBytes": 20389888,
      "scriptDurationMs": 115.10499999999999,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 375,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6312.59,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 84.60699999999999,
      "layouts": 20,
      "layoutDurationMs": 24.598999999999997,
      "taskDurationMs": 6196.704,
      "heapDeltaBytes": -45185844,
      "heapUsedBytes": 183263148,
      "domNodes": -8068,
      "jsHeapTotalBytes": 11845632,
      "scriptDurationMs": 115.12899999999999,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 476,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8924.335000000043,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8547.523999999998,
      "heapDeltaBytes": 20546772,
      "heapUsedBytes": 177520024,
      "domNodes": 0,
      "jsHeapTotalBytes": -6553600,
      "scriptDurationMs": 169.51700000000002,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8917.958999999995,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8509.485999999999,
      "heapDeltaBytes": 22359100,
      "heapUsedBytes": 179182812,
      "domNodes": -4998,
      "jsHeapTotalBytes": -9175040,
      "scriptDurationMs": 136.61100000000005,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.330000000000048,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 477.9229999999757,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 25.787000000000003,
      "layouts": 4,
      "layoutDurationMs": 2.1449999999999996,
      "taskDurationMs": 132.43200000000002,
      "heapDeltaBytes": 5130492,
      "heapUsedBytes": 74473100,
      "domNodes": 147,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 11.906000000000002,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "workflow-execution",
      "durationMs": 108.30299999997806,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 15.354000000000001,
      "layouts": 2,
      "layoutDurationMs": 1.3889999999999998,
      "taskDurationMs": 74.216,
      "heapDeltaBytes": 2999156,
      "heapUsedBytes": 71577884,
      "domNodes": 126,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 5.197,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50763 76060 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.3% 253
src/scripts/pnginfo.ts 21.4% 221

@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 65feec86-0cb7-4b84-a015-78101f85c590

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@github-actions
github-actions Bot requested a review from ryan-di September 30, 2026 15:09
@christian-byrne christian-byrne assigned DrJKL and unassigned ryan-di Sep 30, 2026
@DrJKL
DrJKL self-requested a review September 30, 2026 15:28
@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/extensions/core/agentPanel.ts 89.47% 2 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #19633   +/-   ##
=============================================
  Coverage              ?   84.01%           
=============================================
  Files                 ?     2121           
  Lines                 ?   126992           
  Branches              ?    32485           
=============================================
  Hits                  ?   106687           
  Misses                ?    20126           
  Partials              ?      179           
Flag Coverage Δ
e2e 66.76% <100.00%> (?)
unit 79.17% <94.59%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/telemetry/types.ts 92.59% <ø> (ø)
src/workbench/extensions/agent/AgentPanelRoot.vue 91.99% <100.00%> (ø)
...h/extensions/agent/stores/agent/agentPanelStore.ts 97.08% <100.00%> (ø)
src/extensions/core/agentPanel.ts 96.92% <89.47%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-official

This comment has been minimized.

@comfy-pr-bot
comfy-pr-bot merged commit 5ab40c1 into Comfy-Org:cloud/1.54 Sep 30, 2026
90 of 92 checks passed
comfy-pr-bot pushed a commit that referenced this pull request Sep 30, 2026
…end (#19619) (#19644)

## Summary

Backports merged #19619 onto cloud/1.54 after prerequisite #19633
landed.

## Changes

- **What**: Preserves activation-open consent timing, holds the first
send through consent and coach completion, releases exactly once on
Finish or Skip, cancels on panel close, and records the activation-owned
automatic-offer exit.
- **Dependencies**: Requires merged cloud/1.54 prerequisite #19633.

## Review Focus

Review the target-specific telemetry adapter in agentPanel.ts and the
desktop-login browser fixture adaptation. The product behavior otherwise
matches merged #19619; the target-deleted consent-outcome spec remains
deleted.

Validation: 476 focused unit tests passed; 25 Cloud consent/onboarding
browser tests passed; app typecheck, changed-file lint/format, Cloud
build, commit hooks, and pre-push Knip passed.

Source: #19619
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants