Repository navigation
[backport cloud/1.54] fix(agent): sequence consent tour before held send (#19619) - #19644
Conversation
Keep a freshly activated Agent panel usable before consent, then resume its held first message exactly once after the user finishes or skips the Agent tour. - **What**: Defer the automatic consent card for activation-opened sessions, retain the existing first-message consent gate, and hold that submission until the newly required Agent coach finishes or is skipped. - This intentionally changes only activation-opened sessions: their automatic `first_load` offer is dropped for the page session so the user can type first; restored-open sessions retain the existing automatic offer. - Record that drop as `activation_opened_panel` on `agent_consent_offer_exited` so the funnel distinguishes it from an offer that was never owed. - Add finish and skip browser regressions covering consent persistence, exactly-once send, panel reopen without a consent loop, and cancellation if the panel closes during App Mode. Please verify the activation-only consent boundary, waiter initialization/cleanup across App Mode remounts, and held-send cancellation when the panel closes. Wording, flags, billing, starter prompts, and backend behavior are unchanged. - Focused AgentPanelRoot App Mode/close tests: 2/2 passed. - Focused agentPanel activation/telemetry tests: 2/2 passed. - Commit hooks passed formatting, changed-file lint, and app typecheck. - The previous head passed 11/11 focused Cloud browser scenarios; hosted CI is rerunning on the review-repair head.
|
@christian-byrne is attempting to deploy a commit to the ComfyUI Team on Vercel. A member of the Team first needs to authorize it. |
🎭 Playwright: ✅ 1962 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-30T18:42:02.316Z",
"gitSha": "cb1d22c166885a9f742da2402446f7aa57bbca78",
"branch": "backport-19619-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2004.4430000000375,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.749,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.30800000000005,
"heapDeltaBytes": 5160080,
"heapUsedBytes": 75577740,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.296,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2029.5839999999998,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.007000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.819,
"heapDeltaBytes": -11094556,
"heapUsedBytes": 58501392,
"domNodes": -280,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.810999999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1831.7779999999857,
"styleRecalcs": 75,
"styleRecalcDurationMs": 26.477999999999998,
"layouts": 14,
"layoutDurationMs": 4.881,
"taskDurationMs": 811.173,
"heapDeltaBytes": -12079664,
"heapUsedBytes": 58788164,
"domNodes": -277,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 135.173,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1727.6279999999815,
"styleRecalcs": 73,
"styleRecalcDurationMs": 21.906,
"layouts": 14,
"layoutDurationMs": 3.438,
"taskDurationMs": 679.788,
"heapDeltaBytes": -4930728,
"heapUsedBytes": 66461080,
"domNodes": -281,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 115.388,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1657.1030000000064,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.547999999999998,
"layouts": 6,
"layoutDurationMs": 0.9780000000000001,
"taskDurationMs": 280.37199999999996,
"heapDeltaBytes": 4509488,
"heapUsedBytes": 75445376,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.037,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.9880000000157,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.943,
"layouts": 6,
"layoutDurationMs": 1.7830000000000004,
"taskDurationMs": 297.97,
"heapDeltaBytes": 4295296,
"heapUsedBytes": 74842908,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.485999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 627.3279999999772,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.398,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.819,
"heapDeltaBytes": -7890240,
"heapUsedBytes": 63306148,
"domNodes": 20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 136.276,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 537.5870000000305,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.707,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 357.35,
"heapDeltaBytes": -6583292,
"heapUsedBytes": 64995108,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 125.37500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2041.058000000021,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.034999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 562.1200000000001,
"heapDeltaBytes": 8517400,
"heapUsedBytes": 84813348,
"domNodes": -268,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 30.793,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2025.3689999999551,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.122,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.43100000000004,
"heapDeltaBytes": 8312404,
"heapUsedBytes": 84777688,
"domNodes": -268,
"jsHeapTotalBytes": -626688,
"scriptDurationMs": 27.436999999999998,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2170.6310000000144,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.235999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1345.4,
"heapDeltaBytes": 8606588,
"heapUsedBytes": 86137164,
"domNodes": -269,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 645.418,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2131.0889999999745,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.892999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1307.188,
"heapDeltaBytes": 462568,
"heapUsedBytes": 77863136,
"domNodes": -245,
"jsHeapTotalBytes": 909312,
"scriptDurationMs": 655.9350000000001,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3234.540999999979,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.361000000000002,
"layouts": 60,
"layoutDurationMs": 11.494,
"taskDurationMs": 1425.4859999999999,
"heapDeltaBytes": 9795336,
"heapUsedBytes": 77020208,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 646.8779999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3196.903999999961,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.241,
"layouts": 60,
"layoutDurationMs": 11.136999999999999,
"taskDurationMs": 1360.7089999999998,
"heapDeltaBytes": 9068580,
"heapUsedBytes": 76861168,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 629.5150000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2453.22299999998,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.423999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1572.373,
"heapDeltaBytes": 20331876,
"heapUsedBytes": 88075224,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 790.1929999999999,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2617.3840000000155,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.636999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1612.553,
"heapDeltaBytes": 3529648,
"heapUsedBytes": 84279516,
"domNodes": -279,
"jsHeapTotalBytes": -208896,
"scriptDurationMs": 809.681,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2033.2539999999995,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.4460000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.98699999999997,
"heapDeltaBytes": 5925144,
"heapUsedBytes": 83373520,
"domNodes": -276,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 29.162,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2027.8200000000197,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.178999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.433,
"heapDeltaBytes": 7552316,
"heapUsedBytes": 85696384,
"domNodes": -272,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 27.499000000000002,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 541.6609999999764,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.658,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.147,
"heapDeltaBytes": 14817312,
"heapUsedBytes": 88433108,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 117.532,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 507.29999999998654,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.842,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 319.51099999999997,
"heapDeltaBytes": 14264356,
"heapUsedBytes": 87017244,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 111.272,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.6230000000005,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.613999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.88200000000006,
"heapDeltaBytes": -8362240,
"heapUsedBytes": 65204216,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.29,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1993.2259999999928,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.5440000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.514,
"heapDeltaBytes": -10429544,
"heapUsedBytes": 62530016,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 6.155999999999998,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.707000000004,
"styleRecalcs": 77,
"styleRecalcDurationMs": 23.025000000000002,
"layouts": 18,
"layoutDurationMs": 4.024000000000001,
"taskDurationMs": 677.414,
"heapDeltaBytes": -2171932,
"heapUsedBytes": 70505076,
"domNodes": -295,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 90.45400000000001,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.4040000000246,
"styleRecalcs": 77,
"styleRecalcDurationMs": 21.544999999999998,
"layouts": 18,
"layoutDurationMs": 3.815000000000001,
"taskDurationMs": 637.942,
"heapDeltaBytes": 4227624,
"heapUsedBytes": 77713796,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 79.786,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 900.3830000000335,
"styleRecalcs": 20,
"styleRecalcDurationMs": 24.647999999999996,
"layouts": 16,
"layoutDurationMs": 11.764,
"taskDurationMs": 729.9789999999999,
"heapDeltaBytes": 22062316,
"heapUsedBytes": 106481968,
"domNodes": 13831,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 22.153999999999993,
"eventListeners": 2385,
"totalBlockingTimeMs": 98,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8327.731000000029,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.413999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4863.718000000001,
"heapDeltaBytes": 6821664,
"heapUsedBytes": 83601264,
"domNodes": -274,
"jsHeapTotalBytes": 647168,
"scriptDurationMs": 2221.2929999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8161.707999999976,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.474,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4637.213,
"heapDeltaBytes": -7987360,
"heapUsedBytes": 68615588,
"domNodes": -278,
"jsHeapTotalBytes": 1994752,
"scriptDurationMs": 2154.3179999999998,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14953.991999999971,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14532.426000000001,
"heapDeltaBytes": -46038772,
"heapUsedBytes": 172442428,
"domNodes": -8068,
"jsHeapTotalBytes": -10219520,
"scriptDurationMs": 225.267,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 14639.229,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14009.91,
"heapDeltaBytes": -30135180,
"heapUsedBytes": 176786832,
"domNodes": -8068,
"jsHeapTotalBytes": -13103104,
"scriptDurationMs": 239.39500000000004,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 17433.741999999995,
"styleRecalcs": 147,
"styleRecalcDurationMs": 14.829999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17008.619,
"heapDeltaBytes": -38945752,
"heapUsedBytes": 189992068,
"domNodes": -8068,
"jsHeapTotalBytes": -15163392,
"scriptDurationMs": 760.38,
"eventListeners": -14931,
"totalBlockingTimeMs": 31,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17159.840000000033,
"styleRecalcs": 146,
"styleRecalcDurationMs": 14.36800000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16702.142,
"heapDeltaBytes": -39261384,
"heapUsedBytes": 179852064,
"domNodes": -8068,
"jsHeapTotalBytes": -10743808,
"scriptDurationMs": 725.511,
"eventListeners": -14929,
"totalBlockingTimeMs": 41,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 5189.881999999954,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.536,
"layouts": 20,
"layoutDurationMs": 20.533999999999995,
"taskDurationMs": 5118.243,
"heapDeltaBytes": -40915160,
"heapUsedBytes": 191423508,
"domNodes": -8076,
"jsHeapTotalBytes": 10244096,
"scriptDurationMs": 82.128,
"eventListeners": -14931,
"totalBlockingTimeMs": 205,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5170.480999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.67400000000001,
"layouts": 20,
"layoutDurationMs": 21.654999999999994,
"taskDurationMs": 5049.729000000001,
"heapDeltaBytes": -36454656,
"heapUsedBytes": 182115136,
"domNodes": -8068,
"jsHeapTotalBytes": 17043456,
"scriptDurationMs": 92.25999999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 237,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7343.330999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7074.446000000002,
"heapDeltaBytes": 11148356,
"heapUsedBytes": 190615064,
"domNodes": 0,
"jsHeapTotalBytes": -14680064,
"scriptDurationMs": 107.74299999999998,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7018.219000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6798.7159999999985,
"heapDeltaBytes": 27067060,
"heapUsedBytes": 205151976,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 92.80100000000002,
"eventListeners": 16,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 84.7479999999905,
"styleRecalcs": 7,
"styleRecalcDurationMs": 10.406999999999998,
"layouts": 2,
"layoutDurationMs": 0.8840000000000001,
"taskDurationMs": 55.671000000000014,
"heapDeltaBytes": 3070296,
"heapUsedBytes": 72232184,
"domNodes": 127,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.311999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 80.26599999993778,
"styleRecalcs": 6,
"styleRecalcDurationMs": 11.379999999999997,
"layouts": 2,
"layoutDurationMs": 0.987,
"taskDurationMs": 53.989999999999995,
"heapDeltaBytes": 2997480,
"heapUsedBytes": 72486848,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 3.838000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #19644 +/- ##
=============================================
Coverage ? 84.01%
=============================================
Files ? 2121
Lines ? 127047
Branches ? 32215
=============================================
Hits ? 106735
Misses ? 20133
Partials ? 179
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Summary
Backports merged #19619 onto cloud/1.54 after prerequisite #19633 landed.
Changes
Review Focus
Review the target-specific telemetry adapter in agentPanel.ts and the desktop-login browser fixture adaptation. The product behavior otherwise matches merged #19619; the target-deleted consent-outcome spec remains deleted.
Validation: 476 focused unit tests passed; 25 Cloud consent/onboarding browser tests passed; app typecheck, changed-file lint/format, Cloud build, commit hooks, and pre-push Knip passed.
Source: #19619