Repository navigation
[backport cloud/1.55] Don't gate asset updates on sidebar, smarter page sizes - #19542
Conversation
When a websocket event indicated that new assets were available, a load event would only be triggered if assets were in a visible state. This clashes with the need to have asset information available in more places and results in a degraded user experience (The responsiveness of a user opening the assets panel was gated on the time it took to reload asset state) Set `include_public: false` as a default option. - In my personal testing, I had thought this would already be the default. Since this appears to not always be the case it is formally specified. - The intent is that public assets, as with `temp` assets, should be exposed as a filter option on the assets sidebar. This doesn't mesh as well as I would like with my current caching system. I will need further consideration to ensure things remain performant even once such a system has been added. Added context aware page sizes. - Loading too many assets is rarely problematic. The base page size has been quintupled to `100` - LoadingNew is usually performed after a single node produces an output. Usually this results in a single asset, so the page size is kept small. After the first iteration, the page size returns to the default to better handle long tail edge cases (Someone pipes a 1000 frame video into a 'Save Image') See #18046 I strongly believe that defaults should be used whenever possible. Making page size frontend specified means - We choose not to trust the server's ability to make informed decisions about page size. (i.e. Local has lower roundtrip latency so it's more responsive with small page size) - We loose the ability to change the behaviour without frontend code updates - AI bots wind up writing change detector tests that verify arbitrary numbers instead of actual performance characteristics. The change here is more justifiable to me since it leverages information the frontend has that the backend does not. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since a2925d19e7e6434d28307f543ec9d53ff8eceb0a
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2121 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-30T02:49:00.657Z",
"gitSha": "b70b89aaaba6b16486739376f993008ce7bb3dba",
"branch": "austin/backport-18633-cloud-1-55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2014.7269999999935,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.324000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.19,
"heapDeltaBytes": -2031992,
"heapUsedBytes": 65762636,
"domNodes": -260,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.118,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1990.9639999999627,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.959000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.4290000000001,
"heapDeltaBytes": 4027184,
"heapUsedBytes": 71724596,
"domNodes": -259,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 7.885,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1758.1470000000081,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.475000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 789.5830000000001,
"heapDeltaBytes": 9305244,
"heapUsedBytes": 77007460,
"domNodes": -260,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 147.79600000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1741.5099999999484,
"styleRecalcs": 47,
"styleRecalcDurationMs": 14.690999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 771.4879999999999,
"heapDeltaBytes": -6293120,
"heapUsedBytes": 61379220,
"domNodes": -258,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 143.068,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1666.486999999961,
"styleRecalcs": 33,
"styleRecalcDurationMs": 15.897000000000002,
"layouts": 6,
"layoutDurationMs": 1.2240000000000002,
"taskDurationMs": 352.47599999999994,
"heapDeltaBytes": 3016652,
"heapUsedBytes": 70888860,
"domNodes": 81,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.049000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.9420000000555,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.911000000000001,
"layouts": 6,
"layoutDurationMs": 1.298,
"taskDurationMs": 338.78200000000004,
"heapDeltaBytes": 2838876,
"heapUsedBytes": 70419764,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.895,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 659.9690000000464,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.7459999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.2510000000001,
"heapDeltaBytes": 18664464,
"heapUsedBytes": 86319852,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 160.04700000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 596.8989999998939,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.498000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.92800000000005,
"heapDeltaBytes": 18858668,
"heapUsedBytes": 86612536,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 163.022,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1210.581999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 911.2389999999999,
"heapDeltaBytes": -13726188,
"heapUsedBytes": 72671888,
"domNodes": -294,
"jsHeapTotalBytes": 19005440,
"scriptDurationMs": 61.024999999999984,
"eventListeners": -217,
"totalBlockingTimeMs": 548,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1176.9950000000335,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 865.1949999999999,
"heapDeltaBytes": -17994472,
"heapUsedBytes": 72612052,
"domNodes": -293,
"jsHeapTotalBytes": 20840448,
"scriptDurationMs": 63.735000000000014,
"eventListeners": -217,
"totalBlockingTimeMs": 521,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.9910000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.2809999999995,
"heapDeltaBytes": 14744828,
"heapUsedBytes": 90921040,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 143.09700000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 222,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 841.2989999999354,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.8119999999998,
"heapDeltaBytes": 14643204,
"heapUsedBytes": 91074896,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 135.93800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 219,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9135.700999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8242.557999999999,
"heapDeltaBytes": 2737600,
"heapUsedBytes": 85778120,
"domNodes": -16,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 6832.179,
"eventListeners": 0,
"totalBlockingTimeMs": 521,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8929.709000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8208.976,
"heapDeltaBytes": 11119560,
"heapUsedBytes": 93187092,
"domNodes": -18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 6646.646,
"eventListeners": 0,
"totalBlockingTimeMs": 183,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9546.812000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8680.319000000001,
"heapDeltaBytes": -1639364,
"heapUsedBytes": 80803760,
"domNodes": -16,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 7007.22,
"eventListeners": 0,
"totalBlockingTimeMs": 484,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9216.438000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8319.49,
"heapDeltaBytes": -12580460,
"heapUsedBytes": 69493212,
"domNodes": -14,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 6758.291000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 107,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2047.819000000004,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.574000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 624.9830000000001,
"heapDeltaBytes": -2995696,
"heapUsedBytes": 83776368,
"domNodes": -245,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 40.976,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2031.4079999999421,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.311999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.9630000000001,
"heapDeltaBytes": -3669208,
"heapUsedBytes": 83601968,
"domNodes": -242,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 31.06500000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2351.9410000000107,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.214000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1680.8680000000002,
"heapDeltaBytes": -10640316,
"heapUsedBytes": 77386664,
"domNodes": -240,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 850.5429999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2192.923999999948,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.518999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1547.305,
"heapDeltaBytes": 16151832,
"heapUsedBytes": 80290032,
"domNodes": -240,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 797.531,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3595.8870000000047,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.812999999999999,
"layouts": 60,
"layoutDurationMs": 14.943999999999999,
"taskDurationMs": 1727.523,
"heapDeltaBytes": 9980928,
"heapUsedBytes": 75173760,
"domNodes": -250,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 798.9269999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3471.7699999999923,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.802000000000001,
"layouts": 60,
"layoutDurationMs": 14.083000000000002,
"taskDurationMs": 1646.0330000000001,
"heapDeltaBytes": 9841084,
"heapUsedBytes": 75068868,
"domNodes": -250,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 769.019,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3137.745999999993,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.587999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1963.4170000000001,
"heapDeltaBytes": 26302292,
"heapUsedBytes": 92363236,
"domNodes": -251,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 994.6069999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3052.667999999926,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.438999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1920.4880000000003,
"heapDeltaBytes": -140512,
"heapUsedBytes": 90886160,
"domNodes": -252,
"jsHeapTotalBytes": 970752,
"scriptDurationMs": 980.111,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2030.9300000000121,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.519999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 561.4889999999999,
"heapDeltaBytes": -4622932,
"heapUsedBytes": 84588344,
"domNodes": -248,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 32.522,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.7520000000168,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.671999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 598.6360000000001,
"heapDeltaBytes": -7624856,
"heapUsedBytes": 81161992,
"domNodes": -247,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 35.068000000000005,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.4469999999874,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.741999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.881,
"heapDeltaBytes": 13750480,
"heapUsedBytes": 83822008,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 144.33,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.9059999999654,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.458000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.185,
"heapDeltaBytes": 14004968,
"heapUsedBytes": 84092612,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.781,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1991.7409999999904,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.259999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.2300000000001,
"heapDeltaBytes": 8875128,
"heapUsedBytes": 78043476,
"domNodes": -274,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.322000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.8729999999514,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.59,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.78799999999995,
"heapDeltaBytes": -12193200,
"heapUsedBytes": 57594360,
"domNodes": -274,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.813,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1735.1470000000404,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.700999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 768.139,
"heapDeltaBytes": -6965600,
"heapUsedBytes": 63064820,
"domNodes": -275,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 104.248,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.3120000000727,
"styleRecalcs": 45,
"styleRecalcDurationMs": 12.716000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 674.674,
"heapDeltaBytes": 8398640,
"heapUsedBytes": 78257288,
"domNodes": -276,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 91.049,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1351.590999999985,
"styleRecalcs": 17,
"styleRecalcDurationMs": 27.020999999999997,
"layouts": 5,
"layoutDurationMs": 11.898999999999997,
"taskDurationMs": 845.051,
"heapDeltaBytes": -6259292,
"heapUsedBytes": 81293548,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 26.257999999999996,
"eventListeners": 2383,
"totalBlockingTimeMs": 119,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8277.638000000024,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.39200000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5694.585,
"heapDeltaBytes": -10441152,
"heapUsedBytes": 76261344,
"domNodes": -240,
"jsHeapTotalBytes": 1269760,
"scriptDurationMs": 2641.539,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8293.345999999929,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.504,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5485.556,
"heapDeltaBytes": -2236768,
"heapUsedBytes": 84889568,
"domNodes": -240,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 2648.994,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17295.62199999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17140.257,
"heapDeltaBytes": -43096200,
"heapUsedBytes": 187038812,
"domNodes": -8061,
"jsHeapTotalBytes": -13570048,
"scriptDurationMs": 274.31699999999995,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17032.551000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16843.41,
"heapDeltaBytes": -54805088,
"heapUsedBytes": 186852596,
"domNodes": -8061,
"jsHeapTotalBytes": -16191488,
"scriptDurationMs": 263.378,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21322.100000000035,
"styleRecalcs": 161,
"styleRecalcDurationMs": 18.56900000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21064.839999999997,
"heapDeltaBytes": -52150612,
"heapUsedBytes": 169733368,
"domNodes": -8061,
"jsHeapTotalBytes": -13688832,
"scriptDurationMs": 875.5150000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 73,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21615.963999999964,
"styleRecalcs": 158,
"styleRecalcDurationMs": 19.83500000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21407.175,
"heapDeltaBytes": -33348060,
"heapUsedBytes": 193487752,
"domNodes": -8061,
"jsHeapTotalBytes": -16695296,
"scriptDurationMs": 917.678,
"eventListeners": -14928,
"totalBlockingTimeMs": 180,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6150.807999999984,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.69499999999998,
"layouts": 20,
"layoutDurationMs": 23.175,
"taskDurationMs": 6048.878000000001,
"heapDeltaBytes": -56148384,
"heapUsedBytes": 185038584,
"domNodes": -8061,
"jsHeapTotalBytes": 12644352,
"scriptDurationMs": 111.76099999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 443,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6461.716000000024,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.65200000000003,
"layouts": 20,
"layoutDurationMs": 25.541999999999994,
"taskDurationMs": 6436.870999999999,
"heapDeltaBytes": -21844832,
"heapUsedBytes": 194029596,
"domNodes": -8061,
"jsHeapTotalBytes": 15396864,
"scriptDurationMs": 121.78099999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 533,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8712.983000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8314.239000000001,
"heapDeltaBytes": -440368,
"heapUsedBytes": 178710712,
"domNodes": 0,
"jsHeapTotalBytes": -12845056,
"scriptDurationMs": 128.71200000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8862.621999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8715.257000000001,
"heapDeltaBytes": 5356292,
"heapUsedBytes": 189415132,
"domNodes": 0,
"jsHeapTotalBytes": -11796480,
"scriptDurationMs": 161.91199999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 464.0840000000708,
"styleRecalcs": 15,
"styleRecalcDurationMs": 26.945000000000004,
"layouts": 4,
"layoutDurationMs": 2.163,
"taskDurationMs": 132.49999999999997,
"heapDeltaBytes": 5103156,
"heapUsedBytes": 70630832,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.503,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 468.405999999959,
"styleRecalcs": 14,
"styleRecalcDurationMs": 25.139,
"layouts": 3,
"layoutDurationMs": 0.911,
"taskDurationMs": 126.856,
"heapDeltaBytes": 4889376,
"heapUsedBytes": 70550436,
"domNodes": 121,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 9.910999999999998,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.55 #19542 +/- ##
=============================================
Coverage ? 84.61%
=============================================
Files ? 2314
Lines ? 131568
Branches ? 33248
=============================================
Hits ? 111320
Misses ? 19889
Partials ? 359
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…y-Org#20742) *PR Created by the Glary-Bot Agent* --- ## Summary Adds a regression guard for FE-3332 and FE-2812 (Pylon Comfy-Org#19184). From Sep 9 to Sep 30, users' Imported tab on Cloud showed every base-template input. The cause: Comfy-Org#15381 moved the Assets panel to `useAssetsQuery` without `include_public=false`. Cloud ingest defaults that parameter to `true`, so the shared template-input catalog came back with the user's own uploads. Comfy-Org#18633 restored the parameter (backported as Comfy-Org#19542, shipped in `cloud/v1.55.15`), but no test pinned it. The new `@cloud` spec `browser_tests/tests/sidebar/assets-imported-public.spec.ts` stubs `/api/assets` to match the server default: it returns public assets unless the request sends `include_public=false`. It then asserts: - the Imported tab shows only the user's own input; - the Generated tab shows no other user's assets; - every panel request (`tags_any=input` and `tags_any=output`) sends `include_public=false`. Test only, no production code changes. Companion PR in `Comfy-Org/cloud`: Comfy-Org/cloud#12841. It pins the same contract at the ingest handler and in the daily staging/prod e2e. ## Verification - Ran `pnpm build:cloud`, served `dist/` from local ComfyUI (`--cpu --multi-user` plus devtools, same as CI), then `pnpm exec playwright test --project=cloud browser_tests/tests/sidebar/assets-imported-public.spec.ts`: **2 passed (~12s)**. - Negative control: I removed `include_public: false` from `BASE_PARAMS` in `useAssetsQuery.ts` and rebuilt. **Both tests fail.** `template_sample_a` and `published_render` cards render, `toHaveCount(0)` gets 1, and the parameter assertion fails. Then I restored the line. - oxfmt, oxlint (type-aware), `typecheck:browser` and the server-facts gate passed via pre-commit. - Screenshots come from the same spec: with the fix, the Imported tab shows only `my_upload`. With `include_public` removed, extra template-input cards appear. ## Screenshots   --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
Manual backport of #18633 to
cloud/1.55Required manual backport because one of the tests removed by the PR had been changed.