Repository navigation
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2123 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since a937e31eaa1ab4dd195919f23fc610a8cec5d098
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.98 MB gzip 🔴 +286 kBDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.73 kB) • 🔴 +138 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.44 MB (baseline 1.43 MB) • 🔴 +17.5 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 124 kB) • 🔴 +8.02 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 639 kB (baseline 621 kB) • 🔴 +17.6 kBConfiguration panels, inspectors, and settings screens
Status: 28 added / 27 removed User & Accounts — 37.9 kB (baseline 27.8 kB) • 🔴 +10.1 kBAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 2 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +740 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 124 kB (baseline 117 kB) • 🔴 +6.54 kBReusable component library chunks
Status: 16 added / 15 removed Data & Services — 3.95 MB (baseline 3.6 MB) • 🔴 +346 kBStores, services, APIs, and repositories
Status: 16 added / 16 removed Utilities & Hooks — 577 kB (baseline 559 kB) • 🔴 +18.8 kBHelpers, composables, and utility bundles
Status: 31 added / 29 removed / 7 unchanged Vendor & Third-Party — 17.4 MB (baseline 18.1 MB) • 🟢 -692 kBExternal libraries and shared vendor chunks
Status: 12 added / 12 removed / 6 unchanged Other — 17.8 MB (baseline 16.4 MB) • 🔴 +1.43 MBBundles that do not match a named category
Status: 179 added / 173 removed / 123 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T12:10:30.834Z",
"gitSha": "791b76bc9166fa1b0add190aaae4e5c7c8d68979",
"branch": "glary/fix-imported-tab-public-assets",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.5760000000246,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.595000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.64599999999996,
"heapDeltaBytes": -8092652,
"heapUsedBytes": 59132732,
"domNodes": -260,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.185000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2006.2189999999873,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.312999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 360.61099999999993,
"heapDeltaBytes": -7201776,
"heapUsedBytes": 60254112,
"domNodes": -261,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.605000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1791.6299999999978,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.319,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 832.692,
"heapDeltaBytes": -6401760,
"heapUsedBytes": 61274328,
"domNodes": -260,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 144.304,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1774.4329999999309,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.862999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 825.981,
"heapDeltaBytes": -4140452,
"heapUsedBytes": 63474952,
"domNodes": -258,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 151.278,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.4509999999918,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.848,
"layouts": 6,
"layoutDurationMs": 1.096,
"taskDurationMs": 341.94800000000004,
"heapDeltaBytes": 3144600,
"heapUsedBytes": 70710876,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.235999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1692.5519999999779,
"styleRecalcs": 28,
"styleRecalcDurationMs": 13.791,
"layouts": 6,
"layoutDurationMs": 1.239,
"taskDurationMs": 318.85699999999997,
"heapDeltaBytes": 2122756,
"heapUsedBytes": 64620884,
"domNodes": 76,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 11.270000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 699.0810000000351,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.442,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.823,
"heapDeltaBytes": 18973512,
"heapUsedBytes": 86573032,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 160.411,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 647.9730000000927,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.95,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.724,
"heapDeltaBytes": 18915632,
"heapUsedBytes": 86477016,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 161.877,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1176.1999999999944,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 802.929,
"heapDeltaBytes": 38246332,
"heapUsedBytes": 108497512,
"domNodes": 0,
"jsHeapTotalBytes": 18509824,
"scriptDurationMs": 56.64100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 572,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1211.6869999999835,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 911.136,
"heapDeltaBytes": -17461464,
"heapUsedBytes": 72609136,
"domNodes": -297,
"jsHeapTotalBytes": 21102592,
"scriptDurationMs": 64.162,
"eventListeners": -217,
"totalBlockingTimeMs": 544,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 858.8980000000106,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.76700000000005,
"heapDeltaBytes": 15962772,
"heapUsedBytes": 91473968,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 174.37800000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 241,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.533999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.623,
"heapDeltaBytes": 14445320,
"heapUsedBytes": 89583216,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 159.353,
"eventListeners": 0,
"totalBlockingTimeMs": 214,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10313.198999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9346.914,
"heapDeltaBytes": -10386892,
"heapUsedBytes": 71757824,
"domNodes": -14,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 7534.268,
"eventListeners": 0,
"totalBlockingTimeMs": 667,
"frameDurationMs": 18.329999999999988,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9650.39200000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8787.498,
"heapDeltaBytes": -11856224,
"heapUsedBytes": 70112904,
"domNodes": -16,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 7083.595,
"eventListeners": 0,
"totalBlockingTimeMs": 536,
"frameDurationMs": 18.329999999999988,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9632.98599999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8748.011,
"heapDeltaBytes": 1983368,
"heapUsedBytes": 84448784,
"domNodes": -12,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 7037.441000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 346,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9619.241999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8751.486,
"heapDeltaBytes": -1409172,
"heapUsedBytes": 75552256,
"domNodes": -14,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 7077.242,
"eventListeners": 0,
"totalBlockingTimeMs": 434,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2068.314999999984,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.899000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 654.642,
"heapDeltaBytes": -7107704,
"heapUsedBytes": 79310368,
"domNodes": -255,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 44.702000000000005,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2032.293999999979,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.196999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.11499999999995,
"heapDeltaBytes": -4162168,
"heapUsedBytes": 82707556,
"domNodes": -244,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 39.355000000000004,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2601.4959999999974,
"styleRecalcs": 67,
"styleRecalcDurationMs": 17.915,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1791.3699999999997,
"heapDeltaBytes": -7747600,
"heapUsedBytes": 80196972,
"domNodes": -224,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 932.9430000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2581.651000000079,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.083,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1767.6410000000003,
"heapDeltaBytes": -390636,
"heapUsedBytes": 80915356,
"domNodes": -217,
"jsHeapTotalBytes": 1789952,
"scriptDurationMs": 909.44,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3708.786000000032,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.015,
"layouts": 60,
"layoutDurationMs": 16.024,
"taskDurationMs": 1774.098,
"heapDeltaBytes": 10151880,
"heapUsedBytes": 75216908,
"domNodes": -246,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 849.02,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3649.819999999977,
"styleRecalcs": 63,
"styleRecalcDurationMs": 14.277000000000001,
"layouts": 60,
"layoutDurationMs": 16.049,
"taskDurationMs": 1739.662,
"heapDeltaBytes": 9817092,
"heapUsedBytes": 74909948,
"domNodes": -250,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 822.529,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3187.609000000009,
"styleRecalcs": 43,
"styleRecalcDurationMs": 8.818999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2053.292,
"heapDeltaBytes": 27179488,
"heapUsedBytes": 90918836,
"domNodes": -259,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 1069.4,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3173.9370000000235,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.278,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2063.265,
"heapDeltaBytes": -2972044,
"heapUsedBytes": 87938288,
"domNodes": -252,
"jsHeapTotalBytes": 1757184,
"scriptDurationMs": 1075.6570000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 4,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2019.3490000000338,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.293000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.2429999999999,
"heapDeltaBytes": -4706196,
"heapUsedBytes": 84150808,
"domNodes": -246,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 38.843,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2027.8369999999768,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.650000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 603.2509999999999,
"heapDeltaBytes": -6161484,
"heapUsedBytes": 82205816,
"domNodes": -245,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 40.507,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 588.92400000002,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.175,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.426,
"heapDeltaBytes": 13697776,
"heapUsedBytes": 83623716,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 144.91799999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 581.4399999999296,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.216000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.558,
"heapDeltaBytes": 13755228,
"heapUsedBytes": 83451316,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 144.66400000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.375000000001,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.434999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.8949999999999,
"heapDeltaBytes": 9094488,
"heapUsedBytes": 79001124,
"domNodes": -277,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.829000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2018.9240000000837,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.125,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.51499999999993,
"heapDeltaBytes": 9889868,
"heapUsedBytes": 80001640,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.091000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.1080000000052,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.451999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 704.6890000000001,
"heapDeltaBytes": -8098024,
"heapUsedBytes": 62051740,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 105.96,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1731.6869999999653,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.561000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 750.3310000000001,
"heapDeltaBytes": -8056268,
"heapUsedBytes": 62206816,
"domNodes": -275,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 104.1,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 934.4939999999724,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.402,
"layouts": 5,
"layoutDurationMs": 10.190999999999999,
"taskDurationMs": 683.427,
"heapDeltaBytes": -6197404,
"heapUsedBytes": 81838512,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 25.866,
"eventListeners": 2383,
"totalBlockingTimeMs": 104,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8978.80600000002,
"styleRecalcs": 250,
"styleRecalcDurationMs": 47.269999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6007.0560000000005,
"heapDeltaBytes": -1831248,
"heapUsedBytes": 84833528,
"domNodes": -242,
"jsHeapTotalBytes": -303104,
"scriptDurationMs": 2905.2980000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8895.651000000043,
"styleRecalcs": 252,
"styleRecalcDurationMs": 46.593999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5912.152,
"heapDeltaBytes": -6810640,
"heapUsedBytes": 79675096,
"domNodes": -238,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 2873.425,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 19793.344999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19719.858,
"heapDeltaBytes": -46698120,
"heapUsedBytes": 192966584,
"domNodes": -8061,
"jsHeapTotalBytes": -19496960,
"scriptDurationMs": 380.181,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15345.669000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15051.315,
"heapDeltaBytes": -56331084,
"heapUsedBytes": 179918320,
"domNodes": -8061,
"jsHeapTotalBytes": -18554880,
"scriptDurationMs": 273.517,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 25015.510000000006,
"styleRecalcs": 177,
"styleRecalcDurationMs": 28.691000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24930.757999999998,
"heapDeltaBytes": -65834832,
"heapUsedBytes": 170586108,
"domNodes": -8061,
"jsHeapTotalBytes": -12787712,
"scriptDurationMs": 1064.646,
"eventListeners": -14928,
"totalBlockingTimeMs": 321,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-large-graph-pan",
"durationMs": 20131.141999999956,
"styleRecalcs": 142,
"styleRecalcDurationMs": 19.521999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20040.719,
"heapDeltaBytes": -63608292,
"heapUsedBytes": 178658692,
"domNodes": -8061,
"jsHeapTotalBytes": -16977920,
"scriptDurationMs": 852.6279999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 144,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 7150.50599999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.74899999999995,
"layouts": 20,
"layoutDurationMs": 27.676999999999992,
"taskDurationMs": 7104.228,
"heapDeltaBytes": -25879712,
"heapUsedBytes": 190163364,
"domNodes": -8061,
"jsHeapTotalBytes": 10166272,
"scriptDurationMs": 140.05800000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 691,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6133.474999999976,
"styleRecalcs": 20,
"styleRecalcDurationMs": 67.78699999999999,
"layouts": 20,
"layoutDurationMs": 25.734000000000005,
"taskDurationMs": 6091.707,
"heapDeltaBytes": 5970700,
"heapUsedBytes": 179050084,
"domNodes": -8061,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 114.81399999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 368,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9822.429000000056,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9781.552,
"heapDeltaBytes": 10433136,
"heapUsedBytes": 171339872,
"domNodes": 0,
"jsHeapTotalBytes": -3932160,
"scriptDurationMs": 163.15499999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7839.497000000051,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7742.25,
"heapDeltaBytes": 4254092,
"heapUsedBytes": 179787760,
"domNodes": 0,
"jsHeapTotalBytes": -6029312,
"scriptDurationMs": 118.57200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 990.7610000000204,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.232000000000003,
"layouts": 3,
"layoutDurationMs": 1.591,
"taskDurationMs": 134.51300000000003,
"heapDeltaBytes": 5900084,
"heapUsedBytes": 71306832,
"domNodes": 149,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 15.32,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 106.6920000000664,
"styleRecalcs": 6,
"styleRecalcDurationMs": 11.751999999999999,
"layouts": 2,
"layoutDurationMs": 0.82,
"taskDurationMs": 75.624,
"heapDeltaBytes": 3090384,
"heapUsedBytes": 68616800,
"domNodes": 105,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.427999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
This comment has been minimized.
This comment has been minimized.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe assets store now separates owner-only imported assets from public-inclusive input assets. The Imported tab uses the owner-only list. Input-asset upload, deletion, and import paths use store-level actions to refresh the relevant lists. ChangesInput asset scopes
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The Imported tab is scoped to owned assets while public inputs remain available to widgets. No actionable merge risk remains after normal checks. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
The Media Assets panel's Imported tab listed every workflow-template input file on Comfy Cloud. Ingest's GET /api/assets defaults include_public to true, and the panel never sent the parameter, so the shared public-assets account's 722 template inputs — all tagged 'input' — were OR'd into the user's list. Split the store's input feed: inputAssets stays public-inclusive for the Cloud Load Image/Video widgets, which must keep resolving a template's input, while a new owner-scoped importedAssets backs the panel. Mutations now fan out to both lists, since SharedPagedList only propagates a refresh to lists sharing an item id and the two never overlap for a user who owns nothing yet. The Generated query is scoped the same way to close the leak for any future public output/temp asset.
e947592 to
407cd00
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #18573 +/- ##
==========================================
+ Coverage 83.53% 84.56% +1.02%
==========================================
Files 2991 2293 -698
Lines 148050 131079 -16971
Branches 38237 35438 -2799
==========================================
- Hits 123678 110849 -12829
+ Misses 23087 19929 -3158
+ Partials 1285 301 -984
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 734 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Adds the browser_tests regression the repo's fix policy requires. The route handler reproduces ingest's contract — public assets are withheld only when include_public=false is sent — so reverting either panel query fails these specs. Verified by mutation: dropping include_public from the two panel queries and rebuilding the cloud dist fails both tests.
outputAssets is not panel-only: WidgetSelectDropdown and linear mode's output history read the same list. Scoping it to the owner narrowed a widget-facing list to change one consumer, which is the mistake the input split exists to avoid, and it was outside this fix's goal. Drops the assertions and the end-to-end case that pinned it.
Pins the caller wiring at one site: useNodeImageUpload now spies the store action, so reverting that call site to inputAssets.invalidate fails a test instead of passing silently. Replaces the include_public=true wire assertion with an outcome one. The explicit true matches the server default, so asserting the parameter red-flagged a behaviour-preserving cleanup; asserting that a public asset reaches inputAssets and not importedAssets does not. Guards the combo widget's paging walk, which read the same store member as the option lookup and was previously unpinned. Also switches to the shared useFeatureFlags mock and stops sharing one single-use Response across the three queries opened at store init.
servePagesByScope keyed off the literal include_public=true, so an absent parameter served the empty page — the opposite of ingest, which defaults it to true. Dropping the now-redundant explicit true from the widget-facing query is behaviour-preserving but turned the suite red. Keys off include_public=false instead, matching the Playwright stub, and narrows the settle barrier to the input queries so an unrelated list added to the store cannot fail these tests.
Addressed: pre-merge check + two corrections to the description above1.
|
| Test | Fails when |
|---|---|
AssetsSidebarTab Imported tab |
panel reads inputAssets |
useComboWidget public-template option |
widget reads importedAssets |
useComboWidget paging guard |
loadAll() walks importedAssets |
assetsStore.inputScope fan-out |
fan-out collapses to one list |
useNodeImageUpload |
call site bypasses invalidateInputAssets |
| E2E Imported tab | Imported query stops sending include_public=false |
Note the store suite deliberately stays green when the now-redundant explicit include_public: true is dropped from the widget-facing query — that is a no-op on the wire, since the server already defaults it to true.
Known follow-up (pre-existing, not introduced here)
inputAssets.invalidate() truncates the list to one page, and after this split the sidebar no longer incidentally re-grows it by scrolling. The truncation itself predates this PR; the accidental mitigation is what goes away. Worth a separate ticket to re-arm the exhaustive walk after invalidation.
Gates: typecheck, lint, stylelint, format:check, knip, locale:check, adr:check, typecheck:browser, typecheck:scripts, typecheck:tools all pass. 139 unit test files / 2756 tests pass.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
|
Thanks — confirming the state at No code changes were needed for this approval. Summarising what the earlier
The two corrections in my previous comment still stand and are the important ones for a human reviewer: the Generated tab change was reverted ( Ready for human review. |
Dismissed at DrJKL's request during the Agent PR survey. This does not mark the findings as fixed or approve the PR.
|
superseded |
|
Superseded by #18633. Regression tests: #20742, Comfy-Org/cloud#12841 (merged). Full context for agent readers
|
PR Created by the Glary-Bot Agent
Fixes the "Imported tab shows template assets" half of FE-2812. (The other half — deleted generated assets reappearing — is expected behaviour and needs no code change.)
Root cause
Ingest's
GET /api/assetsdeclaresinclude_publicwithdefault: true(services/ingest/openapi.yaml, andIncludePublic: true // Default to true for backwards compatibilityin bothserver/mapper/assets.goandserver/implementation/assets.go). When it is true,common/assets/repository_impl.goORsasset.UserAssetsEQ(publicAssetUserID)into the query with no workspace predicate — public assets are cross-workspace by design.useAssetsQuery'sBASE_PARAMSnever sent the parameter, so the panel inherited that default. The public-assets account holds the 722 entries ofworkflow_template_input_files.json, uploaded byservices/ingest/scripts/upload-public-assets— and all 722 are taggedinput, which is exactly what the Imported tab queries. Every filename in the report (drinking_unicorn.mp4,car_ref.png,product_shoe.png,real_human_demo.png,flf2v_demo_*_frame.png, …) is in that file.Surfaced by #15381 (
Assets backed assets panel), which repointed the panel from jobs to assets. It only reproduces whereflags.assetsEnabledis on — hence "not on a personal account I've never used".Why not just add
include_public: falseto the existing queryassetsStore.inputAssetshas a second consumer:useComboWidget'sgetCloudInputAssetsbuilds the Cloud Load Image/Video dropdown from it, andgetInputNameresolves hashes to filenames through it. Scoping that list to the user would strip template inputs from those widgets — a template's selected value would vanish from its own dropdown and render as a raw hash.missingMediaAssetResolveralready passesincludePublic: trueexplicitly for the same reason.So the input feed is split by intent:
inputAssets— public-inclusive, unchanged on the wire (include_public: trueis the server default made explicit). Widgets and filename resolution keep reading it.importedAssets— new, owner-scoped. Backs the Imported tab only.Mutations now fan out to both via
invalidateInputAssets/loadNewInputAssets. This is load-bearing, not cosmetic:SharedPagedList's no-arginvalidate()/loadNew()go throughoverlapping(), which only reaches cache entries sharing an item id with the receiver. For a user who owns nothing yet,importedAssetsis empty and the two lists never overlap, so the old single-list refresh would leave the Imported tab stale after a first upload.Also scoped: the Generated tab
outputAssetshad the same inherited default and is nowinclude_public: falsetoo. It is inert today — publish only carries inputs and models — butinclude_publicgates two predicates: the shared public account andasset.HasPublishedAssets(), i.e. assets published by other users. Scoping it closes the same ownership leak prospectively rather than waiting for the first publicoutput/tempasset.Verification
Driven in a real browser against a live ComfyUI backend, with a Playwright interceptor emulating the ingest
include_publiccontract. Observed request log:Before/after below are the same session with only the fix stashed/restored.
Tests are mutation-checked rather than assumed — each fails under the corresponding revert:
AssetsSidebarTabImported-tab testinputAssetsuseComboWidgetpublic-template testimportedAssetsassetsStore.inputScopefan-out testsNote the
useComboWidgettest assigns a distinct stub tostore.importedAssets: that file mocksassetsEnabled: false, where both refs alias the samehistoryInputsobject, so without it the test cannot fail.pnpm typecheckclean,pnpm lint0 errors, 139 asset/store/widget test files (2748 tests) pass. Fullpnpm test:unithas 12 failures inscripts/cicd,scripts/vite-config-dev-agent,src/vitestSetup.test.ts,agentSubgraphDefinitions.test.tsandtools/eslint-plugins/astro.test.ts— all reproduce identically on an unmodifiedmain.Known cost
Cloud sessions now issue three
/assetsrequests at startup instead of two, sinceuseAssetsQueryfetches eagerly on construction andimportedAssetsis built unconditionally. Flagging it so it is not later rediscovered as a regression.Not covered
Server semantics are read from Go source, not exercised against a real Comfy Cloud backend — the interceptor validates the request shape the frontend emits, not ingest's actual filtering. The
assetsEnabled: false(OSS/local) branch is unit-tested only.Screenshots