Repository navigation
fix(agent-crdt): address display-widget mint review findings - #19504
christian-byrne merged 6 commits into
Conversation
Addresses review feedback: #19026 (comment)
Addresses review feedback: #19026 (comment)
Addresses review feedback: #19026 (comment)
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. 📝 WalkthroughWalkthrough
ChangesWidget serialization state
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: 🔵 Low · up to The top-level serialization flag controls live mint eligibility, but the integration fixture also disables options-level serialization, leaving that distinction untested. This is a bounded test gap; no current functional failure is established. 🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The PR title uses bug-fix language:
✨ Finishing Touches 💡 1📝 Generate docstrings
🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2155 passed, 0 failed · 2 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since fd8ec867935e18bd58ac56994f11a4a367eb48d1
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-30T05:08:42.765Z",
"gitSha": "f7d913a9d9dd9d85c20a81c9ec30af7710fcb254",
"branch": "christian-byrne/19026-review-fixes",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.706999999978,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.523000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.7370000000001,
"heapDeltaBytes": -32202248,
"heapUsedBytes": 65885436,
"domNodes": -228,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 7.785,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2032.073999999966,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.720000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.6460000000001,
"heapDeltaBytes": -15193016,
"heapUsedBytes": 63436968,
"domNodes": -228,
"jsHeapTotalBytes": -1048576,
"scriptDurationMs": 8.066999999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1804.6709999999848,
"styleRecalcs": 74,
"styleRecalcDurationMs": 20.53,
"layouts": 12,
"layoutDurationMs": 4.312,
"taskDurationMs": 848.495,
"heapDeltaBytes": -12746800,
"heapUsedBytes": 65571360,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 178.109,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.820560747663553,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1841.760000000022,
"styleRecalcs": 79,
"styleRecalcDurationMs": 19.038,
"layouts": 12,
"layoutDurationMs": 7.481999999999999,
"taskDurationMs": 831.063,
"heapDeltaBytes": -32550624,
"heapUsedBytes": 65893700,
"domNodes": -199,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 164.825,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66636363636363,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1733.9080000000422,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.749,
"layouts": 6,
"layoutDurationMs": 1.2159999999999997,
"taskDurationMs": 318.503,
"heapDeltaBytes": 1570716,
"heapUsedBytes": 80306368,
"domNodes": 53,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 10.71,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.4409999998952,
"styleRecalcs": 33,
"styleRecalcDurationMs": 10.019,
"layouts": 6,
"layoutDurationMs": 1.0109999999999997,
"taskDurationMs": 329.54299999999995,
"heapDeltaBytes": -18891764,
"heapUsedBytes": 79512540,
"domNodes": 53,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 10.639,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66442307692308,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 729.8040000000015,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.572999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.4889999999999,
"heapDeltaBytes": -1968700,
"heapUsedBytes": 96765080,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 169.409,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 739.6280000000388,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.821999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.261,
"heapDeltaBytes": -13223624,
"heapUsedBytes": 65405196,
"domNodes": -228,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 171.108,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909075,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1163.7489999999957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 818.949,
"heapDeltaBytes": 10057412,
"heapUsedBytes": 86215172,
"domNodes": 0,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 64.96,
"eventListeners": 0,
"totalBlockingTimeMs": 544,
"frameDurationMs": 35.351515151515166,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1165.2199999999766,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 816.5720000000001,
"heapDeltaBytes": 8898284,
"heapUsedBytes": 86175156,
"domNodes": 0,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 74.00499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 538,
"frameDurationMs": 34.31176470588236,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 899.3509999999674,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.6789999999995,
"heapDeltaBytes": 15871268,
"heapUsedBytes": 89218168,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 180.529,
"eventListeners": 0,
"totalBlockingTimeMs": 260,
"frameDurationMs": 25.714285714285715,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 867.4230000000307,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.0710000000008,
"heapDeltaBytes": 16023860,
"heapUsedBytes": 90624540,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 167.92600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 227,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9453.119999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8643.311000000002,
"heapDeltaBytes": -1079132,
"heapUsedBytes": 79267528,
"domNodes": 0,
"jsHeapTotalBytes": -15990784,
"scriptDurationMs": 7339.515,
"eventListeners": 0,
"totalBlockingTimeMs": 1326,
"frameDurationMs": 36.06717557251908,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10471.98800000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9519.259,
"heapDeltaBytes": -1086312,
"heapUsedBytes": 79411420,
"domNodes": 0,
"jsHeapTotalBytes": -15990784,
"scriptDurationMs": 7887.295000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1082,
"frameDurationMs": 32.007033639143735,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9649.365999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8952.569000000001,
"heapDeltaBytes": 12952880,
"heapUsedBytes": 93868048,
"domNodes": 0,
"jsHeapTotalBytes": -2097152,
"scriptDurationMs": 7632.537,
"eventListeners": 0,
"totalBlockingTimeMs": 1601,
"frameDurationMs": 36.48825757575757,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11233.806999999957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10225.349,
"heapDeltaBytes": -11473472,
"heapUsedBytes": 69496972,
"domNodes": 0,
"jsHeapTotalBytes": -3670016,
"scriptDurationMs": 8551.782,
"eventListeners": 0,
"totalBlockingTimeMs": 1634,
"frameDurationMs": 33.3320474777448,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-graph-idle",
"durationMs": 2045.2060000000074,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.9010000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 540.321,
"heapDeltaBytes": -37177412,
"heapUsedBytes": 81952968,
"domNodes": -228,
"jsHeapTotalBytes": -360448,
"scriptDurationMs": 31.983999999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2052.7550000000474,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.424,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 549.463,
"heapDeltaBytes": -37183624,
"heapUsedBytes": 81554888,
"domNodes": -228,
"jsHeapTotalBytes": 163840,
"scriptDurationMs": 34.638000000000005,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2362.6630000000546,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.824000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1639.947,
"heapDeltaBytes": -36367252,
"heapUsedBytes": 83137788,
"domNodes": -228,
"jsHeapTotalBytes": 389120,
"scriptDurationMs": 851.265,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.785714285714285,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2713.822999999934,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.078000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1696.6770000000001,
"heapDeltaBytes": 26874056,
"heapUsedBytes": 89166988,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 937.156,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666049382716054,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3668.2440000000156,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.458000000000002,
"layouts": 60,
"layoutDurationMs": 13.198,
"taskDurationMs": 1703.6909999999996,
"heapDeltaBytes": 8480124,
"heapUsedBytes": 72836124,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 813.147,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3558.4820000000263,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.65,
"layouts": 60,
"layoutDurationMs": 13.182,
"taskDurationMs": 1535.6109999999999,
"heapDeltaBytes": 8764264,
"heapUsedBytes": 72568280,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 815.047,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.744811320754714,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3128.4689999999955,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.485,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1881.745,
"heapDeltaBytes": 25553464,
"heapUsedBytes": 90448416,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 961.1129999999998,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755376344086017,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3110.3219999999965,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.451999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1805.6980000000003,
"heapDeltaBytes": 2749220,
"heapUsedBytes": 66499284,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 1031.73,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755675675675672,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2011.3139999999703,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.0170000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.89099999999985,
"heapDeltaBytes": 20779784,
"heapUsedBytes": 84378432,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.805,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2027.4530000000368,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.2909999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.946,
"heapDeltaBytes": 20906384,
"heapUsedBytes": 82999596,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.125,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 599.7519999999668,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.344,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.19399999999996,
"heapDeltaBytes": 13168204,
"heapUsedBytes": 93239892,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 148.548,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 602.7490000000171,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.732999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 379.24899999999997,
"heapDeltaBytes": 12894920,
"heapUsedBytes": 92923508,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 138.40000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2032.1009999999546,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.3489999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.60699999999997,
"heapDeltaBytes": -10743512,
"heapUsedBytes": 68744368,
"domNodes": -244,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 7.366000000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2025.4460000001018,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.078999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.029,
"heapDeltaBytes": -17999824,
"heapUsedBytes": 61977552,
"domNodes": -244,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.430000000000002,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1761.3569999999754,
"styleRecalcs": 78,
"styleRecalcDurationMs": 25.712000000000003,
"layouts": 16,
"layoutDurationMs": 5.496,
"taskDurationMs": 775.287,
"heapDeltaBytes": -18898556,
"heapUsedBytes": 61720112,
"domNodes": -244,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 111.86500000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66509433962264,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1750.498000000107,
"styleRecalcs": 79,
"styleRecalcDurationMs": 18.895000000000003,
"layouts": 16,
"layoutDurationMs": 5.558999999999999,
"taskDurationMs": 775.924,
"heapDeltaBytes": -15945756,
"heapUsedBytes": 64457216,
"domNodes": -244,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 112.39000000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.3590000000704,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.06299999999999,
"layouts": 5,
"layoutDurationMs": 13.648999999999997,
"taskDurationMs": 870.0710000000003,
"heapDeltaBytes": 21412460,
"heapUsedBytes": 95260912,
"domNodes": 13667,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 39.757999999999996,
"eventListeners": 2383,
"totalBlockingTimeMs": 135,
"frameDurationMs": 19.405479452054788,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8467.472000000043,
"styleRecalcs": 251,
"styleRecalcDurationMs": 32.513,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5712.517,
"heapDeltaBytes": -43259540,
"heapUsedBytes": 74777436,
"domNodes": -228,
"jsHeapTotalBytes": -430080,
"scriptDurationMs": 2783.1929999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66587771203156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8478.958000000035,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5694.948,
"heapDeltaBytes": -40359676,
"heapUsedBytes": 78890324,
"domNodes": -228,
"jsHeapTotalBytes": -167936,
"scriptDurationMs": 2754.723,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699013806706116,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16648.547000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16043.877999999999,
"heapDeltaBytes": -48070464,
"heapUsedBytes": 160637344,
"domNodes": -3075,
"jsHeapTotalBytes": 6733824,
"scriptDurationMs": 322.72299999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 18,
"frameDurationMs": 29.730892857142855,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 16631.684999999947,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16135.593,
"heapDeltaBytes": -20819984,
"heapUsedBytes": 186476480,
"domNodes": -3046,
"jsHeapTotalBytes": 5771264,
"scriptDurationMs": 304.862,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.027225130890056,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 20619.38399999997,
"styleRecalcs": 169,
"styleRecalcDurationMs": 16.295999999999978,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20314.779000000002,
"heapDeltaBytes": -60902744,
"heapUsedBytes": 167311404,
"domNodes": -3045,
"jsHeapTotalBytes": 3497984,
"scriptDurationMs": 892.563,
"eventListeners": -14915,
"totalBlockingTimeMs": 46,
"frameDurationMs": 38.64746716697936,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 20397.663999999964,
"styleRecalcs": 177,
"styleRecalcDurationMs": 17.502000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19984.223,
"heapDeltaBytes": -34792556,
"heapUsedBytes": 190197912,
"domNodes": -3045,
"jsHeapTotalBytes": 5664768,
"scriptDurationMs": 954.695,
"eventListeners": -14915,
"totalBlockingTimeMs": 105,
"frameDurationMs": 37.05890909090909,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 5991.6560000000345,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.52900000000002,
"layouts": 20,
"layoutDurationMs": 22.685999999999996,
"taskDurationMs": 5889.506,
"heapDeltaBytes": -12159436,
"heapUsedBytes": 210973592,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 109.34200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 412,
"frameDurationMs": 33.612359550561806,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6071.307999999931,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.763,
"layouts": 20,
"layoutDurationMs": 22.825,
"taskDurationMs": 5954.450000000001,
"heapDeltaBytes": 1174412,
"heapUsedBytes": 205320504,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 111.382,
"eventListeners": 0,
"totalBlockingTimeMs": 408,
"frameDurationMs": 33.42362637362636,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8456.62299999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8172.035000000001,
"heapDeltaBytes": -57232,
"heapUsedBytes": 169257476,
"domNodes": 0,
"jsHeapTotalBytes": -15466496,
"scriptDurationMs": 126.857,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.036769759450173,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8474.58800000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8172.288,
"heapDeltaBytes": 9434580,
"heapUsedBytes": 184429592,
"domNodes": 0,
"jsHeapTotalBytes": -29884416,
"scriptDurationMs": 125.75700000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.252068965517235,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 490.83999999993466,
"styleRecalcs": 20,
"styleRecalcDurationMs": 21.468,
"layouts": 5,
"layoutDurationMs": 2.5260000000000002,
"taskDurationMs": 149.00199999999998,
"heapDeltaBytes": -14459560,
"heapUsedBytes": 81187280,
"domNodes": 131,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 12.078,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 514.4109999999955,
"styleRecalcs": 21,
"styleRecalcDurationMs": 20.029999999999998,
"layouts": 4,
"layoutDurationMs": 1.71,
"taskDurationMs": 152.682,
"heapDeltaBytes": -14211544,
"heapUsedBytes": 81572348,
"domNodes": 126,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 12.072,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 829.2079999999942,
"styleRecalcs": 78,
"styleRecalcDurationMs": 100.491,
"layouts": 76,
"layoutDurationMs": 20.301,
"taskDurationMs": 787.235,
"heapDeltaBytes": 17732696,
"heapUsedBytes": 84903692,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 323.33700000000005,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666000000000004,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 907.77700000001,
"styleRecalcs": 78,
"styleRecalcDurationMs": 105.794,
"layouts": 76,
"layoutDurationMs": 22.807000000000002,
"taskDurationMs": 869.348,
"heapDeltaBytes": 18191376,
"heapUsedBytes": 88442484,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 357.86,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.296226415094335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1358.4230000000161,
"styleRecalcs": 78,
"styleRecalcDurationMs": 252.52200000000002,
"layouts": 76,
"layoutDurationMs": 25.096,
"taskDurationMs": 1331.22,
"heapDeltaBytes": 8864316,
"heapUsedBytes": 115481336,
"domNodes": 76,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 455.35200000000003,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.510126582278495,
"p95FrameDurationMs": 33.20000000000073
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1431.5240000000813,
"styleRecalcs": 78,
"styleRecalcDurationMs": 262.187,
"layouts": 76,
"layoutDurationMs": 25.731,
"taskDurationMs": 1417.331,
"heapDeltaBytes": 9189788,
"heapUsedBytes": 115831284,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 492.666,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.332500000000003,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E CoverageNote The shard matrix did not pass, so these totals cannot be confirmed comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## kishore/crdt-skip-non-value-widget-mints #19504 +/- ##
============================================================================
- Coverage 85.06% 85.06% -0.01%
============================================================================
Files 2316 2316
Lines 133946 133932 -14
Branches 36241 36241
============================================================================
- Hits 113943 113930 -13
+ Misses 19681 19680 -1
Partials 322 322
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 7 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 3 |
| 🟡 Medium | 1 |
| 🟢 Low | 2 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 2 — ledger: 7 prior finding(s) across 1 round(s) (0 never answered).
Found 7 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 2 |
| 🟢 Low | 4 |
Panel: 8/8 reviewers contributed findings.
|
🔗 Commit SHA: 1b97205 | Docs | View more details | Give us feedback! |
5ee77e6
into
kishore/crdt-skip-non-value-widget-mints
Summary
Follow-up fixes for #19026:
widget.serializeassignments cannot leave the store snapshot stale;widget.serialize) distinct from prompt eligibility (widget.options.serialize) so transient prompt inputs such as image comparison continue to mint live values.Addresses:
Testing
pnpm exec vitest run src/workbench/extensions/agent/crdt/mintPortWiring.test.ts(23 passed)pnpm typecheck