Skip to content

fix(agent-crdt): address display-widget mint review findings - #19504

Merged
christian-byrne merged 6 commits into
kishore/crdt-skip-non-value-widget-mintsfrom
christian-byrne/19026-review-fixes
Sep 30, 2026
Merged

christian-byrne merged 6 commits into
kishore/crdt-skip-non-value-widget-mintsfrom
christian-byrne/19026-review-fixes

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Follow-up fixes for #19026:

  • resolve mint eligibility from the live widget so late widget.serialize assignments cannot leave the store snapshot stale;
  • cover the production ordering without an incidental widget re-registration;
  • keep workflow persistence (widget.serialize) distinct from prompt eligibility (widget.options.serialize) so transient prompt inputs such as image comparison continue to mint live values.

Addresses:

Testing

  • pnpm exec vitest run src/workbench/extensions/agent/crdt/mintPortWiring.test.ts (23 passed)
  • targeted ESLint on both changed files
  • pnpm typecheck
  • pre-push knip and fallow gates

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 47bb1059-1c40-47dc-97b9-9fcf14cc80e3

📥 Commits

Reviewing files that changed from the base of the PR and between fd8ec86 and 1b97205.

📒 Files selected for processing (3)
  • src/lib/litegraph/src/widgets/BaseWidget.test.ts
  • src/lib/litegraph/src/widgets/BaseWidget.ts
  • src/workbench/extensions/agent/crdt/mintPortWiring.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC.


📝 Walkthrough

Walkthrough

BaseWidget.serialize now uses accessors backed by _state.serialize. The constructor initializes the state from the input widget. Tests cover changing serialize after registration and checking the registered store state.

Changes

Widget serialization state

Layer / File(s) Summary
Serialize property and registered-state coverage
src/lib/litegraph/src/widgets/BaseWidget.ts, src/lib/litegraph/src/widgets/BaseWidget.test.ts, src/workbench/extensions/agent/crdt/mintPortWiring.test.ts
BaseWidget.serialize reads and writes _state.serialize. The constructor initializes the state from the input widget. Tests cover changes to the property after registration.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: drjkl

Merge Risk: 🔵 Low · up to 1b972

The top-level serialization flag controls live mint eligibility, but the integration fixture also disables options-level serialization, leaving that distinction untested. This is a bounded test gap; no current functional failure is established.

🚥 Pre-merge checks | ✅ 6 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ⚠️ Warning The PR title uses bug-fix language: fix(agent-crdt). The PR changes frontend files under src/, and no changed file is under browser_tests/. The description lists unit, lint, typecheck, and gate … Add or update a Playwright regression test under browser_tests/, or add a concrete explanation in the PR description stating why an end-to-end regression test is not practical.
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the change as a fix for agent CRDT display-widget minting review findings. It matches the main objective of the pull request.
Description check ✅ Passed The description provides a detailed summary, identifies the review findings addressed, and reports testing results. It does not use the template's separate Changes, Review Focus, or Screenshots headin…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Website End-To-End Regression Coverage ✅ Passed No files under apps/website/src/ or apps/website/public/ changed. The pull request changes LiteGraph widget code and agent CRDT tests only, so this website-specific check does not apply.
Adr Compliance For Entity/Litegraph Changes ✅ Passed The PR changes files under src/lib/litegraph/, so the check applies. The diff adds synchronized BaseWidget.serialize getter/setter state and updates related tests. It does not add direct spatial m…
Full details: End-To-End Regression Coverage For Fixes

Explanation

The PR title uses bug-fix language: fix(agent-crdt). The PR changes frontend files under src/, and no changed file is under browser_tests/. The description lists unit, lint, typecheck, and gate checks, but it does not give a concrete reason why an end-to-end regression test was not added.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@christian-byrne christian-byrne added cursor-review Trigger multi-model Cursor agent review on this PR greenlight labels Sep 29, 2026
@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/30/2026, 04:58:31 AM UTC

Links

🎭 Playwright: ✅ 2155 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2134 / ❌ 0 / ⚠️ 2 / ⏭️ 9)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since fd8ec867935e18bd58ac56994f11a4a367eb48d1

Full docs: ADR-DEVEX-LINT-0015

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.7 MB heap
canvas-mouse-sweep: · 59.7 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.2 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.3 MB heap
dom-widget-order-dense-n200-w200-i120: · 28.7 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 541ms TBT · 82.2 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 39.1 avg FPS · 39.9 P5 FPS ❌ (target: ≥52) · 244ms TBT · 85.8 MB heap
extension-clean-combined-draw: · 29.4 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 1204ms TBT · 75.7 MB heap
extension-rgthree-prototype-draw: · 28.6 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 1618ms TBT · 77.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.0 MB heap
large-graph-pan: · 59.8 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.2 MB heap
large-graph-zoom: · 59.9 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.3 MB heap
legacy-node-drag: · 59.7 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.8 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 88.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.2 MB heap
subgraph-transition-enter: · 51.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 135ms TBT · 90.8 MB heap
viewport-pan-sweep: · 59.9 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.3 MB heap
vue-large-graph-idle: · 34.0 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 9ms TBT · 165.5 MB heap
vue-large-graph-pan: · 26.4 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 76ms TBT · 170.5 MB heap
vue-node-resize-workload: · 29.8 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 410ms TBT · 198.5 MB heap
vue-zoom-out-idle: · 34.3 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 168.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.6 MB heap
agent-composer-empty-conversation-typing: · 58.9 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.7 MB heap
agent-composer-long-conversation-typing: · 55.8 avg FPS · 30.1 P5 FPS ❌ (target: ≥52) · 0ms TBT · 110.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 4ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 444ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 61.7 MB
canvas-idle: DOM nodes -228
canvas-idle: event listeners -142
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 6ms
canvas-mouse-sweep: style recalc duration 20ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 840ms
canvas-mouse-sweep: script duration 171ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 62.7 MB
canvas-mouse-sweep: DOM nodes -214
canvas-mouse-sweep: event listeners -142
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 10ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 324ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 76.2 MB
canvas-zoom-sweep: DOM nodes 53
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 6ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 487ms
dom-widget-clipping: script duration 170ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 77.3 MB
dom-widget-clipping: DOM nodes -114
dom-widget-clipping: event listeners -71
dom-widget-order-dense-n200-w200-i120: avg frame time 35ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 818ms
dom-widget-order-dense-n200-w200-i120: script duration 69ms
dom-widget-order-dense-n200-w200-i120: TBT 541ms
dom-widget-order-dense-n200-w200-i120: heap used 82.2 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 26ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 473ms
dom-widget-order-sparse-n1000-w20-i120: script duration 174ms
dom-widget-order-sparse-n1000-w20-i120: TBT 244ms
dom-widget-order-sparse-n1000-w20-i120: heap used 85.8 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 34ms
extension-clean-combined-draw: p95 frame time 67ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 9081ms
extension-clean-combined-draw: script duration 7613ms
extension-clean-combined-draw: TBT 1204ms
extension-clean-combined-draw: heap used 75.7 MB
extension-clean-combined-draw: DOM nodes 0
extension-clean-combined-draw: event listeners 0
extension-rgthree-prototype-draw: avg frame time 35ms
extension-rgthree-prototype-draw: p95 frame time 67ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 0
extension-rgthree-prototype-draw: task duration 9589ms
extension-rgthree-prototype-draw: script duration 8092ms
extension-rgthree-prototype-draw: TBT 1618ms
extension-rgthree-prototype-draw: heap used 77.9 MB
extension-rgthree-prototype-draw: DOM nodes 0
extension-rgthree-prototype-draw: event listeners 0
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 8
large-graph-idle: task duration 545ms
large-graph-idle: script duration 33ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 78.0 MB
large-graph-idle: DOM nodes -228
large-graph-idle: event listeners -142
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 9ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1668ms
large-graph-pan: script duration 894ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 82.2 MB
large-graph-pan: DOM nodes -114
large-graph-pan: event listeners -82
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 64
large-graph-zoom: task duration 1620ms
large-graph-zoom: script duration 814ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 69.3 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 43
legacy-node-drag: task duration 1844ms
legacy-node-drag: script duration 996ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 74.8 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 514ms
minimap-idle: script duration 34ms
minimap-idle: TBT 0ms
minimap-idle: heap used 79.8 MB
minimap-idle: DOM nodes -114
minimap-idle: event listeners -71
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 6ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 388ms
subgraph-dom-widget-clipping: script duration 143ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 88.8 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 5ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 12
subgraph-idle: task duration 437ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 62.3 MB
subgraph-idle: DOM nodes -244
subgraph-idle: event listeners -188
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 22ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 79
subgraph-mouse-sweep: task duration 776ms
subgraph-mouse-sweep: script duration 112ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 60.2 MB
subgraph-mouse-sweep: DOM nodes -244
subgraph-mouse-sweep: event listeners -188
subgraph-transition-enter: avg frame time 19ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 29ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 17
subgraph-transition-enter: task duration 870ms
subgraph-transition-enter: script duration 40ms
subgraph-transition-enter: TBT 135ms
subgraph-transition-enter: heap used 90.8 MB
subgraph-transition-enter: DOM nodes 13667
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 32ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 5704ms
viewport-pan-sweep: script duration 2769ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 73.3 MB
viewport-pan-sweep: DOM nodes -228
viewport-pan-sweep: event listeners -142
vue-large-graph-idle: avg frame time 29ms
vue-large-graph-idle: p95 frame time 50ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16090ms
vue-large-graph-idle: script duration 314ms
vue-large-graph-idle: TBT 9ms
vue-large-graph-idle: heap used 165.5 MB
vue-large-graph-idle: DOM nodes -3061
vue-large-graph-idle: event listeners -14915
vue-large-graph-pan: avg frame time 38ms
vue-large-graph-pan: p95 frame time 83ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 173
vue-large-graph-pan: task duration 20150ms
vue-large-graph-pan: script duration 924ms
vue-large-graph-pan: TBT 76ms
vue-large-graph-pan: heap used 170.5 MB
vue-large-graph-pan: DOM nodes -3045
vue-large-graph-pan: event listeners -14915
vue-node-resize-workload: avg frame time 34ms
vue-node-resize-workload: p95 frame time 67ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 81ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5922ms
vue-node-resize-workload: script duration 110ms
vue-node-resize-workload: TBT 410ms
vue-node-resize-workload: heap used 198.5 MB
vue-node-resize-workload: DOM nodes 0
vue-node-resize-workload: event listeners 0
vue-zoom-out-idle: avg frame time 29ms
vue-zoom-out-idle: p95 frame time 50ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8172ms
vue-zoom-out-idle: script duration 126ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 168.7 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 21ms
workflow-execution: layout count 5
workflow-execution: style recalc count 21
workflow-execution: task duration 151ms
workflow-execution: script duration 12ms
workflow-execution: TBT 0ms
workflow-execution: heap used 77.6 MB
workflow-execution: DOM nodes 129
workflow-execution: event listeners 81
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 22ms
agent-composer-empty-conversation-typing: style recalc duration 103ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 78
agent-composer-empty-conversation-typing: task duration 828ms
agent-composer-empty-conversation-typing: script duration 341ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 82.7 MB
agent-composer-empty-conversation-typing: DOM nodes 76
agent-composer-empty-conversation-typing: event listeners 876
agent-composer-long-conversation-typing: avg frame time 18ms
agent-composer-long-conversation-typing: p95 frame time 33ms
agent-composer-long-conversation-typing: layout duration 25ms
agent-composer-long-conversation-typing: style recalc duration 257ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 78
agent-composer-long-conversation-typing: task duration 1374ms
agent-composer-long-conversation-typing: script duration 474ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 110.3 MB
agent-composer-long-conversation-typing: DOM nodes 76
agent-composer-long-conversation-typing: event listeners 876
Raw data
{
  "timestamp": "2026-09-30T05:08:42.765Z",
  "gitSha": "f7d913a9d9dd9d85c20a81c9ec30af7710fcb254",
  "branch": "christian-byrne/19026-review-fixes",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2024.706999999978,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 4.523000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 455.7370000000001,
      "heapDeltaBytes": -32202248,
      "heapUsedBytes": 65885436,
      "domNodes": -228,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 7.785,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2032.073999999966,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.720000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 431.6460000000001,
      "heapDeltaBytes": -15193016,
      "heapUsedBytes": 63436968,
      "domNodes": -228,
      "jsHeapTotalBytes": -1048576,
      "scriptDurationMs": 8.066999999999998,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66557377049181,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1804.6709999999848,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 20.53,
      "layouts": 12,
      "layoutDurationMs": 4.312,
      "taskDurationMs": 848.495,
      "heapDeltaBytes": -12746800,
      "heapUsedBytes": 65571360,
      "domNodes": -228,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 178.109,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.820560747663553,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1841.760000000022,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 19.038,
      "layouts": 12,
      "layoutDurationMs": 7.481999999999999,
      "taskDurationMs": 831.063,
      "heapDeltaBytes": -32550624,
      "heapUsedBytes": 65893700,
      "domNodes": -199,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 164.825,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66636363636363,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1733.9080000000422,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 10.749,
      "layouts": 6,
      "layoutDurationMs": 1.2159999999999997,
      "taskDurationMs": 318.503,
      "heapDeltaBytes": 1570716,
      "heapUsedBytes": 80306368,
      "domNodes": 53,
      "jsHeapTotalBytes": 3145728,
      "scriptDurationMs": 10.71,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846156,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1741.4409999998952,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 10.019,
      "layouts": 6,
      "layoutDurationMs": 1.0109999999999997,
      "taskDurationMs": 329.54299999999995,
      "heapDeltaBytes": -18891764,
      "heapUsedBytes": 79512540,
      "domNodes": 53,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 10.639,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66442307692308,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 729.8040000000015,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 4.572999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 461.4889999999999,
      "heapDeltaBytes": -1968700,
      "heapUsedBytes": 96765080,
      "domNodes": 0,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 169.409,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665116279069775,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 739.6280000000388,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 6.821999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 512.261,
      "heapDeltaBytes": -13223624,
      "heapUsedBytes": 65405196,
      "domNodes": -228,
      "jsHeapTotalBytes": 1572864,
      "scriptDurationMs": 171.108,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665909090909075,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1163.7489999999957,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 818.949,
      "heapDeltaBytes": 10057412,
      "heapUsedBytes": 86215172,
      "domNodes": 0,
      "jsHeapTotalBytes": 3833856,
      "scriptDurationMs": 64.96,
      "eventListeners": 0,
      "totalBlockingTimeMs": 544,
      "frameDurationMs": 35.351515151515166,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1165.2199999999766,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 816.5720000000001,
      "heapDeltaBytes": 8898284,
      "heapUsedBytes": 86175156,
      "domNodes": 0,
      "jsHeapTotalBytes": 2785280,
      "scriptDurationMs": 74.00499999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 538,
      "frameDurationMs": 34.31176470588236,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 899.3509999999674,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 475.6789999999995,
      "heapDeltaBytes": 15871268,
      "heapUsedBytes": 89218168,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 180.529,
      "eventListeners": 0,
      "totalBlockingTimeMs": 260,
      "frameDurationMs": 25.714285714285715,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 867.4230000000307,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 470.0710000000008,
      "heapDeltaBytes": 16023860,
      "heapUsedBytes": 90624540,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 167.92600000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 227,
      "frameDurationMs": 25.488235294117658,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9453.119999999955,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8643.311000000002,
      "heapDeltaBytes": -1079132,
      "heapUsedBytes": 79267528,
      "domNodes": 0,
      "jsHeapTotalBytes": -15990784,
      "scriptDurationMs": 7339.515,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1326,
      "frameDurationMs": 36.06717557251908,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10471.98800000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9519.259,
      "heapDeltaBytes": -1086312,
      "heapUsedBytes": 79411420,
      "domNodes": 0,
      "jsHeapTotalBytes": -15990784,
      "scriptDurationMs": 7887.295000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1082,
      "frameDurationMs": 32.007033639143735,
      "p95FrameDurationMs": 66.59999999999945
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9649.365999999987,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8952.569000000001,
      "heapDeltaBytes": 12952880,
      "heapUsedBytes": 93868048,
      "domNodes": 0,
      "jsHeapTotalBytes": -2097152,
      "scriptDurationMs": 7632.537,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1601,
      "frameDurationMs": 36.48825757575757,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 11233.806999999957,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10225.349,
      "heapDeltaBytes": -11473472,
      "heapUsedBytes": 69496972,
      "domNodes": 0,
      "jsHeapTotalBytes": -3670016,
      "scriptDurationMs": 8551.782,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1634,
      "frameDurationMs": 33.3320474777448,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2045.2060000000074,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 2.9010000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 540.321,
      "heapDeltaBytes": -37177412,
      "heapUsedBytes": 81952968,
      "domNodes": -228,
      "jsHeapTotalBytes": -360448,
      "scriptDurationMs": 31.983999999999998,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2052.7550000000474,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 3.424,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 549.463,
      "heapDeltaBytes": -37183624,
      "heapUsedBytes": 81554888,
      "domNodes": -228,
      "jsHeapTotalBytes": 163840,
      "scriptDurationMs": 34.638000000000005,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2362.6630000000546,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 9.824000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1639.947,
      "heapDeltaBytes": -36367252,
      "heapUsedBytes": 83137788,
      "domNodes": -228,
      "jsHeapTotalBytes": 389120,
      "scriptDurationMs": 851.265,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.785714285714285,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2713.822999999934,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 9.078000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1696.6770000000001,
      "heapDeltaBytes": 26874056,
      "heapUsedBytes": 89166988,
      "domNodes": 0,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 937.156,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666049382716054,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3668.2440000000156,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 10.458000000000002,
      "layouts": 60,
      "layoutDurationMs": 13.198,
      "taskDurationMs": 1703.6909999999996,
      "heapDeltaBytes": 8480124,
      "heapUsedBytes": 72836124,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 813.147,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66590909090909,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3558.4820000000263,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 10.65,
      "layouts": 60,
      "layoutDurationMs": 13.182,
      "taskDurationMs": 1535.6109999999999,
      "heapDeltaBytes": 8764264,
      "heapUsedBytes": 72568280,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 815.047,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.744811320754714,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3128.4689999999955,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 5.485,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1881.745,
      "heapDeltaBytes": 25553464,
      "heapUsedBytes": 90448416,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 961.1129999999998,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.755376344086017,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3110.3219999999965,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 5.451999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1805.6980000000003,
      "heapDeltaBytes": 2749220,
      "heapUsedBytes": 66499284,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 1031.73,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.755675675675672,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2011.3139999999703,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.0170000000000012,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 500.89099999999985,
      "heapDeltaBytes": 20779784,
      "heapUsedBytes": 84378432,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 32.805,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2027.4530000000368,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 2.2909999999999977,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 526.946,
      "heapDeltaBytes": 20906384,
      "heapUsedBytes": 82999596,
      "domNodes": -228,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 35.125,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 599.7519999999668,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 6.344,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 397.19399999999996,
      "heapDeltaBytes": 13168204,
      "heapUsedBytes": 93239892,
      "domNodes": 0,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 148.548,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 602.7490000000171,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 5.732999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 379.24899999999997,
      "heapDeltaBytes": 12894920,
      "heapUsedBytes": 92923508,
      "domNodes": 0,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 138.40000000000003,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663888888888906,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2032.1009999999546,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 5.3489999999999975,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 445.60699999999997,
      "heapDeltaBytes": -10743512,
      "heapUsedBytes": 68744368,
      "domNodes": -244,
      "jsHeapTotalBytes": -262144,
      "scriptDurationMs": 7.366000000000001,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2025.4460000001018,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 4.078999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 429.029,
      "heapDeltaBytes": -17999824,
      "heapUsedBytes": 61977552,
      "domNodes": -244,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.430000000000002,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1761.3569999999754,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 25.712000000000003,
      "layouts": 16,
      "layoutDurationMs": 5.496,
      "taskDurationMs": 775.287,
      "heapDeltaBytes": -18898556,
      "heapUsedBytes": 61720112,
      "domNodes": -244,
      "jsHeapTotalBytes": -262144,
      "scriptDurationMs": 111.86500000000001,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66509433962264,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1750.498000000107,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 18.895000000000003,
      "layouts": 16,
      "layoutDurationMs": 5.558999999999999,
      "taskDurationMs": 775.924,
      "heapDeltaBytes": -15945756,
      "heapUsedBytes": 64457216,
      "domNodes": -244,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 112.39000000000001,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1401.3590000000704,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 29.06299999999999,
      "layouts": 5,
      "layoutDurationMs": 13.648999999999997,
      "taskDurationMs": 870.0710000000003,
      "heapDeltaBytes": 21412460,
      "heapUsedBytes": 95260912,
      "domNodes": 13667,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 39.757999999999996,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 135,
      "frameDurationMs": 19.405479452054788,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8467.472000000043,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 32.513,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5712.517,
      "heapDeltaBytes": -43259540,
      "heapUsedBytes": 74777436,
      "domNodes": -228,
      "jsHeapTotalBytes": -430080,
      "scriptDurationMs": 2783.1929999999998,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66587771203156,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8478.958000000035,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 30.987,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5694.948,
      "heapDeltaBytes": -40359676,
      "heapUsedBytes": 78890324,
      "domNodes": -228,
      "jsHeapTotalBytes": -167936,
      "scriptDurationMs": 2754.723,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.699013806706116,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16648.547000000006,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16043.877999999999,
      "heapDeltaBytes": -48070464,
      "heapUsedBytes": 160637344,
      "domNodes": -3075,
      "jsHeapTotalBytes": 6733824,
      "scriptDurationMs": 322.72299999999996,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 18,
      "frameDurationMs": 29.730892857142855,
      "p95FrameDurationMs": 50.10000000000218
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16631.684999999947,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16135.593,
      "heapDeltaBytes": -20819984,
      "heapUsedBytes": 186476480,
      "domNodes": -3046,
      "jsHeapTotalBytes": 5771264,
      "scriptDurationMs": 304.862,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 29.027225130890056,
      "p95FrameDurationMs": 50.10000000000218
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20619.38399999997,
      "styleRecalcs": 169,
      "styleRecalcDurationMs": 16.295999999999978,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20314.779000000002,
      "heapDeltaBytes": -60902744,
      "heapUsedBytes": 167311404,
      "domNodes": -3045,
      "jsHeapTotalBytes": 3497984,
      "scriptDurationMs": 892.563,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 46,
      "frameDurationMs": 38.64746716697936,
      "p95FrameDurationMs": 83.29999999999927
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20397.663999999964,
      "styleRecalcs": 177,
      "styleRecalcDurationMs": 17.502000000000017,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19984.223,
      "heapDeltaBytes": -34792556,
      "heapUsedBytes": 190197912,
      "domNodes": -3045,
      "jsHeapTotalBytes": 5664768,
      "scriptDurationMs": 954.695,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 105,
      "frameDurationMs": 37.05890909090909,
      "p95FrameDurationMs": 83.29999999999927
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5991.6560000000345,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 81.52900000000002,
      "layouts": 20,
      "layoutDurationMs": 22.685999999999996,
      "taskDurationMs": 5889.506,
      "heapDeltaBytes": -12159436,
      "heapUsedBytes": 210973592,
      "domNodes": 0,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 109.34200000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 412,
      "frameDurationMs": 33.612359550561806,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6071.307999999931,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 79.763,
      "layouts": 20,
      "layoutDurationMs": 22.825,
      "taskDurationMs": 5954.450000000001,
      "heapDeltaBytes": 1174412,
      "heapUsedBytes": 205320504,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 111.382,
      "eventListeners": 0,
      "totalBlockingTimeMs": 408,
      "frameDurationMs": 33.42362637362636,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8456.62299999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8172.035000000001,
      "heapDeltaBytes": -57232,
      "heapUsedBytes": 169257476,
      "domNodes": 0,
      "jsHeapTotalBytes": -15466496,
      "scriptDurationMs": 126.857,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 29.036769759450173,
      "p95FrameDurationMs": 50.10000000000218
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8474.58800000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8172.288,
      "heapDeltaBytes": 9434580,
      "heapUsedBytes": 184429592,
      "domNodes": 0,
      "jsHeapTotalBytes": -29884416,
      "scriptDurationMs": 125.75700000000006,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 29.252068965517235,
      "p95FrameDurationMs": 50.10000000000218
    },
    {
      "name": "workflow-execution",
      "durationMs": 490.83999999993466,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 21.468,
      "layouts": 5,
      "layoutDurationMs": 2.5260000000000002,
      "taskDurationMs": 149.00199999999998,
      "heapDeltaBytes": -14459560,
      "heapUsedBytes": 81187280,
      "domNodes": 131,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 12.078,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 514.4109999999955,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 20.029999999999998,
      "layouts": 4,
      "layoutDurationMs": 1.71,
      "taskDurationMs": 152.682,
      "heapDeltaBytes": -14211544,
      "heapUsedBytes": 81572348,
      "domNodes": 126,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 12.072,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 829.2079999999942,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 100.491,
      "layouts": 76,
      "layoutDurationMs": 20.301,
      "taskDurationMs": 787.235,
      "heapDeltaBytes": 17732696,
      "heapUsedBytes": 84903692,
      "domNodes": 76,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 323.33700000000005,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666000000000004,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 907.77700000001,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 105.794,
      "layouts": 76,
      "layoutDurationMs": 22.807000000000002,
      "taskDurationMs": 869.348,
      "heapDeltaBytes": 18191376,
      "heapUsedBytes": 88442484,
      "domNodes": 76,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 357.86,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.296226415094335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1358.4230000000161,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 252.52200000000002,
      "layouts": 76,
      "layoutDurationMs": 25.096,
      "taskDurationMs": 1331.22,
      "heapDeltaBytes": 8864316,
      "heapUsedBytes": 115481336,
      "domNodes": 76,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 455.35200000000003,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.510126582278495,
      "p95FrameDurationMs": 33.20000000000073
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1431.5240000000813,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 262.187,
      "layouts": 76,
      "layoutDurationMs": 25.731,
      "taskDurationMs": 1417.331,
      "heapDeltaBytes": 9189788,
      "heapUsedBytes": 115831284,
      "domNodes": 76,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 492.666,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.332500000000003,
      "p95FrameDurationMs": 33.30000000000109
    }
  ]
}

🔬 E2E Coverage

Note

The shard matrix did not pass, so these totals cannot be confirmed comparable with a whole merge.

Metric Covered Total Pct
Lines 52840 79944 66.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1151
src/LGraphNode.ts 70.2% 388
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.1% 330
src/LGraph.ts 78.9% 269
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/core/billing/operationLifecycle.ts 1.2% 252
src/scripts/app.ts 73.1% 252
src/scripts/pnginfo.ts 20.8% 221

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 29, 2026
@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                             Coverage Diff                              @@
##           kishore/crdt-skip-non-value-widget-mints   #19504      +/-   ##
============================================================================
- Coverage                                     85.06%   85.06%   -0.01%     
============================================================================
  Files                                          2316     2316              
  Lines                                        133946   133932      -14     
  Branches                                      36241    36241              
============================================================================
- Hits                                         113943   113930      -13     
+ Misses                                        19681    19680       -1     
  Partials                                        322      322              
Flag Coverage Δ
e2e 66.10% <100.00%> (+0.01%) ⬆️
unit 81.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lib/litegraph/src/widgets/BaseWidget.ts 88.83% <100.00%> (+0.10%) ⬆️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 7 finding(s).

Severity Count
🟠 High 3
🟡 Medium 1
🟢 Low 2
⚪ Nit 1

Panel: 8/8 reviewers contributed findings.

@christian-byrne christian-byrne added cursor-review Trigger multi-model Cursor agent review on this PR and removed cursor-review Trigger multi-model Cursor agent review on this PR labels Sep 30, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Round 2 — ledger: 7 prior finding(s) across 1 round(s) (0 never answered).

Found 7 finding(s).

Severity Count
🟠 High 1
🟡 Medium 2
🟢 Low 4

Panel: 8/8 reviewers contributed findings.

@datadog-official

datadog-official Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Pipelines

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1b97205 | Docs | View more details | Give us feedback!

@christian-byrne
christian-byrne merged commit 5ee77e6 into kishore/crdt-skip-non-value-widget-mints Sep 30, 2026
176 of 178 checks passed
@christian-byrne
christian-byrne deleted the christian-byrne/19026-review-fixes branch September 30, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor agent review on this PR greenlight risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants