Repository navigation
fix(agent-crdt): preserve prompt-only widget mints - #19593
Conversation
Addresses review feedback: Comfy-Org#19026 (comment)
Addresses review feedback: Comfy-Org#19026 (comment)
Addresses review feedback: Comfy-Org#19026 (comment)
This reverts commit 800e449.
This reverts commit 5314515.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ❌ 2153 passed, 1 failed · 2 flaky❌ Failed Tests📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-30T07:56:23.633Z",
"gitSha": "aaf284c1252bf3764597251ede6121ee8949968c",
"branch": "christian-byrne/displaywidget-prompteligibility-repair-3",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2058.5930000000303,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.265,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.00700000000006,
"heapDeltaBytes": -26129260,
"heapUsedBytes": 72201244,
"domNodes": -228,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 9.683,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.80327868852459,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2026.0749999999916,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.643999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.759,
"heapDeltaBytes": -35476672,
"heapUsedBytes": 62788940,
"domNodes": -228,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 9.009,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1868.801000000019,
"styleRecalcs": 80,
"styleRecalcDurationMs": 17.819000000000003,
"layouts": 12,
"layoutDurationMs": 4.713,
"taskDurationMs": 845.002,
"heapDeltaBytes": -17521768,
"heapUsedBytes": 60916572,
"domNodes": -228,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 178.025,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66607142857143,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1818.9920000000939,
"styleRecalcs": 79,
"styleRecalcDurationMs": 18.467000000000002,
"layouts": 12,
"layoutDurationMs": 3.7039999999999997,
"taskDurationMs": 841.574,
"heapDeltaBytes": -9464676,
"heapUsedBytes": 69167380,
"domNodes": -228,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 164.89900000000003,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871556,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.7890000000439,
"styleRecalcs": 33,
"styleRecalcDurationMs": 10.366000000000001,
"layouts": 6,
"layoutDurationMs": 1.2339999999999998,
"taskDurationMs": 334.48100000000005,
"heapDeltaBytes": -19022508,
"heapUsedBytes": 79260324,
"domNodes": 53,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 11.199000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.5789999999351,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.783999999999999,
"layouts": 6,
"layoutDurationMs": 1.066,
"taskDurationMs": 330.306,
"heapDeltaBytes": -18806236,
"heapUsedBytes": 79620812,
"domNodes": 53,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 10.851000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 680.8090000000107,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.8519999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.718,
"heapDeltaBytes": -1834924,
"heapUsedBytes": 96449024,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 175.86599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536566,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 677.7459999999564,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.212000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.322,
"heapDeltaBytes": -1860028,
"heapUsedBytes": 96609580,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 171.939,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1207.9269999999838,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 845.348,
"heapDeltaBytes": 9030620,
"heapUsedBytes": 85153696,
"domNodes": 0,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 71.02699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 571,
"frameDurationMs": 35.294117647058826,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1180.3280000000314,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 837.679,
"heapDeltaBytes": 6435056,
"heapUsedBytes": 83624952,
"domNodes": 0,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 70.309,
"eventListeners": 0,
"totalBlockingTimeMs": 562,
"frameDurationMs": 35.857575757575766,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.7989999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.7839999999999,
"heapDeltaBytes": 15495828,
"heapUsedBytes": 88864388,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 165.61000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 224,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.3549999999132,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.0250000000004,
"heapDeltaBytes": 12417024,
"heapUsedBytes": 93068772,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 164.18,
"eventListeners": 0,
"totalBlockingTimeMs": 228,
"frameDurationMs": 25.491176470588258,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11424.065000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10363.052,
"heapDeltaBytes": 4507312,
"heapUsedBytes": 86892688,
"domNodes": 0,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 8599.014000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1671,
"frameDurationMs": 32.994797687861265,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9511.443999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8766.581,
"heapDeltaBytes": -14047560,
"heapUsedBytes": 66776736,
"domNodes": 0,
"jsHeapTotalBytes": -15466496,
"scriptDurationMs": 7477.692999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1220,
"frameDurationMs": 35.05387453874538,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10598.896999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9676.220000000001,
"heapDeltaBytes": -9285092,
"heapUsedBytes": 70703048,
"domNodes": 0,
"jsHeapTotalBytes": -15466496,
"scriptDurationMs": 7989.134000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1052,
"frameDurationMs": 32.31585365853659,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10734.026000000085,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9737.515,
"heapDeltaBytes": -9107572,
"heapUsedBytes": 71147884,
"domNodes": 0,
"jsHeapTotalBytes": -7602176,
"scriptDurationMs": 8065.823,
"eventListeners": 0,
"totalBlockingTimeMs": 1252,
"frameDurationMs": 32.13443113772455,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "large-graph-idle",
"durationMs": 2064.337000000023,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.399000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.764,
"heapDeltaBytes": -36635644,
"heapUsedBytes": 82315168,
"domNodes": -228,
"jsHeapTotalBytes": -360448,
"scriptDurationMs": 33.65699999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622944,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2042.291999999975,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.907,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.5500000000001,
"heapDeltaBytes": -38337616,
"heapUsedBytes": 81216596,
"domNodes": -228,
"jsHeapTotalBytes": -360448,
"scriptDurationMs": 33.907999999999994,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2504.1499999999814,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.044,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1620.912,
"heapDeltaBytes": 23523176,
"heapUsedBytes": 87413608,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 848.7470000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.777852348993292,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2287.097000000017,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.852,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1487.4089999999999,
"heapDeltaBytes": 20302872,
"heapUsedBytes": 82509152,
"domNodes": -228,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 859.456,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.788970588235294,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3682.454000000007,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.879,
"layouts": 60,
"layoutDurationMs": 13.679,
"taskDurationMs": 1689.4930000000002,
"heapDeltaBytes": 8296276,
"heapUsedBytes": 73180904,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 794.4,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3646.5580000000273,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.392999999999999,
"layouts": 60,
"layoutDurationMs": 13.652000000000001,
"taskDurationMs": 1671.816,
"heapDeltaBytes": 12586960,
"heapUsedBytes": 76553648,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 790.988,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665753424657535,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3201.071000000013,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.662999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1937.8020000000001,
"heapDeltaBytes": 27360016,
"heapUsedBytes": 91471360,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 999.6740000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.842105263157894,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3139.6089999999504,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.0379999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1899.494,
"heapDeltaBytes": 2363160,
"heapUsedBytes": 66801636,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 981.9380000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755080213903746,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2019.2240000000083,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.434000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.064,
"heapDeltaBytes": 20149160,
"heapUsedBytes": 83538648,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.471,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2041.8619999999237,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.6310000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.888,
"heapDeltaBytes": -38120740,
"heapUsedBytes": 83280380,
"domNodes": -228,
"jsHeapTotalBytes": -622592,
"scriptDurationMs": 32.942,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 649.550999999974,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.225999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.183,
"heapDeltaBytes": -21697696,
"heapUsedBytes": 58825024,
"domNodes": -214,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 148.15,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.105263157894736,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.1819999999616,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.5630000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.089,
"heapDeltaBytes": 13010484,
"heapUsedBytes": 92998612,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 148.077,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2037.3899999999594,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.868,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.77799999999996,
"heapDeltaBytes": -20284800,
"heapUsedBytes": 60280092,
"domNodes": -244,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 7.519999999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2068.99199999998,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.2120000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.713,
"heapDeltaBytes": -8102576,
"heapUsedBytes": 71867296,
"domNodes": -244,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 8.411999999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66532258064516,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1759.303999999986,
"styleRecalcs": 75,
"styleRecalcDurationMs": 20.823,
"layouts": 16,
"layoutDurationMs": 5.401,
"taskDurationMs": 788.516,
"heapDeltaBytes": -21393792,
"heapUsedBytes": 59685344,
"domNodes": -244,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 112.56099999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1744.6770000000242,
"styleRecalcs": 77,
"styleRecalcDurationMs": 19.488000000000003,
"layouts": 16,
"layoutDurationMs": 5.887,
"taskDurationMs": 700.076,
"heapDeltaBytes": -21786772,
"heapUsedBytes": 59061396,
"domNodes": -244,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 115.46100000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1452.461000000028,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.255000000000003,
"layouts": 5,
"layoutDurationMs": 12.890999999999996,
"taskDurationMs": 924.7670000000002,
"heapDeltaBytes": 21426652,
"heapUsedBytes": 100167072,
"domNodes": 13667,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 31.644000000000005,
"eventListeners": 2383,
"totalBlockingTimeMs": 138,
"frameDurationMs": 19.298684210526325,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8517.12299999997,
"styleRecalcs": 251,
"styleRecalcDurationMs": 33.090999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5741.328,
"heapDeltaBytes": -44294916,
"heapUsedBytes": 74407960,
"domNodes": -228,
"jsHeapTotalBytes": 356352,
"scriptDurationMs": 2837.6520000000005,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698821218074656,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8635.626000000002,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.285999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5753.424,
"heapDeltaBytes": -40193308,
"heapUsedBytes": 78572148,
"domNodes": -228,
"jsHeapTotalBytes": -954368,
"scriptDurationMs": 2823.871,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69806576402321,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12678.598999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12096.047,
"heapDeltaBytes": -27011768,
"heapUsedBytes": 173760044,
"domNodes": -3045,
"jsHeapTotalBytes": 14454784,
"scriptDurationMs": 208.958,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.287563025210083,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-idle",
"durationMs": 17022.9250000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16449.846,
"heapDeltaBytes": -32199476,
"heapUsedBytes": 176265184,
"domNodes": -3045,
"jsHeapTotalBytes": 3977216,
"scriptDurationMs": 283.113,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.366724137931037,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 20757.116999999995,
"styleRecalcs": 159,
"styleRecalcDurationMs": 17.557000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20501.766,
"heapDeltaBytes": -17836396,
"heapUsedBytes": 178997372,
"domNodes": -3045,
"jsHeapTotalBytes": 9916416,
"scriptDurationMs": 938.545,
"eventListeners": -14915,
"totalBlockingTimeMs": 48,
"frameDurationMs": 40.764636542239685,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 21012.227999999937,
"styleRecalcs": 167,
"styleRecalcDurationMs": 18.07799999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20583.635000000002,
"heapDeltaBytes": -49850564,
"heapUsedBytes": 167480616,
"domNodes": -3045,
"jsHeapTotalBytes": 10940416,
"scriptDurationMs": 938.8349999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 56,
"frameDurationMs": 39.00092936802974,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6193.313999999987,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.86000000000001,
"layouts": 20,
"layoutDurationMs": 23.639999999999993,
"taskDurationMs": 6101.038,
"heapDeltaBytes": -3171396,
"heapUsedBytes": 218814124,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 115.24799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 476,
"frameDurationMs": 35.836994219653185,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6181.792000000087,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.70700000000001,
"layouts": 20,
"layoutDurationMs": 24.374000000000006,
"taskDurationMs": 6092.35,
"heapDeltaBytes": 909600,
"heapUsedBytes": 205533752,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 113.92200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 459,
"frameDurationMs": 36.06023391812866,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8614.317000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8329.783,
"heapDeltaBytes": -16163828,
"heapUsedBytes": 188570336,
"domNodes": -3045,
"jsHeapTotalBytes": 7352320,
"scriptDurationMs": 132.353,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.25034013605443,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8642.814999999928,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8408.429999999998,
"heapDeltaBytes": -53191156,
"heapUsedBytes": 169103292,
"domNodes": -3045,
"jsHeapTotalBytes": 5156864,
"scriptDurationMs": 141.64099999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.29087719298245,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 478.64800000002106,
"styleRecalcs": 14,
"styleRecalcDurationMs": 16.66,
"layouts": 3,
"layoutDurationMs": 0.9460000000000001,
"taskDurationMs": 184.72600000000003,
"heapDeltaBytes": -43887844,
"heapUsedBytes": 52521316,
"domNodes": -199,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 12.558999999999997,
"eventListeners": -101,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 137.25099999999202,
"styleRecalcs": 10,
"styleRecalcDurationMs": 12.589999999999998,
"layouts": 3,
"layoutDurationMs": 0.9440000000000001,
"taskDurationMs": 93.61,
"heapDeltaBytes": -16777148,
"heapUsedBytes": 79998456,
"domNodes": 94,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 6.7749999999999995,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.674999999999955,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 864.4620000000032,
"styleRecalcs": 78,
"styleRecalcDurationMs": 105.585,
"layouts": 76,
"layoutDurationMs": 21.217,
"taskDurationMs": 824.559,
"heapDeltaBytes": 17922124,
"heapUsedBytes": 86836516,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 336.70300000000003,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667307692307688,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 854.2810000000145,
"styleRecalcs": 78,
"styleRecalcDurationMs": 104.687,
"layouts": 76,
"layoutDurationMs": 22.339000000000002,
"taskDurationMs": 816.628,
"heapDeltaBytes": 17955276,
"heapUsedBytes": 87718460,
"domNodes": 76,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 335.953,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384603,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1369.6699999999282,
"styleRecalcs": 78,
"styleRecalcDurationMs": 243.63899999999998,
"layouts": 76,
"layoutDurationMs": 24.488,
"taskDurationMs": 1351.2119999999998,
"heapDeltaBytes": 9235096,
"heapUsedBytes": 116038460,
"domNodes": 76,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 458.375,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.5,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1360.9330000000455,
"styleRecalcs": 78,
"styleRecalcDurationMs": 244.524,
"layouts": 76,
"layoutDurationMs": 25.157,
"taskDurationMs": 1346.1879999999999,
"heapDeltaBytes": 14678660,
"heapUsedBytes": 129861384,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 454.478,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.28271604938271,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E CoverageNote The shard matrix did not pass, so these totals cannot be confirmed comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## kishore/crdt-skip-non-value-widget-mints #19593 +/- ##
=========================================================================
Coverage 85.06% 85.07%
=========================================================================
Files 2316 2316
Lines 133946 133937 -9
Branches 36241 36244 +3
=========================================================================
- Hits 113943 113942 -1
+ Misses 19681 19673 -8
Partials 322 322
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
BaseWidget.serializecorrectionoptions.serialize) from workflow persistence (widget.serialize) for live widget mintsTest plan
NODE_OPTIONS=--no-experimental-webstorage pnpm exec vitest run src/workbench/extensions/agent/crdt/mintPortWiring.test.ts src/lib/litegraph/src/widgets/BaseWidget.test.ts(61 passed)set_widget, received[]pnpm exec eslint src/workbench/extensions/agent/crdt/mintPortWiring.ts src/workbench/extensions/agent/crdt/mintPortWiring.test.tspnpm exec oxfmt --check src/workbench/extensions/agent/crdt/mintPortWiring.ts src/workbench/extensions/agent/crdt/mintPortWiring.test.tsArchitecture boundary
This is a narrow current-architecture hotfix companion targeting #19026. It does not add inbound store-first apply, reconciliation, or new graph mutation surfaces; the legacy outbound store-side mint seam remains superseded by #18700.