Repository navigation
[backport core/1.55] feat(agent): emit app:agent_error telemetry (TEL-8) (#16628) - #19496
Conversation
Implements the required V1 telemetry event `app:agent_error` per `reports/telemetry/v1-checklist.md` in the `in-app-agent-program` workspace (row `TEL-8`): "FE surfaces an agent failure to the user, including pre-acceptance request failures not represented by `agent_turn_failed`." Follows the `app:agent_reconnect_failed` precedent (TEL-11, #16397) for the telemetry plumbing shape. - `AgentErrorMetadata` in `src/platform/telemetry/types.ts`: `error_class` (`request_failed | malformed_stream_event | cancel_failed | history_load_failed | ask_answer_failed | thread_list_load_failed | workflow_open_failed`), `failure_stage` (`pre_acceptance | post_acceptance`), `retryable`, `turn_accepted`, `ui_treatment` (`inline_notice | error_overlay | toast | none`). - `trackAgentError` wired through `TelemetryRegistry` and `PostHogTelemetryProvider`. - Call sites at every FE-visible agent failure not already covered by the backend's `agent_turn_failed`: - `sendMessage()`: a rejected `postMessage` (`request_failed`), `inline_notice` via `recordFailedSend`. - `stopTurn()`: a failed `cancelMessage` (`cancel_failed`), post-acceptance, `error_overlay`. A 409 already-settled race is not tracked - it is not a failure. - `answerAsk()`: a failed ask answer (`ask_answer_failed`), post-acceptance - the turn hangs on an unresolved ask. The 409 collapse path is not tracked. - `onRaw()`: any frame failing `parseAgentWsEvent` (`malformed_stream_event`), deduped per turn. - `hydrateFromServer()`: a non-404 transcript load failure (`history_load_failed`). The 404 thread-not-found branch is not tracked. - `AgentPanelRoot.vue`: a failed agent-driven tab open (`workflow_open_failed`) and a failed thread-list load (`thread_list_load_failed`), both `error_overlay`. `turn_accepted` and `retryable` default from `failure_stage` and are overridable, because the stage only approximates them: a resume-path history load is a request the server never accepted issued while an accepted turn streams on, and a failed cancel is post-acceptance yet safe to resend. `retryable` is derived from the response status via `isRetryableRequestFailure()` for every request-shaped class, so the column means one thing across rows. **Not counted:** a busy-state double-submit. It is a normal interaction rather than a failure, and it is frequent enough to dominate the other classes and make the rate unalertable. Admission errors (`no_funds` paywall) also emit nothing - they return early from the send catch and have their own UI. `AgentRestClient.request()` now reads the response body in its own `try` past `response.ok` and raises `AgentResponseUnreadableError`. A truncated or proxy-mangled 2xx therefore classifies as post-acceptance and non-retryable, the same as a `ZodError` - both mean the server started the turn and the FE lost the ack. ``` $ pnpm typecheck (clean) $ pnpm lint 0 errors (225 pre-existing warnings, none in changed files) $ pnpm format:check All matched files use the correct format. $ pnpm knip (clean) $ pnpm vitest run src/platform/telemetry src/workbench/extensions/agent Test Files 114 passed (114) Tests 1629 passed (1629) ``` Every added or changed test was proven red by mutating the fix it covers, then green on restore. Follow-up filed from review: #17358 (a `localStorage` failure after the ack hides a turn the server already started - pre-existing). Trace: MTG-29, mtg-29.2 emitted-vs-required diff (`in-app-agent-program` TEL-8). <!-- authored-by:agent lane-TEL-8 -->
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (17 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 383bf265f8b69fbcdba3768fe5cfe06156b326ec
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2119 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-30T00:10:24.212Z",
"gitSha": "5fe897a4d31d21a100749b834f4f72376cecd330",
"branch": "backport-16628-to-core-1.55-manual",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2015.1910000000157,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.8900000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.98100000000005,
"heapDeltaBytes": 10078540,
"heapUsedBytes": 77926580,
"domNodes": -262,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.597999999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1991.3399999999228,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.761999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.832,
"heapDeltaBytes": 6505940,
"heapUsedBytes": 74143664,
"domNodes": -260,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.593,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1768.8630000000103,
"styleRecalcs": 45,
"styleRecalcDurationMs": 12.707999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 805.9879999999999,
"heapDeltaBytes": 5426600,
"heapUsedBytes": 73065136,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 166.971,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1756.1739999999872,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.583,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 785.3589999999999,
"heapDeltaBytes": 11224720,
"heapUsedBytes": 78732576,
"domNodes": -260,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 161.009,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1666.9120000000248,
"styleRecalcs": 29,
"styleRecalcDurationMs": 12.140000000000002,
"layouts": 6,
"layoutDurationMs": 0.9920000000000002,
"taskDurationMs": 316.55499999999995,
"heapDeltaBytes": 3116920,
"heapUsedBytes": 70799768,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.705000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1664.3119999999954,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.761,
"layouts": 6,
"layoutDurationMs": 0.9470000000000001,
"taskDurationMs": 322.156,
"heapDeltaBytes": 3103752,
"heapUsedBytes": 70728256,
"domNodes": 79,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.524000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 628.8509999999974,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.378000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.547,
"heapDeltaBytes": 18967452,
"heapUsedBytes": 86544764,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 165.713,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 638.898999999924,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.362,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.47200000000004,
"heapDeltaBytes": 18893172,
"heapUsedBytes": 86539236,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 166.283,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1199.3130000000178,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 853.518,
"heapDeltaBytes": 39011716,
"heapUsedBytes": 104458232,
"domNodes": -296,
"jsHeapTotalBytes": 19558400,
"scriptDurationMs": 69.063,
"eventListeners": -195,
"totalBlockingTimeMs": 573,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1193.9630000000534,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 855.853,
"heapDeltaBytes": 12353972,
"heapUsedBytes": 83907728,
"domNodes": 0,
"jsHeapTotalBytes": 19296256,
"scriptDurationMs": 73.87500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 578,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.7469999999698,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.014,
"heapDeltaBytes": 14397852,
"heapUsedBytes": 90682200,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.163,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 859.5340000000533,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.7859999999996,
"heapDeltaBytes": 14613728,
"heapUsedBytes": 91206240,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.49800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 234,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11085.622000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10135.035,
"heapDeltaBytes": 15572968,
"heapUsedBytes": 97431920,
"domNodes": -12,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 8750.128,
"eventListeners": 0,
"totalBlockingTimeMs": 1872,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10303.645999999957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9477.561,
"heapDeltaBytes": 4259748,
"heapUsedBytes": 86179052,
"domNodes": -14,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7869.5199999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 952,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10302.198000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9450.068,
"heapDeltaBytes": 31268824,
"heapUsedBytes": 96044164,
"domNodes": -6,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 7850.093999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1058,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10758.060999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9909.195,
"heapDeltaBytes": 21960512,
"heapUsedBytes": 86599872,
"domNodes": -4,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 8260.512,
"eventListeners": 0,
"totalBlockingTimeMs": 1288,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "large-graph-idle",
"durationMs": 2051.1700000000133,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.762000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.483,
"heapDeltaBytes": -6868812,
"heapUsedBytes": 80526744,
"domNodes": -246,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 35.00300000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2005.314999999996,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.03,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.832,
"heapDeltaBytes": 20193356,
"heapUsedBytes": 83981828,
"domNodes": -243,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.706999999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2307.957999999985,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.015000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1667.5699999999997,
"heapDeltaBytes": -7797284,
"heapUsedBytes": 80020124,
"domNodes": -251,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 879.9480000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2310.7410000000073,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.299999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1585.2999999999997,
"heapDeltaBytes": -8554808,
"heapUsedBytes": 79449680,
"domNodes": -243,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 934.5759999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3490.439999999978,
"styleRecalcs": 63,
"styleRecalcDurationMs": 15.674000000000001,
"layouts": 60,
"layoutDurationMs": 12.915,
"taskDurationMs": 1683.0759999999998,
"heapDeltaBytes": -8458016,
"heapUsedBytes": 73770344,
"domNodes": -255,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 784.187,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3553.933999999913,
"styleRecalcs": 61,
"styleRecalcDurationMs": 9.374,
"layouts": 60,
"layoutDurationMs": 13.011000000000001,
"taskDurationMs": 1697.377,
"heapDeltaBytes": 10982328,
"heapUsedBytes": 76168108,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 820.37,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3025.911000000008,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.496000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1872.9310000000003,
"heapDeltaBytes": 20646980,
"heapUsedBytes": 86422660,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 974.747,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3120.143999999982,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.516000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1931.4620000000002,
"heapDeltaBytes": 26742416,
"heapUsedBytes": 92509556,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1024.564,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2002.4319999999989,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.4330000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.6329999999999,
"heapDeltaBytes": 20217968,
"heapUsedBytes": 84591876,
"domNodes": -242,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.456999999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2001.8980000000965,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.3500000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.3770000000001,
"heapDeltaBytes": 20186804,
"heapUsedBytes": 84455120,
"domNodes": -249,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.08,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.3770000000222,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.203,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.112,
"heapDeltaBytes": 13404628,
"heapUsedBytes": 77386356,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 148.60299999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.1550000000143,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.417,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.55600000000004,
"heapDeltaBytes": 13772540,
"heapUsedBytes": 77116640,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 146.595,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.7909999999838,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.386000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.789,
"heapDeltaBytes": 7510852,
"heapUsedBytes": 77576576,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.068000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2002.886999999987,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.084999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.3860000000001,
"heapDeltaBytes": -5606648,
"heapUsedBytes": 64578432,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.370999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.0089999999805,
"styleRecalcs": 47,
"styleRecalcDurationMs": 14.845,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 713.6680000000001,
"heapDeltaBytes": -9278092,
"heapUsedBytes": 60079812,
"domNodes": -274,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 99.73100000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.8609999999426,
"styleRecalcs": 47,
"styleRecalcDurationMs": 16.68,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 737.2570000000001,
"heapDeltaBytes": -3213092,
"heapUsedBytes": 66980688,
"domNodes": -273,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 103.311,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.2030000000705,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.735999999999997,
"layouts": 5,
"layoutDurationMs": 12.94,
"taskDurationMs": 903.0550000000002,
"heapDeltaBytes": 21401644,
"heapUsedBytes": 94926668,
"domNodes": 13667,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 31.654999999999994,
"eventListeners": 2383,
"totalBlockingTimeMs": 132,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8347.936999999945,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.791,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5591.203,
"heapDeltaBytes": -10566936,
"heapUsedBytes": 76255428,
"domNodes": -240,
"jsHeapTotalBytes": 745472,
"scriptDurationMs": 2736.314,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8293.039000000022,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.562,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5687.684,
"heapDeltaBytes": -18075964,
"heapUsedBytes": 68854224,
"domNodes": -218,
"jsHeapTotalBytes": 5795840,
"scriptDurationMs": 2788.7650000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16630.80400000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16037.907000000001,
"heapDeltaBytes": -29865292,
"heapUsedBytes": 197704172,
"domNodes": -8061,
"jsHeapTotalBytes": -17436672,
"scriptDurationMs": 256,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16752.700000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16191.763,
"heapDeltaBytes": -58153048,
"heapUsedBytes": 183039400,
"domNodes": -8061,
"jsHeapTotalBytes": -17502208,
"scriptDurationMs": 260.494,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 15682.294999999955,
"styleRecalcs": 82,
"styleRecalcDurationMs": 11.942000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15086.728000000001,
"heapDeltaBytes": -56213140,
"heapUsedBytes": 181748156,
"domNodes": -8061,
"jsHeapTotalBytes": -15663104,
"scriptDurationMs": 818.215,
"eventListeners": -14928,
"totalBlockingTimeMs": 24,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20119.467999999983,
"styleRecalcs": 163,
"styleRecalcDurationMs": 16.543999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19747.861999999997,
"heapDeltaBytes": -43276832,
"heapUsedBytes": 191966532,
"domNodes": -8061,
"jsHeapTotalBytes": -12111872,
"scriptDurationMs": 904.514,
"eventListeners": -14928,
"totalBlockingTimeMs": 132,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4775.137000000086,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.178,
"layouts": 20,
"layoutDurationMs": 24.945999999999994,
"taskDurationMs": 4650.463,
"heapDeltaBytes": -62134864,
"heapUsedBytes": 178944040,
"domNodes": -8062,
"jsHeapTotalBytes": 18546688,
"scriptDurationMs": 92.613,
"eventListeners": -14928,
"totalBlockingTimeMs": 205,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6076.998000000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.71799999999998,
"layouts": 20,
"layoutDurationMs": 21.906999999999996,
"taskDurationMs": 5975.841,
"heapDeltaBytes": -58290396,
"heapUsedBytes": 182732076,
"domNodes": -8061,
"jsHeapTotalBytes": 11595776,
"scriptDurationMs": 103.62599999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 402,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6454.345999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6214.398000000001,
"heapDeltaBytes": -18108908,
"heapUsedBytes": 169758804,
"domNodes": 0,
"jsHeapTotalBytes": -18350080,
"scriptDurationMs": 105.937,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8251.225999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7989.695999999999,
"heapDeltaBytes": 19633976,
"heapUsedBytes": 198578920,
"domNodes": 0,
"jsHeapTotalBytes": -8650752,
"scriptDurationMs": 124.47199999999992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 114.52800000006391,
"styleRecalcs": 7,
"styleRecalcDurationMs": 21.712999999999997,
"layouts": 4,
"layoutDurationMs": 1.7139999999999997,
"taskDurationMs": 93.641,
"heapDeltaBytes": 3220712,
"heapUsedBytes": 68875904,
"domNodes": 111,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.518999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 447.6469999999608,
"styleRecalcs": 15,
"styleRecalcDurationMs": 23.205000000000002,
"layouts": 4,
"layoutDurationMs": 1.82,
"taskDurationMs": 115.29100000000003,
"heapDeltaBytes": 4911196,
"heapUsedBytes": 70809268,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.033,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 3 |
| 🟢 Low | 5 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.55 #19496 +/- ##
=============================================
+ Coverage 84.68% 84.70% +0.02%
=============================================
Files 2323 2323
Lines 132588 132729 +141
Branches 35450 33607 -1843
=============================================
+ Hits 112277 112423 +146
+ Misses 19951 19946 -5
Partials 360 360
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes 🚀 New features to boost your workflow:
|
## Summary Follow-up to #19496. That backport merged before its Cursor threads were resolved. This applies the validated fixes already used by the cloud/1.55 backport: - prevent duplicate retries after the server accepted a turn - bind malformed-stream telemetry to known turns and cap/redact issue context - preserve abort identity and remove route IDs from unreadable-response errors - suppress expected disowned-workflow noise and classify deterministic 4xx failures correctly - make background settlement side-effect-only - extract helpers to clear the Fallow complexity gate ## Testing - 535 focused tests passed (2 expected failures) - 110 session tests passed after the final helper extraction (2 expected failures) - `pnpm typecheck:app` - `pnpm typecheck:browser` - Fallow new-only audit: pass, zero introduced findings ## Source #19496
Backports #16628 to core/1.55 after the automated backport conflicted.
This preserves failed prompts for retry and records bounded agent error telemetry across transport, workflow, and session failures. The conflict resolution keeps the release branch agent implementation and layers the new telemetry contract onto it.
Validation: