Repository navigation
[backport core/1.55] fix(agent): address TEL-8 review findings - #19539
Conversation
Addresses review feedback:\nhttps://github.com//pull/19497#discussion_r4139468017\nhttps://github.com//pull/19497#discussion_r4139468021\nhttps://github.com//pull/19497#discussion_r4139468025\nhttps://github.com//pull/19497#discussion_r4139468037\nhttps://github.com//pull/19497#discussion_r4139468040\nhttps://github.com//pull/19497#discussion_r4139468044
Addresses review feedback:\nhttps://github.com//pull/19497#discussion_r4139468032\nhttps://github.com//pull/19497#discussion_r4139468034\nhttps://github.com//pull/19497#discussion_r4139468046
Addresses review feedback:\nhttps://github.com//pull/19497#discussion_r4139468044
Extract active-tab and send-failure helpers without changing behavior; document interface-dispatched telemetry members for static analysis.
Addresses review feedback:\nhttps://github.com//pull/19496#discussion_r4139518447\nhttps://github.com//pull/19496#discussion_r4139518462
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2125 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 7290f388ad811e1e4da8751263c06be317285aee
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-30T03:22:31.518Z",
"gitSha": "2b4e94e10e0593d91a4aebf76d4ce97a7ca7314b",
"branch": "fix-19496-review",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2018.4489999999755,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.9159999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.8119999999999,
"heapDeltaBytes": -1577936,
"heapUsedBytes": 66073984,
"domNodes": -262,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 11.639000000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2021.596000000045,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.196,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.864,
"heapDeltaBytes": 10379680,
"heapUsedBytes": 77998292,
"domNodes": -261,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 11.797999999999996,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1733.396999999968,
"styleRecalcs": 44,
"styleRecalcDurationMs": 14.579,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 839.9549999999999,
"heapDeltaBytes": 11104628,
"heapUsedBytes": 78816592,
"domNodes": -262,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 163.49999999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1791.0010000000511,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.458000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 842.5450000000001,
"heapDeltaBytes": -5010048,
"heapUsedBytes": 62642956,
"domNodes": -262,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 166.802,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.145000000055,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.679999999999996,
"layouts": 6,
"layoutDurationMs": 1.127,
"taskDurationMs": 430.903,
"heapDeltaBytes": 3125696,
"heapUsedBytes": 70672104,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 16.508999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1684.2589999999973,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.742999999999999,
"layouts": 6,
"layoutDurationMs": 1.161,
"taskDurationMs": 362.45200000000006,
"heapDeltaBytes": 3022024,
"heapUsedBytes": 70831988,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.856,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 685.2460000000065,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.457999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.15500000000003,
"heapDeltaBytes": 18967980,
"heapUsedBytes": 86512552,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 181.57899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 709.5819999999549,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.437,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.21000000000004,
"heapDeltaBytes": 18952528,
"heapUsedBytes": 86645756,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 171.11900000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1189.9850000000356,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 877.7660000000001,
"heapDeltaBytes": 39233364,
"heapUsedBytes": 107579980,
"domNodes": 0,
"jsHeapTotalBytes": 19820544,
"scriptDurationMs": 75.968,
"eventListeners": 0,
"totalBlockingTimeMs": 577,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1205.3430000000844,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 870.9080000000001,
"heapDeltaBytes": 38266132,
"heapUsedBytes": 108537736,
"domNodes": 0,
"jsHeapTotalBytes": 18771968,
"scriptDurationMs": 74.00599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 593,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.937999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.3730000000005,
"heapDeltaBytes": 14471844,
"heapUsedBytes": 89931312,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 174.77599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 232,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 879.4489999999087,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.65599999999966,
"heapDeltaBytes": 14963640,
"heapUsedBytes": 90405092,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 176.64600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 234,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11372.247000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10422.35,
"heapDeltaBytes": -11967896,
"heapUsedBytes": 70136968,
"domNodes": -14,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 8622.775000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1552,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 49.89999999999782
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11659.452999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10675.476999999999,
"heapDeltaBytes": 1969044,
"heapUsedBytes": 84330548,
"domNodes": -14,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 8817.288,
"eventListeners": 0,
"totalBlockingTimeMs": 1699,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11317.296999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10471.103000000001,
"heapDeltaBytes": -10963384,
"heapUsedBytes": 71269564,
"domNodes": -14,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8703.394000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 1415,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11851.136999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10916.85,
"heapDeltaBytes": 16133476,
"heapUsedBytes": 93100612,
"domNodes": -14,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 9078.958999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1857,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2089.7580000000744,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.321,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 790.8040000000001,
"heapDeltaBytes": -4887512,
"heapUsedBytes": 81696760,
"domNodes": -243,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 49.859,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2027.091999999925,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.492000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 657.445,
"heapDeltaBytes": -4048632,
"heapUsedBytes": 82797364,
"domNodes": -243,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 38.241,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2480.5690000000595,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.053999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1745.647,
"heapDeltaBytes": 20361292,
"heapUsedBytes": 84473008,
"domNodes": -243,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 886.2829999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2460.7420000000957,
"styleRecalcs": 69,
"styleRecalcDurationMs": 17.059999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1791.7419999999997,
"heapDeltaBytes": -7735768,
"heapUsedBytes": 80300048,
"domNodes": -250,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 925.386,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3680.213999999978,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.220000000000002,
"layouts": 60,
"layoutDurationMs": 14.238000000000001,
"taskDurationMs": 1797.691,
"heapDeltaBytes": 8410888,
"heapUsedBytes": 74214848,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 830.1500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3695.948000000044,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.583999999999998,
"layouts": 60,
"layoutDurationMs": 14.012,
"taskDurationMs": 1814.962,
"heapDeltaBytes": 9855692,
"heapUsedBytes": 75056688,
"domNodes": -250,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 843.604,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3175.0939999999446,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.2189999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2078.565,
"heapDeltaBytes": 25922696,
"heapUsedBytes": 92068912,
"domNodes": 4,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 1076.397,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3103.971999999999,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.79,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1977.811,
"heapDeltaBytes": 25663460,
"heapUsedBytes": 91800848,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 996.9110000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2042.7270000000135,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.633000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 725.259,
"heapDeltaBytes": -6270544,
"heapUsedBytes": 82702228,
"domNodes": -248,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 43.503,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2028.8519999999153,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.357000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 624.461,
"heapDeltaBytes": -4212936,
"heapUsedBytes": 84126044,
"domNodes": -244,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 39.781,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 589.0449999999419,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.402999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.66,
"heapDeltaBytes": 13751056,
"heapUsedBytes": 83593660,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 147.36100000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 600.0150000000986,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.345,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.453,
"heapDeltaBytes": 13707904,
"heapUsedBytes": 83708820,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 145.04600000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2018.5280000000603,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.459999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.574,
"heapDeltaBytes": -3345792,
"heapUsedBytes": 66558836,
"domNodes": -277,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.376,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.1240000000234,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.950999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.3399999999999,
"heapDeltaBytes": -13940944,
"heapUsedBytes": 55649336,
"domNodes": -277,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.263,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.4420000000673,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.694999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 828.998,
"heapDeltaBytes": 8870020,
"heapUsedBytes": 78403332,
"domNodes": -276,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 118.793,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.1159999999854,
"styleRecalcs": 44,
"styleRecalcDurationMs": 16.066999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 802.475,
"heapDeltaBytes": -13420272,
"heapUsedBytes": 56360432,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 118.745,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.3659999999545,
"styleRecalcs": 18,
"styleRecalcDurationMs": 32.690999999999995,
"layouts": 5,
"layoutDurationMs": 14.157999999999998,
"taskDurationMs": 1050.1620000000003,
"heapDeltaBytes": -4440596,
"heapUsedBytes": 84856804,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 33.412,
"eventListeners": 2383,
"totalBlockingTimeMs": 163,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8891.879000000017,
"styleRecalcs": 246,
"styleRecalcDurationMs": 35.458000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6133.919,
"heapDeltaBytes": 16208548,
"heapUsedBytes": 80134716,
"domNodes": -249,
"jsHeapTotalBytes": 192512,
"scriptDurationMs": 2879.0959999999995,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8677.837000000069,
"styleRecalcs": 251,
"styleRecalcDurationMs": 38.666000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6115.661999999999,
"heapDeltaBytes": -9667796,
"heapUsedBytes": 76532748,
"domNodes": -238,
"jsHeapTotalBytes": 1007616,
"scriptDurationMs": 2873.918,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13364.174999999932,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12767.502999999999,
"heapDeltaBytes": -58693404,
"heapUsedBytes": 181688936,
"domNodes": -8061,
"jsHeapTotalBytes": -13787136,
"scriptDurationMs": 225.28599999999997,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17376.357999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16994.931,
"heapDeltaBytes": -27580696,
"heapUsedBytes": 198299296,
"domNodes": -8061,
"jsHeapTotalBytes": -15212544,
"scriptDurationMs": 269.05999999999995,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21150.775000000067,
"styleRecalcs": 151,
"styleRecalcDurationMs": 19.283999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21003.01,
"heapDeltaBytes": -38960628,
"heapUsedBytes": 180564700,
"domNodes": -8061,
"jsHeapTotalBytes": -17833984,
"scriptDurationMs": 908.362,
"eventListeners": -14928,
"totalBlockingTimeMs": 90,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20837.795000000027,
"styleRecalcs": 149,
"styleRecalcDurationMs": 18.818,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20620.577,
"heapDeltaBytes": -34186016,
"heapUsedBytes": 180853116,
"domNodes": -8061,
"jsHeapTotalBytes": -13754368,
"scriptDurationMs": 900.7180000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 65,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6154.133000000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.206,
"layouts": 20,
"layoutDurationMs": 24.155999999999995,
"taskDurationMs": 6121.235000000001,
"heapDeltaBytes": -37527336,
"heapUsedBytes": 196813632,
"domNodes": -8061,
"jsHeapTotalBytes": 18337792,
"scriptDurationMs": 115.47999999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 433,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6129.877999999962,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.07,
"layouts": 20,
"layoutDurationMs": 22.998000000000005,
"taskDurationMs": 6086.8510000000015,
"heapDeltaBytes": -64845880,
"heapUsedBytes": 175996208,
"domNodes": -8061,
"jsHeapTotalBytes": 11595776,
"scriptDurationMs": 109.049,
"eventListeners": -14928,
"totalBlockingTimeMs": 444,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6674.582999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6423.221999999999,
"heapDeltaBytes": -37019736,
"heapUsedBytes": 168959416,
"domNodes": 0,
"jsHeapTotalBytes": -30146560,
"scriptDurationMs": 110.31500000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8573.621000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8463.354999999998,
"heapDeltaBytes": 27158792,
"heapUsedBytes": 195384812,
"domNodes": 0,
"jsHeapTotalBytes": -11796480,
"scriptDurationMs": 166.38200000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 483.68300000004183,
"styleRecalcs": 23,
"styleRecalcDurationMs": 36.31,
"layouts": 5,
"layoutDurationMs": 2.8139999999999996,
"taskDurationMs": 167.687,
"heapDeltaBytes": 5368696,
"heapUsedBytes": 70075012,
"domNodes": 157,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 20.308,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 101.07000000004973,
"styleRecalcs": 8,
"styleRecalcDurationMs": 20.686,
"layouts": 3,
"layoutDurationMs": 2.195,
"taskDurationMs": 81.33300000000001,
"heapDeltaBytes": 3043372,
"heapUsedBytes": 68491400,
"domNodes": 126,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 6.429999999999998,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 9 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 5 |
| 🟢 Low | 3 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.55 #19539 +/- ##
=============================================
- Coverage 84.70% 84.70% -0.01%
=============================================
Files 2324 2324
Lines 132768 132805 +37
Branches 33601 33618 +17
=============================================
+ Hits 112458 112488 +30
- Misses 19950 19957 +7
Partials 360 360
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Addresses review feedback:\nhttps://github.com//pull/19539#discussion_r4140288809\nhttps://github.com//pull/19539#discussion_r4140288814\nhttps://github.com//pull/19539#discussion_r4140288819\nhttps://github.com//pull/19539#discussion_r4140288824\nhttps://github.com//pull/19539#discussion_r4140288837\nhttps://github.com//pull/19539#discussion_r4140288842
Summary
Follow-up to #19496. That backport merged before its Cursor threads were resolved. This applies the validated fixes already used by the cloud/1.55 backport:
Testing
pnpm typecheck:apppnpm typecheck:browserSource
#19496