Repository navigation
[backport core/1.55] feat(agent): instrument starter-prompt clicks and sends (#18991) - #19489
Conversation
… they produce (Comfy-Org#18991) The five empty-state starter prompts are the cheapest lever on the first-run path and nothing measures them. `input_method: 'suggestion'` on `app:agent_message_sent` already says a chip was used; it cannot say **which** chip, and nothing at all counts a chip that was clicked and never sent. So "is prompt 3 the one that activates people?" is unanswerable, and any experiment on the prompt set would be unreadable. **New: `app:agent_starter_prompt_clicked`** — one event per click, never on render, hover or focus. | property | why it is there | |---|---| | `prompt_id` | The chip's **slot**, from a frozen table (`starterPrompts.ts`), not its display text — the copy is owned by product and is changing | | `prompt_index`, `prompt_count` | A reordered or resized set is visible instead of silently re-labelling slots | | `prompt_text_hash` | FNV-1a, 8 hex, of the displayed text. Without it a copy change under a stable `prompt_id` is indistinguishable from the slot performing differently. Not the text, not reversible | | `locale` | The locale that produced the hash — a translation is a different hash of the same prompt | | `click_id` | Minted per click; the join key to the send | | `draft_was_empty` | Inserting **appends**, so `false` marks a submitted draft that is a mix of this chip and something else | **Extended: `app:agent_message_sent`** gains `starter_prompt_id` and `starter_prompt_click_id`, so click → send → turn is one chain instead of three unrelated counts. Both are `null` for a typed message, which is the other arm of the question. No copy change, no change to the prompt set, no change to submission semantics, no flag or config touched. The click still inserts and still does not send (`browser_tests/tests/agent/agentPanel.spec.ts` covers that and is untouched). - **Attribution lives and dies with `promptOrigin`**: held with the submission snapshot, cleared at `startSubmission`, restored by `takeFailedSubmission` so a retry is still that chip's message, dropped when the conversation's edit action replaces the prompt. Two sources of truth that could disagree about "did this come from a chip" would be worse than one, so they share a lifecycle. Invariant, checkable in the data: `starter_prompt_id` is non-null exactly when `input_method === 'suggestion'`. - **Reporting is gated on the caller identifying a prompt.** `insert()` without an attribution still inserts and is still recorded as `suggestion`, but reports no click — so a future affordance that reuses `insert()` cannot inflate the starter-prompt counts. - **A sixth prompt with no id reports `unregistered`** rather than borrowing its neighbour's identity, and `starterPrompts.test.ts` fails with a comment telling you to add the id. Graceful in data, loud in CI. - **The last chip clicked owns the send**, because inserting appends and a send is one message. `draft_was_empty: false` is how the mixed case is found rather than assumed away. `pnpm vitest run src/workbench/extensions/agent src/platform/telemetry` — 177 files, 2918 passing. New coverage, one case per branch: - `utils/starterPrompts.test.ts` — id table length matches the locale array; out-of-table slot → `unregistered`; id survives a copy change while the hash does not; hash shape and determinism. - `components/agent/EmptyState.test.ts` — table-driven over all five chips (slot id and index); nothing emitted before a click; two clicks are two events; the payload carries the hash and **not** the text. - `composables/agent/useComposer.test.ts` — one click event per identified insert, with the click id the send will carry; second click reports `draft_was_empty: false`; unidentified insert reports nothing and leaves no stale attribution. - `stores/agent/agentComposerStore.test.ts` — chip survives a reword, cleared at submission, restored for a failed retry, dropped by the edit action. - `composables/agent/useAgentDraftSubmission.test.ts` — the chip reaches `SubmissionMeta`, is not carried into the next send, and is restored for the retry with a fresh `clientMessageId`. - `AgentPanelRoot.test.ts` — the full chain end to end: the click event's `click_id` is the send event's `starter_prompt_click_id`. - Registry / PostHog / host-sink conformance cases for the new event. Not on merge. Production serves a pinned frontend SHA (`08abb06e41` as of 2026-09-26, with `canary.enabled: false`), and `app:agent_message_sent`'s existing `input_method` is a live example of the gap: it is in `main`, absent from the served build, and has **0 events on `cloud.comfy.org`** against 103 on `agent.comfy.org` in 30 days. This event needs merge → `cloud/1.54` backport → pin bump → argocd sync before a production user can emit it. Any query on it must split by `$host`.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2121 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-29T23:44:03.293Z",
"gitSha": "a0aebdfbe962bd3555cd15d222b7e1710b0ff232",
"branch": "backport-18991-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1992.8739999999152,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.496,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.95199999999994,
"heapDeltaBytes": 10087840,
"heapUsedBytes": 77532612,
"domNodes": -257,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.431999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2001.5460000000758,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.186000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.33,
"heapDeltaBytes": -8531128,
"heapUsedBytes": 58196036,
"domNodes": -256,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.408,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.925000000012,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.957,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.487,
"heapDeltaBytes": -6285420,
"heapUsedBytes": 61308572,
"domNodes": -259,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 109.237,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1702.2100000000364,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.69,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 599.496,
"heapDeltaBytes": -8916172,
"heapUsedBytes": 58914252,
"domNodes": -258,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 100.57,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.679999999992,
"styleRecalcs": 32,
"styleRecalcDurationMs": 12.350000000000001,
"layouts": 6,
"layoutDurationMs": 0.7859999999999999,
"taskDurationMs": 255.01600000000002,
"heapDeltaBytes": 3044996,
"heapUsedBytes": 70536064,
"domNodes": 80,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.377,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1702.6919999999564,
"styleRecalcs": 29,
"styleRecalcDurationMs": 11.460999999999999,
"layouts": 6,
"layoutDurationMs": 0.8190000000000001,
"taskDurationMs": 250.09799999999998,
"heapDeltaBytes": 3040424,
"heapUsedBytes": 70807712,
"domNodes": 80,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.279,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 466.49600000000646,
"styleRecalcs": 14,
"styleRecalcDurationMs": 6.328,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 287.617,
"heapDeltaBytes": 18690260,
"heapUsedBytes": 86563352,
"domNodes": 23,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 112.09700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 516.1070000000336,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.4719999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 314.973,
"heapDeltaBytes": 18580076,
"heapUsedBytes": 86244372,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 116.15000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1030.2750000000742,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 671.22,
"heapDeltaBytes": -13126260,
"heapUsedBytes": 73187752,
"domNodes": -292,
"jsHeapTotalBytes": 19267584,
"scriptDurationMs": 42.424,
"eventListeners": -217,
"totalBlockingTimeMs": 381,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1036.976999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 677.0959999999999,
"heapDeltaBytes": -17137832,
"heapUsedBytes": 72937676,
"domNodes": -291,
"jsHeapTotalBytes": 21889024,
"scriptDurationMs": 44.16300000000001,
"eventListeners": -217,
"totalBlockingTimeMs": 387,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 715.7139999999345,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 306.82700000000017,
"heapDeltaBytes": 13686488,
"heapUsedBytes": 88520704,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 93.47400000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 109,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 700.4839999999604,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 300.22899999999987,
"heapDeltaBytes": 13979016,
"heapUsedBytes": 90376088,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 89.086,
"eventListeners": 0,
"totalBlockingTimeMs": 107,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6533.758000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5448.276,
"heapDeltaBytes": -9172092,
"heapUsedBytes": 72592812,
"domNodes": -20,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 4461.062999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 53,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6279.5679999999265,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.5889999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5358.548,
"heapDeltaBytes": -12868908,
"heapUsedBytes": 68647860,
"domNodes": -16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 4176.366000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 49,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6111.482999999907,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.8710000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5166.975,
"heapDeltaBytes": 7542792,
"heapUsedBytes": 85332484,
"domNodes": -262,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 4029.399,
"eventListeners": -174,
"totalBlockingTimeMs": 23,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.20000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6166.047000000049,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.0340000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5351.104,
"heapDeltaBytes": 1489708,
"heapUsedBytes": 80005572,
"domNodes": -258,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 4214.5,
"eventListeners": -174,
"totalBlockingTimeMs": 23,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "large-graph-idle",
"durationMs": 2024.6720000000096,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.088000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.302,
"heapDeltaBytes": 4992,
"heapUsedBytes": 80335516,
"domNodes": -237,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 25.169999999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2025.8999999999787,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.189000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.4180000000001,
"heapDeltaBytes": -5902780,
"heapUsedBytes": 81607128,
"domNodes": -237,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 23.472,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2138.3670000000166,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.503999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1171.61,
"heapDeltaBytes": -12879716,
"heapUsedBytes": 75320012,
"domNodes": -238,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 561.7800000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2114.887999999951,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.292000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1160.871,
"heapDeltaBytes": -14538384,
"heapUsedBytes": 67374304,
"domNodes": -247,
"jsHeapTotalBytes": 815104,
"scriptDurationMs": 555.0849999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3059.6990000000233,
"styleRecalcs": 66,
"styleRecalcDurationMs": 9.206,
"layouts": 60,
"layoutDurationMs": 8.154,
"taskDurationMs": 1184.0420000000001,
"heapDeltaBytes": 10620560,
"heapUsedBytes": 74287360,
"domNodes": -244,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 511.89799999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3101.9059999999854,
"styleRecalcs": 66,
"styleRecalcDurationMs": 9.552000000000001,
"layouts": 60,
"layoutDurationMs": 8.34,
"taskDurationMs": 1228.48,
"heapDeltaBytes": -14776840,
"heapUsedBytes": 75287860,
"domNodes": -240,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 529.9979999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2194.389000000001,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.962999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1344.3799999999999,
"heapDeltaBytes": -21483084,
"heapUsedBytes": 70166476,
"domNodes": -213,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 633.5939999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2198.024000000032,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.747000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1305.3870000000002,
"heapDeltaBytes": 18360384,
"heapUsedBytes": 82679336,
"domNodes": -244,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 624.7230000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2036.2710000000561,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.236999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.90599999999995,
"heapDeltaBytes": -6419896,
"heapUsedBytes": 82508692,
"domNodes": -234,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 20.706000000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2009.8169999999982,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.404999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.078,
"heapDeltaBytes": -5005764,
"heapUsedBytes": 84584884,
"domNodes": -236,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 17.940000000000005,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 445.87799999999334,
"styleRecalcs": 49,
"styleRecalcDurationMs": 7.993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 286.40900000000005,
"heapDeltaBytes": 13398880,
"heapUsedBytes": 83565004,
"domNodes": 23,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 97.691,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 448.0740000000196,
"styleRecalcs": 49,
"styleRecalcDurationMs": 8.024999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 293.152,
"heapDeltaBytes": 14067008,
"heapUsedBytes": 83840980,
"domNodes": 23,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 100.67000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1993.2390000000169,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.58899999999994,
"heapDeltaBytes": -4117896,
"heapUsedBytes": 65905536,
"domNodes": -274,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 5.524999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2010.707000000025,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.883,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.85799999999995,
"heapDeltaBytes": -1217996,
"heapUsedBytes": 68696112,
"domNodes": -274,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 5.895,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.6480000000665,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.885000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.3670000000001,
"heapDeltaBytes": -9502124,
"heapUsedBytes": 60562644,
"domNodes": -274,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 62.949000000000005,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.0569999999343,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.887,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.7539999999999,
"heapDeltaBytes": -9267144,
"heapUsedBytes": 60080340,
"domNodes": -270,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 65.606,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 832.5779999998986,
"styleRecalcs": 18,
"styleRecalcDurationMs": 19.837,
"layouts": 5,
"layoutDurationMs": 8.100000000000001,
"taskDurationMs": 644.19,
"heapDeltaBytes": -8156460,
"heapUsedBytes": 81958384,
"domNodes": 13667,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 17.192,
"eventListeners": 2383,
"totalBlockingTimeMs": 98,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8139.746999999943,
"styleRecalcs": 251,
"styleRecalcDurationMs": 25.177000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3940.5979999999995,
"heapDeltaBytes": -21194384,
"heapUsedBytes": 66436316,
"domNodes": -245,
"jsHeapTotalBytes": 4747264,
"scriptDurationMs": 1801.1889999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8123.442999999952,
"styleRecalcs": 250,
"styleRecalcDurationMs": 21.425000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3943.581,
"heapDeltaBytes": 12360228,
"heapUsedBytes": 75951488,
"domNodes": -236,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 1800.149,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10545.507000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9951.920000000002,
"heapDeltaBytes": -52957484,
"heapUsedBytes": 186788320,
"domNodes": -8062,
"jsHeapTotalBytes": -11513856,
"scriptDurationMs": 102.88899999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 10551.0119999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9901.927,
"heapDeltaBytes": -23969308,
"heapUsedBytes": 189062716,
"domNodes": -8062,
"jsHeapTotalBytes": -12566528,
"scriptDurationMs": 102.02099999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 12785.570000000007,
"styleRecalcs": 67,
"styleRecalcDurationMs": 7.651999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12167.163000000002,
"heapDeltaBytes": -53565052,
"heapUsedBytes": 166784700,
"domNodes": -8062,
"jsHeapTotalBytes": -19988480,
"scriptDurationMs": 584.4540000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 34,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 12758.593000000019,
"styleRecalcs": 66,
"styleRecalcDurationMs": 7.69499999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12100.127999999999,
"heapDeltaBytes": -41354040,
"heapUsedBytes": 184658456,
"domNodes": -8062,
"jsHeapTotalBytes": -20787200,
"scriptDurationMs": 568.498,
"eventListeners": -14928,
"totalBlockingTimeMs": 40,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3853.4179999999196,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.199,
"layouts": 20,
"layoutDurationMs": 14.834,
"taskDurationMs": 3671.1709999999994,
"heapDeltaBytes": -16021984,
"heapUsedBytes": 202641676,
"domNodes": -8062,
"jsHeapTotalBytes": 14934016,
"scriptDurationMs": 50.626,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 3847.0099999999547,
"styleRecalcs": 20,
"styleRecalcDurationMs": 55.336,
"layouts": 20,
"layoutDurationMs": 15.292,
"taskDurationMs": 3636.113,
"heapDeltaBytes": -44082264,
"heapUsedBytes": 176611948,
"domNodes": -8065,
"jsHeapTotalBytes": 7274496,
"scriptDurationMs": 80.821,
"eventListeners": -14928,
"totalBlockingTimeMs": 1,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 4149.303000000032,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.0690000000000135,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3661.2209999999995,
"heapDeltaBytes": -2794172,
"heapUsedBytes": 170746736,
"domNodes": 0,
"jsHeapTotalBytes": -20185088,
"scriptDurationMs": 43.97899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5293.130000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4974.86,
"heapDeltaBytes": -6753576,
"heapUsedBytes": 182788828,
"domNodes": 0,
"jsHeapTotalBytes": -17301504,
"scriptDurationMs": 54.98999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 87.36599999997452,
"styleRecalcs": 8,
"styleRecalcDurationMs": 11.090000000000002,
"layouts": 3,
"layoutDurationMs": 1.088,
"taskDurationMs": 62.347,
"heapDeltaBytes": 3071028,
"heapUsedBytes": 68363620,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.875999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 55.8730000000196,
"styleRecalcs": 4,
"styleRecalcDurationMs": 6.242999999999999,
"layouts": 2,
"layoutDurationMs": 0.748,
"taskDurationMs": 41.59,
"heapDeltaBytes": 3004080,
"heapUsedBytes": 68829476,
"domNodes": 120,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 3.9060000000000015,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.55 #19489 +/- ##
=============================================
- Coverage 84.69% 84.68% -0.01%
=============================================
Files 2323 2324 +1
Lines 132657 132696 +39
Branches 35468 33588 -1880
=============================================
+ Hits 112356 112380 +24
- Misses 19941 19956 +15
Partials 360 360
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
… local (#19283) (#19569) ## Summary Backports #19283 to `core/1.55`. - ships the approved five-prompt distributions for Cloud and local/Desktop - preserves the stable telemetry slot IDs introduced by #18991 - retains core/1.55-specific test structure while carrying the source feature and focused coverage ## Conflict resolution The release branch already contains the manually backported #18991 implementation, but its test scaffolding differs from `main`. Conflicted test-only hunks were resolved against the release line, then the slot-ID assertions needed by this feature were applied directly. Production prompt selection, copy, localization, and telemetry types are preserved from the source PR. ## Verification - `pnpm typecheck:app` - focused Vitest: 7 files, 270 tests passed - pre-push `knip --cache` - `git diff --check` ## Source - Source PR: #19283 - Dependency/backport context: #19489 Co-authored-by: jojodecayz <121620462+jojodecayz@users.noreply.github.com> Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
Backports #18991 to
core/1.55.This preserves the release branch APIs while adding stable starter-prompt IDs, click telemetry, and click-to-send attribution (including retry restoration). The release branch predates some mainline composer plumbing, so the attribution lifecycle is adapted directly rather than importing unrelated newer panel code.
Verification:
pnpm vitest run src/workbench/extensions/agent/composables/agent/useComposer.test.ts src/workbench/extensions/agent/utils/starterPrompts.test.ts src/platform/telemetry/TelemetryRegistry.test.ts src/platform/telemetry/providers/cloud/PostHogTelemetryProvider.test.ts src/platform/telemetry/providers/host/HostTelemetrySink.test.ts(153 passed)pnpm typecheck(passed)knip --cache(passed)