Repository navigation
[backport core/1.54] feat(agent): record every consent request outcome - #19470
Conversation
Replaces automatically closed stacked PR #18992 after parent #18978 merged. Reconstructed root-first as the same two PR-owned commits on current `main`. Tracks every ending of a consent request and every outcome of a shown consent card. Preserves the test-only allowlist fixture repair. Validation: focused unit denominator 3 files / 168 tests passed; pre-push Knip and changed-file Fallow passed. No exposure or feature flags changed.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1957 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-29T22:31:54.202Z",
"gitSha": "97c9106063adfe74ea81d71d85d8cad4b1745a99",
"branch": "backport-19430-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2061.982999999998,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.808000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.639,
"heapDeltaBytes": -2756296,
"heapUsedBytes": 66794872,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.329000000000004,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2055.355000000077,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.991999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.496,
"heapDeltaBytes": -3531160,
"heapUsedBytes": 66906888,
"domNodes": -277,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 9.517999999999999,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1941.5539999999964,
"styleRecalcs": 77,
"styleRecalcDurationMs": 32.39,
"layouts": 14,
"layoutDurationMs": 4.228,
"taskDurationMs": 956.912,
"heapDeltaBytes": 5975624,
"heapUsedBytes": 77175412,
"domNodes": -279,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 169.066,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1880.2939999999353,
"styleRecalcs": 77,
"styleRecalcDurationMs": 31.854,
"layouts": 14,
"layoutDurationMs": 4.1850000000000005,
"taskDurationMs": 922.166,
"heapDeltaBytes": 4590012,
"heapUsedBytes": 75638388,
"domNodes": -278,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 171.18,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.6949999999638,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.637,
"layouts": 6,
"layoutDurationMs": 1.075,
"taskDurationMs": 376.60400000000004,
"heapDeltaBytes": 4345668,
"heapUsedBytes": 74439200,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.219000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.1439999999475,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.140000000000004,
"layouts": 6,
"layoutDurationMs": 1.2500000000000002,
"taskDurationMs": 362.39700000000005,
"heapDeltaBytes": 4284256,
"heapUsedBytes": 74627576,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.091,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 710.3629999999725,
"styleRecalcs": 13,
"styleRecalcDurationMs": 10.314,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.18899999999996,
"heapDeltaBytes": -7555368,
"heapUsedBytes": 63178596,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 167.032,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 693.1369999999788,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.496999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.68300000000005,
"heapDeltaBytes": 18426760,
"heapUsedBytes": 88600676,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 170.989,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2072.572999999977,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.710000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 661.3199999999999,
"heapDeltaBytes": 7115976,
"heapUsedBytes": 83838676,
"domNodes": -279,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 36.53200000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2026.1089999999058,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.770999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 599.746,
"heapDeltaBytes": -16359796,
"heapUsedBytes": 87562368,
"domNodes": -269,
"jsHeapTotalBytes": -1376256,
"scriptDurationMs": 32.412,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2375.715000000014,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.813999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1679.068,
"heapDeltaBytes": 7645284,
"heapUsedBytes": 85117172,
"domNodes": -275,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 826.363,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2481.6829999999754,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.590000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1787.4430000000002,
"heapDeltaBytes": 11981260,
"heapUsedBytes": 89312312,
"domNodes": -277,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 872.52,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3611.7740000000254,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.848000000000003,
"layouts": 60,
"layoutDurationMs": 11.885,
"taskDurationMs": 1735.7160000000003,
"heapDeltaBytes": 8496736,
"heapUsedBytes": 76838968,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 785.4259999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3609.354000000053,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.011999999999997,
"layouts": 60,
"layoutDurationMs": 12.006999999999998,
"taskDurationMs": 1743.916,
"heapDeltaBytes": 8184720,
"heapUsedBytes": 76556288,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 786.6419999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3091.8420000000424,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.9399999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1981.4969999999998,
"heapDeltaBytes": 23028420,
"heapUsedBytes": 91083876,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1006.172,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3168.9179999999624,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.667000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1999.5400000000002,
"heapDeltaBytes": 21809280,
"heapUsedBytes": 90202004,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 985.8730000000002,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2060.7650000000035,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.453999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 644.8950000000001,
"heapDeltaBytes": 5610100,
"heapUsedBytes": 82910168,
"domNodes": -280,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 35.321000000000005,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2035.4399999999941,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.133999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 596.754,
"heapDeltaBytes": 9228648,
"heapUsedBytes": 87766056,
"domNodes": -271,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 34.087,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 594.2059999999856,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.824999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.164,
"heapDeltaBytes": 14751872,
"heapUsedBytes": 88220696,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 146.009,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 625.9560000000874,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.827000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.171,
"heapDeltaBytes": 14663392,
"heapUsedBytes": 87911704,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 145.898,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2028.7739999999985,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.740999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.9469999999999,
"heapDeltaBytes": -14554416,
"heapUsedBytes": 58642544,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.525000000000002,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.975999999995,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.527999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.9870000000001,
"heapDeltaBytes": -3652328,
"heapUsedBytes": 69778032,
"domNodes": -297,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 8.282000000000002,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1769.6429999999737,
"styleRecalcs": 78,
"styleRecalcDurationMs": 30.025000000000002,
"layouts": 18,
"layoutDurationMs": 5.084,
"taskDurationMs": 879.4789999999999,
"heapDeltaBytes": -1462176,
"heapUsedBytes": 71783608,
"domNodes": -293,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 114.67999999999999,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1755.8950000000095,
"styleRecalcs": 79,
"styleRecalcDurationMs": 28.449,
"layouts": 18,
"layoutDurationMs": 5.064,
"taskDurationMs": 845.4620000000001,
"heapDeltaBytes": -7987624,
"heapUsedBytes": 65342088,
"domNodes": -294,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 114.477,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.3060000000337,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.57899999999999,
"layouts": 15,
"layoutDurationMs": 15.337999999999997,
"taskDurationMs": 978.011,
"heapDeltaBytes": 21732472,
"heapUsedBytes": 107263356,
"domNodes": 13831,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 35.873999999999995,
"eventListeners": 2385,
"totalBlockingTimeMs": 146,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8698.397999999997,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.83399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6052.901999999999,
"heapDeltaBytes": 4753660,
"heapUsedBytes": 80943764,
"domNodes": -268,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 2782.692,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8934.403999999973,
"styleRecalcs": 246,
"styleRecalcDurationMs": 38.236000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6182.914000000001,
"heapDeltaBytes": -11178444,
"heapUsedBytes": 91827456,
"domNodes": -271,
"jsHeapTotalBytes": 421888,
"scriptDurationMs": 2928.771,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17625.068999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16952.596,
"heapDeltaBytes": -35816644,
"heapUsedBytes": 182437280,
"domNodes": -8068,
"jsHeapTotalBytes": -10235904,
"scriptDurationMs": 290.959,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17449.331000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16851.748,
"heapDeltaBytes": -38893396,
"heapUsedBytes": 179241804,
"domNodes": -8068,
"jsHeapTotalBytes": -7659520,
"scriptDurationMs": 287.41,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21721.895999999957,
"styleRecalcs": 165,
"styleRecalcDurationMs": 20.19800000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21461.036,
"heapDeltaBytes": -42790704,
"heapUsedBytes": 183369116,
"domNodes": -8068,
"jsHeapTotalBytes": -16650240,
"scriptDurationMs": 937.0129999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 56,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21907.29699999997,
"styleRecalcs": 171,
"styleRecalcDurationMs": 21.13799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21546.175000000003,
"heapDeltaBytes": -42766448,
"heapUsedBytes": 169809768,
"domNodes": -8068,
"jsHeapTotalBytes": -10498048,
"scriptDurationMs": 1013.0940000000002,
"eventListeners": -14925,
"totalBlockingTimeMs": 100,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6302.982999999984,
"styleRecalcs": 20,
"styleRecalcDurationMs": 99.624,
"layouts": 20,
"layoutDurationMs": 31.155999999999988,
"taskDurationMs": 6221.610000000001,
"heapDeltaBytes": -55083048,
"heapUsedBytes": 178029488,
"domNodes": -8101,
"jsHeapTotalBytes": 4542464,
"scriptDurationMs": 111.814,
"eventListeners": -14929,
"totalBlockingTimeMs": 591,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6314.25200000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 88.39999999999998,
"layouts": 20,
"layoutDurationMs": 25.581999999999994,
"taskDurationMs": 6222.710999999999,
"heapDeltaBytes": -36159372,
"heapUsedBytes": 183041800,
"domNodes": -8068,
"jsHeapTotalBytes": 16982016,
"scriptDurationMs": 125.01899999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 500,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8891.975000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8515.904,
"heapDeltaBytes": 19633384,
"heapUsedBytes": 177541240,
"domNodes": 0,
"jsHeapTotalBytes": -12845056,
"scriptDurationMs": 187.01199999999994,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8983.571999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8518.884000000002,
"heapDeltaBytes": 11935812,
"heapUsedBytes": 179460832,
"domNodes": 0,
"jsHeapTotalBytes": -26476544,
"scriptDurationMs": 149.89200000000002,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 116.49399999998877,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.027000000000001,
"layouts": 2,
"layoutDurationMs": 0.628,
"taskDurationMs": 83.52699999999999,
"heapDeltaBytes": 3109856,
"heapUsedBytes": 72013692,
"domNodes": 109,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 110.89900000001762,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.415,
"layouts": 2,
"layoutDurationMs": 1.2270000000000003,
"taskDurationMs": 71.017,
"heapDeltaBytes": 3019264,
"heapUsedBytes": 72461096,
"domNodes": 108,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.304000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.54 #19470 +/- ##
============================================
Coverage 83.90% 83.90%
============================================
Files 2109 2109
Lines 125925 125973 +48
Branches 31963 33837 +1874
============================================
+ Hits 105662 105703 +41
- Misses 20084 20091 +7
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
…d sends (#18991) (#19490) ## Summary Backports #18991 so core 1.54 records each starter-prompt click and attributes the resulting message send to the same click. ## Changes - **What**: Adds stable prompt IDs, copy hashes, per-click IDs, click telemetry, and send attribution with focused unit coverage. - **Dependencies**: `core/1.54` did not contain #18908 (the 1.54 activation-funnel telemetry substrate already present on `cloud/1.54`), so this backport includes that prerequisite while preserving the newer consent-outcome telemetry from #19470. ## Review Focus Confirm the activation-funnel prerequisite is appropriate for core 1.54 and the target-specific `sendMessage` integration preserves the four-argument core API. ## Verification - `pnpm vitest run` on the eight focused starter-prompt, composer-store, submission, registry, PostHog, and host-sink suites: 203 passed - Focused `AgentPanelRoot` click-to-send chain: 1 passed - `pnpm typecheck`: passed - Pre-commit lint, format, style, and typecheck hooks: passed - Pre-push `knip`: passed --------- Co-authored-by: Hunter <huntcsg@users.noreply.github.com>
Backports #19430 to
core/1.54from merge commita3a4a0b8a692ed738e9ceb5c23da0784739ce7c4.The release branch predates the explicit consent-trigger and telemetry routing APIs. This adaptation preserves its callback-first
withConsent(onAccept, hooks)contract, derivesfirst_loadonly from the existing automatic-offer hooks, and adds only the consent shown/resolved/request-exit telemetry required by #19430. It does not import later onboarding or message-attribution APIs.Validation:
--testTimeout=30000The target branch does not contain the newer offline browser runner. A direct Playwright attempt reached the configured external server and all four cases stopped in fixture setup with HTTP 405 before exercising product behavior; hosted CI remains the browser runtime gate.
Source: #19430