Repository navigation
[backport core/1.54] feat(agent): instrument starter-prompt clicks and sends (#18991) - #19490
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
…funnel (PM-1474) (#18503) (#18908) Backport of #18503 to `cloud/1.54`. The automated `comfy-pr-bot` cherry-pick failed with conflicts and deleted its branch, so this backport was done by hand. `git cherry-pick 2e664f6` conflicted in four files. `cloud/1.54` already carries a different, separately-backported set of agent telemetry handlers (implemented in `PostHogTelemetryProvider.ts` but only partially in `HostTelemetrySink.ts`), so the conflicts were additive/adjacent rather than semantic. Resolved by keeping only what #18503 itself introduces on top of `cloud/1.54`'s existing state (verified line-by-line against the commit's actual diff, not just against what the 3-way merge showed as "theirs"): - `src/extensions/core/agentPanel.test.ts` — union: kept `cloud/1.54`'s existing `import type { LGraphNode }`, added `#18503`'s new `AgentConsentTrigger` type import and threaded `_trigger` through the `withConsent` mock signature. Dropped `useExtensionService`, `PostHog`, a duplicate value-style `LGraphNode` import, and `createTestSubgraph` that appeared in the conflict hunk as merge context from `main` but were unused and not part of #18503's actual diff. - `src/platform/telemetry/providers/host/HostTelemetrySink.ts` — union: added only the four trackers #18503 introduces (`trackAgentConsentShown`, `trackAgentConsentResolved`, `trackAgentOnboardingShown`, `trackAgentOnboardingStep`) and their three new type imports, alongside `cloud/1.54`'s existing `trackAgentConsentNotOffered`/`trackAgentOnboardingNotShown`. Excluded `trackAgentMessageFeedback`, `trackAgentPanelOpened/Closed`, `trackAgentEntryButtonClicked`, `trackAgentCloseButtonClicked`, `trackAgentMessageSent`, `trackAgentNodeTagged`, `trackAgentAttachButtonClicked`, and `trackAgentWorkflowApplied` — those belong to the still-unmerged `cloud/1.54` backport of #18376 ("forward agent telemetry to desktop host"), not to #18503; pulling them in here would have been scope creep from an unrelated PR. - `src/platform/telemetry/providers/host/HostTelemetrySink.test.ts` — same reasoning: added only the four new `it.for` cases for the trackers above; excluded the modified/new `trackAgentMessageSent` cases and the `AGENT_NODE_TAGGED`/`AGENT_ATTACH_BUTTON_CLICKED`/`AGENT_WORKFLOW_APPLIED` cases, since those trackers aren't implemented in this file on `cloud/1.54`. - `src/workbench/extensions/agent/AgentPanelRoot.test.ts` — union: kept `cloud/1.54`'s existing `vi.mock<unknown>(import('@/platform/distribution/types'), ...)` and added #18503's new `uuid`/`nextClientMessageId` mock ahead of it, plus the `clientMessageIds` counter reset in `beforeEach`. The `useCurrentUser()...` reassignment lines shown in the conflict were merge context from `main`'s different (auto-mocked) `useCurrentUser` pattern, not part of #18503's diff, so they were left out; adding them without the matching import would have broken the build. Also added the four new tracker names (`trackAgentConsentShown/Resolved/OnboardingShown/OnboardingStep`) to this file's hand-rolled `telemetry` mock object so the real `useAgentConsent`/`OnboardingCoach` code exercised by these tests doesn't call `undefined` — `cloud/1.54` mocks telemetry with an explicit method list rather than `main`'s auto-mock, so this list needs to track new trackers a component calls. Verified every one of the 23 touched files' diff against `origin/cloud/1.54` matches the original commit's diff exactly (no more, no less) before finalizing. > Merge order: the `cloud/1.54` backport of #18376 should land before this one; both touch the same region of `HostTelemetrySink.ts` and this branch will need a rebase afterwards. The backport of #18665 should land after this one.
… they produce (#18991) The five empty-state starter prompts are the cheapest lever on the first-run path and nothing measures them. `input_method: 'suggestion'` on `app:agent_message_sent` already says a chip was used; it cannot say **which** chip, and nothing at all counts a chip that was clicked and never sent. So "is prompt 3 the one that activates people?" is unanswerable, and any experiment on the prompt set would be unreadable. **New: `app:agent_starter_prompt_clicked`** — one event per click, never on render, hover or focus. | property | why it is there | |---|---| | `prompt_id` | The chip's **slot**, from a frozen table (`starterPrompts.ts`), not its display text — the copy is owned by product and is changing | | `prompt_index`, `prompt_count` | A reordered or resized set is visible instead of silently re-labelling slots | | `prompt_text_hash` | FNV-1a, 8 hex, of the displayed text. Without it a copy change under a stable `prompt_id` is indistinguishable from the slot performing differently. Not the text, not reversible | | `locale` | The locale that produced the hash — a translation is a different hash of the same prompt | | `click_id` | Minted per click; the join key to the send | | `draft_was_empty` | Inserting **appends**, so `false` marks a submitted draft that is a mix of this chip and something else | **Extended: `app:agent_message_sent`** gains `starter_prompt_id` and `starter_prompt_click_id`, so click → send → turn is one chain instead of three unrelated counts. Both are `null` for a typed message, which is the other arm of the question. No copy change, no change to the prompt set, no change to submission semantics, no flag or config touched. The click still inserts and still does not send (`browser_tests/tests/agent/agentPanel.spec.ts` covers that and is untouched). - **Attribution lives and dies with `promptOrigin`**: held with the submission snapshot, cleared at `startSubmission`, restored by `takeFailedSubmission` so a retry is still that chip's message, dropped when the conversation's edit action replaces the prompt. Two sources of truth that could disagree about "did this come from a chip" would be worse than one, so they share a lifecycle. Invariant, checkable in the data: `starter_prompt_id` is non-null exactly when `input_method === 'suggestion'`. - **Reporting is gated on the caller identifying a prompt.** `insert()` without an attribution still inserts and is still recorded as `suggestion`, but reports no click — so a future affordance that reuses `insert()` cannot inflate the starter-prompt counts. - **A sixth prompt with no id reports `unregistered`** rather than borrowing its neighbour's identity, and `starterPrompts.test.ts` fails with a comment telling you to add the id. Graceful in data, loud in CI. - **The last chip clicked owns the send**, because inserting appends and a send is one message. `draft_was_empty: false` is how the mixed case is found rather than assumed away. `pnpm vitest run src/workbench/extensions/agent src/platform/telemetry` — 177 files, 2918 passing. New coverage, one case per branch: - `utils/starterPrompts.test.ts` — id table length matches the locale array; out-of-table slot → `unregistered`; id survives a copy change while the hash does not; hash shape and determinism. - `components/agent/EmptyState.test.ts` — table-driven over all five chips (slot id and index); nothing emitted before a click; two clicks are two events; the payload carries the hash and **not** the text. - `composables/agent/useComposer.test.ts` — one click event per identified insert, with the click id the send will carry; second click reports `draft_was_empty: false`; unidentified insert reports nothing and leaves no stale attribution. - `stores/agent/agentComposerStore.test.ts` — chip survives a reword, cleared at submission, restored for a failed retry, dropped by the edit action. - `composables/agent/useAgentDraftSubmission.test.ts` — the chip reaches `SubmissionMeta`, is not carried into the next send, and is restored for the retry with a fresh `clientMessageId`. - `AgentPanelRoot.test.ts` — the full chain end to end: the click event's `click_id` is the send event's `starter_prompt_click_id`. - Registry / PostHog / host-sink conformance cases for the new event. Not on merge. Production serves a pinned frontend SHA (`08abb06e41` as of 2026-09-26, with `canary.enabled: false`), and `app:agent_message_sent`'s existing `input_method` is a live example of the gap: it is in `main`, absent from the served build, and has **0 events on `cloud.comfy.org`** against 103 on `agent.comfy.org` in 30 days. This event needs merge → `cloud/1.54` backport → pin bump → argocd sync before a production user can emit it. Any query on it must split by `$host`.
7cc53bd to
a3630a2
Compare
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1959 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-29T23:19:29.945Z",
"gitSha": "ac3adeb4572c8db576ff7d77a4c80f0407b123b1",
"branch": "backport-18991-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2112.047000000018,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.764,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 651.375,
"heapDeltaBytes": -529352,
"heapUsedBytes": 69900680,
"domNodes": -279,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 12.377000000000002,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2052.314000000024,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.642999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 593.49,
"heapDeltaBytes": -11162016,
"heapUsedBytes": 59778876,
"domNodes": -284,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 13.432999999999996,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1903.336999999965,
"styleRecalcs": 76,
"styleRecalcDurationMs": 31.265,
"layouts": 14,
"layoutDurationMs": 4.348,
"taskDurationMs": 928.5079999999999,
"heapDeltaBytes": -6781088,
"heapUsedBytes": 63285868,
"domNodes": -281,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 164.492,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1969.4559999999797,
"styleRecalcs": 78,
"styleRecalcDurationMs": 33.571,
"layouts": 14,
"layoutDurationMs": 4.41,
"taskDurationMs": 979.7929999999999,
"heapDeltaBytes": 9212464,
"heapUsedBytes": 80073912,
"domNodes": -280,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 174.487,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1754.9149999999827,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.164,
"layouts": 6,
"layoutDurationMs": 1.212,
"taskDurationMs": 434.851,
"heapDeltaBytes": 4635888,
"heapUsedBytes": 75674988,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 15.708000000000004,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.356000000067,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.308999999999997,
"layouts": 6,
"layoutDurationMs": 1.0299999999999998,
"taskDurationMs": 437.66299999999995,
"heapDeltaBytes": 4708580,
"heapUsedBytes": 75778964,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 16.369999999999997,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 683.6410000000228,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.385,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.405,
"heapDeltaBytes": -7564832,
"heapUsedBytes": 63364284,
"domNodes": 22,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 159.673,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 725.6439999999884,
"styleRecalcs": 13,
"styleRecalcDurationMs": 12.001000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.24100000000004,
"heapDeltaBytes": -7513332,
"heapUsedBytes": 63456484,
"domNodes": 22,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 179.18300000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2054.8949999999877,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.419999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 800.5870000000001,
"heapDeltaBytes": 5730264,
"heapUsedBytes": 81913896,
"domNodes": -281,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 41.163000000000004,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2061.9279999999662,
"styleRecalcs": 4,
"styleRecalcDurationMs": 6.509000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 752.232,
"heapDeltaBytes": 10739268,
"heapUsedBytes": 87464896,
"domNodes": -272,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 39.593,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2755.70799999997,
"styleRecalcs": 62,
"styleRecalcDurationMs": 8.544999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1807.89,
"heapDeltaBytes": 25059032,
"heapUsedBytes": 91699816,
"domNodes": 0,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 901.5519999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2938.9959999999746,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.323,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1873.7630000000001,
"heapDeltaBytes": 26915308,
"heapUsedBytes": 92935560,
"domNodes": -274,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 934.018,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3705.1399999999717,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.785,
"layouts": 60,
"layoutDurationMs": 12.893000000000002,
"taskDurationMs": 1851.2130000000002,
"heapDeltaBytes": 8487876,
"heapUsedBytes": 76173380,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 811.972,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4054.3760000000475,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.717,
"layouts": 60,
"layoutDurationMs": 12.981,
"taskDurationMs": 1960.595,
"heapDeltaBytes": 9093548,
"heapUsedBytes": 77225500,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 895.555,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3200.4440000000045,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.433999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2113.5480000000002,
"heapDeltaBytes": 4383968,
"heapUsedBytes": 86014584,
"domNodes": -285,
"jsHeapTotalBytes": 53248,
"scriptDurationMs": 1005.3879999999999,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3115.668000000028,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.658000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2069.5139999999997,
"heapDeltaBytes": 26429484,
"heapUsedBytes": 94732276,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1007.4290000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2037.0770000000107,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.7920000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 703.438,
"heapDeltaBytes": 10092928,
"heapUsedBytes": 86682892,
"domNodes": -272,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 43.523,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2038.7309999999843,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.7790000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 762.1390000000001,
"heapDeltaBytes": 9454756,
"heapUsedBytes": 88238912,
"domNodes": -272,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 39.251000000000005,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 652.8419999999642,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.912999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.67199999999997,
"heapDeltaBytes": 15087612,
"heapUsedBytes": 88260748,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 146.65399999999997,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 703.1499999999369,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.93300000000005,
"heapDeltaBytes": 15024996,
"heapUsedBytes": 88435936,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 148.08200000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2037.5980000000027,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.101000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 549.933,
"heapDeltaBytes": -5564460,
"heapUsedBytes": 67787476,
"domNodes": -298,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 11.278,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2035.0419999999758,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.577000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 594.278,
"heapDeltaBytes": -4476488,
"heapUsedBytes": 67798676,
"domNodes": -299,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.470999999999998,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.610999999968,
"styleRecalcs": 78,
"styleRecalcDurationMs": 29.040000000000003,
"layouts": 18,
"layoutDurationMs": 5.011999999999999,
"taskDurationMs": 886.459,
"heapDeltaBytes": -10272332,
"heapUsedBytes": 62293944,
"domNodes": -292,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 115.827,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.7800000000097,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.201999999999998,
"layouts": 18,
"layoutDurationMs": 5.319,
"taskDurationMs": 905.581,
"heapDeltaBytes": -2963692,
"heapUsedBytes": 70385024,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 124.409,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1416.780000000017,
"styleRecalcs": 17,
"styleRecalcDurationMs": 33.934,
"layouts": 13,
"layoutDurationMs": 16.316999999999997,
"taskDurationMs": 1039.0600000000002,
"heapDeltaBytes": -5030736,
"heapUsedBytes": 85301356,
"domNodes": 13831,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 34.342,
"eventListeners": 2387,
"totalBlockingTimeMs": 151,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9546.493999999995,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.666,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6454.9710000000005,
"heapDeltaBytes": 9673208,
"heapUsedBytes": 86199472,
"domNodes": -278,
"jsHeapTotalBytes": 876544,
"scriptDurationMs": 2896.2860000000005,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 11047.645999999986,
"styleRecalcs": 246,
"styleRecalcDurationMs": 39.48599999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6918.882999999999,
"heapDeltaBytes": -12024440,
"heapUsedBytes": 92045964,
"domNodes": -271,
"jsHeapTotalBytes": -659456,
"scriptDurationMs": 3159.038,
"eventListeners": -140,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666607,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18194.35599999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17576.15,
"heapDeltaBytes": -54583064,
"heapUsedBytes": 181138916,
"domNodes": -8068,
"jsHeapTotalBytes": -8155136,
"scriptDurationMs": 301.331,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18478.535999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18061.603,
"heapDeltaBytes": -53115248,
"heapUsedBytes": 165976152,
"domNodes": -8068,
"jsHeapTotalBytes": -10280960,
"scriptDurationMs": 343.5,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22473.95399999999,
"styleRecalcs": 170,
"styleRecalcDurationMs": 24.582999999999966,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22218.316,
"heapDeltaBytes": -48725048,
"heapUsedBytes": 184234812,
"domNodes": -8068,
"jsHeapTotalBytes": -18788352,
"scriptDurationMs": 1062.5149999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 180,
"frameDurationMs": 18.889999999999905,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22267.578999999954,
"styleRecalcs": 164,
"styleRecalcDurationMs": 22.428000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21930.95,
"heapDeltaBytes": -65840304,
"heapUsedBytes": 169245576,
"domNodes": -8068,
"jsHeapTotalBytes": -13012992,
"scriptDurationMs": 985.0050000000001,
"eventListeners": -14931,
"totalBlockingTimeMs": 78,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-node-resize-workload",
"durationMs": 6644.288000000017,
"styleRecalcs": 20,
"styleRecalcDurationMs": 86.48300000000003,
"layouts": 20,
"layoutDurationMs": 27.243000000000002,
"taskDurationMs": 6529.174999999999,
"heapDeltaBytes": -58696232,
"heapUsedBytes": 174822364,
"domNodes": -8068,
"jsHeapTotalBytes": 1896448,
"scriptDurationMs": 151.74200000000002,
"eventListeners": -14931,
"totalBlockingTimeMs": 467,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6292.0199999999795,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.40600000000003,
"layouts": 20,
"layoutDurationMs": 22.666999999999994,
"taskDurationMs": 6149.888000000001,
"heapDeltaBytes": -32876436,
"heapUsedBytes": 178319364,
"domNodes": -8068,
"jsHeapTotalBytes": 5730304,
"scriptDurationMs": 107.35100000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 439,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9261.719000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8911.298999999997,
"heapDeltaBytes": -6144500,
"heapUsedBytes": 182507684,
"domNodes": 0,
"jsHeapTotalBytes": -3145728,
"scriptDurationMs": 160.6949999999999,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8813.656999999921,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8478.569,
"heapDeltaBytes": 18647808,
"heapUsedBytes": 179222684,
"domNodes": 0,
"jsHeapTotalBytes": -14155776,
"scriptDurationMs": 141.227,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 459.6300000000042,
"styleRecalcs": 12,
"styleRecalcDurationMs": 18.09,
"layouts": 3,
"layoutDurationMs": 0.743,
"taskDurationMs": 105.61200000000001,
"heapDeltaBytes": 4782888,
"heapUsedBytes": 73927432,
"domNodes": 120,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.241000000000001,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 477.675999999974,
"styleRecalcs": 17,
"styleRecalcDurationMs": 24.000999999999998,
"layouts": 3,
"layoutDurationMs": 1.641,
"taskDurationMs": 116.06199999999998,
"heapDeltaBytes": 4885036,
"heapUsedBytes": 74397800,
"domNodes": 142,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.548000000000002,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #19490 +/- ##
=============================================
+ Coverage 83.90% 83.92% +0.01%
=============================================
Files 2109 2110 +1
Lines 125973 126054 +81
Branches 33837 33852 +15
=============================================
+ Hits 105695 105788 +93
+ Misses 20099 20087 -12
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Backports #18991 so core 1.54 records each starter-prompt click and attributes the resulting message send to the same click.
Changes
core/1.54did not contain [backport cloud/1.54] feat(telemetry): complete the agent activation funnel (PM-1474) (#18503) #18908 (the 1.54 activation-funnel telemetry substrate already present oncloud/1.54), so this backport includes that prerequisite while preserving the newer consent-outcome telemetry from [backport core/1.54] feat(agent): record every consent request outcome #19470.Review Focus
Confirm the activation-funnel prerequisite is appropriate for core 1.54 and the target-specific
sendMessageintegration preserves the four-argument core API.Verification
pnpm vitest runon the eight focused starter-prompt, composer-store, submission, registry, PostHog, and host-sink suites: 203 passedAgentPanelRootclick-to-send chain: 1 passedpnpm typecheck: passedknip: passed