Repository navigation
[backport cloud/1.54] feat(agent): record every consent request outcome (#19430) - #19469
Conversation
Replaces automatically closed stacked PR Comfy-Org#18992 after parent Comfy-Org#18978 merged. Reconstructed root-first as the same two PR-owned commits on current `main`. Tracks every ending of a consent request and every outcome of a shown consent card. Preserves the test-only allowlist fixture repair. Validation: focused unit denominator 3 files / 168 tests passed; pre-push Knip and changed-file Fallow passed. No exposure or feature flags changed.
|
@christian-byrne is attempting to deploy a commit to the ComfyUI Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ⏳ Running...📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-29T22:41:44.239Z",
"gitSha": "0d2730caa02b8c4dedcd0be266629829e613a9ba",
"branch": "backport-19430-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2115.9739999999942,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.14,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.8449999999999,
"heapDeltaBytes": 1854092,
"heapUsedBytes": 72318956,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 9.305000000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2055.3069999999707,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.838,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.99799999999993,
"heapDeltaBytes": -9512768,
"heapUsedBytes": 61581424,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.483999999999998,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2034.7550000000183,
"styleRecalcs": 76,
"styleRecalcDurationMs": 32.046,
"layouts": 14,
"layoutDurationMs": 4.629,
"taskDurationMs": 1007.984,
"heapDeltaBytes": 5723168,
"heapUsedBytes": 76741388,
"domNodes": -282,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 169.154,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1764.2080000000533,
"styleRecalcs": 73,
"styleRecalcDurationMs": 26.341000000000005,
"layouts": 14,
"layoutDurationMs": 3.4740000000000006,
"taskDurationMs": 852.441,
"heapDeltaBytes": 3774104,
"heapUsedBytes": 74817068,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 154.164,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.875000000035,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.524,
"layouts": 6,
"layoutDurationMs": 1.035,
"taskDurationMs": 345.306,
"heapDeltaBytes": 4574736,
"heapUsedBytes": 75941520,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.583000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.6569999999083,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.072999999999999,
"layouts": 6,
"layoutDurationMs": 0.936,
"taskDurationMs": 345.255,
"heapDeltaBytes": 4570316,
"heapUsedBytes": 75443404,
"domNodes": 72,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.494999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 637.8650000000334,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.227000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.75000000000006,
"heapDeltaBytes": -7108568,
"heapUsedBytes": 63500400,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 159.11,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 677.4730000000773,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.636000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.637,
"heapDeltaBytes": -7762760,
"heapUsedBytes": 63158788,
"domNodes": 20,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 167.195,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2028.663999999992,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.7809999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 570.7399999999999,
"heapDeltaBytes": 11260848,
"heapUsedBytes": 87459652,
"domNodes": -272,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 33.28,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2039.0339999999014,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.618000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.961,
"heapDeltaBytes": 10944584,
"heapUsedBytes": 87647428,
"domNodes": -275,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 31.155,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2324.4949999999562,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.99,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1710.419,
"heapDeltaBytes": 1113668,
"heapUsedBytes": 78862596,
"domNodes": -243,
"jsHeapTotalBytes": 1171456,
"scriptDurationMs": 836.5200000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2264.9959999999965,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.565,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1602.5040000000001,
"heapDeltaBytes": 23989060,
"heapUsedBytes": 90162472,
"domNodes": -279,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 808.845,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3652.06500000005,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.476999999999999,
"layouts": 60,
"layoutDurationMs": 11.720999999999998,
"taskDurationMs": 1745.3600000000004,
"heapDeltaBytes": 9423812,
"heapUsedBytes": 76728148,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 804.9699999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3503.951999999913,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.504000000000001,
"layouts": 60,
"layoutDurationMs": 11.434,
"taskDurationMs": 1677.979,
"heapDeltaBytes": 9918280,
"heapUsedBytes": 76993976,
"domNodes": -281,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 764.7270000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3127.431999999999,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.646999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1980.823,
"heapDeltaBytes": 7727156,
"heapUsedBytes": 88576572,
"domNodes": -253,
"jsHeapTotalBytes": 53248,
"scriptDurationMs": 967.4499999999999,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3088.084999999978,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.5520000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1919.3890000000001,
"heapDeltaBytes": 23097120,
"heapUsedBytes": 91447624,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 953.034,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.6469999999877,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.0669999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 562.6679999999999,
"heapDeltaBytes": 10394984,
"heapUsedBytes": 87913812,
"domNodes": -271,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 30.116000000000003,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2054.2480000000296,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.5680000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 622.985,
"heapDeltaBytes": 5457272,
"heapUsedBytes": 82847476,
"domNodes": -282,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 39.266999999999996,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 592.1670000000177,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.411999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.7029999999999,
"heapDeltaBytes": 14688644,
"heapUsedBytes": 81150988,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 140.91199999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 592.6249999999982,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.976999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.779,
"heapDeltaBytes": 14361652,
"heapUsedBytes": 86703132,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 143.30900000000003,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2033.8399999999979,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.835,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.721,
"heapDeltaBytes": -4388792,
"heapUsedBytes": 67595400,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.109000000000002,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.78599999993,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.177999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.58200000000005,
"heapDeltaBytes": -9146872,
"heapUsedBytes": 63481460,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 8.254000000000001,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1755.818999999974,
"styleRecalcs": 79,
"styleRecalcDurationMs": 28.453000000000003,
"layouts": 18,
"layoutDurationMs": 4.305,
"taskDurationMs": 801.668,
"heapDeltaBytes": 5161872,
"heapUsedBytes": 78588088,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 105.402,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1762.1669999999767,
"styleRecalcs": 76,
"styleRecalcDurationMs": 27.215000000000003,
"layouts": 18,
"layoutDurationMs": 4.6080000000000005,
"taskDurationMs": 826.97,
"heapDeltaBytes": -4914764,
"heapUsedBytes": 68701640,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 109.60900000000001,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.8660000000118,
"styleRecalcs": 18,
"styleRecalcDurationMs": 32.12,
"layouts": 14,
"layoutDurationMs": 15.027000000000003,
"taskDurationMs": 924.7999999999998,
"heapDeltaBytes": -6977672,
"heapUsedBytes": 85851688,
"domNodes": 13831,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 31.382,
"eventListeners": 2385,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8534.844000000021,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.097,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5801.198,
"heapDeltaBytes": 11213232,
"heapUsedBytes": 86865748,
"domNodes": -265,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 2653.3480000000004,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8452.891999999905,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.126,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5817.2,
"heapDeltaBytes": 14655768,
"heapUsedBytes": 91335940,
"domNodes": -284,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 2711.277,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16848.88599999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16442.809,
"heapDeltaBytes": -42388336,
"heapUsedBytes": 177038316,
"domNodes": -8068,
"jsHeapTotalBytes": -11284480,
"scriptDurationMs": 288.956,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17414.49399999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16801.063,
"heapDeltaBytes": -49338780,
"heapUsedBytes": 179181832,
"domNodes": -8068,
"jsHeapTotalBytes": -18309120,
"scriptDurationMs": 276.58799999999997,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20650.331999999937,
"styleRecalcs": 164,
"styleRecalcDurationMs": 17.008000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20302.503,
"heapDeltaBytes": -38768888,
"heapUsedBytes": 180276220,
"domNodes": -8068,
"jsHeapTotalBytes": -12017664,
"scriptDurationMs": 914.525,
"eventListeners": -14927,
"totalBlockingTimeMs": 10,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20850.915999999983,
"styleRecalcs": 159,
"styleRecalcDurationMs": 18.54800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20546.084,
"heapDeltaBytes": -25476864,
"heapUsedBytes": 194164868,
"domNodes": -8068,
"jsHeapTotalBytes": -13119488,
"scriptDurationMs": 952.293,
"eventListeners": -14927,
"totalBlockingTimeMs": 49,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6123.617000000081,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.13200000000003,
"layouts": 20,
"layoutDurationMs": 21.433000000000007,
"taskDurationMs": 6020.55,
"heapDeltaBytes": -35283348,
"heapUsedBytes": 183427244,
"domNodes": -8068,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 109.86500000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 373,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6224.8369999999795,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.54699999999998,
"layouts": 20,
"layoutDurationMs": 23.589,
"taskDurationMs": 6120.031000000001,
"heapDeltaBytes": -35191348,
"heapUsedBytes": 198029896,
"domNodes": -8068,
"jsHeapTotalBytes": 11595776,
"scriptDurationMs": 114.36999999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 520,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8489.912000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8303.815,
"heapDeltaBytes": -435064,
"heapUsedBytes": 179343524,
"domNodes": 0,
"jsHeapTotalBytes": -20447232,
"scriptDurationMs": 131.44899999999993,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8496.528000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8293.046,
"heapDeltaBytes": 10052156,
"heapUsedBytes": 178685584,
"domNodes": 0,
"jsHeapTotalBytes": -10223616,
"scriptDurationMs": 130.02700000000002,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 488.86600000003,
"styleRecalcs": 19,
"styleRecalcDurationMs": 23.625,
"layouts": 3,
"layoutDurationMs": 1.5410000000000001,
"taskDurationMs": 122.34599999999999,
"heapDeltaBytes": 5004120,
"heapUsedBytes": 74457752,
"domNodes": 147,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 11.590000000000002,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 452.50800000007985,
"styleRecalcs": 13,
"styleRecalcDurationMs": 17.442,
"layouts": 2,
"layoutDurationMs": 0.5379999999999999,
"taskDurationMs": 102.25300000000001,
"heapDeltaBytes": 4766684,
"heapUsedBytes": 74434108,
"domNodes": 119,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.125,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #19469 +/- ##
=============================================
Coverage ? 83.94%
=============================================
Files ? 2119
Lines ? 126859
Branches ? 34036
=============================================
Hits ? 106491
Misses ? 20190
Partials ? 178
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
…nd sends (#18991) (#19488) Backports #18991 to `cloud/1.54`. This carries starter-prompt click telemetry and correlates the subsequent send with prompt/click IDs while preserving the release branch Agent and telemetry APIs. It is based on the already-merged consent telemetry predecessor #19469. Conflict resolution: - preserved the release-branch Host telemetry and Agent panel test structure - added the starter-prompt event/method and send attribution fields - retained release-branch component behavior while carrying the runtime attribution path and focused coverage Validation: - pre-commit formatting, lint, ESLint, and `typecheck:app` passed - 9 focused test files passed: 326 tests - focused AgentPanelRoot attribution/workflow tests passed: 5 tests - full AgentPanelRoot file also exposed five unrelated asset/Response harness failures; the three attribution expectation failures were updated and pass in the focused run Original: #18991
Backports #19430 to
cloud/1.54.Source: #19430
Source merge:
a3a4a0b8a692ed738e9ceb5c23da0784739ce7c4The target lacked the consent-offer-exit telemetry substrate that #19430 extends. The conflict resolution includes only that required registry/provider contract, keeps
AgentConsentOfferStageprivate because this release branch has no external consumer, and adapts the consent unit tests to the target auth mock. No product behavior outside consent outcome telemetry is changed.Local verification:
--testTimeout=30000NODE_OPTIONS=--max-old-space-size=8192 pnpm typecheck