Skip to content

[backport cloud/1.54] feat(agent): instrument starter-prompt clicks and sends (#18991) - #19488

Merged
christian-byrne merged 1 commit into
Comfy-Org:cloud/1.54from
christian-byrne:backport-18991-to-cloud-1.54
Sep 29, 2026
Merged

christian-byrne merged 1 commit into
Comfy-Org:cloud/1.54from
christian-byrne:backport-18991-to-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backports #18991 to cloud/1.54.

This carries starter-prompt click telemetry and correlates the subsequent send with prompt/click IDs while preserving the release branch Agent and telemetry APIs. It is based on the already-merged consent telemetry predecessor #19469.

Conflict resolution:

  • preserved the release-branch Host telemetry and Agent panel test structure
  • added the starter-prompt event/method and send attribution fields
  • retained release-branch component behavior while carrying the runtime attribution path and focused coverage

Validation:

  • pre-commit formatting, lint, ESLint, and typecheck:app passed
  • 9 focused test files passed: 326 tests
  • focused AgentPanelRoot attribution/workflow tests passed: 5 tests
  • full AgentPanelRoot file also exposed five unrelated asset/Response harness failures; the three attribution expectation failures were updated and pass in the focused run

Original: #18991

… they produce (Comfy-Org#18991)

The five empty-state starter prompts are the cheapest lever on the
first-run path and nothing measures them. `input_method: 'suggestion'`
on `app:agent_message_sent` already says a chip was used; it cannot say
**which** chip, and nothing at all counts a chip that was clicked and
never sent. So "is prompt 3 the one that activates people?" is
unanswerable, and any experiment on the prompt set would be unreadable.

**New: `app:agent_starter_prompt_clicked`** — one event per click, never
on render, hover or focus.

| property | why it is there |
|---|---|
| `prompt_id` | The chip's **slot**, from a frozen table
(`starterPrompts.ts`), not its display text — the copy is owned by
product and is changing |
| `prompt_index`, `prompt_count` | A reordered or resized set is visible
instead of silently re-labelling slots |
| `prompt_text_hash` | FNV-1a, 8 hex, of the displayed text. Without it
a copy change under a stable `prompt_id` is indistinguishable from the
slot performing differently. Not the text, not reversible |
| `locale` | The locale that produced the hash — a translation is a
different hash of the same prompt |
| `click_id` | Minted per click; the join key to the send |
| `draft_was_empty` | Inserting **appends**, so `false` marks a
submitted draft that is a mix of this chip and something else |

**Extended: `app:agent_message_sent`** gains `starter_prompt_id` and
`starter_prompt_click_id`, so click → send → turn is one chain instead
of three unrelated counts. Both are `null` for a typed message, which is
the other arm of the question.

No copy change, no change to the prompt set, no change to submission
semantics, no flag or config touched. The click still inserts and still
does not send (`browser_tests/tests/agent/agentPanel.spec.ts` covers
that and is untouched).

- **Attribution lives and dies with `promptOrigin`**: held with the
submission snapshot, cleared at `startSubmission`, restored by
`takeFailedSubmission` so a retry is still that chip's message, dropped
when the conversation's edit action replaces the prompt. Two sources of
truth that could disagree about "did this come from a chip" would be
worse than one, so they share a lifecycle. Invariant, checkable in the
data: `starter_prompt_id` is non-null exactly when `input_method ===
'suggestion'`.
- **Reporting is gated on the caller identifying a prompt.** `insert()`
without an attribution still inserts and is still recorded as
`suggestion`, but reports no click — so a future affordance that reuses
`insert()` cannot inflate the starter-prompt counts.
- **A sixth prompt with no id reports `unregistered`** rather than
borrowing its neighbour's identity, and `starterPrompts.test.ts` fails
with a comment telling you to add the id. Graceful in data, loud in CI.
- **The last chip clicked owns the send**, because inserting appends and
a send is one message. `draft_was_empty: false` is how the mixed case is
found rather than assumed away.

`pnpm vitest run src/workbench/extensions/agent src/platform/telemetry`
— 177 files, 2918 passing. New coverage, one case per branch:

- `utils/starterPrompts.test.ts` — id table length matches the locale
array; out-of-table slot → `unregistered`; id survives a copy change
while the hash does not; hash shape and determinism.
- `components/agent/EmptyState.test.ts` — table-driven over all five
chips (slot id and index); nothing emitted before a click; two clicks
are two events; the payload carries the hash and **not** the text.
- `composables/agent/useComposer.test.ts` — one click event per
identified insert, with the click id the send will carry; second click
reports `draft_was_empty: false`; unidentified insert reports nothing
and leaves no stale attribution.
- `stores/agent/agentComposerStore.test.ts` — chip survives a reword,
cleared at submission, restored for a failed retry, dropped by the edit
action.
- `composables/agent/useAgentDraftSubmission.test.ts` — the chip reaches
`SubmissionMeta`, is not carried into the next send, and is restored for
the retry with a fresh `clientMessageId`.
- `AgentPanelRoot.test.ts` — the full chain end to end: the click
event's `click_id` is the send event's `starter_prompt_click_id`.
- Registry / PostHog / host-sink conformance cases for the new event.

Not on merge. Production serves a pinned frontend SHA (`08abb06e41` as
of 2026-09-26, with `canary.enabled: false`), and
`app:agent_message_sent`'s existing `input_method` is a live example of
the gap: it is in `main`, absent from the served build, and has **0
events on `cloud.comfy.org`** against 103 on `agent.comfy.org` in 30
days. This event needs merge → `cloud/1.54` backport → pin bump → argocd
sync before a production user can emit it. Any query on it must split by
`$host`.
@vercel

vercel Bot commented Sep 29, 2026

Copy link
Copy Markdown

@christian-byrne is attempting to deploy a commit to the ComfyUI Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: c6050ce2-fe6b-4f09-9355-73a150745588

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned) agent Comfy Agent product, integration, tests or product documentation agent-telemetry Agent analytics, diagnostics, error reporting or observability agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 29, 2026
@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/29/2026, 11:02:47 PM UTC

Links

🎭 Playwright: ⏳ Running...

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.4 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.4 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 88.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.6 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.9 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 150ms TBT · 105.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.0 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.1 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 93ms TBT · 173.8 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 495ms TBT · 173.7 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.8 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.0 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 7
canvas-idle: task duration 560ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 65.7 MB
canvas-idle: DOM nodes -285
canvas-idle: event listeners -181
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 30ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 899ms
canvas-mouse-sweep: script duration 164ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 57.7 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -180
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 375ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.4 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 474ms
dom-widget-clipping: script duration 175ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.7 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 8ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 618ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 80.8 MB
large-graph-idle: DOM nodes -276
large-graph-idle: event listeners -192
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1711ms
large-graph-pan: script duration 847ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 73.4 MB
large-graph-pan: DOM nodes -269
large-graph-pan: event listeners -177
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1747ms
large-graph-zoom: script duration 788ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 70.4 MB
large-graph-zoom: DOM nodes -145
large-graph-zoom: event listeners -94
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1938ms
legacy-node-drag: script duration 958ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 88.6 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 601ms
minimap-idle: script duration 34ms
minimap-idle: TBT 0ms
minimap-idle: heap used 81.5 MB
minimap-idle: DOM nodes -277
minimap-idle: event listeners -179
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 414ms
subgraph-dom-widget-clipping: script duration 144ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.6 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 488ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 72.9 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -210
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 29ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 842ms
subgraph-mouse-sweep: script duration 116ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 71.7 MB
subgraph-mouse-sweep: DOM nodes -307
subgraph-mouse-sweep: event listeners -227
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 17ms
subgraph-transition-enter: style recalc duration 34ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 968ms
subgraph-transition-enter: script duration 32ms
subgraph-transition-enter: TBT 150ms
subgraph-transition-enter: heap used 105.6 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 36ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5912ms
viewport-pan-sweep: script duration 2735ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 83.0 MB
viewport-pan-sweep: DOM nodes -258
viewport-pan-sweep: event listeners -177
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16978ms
vue-large-graph-idle: script duration 305ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.1 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 167
vue-large-graph-pan: task duration 20730ms
vue-large-graph-pan: script duration 953ms
vue-large-graph-pan: TBT 93ms
vue-large-graph-pan: heap used 173.8 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14925
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 25ms
vue-node-resize-workload: style recalc duration 83ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6149ms
vue-node-resize-workload: script duration 111ms
vue-node-resize-workload: TBT 495ms
vue-node-resize-workload: heap used 173.7 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14929
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8499ms
vue-zoom-out-idle: script duration 160ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 169.8 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 17ms
workflow-execution: layout count 2
workflow-execution: style recalc count 9
workflow-execution: task duration 81ms
workflow-execution: script duration 5ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.0 MB
workflow-execution: DOM nodes 131
workflow-execution: event listeners 17
Raw data
{
  "timestamp": "2026-09-29T23:12:08.105Z",
  "gitSha": "1637adc1bcee605cc753d796d5cd5b609c514115",
  "branch": "backport-18991-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2155.2859999999896,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.429999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 610.391,
      "heapDeltaBytes": 8264548,
      "heapUsedBytes": 79656736,
      "domNodes": -286,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 9.676,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2038.729000000103,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.32,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 509.499,
      "heapDeltaBytes": -12481168,
      "heapUsedBytes": 58041264,
      "domNodes": -283,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 8.882000000000001,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1941.0409999999843,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 32.82899999999999,
      "layouts": 14,
      "layoutDurationMs": 4.026999999999999,
      "taskDurationMs": 915.8280000000001,
      "heapDeltaBytes": -13304724,
      "heapUsedBytes": 57292652,
      "domNodes": -278,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 166.632,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1822.3799999999528,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 26.247,
      "layouts": 14,
      "layoutDurationMs": 3.6420000000000003,
      "taskDurationMs": 882.1159999999999,
      "heapDeltaBytes": -6457724,
      "heapUsedBytes": 63728840,
      "domNodes": -281,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 162.106,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1667.7270000000135,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 14.994,
      "layouts": 6,
      "layoutDurationMs": 0.9730000000000001,
      "taskDurationMs": 361.13800000000003,
      "heapDeltaBytes": 4619416,
      "heapUsedBytes": 75745580,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.623999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1756.3599999999724,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 17.798000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.228,
      "taskDurationMs": 389.01900000000006,
      "heapDeltaBytes": 4597328,
      "heapUsedBytes": 76127996,
      "domNodes": 77,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 12.495999999999997,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 695.8909999999605,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.248000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 481.298,
      "heapDeltaBytes": -7575224,
      "heapUsedBytes": 63490040,
      "domNodes": 20,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 173.672,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 674.323999999956,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.086999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 467.09000000000003,
      "heapDeltaBytes": 19302668,
      "heapUsedBytes": 88928984,
      "domNodes": 18,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 176.51,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2043.2069999999953,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 3.974000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 596.5180000000001,
      "heapDeltaBytes": 10815144,
      "heapUsedBytes": 87427632,
      "domNodes": -276,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 33.903000000000006,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2066.8699999999944,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 11.706999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 640.236,
      "heapDeltaBytes": 5896528,
      "heapUsedBytes": 81938616,
      "domNodes": -276,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 33.775,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2251.8440000000055,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 14.620999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1689.1249999999998,
      "heapDeltaBytes": 8822568,
      "heapUsedBytes": 86036380,
      "domNodes": -251,
      "jsHeapTotalBytes": -663552,
      "scriptDurationMs": 835.335,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2341.632000000004,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.366999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1732.8669999999997,
      "heapDeltaBytes": -10434732,
      "heapUsedBytes": 67860668,
      "domNodes": -287,
      "jsHeapTotalBytes": -364544,
      "scriptDurationMs": 857.8009999999999,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3569.6289999999635,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.654999999999998,
      "layouts": 60,
      "layoutDurationMs": 12.078000000000001,
      "taskDurationMs": 1711.0729999999999,
      "heapDeltaBytes": 8535304,
      "heapUsedBytes": 76535104,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 784.1909999999999,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3623.5719999999674,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 12.919,
      "layouts": 60,
      "layoutDurationMs": 12.188,
      "taskDurationMs": 1781.936,
      "heapDeltaBytes": -7722124,
      "heapUsedBytes": 71062652,
      "domNodes": -289,
      "jsHeapTotalBytes": 2781184,
      "scriptDurationMs": 792.071,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3132.862999999986,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.781999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1939.806,
      "heapDeltaBytes": 24858484,
      "heapUsedBytes": 92948380,
      "domNodes": 0,
      "jsHeapTotalBytes": 1204224,
      "scriptDurationMs": 964.1400000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3074.2569999999887,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.635,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1936.6719999999998,
      "heapDeltaBytes": 24856300,
      "heapUsedBytes": 92827372,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 951.7189999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2059.690000000046,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.952000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 635.5469999999999,
      "heapDeltaBytes": 5573484,
      "heapUsedBytes": 83103064,
      "domNodes": -281,
      "jsHeapTotalBytes": -1675264,
      "scriptDurationMs": 33.03300000000001,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2009.4239999999672,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 4.4140000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 565.849,
      "heapDeltaBytes": 21802468,
      "heapUsedBytes": 87768236,
      "domNodes": -272,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 34.151,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 616.6650000000118,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.487000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 416.9510000000001,
      "heapDeltaBytes": 15171692,
      "heapUsedBytes": 88196128,
      "domNodes": 18,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 143.10500000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 592.1289999999999,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.249999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 411.503,
      "heapDeltaBytes": 14278668,
      "heapUsedBytes": 87039244,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 145.19000000000003,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2025.4079999999703,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.103999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 485.13399999999996,
      "heapDeltaBytes": 4730204,
      "heapUsedBytes": 77830236,
      "domNodes": -297,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.620000000000003,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.1309999999585,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.408999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 491.163,
      "heapDeltaBytes": 1617524,
      "heapUsedBytes": 75069492,
      "domNodes": -297,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.783,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1725.0810000000456,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 27.858,
      "layouts": 18,
      "layoutDurationMs": 4.824999999999999,
      "taskDurationMs": 840.135,
      "heapDeltaBytes": -6611392,
      "heapUsedBytes": 67354940,
      "domNodes": -316,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 115.197,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1739.9370000000545,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 29.225,
      "layouts": 18,
      "layoutDurationMs": 5.108,
      "taskDurationMs": 843.0999999999999,
      "heapDeltaBytes": 9657288,
      "heapUsedBytes": 82974204,
      "domNodes": -297,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 117.19999999999999,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.938999999994,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 33.883,
      "layouts": 16,
      "layoutDurationMs": 16.801000000000002,
      "taskDurationMs": 967.6420000000002,
      "heapDeltaBytes": 21246224,
      "heapUsedBytes": 110726552,
      "domNodes": 13831,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 32.386,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 150,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8496.584999999981,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 36.464,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5903.194,
      "heapDeltaBytes": 13962868,
      "heapUsedBytes": 90675068,
      "domNodes": -271,
      "jsHeapTotalBytes": -1712128,
      "scriptDurationMs": 2706.6820000000002,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8471.307000000024,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 36.498000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5921.654,
      "heapDeltaBytes": 7011296,
      "heapUsedBytes": 83348228,
      "domNodes": -245,
      "jsHeapTotalBytes": 909312,
      "scriptDurationMs": 2762.8050000000003,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17785.13499999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16991.689000000002,
      "heapDeltaBytes": -63362480,
      "heapUsedBytes": 179813536,
      "domNodes": -8068,
      "jsHeapTotalBytes": -20230144,
      "scriptDurationMs": 290.51899999999995,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17744.768999999906,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16964.559,
      "heapDeltaBytes": -40012452,
      "heapUsedBytes": 178973800,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12115968,
      "scriptDurationMs": 320.172,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21243.517999999996,
      "styleRecalcs": 164,
      "styleRecalcDurationMs": 19.022999999999957,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20806.464000000004,
      "heapDeltaBytes": -55251056,
      "heapUsedBytes": 184144936,
      "domNodes": -8068,
      "jsHeapTotalBytes": -18251776,
      "scriptDurationMs": 989.3499999999999,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 99,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21045.383000000016,
      "styleRecalcs": 169,
      "styleRecalcDurationMs": 18.167999999999964,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20652.699,
      "heapDeltaBytes": -38739332,
      "heapUsedBytes": 180377020,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12902400,
      "scriptDurationMs": 916.9860000000001,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 87,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6277.426999999989,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 87.752,
      "layouts": 20,
      "layoutDurationMs": 26.726000000000013,
      "taskDurationMs": 6156.685,
      "heapDeltaBytes": -39646444,
      "heapUsedBytes": 183266836,
      "domNodes": -8068,
      "jsHeapTotalBytes": 8572928,
      "scriptDurationMs": 110.81000000000002,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 534,
      "frameDurationMs": 18.33333333333327,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6252.953000000048,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.94300000000004,
      "layouts": 20,
      "layoutDurationMs": 23.230000000000015,
      "taskDurationMs": 6142.223000000001,
      "heapDeltaBytes": -57956648,
      "heapUsedBytes": 180959140,
      "domNodes": -8068,
      "jsHeapTotalBytes": 8187904,
      "scriptDurationMs": 110.71400000000001,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 456,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8723.709999999983,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8497.214000000002,
      "heapDeltaBytes": 25036,
      "heapUsedBytes": 178652040,
      "domNodes": 0,
      "jsHeapTotalBytes": -19660800,
      "scriptDurationMs": 149.67799999999997,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8813.177999999993,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8500.822000000002,
      "heapDeltaBytes": -335116,
      "heapUsedBytes": 177517768,
      "domNodes": 0,
      "jsHeapTotalBytes": -25427968,
      "scriptDurationMs": 170.07099999999997,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 151.8980000000738,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 20.424999999999997,
      "layouts": 2,
      "layoutDurationMs": 1.425,
      "taskDurationMs": 89.38,
      "heapDeltaBytes": 3025104,
      "heapUsedBytes": 72520896,
      "domNodes": 135,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 5.922999999999999,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 101.19899999995141,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 14.442,
      "layouts": 2,
      "layoutDurationMs": 1.442,
      "taskDurationMs": 72.81000000000002,
      "heapDeltaBytes": 2981056,
      "heapUsedBytes": 72191840,
      "domNodes": 126,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 4.538,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

@codecov

codecov Bot commented Sep 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #19488   +/-   ##
=============================================
  Coverage              ?   79.12%           
=============================================
  Files                 ?     2030           
  Lines                 ?   113678           
  Branches              ?    32112           
=============================================
  Hits                  ?    89953           
  Misses                ?    23546           
  Partials              ?      179           
Flag Coverage Δ
unit 79.12% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/telemetry/TelemetryRegistry.ts 48.48% <100.00%> (ø)
...emetry/providers/cloud/PostHogTelemetryProvider.ts 73.41% <100.00%> (ø)
...form/telemetry/providers/host/HostTelemetrySink.ts 50.87% <100.00%> (ø)
src/platform/telemetry/types.ts 97.91% <ø> (ø)
src/workbench/extensions/agent/AgentPanelRoot.vue 91.49% <100.00%> (ø)
...h/extensions/agent/components/agent/AgentPanel.vue 96.82% <100.00%> (ø)
...nch/extensions/agent/components/agent/Composer.vue 99.17% <100.00%> (ø)
...h/extensions/agent/components/agent/EmptyState.vue 100.00% <100.00%> (ø)
...agent/composables/agent/useAgentDraftSubmission.ts 100.00% <100.00%> (ø)
.../extensions/agent/composables/agent/useComposer.ts 100.00% <100.00%> (ø)
... and 2 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne merged commit 1e17410 into Comfy-Org:cloud/1.54 Sep 29, 2026
135 of 138 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-telemetry Agent analytics, diagnostics, error reporting or observability agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants