Repository navigation
[backport cloud/1.54] feat(agent): instrument starter-prompt clicks and sends (#18991) - #19488
Conversation
… they produce (Comfy-Org#18991) The five empty-state starter prompts are the cheapest lever on the first-run path and nothing measures them. `input_method: 'suggestion'` on `app:agent_message_sent` already says a chip was used; it cannot say **which** chip, and nothing at all counts a chip that was clicked and never sent. So "is prompt 3 the one that activates people?" is unanswerable, and any experiment on the prompt set would be unreadable. **New: `app:agent_starter_prompt_clicked`** — one event per click, never on render, hover or focus. | property | why it is there | |---|---| | `prompt_id` | The chip's **slot**, from a frozen table (`starterPrompts.ts`), not its display text — the copy is owned by product and is changing | | `prompt_index`, `prompt_count` | A reordered or resized set is visible instead of silently re-labelling slots | | `prompt_text_hash` | FNV-1a, 8 hex, of the displayed text. Without it a copy change under a stable `prompt_id` is indistinguishable from the slot performing differently. Not the text, not reversible | | `locale` | The locale that produced the hash — a translation is a different hash of the same prompt | | `click_id` | Minted per click; the join key to the send | | `draft_was_empty` | Inserting **appends**, so `false` marks a submitted draft that is a mix of this chip and something else | **Extended: `app:agent_message_sent`** gains `starter_prompt_id` and `starter_prompt_click_id`, so click → send → turn is one chain instead of three unrelated counts. Both are `null` for a typed message, which is the other arm of the question. No copy change, no change to the prompt set, no change to submission semantics, no flag or config touched. The click still inserts and still does not send (`browser_tests/tests/agent/agentPanel.spec.ts` covers that and is untouched). - **Attribution lives and dies with `promptOrigin`**: held with the submission snapshot, cleared at `startSubmission`, restored by `takeFailedSubmission` so a retry is still that chip's message, dropped when the conversation's edit action replaces the prompt. Two sources of truth that could disagree about "did this come from a chip" would be worse than one, so they share a lifecycle. Invariant, checkable in the data: `starter_prompt_id` is non-null exactly when `input_method === 'suggestion'`. - **Reporting is gated on the caller identifying a prompt.** `insert()` without an attribution still inserts and is still recorded as `suggestion`, but reports no click — so a future affordance that reuses `insert()` cannot inflate the starter-prompt counts. - **A sixth prompt with no id reports `unregistered`** rather than borrowing its neighbour's identity, and `starterPrompts.test.ts` fails with a comment telling you to add the id. Graceful in data, loud in CI. - **The last chip clicked owns the send**, because inserting appends and a send is one message. `draft_was_empty: false` is how the mixed case is found rather than assumed away. `pnpm vitest run src/workbench/extensions/agent src/platform/telemetry` — 177 files, 2918 passing. New coverage, one case per branch: - `utils/starterPrompts.test.ts` — id table length matches the locale array; out-of-table slot → `unregistered`; id survives a copy change while the hash does not; hash shape and determinism. - `components/agent/EmptyState.test.ts` — table-driven over all five chips (slot id and index); nothing emitted before a click; two clicks are two events; the payload carries the hash and **not** the text. - `composables/agent/useComposer.test.ts` — one click event per identified insert, with the click id the send will carry; second click reports `draft_was_empty: false`; unidentified insert reports nothing and leaves no stale attribution. - `stores/agent/agentComposerStore.test.ts` — chip survives a reword, cleared at submission, restored for a failed retry, dropped by the edit action. - `composables/agent/useAgentDraftSubmission.test.ts` — the chip reaches `SubmissionMeta`, is not carried into the next send, and is restored for the retry with a fresh `clientMessageId`. - `AgentPanelRoot.test.ts` — the full chain end to end: the click event's `click_id` is the send event's `starter_prompt_click_id`. - Registry / PostHog / host-sink conformance cases for the new event. Not on merge. Production serves a pinned frontend SHA (`08abb06e41` as of 2026-09-26, with `canary.enabled: false`), and `app:agent_message_sent`'s existing `input_method` is a live example of the gap: it is in `main`, absent from the served build, and has **0 events on `cloud.comfy.org`** against 103 on `agent.comfy.org` in 30 days. This event needs merge → `cloud/1.54` backport → pin bump → argocd sync before a production user can emit it. Any query on it must split by `$host`.
|
@christian-byrne is attempting to deploy a commit to the ComfyUI Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ⏳ Running...📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-29T23:12:08.105Z",
"gitSha": "1637adc1bcee605cc753d796d5cd5b609c514115",
"branch": "backport-18991-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2155.2859999999896,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.429999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 610.391,
"heapDeltaBytes": 8264548,
"heapUsedBytes": 79656736,
"domNodes": -286,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 9.676,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2038.729000000103,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.32,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.499,
"heapDeltaBytes": -12481168,
"heapUsedBytes": 58041264,
"domNodes": -283,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.882000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1941.0409999999843,
"styleRecalcs": 77,
"styleRecalcDurationMs": 32.82899999999999,
"layouts": 14,
"layoutDurationMs": 4.026999999999999,
"taskDurationMs": 915.8280000000001,
"heapDeltaBytes": -13304724,
"heapUsedBytes": 57292652,
"domNodes": -278,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 166.632,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1822.3799999999528,
"styleRecalcs": 74,
"styleRecalcDurationMs": 26.247,
"layouts": 14,
"layoutDurationMs": 3.6420000000000003,
"taskDurationMs": 882.1159999999999,
"heapDeltaBytes": -6457724,
"heapUsedBytes": 63728840,
"domNodes": -281,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 162.106,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.7270000000135,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.994,
"layouts": 6,
"layoutDurationMs": 0.9730000000000001,
"taskDurationMs": 361.13800000000003,
"heapDeltaBytes": 4619416,
"heapUsedBytes": 75745580,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.623999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1756.3599999999724,
"styleRecalcs": 33,
"styleRecalcDurationMs": 17.798000000000002,
"layouts": 6,
"layoutDurationMs": 1.228,
"taskDurationMs": 389.01900000000006,
"heapDeltaBytes": 4597328,
"heapUsedBytes": 76127996,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.495999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 695.8909999999605,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.248000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.298,
"heapDeltaBytes": -7575224,
"heapUsedBytes": 63490040,
"domNodes": 20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 173.672,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 674.323999999956,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.086999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.09000000000003,
"heapDeltaBytes": 19302668,
"heapUsedBytes": 88928984,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 176.51,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2043.2069999999953,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.974000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 596.5180000000001,
"heapDeltaBytes": 10815144,
"heapUsedBytes": 87427632,
"domNodes": -276,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 33.903000000000006,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2066.8699999999944,
"styleRecalcs": 8,
"styleRecalcDurationMs": 11.706999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 640.236,
"heapDeltaBytes": 5896528,
"heapUsedBytes": 81938616,
"domNodes": -276,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 33.775,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2251.8440000000055,
"styleRecalcs": 66,
"styleRecalcDurationMs": 14.620999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1689.1249999999998,
"heapDeltaBytes": 8822568,
"heapUsedBytes": 86036380,
"domNodes": -251,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 835.335,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2341.632000000004,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.366999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1732.8669999999997,
"heapDeltaBytes": -10434732,
"heapUsedBytes": 67860668,
"domNodes": -287,
"jsHeapTotalBytes": -364544,
"scriptDurationMs": 857.8009999999999,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3569.6289999999635,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.654999999999998,
"layouts": 60,
"layoutDurationMs": 12.078000000000001,
"taskDurationMs": 1711.0729999999999,
"heapDeltaBytes": 8535304,
"heapUsedBytes": 76535104,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 784.1909999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3623.5719999999674,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.919,
"layouts": 60,
"layoutDurationMs": 12.188,
"taskDurationMs": 1781.936,
"heapDeltaBytes": -7722124,
"heapUsedBytes": 71062652,
"domNodes": -289,
"jsHeapTotalBytes": 2781184,
"scriptDurationMs": 792.071,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3132.862999999986,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.781999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1939.806,
"heapDeltaBytes": 24858484,
"heapUsedBytes": 92948380,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 964.1400000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3074.2569999999887,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.635,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1936.6719999999998,
"heapDeltaBytes": 24856300,
"heapUsedBytes": 92827372,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 951.7189999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2059.690000000046,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.952000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 635.5469999999999,
"heapDeltaBytes": 5573484,
"heapUsedBytes": 83103064,
"domNodes": -281,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 33.03300000000001,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2009.4239999999672,
"styleRecalcs": 3,
"styleRecalcDurationMs": 4.4140000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.849,
"heapDeltaBytes": 21802468,
"heapUsedBytes": 87768236,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.151,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 616.6650000000118,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.487000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.9510000000001,
"heapDeltaBytes": 15171692,
"heapUsedBytes": 88196128,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 143.10500000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 592.1289999999999,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.249999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.503,
"heapDeltaBytes": 14278668,
"heapUsedBytes": 87039244,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 145.19000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2025.4079999999703,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.103999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.13399999999996,
"heapDeltaBytes": 4730204,
"heapUsedBytes": 77830236,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.620000000000003,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.1309999999585,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.408999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.163,
"heapDeltaBytes": 1617524,
"heapUsedBytes": 75069492,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.783,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.0810000000456,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.858,
"layouts": 18,
"layoutDurationMs": 4.824999999999999,
"taskDurationMs": 840.135,
"heapDeltaBytes": -6611392,
"heapUsedBytes": 67354940,
"domNodes": -316,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 115.197,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.9370000000545,
"styleRecalcs": 78,
"styleRecalcDurationMs": 29.225,
"layouts": 18,
"layoutDurationMs": 5.108,
"taskDurationMs": 843.0999999999999,
"heapDeltaBytes": 9657288,
"heapUsedBytes": 82974204,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 117.19999999999999,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.938999999994,
"styleRecalcs": 20,
"styleRecalcDurationMs": 33.883,
"layouts": 16,
"layoutDurationMs": 16.801000000000002,
"taskDurationMs": 967.6420000000002,
"heapDeltaBytes": 21246224,
"heapUsedBytes": 110726552,
"domNodes": 13831,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 32.386,
"eventListeners": 2385,
"totalBlockingTimeMs": 150,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8496.584999999981,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.464,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5903.194,
"heapDeltaBytes": 13962868,
"heapUsedBytes": 90675068,
"domNodes": -271,
"jsHeapTotalBytes": -1712128,
"scriptDurationMs": 2706.6820000000002,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8471.307000000024,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.498000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5921.654,
"heapDeltaBytes": 7011296,
"heapUsedBytes": 83348228,
"domNodes": -245,
"jsHeapTotalBytes": 909312,
"scriptDurationMs": 2762.8050000000003,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17785.13499999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16991.689000000002,
"heapDeltaBytes": -63362480,
"heapUsedBytes": 179813536,
"domNodes": -8068,
"jsHeapTotalBytes": -20230144,
"scriptDurationMs": 290.51899999999995,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17744.768999999906,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16964.559,
"heapDeltaBytes": -40012452,
"heapUsedBytes": 178973800,
"domNodes": -8068,
"jsHeapTotalBytes": -12115968,
"scriptDurationMs": 320.172,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21243.517999999996,
"styleRecalcs": 164,
"styleRecalcDurationMs": 19.022999999999957,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20806.464000000004,
"heapDeltaBytes": -55251056,
"heapUsedBytes": 184144936,
"domNodes": -8068,
"jsHeapTotalBytes": -18251776,
"scriptDurationMs": 989.3499999999999,
"eventListeners": -14925,
"totalBlockingTimeMs": 99,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21045.383000000016,
"styleRecalcs": 169,
"styleRecalcDurationMs": 18.167999999999964,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20652.699,
"heapDeltaBytes": -38739332,
"heapUsedBytes": 180377020,
"domNodes": -8068,
"jsHeapTotalBytes": -12902400,
"scriptDurationMs": 916.9860000000001,
"eventListeners": -14925,
"totalBlockingTimeMs": 87,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6277.426999999989,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.752,
"layouts": 20,
"layoutDurationMs": 26.726000000000013,
"taskDurationMs": 6156.685,
"heapDeltaBytes": -39646444,
"heapUsedBytes": 183266836,
"domNodes": -8068,
"jsHeapTotalBytes": 8572928,
"scriptDurationMs": 110.81000000000002,
"eventListeners": -14929,
"totalBlockingTimeMs": 534,
"frameDurationMs": 18.33333333333327,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6252.953000000048,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.94300000000004,
"layouts": 20,
"layoutDurationMs": 23.230000000000015,
"taskDurationMs": 6142.223000000001,
"heapDeltaBytes": -57956648,
"heapUsedBytes": 180959140,
"domNodes": -8068,
"jsHeapTotalBytes": 8187904,
"scriptDurationMs": 110.71400000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 456,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8723.709999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8497.214000000002,
"heapDeltaBytes": 25036,
"heapUsedBytes": 178652040,
"domNodes": 0,
"jsHeapTotalBytes": -19660800,
"scriptDurationMs": 149.67799999999997,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8813.177999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8500.822000000002,
"heapDeltaBytes": -335116,
"heapUsedBytes": 177517768,
"domNodes": 0,
"jsHeapTotalBytes": -25427968,
"scriptDurationMs": 170.07099999999997,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 151.8980000000738,
"styleRecalcs": 10,
"styleRecalcDurationMs": 20.424999999999997,
"layouts": 2,
"layoutDurationMs": 1.425,
"taskDurationMs": 89.38,
"heapDeltaBytes": 3025104,
"heapUsedBytes": 72520896,
"domNodes": 135,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.922999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 101.19899999995141,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.442,
"layouts": 2,
"layoutDurationMs": 1.442,
"taskDurationMs": 72.81000000000002,
"heapDeltaBytes": 2981056,
"heapUsedBytes": 72191840,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.538,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #19488 +/- ##
=============================================
Coverage ? 79.12%
=============================================
Files ? 2030
Lines ? 113678
Branches ? 32112
=============================================
Hits ? 89953
Misses ? 23546
Partials ? 179
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
1e17410
into
Comfy-Org:cloud/1.54
Backports #18991 to
cloud/1.54.This carries starter-prompt click telemetry and correlates the subsequent send with prompt/click IDs while preserving the release branch Agent and telemetry APIs. It is based on the already-merged consent telemetry predecessor #19469.
Conflict resolution:
Validation:
typecheck:apppassedOriginal: #18991