Skip to content

FE-3019 fix(billing-web): summary discounts, kept team commitment, and payment column layout per M3 design review - #19374

Merged
dante01yoon merged 7 commits into
jaewon/fe-3018-full-page-checkout-shellfrom
jaewon/fe-3019-m3-design-review-summary
Sep 29, 2026
Merged

dante01yoon merged 7 commits into
jaewon/fe-3018-full-page-checkout-shellfrom
jaewon/fe-3019-m3-design-review-summary

Conversation

@dante01yoon

@dante01yoon dante01yoon commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to design review on #19253. Brings the full-page checkout's summary ledger and payment column in line with Alex's M3 review (FE-3019 "Added 2026-09-28", DES-1210).

Why

The review found three places where the build does not match Figma, and one behavior bug. When a team lowers its commitment, the summary said "You'll keep Team until July 28". It did not say which commitment runs until then, because every commitment has the same tier name.

Root cause

  • The scheduled family's trailing line named the kept plan by tier only. For a team-to-team change, the tier is the same on both sides, so the line could not tell commitments apart.
  • Held and promo discount amounts used the foreground color. Figma mutes every negative amount (305-9069).
  • The saved method used the shared embedded-checkout row: a "Saved payment method" caption, visa •••• 4242, and a Change link. The full-page design uses a filled picker row with a card icon, Visa ·· 4242, and a chevron (180-6640). Add new already has its own tab, so the Change link duplicated it.
  • StripePaymentForm always drew its own semibold heading and method-choice subtitle. On the tabbed rail it drew an empty heading with the subtitle still showing. Figma wants "Payment method" and "Billing address" in Regular 16, 12px above what they label, with no subtitle (180-6630).

How

  • summaryLedger.ts: on a team commit change, the kept-plan line reads "You'll keep Team at $1,400.00 /mo until July 28, 2026". The rate is current_plan.seat_summary.total_cost_cents, formatted and not computed.
  • CheckoutLedger.vue: adjustment and promo amounts use text-muted-foreground.
  • New SavedMethodSelect.vue (billing-web only): a Reka select whose trigger is the Figma row. The brand is capitalized in CSS, and ·· {last4} is muted. Alipay shows a wallet icon and its name. SavedMethodPanel drops the shared CheckoutSavedMethods and its Change and Add new affordances.
  • StripePaymentForm gets an opt-in pageLayout prop. With it, the form drops its heading and subtitle, names its group with aria-label, and sets the Billing address label in Regular 16. The prop defaults to off, so the core app's embedded checkout does not change. billing-web renders one "Payment method" label above the tabs and the form, with a 12px gap.
Alex's item Status Commit
Strikethrough only on a discounted plan's compare price; promo and held rows show "−$X" and are never struck through Already correct for promo and held rows: they render −$X and nothing is struck through. The compare price is a BE gap, see below none
Subtotal only when a discount follows 2 or more price rows Already correct: Subtotal never renders. Today's ledger has at most one money row, and the quote reports no subtotal. BE gap, see below none
Bug 8 (#19266): lowering a team commitment doesn't say which commitment is kept Fixed 9ad5045 (test), b86190c
Discount amounts muted (305-9069) Fixed 4d159c7
Saved card as a filled row with a card icon, Visa ·· 4242, and a chevron (180-6640) Fixed c158118 (test), daaaf30
"Payment method" / "Billing address" in Regular 16, 12px gap, no subtitle (180-6630) Fixed 90cdb8a (test), 1a08061, daaaf30

BE gaps (not computed on the frontend)

  • Compare price. The strikethrough compare price on a discounted rate ("$630 $700 /mo × 12 months") needs a server-reported per-period list price and discounted price. PreviewSubscribeResponse has only price_cents and a plan discount with no per-period figures. Deriving $630 as 756000 / 12 would be client money arithmetic, so the annual subline stays "Billed yearly".
  • Subtotal. PreviewSubscribeResponse has no pre-discount subtotal field. The subtotal ledger slot stays unpopulated until the server reports one. It can only qualify once the quote itemizes proration into two rows.

Review Focus

  • The saved method is now always a picker, including when there is only one method. Figma shows the chevron on a single Visa, so a one-item list opens. Alex should confirm this over a static row.
  • The kept-commitment copy ("at $1,400.00 /mo") is new. FE-3019 and FE-2856 have no copy for it, so it needs Alex's sign-off. Team commit proration copy is still held until Wei answers (DES-1210).

Plan position

PR Scope
#19253 M3 full-page checkout shell (base)
FE-3018 follow-up entry and keep-subscription
this PR (FE-3019) summary and payment column layout
FE-3020 follow-up promo
FE-3021 follow-up endings
FE-3022 follow-up payment auth
graph LR
  base["#19253 shell"] --> a["FE-3018 entry"]
  base --> b["FE-3019 summary + payment column"]
  base --> c["FE-3020 promo"]
  base --> d["FE-3021 endings"]
  base --> e["FE-3022 payment auth"]
  style b fill:#f5c518,color:#000
Loading

Verification

  • billing-web: vitest (729 passed), typecheck:billing-web, lint, and Playwright. The full suite ran 66 of 68 green. The other 2 lost their preview server partway through the run (a refused connection on :4174) and passed when full-page-checkout.spec.ts was rerun (7/7).
  • account-ui: vitest (215 passed) and typecheck:account-ui.
  • Root: pnpm typecheck and pnpm knip are clean. The fallow audit shows advisory token-drift warnings only.

Screenshots

All images are from the fixture build: the billing-web Playwright fixtures (apps/billing-web/e2e/fixtures, mocked Cloud and a fake Stripe.js), production vite build, dark theme, 1280px wide unless the row says phone. AS IS is the base jaewon/fe-3018-full-page-checkout-shell @ 2c0d3a1381; TO BE is this PR @ daaaf30e2f. None are from a real backend.

Item AS IS TO BE
Bug 8: lowered team commitment names the kept commitment by its rate lowered-team-commitment AS IS lowered-team-commitment TO BE
Discount amounts muted (305-9069) discount-rows AS IS discount-rows TO BE
Saved card as a picker row, Visa ·· 4242, chevron (180-6640) saved-card AS IS saved-card TO BE
"Payment method" / "Billing address" labels, Regular 16, no subtitle (180-6630), Add new payment tab payment-labels AS IS payment-labels TO BE

Not captured:

  • The fake Stripe.js in the fixture build renders no card or address fields, so the payment column shows only the labels around empty Elements.

@dante01yoon
dante01yoon requested a review from a team as a code owner September 29, 2026 07:08
@dante01yoon dante01yoon added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch core/1.55 Backport PRs for core 1.55 cloud/1.55 Backport PRs for cloud 1.55 labels Sep 29, 2026
@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 150ca671-b7be-4690-bd3e-e22eaae4fbc9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 2c0d3a1381fe2725af9082f7d1fe8013fd2f183b

Full docs: ADR-DEVEX-LINT-0015

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/29/2026, 07:24:19 AM UTC

Links

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🎭 Playwright: ✅ 2159 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2138 / ❌ 0 / ⚠️ 0 / ⏭️ 9)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 92.4 MB heap
dom-widget-order-dense-n200-w200-i120: · 27.7 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 578ms TBT · 81.7 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 38.9 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 241ms TBT · 88.1 MB heap
extension-clean-combined-draw: · 29.4 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 1468ms TBT · 64.6 MB heap
extension-rgthree-prototype-draw: · 31.2 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 1447ms TBT · 77.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
legacy-node-drag: · 59.5 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.5 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 89.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.3 MB heap
subgraph-mouse-sweep: · 59.7 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.4 MB heap
subgraph-transition-enter: · 50.2 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 141ms TBT · 93.8 MB heap
viewport-pan-sweep: · 59.9 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.9 MB heap
vue-large-graph-idle: · 31.9 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 2ms TBT · 177.1 MB heap
vue-large-graph-pan: · 24.8 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 63ms TBT · 181.3 MB heap
vue-node-resize-workload: · 27.4 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 454ms TBT · 205.8 MB heap
vue-zoom-out-idle: · 36.0 avg FPS · 17.2 P5 FPS ❌ (target: ≥52) · 0ms TBT · 172.3 MB heap
workflow-execution: · 56.5 avg FPS · 39.9 P5 FPS ❌ (target: ≥52) · 0ms TBT · 76.5 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.2 MB heap
agent-composer-long-conversation-typing: · 55.2 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 110.2 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 4ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 489ms
canvas-idle: script duration 12ms
canvas-idle: TBT 0ms
canvas-idle: heap used 58.2 MB
canvas-idle: DOM nodes -228
canvas-idle: event listeners -142
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 20ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 891ms
canvas-mouse-sweep: script duration 174ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 70.4 MB
canvas-mouse-sweep: DOM nodes -228
canvas-mouse-sweep: event listeners -153
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 12ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 33
canvas-zoom-sweep: task duration 372ms
canvas-zoom-sweep: script duration 14ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 76.8 MB
canvas-zoom-sweep: DOM nodes 53
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 5ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 481ms
dom-widget-clipping: script duration 177ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 92.4 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 36ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 869ms
dom-widget-order-dense-n200-w200-i120: script duration 73ms
dom-widget-order-dense-n200-w200-i120: TBT 578ms
dom-widget-order-dense-n200-w200-i120: heap used 81.7 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 26ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 488ms
dom-widget-order-sparse-n1000-w20-i120: script duration 169ms
dom-widget-order-sparse-n1000-w20-i120: TBT 241ms
dom-widget-order-sparse-n1000-w20-i120: heap used 88.1 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 34ms
extension-clean-combined-draw: p95 frame time 67ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 9897ms
extension-clean-combined-draw: script duration 8247ms
extension-clean-combined-draw: TBT 1468ms
extension-clean-combined-draw: heap used 64.6 MB
extension-clean-combined-draw: DOM nodes 0
extension-clean-combined-draw: event listeners 0
extension-rgthree-prototype-draw: avg frame time 32ms
extension-rgthree-prototype-draw: p95 frame time 67ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 0
extension-rgthree-prototype-draw: task duration 10228ms
extension-rgthree-prototype-draw: script duration 8453ms
extension-rgthree-prototype-draw: TBT 1447ms
extension-rgthree-prototype-draw: heap used 77.1 MB
extension-rgthree-prototype-draw: DOM nodes 0
extension-rgthree-prototype-draw: event listeners 0
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 8
large-graph-idle: task duration 628ms
large-graph-idle: script duration 39ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 78.9 MB
large-graph-idle: DOM nodes -228
large-graph-idle: event listeners -153
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1822ms
large-graph-pan: script duration 930ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 72.1 MB
large-graph-pan: DOM nodes -228
large-graph-pan: event listeners -153
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 15ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 63
large-graph-zoom: task duration 1794ms
large-graph-zoom: script duration 823ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 71.7 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 44
legacy-node-drag: task duration 2023ms
legacy-node-drag: script duration 1022ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 62.5 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 602ms
minimap-idle: script duration 36ms
minimap-idle: TBT 0ms
minimap-idle: heap used 80.0 MB
minimap-idle: DOM nodes -228
minimap-idle: event listeners -142
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 7ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 421ms
subgraph-dom-widget-clipping: script duration 150ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 89.3 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 4ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 487ms
subgraph-idle: script duration 11ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 57.3 MB
subgraph-idle: DOM nodes -244
subgraph-idle: event listeners -199
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 20ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 74
subgraph-mouse-sweep: task duration 854ms
subgraph-mouse-sweep: script duration 120ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 55.4 MB
subgraph-mouse-sweep: DOM nodes -244
subgraph-mouse-sweep: event listeners -199
subgraph-transition-enter: avg frame time 20ms
subgraph-transition-enter: p95 frame time 33ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 16
subgraph-transition-enter: task duration 972ms
subgraph-transition-enter: script duration 41ms
subgraph-transition-enter: TBT 141ms
subgraph-transition-enter: heap used 93.8 MB
subgraph-transition-enter: DOM nodes 13667
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 34ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 6085ms
viewport-pan-sweep: script duration 2864ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 80.9 MB
viewport-pan-sweep: DOM nodes -228
viewport-pan-sweep: event listeners -153
vue-large-graph-idle: avg frame time 31ms
vue-large-graph-idle: p95 frame time 67ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16794ms
vue-large-graph-idle: script duration 308ms
vue-large-graph-idle: TBT 2ms
vue-large-graph-idle: heap used 177.1 MB
vue-large-graph-idle: DOM nodes -5547
vue-large-graph-idle: event listeners -14919
vue-large-graph-pan: avg frame time 40ms
vue-large-graph-pan: p95 frame time 83ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 154
vue-large-graph-pan: task duration 20830ms
vue-large-graph-pan: script duration 926ms
vue-large-graph-pan: TBT 63ms
vue-large-graph-pan: heap used 181.3 MB
vue-large-graph-pan: DOM nodes -5547
vue-large-graph-pan: event listeners -7458
vue-node-resize-workload: avg frame time 36ms
vue-node-resize-workload: p95 frame time 67ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 83ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6107ms
vue-node-resize-workload: script duration 110ms
vue-node-resize-workload: TBT 454ms
vue-node-resize-workload: heap used 205.8 MB
vue-node-resize-workload: DOM nodes 0
vue-node-resize-workload: event listeners 0
vue-zoom-out-idle: avg frame time 28ms
vue-zoom-out-idle: p95 frame time 58ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7567ms
vue-zoom-out-idle: script duration 144ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 172.3 MB
vue-zoom-out-idle: DOM nodes -1523
vue-zoom-out-idle: event listeners -7458
workflow-execution: avg frame time 18ms
workflow-execution: p95 frame time 25ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 4
workflow-execution: style recalc count 11
workflow-execution: task duration 112ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 76.5 MB
workflow-execution: DOM nodes 118
workflow-execution: event listeners 25
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 26ms
agent-composer-empty-conversation-typing: style recalc duration 115ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 78
agent-composer-empty-conversation-typing: task duration 984ms
agent-composer-empty-conversation-typing: script duration 406ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 87.2 MB
agent-composer-empty-conversation-typing: DOM nodes 76
agent-composer-empty-conversation-typing: event listeners 876
agent-composer-long-conversation-typing: avg frame time 18ms
agent-composer-long-conversation-typing: p95 frame time 33ms
agent-composer-long-conversation-typing: layout duration 26ms
agent-composer-long-conversation-typing: style recalc duration 256ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 78
agent-composer-long-conversation-typing: task duration 1404ms
agent-composer-long-conversation-typing: script duration 474ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 110.2 MB
agent-composer-long-conversation-typing: DOM nodes 76
agent-composer-long-conversation-typing: event listeners 876
Raw data
{
  "timestamp": "2026-09-29T07:32:34.071Z",
  "gitSha": "72ced5ed78e34bfefd0e35135746ffdae0c4164b",
  "branch": "jaewon/fe-3019-m3-design-review-summary",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2030.869999999993,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.276999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 506.76,
      "heapDeltaBytes": -18501616,
      "heapUsedBytes": 60296392,
      "domNodes": -228,
      "jsHeapTotalBytes": -524288,
      "scriptDurationMs": 12.716000000000001,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2043.3029999999235,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.7489999999999988,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 471.90599999999995,
      "heapDeltaBytes": -16809792,
      "heapUsedBytes": 61666052,
      "domNodes": -228,
      "jsHeapTotalBytes": -524288,
      "scriptDurationMs": 10.293999999999997,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665040650406507,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1908.095000000003,
      "styleRecalcs": 82,
      "styleRecalcDurationMs": 20.282999999999998,
      "layouts": 12,
      "layoutDurationMs": 4.98,
      "taskDurationMs": 906.172,
      "heapDeltaBytes": -29923380,
      "heapUsedBytes": 68194168,
      "domNodes": -228,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 174.47600000000003,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665789473684214,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1864.7290000000112,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 19.517,
      "layouts": 12,
      "layoutDurationMs": 4.807,
      "taskDurationMs": 875.146,
      "heapDeltaBytes": 26968,
      "heapUsedBytes": 79341712,
      "domNodes": -228,
      "jsHeapTotalBytes": -262144,
      "scriptDurationMs": 173.82999999999998,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66607142857143,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1692.3059999999737,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 11.889000000000001,
      "layouts": 6,
      "layoutDurationMs": 1.4310000000000003,
      "taskDurationMs": 380.903,
      "heapDeltaBytes": 1780288,
      "heapUsedBytes": 80625456,
      "domNodes": 53,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 14.578000000000001,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66568627450981,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1734.4059999999217,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 11.225999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.104,
      "taskDurationMs": 362.425,
      "heapDeltaBytes": 1493284,
      "heapUsedBytes": 80408044,
      "domNodes": 53,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 13.574999999999998,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665384615384614,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 741.960000000006,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 4.693,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 477.35499999999996,
      "heapDeltaBytes": 18298824,
      "heapUsedBytes": 97224104,
      "domNodes": 0,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 177.33400000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665909090909096,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 748.1839999999238,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 5.1129999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 484.06499999999994,
      "heapDeltaBytes": -1982460,
      "heapUsedBytes": 96601352,
      "domNodes": 0,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 177.396,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665909090909096,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1193.0490000000304,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 869.8549999999999,
      "heapDeltaBytes": 9629840,
      "heapUsedBytes": 85705876,
      "domNodes": 0,
      "jsHeapTotalBytes": 4358144,
      "scriptDurationMs": 71.67099999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 578,
      "frameDurationMs": 36.36363636363637,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1225.488999999925,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 868.025,
      "heapDeltaBytes": 9653660,
      "heapUsedBytes": 85573384,
      "domNodes": 0,
      "jsHeapTotalBytes": 4882432,
      "scriptDurationMs": 74.85600000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 578,
      "frameDurationMs": 35.782352941176484,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 877.8310000000147,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 501.49199999999985,
      "heapDeltaBytes": 15943388,
      "heapUsedBytes": 90919516,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 174.975,
      "eventListeners": 0,
      "totalBlockingTimeMs": 250,
      "frameDurationMs": 25.979411764705862,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 863.7870000000021,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 474.13900000000007,
      "heapDeltaBytes": 14681560,
      "heapUsedBytes": 93761024,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 163.598,
      "eventListeners": 0,
      "totalBlockingTimeMs": 232,
      "frameDurationMs": 25.491176470588204,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 11606.896999999975,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10468.596,
      "heapDeltaBytes": -11479016,
      "heapUsedBytes": 68865044,
      "domNodes": 0,
      "jsHeapTotalBytes": -14417920,
      "scriptDurationMs": 8617.900000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1611,
      "frameDurationMs": 33.04729344729345,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10121.68799999995,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9325.5,
      "heapDeltaBytes": -14134956,
      "heapUsedBytes": 66715764,
      "domNodes": 0,
      "jsHeapTotalBytes": -13631488,
      "scriptDurationMs": 7876.146,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1324,
      "frameDurationMs": 35.00449826989619,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 11471.45599999999,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10398.971,
      "heapDeltaBytes": -1697832,
      "heapUsedBytes": 79653884,
      "domNodes": 0,
      "jsHeapTotalBytes": -8912896,
      "scriptDurationMs": 8593.653999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1588,
      "frameDurationMs": 32.39039548022599,
      "p95FrameDurationMs": 66.69999999999982
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 11150.622999999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10057.630000000001,
      "heapDeltaBytes": 1201636,
      "heapUsedBytes": 82041480,
      "domNodes": 0,
      "jsHeapTotalBytes": -15204352,
      "scriptDurationMs": 8312.317000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1305,
      "frameDurationMs": 31.808285714285713,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2068.741999999986,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.381,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 651.0369999999999,
      "heapDeltaBytes": -35919380,
      "heapUsedBytes": 82894872,
      "domNodes": -228,
      "jsHeapTotalBytes": 425984,
      "scriptDurationMs": 41.228,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66532258064516,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2060.055000000034,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 3.4859999999999993,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 603.9709999999999,
      "heapDeltaBytes": -36577320,
      "heapUsedBytes": 82566132,
      "domNodes": -228,
      "jsHeapTotalBytes": -360448,
      "scriptDurationMs": 37.721999999999994,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3043.461999999977,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 10.148000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1832.77,
      "heapDeltaBytes": -54909876,
      "heapUsedBytes": 64360324,
      "domNodes": -228,
      "jsHeapTotalBytes": -98304,
      "scriptDurationMs": 917.518,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665745856353592,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2879.4960000000174,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 9.641,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1810.845,
      "heapDeltaBytes": -33145732,
      "heapUsedBytes": 86924540,
      "domNodes": -228,
      "jsHeapTotalBytes": 126976,
      "scriptDurationMs": 941.8580000000001,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66608187134503,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3868.681000000038,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 11.477000000000004,
      "layouts": 60,
      "layoutDurationMs": 14.643999999999998,
      "taskDurationMs": 1812.333,
      "heapDeltaBytes": 9511956,
      "heapUsedBytes": 73753820,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 824.5709999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666379310344826,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3812.575000000038,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 11.205,
      "layouts": 60,
      "layoutDurationMs": 14.571999999999997,
      "taskDurationMs": 1776.627,
      "heapDeltaBytes": 12598592,
      "heapUsedBytes": 76703564,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 820.4879999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665938864628824,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3149.4089999999915,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 6.1499999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2050.624,
      "heapDeltaBytes": 812556,
      "heapUsedBytes": 65588016,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 1026.5279999999998,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.843850267379676,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3188.301000000024,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 6.270000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1996.3570000000002,
      "heapDeltaBytes": 539624,
      "heapUsedBytes": 65583756,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 1018.172,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.753968253968253,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2046.514000000002,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 2.699,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 631.9749999999998,
      "heapDeltaBytes": -36812528,
      "heapUsedBytes": 84035680,
      "domNodes": -228,
      "jsHeapTotalBytes": 163840,
      "scriptDurationMs": 39.81699999999999,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2050.448000000074,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.9999999999999982,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 571.5659999999999,
      "heapDeltaBytes": -36866872,
      "heapUsedBytes": 83754608,
      "domNodes": -228,
      "jsHeapTotalBytes": 163840,
      "scriptDurationMs": 32.574999999999996,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 635.3730000000155,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 6.2810000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 424.17900000000003,
      "heapDeltaBytes": 12430648,
      "heapUsedBytes": 93694236,
      "domNodes": 0,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 152.272,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665789473684214,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 647.8700000000117,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 6.804000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 417.921,
      "heapDeltaBytes": 13338104,
      "heapUsedBytes": 93482192,
      "domNodes": 0,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 147.807,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665789473684214,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2040.71399999998,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 4.585000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 502.0530000000001,
      "heapDeltaBytes": -15375588,
      "heapUsedBytes": 65836632,
      "domNodes": -244,
      "jsHeapTotalBytes": -262144,
      "scriptDurationMs": 12.771999999999998,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66557377049181,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2037.2129999999515,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 4.225000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 472.587,
      "heapDeltaBytes": -27196924,
      "heapUsedBytes": 54359304,
      "domNodes": -244,
      "jsHeapTotalBytes": -786432,
      "scriptDurationMs": 9.779999999999998,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1757.5979999999731,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 19.596999999999998,
      "layouts": 16,
      "layoutDurationMs": 5.888,
      "taskDurationMs": 859.6840000000001,
      "heapDeltaBytes": -26690604,
      "heapUsedBytes": 54743336,
      "domNodes": -244,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 120.64899999999999,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665714285714284,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1743.863000000033,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 21.122000000000003,
      "layouts": 16,
      "layoutDurationMs": 6.581999999999999,
      "taskDurationMs": 847.593,
      "heapDeltaBytes": -19295664,
      "heapUsedBytes": 61343132,
      "domNodes": -244,
      "jsHeapTotalBytes": -786432,
      "scriptDurationMs": 120.15,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.826923076923077,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1419.0450000000965,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 31.33299999999999,
      "layouts": 5,
      "layoutDurationMs": 13.852000000000004,
      "taskDurationMs": 972.2800000000002,
      "heapDeltaBytes": 21340712,
      "heapUsedBytes": 98378592,
      "domNodes": 13667,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 40.954,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 141,
      "frameDurationMs": 19.90555555555555,
      "p95FrameDurationMs": 33.30000000000018
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9329.781999999967,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 34.151,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6157.863000000001,
      "heapDeltaBytes": -33503292,
      "heapUsedBytes": 85675424,
      "domNodes": -228,
      "jsHeapTotalBytes": -167936,
      "scriptDurationMs": 2892.167,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.695698924731182,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9086.510999999973,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 33.154,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6011.951,
      "heapDeltaBytes": -34782700,
      "heapUsedBytes": 83968440,
      "domNodes": -228,
      "jsHeapTotalBytes": 94208,
      "scriptDurationMs": 2835.1009999999997,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.69668508287293,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16958.349000000057,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16702.132999999998,
      "heapDeltaBytes": 5156108,
      "heapUsedBytes": 177790904,
      "domNodes": -8049,
      "jsHeapTotalBytes": -12320768,
      "scriptDurationMs": 273.13300000000004,
      "eventListeners": -14923,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 30.903460837887074,
      "p95FrameDurationMs": 66.59999999999854
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17215.937999999936,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16884.995,
      "heapDeltaBytes": -4526820,
      "heapUsedBytes": 193584024,
      "domNodes": -3045,
      "jsHeapTotalBytes": 4468736,
      "scriptDurationMs": 342.857,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 3,
      "frameDurationMs": 31.853234750462104,
      "p95FrameDurationMs": 66.69999999999709
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21057.55199999999,
      "styleRecalcs": 158,
      "styleRecalcDurationMs": 19.290999999999976,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20908.037999999997,
      "heapDeltaBytes": -33415968,
      "heapUsedBytes": 191014476,
      "domNodes": -3045,
      "jsHeapTotalBytes": 7020544,
      "scriptDurationMs": 949.436,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 27,
      "frameDurationMs": 40.2337786259542,
      "p95FrameDurationMs": 83.30000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20886.571000000004,
      "styleRecalcs": 149,
      "styleRecalcDurationMs": 18.31800000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20751.279,
      "heapDeltaBytes": 23281364,
      "heapUsedBytes": 189124312,
      "domNodes": -8049,
      "jsHeapTotalBytes": -16322560,
      "scriptDurationMs": 903.501,
      "eventListeners": 0,
      "totalBlockingTimeMs": 99,
      "frameDurationMs": 40.391876208897486,
      "p95FrameDurationMs": 83.29999999999927
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6146.591,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 81.119,
      "layouts": 20,
      "layoutDurationMs": 24.451,
      "taskDurationMs": 6092.928,
      "heapDeltaBytes": 1158408,
      "heapUsedBytes": 222038688,
      "domNodes": 0,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 111.679,
      "eventListeners": 0,
      "totalBlockingTimeMs": 454,
      "frameDurationMs": 37.27151515151516,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6239.802999999938,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 83.91799999999999,
      "layouts": 20,
      "layoutDurationMs": 23.638000000000005,
      "taskDurationMs": 6121.201,
      "heapDeltaBytes": -12339044,
      "heapUsedBytes": 209527712,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 107.38699999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 453,
      "frameDurationMs": 35.7264367816092,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8713.787000000026,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8560.461,
      "heapDeltaBytes": -21871536,
      "heapUsedBytes": 195472256,
      "domNodes": -3045,
      "jsHeapTotalBytes": 6471680,
      "scriptDurationMs": 171.8700000000001,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 31.750729927007303,
      "p95FrameDurationMs": 66.60000000000218
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6765.299000000027,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6572.733000000001,
      "heapDeltaBytes": -10778288,
      "heapUsedBytes": 165860720,
      "domNodes": 0,
      "jsHeapTotalBytes": -31195136,
      "scriptDurationMs": 116.89699999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 23.766197183098587,
      "p95FrameDurationMs": 50
    },
    {
      "name": "workflow-execution",
      "durationMs": 163.40999999999894,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 12.457999999999998,
      "layouts": 3,
      "layoutDurationMs": 1.536,
      "taskDurationMs": 107.36899999999999,
      "heapDeltaBytes": -16898512,
      "heapUsedBytes": 80191184,
      "domNodes": 117,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 11.258000000000001,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.75,
      "p95FrameDurationMs": 33.30000000000018
    },
    {
      "name": "workflow-execution",
      "durationMs": 147.94000000006235,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 18.124000000000002,
      "layouts": 5,
      "layoutDurationMs": 1.828,
      "taskDurationMs": 117.13799999999999,
      "heapDeltaBytes": -16673720,
      "heapUsedBytes": 80195856,
      "domNodes": 119,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 8.389,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.677777777777717,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 1004.6489999999721,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 113.73400000000001,
      "layouts": 76,
      "layoutDurationMs": 24.796,
      "taskDurationMs": 965.388,
      "heapDeltaBytes": 19070948,
      "heapUsedBytes": 91679848,
      "domNodes": 76,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 400.75300000000004,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 1034.2180000000099,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 115.85,
      "layouts": 76,
      "layoutDurationMs": 26.505000000000003,
      "taskDurationMs": 1003.4589999999998,
      "heapDeltaBytes": 19213184,
      "heapUsedBytes": 91144712,
      "domNodes": 76,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 411.3,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666129032258052,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1436.9819999999436,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 263.629,
      "layouts": 76,
      "layoutDurationMs": 26.423,
      "taskDurationMs": 1414.123,
      "heapDeltaBytes": 8823924,
      "heapUsedBytes": 115192224,
      "domNodes": 76,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 478.97299999999996,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.563291139240505,
      "p95FrameDurationMs": 33.30000000000109
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1422.6639999999406,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 248.141,
      "layouts": 76,
      "layoutDurationMs": 25.378999999999998,
      "taskDurationMs": 1394.5949999999998,
      "heapDeltaBytes": 9059548,
      "heapUsedBytes": 115833324,
      "domNodes": 76,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 468.52500000000003,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.682926829268293,
      "p95FrameDurationMs": 33.29999999999927
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 52934 80623 65.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1151
src/LGraphNode.ts 70.2% 388
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.1% 330
src/LGraph.ts 78.9% 269
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/core/billing/operationLifecycle.ts 1.2% 252
src/scripts/app.ts 73.1% 252
src/core/webSessionIdentity.ts 3.4% 224

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 29, 2026
@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...-web/src/components/fullPage/SavedMethodSelect.vue 77.27% 0 Missing and 5 partials ⚠️
...g-web/src/components/fullPage/SavedMethodPanel.vue 50.00% 0 Missing and 1 partial ⚠️
@@                             Coverage Diff                             @@
##           jaewon/fe-3018-full-page-checkout-shell   #19374      +/-   ##
===========================================================================
- Coverage                                    84.32%   84.10%   -0.22%     
===========================================================================
  Files                                         3260     3260              
  Lines                                       158322   159043     +721     
  Branches                                     41276    41241      -35     
===========================================================================
+ Hits                                        133502   133766     +264     
- Misses                                       23061    23536     +475     
+ Partials                                      1759     1741      -18     
Flag Coverage Δ
billing-web-unit 91.68% <83.33%> (-0.18%) ⬇️
e2e 65.67% <ø> (-0.01%) ⬇️
website-unit 78.72% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/billing-web/src/checkout/summaryLedger.ts 98.73% <100.00%> (+0.04%) ⬆️
.../src/components/fullPage/CheckoutPaymentColumn.vue 96.61% <100.00%> (ø)
...ng-web/src/components/fullPage/PaymentTabsRail.vue 100.00% <ø> (ø)
...src/components/fullPage/summary/CheckoutLedger.vue 97.05% <100.00%> (ø)
...ccount-ui/src/billing/stripe/StripePaymentForm.vue 85.58% <ø> (-0.26%) ⬇️
...g-web/src/components/fullPage/SavedMethodPanel.vue 80.00% <50.00%> (-4.62%) ⬇️
...-web/src/components/fullPage/SavedMethodSelect.vue 77.27% <77.27%> (ø)

... and 46 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The summary keeps the server quote authoritative, preserves the existing commitment through its named date, and gives saved methods a correctly labelled full-page selector without changing embedded form semantics.

@dante01yoon
dante01yoon merged commit d4356b9 into jaewon/fe-3018-full-page-checkout-shell Sep 29, 2026
157 of 159 checks passed
@dante01yoon
dante01yoon deleted the jaewon/fe-3019-m3-design-review-summary branch September 29, 2026 17:46
dante01yoon added a commit that referenced this pull request Sep 29, 2026
…e-check failure body (#19487)

## Summary

Applies two decisions from Alex Tov (design, 2026-09-29 18:21 and 18:33
EDT) to two endings added in #19462 and #19376: the scheduled-change
refusal names its plan like the rest of checkout, and the failed payment
re-check becomes the Couldn't load ending with its own body.

## Changes

- **Why**: Alex asked for the SUBSCRIPTION_CHANGE_IN_PROGRESS refusal to
read "Pro" / "Pro Yearly" with a full date, matching the summary (Figma
643-14661). He also asked for the re-check failure to be the same
"Couldn't load your checkout" screen as the quote-load failure, with
only the body changed (Figma 677-14662).
- **Root cause**: the refusal named the plan through
`useHostedCopy().planName`, the settings panel's "{tier} · {duration}"
format, rather than the summary's naming. The re-check failure was a
distinct page kind (`recheck_failed`) and a distinct ending, although it
differs from the quote-load failure only in copy.
- **How**:
- `summaryLedger.ts` exports `namedPlan`, the naming the summary's
"You'll keep {plan} until {date}" line already used. The refusal calls
it with the cadence shown only for yearly, so a monthly change reads
"Pro" and a yearly one "Pro Yearly". The date was already `longDate`
(full month, UTC), and a test now covers that.
- `recheck_failed` is gone from both the page and the ending. The page's
`unavailable` now carries `cause: 'quote' | 'recheck'`. The
`recheckFailed` event still names the re-check, and it lands on
`unavailable` with `cause: 'recheck'`. `load_failed` picks `body.quote`
or `body.recheck`, and Try again handles both causes the same way,
re-running the re-check and the quote. `ending.recheck_failed.*` is
removed and `ending.load_failed.body` is split by cause.

| Item | Commit |
| --- | --- |
| 1. Scheduled-change plan/date format | 07d4adb `fix(billing-web):
name a scheduled change's plan the way the summary names a kept plan` |
| 2. Re-check failure folded into Couldn't load | 5a0dc5d
`fix(billing-web): fold the failed payment re-check into Couldn't load
your checkout` |

The tests went in with each fix because the pre-commit typecheck rejects
a red test commit. I confirmed them red locally first: 11 failing before
either fix.

## Review Focus

- A retry still re-runs the re-check. `retryLoad` calls `reconcile()`
and dispatches `retried`, and `retried` resolves again from any
`unavailable`. That is covered in the view test (recover called twice)
and in e2e (`full-page-endings.spec.ts`, which now also asserts the new
body).
- Stacked on #19462 (in the merge queue). GitHub retargets this PR to
main when that branch is deleted.

Plan position:

| PR | Scope |
| --- | --- |
| #19373 / #19374 / #19376 / #19379 | M3 design review rounds 1-2
(merged) |
| #19462 | M3 design review round 3 (merge queue) |
| **this PR** | **M3 design review round 4: Alex's 2026-09-29
decisions** |

```mermaid
graph LR
  A[round 1-2 merged] --> B[#19462 round 3] --> C[round 4: this PR]
  style C stroke-width:3px
```

## Screenshots (if applicable)

All captures come from the billing-web e2e fixture build (mocked cloud,
dark, 1512×982), labelled **fixture build**. AS IS is df3e0ad (#19462
head).

| Fixture build | AS IS | TO BE |
| --- | --- | --- |
| Scheduled change, monthly (`pro_monthly`) | <img width="756" alt="as
is"
src="https://github.com/user-attachments/assets/eb22b626-1bac-4191-8b4c-cd9dd06465fe"
/> | <img width="756" alt="to be"
src="https://github.com/user-attachments/assets/24e1389b-0fe8-4391-8bad-d63d97924661"
/> |
| Scheduled change, yearly (`pro_yearly`) | <img width="756" alt="as is"
src="https://github.com/user-attachments/assets/0ade37c8-3c6d-48a7-8a0e-d30009a50e59"
/> | <img width="756" alt="to be"
src="https://github.com/user-attachments/assets/2e50f6c5-ccd3-472b-a0ed-ddc557b0d34c"
/> |
| Payment re-check failed | <img width="756" alt="as is"
src="https://github.com/user-attachments/assets/f8ebec6d-4488-41b2-a22d-2242d4e3b65f"
/> | <img width="756" alt="to be"
src="https://github.com/user-attachments/assets/5393a952-c67e-413e-ac05-2b06345afba0"
/> |

Quote-load failure, unchanged, for comparison (fixture build):

<img width="756" alt="quote failed"
src="https://github.com/user-attachments/assets/6c836d94-6cd3-4756-b3b8-85ebd1d450cd"
/>
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 30, 2026
…ming and endings copy (Comfy-Org#19537)

## Summary

Fixes seven items from Alex Tov's UX pass on the M3 full-page checkout
(`billing_web_checkout_ui`): a refused Pay gets the processing-error
card, a $0 total says why, yearly kept plans name their cadence, team
keep-subscription copy follows a period change, and three endings (View
plans, capabilities failure, missing Stripe key) behave per design.

## Changes

- **Why** (Alex's items)
- 13: a coded Pay failure (e.g. a 500 → `REQUEST_FAILED`) rendered as a
bare red `<p role=alert>` with no support path. Figma 314-10612 wants
the "Payment couldn't be processed" card with Contact support.
- 14: a $0 total with no explanation. An upgrade a code takes to $0, or
a $0 new subscription the quote gives no `renewal_at`, got no zero-due
line. Figma 294-8224.
- 15: a yearly→yearly downgrade read "You'll keep Pro until…"; yearly
plans must read "Pro Yearly". Figma 294-8445.
- 17b: team monthly→yearly read "Changing your commitment…" instead of
the switch-to-yearly line.
- 16a: View plans opened the Team tab only for a missing stop; a retired
team plan whose link carries `team_credit_stop_id` went to the default
tab.
- 16b: a failed capabilities read showed the quote body ("We couldn't
load your quote. Nothing has been charged…"). Figma 421-5804.
- 16c: a missing Stripe key ended the whole page. Figma 370-15519 fails
inside the payment column.
- **Root cause**
- 13: `payVerdictOf` had a separate `failure` verdict that bypassed
`InlineOutcome`, so the page threaded a plain `failure` string through
the view, column and pay action beside the card.
- 14: `chargeNowTrailing` gated the zero-due line on `new_subscription`
and a `renewal_at`; the prorated family never had one.
- 15: `keptPlanLine` passed `cadenceChanges` to `namedPlan`, which is
false for yearly→yearly.
  - 17b: `changeOf` checked TEAM→TEAM before the duration change.
- 16a: `viewPlansLink` read only the page's `team_stop_missing` reason,
never the link.
  - 16b: `capabilityStop` emitted the quote's `unavailable` event.
  - 16c: `quotedStop` turned a missing key into an `unavailable` stop.
- **How**
- 13: a coded refusal is now `InlineOutcome { kind: 'processing_error',
code, serverMessage? }`. `payFailed` always carries an outcome; the
`failure` verdict, `payFailure` and the `failure` prop chain are
deleted. The card body goes through `useHostedCopy().refusal`, so the
"show server message" rule (status-only codes, 5xx included) holds
inside the card. Support mail quotes `Error code: <code>`.
- 14: one `zeroDueLine` for every $0 total in `charge_now` and
`prorated_change` (not `scheduled`); dated → existing `zeroDue`, undated
→ new `zeroDueUndated`. Amounts are the quote's `renewal_amount_cents ??
cost_next_period_cents`.
- 15: the kept plan names its cadence when it changes or when it is
yearly.
- 17b: TEAM→TEAM is `commitment` only when the duration is unchanged;
otherwise `to_yearly` / `to_yearly_undated` / `to_monthly`.
- 16a: Team tab when the link carries a stop, or the quote named a team
plan without one.
- 16b: new `capabilitiesFailed` event → `unavailable { cause:
'capabilities' }` with its own body that does not claim nothing was
charged. Title, code and Try again unchanged.
- 16c: the `quoted` event carries `element: 'failed'` when no key
resolved, so the collect rail arrives failed. With no saved method that
is `column_error` (Try again remounts the form, which picks up a key
that arrived); beside saved methods, Saved stays payable. On-file plan
changes never read the key.

## Review Focus

- 16c beside saved methods: the failure stays inside Add new rather than
taking the column, per the existing rail rules (368-15319). Figma
370-15519 shows the no-saved-method case.
- 13 body wording: `REQUEST_FAILED` with a server message shows that
message; without one, billing-web's own copy for the code.

## Screenshots (fixture build)

Taken from the Playwright e2e fixture build (mocked cloud, fake Stripe),
not a real backend. AS IS is `origin/main` source, TO BE is this branch.

| Item | AS IS (fixture build) | TO BE (fixture build) |
| --- | --- | --- |
| 13 Pay failure (500 with a server message) | <img width="640"
alt="item13-asis"
src="https://github.com/user-attachments/assets/6c02c40e-abcc-4d1d-8831-3cb918519a39"
/> | <img width="640" alt="item13-tobe"
src="https://github.com/user-attachments/assets/19fe1596-e731-4381-87d4-583ac0d935bf"
/> |
| 14 upgrade taken to $0 by a code | <img width="640" alt="item14-asis"
src="https://github.com/user-attachments/assets/14e964d2-0b65-4b64-9bf0-9856612fcd0b"
/> | <img width="640" alt="item14-tobe"
src="https://github.com/user-attachments/assets/8891c3d6-af19-4b6a-9e90-83fa75b59c88"
/> |
| 15 yearly to yearly downgrade | <img width="640" alt="item15-asis"
src="https://github.com/user-attachments/assets/7f0c40e6-d57b-4115-b08d-80ad410a895a"
/> | <img width="640" alt="item15-tobe"
src="https://github.com/user-attachments/assets/cb611b3e-ee21-4a4a-8718-c2aef802af7f"
/> |
| 17b team monthly to yearly, plan set to end | <img width="640"
alt="item17b-asis"
src="https://github.com/user-attachments/assets/c83cbc14-2d64-4884-b831-8d2ee4366c25"
/> | <img width="640" alt="item17b-tobe"
src="https://github.com/user-attachments/assets/d0ef591e-f99e-4429-bfc8-aaac3f920ba5"
/> |
| 16b capabilities read failed | <img width="640" alt="item16b-asis"
src="https://github.com/user-attachments/assets/270e6ab8-8c37-4ade-b838-1b49660fe708"
/> | <img width="640" alt="item16b-tobe"
src="https://github.com/user-attachments/assets/d2f03058-e4e7-4ad8-b681-6a3bb95ee57d"
/> |

16a is a URL change, covered by the e2e spec for a retired team plan
whose link carries its commit stop. 16c has no fixture-build screenshot
because the e2e build bakes a Stripe key; the component test `370-15519`
covers it.

## Plan position

| PR | Ticket | Scope |
| --- | --- | --- |
| Comfy-Org#19374 | FE-3019 | summary discounts, kept team commitment, payment
column layout |
| Comfy-Org#19373 | FE-3020 | promo pricing on Pay, unreadable promo links,
expired card on re-reads |
| Comfy-Org#19376 | FE-3021 | ending screens, error-card buttons |
| Comfy-Org#19379 | FE-3022 | payment authentication follow-ups |
| **this PR** | **FE-3021** | **Pay failure card, $0 explanation, yearly
naming, endings copy (items 13-17b)** |

```mermaid
flowchart LR
  R[M3 design review] --> A[FE-3019 Comfy-Org#19374]
  R --> B[FE-3020 Comfy-Org#19373]
  R --> C[FE-3021 Comfy-Org#19376]
  R --> D[FE-3022 Comfy-Org#19379]
  R --> E[FE-3021 items 13-17b]
  style E fill:#f5c518,color:#000
```

## Verification

- Red first: 16 new or changed unit and component tests and 5 new e2e
specs failed on `origin/main` source, pass here.
- `apps/billing-web`: typecheck, lint (eslint + stylelint + oxlint),
vitest 839/839, Playwright 95/95.
- `pnpm knip` clean; `fallow audit --changed-since origin/main`: no new
findings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cloud/1.55 Backport PRs for cloud 1.55 core/1.55 Backport PRs for core 1.55 needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants