Skip to content

FE-3020 fix(billing-web): price an unapplied promo on Pay, keep links with an unreadable promo, show the expired card on re-reads - #19373

Merged
dante01yoon merged 8 commits into
jaewon/fe-3018-full-page-checkout-shellfrom
jaewon/fe-3020-m3-design-review-promo
Sep 29, 2026
Merged

dante01yoon merged 8 commits into
jaewon/fe-3018-full-page-checkout-shellfrom
jaewon/fe-3020-m3-design-review-promo

Conversation

@dante01yoon

@dante01yoon dante01yoon commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Follow-up to design review on #19253 (Alex Tov, FE-3020 "Added 2026-09-28").

Why

Alex's M3 review left promo-code decisions and two promo bugs on the full-page checkout.

Root cause

  • Pay never looked at the promo field, so a typed code that nobody applied was silently dropped from the charge.
  • The capture re-read (back button, sibling tab) called promo.expire() but its quoted event had no field for the lapsed code. The chip vanished with no card and the price changed with no notice.
  • parseBillingEntry refused the whole link when promo failed the identifier charset (SAVE 20), so one bad prefill voided the checkout.
  • The promo field turned its border red on error and used a transparent, 6px-radius field.

How

  • hasUnappliedDraft in promoEntry.ts. pay() applies a typed, unjudged code and returns, so the second Pay charges the re-priced quote. A code Apply already refused does not block Pay.
  • quoted carries expiredPromo. arrived() opens capture on the promo_expired card, which outranks a carried verdict because the price changed.
  • The contract parser carries an unreadable promo as unreadablePromotionCode instead of an error. initialPromoEntry opens it as rejected/invalid with the text as typed. It never enters promotionCode, so it never reaches the checkout return URL. The builder still refuses it.
  • Field: neutral border-interface-stroke, filled bg-input-surface, rounded-lg. Only the text turns red.
Alex's item Status Commit
URL promo opens the field, typed, not applied already correct (#19277)
Unapplied code at Pay: apply, re-price, wait for second Pay fixed d43bcc5 (red), 0400623
Bug 3: expired promo on a self-initiated re-check shows no card fixed e484118 (red), bf187f4
Bug 6: SAVE 20 in the URL breaks the link fixed 3c3a255 (red), f30e13f, bd9c0ae (e2e)
✕ is a ghost icon button, blur never closes, ✕ clears the draft (62-3049) already correct, icon now foreground per Figma 1f77f3d
"We couldn't check this code. Try again." on network/server error (614-14674) already correct (#19278)
Field error: neutral border, red text only, filled, 8px radius (480-4994) fixed 1f77f3d
Lock: Add and chip ✕ disabled during Phase A and processing unchanged, covered by existing tests

Screenshots

All images are from the fixture build: the billing-web Playwright fixtures (apps/billing-web/e2e/fixtures, mocked Cloud and a fake Stripe.js), production vite build, dark theme, 1280px wide unless the row says phone. AS IS is the base jaewon/fe-3018-full-page-checkout-shell @ 2c0d3a1381; TO BE is this PR @ bd9c0aebf8. None are from a real backend.

Item AS IS TO BE
?promo=LAUNCH20: field opens typed, not applied (already correct, same in both) url-code-before-pay AS IS url-code-before-pay TO BE
After the first Pay over that unapplied code. AS IS charged $50 without the code and ended on success; TO BE applies it, re-prices to $40 and waits for a second Pay url-code-after-first-pay AS IS url-code-after-first-pay TO BE
Bug 3: the page re-reads on its own (a watched payment in another tab ends) after LAUNCH20 lapsed expired-on-recheck AS IS expired-on-recheck TO BE
Bug 6: promo=SAVE 20 in the link url-code-unreadable AS IS url-code-unreadable TO BE
Field error: neutral border, red text only, filled, 8px radius (480-4994) field-error AS IS field-error TO BE

Verification

billing-web unit (734), billing-contract unit (78), billing-web Playwright (70, including two new promo specs), typecheck, eslint/oxlint, knip, and fallow audit (no issues in changed files).

@dante01yoon
dante01yoon requested a review from a team as a code owner September 29, 2026 07:07
@dante01yoon dante01yoon added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch core/1.55 Backport PRs for core 1.55 cloud/1.55 Backport PRs for cloud 1.55 labels Sep 29, 2026
@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: c9b81b73-5ca1-4c8c-ab7b-69d1fbd0a6b8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 2c0d3a1381fe2725af9082f7d1fe8013fd2f183b

Full docs: ADR-DEVEX-LINT-0015

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/29/2026, 07:23:44 AM UTC

Links

🎭 Playwright: ✅ 2159 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2138 / ❌ 0 / ⚠️ 0 / ⏭️ 9)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.4 MB heap
canvas-mouse-sweep: · 59.5 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 91.7 MB heap
dom-widget-order-dense-n200-w200-i120: · 27.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 611ms TBT · 79.5 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 39.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 242ms TBT · 85.7 MB heap
extension-clean-combined-draw: · 29.2 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 1482ms TBT · 83.7 MB heap
extension-rgthree-prototype-draw: · 30.3 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 1649ms TBT · 65.8 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.3 MB heap
legacy-node-drag: · 59.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 89.7 MB heap
subgraph-idle: · 59.8 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.0 MB heap
subgraph-transition-enter: · 50.9 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 148ms TBT · 100.1 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.0 MB heap
vue-large-graph-idle: · 34.9 avg FPS · 17.2 P5 FPS ❌ (target: ≥52) · 0ms TBT · 170.3 MB heap
vue-large-graph-pan: · 23.4 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 58ms TBT · 176.1 MB heap
vue-node-resize-workload: · 25.2 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 486ms TBT · 198.8 MB heap
vue-zoom-out-idle: · 30.0 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 172.4 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.8 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.1 MB heap
agent-composer-long-conversation-typing: · 54.6 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 110.2 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 5ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 437ms
canvas-idle: script duration 13ms
canvas-idle: TBT 0ms
canvas-idle: heap used 59.4 MB
canvas-idle: DOM nodes -228
canvas-idle: event listeners -142
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 20ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 79
canvas-mouse-sweep: task duration 961ms
canvas-mouse-sweep: script duration 190ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 57.3 MB
canvas-mouse-sweep: DOM nodes -228
canvas-mouse-sweep: event listeners -142
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 12ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 33
canvas-zoom-sweep: task duration 397ms
canvas-zoom-sweep: script duration 16ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 76.5 MB
canvas-zoom-sweep: DOM nodes 53
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 4ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 489ms
dom-widget-clipping: script duration 177ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 91.7 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 37ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 900ms
dom-widget-order-dense-n200-w200-i120: script duration 78ms
dom-widget-order-dense-n200-w200-i120: TBT 611ms
dom-widget-order-dense-n200-w200-i120: heap used 79.5 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 26ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 509ms
dom-widget-order-sparse-n1000-w20-i120: script duration 179ms
dom-widget-order-sparse-n1000-w20-i120: TBT 242ms
dom-widget-order-sparse-n1000-w20-i120: heap used 85.7 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 34ms
extension-clean-combined-draw: p95 frame time 67ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 9678ms
extension-clean-combined-draw: script duration 8000ms
extension-clean-combined-draw: TBT 1482ms
extension-clean-combined-draw: heap used 83.7 MB
extension-clean-combined-draw: DOM nodes 0
extension-clean-combined-draw: event listeners 0
extension-rgthree-prototype-draw: avg frame time 33ms
extension-rgthree-prototype-draw: p95 frame time 67ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 0
extension-rgthree-prototype-draw: task duration 10610ms
extension-rgthree-prototype-draw: script duration 8805ms
extension-rgthree-prototype-draw: TBT 1649ms
extension-rgthree-prototype-draw: heap used 65.8 MB
extension-rgthree-prototype-draw: DOM nodes 0
extension-rgthree-prototype-draw: event listeners 0
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 727ms
large-graph-idle: script duration 42ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 79.0 MB
large-graph-idle: DOM nodes -228
large-graph-idle: event listeners -153
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1679ms
large-graph-pan: script duration 950ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 72.0 MB
large-graph-pan: DOM nodes 0
large-graph-pan: event listeners 0
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 15ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 63
large-graph-zoom: task duration 1865ms
large-graph-zoom: script duration 882ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.3 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 2117ms
legacy-node-drag: script duration 1079ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 63.0 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 652ms
minimap-idle: script duration 38ms
minimap-idle: TBT 0ms
minimap-idle: heap used 79.8 MB
minimap-idle: DOM nodes -228
minimap-idle: event listeners -153
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 8ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 418ms
subgraph-dom-widget-clipping: script duration 157ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 89.7 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 4ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 490ms
subgraph-idle: script duration 12ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 59.8 MB
subgraph-idle: DOM nodes -244
subgraph-idle: event listeners -199
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 7ms
subgraph-mouse-sweep: style recalc duration 22ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 902ms
subgraph-mouse-sweep: script duration 129ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 58.0 MB
subgraph-mouse-sweep: DOM nodes -244
subgraph-mouse-sweep: event listeners -188
subgraph-transition-enter: avg frame time 20ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 17
subgraph-transition-enter: task duration 996ms
subgraph-transition-enter: script duration 34ms
subgraph-transition-enter: TBT 148ms
subgraph-transition-enter: heap used 100.1 MB
subgraph-transition-enter: DOM nodes 13667
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 36ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 6418ms
viewport-pan-sweep: script duration 3074ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 83.0 MB
viewport-pan-sweep: DOM nodes -228
viewport-pan-sweep: event listeners -153
vue-large-graph-idle: avg frame time 29ms
vue-large-graph-idle: p95 frame time 58ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 15072ms
vue-large-graph-idle: script duration 273ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.3 MB
vue-large-graph-idle: DOM nodes -3046
vue-large-graph-idle: event listeners -14915
vue-large-graph-pan: avg frame time 43ms
vue-large-graph-pan: p95 frame time 83ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 21ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 156
vue-large-graph-pan: task duration 21603ms
vue-large-graph-pan: script duration 980ms
vue-large-graph-pan: TBT 58ms
vue-large-graph-pan: heap used 176.1 MB
vue-large-graph-pan: DOM nodes -3045
vue-large-graph-pan: event listeners -14915
vue-node-resize-workload: avg frame time 40ms
vue-node-resize-workload: p95 frame time 83ms
vue-node-resize-workload: layout duration 26ms
vue-node-resize-workload: style recalc duration 86ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6464ms
vue-node-resize-workload: script duration 128ms
vue-node-resize-workload: TBT 486ms
vue-node-resize-workload: heap used 198.8 MB
vue-node-resize-workload: DOM nodes 0
vue-node-resize-workload: event listeners 0
vue-zoom-out-idle: avg frame time 33ms
vue-zoom-out-idle: p95 frame time 67ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8781ms
vue-zoom-out-idle: script duration 145ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 172.4 MB
vue-zoom-out-idle: DOM nodes -1523
vue-zoom-out-idle: event listeners -7458
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 19ms
workflow-execution: layout count 4
workflow-execution: style recalc count 19
workflow-execution: task duration 150ms
workflow-execution: script duration 13ms
workflow-execution: TBT 0ms
workflow-execution: heap used 78.8 MB
workflow-execution: DOM nodes 115
workflow-execution: event listeners 81
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 28ms
agent-composer-empty-conversation-typing: style recalc duration 121ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 78
agent-composer-empty-conversation-typing: task duration 1123ms
agent-composer-empty-conversation-typing: script duration 472ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 76.1 MB
agent-composer-empty-conversation-typing: DOM nodes 76
agent-composer-empty-conversation-typing: event listeners 876
agent-composer-long-conversation-typing: avg frame time 18ms
agent-composer-long-conversation-typing: p95 frame time 33ms
agent-composer-long-conversation-typing: layout duration 27ms
agent-composer-long-conversation-typing: style recalc duration 262ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 78
agent-composer-long-conversation-typing: task duration 1435ms
agent-composer-long-conversation-typing: script duration 480ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 110.2 MB
agent-composer-long-conversation-typing: DOM nodes 76
agent-composer-long-conversation-typing: event listeners 876
Raw data
{
  "timestamp": "2026-09-29T07:32:17.966Z",
  "gitSha": "5fe980494386b3fb6142a92f6ab82ab286fc92c2",
  "branch": "jaewon/fe-3020-m3-design-review-promo",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2025.2999999999588,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 4.7749999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 425.412,
      "heapDeltaBytes": -16360724,
      "heapUsedBytes": 62409332,
      "domNodes": -228,
      "jsHeapTotalBytes": -524288,
      "scriptDurationMs": 13.097999999999999,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2038.8269999999693,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.293000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 448.401,
      "heapDeltaBytes": -36479024,
      "heapUsedBytes": 62063500,
      "domNodes": -228,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 13.142999999999999,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1926.10099999996,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 20.984,
      "layouts": 12,
      "layoutDurationMs": 5.535,
      "taskDurationMs": 933.463,
      "heapDeltaBytes": -37439308,
      "heapUsedBytes": 60639572,
      "domNodes": -228,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 187.532,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.81228070175439,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1942.4400000000333,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 19.957999999999995,
      "layouts": 12,
      "layoutDurationMs": 5.11,
      "taskDurationMs": 988.479,
      "heapDeltaBytes": -39050976,
      "heapUsedBytes": 59596724,
      "domNodes": -228,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 191.601,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.811304347826088,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1750.5739999999719,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 12.074,
      "layouts": 6,
      "layoutDurationMs": 1.3699999999999999,
      "taskDurationMs": 385.656,
      "heapDeltaBytes": 2002764,
      "heapUsedBytes": 80845868,
      "domNodes": 53,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 15.645000000000003,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66571428571429,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1759.992000000011,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 11.538000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.2360000000000002,
      "taskDurationMs": 407.86400000000003,
      "heapDeltaBytes": -18570896,
      "heapUsedBytes": 79516276,
      "domNodes": 53,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 15.857,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665714285714284,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 753.4739999999829,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 4.668000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 482.689,
      "heapDeltaBytes": 18279120,
      "heapUsedBytes": 97113384,
      "domNodes": 0,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 178.29,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664444444444435,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 757.2129999999788,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 4.1770000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 495.918,
      "heapDeltaBytes": -2819784,
      "heapUsedBytes": 95191092,
      "domNodes": 0,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 176.38299999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1191.9900000000325,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 832.5760000000001,
      "heapDeltaBytes": 9105596,
      "heapUsedBytes": 84995340,
      "domNodes": 0,
      "jsHeapTotalBytes": 4620288,
      "scriptDurationMs": 74.40100000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 581,
      "frameDurationMs": 36.36060606060605,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1286.143999999922,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 968.2259999999999,
      "heapDeltaBytes": 6125656,
      "heapUsedBytes": 81751728,
      "domNodes": 0,
      "jsHeapTotalBytes": 5144576,
      "scriptDurationMs": 80.73300000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 640,
      "frameDurationMs": 36.662857142857135,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 877.3429999999962,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 510.6249999999992,
      "heapDeltaBytes": 16703152,
      "heapUsedBytes": 90312248,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 182.60500000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 240,
      "frameDurationMs": 25.237142857142835,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 877.6040000000194,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 506.69899999999933,
      "heapDeltaBytes": 15924228,
      "heapUsedBytes": 89490928,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 175.303,
      "eventListeners": 0,
      "totalBlockingTimeMs": 244,
      "frameDurationMs": 25.982352941176458,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 11555.444999999963,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10480.231,
      "heapDeltaBytes": 3569384,
      "heapUsedBytes": 83728672,
      "domNodes": 0,
      "jsHeapTotalBytes": -15466496,
      "scriptDurationMs": 8549.724,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1731,
      "frameDurationMs": 33.869501466275665,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9751.221999999983,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8876.12,
      "heapDeltaBytes": 11643100,
      "heapUsedBytes": 91765736,
      "domNodes": 0,
      "jsHeapTotalBytes": -13631488,
      "scriptDurationMs": 7450.6230000000005,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1233,
      "frameDurationMs": 34.695729537366546,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 11483.011999999973,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10400.410000000002,
      "heapDeltaBytes": -12219800,
      "heapUsedBytes": 68424552,
      "domNodes": 0,
      "jsHeapTotalBytes": -8126464,
      "scriptDurationMs": 8636.552,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1575,
      "frameDurationMs": 32.667236467236464,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 11945.474999999988,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10819.122,
      "heapDeltaBytes": -10862472,
      "heapUsedBytes": 69480520,
      "domNodes": 0,
      "jsHeapTotalBytes": -14155776,
      "scriptDurationMs": 8972.514000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1723,
      "frameDurationMs": 33.37849162011173,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2066.7490000000157,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.003000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 739.2250000000001,
      "heapDeltaBytes": -35891756,
      "heapUsedBytes": 82627896,
      "domNodes": -228,
      "jsHeapTotalBytes": -360448,
      "scriptDurationMs": 41.42,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2047.3440000000664,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 3.032,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 713.9340000000001,
      "heapDeltaBytes": -36092692,
      "heapUsedBytes": 82979732,
      "domNodes": -228,
      "jsHeapTotalBytes": -360448,
      "scriptDurationMs": 41.604,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2869.5390000000316,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 10.176,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1650.4339999999997,
      "heapDeltaBytes": 24216124,
      "heapUsedBytes": 87729708,
      "domNodes": 0,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 939.0939999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666081871345032,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3076.779999999985,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 10.249999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1707.605,
      "heapDeltaBytes": 383224,
      "heapUsedBytes": 63326144,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 960.736,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66576086956522,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3890.1290000000017,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 11.474000000000002,
      "layouts": 60,
      "layoutDurationMs": 14.581999999999999,
      "taskDurationMs": 1809.0699999999997,
      "heapDeltaBytes": 12812248,
      "heapUsedBytes": 78390652,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 853.558,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66609442060086,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3947.443999999905,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 12.077999999999998,
      "layouts": 60,
      "layoutDurationMs": 15.617999999999999,
      "taskDurationMs": 1920.8590000000002,
      "heapDeltaBytes": 13400608,
      "heapUsedBytes": 77474184,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 911.089,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665822784810125,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3198.847999999998,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 5.918000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2117.331,
      "heapDeltaBytes": 2694360,
      "heapUsedBytes": 66563612,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 1079.4969999999998,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.842328042328045,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3180.430000000001,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.6000000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2116.8140000000003,
      "heapDeltaBytes": 831156,
      "heapUsedBytes": 65635812,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 1078.1569999999997,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.843085106382983,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2043.9850000000206,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.268000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 648.15,
      "heapDeltaBytes": -37307524,
      "heapUsedBytes": 83685592,
      "domNodes": -228,
      "jsHeapTotalBytes": -360448,
      "scriptDurationMs": 37.61299999999999,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2051.1860000000297,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 2.536,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 656.815,
      "heapDeltaBytes": -37790128,
      "heapUsedBytes": 83654604,
      "domNodes": -228,
      "jsHeapTotalBytes": -98304,
      "scriptDurationMs": 38.05299999999999,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66585365853659,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 600.6699999999796,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 8.38,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 395.37,
      "heapDeltaBytes": 12711212,
      "heapUsedBytes": 94036852,
      "domNodes": 0,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 155.312,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 692.3949999999195,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 7.259999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 440.07599999999996,
      "heapDeltaBytes": 13278532,
      "heapUsedBytes": 94155624,
      "domNodes": 0,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 158.39000000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66341463414634,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2049.925999999971,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 4.149000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 533.748,
      "heapDeltaBytes": -13580360,
      "heapUsedBytes": 67733852,
      "domNodes": -244,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 11.559999999999997,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.80245901639344,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2036.3290000000234,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.715999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 446.2480000000001,
      "heapDeltaBytes": -21841876,
      "heapUsedBytes": 57740340,
      "domNodes": -244,
      "jsHeapTotalBytes": -1835008,
      "scriptDurationMs": 12.809000000000001,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1793.3440000000473,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 22.118,
      "layouts": 16,
      "layoutDurationMs": 7.01,
      "taskDurationMs": 905.26,
      "heapDeltaBytes": -20402112,
      "heapUsedBytes": 60884160,
      "domNodes": -244,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 129.70000000000002,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66542056074767,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1798.3669999999847,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 21.728,
      "layouts": 16,
      "layoutDurationMs": 6.485,
      "taskDurationMs": 899.437,
      "heapDeltaBytes": -20076572,
      "heapUsedBytes": 60647344,
      "domNodes": -244,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 128.382,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1420.3190000000632,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 30.89399999999999,
      "layouts": 5,
      "layoutDurationMs": 13.669,
      "taskDurationMs": 996.151,
      "heapDeltaBytes": 23204588,
      "heapUsedBytes": 104964456,
      "domNodes": 13667,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 33.923,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 148,
      "frameDurationMs": 19.632876712328752,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9796.20699999998,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 35.318,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6288.721,
      "heapDeltaBytes": -34975480,
      "heapUsedBytes": 83605736,
      "domNodes": -228,
      "jsHeapTotalBytes": -430080,
      "scriptDurationMs": 2977.1899999999996,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66609880749574,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 10354.683999999907,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 36.467,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6546.503,
      "heapDeltaBytes": -29025552,
      "heapUsedBytes": 90528160,
      "domNodes": -228,
      "jsHeapTotalBytes": 1667072,
      "scriptDurationMs": 3170.3160000000003,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666022544283415,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 13460.759000000053,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12971.889000000001,
      "heapDeltaBytes": -14395856,
      "heapUsedBytes": 189927020,
      "domNodes": -3045,
      "jsHeapTotalBytes": 8355840,
      "scriptDurationMs": 246.66100000000003,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 24.102867383512542,
      "p95FrameDurationMs": 49.900000000001455
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17509.159999999953,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17172.810999999998,
      "heapDeltaBytes": -38220452,
      "heapUsedBytes": 167123232,
      "domNodes": -3046,
      "jsHeapTotalBytes": 5255168,
      "scriptDurationMs": 298.37199999999996,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 33.17424242424243,
      "p95FrameDurationMs": 66.60000000000218
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21876.38899999996,
      "styleRecalcs": 156,
      "styleRecalcDurationMs": 20.79299999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21733.331,
      "heapDeltaBytes": -20013116,
      "heapUsedBytes": 178819496,
      "domNodes": -3045,
      "jsHeapTotalBytes": 9609216,
      "scriptDurationMs": 1032.9859999999999,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 63,
      "frameDurationMs": 43.384325396825396,
      "p95FrameDurationMs": 83.40000000000146
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21720.169000000056,
      "styleRecalcs": 156,
      "styleRecalcDurationMs": 20.89200000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21472.752,
      "heapDeltaBytes": -13540680,
      "heapUsedBytes": 190497588,
      "domNodes": -3045,
      "jsHeapTotalBytes": 6496256,
      "scriptDurationMs": 926.203,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 52,
      "frameDurationMs": 42.16660194174758,
      "p95FrameDurationMs": 83.40000000000146
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6599.608999999987,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 87.51500000000001,
      "layouts": 20,
      "layoutDurationMs": 27.378999999999987,
      "taskDurationMs": 6565.513,
      "heapDeltaBytes": 836120,
      "heapUsedBytes": 198617648,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 131.18800000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 498,
      "frameDurationMs": 40.992546583850924,
      "p95FrameDurationMs": 83.29999999999927
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6429.347000000007,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 85.26699999999998,
      "layouts": 20,
      "layoutDurationMs": 25.375000000000007,
      "taskDurationMs": 6361.524,
      "heapDeltaBytes": 14635440,
      "heapUsedBytes": 218193768,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 125.22699999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 473,
      "frameDurationMs": 38.52155688622755,
      "p95FrameDurationMs": 83.29999999999927
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9025.263999999992,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8887.968,
      "heapDeltaBytes": -41761524,
      "heapUsedBytes": 185404248,
      "domNodes": -3045,
      "jsHeapTotalBytes": 8855552,
      "scriptDurationMs": 148.00999999999996,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 34.60919540229885,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8889.03300000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8673.073999999999,
      "heapDeltaBytes": -22903468,
      "heapUsedBytes": 176095064,
      "domNodes": 0,
      "jsHeapTotalBytes": -28835840,
      "scriptDurationMs": 142.85400000000004,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 32.068231046931416,
      "p95FrameDurationMs": 66.60000000000218
    },
    {
      "name": "workflow-execution",
      "durationMs": 472.57600000000366,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 16.781000000000002,
      "layouts": 3,
      "layoutDurationMs": 1.0719999999999998,
      "taskDurationMs": 138.791,
      "heapDeltaBytes": -14352800,
      "heapUsedBytes": 82357680,
      "domNodes": 104,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 12.566,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665517241379284,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 521.0930000000644,
      "styleRecalcs": 23,
      "styleRecalcDurationMs": 21.652,
      "layouts": 5,
      "layoutDurationMs": 2.155,
      "taskDurationMs": 160.63499999999996,
      "heapDeltaBytes": -14286780,
      "heapUsedBytes": 82940488,
      "domNodes": 126,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 13.834,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66451612903227,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 1128.1540000001087,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 120.99600000000001,
      "layouts": 76,
      "layoutDurationMs": 27.986,
      "taskDurationMs": 1101.966,
      "heapDeltaBytes": 20157364,
      "heapUsedBytes": 92235236,
      "domNodes": 76,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 468.463,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666176470588226,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 1169.6890000000622,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 120.061,
      "layouts": 76,
      "layoutDurationMs": 27.382,
      "taskDurationMs": 1143.141,
      "heapDeltaBytes": -4570876,
      "heapUsedBytes": 67455872,
      "domNodes": 76,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 476.173,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66571428571429,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1487.0959999999513,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 271.552,
      "layouts": 76,
      "layoutDurationMs": 27.923,
      "taskDurationMs": 1462.097,
      "heapDeltaBytes": 9009972,
      "heapUsedBytes": 115357568,
      "domNodes": 76,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 491.124,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.495121951219517,
      "p95FrameDurationMs": 33.30000000000109
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1428.2669999998916,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 253.4,
      "layouts": 76,
      "layoutDurationMs": 26.095,
      "taskDurationMs": 1407.134,
      "heapDeltaBytes": 9020068,
      "heapUsedBytes": 115788256,
      "domNodes": 76,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 468.05400000000003,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.106172839506176,
      "p95FrameDurationMs": 33.29999999999927
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 52916 80623 65.6% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1151
src/LGraphNode.ts 70.2% 388
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.1% 330
src/LGraph.ts 78.9% 269
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/core/billing/operationLifecycle.ts 1.2% 252
src/scripts/app.ts 73.1% 252
src/core/webSessionIdentity.ts 3.4% 224

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 29, 2026
@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                             Coverage Diff                             @@
##           jaewon/fe-3018-full-page-checkout-shell   #19373      +/-   ##
===========================================================================
- Coverage                                    84.32%   84.30%   -0.02%     
===========================================================================
  Files                                         3260     3257       -3     
  Lines                                       158322   157961     -361     
  Branches                                     41276    41218      -58     
===========================================================================
- Hits                                        133502   133171     -331     
+ Misses                                       23061    23057       -4     
+ Partials                                      1759     1733      -26     
Flag Coverage Δ
billing-web-unit 91.94% <100.00%> (+0.08%) ⬆️
e2e 65.65% <ø> (-0.03%) ⬇️
unit 81.51% <100.00%> (-0.04%) ⬇️
website-unit 78.72% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/billing-web/src/checkout/checkoutPage.ts 98.60% <100.00%> (+0.01%) ⬆️
apps/billing-web/src/checkout/promoEntry.ts 100.00% <100.00%> (ø)
...src/components/fullPage/summary/PromoCodeField.vue 90.90% <ø> (-0.76%) ⬇️
...ps/billing-web/src/composables/useCheckoutPromo.ts 82.75% <100.00%> (+0.61%) ⬆️
...billing-web/src/composables/useFullPageCheckout.ts 95.95% <100.00%> (+0.55%) ⬆️
packages/billing-contract/src/entryFields.ts 100.00% <ø> (ø)
packages/billing-contract/src/entryParser.ts 100.00% <100.00%> (ø)

... and 61 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Promo handling remains server-priced: an unapplied code requires a quote before Pay can charge, unreadable input is displayed as refused without reaching the API, and a lapsed applied code produces an explicit repriced state.

@dante01yoon
dante01yoon merged commit 92e7d8a into jaewon/fe-3018-full-page-checkout-shell Sep 29, 2026
162 of 167 checks passed
@dante01yoon
dante01yoon deleted the jaewon/fe-3020-m3-design-review-promo branch September 29, 2026 17:46
dante01yoon added a commit that referenced this pull request Sep 29, 2026
…e-check failure body (#19487)

## Summary

Applies two decisions from Alex Tov (design, 2026-09-29 18:21 and 18:33
EDT) to two endings added in #19462 and #19376: the scheduled-change
refusal names its plan like the rest of checkout, and the failed payment
re-check becomes the Couldn't load ending with its own body.

## Changes

- **Why**: Alex asked for the SUBSCRIPTION_CHANGE_IN_PROGRESS refusal to
read "Pro" / "Pro Yearly" with a full date, matching the summary (Figma
643-14661). He also asked for the re-check failure to be the same
"Couldn't load your checkout" screen as the quote-load failure, with
only the body changed (Figma 677-14662).
- **Root cause**: the refusal named the plan through
`useHostedCopy().planName`, the settings panel's "{tier} · {duration}"
format, rather than the summary's naming. The re-check failure was a
distinct page kind (`recheck_failed`) and a distinct ending, although it
differs from the quote-load failure only in copy.
- **How**:
- `summaryLedger.ts` exports `namedPlan`, the naming the summary's
"You'll keep {plan} until {date}" line already used. The refusal calls
it with the cadence shown only for yearly, so a monthly change reads
"Pro" and a yearly one "Pro Yearly". The date was already `longDate`
(full month, UTC), and a test now covers that.
- `recheck_failed` is gone from both the page and the ending. The page's
`unavailable` now carries `cause: 'quote' | 'recheck'`. The
`recheckFailed` event still names the re-check, and it lands on
`unavailable` with `cause: 'recheck'`. `load_failed` picks `body.quote`
or `body.recheck`, and Try again handles both causes the same way,
re-running the re-check and the quote. `ending.recheck_failed.*` is
removed and `ending.load_failed.body` is split by cause.

| Item | Commit |
| --- | --- |
| 1. Scheduled-change plan/date format | 07d4adb `fix(billing-web):
name a scheduled change's plan the way the summary names a kept plan` |
| 2. Re-check failure folded into Couldn't load | 5a0dc5d
`fix(billing-web): fold the failed payment re-check into Couldn't load
your checkout` |

The tests went in with each fix because the pre-commit typecheck rejects
a red test commit. I confirmed them red locally first: 11 failing before
either fix.

## Review Focus

- A retry still re-runs the re-check. `retryLoad` calls `reconcile()`
and dispatches `retried`, and `retried` resolves again from any
`unavailable`. That is covered in the view test (recover called twice)
and in e2e (`full-page-endings.spec.ts`, which now also asserts the new
body).
- Stacked on #19462 (in the merge queue). GitHub retargets this PR to
main when that branch is deleted.

Plan position:

| PR | Scope |
| --- | --- |
| #19373 / #19374 / #19376 / #19379 | M3 design review rounds 1-2
(merged) |
| #19462 | M3 design review round 3 (merge queue) |
| **this PR** | **M3 design review round 4: Alex's 2026-09-29
decisions** |

```mermaid
graph LR
  A[round 1-2 merged] --> B[#19462 round 3] --> C[round 4: this PR]
  style C stroke-width:3px
```

## Screenshots (if applicable)

All captures come from the billing-web e2e fixture build (mocked cloud,
dark, 1512×982), labelled **fixture build**. AS IS is df3e0ad (#19462
head).

| Fixture build | AS IS | TO BE |
| --- | --- | --- |
| Scheduled change, monthly (`pro_monthly`) | <img width="756" alt="as
is"
src="https://github.com/user-attachments/assets/eb22b626-1bac-4191-8b4c-cd9dd06465fe"
/> | <img width="756" alt="to be"
src="https://github.com/user-attachments/assets/24e1389b-0fe8-4391-8bad-d63d97924661"
/> |
| Scheduled change, yearly (`pro_yearly`) | <img width="756" alt="as is"
src="https://github.com/user-attachments/assets/0ade37c8-3c6d-48a7-8a0e-d30009a50e59"
/> | <img width="756" alt="to be"
src="https://github.com/user-attachments/assets/2e50f6c5-ccd3-472b-a0ed-ddc557b0d34c"
/> |
| Payment re-check failed | <img width="756" alt="as is"
src="https://github.com/user-attachments/assets/f8ebec6d-4488-41b2-a22d-2242d4e3b65f"
/> | <img width="756" alt="to be"
src="https://github.com/user-attachments/assets/5393a952-c67e-413e-ac05-2b06345afba0"
/> |

Quote-load failure, unchanged, for comparison (fixture build):

<img width="756" alt="quote failed"
src="https://github.com/user-attachments/assets/6c836d94-6cd3-4756-b3b8-85ebd1d450cd"
/>
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 30, 2026
…ming and endings copy (Comfy-Org#19537)

## Summary

Fixes seven items from Alex Tov's UX pass on the M3 full-page checkout
(`billing_web_checkout_ui`): a refused Pay gets the processing-error
card, a $0 total says why, yearly kept plans name their cadence, team
keep-subscription copy follows a period change, and three endings (View
plans, capabilities failure, missing Stripe key) behave per design.

## Changes

- **Why** (Alex's items)
- 13: a coded Pay failure (e.g. a 500 → `REQUEST_FAILED`) rendered as a
bare red `<p role=alert>` with no support path. Figma 314-10612 wants
the "Payment couldn't be processed" card with Contact support.
- 14: a $0 total with no explanation. An upgrade a code takes to $0, or
a $0 new subscription the quote gives no `renewal_at`, got no zero-due
line. Figma 294-8224.
- 15: a yearly→yearly downgrade read "You'll keep Pro until…"; yearly
plans must read "Pro Yearly". Figma 294-8445.
- 17b: team monthly→yearly read "Changing your commitment…" instead of
the switch-to-yearly line.
- 16a: View plans opened the Team tab only for a missing stop; a retired
team plan whose link carries `team_credit_stop_id` went to the default
tab.
- 16b: a failed capabilities read showed the quote body ("We couldn't
load your quote. Nothing has been charged…"). Figma 421-5804.
- 16c: a missing Stripe key ended the whole page. Figma 370-15519 fails
inside the payment column.
- **Root cause**
- 13: `payVerdictOf` had a separate `failure` verdict that bypassed
`InlineOutcome`, so the page threaded a plain `failure` string through
the view, column and pay action beside the card.
- 14: `chargeNowTrailing` gated the zero-due line on `new_subscription`
and a `renewal_at`; the prorated family never had one.
- 15: `keptPlanLine` passed `cadenceChanges` to `namedPlan`, which is
false for yearly→yearly.
  - 17b: `changeOf` checked TEAM→TEAM before the duration change.
- 16a: `viewPlansLink` read only the page's `team_stop_missing` reason,
never the link.
  - 16b: `capabilityStop` emitted the quote's `unavailable` event.
  - 16c: `quotedStop` turned a missing key into an `unavailable` stop.
- **How**
- 13: a coded refusal is now `InlineOutcome { kind: 'processing_error',
code, serverMessage? }`. `payFailed` always carries an outcome; the
`failure` verdict, `payFailure` and the `failure` prop chain are
deleted. The card body goes through `useHostedCopy().refusal`, so the
"show server message" rule (status-only codes, 5xx included) holds
inside the card. Support mail quotes `Error code: <code>`.
- 14: one `zeroDueLine` for every $0 total in `charge_now` and
`prorated_change` (not `scheduled`); dated → existing `zeroDue`, undated
→ new `zeroDueUndated`. Amounts are the quote's `renewal_amount_cents ??
cost_next_period_cents`.
- 15: the kept plan names its cadence when it changes or when it is
yearly.
- 17b: TEAM→TEAM is `commitment` only when the duration is unchanged;
otherwise `to_yearly` / `to_yearly_undated` / `to_monthly`.
- 16a: Team tab when the link carries a stop, or the quote named a team
plan without one.
- 16b: new `capabilitiesFailed` event → `unavailable { cause:
'capabilities' }` with its own body that does not claim nothing was
charged. Title, code and Try again unchanged.
- 16c: the `quoted` event carries `element: 'failed'` when no key
resolved, so the collect rail arrives failed. With no saved method that
is `column_error` (Try again remounts the form, which picks up a key
that arrived); beside saved methods, Saved stays payable. On-file plan
changes never read the key.

## Review Focus

- 16c beside saved methods: the failure stays inside Add new rather than
taking the column, per the existing rail rules (368-15319). Figma
370-15519 shows the no-saved-method case.
- 13 body wording: `REQUEST_FAILED` with a server message shows that
message; without one, billing-web's own copy for the code.

## Screenshots (fixture build)

Taken from the Playwright e2e fixture build (mocked cloud, fake Stripe),
not a real backend. AS IS is `origin/main` source, TO BE is this branch.

| Item | AS IS (fixture build) | TO BE (fixture build) |
| --- | --- | --- |
| 13 Pay failure (500 with a server message) | <img width="640"
alt="item13-asis"
src="https://github.com/user-attachments/assets/6c02c40e-abcc-4d1d-8831-3cb918519a39"
/> | <img width="640" alt="item13-tobe"
src="https://github.com/user-attachments/assets/19fe1596-e731-4381-87d4-583ac0d935bf"
/> |
| 14 upgrade taken to $0 by a code | <img width="640" alt="item14-asis"
src="https://github.com/user-attachments/assets/14e964d2-0b65-4b64-9bf0-9856612fcd0b"
/> | <img width="640" alt="item14-tobe"
src="https://github.com/user-attachments/assets/8891c3d6-af19-4b6a-9e90-83fa75b59c88"
/> |
| 15 yearly to yearly downgrade | <img width="640" alt="item15-asis"
src="https://github.com/user-attachments/assets/7f0c40e6-d57b-4115-b08d-80ad410a895a"
/> | <img width="640" alt="item15-tobe"
src="https://github.com/user-attachments/assets/cb611b3e-ee21-4a4a-8718-c2aef802af7f"
/> |
| 17b team monthly to yearly, plan set to end | <img width="640"
alt="item17b-asis"
src="https://github.com/user-attachments/assets/c83cbc14-2d64-4884-b831-8d2ee4366c25"
/> | <img width="640" alt="item17b-tobe"
src="https://github.com/user-attachments/assets/d0ef591e-f99e-4429-bfc8-aaac3f920ba5"
/> |
| 16b capabilities read failed | <img width="640" alt="item16b-asis"
src="https://github.com/user-attachments/assets/270e6ab8-8c37-4ade-b838-1b49660fe708"
/> | <img width="640" alt="item16b-tobe"
src="https://github.com/user-attachments/assets/d2f03058-e4e7-4ad8-b681-6a3bb95ee57d"
/> |

16a is a URL change, covered by the e2e spec for a retired team plan
whose link carries its commit stop. 16c has no fixture-build screenshot
because the e2e build bakes a Stripe key; the component test `370-15519`
covers it.

## Plan position

| PR | Ticket | Scope |
| --- | --- | --- |
| Comfy-Org#19374 | FE-3019 | summary discounts, kept team commitment, payment
column layout |
| Comfy-Org#19373 | FE-3020 | promo pricing on Pay, unreadable promo links,
expired card on re-reads |
| Comfy-Org#19376 | FE-3021 | ending screens, error-card buttons |
| Comfy-Org#19379 | FE-3022 | payment authentication follow-ups |
| **this PR** | **FE-3021** | **Pay failure card, $0 explanation, yearly
naming, endings copy (items 13-17b)** |

```mermaid
flowchart LR
  R[M3 design review] --> A[FE-3019 Comfy-Org#19374]
  R --> B[FE-3020 Comfy-Org#19373]
  R --> C[FE-3021 Comfy-Org#19376]
  R --> D[FE-3022 Comfy-Org#19379]
  R --> E[FE-3021 items 13-17b]
  style E fill:#f5c518,color:#000
```

## Verification

- Red first: 16 new or changed unit and component tests and 5 new e2e
specs failed on `origin/main` source, pass here.
- `apps/billing-web`: typecheck, lint (eslint + stylelint + oxlint),
vitest 839/839, Playwright 95/95.
- `pnpm knip` clean; `fallow audit --changed-since origin/main`: no new
findings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cloud/1.55 Backport PRs for cloud 1.55 core/1.55 Backport PRs for core 1.55 needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants