Repository navigation
FE-2904 fix(cloud): remote widgets fetch on the web session workspace - #19367
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughRemote widgets now try same-origin requests through the current web session before falling back to Axios. The change adds response parsing, timeout and abort handling, and tests for request routing and workspace switching. ChangesRemote widget web-session request flow
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant RemoteWidget as fetchData
participant ComfyApi
participant SessionSender as Web session sender
participant Axios
RemoteWidget->>ComfyApi: fetchOnWebSession(url, init)
ComfyApi->>SessionSender: Send request through current web session
SessionSender-->>ComfyApi: Response or undefined
ComfyApi-->>RemoteWidget: Response or undefined
RemoteWidget->>Axios: Send authenticated request if no session response
Suggested reviewers: Merge Risk: ⚪ Minimal · up to No concrete merge-blocking issue is established. The session-routing change and test fixture update appear mergeable subject to normal checks; permanent-widget cache behavior remains unchanged. Security Architecture ReviewSecurity architecture risk: 🟡 Moderate · up to Requests now use the selected workspace’s session authority, correcting the previous routing problem. However, workspace-specific results still enter a shared cache that does not track the user or workspace. Normal workspace switches reload the page and limit this exposure, but non-reloading identity changes and recovery can retain data from an earlier context. Retained concerns
Security review detailsSecurity Blast Radius
Security Findings and Attack Paths
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The PR uses bug-fix signals: the title starts with
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 156813d1db380b50e45fb7dfbe91f52276e2bf18
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2160 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 10 MB gzip 🔴 +543 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.46 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 133 kB (baseline 133 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 643 kB (baseline 643 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 39.4 kB (baseline 39.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 125 kB (baseline 125 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 4.08 MB (baseline 4.07 MB) • 🔴 +1.32 kBStores, services, APIs, and repositories
Status: 12 added / 12 removed / 3 unchanged Utilities & Hooks — 582 kB (baseline 582 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 20 added / 20 removed / 17 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.9 MB (baseline 17.9 MB) • ⚪ 0 BBundles that do not match a named category
Status: 74 added / 74 removed / 226 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-29T23:53:39.764Z",
"gitSha": "4cb2fabf856429fde2b12996654a4df5f6949310",
"branch": "dante01yoon/fe-2904-remote-widget-session",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2015.2980000000298,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.078,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.278,
"heapDeltaBytes": -37020260,
"heapUsedBytes": 61511488,
"domNodes": -228,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8.03,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2014.7380000000794,
"styleRecalcs": 13,
"styleRecalcDurationMs": 4.301000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.76599999999996,
"heapDeltaBytes": -2628572,
"heapUsedBytes": 76398412,
"domNodes": -228,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 9.478999999999997,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1722.7980000000116,
"styleRecalcs": 73,
"styleRecalcDurationMs": 16.034,
"layouts": 12,
"layoutDurationMs": 4.34,
"taskDurationMs": 672.335,
"heapDeltaBytes": -4888676,
"heapUsedBytes": 74185836,
"domNodes": -228,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 123.12600000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1732.2130000000016,
"styleRecalcs": 73,
"styleRecalcDurationMs": 16.077,
"layouts": 12,
"layoutDurationMs": 4.1579999999999995,
"taskDurationMs": 670.437,
"heapDeltaBytes": -5753092,
"heapUsedBytes": 73557716,
"domNodes": -228,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 133.324,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1718.55400000004,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.145000000000001,
"layouts": 6,
"layoutDurationMs": 1.03,
"taskDurationMs": 270.44599999999997,
"heapDeltaBytes": 1540848,
"heapUsedBytes": 80432584,
"domNodes": 53,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 10.808000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1712.9889999999932,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.039000000000001,
"layouts": 6,
"layoutDurationMs": 1.134,
"taskDurationMs": 282.71500000000003,
"heapDeltaBytes": 1478976,
"heapUsedBytes": 80402872,
"domNodes": 53,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 12.057,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 546.0630000000037,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.5569999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.59799999999996,
"heapDeltaBytes": 18293940,
"heapUsedBytes": 97293316,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 135.714,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 537.8699999999981,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.977000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.796,
"heapDeltaBytes": 18064728,
"heapUsedBytes": 97668652,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 133.579,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66874999999999,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1018.4539999999629,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 642.27,
"heapDeltaBytes": 9765196,
"heapUsedBytes": 86650076,
"domNodes": 0,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 50.10800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 396,
"frameDurationMs": 30.806060606060615,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1037.492000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 649.115,
"heapDeltaBytes": 10509288,
"heapUsedBytes": 86317528,
"domNodes": 0,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 54.534,
"eventListeners": 0,
"totalBlockingTimeMs": 400,
"frameDurationMs": 30.388235294117642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 801.7809999999486,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 379.52699999999993,
"heapDeltaBytes": 15691416,
"heapUsedBytes": 90561436,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 119.52499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 159,
"frameDurationMs": 22.854285714285705,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 773.8620000000083,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.249,
"heapDeltaBytes": -16977676,
"heapUsedBytes": 71760928,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 118.98,
"eventListeners": 0,
"totalBlockingTimeMs": 160,
"frameDurationMs": 23.038235294117626,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7156.547000000046,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6333.561000000001,
"heapDeltaBytes": 3545712,
"heapUsedBytes": 83829028,
"domNodes": 0,
"jsHeapTotalBytes": -13631488,
"scriptDurationMs": 5035.819,
"eventListeners": 0,
"totalBlockingTimeMs": 27,
"frameDurationMs": 24.91149825783972,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7104.877999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6310.983,
"heapDeltaBytes": -630700,
"heapUsedBytes": 79932420,
"domNodes": 0,
"jsHeapTotalBytes": -16515072,
"scriptDurationMs": 4999.803,
"eventListeners": 0,
"totalBlockingTimeMs": 30,
"frameDurationMs": 24.231399317406144,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7186.524000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6431.947,
"heapDeltaBytes": 3545408,
"heapUsedBytes": 84403232,
"domNodes": 0,
"jsHeapTotalBytes": -15728640,
"scriptDurationMs": 5138.738,
"eventListeners": 0,
"totalBlockingTimeMs": 66,
"frameDurationMs": 24.85501730103806,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6944.529999999986,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.38699999999999846,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6197.157,
"heapDeltaBytes": 2650332,
"heapUsedBytes": 82988212,
"domNodes": 0,
"jsHeapTotalBytes": -16252928,
"scriptDurationMs": 4928.433,
"eventListeners": 0,
"totalBlockingTimeMs": 33,
"frameDurationMs": 24.412323943661974,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-graph-idle",
"durationMs": 2038.7519999999881,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7790000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.41999999999996,
"heapDeltaBytes": -36971548,
"heapUsedBytes": 82935740,
"domNodes": -228,
"jsHeapTotalBytes": 163840,
"scriptDurationMs": 29.112000000000005,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2035.6880000000501,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.1899999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.86899999999997,
"heapDeltaBytes": -37154580,
"heapUsedBytes": 83025120,
"domNodes": -228,
"jsHeapTotalBytes": -622592,
"scriptDurationMs": 28.162,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2144.6659999999724,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.205,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1309.0459999999998,
"heapDeltaBytes": 24859384,
"heapUsedBytes": 87111944,
"domNodes": -228,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 671.772,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666406249999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2102.1599999999125,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.177999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1241.8819999999998,
"heapDeltaBytes": 19426364,
"heapUsedBytes": 82337316,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 640.707,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665873015873014,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3258.5920000000215,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.045999999999998,
"layouts": 60,
"layoutDurationMs": 13.093,
"taskDurationMs": 1428.5700000000002,
"heapDeltaBytes": 10460216,
"heapUsedBytes": 74506868,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 673.179,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666153846153843,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3238.7519999999768,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.759,
"layouts": 60,
"layoutDurationMs": 13.126999999999999,
"taskDurationMs": 1367.3289999999997,
"heapDeltaBytes": 8193456,
"heapUsedBytes": 72187232,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 634.176,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666494845360827,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2247.1290000000295,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.259000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1527.9539999999997,
"heapDeltaBytes": 17785120,
"heapUsedBytes": 83071952,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 774.747,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.79097744360902,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2450.5190000000994,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.203,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1563.55,
"heapDeltaBytes": 21779764,
"heapUsedBytes": 86753820,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 788.045,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.780689655172413,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2029.2210000000068,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.3099999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.47499999999997,
"heapDeltaBytes": 21015284,
"heapUsedBytes": 84258964,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.142000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2024.045000000001,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.299000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.37600000000015,
"heapDeltaBytes": -10475656,
"heapUsedBytes": 83843120,
"domNodes": -228,
"jsHeapTotalBytes": -1445888,
"scriptDurationMs": 31,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 545.659999999998,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.271000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 332.992,
"heapDeltaBytes": 12680176,
"heapUsedBytes": 94273104,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 121.72,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636353,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 543.7469999999394,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.792000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.369,
"heapDeltaBytes": 12698020,
"heapUsedBytes": 94243952,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 121.285,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636368,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2010.7299999999668,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.488,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.929,
"heapDeltaBytes": -28321432,
"heapUsedBytes": 53187852,
"domNodes": -244,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 8.283999999999997,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2026.7370000000255,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.101999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.425,
"heapDeltaBytes": -10958708,
"heapUsedBytes": 70265532,
"domNodes": -244,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 8.302999999999997,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1712.3410000000376,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.833,
"layouts": 16,
"layoutDurationMs": 4.92,
"taskDurationMs": 614.1949999999999,
"heapDeltaBytes": -4111228,
"heapUsedBytes": 77184328,
"domNodes": -244,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 86.971,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1712.933000000021,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.044000000000004,
"layouts": 16,
"layoutDurationMs": 5.890000000000001,
"taskDurationMs": 664.621,
"heapDeltaBytes": -3552332,
"heapUsedBytes": 78059736,
"domNodes": -244,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 95.093,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 884.6209999999246,
"styleRecalcs": 16,
"styleRecalcDurationMs": 23.153000000000006,
"layouts": 5,
"layoutDurationMs": 9.623,
"taskDurationMs": 696.2669999999999,
"heapDeltaBytes": 21465376,
"heapUsedBytes": 96279072,
"domNodes": 13667,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 22.468000000000004,
"eventListeners": 2383,
"totalBlockingTimeMs": 88,
"frameDurationMs": 20.075000000000003,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8161.920000000009,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.589,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4760.995,
"heapDeltaBytes": -35229140,
"heapUsedBytes": 84757376,
"domNodes": -228,
"jsHeapTotalBytes": 126976,
"scriptDurationMs": 2307.195,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666053169734152,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8204.882999999994,
"styleRecalcs": 252,
"styleRecalcDurationMs": 34.557,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4750.098999999999,
"heapDeltaBytes": -37095956,
"heapUsedBytes": 82811824,
"domNodes": -228,
"jsHeapTotalBytes": 126976,
"scriptDurationMs": 2220.65,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666191446028513,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14566.611999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14465.797999999999,
"heapDeltaBytes": -9812308,
"heapUsedBytes": 169548972,
"domNodes": 0,
"jsHeapTotalBytes": -14155776,
"scriptDurationMs": 216.735,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.511764705882356,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 14666.135000000053,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14571.739999999998,
"heapDeltaBytes": -74538056,
"heapUsedBytes": 174750188,
"domNodes": -8049,
"jsHeapTotalBytes": -26587136,
"scriptDurationMs": 241.14000000000001,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.46020202020202,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 17428.346000000034,
"styleRecalcs": 121,
"styleRecalcDurationMs": 13.784000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17275.948,
"heapDeltaBytes": -49276956,
"heapUsedBytes": 177750840,
"domNodes": -8049,
"jsHeapTotalBytes": -16556032,
"scriptDurationMs": 727.0080000000002,
"eventListeners": -14923,
"totalBlockingTimeMs": 10,
"frameDurationMs": 34.8652,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 17576.020999999968,
"styleRecalcs": 121,
"styleRecalcDurationMs": 15.979999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17491.275999999998,
"heapDeltaBytes": 4660284,
"heapUsedBytes": 190557096,
"domNodes": -8078,
"jsHeapTotalBytes": -28119040,
"scriptDurationMs": 745.275,
"eventListeners": -14923,
"totalBlockingTimeMs": 13,
"frameDurationMs": 35.587878787878786,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5297.5529999999935,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.82699999999999,
"layouts": 20,
"layoutDurationMs": 21.626999999999992,
"taskDurationMs": 5256.881,
"heapDeltaBytes": -5979324,
"heapUsedBytes": 200397356,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 94.271,
"eventListeners": 0,
"totalBlockingTimeMs": 228,
"frameDurationMs": 32.417073170731705,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 5451.96999999996,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.05400000000002,
"layouts": 20,
"layoutDurationMs": 23.49,
"taskDurationMs": 5415.546,
"heapDeltaBytes": 20786132,
"heapUsedBytes": 224699416,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 96.166,
"eventListeners": 0,
"totalBlockingTimeMs": 281,
"frameDurationMs": 35.041666666666664,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7298.170000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7254.895999999999,
"heapDeltaBytes": 13423084,
"heapUsedBytes": 184512648,
"domNodes": 0,
"jsHeapTotalBytes": -31457280,
"scriptDurationMs": 108.99200000000003,
"eventListeners": -1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.265200000000004,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7557.426000000078,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7515.426999999999,
"heapDeltaBytes": -31179352,
"heapUsedBytes": 194357632,
"domNodes": -3045,
"jsHeapTotalBytes": 16605184,
"scriptDurationMs": 120.48899999999996,
"eventListeners": -14907,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.145019920318724,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 456.77100000000337,
"styleRecalcs": 21,
"styleRecalcDurationMs": 14.804000000000002,
"layouts": 3,
"layoutDurationMs": 1.5150000000000001,
"taskDurationMs": 173.33200000000005,
"heapDeltaBytes": -43550300,
"heapUsedBytes": 53438516,
"domNodes": -119,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 8.617999999999999,
"eventListeners": -62,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 119.36100000002625,
"styleRecalcs": 8,
"styleRecalcDurationMs": 13.579999999999998,
"layouts": 3,
"layoutDurationMs": 0.9539999999999998,
"taskDurationMs": 87.22900000000001,
"heapDeltaBytes": -16690500,
"heapUsedBytes": 79930656,
"domNodes": 94,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 6.185000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 551.0590000000093,
"styleRecalcs": 78,
"styleRecalcDurationMs": 82.348,
"layouts": 76,
"layoutDurationMs": 17.845,
"taskDurationMs": 517.646,
"heapDeltaBytes": -16839680,
"heapUsedBytes": 70036572,
"domNodes": 76,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 187.84799999999998,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 627.5439999999435,
"styleRecalcs": 78,
"styleRecalcDurationMs": 87.605,
"layouts": 76,
"layoutDurationMs": 19.25,
"taskDurationMs": 581.924,
"heapDeltaBytes": -16402536,
"heapUsedBytes": 73131136,
"domNodes": 76,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 213.385,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1193.3480000000145,
"styleRecalcs": 78,
"styleRecalcDurationMs": 248.468,
"layouts": 76,
"layoutDurationMs": 24.523,
"taskDurationMs": 1176.895,
"heapDeltaBytes": 13222244,
"heapUsedBytes": 131694012,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 362.45099999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665753424657538,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1196.1839999999029,
"styleRecalcs": 78,
"styleRecalcDurationMs": 233.373,
"layouts": 76,
"layoutDurationMs": 22.723,
"taskDurationMs": 1183.709,
"heapDeltaBytes": 24311712,
"heapUsedBytes": 133452644,
"domNodes": -7942,
"jsHeapTotalBytes": -3973120,
"scriptDurationMs": 337.215,
"eventListeners": -1226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #19367 +/- ##
==========================================
+ Coverage 84.28% 85.04% +0.75%
==========================================
Files 3286 2340 -946
Lines 158348 133834 -24514
Branches 41132 34404 -6728
==========================================
- Hits 133463 113814 -19649
+ Misses 23060 19656 -3404
+ Partials 1825 364 -1461
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 955 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approved. Remote-widget requests remain scoped to the workspace selected in this tab, with no cross-tab workspace replay.
5b81378
|
@christian-byrne The merge queue dropped this twice without running CI. With main merged in, typecheck failed: #19414 made |
|
🔗 Commit SHA: 5b81378 | Docs | View more details | Give us feedback! |
christian-byrne
left a comment
There was a problem hiding this comment.
The workspace-bound request flow is sound, the exact-head checks are settled green, and there are no unresolved review threads. This preserves tab-local workspace scope: separate tabs may intentionally select different workspaces.
Full context for agent readers
The remote-widget request derives its web-session authorization from the request's workspace scope rather than shared global state. The focused coverage exercises the workspace-bound path, and the previously failing Cloud browser shard has cleared on this head.
## Summary Pins the user-visible behavior that a same-origin remote combo renders options from the selected team workspace instead of silently falling back to personal-workspace results. Current `main` already contains the web-session remote-widget implementation and unit coverage. After merging current `main`, this carrier's effective diff is deliberately one black-box browser spec. ## Changes - Route the remote-widget endpoint through the unified web-session fixture. - Return distinct team/personal options based on `X-Comfy-Workspace-ID`. - Assert the rendered canvas widget options and selected value. - Mock only the settings and userdata boot reads that otherwise fall through to a local multi-user backend; the session/workspace request path under test remains fixture-owned. ## Review Focus The response is deliberately selected by the workspace header, so bypassing the web-session request path produces `personal-checkpoint.safetensors` and fails the visible canvas-state assertion. Mutation proof at `2e8c61ef65`: changing the expected canvas state to the personal option failed with the received team option; restoring the assertion passed the same cloud Playwright command. Source: Comfy-Org#19367 ## Test plan - `NODE_OPTIONS=--no-experimental-webstorage pnpm exec vitest run src/renderer/extensions/vueNodes/widgets/composables/useRemoteWidget.test.ts src/renderer/extensions/vueNodes/widgets/composables/useRemoteWidget.webSession.test.ts` - `pnpm exec oxfmt --check browser_tests/tests/remoteWidgetWebSession.spec.ts` - `pnpm exec oxlint --type-aware browser_tests/tests/remoteWidgetWebSession.spec.ts` - `PLAYWRIGHT_SETUP_API_URL=http://localhost:8191 PLAYWRIGHT_TEST_URL=http://localhost:6217 DISTRIBUTION=cloud pnpm exec playwright test browser_tests/tests/remoteWidgetWebSession.spec.ts --project=cloud --workers=1` ## Screenshots (if applicable) Not applicable; this is an automated canvas-state regression test. --------- Co-authored-by: dante01yoon <bunggl@naver.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
Why
With the unified web session on, remote-widget combos in a team workspace loaded the personal workspace's options. Model lists are one example.
Root cause
useRemoteWidget.fetchDatacalledaxios.getdirectly withuseAuthStore().getAuthHeader(). It never went through the session request slot thatapi.fetchApiuses. The request carried the user's bearer token and noX-Comfy-Workspace-ID,X-Comfy-Clientor session cookie, so ingest resolved it to the personal workspace. #18875 listed this gap under "Not in this PR".How
ComfyApi.fetchOnWebSession(url, init)sends one request on the web session. It returnsundefinedwhen this tab is not on the session.fetchDatauses it only for same-origin routes. Absolute third-party URLs and//hoststay on axios, so the cookie and CSRF token never leave the origin.finally.max_retriesstill apply.api.fetchApiis not reused. It prefixes/api, addsComfy-Userandno-cache, and would attach session credentials to third-party routes.AS IS / TO BE
No UI change. The table shows the request
GET /api/models/checkpointssent from a team workspace, flag on:AuthorizationBearer <firebase token>X-Comfy-Workspace-ID<team workspace id>(absent in personal)X-Comfy-ClientCOMFY_CLIENTcredentialsinclude(session cookie)After a workspace switch,
widget.refresh()changes only the workspace header, with no/api/auth/token.Tests
useRemoteWidget.test.ts:response_key.//hostand no-session requests stay on axios.useRemoteWidget.webSession.test.ts: through the real session store, for team and personal workspaces. It checks the exact ingest request match, then a switch and refresh.The existing "concurrent hook instances" test moved from
Promise.racetoPromise.all, because the extra session probe changed microtask ordering.raceonly passed by tick count.allkeeps every assertion, including oneaxios.getcall.Out of scope
The remote-widget cache key doesn't include the workspace. After a switch, a permanent widget (
refresh <= 0) keeps the previous workspace's options until it refreshes. This is existing behaviour, left for a follow-up.Where this sits