Repository navigation
test(cloud): pin remote widget web-session workspace - #19484
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (4)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. 📝 WalkthroughWalkthroughThis change adds a browser test that selects the ChangesWorkspace checkpoint browser test
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to This test change does not alter production behavior, and the inspected fixture and request wiring support its intended team-workspace check. No merge-blocking risk is established. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since f1201c62649c4f045adb11ba19d100a1a71253e9
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2193 passed, 0 failed📊 Browser Reports
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-04T03:41:25.998Z",
"gitSha": "e865740de650c03747e7a1e9b58e454ac4222a91",
"branch": "codex/remotewidget-blackbox-proof-1",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2017.1670000000859,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.6760000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 313.32000000000005,
"heapDeltaBytes": 22361424,
"heapUsedBytes": 76403904,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.086999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2017.1619999999848,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5400000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 312.452,
"heapDeltaBytes": 22353852,
"heapUsedBytes": 76287364,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.545,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1684.3519999999899,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.539999999999997,
"layouts": 12,
"layoutDurationMs": 3.603,
"taskDurationMs": 591.931,
"heapDeltaBytes": 19523288,
"heapUsedBytes": 73445036,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 112.60600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1688.3719999999585,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.781,
"layouts": 12,
"layoutDurationMs": 3.6499999999999995,
"taskDurationMs": 602.8299999999999,
"heapDeltaBytes": 19287452,
"heapUsedBytes": 73534876,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 115.571,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1711.5380000000187,
"styleRecalcs": 31,
"styleRecalcDurationMs": 7.933000000000001,
"layouts": 6,
"layoutDurationMs": 1.1309999999999998,
"taskDurationMs": 258.886,
"heapDeltaBytes": 3359608,
"heapUsedBytes": 71140276,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.058000000000005,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262138,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.4099999999107,
"styleRecalcs": 31,
"styleRecalcDurationMs": 8.159,
"layouts": 6,
"layoutDurationMs": 1.0859999999999999,
"taskDurationMs": 270.704,
"heapDeltaBytes": 3410716,
"heapUsedBytes": 71399512,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.187000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 553.3260000000837,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.0360000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 354.26200000000006,
"heapDeltaBytes": 15262316,
"heapUsedBytes": 69267552,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 129.659,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636353,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 541.8970000000627,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.3699999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.85200000000003,
"heapDeltaBytes": -8067620,
"heapUsedBytes": 59355284,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 131.01000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 985.3880000000572,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 612.561,
"heapDeltaBytes": 11863724,
"heapUsedBytes": 81696292,
"domNodes": 0,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 47.66300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 368,
"frameDurationMs": 29.796969696969704,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1017.0729999999821,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 627.0900000000001,
"heapDeltaBytes": 13279012,
"heapUsedBytes": 94876868,
"domNodes": 0,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 48.635,
"eventListeners": 0,
"totalBlockingTimeMs": 382,
"frameDurationMs": 29.90000000000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 785.0740000000087,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.0180000000002,
"heapDeltaBytes": -14784324,
"heapUsedBytes": 106787572,
"domNodes": 0,
"jsHeapTotalBytes": 4198400,
"scriptDurationMs": 118.71499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 162,
"frameDurationMs": 23.038235294117626,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 801.60699999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.14399999999983,
"heapDeltaBytes": -14227020,
"heapUsedBytes": 80411172,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 123.63599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 164,
"frameDurationMs": 22.85428571428573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6499.594999999999,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.900999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5789.892999999999,
"heapDeltaBytes": -4281532,
"heapUsedBytes": 79718292,
"domNodes": -142,
"jsHeapTotalBytes": -6164480,
"scriptDurationMs": 4634.284,
"eventListeners": -78,
"totalBlockingTimeMs": 36,
"frameDurationMs": 24.903448275862065,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6324.294000000009,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.3430000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5673.446,
"heapDeltaBytes": -498344,
"heapUsedBytes": 80073928,
"domNodes": 0,
"jsHeapTotalBytes": -17563648,
"scriptDurationMs": 4716.95,
"eventListeners": 0,
"totalBlockingTimeMs": 30,
"frameDurationMs": 25.065079365079367,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6577.164999999923,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8110000000000009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5917.891,
"heapDeltaBytes": -16686980,
"heapUsedBytes": 68153864,
"domNodes": -143,
"jsHeapTotalBytes": -6426624,
"scriptDurationMs": 4783.388999999999,
"eventListeners": -82,
"totalBlockingTimeMs": 102,
"frameDurationMs": 25.45116279069767,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6358.765000000062,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.36800000000000027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5831.833,
"heapDeltaBytes": -730512,
"heapUsedBytes": 79685524,
"domNodes": 0,
"jsHeapTotalBytes": -15204352,
"scriptDurationMs": 4691.918000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 49,
"frameDurationMs": 25.097628458498022,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-graph-idle",
"durationMs": 2013.7299999998959,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.7409999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.22100000000006,
"heapDeltaBytes": -10711240,
"heapUsedBytes": 77154068,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 28.020000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2007.0489999999381,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.823000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.88100000000003,
"heapDeltaBytes": -10576492,
"heapUsedBytes": 78168960,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 30.488,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2122.2099999999955,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.673,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1212.317,
"heapDeltaBytes": 9501324,
"heapUsedBytes": 89101588,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 657.146,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665354330708666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2100.7419999999684,
"styleRecalcs": 66,
"styleRecalcDurationMs": 9.083,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1228.1309999999999,
"heapDeltaBytes": 2867348,
"heapUsedBytes": 66647920,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 676.652,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665873015873014,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3208.7960000000066,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.566000000000003,
"layouts": 60,
"layoutDurationMs": 13.301,
"taskDurationMs": 1316.689,
"heapDeltaBytes": -18536480,
"heapUsedBytes": 68486436,
"domNodes": 24,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 630.923,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000002,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3122.1760000000813,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.797999999999998,
"layouts": 60,
"layoutDurationMs": 12.865000000000002,
"taskDurationMs": 1267.0240000000001,
"heapDeltaBytes": -236412,
"heapUsedBytes": 64675324,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 603.1569999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665775401069517,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2230.287999999973,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.168,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1483.1589999999997,
"heapDeltaBytes": 3279292,
"heapUsedBytes": 68332128,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 782.27,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.792424242424246,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2166.394000000082,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.2059999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1450.837,
"heapDeltaBytes": 2959196,
"heapUsedBytes": 67341296,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 755.255,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7953125,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.2179999999908,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.2050000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.34999999999997,
"heapDeltaBytes": 10330564,
"heapUsedBytes": 73239088,
"domNodes": -328,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.879000000000005,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2011.790000000019,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.613000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.7750000000001,
"heapDeltaBytes": 10323280,
"heapUsedBytes": 73258884,
"domNodes": -328,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.621999999999996,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 508.47699999997076,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.779000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 305.65000000000003,
"heapDeltaBytes": 9632128,
"heapUsedBytes": 63842640,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 113.03300000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 493.05699999990793,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.016999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 319.37200000000007,
"heapDeltaBytes": 8865680,
"heapUsedBytes": 63111644,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 119.336,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66206896551725,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2035.7589999999846,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.457,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 340.402,
"heapDeltaBytes": -29522832,
"heapUsedBytes": 75790764,
"domNodes": -249,
"jsHeapTotalBytes": -3670016,
"scriptDurationMs": 8.001000000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2020.516999999927,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8339999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 308.05499999999995,
"heapDeltaBytes": 22301384,
"heapUsedBytes": 76521056,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.411,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.7719999999808,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.858,
"layouts": 16,
"layoutDurationMs": 4.701,
"taskDurationMs": 564.062,
"heapDeltaBytes": -6610424,
"heapUsedBytes": 63777144,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 82.41999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.3689999999988,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.167000000000002,
"layouts": 16,
"layoutDurationMs": 4.449,
"taskDurationMs": 562.525,
"heapDeltaBytes": 15025820,
"heapUsedBytes": 69326756,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 82.439,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 850.9699999999611,
"styleRecalcs": 17,
"styleRecalcDurationMs": 23.340000000000007,
"layouts": 5,
"layoutDurationMs": 10.675999999999998,
"taskDurationMs": 669.014,
"heapDeltaBytes": 22087756,
"heapUsedBytes": 108173204,
"domNodes": 13747,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 21.40700000000001,
"eventListeners": 2383,
"totalBlockingTimeMs": 88,
"frameDurationMs": 19.76511627906978,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8148.61499999995,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.93900000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4222.4,
"heapDeltaBytes": -35142788,
"heapUsedBytes": 91333648,
"domNodes": -328,
"jsHeapTotalBytes": -2756608,
"scriptDurationMs": 2095.842,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665848670756645,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8164.0670000000455,
"styleRecalcs": 251,
"styleRecalcDurationMs": 35.43399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4305.19,
"heapDeltaBytes": 7711092,
"heapUsedBytes": 95694184,
"domNodes": 0,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 2219.6890000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66591836734694,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14270.199000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13190.620000000003,
"heapDeltaBytes": -31141464,
"heapUsedBytes": 171298952,
"domNodes": -3045,
"jsHeapTotalBytes": 8384512,
"scriptDurationMs": 207.53300000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.682006920415226,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-idle",
"durationMs": 14313.429000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13275.927,
"heapDeltaBytes": -30211672,
"heapUsedBytes": 174347504,
"domNodes": -3045,
"jsHeapTotalBytes": 8933376,
"scriptDurationMs": 206.23800000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.555917667238422,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 16728.694000000018,
"styleRecalcs": 129,
"styleRecalcDurationMs": 14.783999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16199.508999999998,
"heapDeltaBytes": -2223908,
"heapUsedBytes": 194773492,
"domNodes": -3045,
"jsHeapTotalBytes": 7380992,
"scriptDurationMs": 695.012,
"eventListeners": -14915,
"totalBlockingTimeMs": 7,
"frameDurationMs": 30.47850637522769,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-large-graph-pan",
"durationMs": 17153.28099999999,
"styleRecalcs": 146,
"styleRecalcDurationMs": 15.336999999999989,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16706.653,
"heapDeltaBytes": -31203840,
"heapUsedBytes": 166684424,
"domNodes": -3045,
"jsHeapTotalBytes": 7856128,
"scriptDurationMs": 693.6360000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 4,
"frameDurationMs": 31.75796296296296,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-node-resize-workload",
"durationMs": 3913.441999999918,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.67100000000003,
"layouts": 20,
"layoutDurationMs": 21.902000000000005,
"taskDurationMs": 3814.451,
"heapDeltaBytes": 987724,
"heapUsedBytes": 212336108,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 69.40899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.50862068965517,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 5243.142999999918,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.89600000000001,
"layouts": 20,
"layoutDurationMs": 21.274,
"taskDurationMs": 5092.661999999999,
"heapDeltaBytes": 7617632,
"heapUsedBytes": 206043292,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 82.93,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.399438202247183,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7345.186000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6902.799999999999,
"heapDeltaBytes": -43299560,
"heapUsedBytes": 178110016,
"domNodes": -3045,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 116.427,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.084300341296924,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7258.646999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6929.739000000001,
"heapDeltaBytes": -35933780,
"heapUsedBytes": 184860252,
"domNodes": -3045,
"jsHeapTotalBytes": 5439488,
"scriptDurationMs": 102.02499999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.67597173144877,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 437.97300000005635,
"styleRecalcs": 16,
"styleRecalcDurationMs": 12.500000000000002,
"layouts": 3,
"layoutDurationMs": 0.8690000000000002,
"taskDurationMs": 96.72900000000004,
"heapDeltaBytes": 5698968,
"heapUsedBytes": 70850796,
"domNodes": 104,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.775999999999998,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384603,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 86.53400000002875,
"styleRecalcs": 6,
"styleRecalcDurationMs": 9.76,
"layouts": 3,
"layoutDurationMs": 1.668,
"taskDurationMs": 61.974000000000004,
"heapDeltaBytes": 3640756,
"heapUsedBytes": 61373056,
"domNodes": 113,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.824999999999998,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 535.2809999999408,
"styleRecalcs": 78,
"styleRecalcDurationMs": 77.419,
"layouts": 76,
"layoutDurationMs": 18.721,
"taskDurationMs": 496.104,
"heapDeltaBytes": 14314280,
"heapUsedBytes": 88443440,
"domNodes": 76,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 185.07999999999998,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 495.6609999999273,
"styleRecalcs": 78,
"styleRecalcDurationMs": 74.718,
"layouts": 76,
"layoutDurationMs": 17.898,
"taskDurationMs": 469.209,
"heapDeltaBytes": -17228936,
"heapUsedBytes": 69352196,
"domNodes": 76,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 171.86599999999999,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1030.3639999999632,
"styleRecalcs": 78,
"styleRecalcDurationMs": 226.481,
"layouts": 76,
"layoutDurationMs": 23.116999999999997,
"taskDurationMs": 1004.4470000000001,
"heapDeltaBytes": 6425564,
"heapUsedBytes": 112280344,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 302.969,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1167.5410000000284,
"styleRecalcs": 78,
"styleRecalcDurationMs": 243.391,
"layouts": 76,
"layoutDurationMs": 24.171000000000003,
"taskDurationMs": 1135.886,
"heapDeltaBytes": 7249944,
"heapUsedBytes": 112890256,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 357.242,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.15735294117648,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
This comment has been minimized.
This comment has been minimized.
dante01yoon
left a comment
There was a problem hiding this comment.
The product change looks right. fetchOnSession only takes same-origin routes, combines the caller's abort with its own timeout via AbortSignal.any, keeps the axios/bearer path when the tab isn't on the session, and returns non-2xx as a request error, so the existing retry and backoff accounting still applies. The new E2E is a good black-box proof: the endpoint answers by X-Comfy-Workspace-ID, so bypassing the session path shows the personal option and fails the canvas assertion. Focused unit suites pass locally (62/62).
One blocker. CI is red for a single reason, and it takes E2E down with it. On main, WebSessionRequests gained a required authorizeResource member (#19378, after #19367 branched). The test double here doesn't implement it, so typecheck fails with TS2741. setup runs the same typecheck and fails, and that cascades into merge-reports, e2e-status, perf-tests and lint-and-format. As a result, the new remoteWidgetWebSession.spec.ts has not actually run in CI yet. Vitest passes locally only because it doesn't typecheck. See inline.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19484 +/- ##
==========================================
- Coverage 84.98% 82.43% -2.55%
==========================================
Files 3451 2408 -1043
Lines 165944 143000 -22944
Branches 43352 34070 -9282
==========================================
- Hits 141021 117882 -23139
- Misses 22951 24757 +1806
+ Partials 1972 361 -1611
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Re-reviewed d1be2e3. Product routing still looks right: same-origin only, session first with axios/bearer fallback, AbortSignal.any for timeout, non-2xx as request errors so retry/backoff still apply. The browser fixture that answers by X-Comfy-Workspace-ID is a solid black-box proof.
Gates: Gate 1 pass (workspace fallback proven by the deliberate personal-vs-team response). Gate 2 pass. Gate 3 pass (no hand-declared production API response types).
One blocker remains on this head. The provideWebSessionRequests double in useRemoteWidget.test.ts still omits required WebSessionRequests members (authorizeResource, and workspaceToken as well). CI typecheck is still red on d1be2e3, which also keeps the new E2E from running. The branch is also dirty against current main — please rebase, complete the double (or fromPartial<WebSessionRequests>), and let typecheck + the browser proof go green before merge.
…ackbox-proof-1 # Conflicts: # src/renderer/extensions/vueNodes/widgets/composables/useRemoteWidget.test.ts # src/renderer/extensions/vueNodes/widgets/composables/useRemoteWidget.webSession.test.ts
Resolved at 2e8c61e: current main already contains the repaired fromPartial double and product implementation, so the exact-head PR diff is now only the black-box spec. Focused unit suites pass 62/62, pre-commit typecheck:browser passed, and the cloud Playwright spec passed with a deliberate personal-option mutation failing on the received team canvas state.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 6 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 2 |
| 🟢 Low | 4 |
Panel: 8/8 reviewers contributed findings.
|
|
||
| await comfyPage.workflow.loadWorkflow('inputs/remote_widget') | ||
|
|
||
| await expect |
There was a problem hiding this comment.
🟡 Medium — test.describe.configure({ timeout: 120_000 }) raises only the test timeout; expect.poll is bounded by the separate expect timeout, which the cloud project does not override (only cloud-live sets expect: { timeout: 30_000 }), so this poll gives up after Playwright's 5s default regardless of the 120s budget. On a slow web-session boot the test fails at the poll long before the intended budget — pass an explicit { timeout } to expect.poll. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| ({ title }) => title === 'Remote Widget Node' | ||
| ) | ||
| return { | ||
| options: node?.widgets?.[0].options.values, |
There was a problem hiding this comment.
🟡 Medium — node?.widgets?.[0].options.values is not fully null-safe: optional chaining short-circuits only on nullish operands, so when widgets is an empty array [0] is undefined and .options throws a TypeError inside page.evaluate rather than yielding a value the poll can compare. Use node?.widgets?.[0]?.options?.values (and the same for .value on the next line) so a transient empty-widgets window produces a clean mismatch instead of an opaque evaluate error. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| } | ||
| ) | ||
|
|
||
| await comfyPage.workflow.loadWorkflow('inputs/remote_widget') |
There was a problem hiding this comment.
🟢 Low — The workflow is loaded without first waiting for the web session and workspace scope to be established. useRemoteWidget.fetchData calls api.fetchOnWebSession, which returns undefined while webSessionRequests().scope() is unresolved and falls back to a plain axios.get carrying no x-comfy-workspace-id; because this node's remote config has no refresh the cached entry is permanent, so one early header-less request pins PERSONAL_OPTIONS and the poll can never recover. Gate the loadWorkflow on the session/workspace being ready so a lost race reads as a product failure only when it really is one. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
|
|
||
| const test = webSessionTest.extend({ | ||
| page: async ({ page }, use) => { | ||
| await page.route('**/api/settings', (route) => route.fulfill(jsonRoute({}))) |
There was a problem hiding this comment.
🟢 Low — Fulfilling **/api/settings with {} discards every setting the comfyPage fixture seeds via /api/devtools/set_settings (Comfy.UseNewMenu, Comfy.TutorialCompleted, Comfy.OnboardingCoachmarks.Seen, etc.), since the app reads them back through GET /api/settings — so this spec boots with onboarding and the tutorial re-enabled unlike every other spec. The glob also swallows POST /api/settings (acked but dropped) while not matching POST /api/settings/<id>, which still reaches the backend; stub only what the test needs, or merge the fixture defaults into the response. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
| const test = webSessionTest.extend({ | ||
| page: async ({ page }, use) => { | ||
| await page.route('**/api/settings', (route) => route.fulfill(jsonRoute({}))) | ||
| await page.route('**/api/userdata**', (route) => |
There was a problem hiding this comment.
🟢 Low — **/api/userdata** matches every userdata path and every verb but always answers 200 with an array: single-file reads (GET /api/userdata/<file>) get [] instead of their real body or a 404, and PUT/POST/DELETE writes are silently acked without happening, so a persistence regression would stay invisible behind a green test. Scope the route to the listing requests the boot path actually needs. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| } | ||
| }) | ||
|
|
||
| test('shows options from the selected team workspace', async ({ |
There was a problem hiding this comment.
🟢 Low — The suite is named for workspace routing but contains a single positive load and never switches workspaces, so the PERSONAL_OPTIONS branch of the route handler is dead and the cross-tenant case goes untested. Since useRemoteWidget's cache key is route;r=<refresh>;<params> with no workspace component and no invalidation on workspace change, a switch-then-reassert case is exactly the scenario most likely to expose a real bug here. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
| const test = webSessionTest.extend({ | ||
| page: async ({ page }, use) => { | ||
| await page.route('**/api/settings', (route) => route.fulfill(jsonRoute({}))) | ||
| await page.route('**/api/userdata**', (route) => | ||
| route.fulfill(jsonRoute([])) | ||
| ) | ||
| await use(page) | ||
| } | ||
| }) |
There was a problem hiding this comment.
Note to self: Another routing fixture to add to the standardization work.
| 'Remote widget web-session routing', | ||
| { tag: ['@cloud', '@widget'] }, | ||
| () => { | ||
| test.describe.configure({ timeout: 120_000 }) |
There was a problem hiding this comment.
These can't all actually need this long a timeout.
If our tests are this bad, we should just set the long timeout globally and then do periodic audits.
| await comfyPage.page.route( | ||
| '**/api/models/checkpoints**', | ||
| async (route) => { | ||
| const workspaceId = await route | ||
| .request() | ||
| .headerValue('x-comfy-workspace-id') | ||
| await route.fulfill( | ||
| jsonRoute( | ||
| workspaceId === TEAM_WORKSPACE_ID | ||
| ? TEAM_OPTIONS | ||
| : PERSONAL_OPTIONS | ||
| ) | ||
| ) | ||
| } | ||
| ) |
There was a problem hiding this comment.
Normally I would expect a matching route promise binding and a subsequent await.
| const node = window.app!.graph.nodes.find( | ||
| ({ title }) => title === 'Remote Widget Node' | ||
| ) |
There was a problem hiding this comment.
Don't we have a utility for this that we could use?
|
|
||
| test.describe( | ||
| 'Remote widget web-session routing', | ||
| { tag: ['@cloud', '@widget'] }, |
There was a problem hiding this comment.
Or does @cloud imply @vue-nodes?
| { tag: ['@cloud', '@widget'] }, | |
| { tag: ['@cloud', '@widget', '@vue-nodes'] }, |
There was a problem hiding this comment.
Is there a more specific domain we can use for placing this test?
Summary
Pins the user-visible behavior that a same-origin remote combo renders options from the selected team workspace instead of silently falling back to personal-workspace results.
Current
mainalready contains the web-session remote-widget implementation and unit coverage. After merging currentmain, this carrier's effective diff is deliberately one black-box browser spec.Changes
X-Comfy-Workspace-ID.Review Focus
The response is deliberately selected by the workspace header, so bypassing the web-session request path produces
personal-checkpoint.safetensorsand fails the visible canvas-state assertion.Mutation proof at
2e8c61ef65: changing the expected canvas state to the personal option failed with the received team option; restoring the assertion passed the same cloud Playwright command.Source: #19367
Test plan
NODE_OPTIONS=--no-experimental-webstorage pnpm exec vitest run src/renderer/extensions/vueNodes/widgets/composables/useRemoteWidget.test.ts src/renderer/extensions/vueNodes/widgets/composables/useRemoteWidget.webSession.test.tspnpm exec oxfmt --check browser_tests/tests/remoteWidgetWebSession.spec.tspnpm exec oxlint --type-aware browser_tests/tests/remoteWidgetWebSession.spec.tsPLAYWRIGHT_SETUP_API_URL=http://localhost:8191 PLAYWRIGHT_TEST_URL=http://localhost:6217 DISTRIBUTION=cloud pnpm exec playwright test browser_tests/tests/remoteWidgetWebSession.spec.ts --project=cloud --workers=1Screenshots (if applicable)
Not applicable; this is an automated canvas-state regression test.