Repository navigation
[backport core/1.54] fix(agent): bound attachment upload contract (#16985) - #19348
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1957 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-29T18:54:01.704Z",
"gitSha": "6f9ce94eca641126308fcda086fe3a395843cb55",
"branch": "backport/16985-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2033.2920000000172,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.783999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 549.603,
"heapDeltaBytes": 9203592,
"heapUsedBytes": 79355696,
"domNodes": -283,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 10.758000000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2034.9769999999694,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.776999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.1909999999999,
"heapDeltaBytes": -10838400,
"heapUsedBytes": 60268776,
"domNodes": -283,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 9.149000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1857.101,
"styleRecalcs": 76,
"styleRecalcDurationMs": 31.56,
"layouts": 14,
"layoutDurationMs": 4.022,
"taskDurationMs": 932.728,
"heapDeltaBytes": -5962088,
"heapUsedBytes": 64940540,
"domNodes": -279,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 150.822,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1840.1059999999916,
"styleRecalcs": 74,
"styleRecalcDurationMs": 29.042,
"layouts": 14,
"layoutDurationMs": 4.101999999999999,
"taskDurationMs": 888.5830000000001,
"heapDeltaBytes": -6842740,
"heapUsedBytes": 63618232,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 152.24599999999998,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.179000000016,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.965,
"layouts": 6,
"layoutDurationMs": 1.2540000000000002,
"taskDurationMs": 383.73699999999997,
"heapDeltaBytes": 4694264,
"heapUsedBytes": 75996712,
"domNodes": 73,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 13.434000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1753.1819999999243,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.546,
"layouts": 6,
"layoutDurationMs": 1.2600000000000002,
"taskDurationMs": 381.64799999999997,
"heapDeltaBytes": 4587280,
"heapUsedBytes": 75547120,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.75,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 769.2470000000071,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.7280000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.71899999999994,
"heapDeltaBytes": -7601756,
"heapUsedBytes": 63320092,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 171.966,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 677.5880000000143,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.510999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.5520000000001,
"heapDeltaBytes": 17991132,
"heapUsedBytes": 88281728,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 153.99,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2061.300000000017,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.575999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 607.0409999999999,
"heapDeltaBytes": 10689524,
"heapUsedBytes": 87495712,
"domNodes": -274,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 36.97900000000001,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2032.2510000000875,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.1389999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 656.6240000000001,
"heapDeltaBytes": -16237116,
"heapUsedBytes": 87534876,
"domNodes": -271,
"jsHeapTotalBytes": -1376256,
"scriptDurationMs": 39.67699999999999,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2191.7760000000044,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.032999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1621.561,
"heapDeltaBytes": 8255760,
"heapUsedBytes": 85078132,
"domNodes": -273,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 772.404,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2291.5120000000115,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.613999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1648.9409999999998,
"heapDeltaBytes": 7885048,
"heapUsedBytes": 84860904,
"domNodes": -281,
"jsHeapTotalBytes": 909312,
"scriptDurationMs": 792.367,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3519.3849999999998,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.835000000000004,
"layouts": 60,
"layoutDurationMs": 13.364,
"taskDurationMs": 1691.6259999999997,
"heapDeltaBytes": 8481540,
"heapUsedBytes": 76179220,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 753.076,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3903.2270000000153,
"styleRecalcs": 63,
"styleRecalcDurationMs": 14.442,
"layouts": 60,
"layoutDurationMs": 13.491999999999999,
"taskDurationMs": 1924.5130000000001,
"heapDeltaBytes": 9882744,
"heapUsedBytes": 88495416,
"domNodes": -287,
"jsHeapTotalBytes": 4354048,
"scriptDurationMs": 845.213,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3190.5209999999897,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.873999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2039.1370000000002,
"heapDeltaBytes": -1453612,
"heapUsedBytes": 79223808,
"domNodes": 6,
"jsHeapTotalBytes": 5820416,
"scriptDurationMs": 984.6029999999998,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3124.6750000000247,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.537,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1993.4509999999998,
"heapDeltaBytes": 25483156,
"heapUsedBytes": 93571256,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 985.225,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2056.429000000037,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.2719999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 678.31,
"heapDeltaBytes": 8447620,
"heapUsedBytes": 86643536,
"domNodes": -276,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 37.883,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.5259999999944,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.819000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 633.914,
"heapDeltaBytes": 21820520,
"heapUsedBytes": 87825200,
"domNodes": -277,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.35899999999999,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 609.7169999999892,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.568999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.37800000000004,
"heapDeltaBytes": 14573272,
"heapUsedBytes": 86806184,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 144.77599999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 613.8919999999644,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.144,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.42,
"heapDeltaBytes": 15022144,
"heapUsedBytes": 88151876,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 147.049,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2010.4500000000485,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.842000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.0659999999999,
"heapDeltaBytes": 10433728,
"heapUsedBytes": 82883200,
"domNodes": -299,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.194999999999999,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2013.4010000000444,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.488000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.258,
"heapDeltaBytes": -549248,
"heapUsedBytes": 71670156,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.958,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.478999999974,
"styleRecalcs": 78,
"styleRecalcDurationMs": 29.224000000000004,
"layouts": 18,
"layoutDurationMs": 4.949,
"taskDurationMs": 823.078,
"heapDeltaBytes": -8903428,
"heapUsedBytes": 63682128,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 108.74000000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1752.8899999999794,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.036000000000005,
"layouts": 18,
"layoutDurationMs": 4.925000000000001,
"taskDurationMs": 836.461,
"heapDeltaBytes": -674016,
"heapUsedBytes": 72231060,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 108.341,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1385.6940000000009,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.337999999999997,
"layouts": 14,
"layoutDurationMs": 14.295000000000002,
"taskDurationMs": 967.9330000000001,
"heapDeltaBytes": -5144868,
"heapUsedBytes": 84494448,
"domNodes": 13831,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 29.55699999999999,
"eventListeners": 2385,
"totalBlockingTimeMs": 138,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8686.777000000006,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.778999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6130.197,
"heapDeltaBytes": 10215788,
"heapUsedBytes": 86554820,
"domNodes": -269,
"jsHeapTotalBytes": 385024,
"scriptDurationMs": 2816.455,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8469.185999999921,
"styleRecalcs": 246,
"styleRecalcDurationMs": 38.800000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5821.643,
"heapDeltaBytes": 4807548,
"heapUsedBytes": 81213260,
"domNodes": -273,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 2614.599,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18480.512999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17936.489,
"heapDeltaBytes": -44586608,
"heapUsedBytes": 168778780,
"domNodes": -8068,
"jsHeapTotalBytes": -5779456,
"scriptDurationMs": 318.99,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17972.37299999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17474.337,
"heapDeltaBytes": -41420988,
"heapUsedBytes": 177263888,
"domNodes": -8067,
"jsHeapTotalBytes": -13643776,
"scriptDurationMs": 325.56399999999996,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.889999999999905,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22036.302000000036,
"styleRecalcs": 159,
"styleRecalcDurationMs": 22.216000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21806.731000000003,
"heapDeltaBytes": -51635880,
"heapUsedBytes": 180426420,
"domNodes": -8068,
"jsHeapTotalBytes": -17739776,
"scriptDurationMs": 923.764,
"eventListeners": -14929,
"totalBlockingTimeMs": 164,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22396.90500000006,
"styleRecalcs": 167,
"styleRecalcDurationMs": 23.451999999999973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22169.673,
"heapDeltaBytes": -43983972,
"heapUsedBytes": 179396768,
"domNodes": -8068,
"jsHeapTotalBytes": -14467072,
"scriptDurationMs": 952.0939999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 104,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6528.305999999986,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.42399999999999,
"layouts": 20,
"layoutDurationMs": 26.033,
"taskDurationMs": 6481.911999999999,
"heapDeltaBytes": -44453640,
"heapUsedBytes": 180177584,
"domNodes": -8068,
"jsHeapTotalBytes": 9080832,
"scriptDurationMs": 123.935,
"eventListeners": -14929,
"totalBlockingTimeMs": 464,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6450.879999999984,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.594,
"layouts": 20,
"layoutDurationMs": 24.777000000000008,
"taskDurationMs": 6366.818,
"heapDeltaBytes": -48289044,
"heapUsedBytes": 170601464,
"domNodes": -8068,
"jsHeapTotalBytes": 19124224,
"scriptDurationMs": 121.91600000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 391,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9183.273999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8957.044999999998,
"heapDeltaBytes": 37758108,
"heapUsedBytes": 196409424,
"domNodes": 0,
"jsHeapTotalBytes": -13107200,
"scriptDurationMs": 177.12299999999993,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9009.882999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8773.516000000001,
"heapDeltaBytes": 4460960,
"heapUsedBytes": 179654372,
"domNodes": 0,
"jsHeapTotalBytes": -14680064,
"scriptDurationMs": 147.08599999999993,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 505.61500000003434,
"styleRecalcs": 20,
"styleRecalcDurationMs": 25.282000000000004,
"layouts": 3,
"layoutDurationMs": 1.8380000000000003,
"taskDurationMs": 126.687,
"heapDeltaBytes": 4908832,
"heapUsedBytes": 73745384,
"domNodes": 149,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.864000000000003,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 458.313999999973,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.235000000000003,
"layouts": 3,
"layoutDurationMs": 1.6039999999999999,
"taskDurationMs": 110.144,
"heapDeltaBytes": 4911296,
"heapUsedBytes": 73830988,
"domNodes": 144,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.925,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 6 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
| 🟢 Low | 4 |
| ⚪ Nit | 1 |
Panel: 3/8 reviewers contributed findings.
Reviewers that did not contribute: claude-opus-5-thinking-max:adversarial (error), gpt-5.6-sol-max:adversarial (error), claude-opus-5-thinking-max:edge-case (error), gemini-3.1-pro:edge-case (error), gpt-5.6-sol-max:edge-case (error)
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.54 #19348 +/- ##
=============================================
+ Coverage 83.87% 83.90% +0.03%
=============================================
Files 2109 2109
Lines 125661 125925 +264
Branches 33732 33831 +99
=============================================
+ Hits 105399 105659 +260
- Misses 20083 20087 +4
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 2 — ledger: 6 prior finding(s) across 1 round(s) (6 never answered).
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 3 |
| 🟢 Low | 7 |
Panel: 8/8 reviewers contributed findings.
|
Fixed the backport-only unit failure in commit Verification on
The push also started fresh CI and Cursor review runs. The other 60 unit failures in the previous unit job are unchanged |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 3 — ledger: 16 prior finding(s) across 2 round(s) (16 never answered).
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 4 |
| 🟢 Low | 6 |
Panel: 8/8 reviewers contributed findings.
Validate stored upload names, preserve server locations, cancel source fetches, classify failures, refresh settled uploads, and bound batches.\n\nReview: #19348 (comment)
|
Addressed the current attachment review round in commit
Validation: 79 focused utility, upload, transport, and API-client tests passed; 8 targeted panel scenarios passed; app typecheck, changed-file lint, formatting, and knip passed. The full panel file passed 260 tests; seven unrelated workflow-binding cases exceeded the release branch’s existing five-second test timeout. |
Addresses review feedback: #19348 (comment)
|
All review findings are addressed on commit 1a52784. Deferred asset fetches now use the upload transfer budget instead of a fixed 60-second timeout, while preserving cancellation and timeout telemetry. Validation passed across the five affected test files (338 tests), app type checking, formatting, Oxlint, and ESLint. |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 4 — ledger: 26 prior finding(s) across 3 round(s) (26 never answered).
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 5 |
| 🟢 Low | 4 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
|
CI triage and the completed review panel are addressed at
Validation passed:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 7 — ledger: 20 prior finding(s) across 2 round(s) (0 never answered).
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 2 |
| 🟡 Medium | 3 |
| 🟢 Low | 4 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
|
The latest review findings are addressed in |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 8 — ledger: 20 prior finding(s) across 2 round(s) (0 never answered).
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 5 |
| 🟢 Low | 4 |
Panel: 8/8 reviewers contributed findings.
|
Addressed the latest attachment review in e701106. This round hardens upload location and asset-reference validation, same-origin view fetching, bounded canvas reads and buffering, dismissed-failure cleanup, and restored attachment locations. Validation passed: 440 focused tests with 2 expected failures, full app typecheck, changed-file lint and formatting, and baseline-aware Fallow. A fresh automated review is running on this head. |
christian-byrne
left a comment
There was a problem hiding this comment.
Independent exact-head review of a8d37e8 against core/1.54: sound. The repair restores target-native fetch behavior for ordinary canvas drops and confines same-origin /api/view validation to Agent attachment ingestion. Local retries=0 evidence: focused unit/component suites 326/326 pass; both loadWorkflowInMedia visible canvas-drop oracles pass at this head and both fail at restrictive parent e701106 (graph node count remains unchanged). I also verified bounded streaming/body cancellation, server-derived cap with conservative fallback and 100 MiB ceiling, size-aware source/upload deadlines, panel-close cancellation, and the shared three-slot permit remain intact. No unresolved review thread or adverse exact-head check observed; no product-branch mutation made.
Use the server's upload-size limit for agent attachments, upload up to three files concurrently, and cancel pending uploads when the panel closes. Removing a reference keeps its upload available for Undo, matching the current composer behavior. - Apply one extension allowlist to the picker and runtime validation. - Reserve 1 KiB for request overhead; fall back to 20 MiB for invalid server limits and cap advertised limits at 512 MiB. - Scale upload deadlines with file size, abort expired requests, and refresh the asset library after each completed batch. - Remove cancelled attachments immediately on panel disposal so reopening preserves a usable draft. - Keep user-removed references detached while their uploads finish; only Undo brings them back. - Dependencies: none. Panel-close cancellation versus undoable reference removal, persisted drafts, and file-size validation. The existing human findings have fixes and regression coverage; their threads remain open for the reviewer. <details><summary>Verification and source context</summary> - The first published integration failed the existing inline-reference browser test after Undo. Cancelling a removed reference permanently retired its attachment; current main intentionally preserves that upload for Undo. The repair removes the parent cancellation listener, preserving panel-disposal cancellation. - Three cloud browser scenarios, each repeated twice: six passes. They cover reference removal and Undo, closing/reopening during an upload, and accepting/rejecting files against the server limit. - Four unit/component suites: 336 passes. The component regression was also rerun after using the repository-supported deferred-promise pattern. - Commit hooks passed formatting, stylelint, type-aware Oxlint, ESLint, application/package typechecks, unused-translation and frozen-directory checks. GitHub checks run separately on the pushed revision. - The earlier preparation also verified cancellation and invalid-limit cases fail without their fixes. Browser commands use a private browser cache and a 60-second test timeout for dev-server startup and large fixture transfer. This remains the main-based attachment subset of #16385. It does not replace that PR's non-attachment work. Glossary: MiB = 1,048,576 bytes; KiB = 1,024 bytes. </details> <!-- authored-by:agent lane-revfold-10-1515 -->
Fixes the repo-checks failure on https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36519688675/job/109252271371 by removing declarations made unused by the generated release upload contract.
Validate stored upload names, preserve server locations, cancel source fetches, classify failures, refresh settled uploads, and bound batches.\n\nReview: #19348 (comment)
Addresses review feedback: #19348 (comment)
a8d37e8 to
2a198c3
Compare
Backports #16985 to
core/1.54.This preserves the release branch session/schema APIs while bringing over bounded attachment-upload concurrency, size-aware deadlines, cancellation, and authoritative server-limit handling.
Validation:
pnpm knippnpm typecheckgit diff --checkBackport-specific CI repair:
Justification: Agent release-backport authority permits operator merge to core/1.54 after target-aware exact-head review; head 2a198c3 passed 93 checks with no adverse conclusion, has zero unresolved review threads, and independent review found the refreshed 24-file patch unchanged and target-native.