Skip to content

[backport cloud/1.54] cover reference-only attachment-history previews - #19343

Merged
christian-byrne merged 4 commits into
cloud/1.54from
backport/18247-cloud-1.54
Sep 30, 2026
Merged

christian-byrne merged 4 commits into
cloud/1.54from
backport/18247-cloud-1.54

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Backport of #18247 to cloud/1.54.

Cherry-picked merge commit 45750c60bb5b560d67ae037378e6b9e821e7c6d7 and resolved the attachment-history E2E conflict using the target branch's composer/input drag convention, including the composer asset assertion. Preserves four scenarios: filename-only, filenames plus references, reference-only images, and reference-only image/video across reload and chat switching.

Validation:

  • targeted oxfmt: passed
  • targeted ESLint: passed
  • Playwright discovery: 4/four scenarios collected
  • hosted CI: Tests E2E passed the cloud project, all 16 Chromium shards, 0.5x/2x DPR projects, mobile Chrome/Safari, report merge, and final E2E status on a1a84aeb70
  • browser typecheck was attempted with the shared current-main dependency tree, but is not a valid stable-branch gate because it lacks stable-only dependencies (jsonata, vuefire, older Tiptap packages) and reports unrelated existing source errors

Do not merge until CI is green.

Cover image/video attachment previews after reload and chat switching,
including reference-only history.

<details><summary>Full context for agent readers</summary>

- Follow up the non-blocking coverage suggestions on [attachment-history
coverage
PR18244](#18244).
- Keep the single-image case and two distinct image fixtures. Add
history containing only `attachment_refs`, so `attachments` cannot hide
a broken fallback.
- Four cases cover one image, two images with filenames/references,
reference-only images, and mixed image/video references. Each verifies
reload, an empty new chat and restoration of the original chat.
- Assert exact filenames, decoded dimensions and Playwright visibility.
Empty video `currentSrc` returns a retryable mismatch; preview
assertions retain a ten-second timeout.
- No production changes. [Attachment restoration
PM-1148](https://linear.app/comfyorg/issue/PM-1148) and [original
regression acceptance
PM-1149](https://linear.app/comfyorg/issue/PM-1149) remain open for
unavailable media, raw-reference presentation, storage identity, video
playback and real-service persistence. Controlled-response video and
chat-switch coverage are now established.

The history response is independently specified rather than copied from
the outgoing attachments. The outgoing request still has an exact
filename assertion. Two images have different decoded widths (64 and
32), so duplicate-image recovery fails.

September 21 review-repair verification: all four cases passed with zero
retries against the preserved Cloud build from main `35524d57b8`, whose
served index matched SHA256
`23a259c26b2af1638d1018be346bf4d8da30cd36786aea403601399aff24bccd`. The
tested helper is byte-identical to [the published
repair](507c172).
Application/browser typechecks and mandatory commit/push hooks passed.
Fresh hosted checks and human re-review remain required.

Earlier sensitivity control: replacing only the `attachment_refs`
fallback with an empty list made the reference-only case fail after
reload, expecting two previews and receiving zero. Restoring production
code and rebuilding returned the then-three cases to green. That
counterfactual was not rerun for this helper repair and is not included
in the PR.

Each case emits before-reload, after-reload and after-chat-switch
screenshots. The inspected mixed-media after-chat-switch capture shows
the image and video preview together; full filenames and decoded
dimensions are established by the browser assertions, not the truncated
text. Playback is not tested.

Glossary: reference-only history contains resolved `attachment_refs`
without an `attachments` filename list; counterfactual means
deliberately disabling one behavior to verify test sensitivity.

</details>

---------

Co-authored-by: GitHub Action <action@github.com>
@vercel

vercel Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 30, 2026 4:55am UTC
billing-web-test Ignored Ignored Sep 30, 2026 4:55am UTC

Request Review

@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR labels Sep 29, 2026
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 07115998-f826-4c12-8b48-8c617ad97069

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1962 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1941 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.0 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.0 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 151ms TBT · 83.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.6 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.4 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 79ms TBT · 171.9 MB heap
vue-node-resize-workload: · 53.7 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 430ms TBT · 174.8 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 501ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 62.3 MB
canvas-idle: DOM nodes -131
canvas-idle: event listeners -95
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 32ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 80
canvas-mouse-sweep: task duration 933ms
canvas-mouse-sweep: script duration 171ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 72.3 MB
canvas-mouse-sweep: DOM nodes -279
canvas-mouse-sweep: event listeners -182
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 364ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.1 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 10
dom-widget-clipping: task duration 455ms
dom-widget-clipping: script duration 163ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.7 MB
dom-widget-clipping: DOM nodes 16
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 620ms
large-graph-idle: script duration 35ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 79.6 MB
large-graph-idle: DOM nodes -278
large-graph-idle: event listeners -193
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1707ms
large-graph-pan: script duration 835ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 73.6 MB
large-graph-pan: DOM nodes -284
large-graph-pan: event listeners -192
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1733ms
large-graph-zoom: script duration 798ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.0 MB
large-graph-zoom: DOM nodes -140
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 43
legacy-node-drag: task duration 1994ms
legacy-node-drag: script duration 974ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 83.9 MB
legacy-node-drag: DOM nodes -269
legacy-node-drag: event listeners -10
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 562ms
minimap-idle: script duration 33ms
minimap-idle: TBT 0ms
minimap-idle: heap used 84.1 MB
minimap-idle: DOM nodes -132
minimap-idle: event listeners -94
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 404ms
subgraph-dom-widget-clipping: script duration 140ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.4 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 495ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 75.0 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -210
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 26ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 783ms
subgraph-mouse-sweep: script duration 112ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 65.4 MB
subgraph-mouse-sweep: DOM nodes -130
subgraph-mouse-sweep: event listeners -119
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 33ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 966ms
subgraph-transition-enter: script duration 32ms
subgraph-transition-enter: TBT 151ms
subgraph-transition-enter: heap used 83.9 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5946ms
viewport-pan-sweep: script duration 2740ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 80.6 MB
viewport-pan-sweep: DOM nodes -269
viewport-pan-sweep: event listeners -147
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16711ms
vue-large-graph-idle: script duration 278ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.4 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 170
vue-large-graph-pan: task duration 20586ms
vue-large-graph-pan: script duration 947ms
vue-large-graph-pan: TBT 79ms
vue-large-graph-pan: heap used 171.9 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14929
vue-node-resize-workload: avg frame time 19ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 22ms
vue-node-resize-workload: style recalc duration 80ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6111ms
vue-node-resize-workload: script duration 115ms
vue-node-resize-workload: TBT 430ms
vue-node-resize-workload: heap used 174.8 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14931
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8434ms
vue-zoom-out-idle: script duration 137ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 171.2 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -11
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 22ms
workflow-execution: layout count 3
workflow-execution: style recalc count 19
workflow-execution: task duration 117ms
workflow-execution: script duration 11ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.5 MB
workflow-execution: DOM nodes 146
workflow-execution: event listeners 66
Raw data
{
  "timestamp": "2026-09-29T07:13:20.384Z",
  "gitSha": "5d0990f9b4d8587089ac95aa17b46d60f08c9d71",
  "branch": "backport/18247-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2052.222000000029,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.084000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 492.969,
      "heapDeltaBytes": 1723364,
      "heapUsedBytes": 71649548,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 8.871,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2034.721999999988,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.771999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 508.173,
      "heapDeltaBytes": -11245700,
      "heapUsedBytes": 59028360,
      "domNodes": -280,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.904000000000002,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2148.8200000000006,
      "styleRecalcs": 86,
      "styleRecalcDurationMs": 37.806,
      "layouts": 14,
      "layoutDurationMs": 4.463,
      "taskDurationMs": 1016.997,
      "heapDeltaBytes": -3104884,
      "heapUsedBytes": 68272828,
      "domNodes": -277,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 183.32,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1808.3219999999756,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 25.753,
      "layouts": 14,
      "layoutDurationMs": 3.4499999999999997,
      "taskDurationMs": 849.236,
      "heapDeltaBytes": 12468724,
      "heapUsedBytes": 83336944,
      "domNodes": -280,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 158.5,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1724.410999999975,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.256,
      "layouts": 6,
      "layoutDurationMs": 0.949,
      "taskDurationMs": 348.966,
      "heapDeltaBytes": 4656568,
      "heapUsedBytes": 75532044,
      "domNodes": 74,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 10.629,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1755.9830000000147,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 19.717,
      "layouts": 6,
      "layoutDurationMs": 1.351,
      "taskDurationMs": 378.218,
      "heapDeltaBytes": 4574552,
      "heapUsedBytes": 75670992,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 11.741999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 638.210000000015,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.436999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 446.141,
      "heapDeltaBytes": 18314892,
      "heapUsedBytes": 88880424,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 161.10000000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 689.8219999999355,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.257999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 463.5349999999999,
      "heapDeltaBytes": -7906632,
      "heapUsedBytes": 63581104,
      "domNodes": 14,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 164.638,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2049.712999999997,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.715000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 617.973,
      "heapDeltaBytes": 5824108,
      "heapUsedBytes": 81348908,
      "domNodes": -278,
      "jsHeapTotalBytes": -626688,
      "scriptDurationMs": 34.65700000000001,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2055.015000000026,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 6.297000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 622.5339999999999,
      "heapDeltaBytes": 8749824,
      "heapUsedBytes": 85607460,
      "domNodes": -277,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 36.23500000000001,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2347.875999999985,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 11.903,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1704.5410000000004,
      "heapDeltaBytes": -61756,
      "heapUsedBytes": 77573680,
      "domNodes": -284,
      "jsHeapTotalBytes": 122880,
      "scriptDurationMs": 840.8840000000001,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2299.4559999999638,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 13.284,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1709.167,
      "heapDeltaBytes": -932224,
      "heapUsedBytes": 76760824,
      "domNodes": -284,
      "jsHeapTotalBytes": 385024,
      "scriptDurationMs": 828.722,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3541.698999999994,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.686999999999998,
      "layouts": 60,
      "layoutDurationMs": 11.868,
      "taskDurationMs": 1702.913,
      "heapDeltaBytes": 9187732,
      "heapUsedBytes": 77041388,
      "domNodes": -281,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 771.0989999999999,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3654.05700000008,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 10.894999999999998,
      "layouts": 60,
      "layoutDurationMs": 11.820999999999998,
      "taskDurationMs": 1763.559,
      "heapDeltaBytes": 11303900,
      "heapUsedBytes": 78075332,
      "domNodes": 2,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 825.56,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3141.7319999999904,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 7.632,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1968.436,
      "heapDeltaBytes": 5634692,
      "heapUsedBytes": 86221672,
      "domNodes": -255,
      "jsHeapTotalBytes": 1626112,
      "scriptDurationMs": 964.675,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3177.8220000001056,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 7.477000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2018.7900000000002,
      "heapDeltaBytes": 8081320,
      "heapUsedBytes": 89775048,
      "domNodes": -283,
      "jsHeapTotalBytes": 577536,
      "scriptDurationMs": 984.1000000000001,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "minimap-idle",
      "durationMs": 1994.1550000000348,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.5529999999999988,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 526.3090000000001,
      "heapDeltaBytes": 21763404,
      "heapUsedBytes": 88224860,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 31.913999999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2034.1720000000123,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.410000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 598.2639999999999,
      "heapDeltaBytes": 9390416,
      "heapUsedBytes": 88243844,
      "domNodes": -268,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 34.44,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 603.385000000003,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.006999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 406.13800000000003,
      "heapDeltaBytes": 15177576,
      "heapUsedBytes": 88611500,
      "domNodes": 20,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 140.86700000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 576.9679999999653,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.548000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 402.38300000000004,
      "heapDeltaBytes": 15102092,
      "heapUsedBytes": 88440048,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 138.657,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.013000000029,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.31,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 489.06299999999993,
      "heapDeltaBytes": 594600,
      "heapUsedBytes": 74026820,
      "domNodes": -296,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.5329999999999995,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.8149999999841,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.640999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 500.0340000000001,
      "heapDeltaBytes": 9866520,
      "heapUsedBytes": 83170820,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 8.245000000000003,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1708.2100000000082,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 25.439999999999998,
      "layouts": 18,
      "layoutDurationMs": 4.222999999999999,
      "taskDurationMs": 801.921,
      "heapDeltaBytes": -3004120,
      "heapUsedBytes": 70487796,
      "domNodes": -295,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 111.04700000000001,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1675.7690000000593,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 27.538999999999998,
      "layouts": 18,
      "layoutDurationMs": 5.044,
      "taskDurationMs": 764.782,
      "heapDeltaBytes": -5830196,
      "heapUsedBytes": 66664248,
      "domNodes": 35,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 112.067,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1417.7790000000527,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 32.695,
      "layouts": 15,
      "layoutDurationMs": 15.567,
      "taskDurationMs": 965.9799999999998,
      "heapDeltaBytes": -5342132,
      "heapUsedBytes": 88014768,
      "domNodes": 13831,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 32.023999999999994,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 151,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8334.316,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 34.51899999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5799.021,
      "heapDeltaBytes": -21477404,
      "heapUsedBytes": 82527440,
      "domNodes": -267,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 2698.651,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8859.050000000025,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 36.30500000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6092.936,
      "heapDeltaBytes": 9973688,
      "heapUsedBytes": 86599240,
      "domNodes": -270,
      "jsHeapTotalBytes": -434176,
      "scriptDurationMs": 2780.8830000000003,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16864.965999999982,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16478.986,
      "heapDeltaBytes": -48796000,
      "heapUsedBytes": 179378212,
      "domNodes": -8068,
      "jsHeapTotalBytes": -19611648,
      "scriptDurationMs": 268.13499999999993,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17763.229000000025,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16943.216999999997,
      "heapDeltaBytes": -54043572,
      "heapUsedBytes": 180146808,
      "domNodes": -8068,
      "jsHeapTotalBytes": -15880192,
      "scriptDurationMs": 287.635,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20684.538000000033,
      "styleRecalcs": 170,
      "styleRecalcDurationMs": 17.32900000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20246.597,
      "heapDeltaBytes": -52520284,
      "heapUsedBytes": 166466784,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11853824,
      "scriptDurationMs": 919.694,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 48,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21290.694999999912,
      "styleRecalcs": 169,
      "styleRecalcDurationMs": 18.09099999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20924.652,
      "heapDeltaBytes": -45831568,
      "heapUsedBytes": 194016696,
      "domNodes": -8068,
      "jsHeapTotalBytes": -19894272,
      "scriptDurationMs": 973.607,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 109,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6263.17899999998,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 81.34800000000003,
      "layouts": 20,
      "layoutDurationMs": 22.41599999999999,
      "taskDurationMs": 6143.897,
      "heapDeltaBytes": -35372792,
      "heapUsedBytes": 183218396,
      "domNodes": -8068,
      "jsHeapTotalBytes": 17117184,
      "scriptDurationMs": 115.15299999999999,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 438,
      "frameDurationMs": 18.889999999999965,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6201.63500000001,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 78.43899999999998,
      "layouts": 20,
      "layoutDurationMs": 21.787,
      "taskDurationMs": 6078.3820000000005,
      "heapDeltaBytes": -35495728,
      "heapUsedBytes": 183423336,
      "domNodes": -8068,
      "jsHeapTotalBytes": 17506304,
      "scriptDurationMs": 114.28799999999998,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 421,
      "frameDurationMs": 18.329999999999927,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8663.937000000033,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8446.18,
      "heapDeltaBytes": 6472012,
      "heapUsedBytes": 179474928,
      "domNodes": 0,
      "jsHeapTotalBytes": -13893632,
      "scriptDurationMs": 135.328,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.773333333333238,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8663.121000000046,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8421.536000000002,
      "heapDeltaBytes": 6427336,
      "heapUsedBytes": 179604540,
      "domNodes": 0,
      "jsHeapTotalBytes": -8912896,
      "scriptDurationMs": 137.91500000000002,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 482.1770000000356,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 22.116999999999997,
      "layouts": 3,
      "layoutDurationMs": 1.7919999999999998,
      "taskDurationMs": 121.54199999999999,
      "heapDeltaBytes": 5004972,
      "heapUsedBytes": 74424816,
      "domNodes": 145,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 12.533999999999999,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 468.7109999999848,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 22.77,
      "layouts": 3,
      "layoutDurationMs": 1.2990000000000002,
      "taskDurationMs": 111.78399999999999,
      "heapDeltaBytes": 4889476,
      "heapUsedBytes": 73498660,
      "domNodes": 146,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 9.475,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50760 75942 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.3% 253
src/scripts/pnginfo.ts 21.4% 221

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/29/2026, 06:46:00 AM UTC

Links

@datadog-official

This comment has been minimized.

@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #19343   +/-   ##
=============================================
  Coverage              ?   83.93%           
=============================================
  Files                 ?     2121           
  Lines                 ?   127526           
  Branches              ?    34161           
=============================================
  Hits                  ?   107044           
  Misses                ?    20304           
  Partials              ?      178           
Flag Coverage Δ
unit 79.15% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 9 finding(s).

Severity Count
🟡 Medium 4
🟢 Low 4
⚪ Nit 1

Panel: 8/8 reviewers contributed findings.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Updated attachment-history coverage now checks the user turn only, distinguishes display labels from upload references, waits for every staged asset, closes the history-route race, and covers empty attachments falling back to valid attachment_refs. Focused transcript tests pass (38/38), ESLint and formatting pass, and Playwright discovers all 5 scenarios. Browser type checking reports only the release branch’s existing errors in unrelated UI, pricing, markdown, and auth modules; it reports no errors in these changed files. Fresh CI and Cursor review are running on the current head.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 29, 2026

@ryan-di ryan-di left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is described as a test-only backport of #18247, but commit bc17185 ("test(agent): harden attachment history coverage") also changes parseUserAttachments in agentTranscript.ts. It now falls back to attachment_refs when attachments is [].

  • That change isn't on main or the 1.55 branches. #18247 itself only changed the two browser-test files.
  • The current cloud backend doesn't write that shape. It leaves out attachments when it's empty, and builds attachment_refs from the same names.
  • #18712 has a fuller version of this fix and is labelled for 1.54, so its backport will conflict on these lines.

Could you drop the agentTranscript.ts / agentTranscript.test.ts changes and the "references when filenames are present but empty" E2E scenario, so this stays a plain backport? Please also update the description: it mentions 4 scenarios (the spec has 5) and doesn't mention the src/ change.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Addressed Ryan’s review at 0bae1eb: removed the production transcript fallback, its unit test, and the empty-filenames scenario. The backport is now limited to the original four test scenarios; the description is updated.

@christian-byrne
christian-byrne merged commit 5f4f158 into cloud/1.54 Sep 30, 2026
85 checks passed
@christian-byrne
christian-byrne deleted the backport/18247-cloud-1.54 branch September 30, 2026 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR greenlight risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants