Repository navigation
[backport cloud/1.54] fix(agent): report an approval ask the panel never delivered (#18952) - #19335
Conversation
A turn parked waiting for the user to approve a tool call, the approval
prompt never reached the panel, and nothing anywhere recorded it — so
this PR makes that drop report, and pins the user's journey as a spec.
- **What**: `reportError('failure_delivering_agent_approval_ask')` at
the two reachable sites where an `agent_ask` frame is discarded, plus
`browser_tests/tests/agent/agentApprovalSurvivesSocketDrop.spec.ts`
reproducing the reported flow through the real socket and the rendered
panel.
A user asked for an img2img workflow, then for img2video, and the panel
went dead. They restarted the agent tab to get out of it.
A session-id trace established that **the backend never hung.** The turn
was alive the whole time, parked waiting for the user to approve a tool
call, and the approval prompt never made it into the panel. That is the
worst shape a stall can take: the product is working and waiting on the
user, while the user sees a dead panel and no way to answer.
**There was no telemetry for it at all.** It reached us through a
feedback form, not a dashboard — and only because that one user happened
to paste a session id.
`useAgentSession.onStatus(false)` answers a transient websocket close
with `abortActiveTurn()` + `dropBackgroundTurns()`. The server never
learned the socket went away, so it keeps running the turn and then
emits `agent_ask` for the approval it is parked on. By then `transport`
is null and `backgroundTurns` is empty, so the frame reaches
`ingestBackgroundTurnEvent`, hits `if (!entry …) return`, and is gone.
Nothing errors.
It is specifically the *socket blip*, not a refresh. On a refresh the
ask comes back, because the persisted row carries `pending_ask` and
`normalizeAgentTranscript` rebuilds the card — which is why restarting
the tab "fixed" it for this user, and why this class only ever surfaces
through a form.
Two sites, tagged by `reason` so they split on the dashboard:
| `reason` | Site | Why it is the same user-visible outcome |
|---|---|---|
| `no-live-turn` | `ingestBackgroundTurnEvent`, `!entry` | The
socket-drop teardown left nothing to route the ask to. |
| `unknown-kind` | `handleAskEvent`, `kind !== 'run_approval'` | Renders
no card while the server still parks on the ask. |
The third `return` in `ingest` (`eventThreadId === undefined`) is
**unreachable for an ask** — `zAgentAskEvent` is
`zAgentPendingAsk.extend({ thread_id: z.string() })`, and
`agent_active_tab` is the only event with an optional `thread_id`,
handled above it. It is commented rather than instrumented, because a
report at a dead branch is noise that reads as coverage.
Deliberately **not** a `pushError`: the user cannot act on it, and a
notice would replace a silent stall with a stall plus a scary message.
This is for the dashboard.
**The spec's first two cases are `test.fail()` pins, on purpose.**
Fixing the delivery itself needs the turn to survive the blip, and that
is [#18152](#18152) —
on `main` there is no turn-recovery path at all. So this PR lands the
telemetry and the reproduction now, standing alone, and the pins flip
green when the delivery fix lands on top of #18152. Neither piece is
hostage to that stack.
The third case pushes the **same ask with no socket drop** and must stay
green. That is what stops the two pins from going vacuous on a renamed
locator, a gate, or reworded copy — without it, a card that never
renders under this fixture at all would look exactly like the defect.
Run against a cloud dev server plus the e2e ComfyUI container:
```
✘ 1 the approval card reaches the panel after a reconnect (expected)
✘ 2 the user can answer the ask that arrived after the reconnect (expected)
✓ 3 the same ask renders when the socket never drops
✓ 4 the fixture pushes an ask the client can parse
4 passed (33.4s)
```
Pin 1 fails for the stated reason, not an incidental one — with
`test.fail()` removed:
```
Error: expect(locator).toBeVisible() failed
Locator: locator('#agent-panel-root').getByText('Do you approve?')
Error: element(s) not found
```
- Store and transport unit suites: `392 passed (392)`.
- Agent subtree: `Test Files 137 passed (137)`, `Tests 2338 passed | 17
expected fail (2355)` (the expected fails are pre-existing).
- The four new store cases are **red on `main` production code** (`2
failed | 2 passed`), and the two that fail are the two reporting
assertions while both "stays quiet" guards pass — so they are not
tautological.
- `typecheck:app`, `typecheck:browser`, ESLint, type-aware Oxlint, Oxfmt
and Knip clean.
(cherry picked from commit 8223a93)
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
christian-byrne
left a comment
There was a problem hiding this comment.
Authorized release self-review at exact head ae911ae: reviewed all seven carried files against source merge 8223a93. The sole conflict is source-valid: cloud/1.54 has already removed draft-answer state, so the resolution adds the undeliverable-ask report but does not reintroduce dropDraft(). All browser_tests hunks are retained. Focused unit suites pass 97/97; removing the ask-ID ledger write makes the cross-routing dedupe test fail 2-vs-1. typecheck:app and focused type-aware Oxlint/ESLint/Oxfmt pass. Browser acceptance is currently blocked before its oracle by the target branch Agent gate; the existing agentPanelLifecycle control fails at the identical data-agent-gate-settled precondition, and no assertion was weakened. Hosted gates remain binding.
🎭 Playwright: ✅ 1958 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-29T07:12:23.331Z",
"gitSha": "0c732951b123ae2dfc52fd357b904a58810ebae3",
"branch": "backport-18952-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2087.6460000000066,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.782,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.592,
"heapDeltaBytes": -9508756,
"heapUsedBytes": 60941952,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.656000000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2053.810999999996,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.072999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.943,
"heapDeltaBytes": -12287516,
"heapUsedBytes": 58008556,
"domNodes": -282,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 10.145999999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2136.453999999958,
"styleRecalcs": 80,
"styleRecalcDurationMs": 37.467,
"layouts": 14,
"layoutDurationMs": 4.418,
"taskDurationMs": 1065.744,
"heapDeltaBytes": 7236492,
"heapUsedBytes": 77629644,
"domNodes": -283,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 188.245,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1864.2190000000483,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.532000000000004,
"layouts": 14,
"layoutDurationMs": 4.059,
"taskDurationMs": 910.57,
"heapDeltaBytes": -6450260,
"heapUsedBytes": 64751552,
"domNodes": -278,
"jsHeapTotalBytes": 7331840,
"scriptDurationMs": 167.325,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1729.7929999999724,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.006999999999998,
"layouts": 6,
"layoutDurationMs": 1.1289999999999998,
"taskDurationMs": 402.647,
"heapDeltaBytes": 4609480,
"heapUsedBytes": 74968536,
"domNodes": 75,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 13.674999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.183999999933,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.757000000000005,
"layouts": 6,
"layoutDurationMs": 1.0600000000000003,
"taskDurationMs": 397.94699999999995,
"heapDeltaBytes": 4333016,
"heapUsedBytes": 74883432,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 18.656,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 712.5220000000354,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.375000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.398,
"heapDeltaBytes": -7535496,
"heapUsedBytes": 63209404,
"domNodes": 16,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 164.75599999999997,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 737.3519999999871,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.887999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.1070000000001,
"heapDeltaBytes": -7952932,
"heapUsedBytes": 63214268,
"domNodes": 18,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 167.936,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2050.9440000000154,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.238,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 667.78,
"heapDeltaBytes": 7756500,
"heapUsedBytes": 84510124,
"domNodes": -275,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 35.632999999999996,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.9639999999936,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.291000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 657.9540000000001,
"heapDeltaBytes": 9914556,
"heapUsedBytes": 86663580,
"domNodes": -269,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 34.619,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2267.6680000000147,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.726999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1637.14,
"heapDeltaBytes": 22331624,
"heapUsedBytes": 89287040,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 815.072,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2463.877000000025,
"styleRecalcs": 62,
"styleRecalcDurationMs": 7.861999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1722.4099999999999,
"heapDeltaBytes": 26930816,
"heapUsedBytes": 92857492,
"domNodes": -280,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 859.738,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3642.1440000000302,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.443,
"layouts": 60,
"layoutDurationMs": 12.301999999999998,
"taskDurationMs": 1817.1559999999997,
"heapDeltaBytes": -7208716,
"heapUsedBytes": 71777100,
"domNodes": -288,
"jsHeapTotalBytes": 3567616,
"scriptDurationMs": 798.4350000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3633.788999999979,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.942,
"layouts": 60,
"layoutDurationMs": 11.962,
"taskDurationMs": 1769.9009999999998,
"heapDeltaBytes": 7989124,
"heapUsedBytes": 76050376,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 805.4409999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3234.0619999999944,
"styleRecalcs": 44,
"styleRecalcDurationMs": 9.287,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2051.544,
"heapDeltaBytes": 3345092,
"heapUsedBytes": 84125716,
"domNodes": -255,
"jsHeapTotalBytes": 839680,
"scriptDurationMs": 1020.8760000000001,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3131.9939999999633,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.818,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1979.9759999999999,
"heapDeltaBytes": 29122568,
"heapUsedBytes": 96793124,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 980.435,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2026.0040000000004,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.6750000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 678.75,
"heapDeltaBytes": -6300604,
"heapUsedBytes": 71510264,
"domNodes": -283,
"jsHeapTotalBytes": -364544,
"scriptDurationMs": 42.580000000000005,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2047.7809999999863,
"styleRecalcs": 5,
"styleRecalcDurationMs": 9.016999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 666.626,
"heapDeltaBytes": 6787780,
"heapUsedBytes": 85492984,
"domNodes": -274,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 39.466,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 645.9240000000364,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.31,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.65200000000004,
"heapDeltaBytes": 14861220,
"heapUsedBytes": 88267084,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 150.258,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 608.7830000000167,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.068999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.2469999999999,
"heapDeltaBytes": 15144724,
"heapUsedBytes": 88453916,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 144.446,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2018.5670000000187,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.637,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.187,
"heapDeltaBytes": 10475840,
"heapUsedBytes": 83526284,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.204,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2026.8090000000711,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.387,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 521.3100000000001,
"heapDeltaBytes": -14663344,
"heapUsedBytes": 58679920,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.37,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1734.1610000000287,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.477999999999998,
"layouts": 18,
"layoutDurationMs": 4.573,
"taskDurationMs": 826.8259999999999,
"heapDeltaBytes": -15348224,
"heapUsedBytes": 58023800,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 112.684,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1756.6679999999906,
"styleRecalcs": 79,
"styleRecalcDurationMs": 32.625,
"layouts": 18,
"layoutDurationMs": 5.0489999999999995,
"taskDurationMs": 861.3,
"heapDeltaBytes": 3587864,
"heapUsedBytes": 77063248,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 120.00099999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.8489999999938,
"styleRecalcs": 18,
"styleRecalcDurationMs": 34.022,
"layouts": 14,
"layoutDurationMs": 16.834,
"taskDurationMs": 1015.9239999999999,
"heapDeltaBytes": 20271588,
"heapUsedBytes": 105204300,
"domNodes": 13831,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 33.220000000000006,
"eventListeners": 2387,
"totalBlockingTimeMs": 152,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8798.764000000006,
"styleRecalcs": 247,
"styleRecalcDurationMs": 35.53099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6068.689000000001,
"heapDeltaBytes": 18270640,
"heapUsedBytes": 94752048,
"domNodes": -271,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 2760.233,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8910.23699999994,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.21200000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6161.876,
"heapDeltaBytes": -6831308,
"heapUsedBytes": 70010320,
"domNodes": -282,
"jsHeapTotalBytes": 2781184,
"scriptDurationMs": 2803.372,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17708.737999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16993.785000000003,
"heapDeltaBytes": -41335724,
"heapUsedBytes": 177071252,
"domNodes": -8068,
"jsHeapTotalBytes": -10235904,
"scriptDurationMs": 299.94,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17231.42599999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16692.619,
"heapDeltaBytes": -51046260,
"heapUsedBytes": 179255156,
"domNodes": -8068,
"jsHeapTotalBytes": -14254080,
"scriptDurationMs": 278.619,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21213.677000000018,
"styleRecalcs": 164,
"styleRecalcDurationMs": 19.840999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20989.988999999998,
"heapDeltaBytes": -35276704,
"heapUsedBytes": 190490216,
"domNodes": -8068,
"jsHeapTotalBytes": -15618048,
"scriptDurationMs": 948.3929999999999,
"eventListeners": -14925,
"totalBlockingTimeMs": 172,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21410.03699999999,
"styleRecalcs": 162,
"styleRecalcDurationMs": 20.363999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21086.893,
"heapDeltaBytes": -61492728,
"heapUsedBytes": 171678580,
"domNodes": -8068,
"jsHeapTotalBytes": -19337216,
"scriptDurationMs": 966.267,
"eventListeners": -14927,
"totalBlockingTimeMs": 50,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6286.846000000025,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.951,
"layouts": 20,
"layoutDurationMs": 25.51500000000001,
"taskDurationMs": 6175.009999999999,
"heapDeltaBytes": -57307868,
"heapUsedBytes": 175728072,
"domNodes": -8068,
"jsHeapTotalBytes": 11358208,
"scriptDurationMs": 115.32900000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 557,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6259.311000000025,
"styleRecalcs": 20,
"styleRecalcDurationMs": 102.29200000000004,
"layouts": 20,
"layoutDurationMs": 37.229,
"taskDurationMs": 6167.797,
"heapDeltaBytes": -47034772,
"heapUsedBytes": 165935396,
"domNodes": -8068,
"jsHeapTotalBytes": 10788864,
"scriptDurationMs": 110.891,
"eventListeners": -14931,
"totalBlockingTimeMs": 573,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8934.980999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8564.482000000002,
"heapDeltaBytes": -7057244,
"heapUsedBytes": 179478600,
"domNodes": 0,
"jsHeapTotalBytes": -12845056,
"scriptDurationMs": 146.965,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8889.258000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8507.589999999998,
"heapDeltaBytes": 13890632,
"heapUsedBytes": 196639780,
"domNodes": 0,
"jsHeapTotalBytes": -2883584,
"scriptDurationMs": 142.266,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 443.2959999999184,
"styleRecalcs": 13,
"styleRecalcDurationMs": 19.931,
"layouts": 3,
"layoutDurationMs": 0.8049999999999999,
"taskDurationMs": 108.871,
"heapDeltaBytes": 4784496,
"heapUsedBytes": 74265728,
"domNodes": 120,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.675,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 88.16000000001623,
"styleRecalcs": 6,
"styleRecalcDurationMs": 14.471,
"layouts": 2,
"layoutDurationMs": 1.0079999999999998,
"taskDurationMs": 64.776,
"heapDeltaBytes": 2952760,
"heapUsedBytes": 67733640,
"domNodes": 123,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.165,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #19335 +/- ##
=============================================
Coverage ? 83.99%
=============================================
Files ? 2120
Lines ? 126606
Branches ? 32077
=============================================
Hits ? 106338
Misses ? 20090
Partials ? 178
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Summary
Backports #18952 to
cloud/1.54, reporting approval asks that the Agent panel cannot deliver and preserving its black-box socket-drop contract.Changes
8223a93de30cd630338924e923e2f6fe9bb9d6e6, including the fixture andagentApprovalSurvivesSocketDrop.spec.ts.cloud/1.54's newer removal of draft-answer state while adding the source reporting call.Review Focus
dropDraft()behavior.reportedAskIds.add(data.ask_id)makes the cross-routing dedupe case fail with two reports instead of one.typecheck:app, focused type-aware Oxlint, ESLint, and formatting pass.agentPanelLifecyclecontrol both stop at the same pre-test release-harness gate (data-agent-gate-settlednever appears), before the approval oracle runs. No assertion or fixture was weakened.Source: #18952