Repository navigation
feat(website): the nav calls the catalogue the Hub - #19322
mariana953 wants to merge 2 commits into
Conversation
Hub is the name the product goes by, and the top-level nav entry was the last place still calling it Models. The address and the Browse Models entry under Products are unchanged here; they carry more with them.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (10)
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe English and Chinese navigation labels change from “Models” to “Hub”. Website component and end-to-end tests now check for “Hub”; the existing ChangesHub navigation label
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to Users will see Hub in English and Simplified Chinese, while the link still opens Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1d2158194f79ebd2b2877eaba70a7b3cfba12c51
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19322.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-b9diob71f-comfyui.vercel.app Last updated: 2026-09-29T01:54:25Z for |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19322 +/- ##
==========================================
- Coverage 84.20% 84.20% -0.01%
==========================================
Files 3221 3189 -32
Lines 156656 155895 -761
Branches 42505 42282 -223
==========================================
- Hits 131919 131276 -643
+ Misses 23023 22982 -41
+ Partials 1714 1637 -77
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 80 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Heads-up on the rest of the Hub rename: I'm taking the model-page URL move in FE-2972 (https://linear.app/comfyorg/issue/FE-2972). The model pages move from |
|
Perfect, thanks — that is exactly the split I was hoping for. This PR is label-only: One thing worth knowing for your PR: ten Generated by Claude Code |
|
Superseded by #19320, which now contains this PR's current head together with Mar's complete Hub/Cinematic design pass. The aggregate was rebased onto current main and audited bidirectionally before this PR was closed. |
|
Closing: this change already lives in #19320, so keeping it open only costs a second CI run for the same line. The whole of what this branch adds to Reopen if #19320 is split up and the nav name does not travel with it. Generated by Claude Code |
## Summary Lands Mar's ten current Hub and Cinematic Studio PRs together so they can be reviewed and merged as one coherent design pass. Mar's look, feel, CSS, copy, and layout decisions are preserved. The integration changes only reconcile her presentation with work already on main and fix confirmed functional defects. This PR supersedes: * #19313 — app-page “View on GitHub” * #19322 — Hub navigation label * #19383 — video example poster frame * #19403 — mobile polish for Re-shoot, outputs, tabs, and source previews * #19384 — numbered Workflow API steps * #19319 — take naming and removal of the non-functional progress bar * #19329 — real Cinematic option preview frames * #19416 — Cinematic output card aligned with model output presentation * #19387 — Hub feedback round * #19320 — final Hub design pass, including the latest Comfy API card marker ## Integration notes * Rebased onto current main at 25c2685, including Rob's Cinematic stack (#19326 and #19370), workflow audit (#19391), analytics (#19451), and SDK API snippets (#19323). * Keeps #19323's Python, TypeScript, and cURL tabs while retaining Mar's numbered key/download controls and collapsible steps. Manual upload and polling steps remain cURL-only. * Preserves Rob's image/video rendering paths and video thumbnails while applying Mar's final card, status, preview, and responsive presentation. * Preserves all four audited Change a material examples from #19391 while applying Mar's revised first-example wording; a regression test pins them. * Corrects the confirmed tall-workflow graph fit bug by calculating initial scale from both panel dimensions. * No unrelated product or visual changes were added. ## Validation On final head 6c0c446: * Website typecheck: 0 errors * Formatting: clean * Focused API, graph, and content suite: 153 tests passed * Source containment: all 150 files from the ten source PRs represented; only three expected Rob-integration files added * Structured data sweep: 331/331 slugs; no example-count, sample-count, or input-key regression * Pre-push Fallow audit: no introduced issues in 153 changed files * Commit hook stylelint, type-aware oxlint, and ESLint: clean for changed files ## Review focus Please review actual functional or integration defects. Mar owns the visual design and layout. In particular, verify that: * Cinematic image and video generation behavior from #19370 remains intact. * Mobile and source-preview behavior remains accessible. * Workflow catalogue, filters, and back-navigation state stay coherent. * API and example presentation remains correct without changing Mar's layout. * SDK tab switching and cURL-only manual steps are correctly reconciled. --------- Co-authored-by: benjcooley <benjcooley@gmail.com> Co-authored-by: GitHub Action <action@github.com>
Summary
The top-level nav entry that opens the catalogue now reads Hub, the name the product goes by, instead of Models.
Asked for by Eric in
#proj-comfy-hub("Let's use Hub as the official brand — we should change the url and menu copy to Hub"), and split out on its own at Ben's request, who is stacking the rest of the rename on top of it.Changes
nav.workshopreadsHubinenandzh-CN. Seven e2e assertions and six unit assertions that named the entry follow it.@visualbaselines moved —home-product-cards,home-get-started,pricing-tiers,pricing-faqandenterprise-faq, each at3-lgand4-xl. Those are full-viewport screenshots, so they carry the header; the shorter word shifts every nav item after it left. Only the widths where the desktop nav is visible changed, which is why1-smand2-mdare untouched, and the diff images showed the difference confined to the header row. Regenerated locally after confirming every unchanged baseline still passes byte-for-byte here, so this environment renders identically to CI's./models, and the Browse Models entry under Products (nav.comfyWorkshop) is untouched. Both carry more than a label with them — redirects, indexing and the other call sites — and Ben has that work.Review Focus
Nothing but the label moved. The entry's href, its NEW badge, its active-state behaviour and its build gating are unchanged, and the tests that covered each of those still cover them under the new name.
Every renamed assertion was checked to be the nav entry, not the catalogue's own Models tab:
workshop-workflows.spec.ts:413uses'Models'for the tab inside the catalogue and is left alone.workshop-visibility.spec.tsasserts the entry is absent when the flag is off; it now asserts that ofHub, so it still fails if the entry leaks out.Checks run locally on this head:
pnpm typecheckfor the website (0 errors),pnpm exec eslint apps/website(0), the header and navigation unit suites, and against a production buildheader-models-navigation.spec.ts(3),navigation.spec.ts(20) and the whole@visualproject (66). CI is green end to end on3d971baf63.Not from this branch:
apps/website's unit suite also has 3 failures insrc/composables/useWorkflowFormDraft.test.ts, which reproduce on a cleanorigin/mainworktree with that file byte-identical to main's.Screenshots (if applicable)
Preview: https://comfy-website-preview-pr-19322.vercel.app — the header's first entry.