Skip to content

feat(website): the nav calls the catalogue the Hub - #19322

Closed
mariana953 wants to merge 2 commits into
mainfrom
mariana/hub-nav-name
Closed

mariana953 wants to merge 2 commits into
mainfrom
mariana/hub-nav-name

Conversation

@mariana953

@mariana953 mariana953 commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The top-level nav entry that opens the catalogue now reads Hub, the name the product goes by, instead of Models.

Asked for by Eric in #proj-comfy-hub ("Let's use Hub as the official brand — we should change the url and menu copy to Hub"), and split out on its own at Ben's request, who is stacking the rest of the rename on top of it.

Changes

  • What: nav.workshop reads Hub in en and zh-CN. Seven e2e assertions and six unit assertions that named the entry follow it.
  • Screenshot baselines: ten @visual baselines moved — home-product-cards, home-get-started, pricing-tiers, pricing-faq and enterprise-faq, each at 3-lg and 4-xl. Those are full-viewport screenshots, so they carry the header; the shorter word shifts every nav item after it left. Only the widths where the desktop nav is visible changed, which is why 1-sm and 2-md are untouched, and the diff images showed the difference confined to the header row. Regenerated locally after confirming every unchanged baseline still passes byte-for-byte here, so this environment renders identically to CI's.
  • Deliberately not in this PR: the address is still /models, and the Browse Models entry under Products (nav.comfyWorkshop) is untouched. Both carry more than a label with them — redirects, indexing and the other call sites — and Ben has that work.
  • Dependencies: none.

Review Focus

Nothing but the label moved. The entry's href, its NEW badge, its active-state behaviour and its build gating are unchanged, and the tests that covered each of those still cover them under the new name.

Every renamed assertion was checked to be the nav entry, not the catalogue's own Models tab: workshop-workflows.spec.ts:413 uses 'Models' for the tab inside the catalogue and is left alone.

workshop-visibility.spec.ts asserts the entry is absent when the flag is off; it now asserts that of Hub, so it still fails if the entry leaks out.

Checks run locally on this head: pnpm typecheck for the website (0 errors), pnpm exec eslint apps/website (0), the header and navigation unit suites, and against a production build header-models-navigation.spec.ts (3), navigation.spec.ts (20) and the whole @visual project (66). CI is green end to end on 3d971baf63.

Not from this branch: apps/website's unit suite also has 3 failures in src/composables/useWorkflowFormDraft.test.ts, which reproduce on a clean origin/main worktree with that file byte-identical to main's.

Screenshots (if applicable)

Preview: https://comfy-website-preview-pr-19322.vercel.app — the header's first entry.

Hub is the name the product goes by, and the top-level nav entry was the
last place still calling it Models. The address and the Browse Models entry
under Products are unchanged here; they carry more with them.
@mariana953
mariana953 requested review from a team September 29, 2026 00:44
@vercel

vercel Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 29, 2026 1:48am UTC
billing-web-test Ignored Ignored Sep 29, 2026 1:48am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 1361e383-5b09-446d-b945-7d7984b7d524

📥 Commits

Reviewing files that changed from the base of the PR and between e7ae97e and 3d971ba.

⛔ Files ignored due to path filters (10)
  • apps/website/e2e/visual-responsive.spec.ts-snapshots/enterprise-faq-3-lg-visual-linux.png is excluded by !**/*.png
  • apps/website/e2e/visual-responsive.spec.ts-snapshots/enterprise-faq-4-xl-visual-linux.png is excluded by !**/*.png
  • apps/website/e2e/visual-responsive.spec.ts-snapshots/home-get-started-3-lg-visual-linux.png is excluded by !**/*.png
  • apps/website/e2e/visual-responsive.spec.ts-snapshots/home-get-started-4-xl-visual-linux.png is excluded by !**/*.png
  • apps/website/e2e/visual-responsive.spec.ts-snapshots/home-product-cards-3-lg-visual-linux.png is excluded by !**/*.png
  • apps/website/e2e/visual-responsive.spec.ts-snapshots/home-product-cards-4-xl-visual-linux.png is excluded by !**/*.png
  • apps/website/e2e/visual-responsive.spec.ts-snapshots/pricing-faq-3-lg-visual-linux.png is excluded by !**/*.png
  • apps/website/e2e/visual-responsive.spec.ts-snapshots/pricing-faq-4-xl-visual-linux.png is excluded by !**/*.png
  • apps/website/e2e/visual-responsive.spec.ts-snapshots/pricing-tiers-3-lg-visual-linux.png is excluded by !**/*.png
  • apps/website/e2e/visual-responsive.spec.ts-snapshots/pricing-tiers-4-xl-visual-linux.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • apps/website/e2e/header-models-navigation.spec.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The English and Chinese navigation labels change from “Models” to “Hub”. Website component and end-to-end tests now check for “Hub”; the existing /models paths remain unchanged.

Changes

Hub navigation label

Layer / File(s) Summary
Update label and navigation checks
apps/website/src/i18n/translations.ts, apps/website/src/components/common/HeaderMain/*, apps/website/e2e/*
The English and Chinese navigation labels change to “Hub”. Component and end-to-end tests use “Hub” in navigation checks, while existing /models paths remain.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Suggested reviewers: benjcooley

Merge Risk: ⚪ Minimal · up to 3d971

Users will see Hub in English and Simplified Chinese, while the link still opens /models and visibility is unchanged. No concrete user-facing regression is established, so no merge-blocking risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 3d971

The change affects 1 system.

Changed systems: apps/website

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — apps/website (service) was modified; 9 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in apps/website/e2e/navigation.spec.ts: The top-level navigation label expected by the test changes from “Models” to “Hub”.
  • observed — Modified behavior in apps/website/e2e/navigation.spec.ts: The desktop NEW-badge check now targets the “Hub” link instead of the “Models” link.
  • observed — Modified behavior in apps/website/e2e/navigation.spec.ts: The mobile menu item check replaces “Models” with “Hub”.
  • observed — Modified behavior in apps/website/e2e/navigation.spec.ts: The mobile NEW-badge check now targets “Hub” instead of “Models”.
🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed The PR title and both commit subjects use feat or test; none uses bug-fix language. The changed files are exclusively under apps/website, which this check explicitly exempts because its end-to-e…
Website End-To-End Regression Coverage ✅ Passed The PR changes apps/website/src/i18n/translations.ts, so the check applies. The runtime change is limited to navigation copy: Models/模型 becomes Hub/Hub; the description states that the `/mod…
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed-file list contains only website navigation tests and translations. It contains no files under src/lib/litegraph/, src/ecs/, or files related to graph entities. The ADR-LAYOUT and ADR-E…
Title check ✅ Passed The title clearly and concisely describes the main change: renaming the catalogue navigation label to Hub.
Description check ✅ Passed The description includes the required Summary, Changes, Review Focus, and Screenshots sections. It explains the label change, unchanged behavior, test coverage, dependencies, screenshot updates, and r…
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Sep 29, 2026
@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 1d2158194f79ebd2b2877eaba70a7b3cfba12c51

Full docs: ADR-DEVEX-LINT-0015

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-19322.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-b9diob71f-comfyui.vercel.app

Last updated: 2026-09-29T01:54:25Z for 3d971ba

@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #19322      +/-   ##
==========================================
- Coverage   84.20%   84.20%   -0.01%     
==========================================
  Files        3221     3189      -32     
  Lines      156656   155895     -761     
  Branches    42505    42282     -223     
==========================================
- Hits       131919   131276     -643     
+ Misses      23023    22982      -41     
+ Partials     1714     1637      -77     
Flag Coverage Δ
billing-web-unit ?
website-unit 78.72% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/website/src/i18n/translations.ts 100.00% <ø> (ø)

... and 80 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 29, 2026
@MaanilVerma

Copy link
Copy Markdown
Collaborator

Heads-up on the rest of the Hub rename: I'm taking the model-page URL move in FE-2972 (https://linear.app/comfyorg/issue/FE-2972). The model pages move from /models/<provider--model--task>/ to clean /hub/models/<model-task>/ addresses. Every old URL gets one 308 hop, and /models/ goes to /hub/models/. That work is branched from main, so this PR can land on its own. When both are in, I'll line up the nav label and link targets so the Hub tab points at /hub/models/. The router side is comfy-router#46. I've let Ben know so the move only happens in one PR.

Copy link
Copy Markdown
Contributor Author

Perfect, thanks — that is exactly the split I was hoping for. This PR is label-only: nav.workshop reads Hub in en and zh-CN, and the entry's href stays /models, as does the Browse Models entry under Products (nav.comfyWorkshop). So it is safe to land before FE-2972 and nothing here will fight the redirects; when your move is in, pointing this entry at /hub/models/ is a one-line change on top.

One thing worth knowing for your PR: ten @visual baselines carry the header, so any nav text or width change turns them red. In this PR the ones at 3-lg and 4-xl had to be regenerated — home-product-cards, home-get-started, pricing-tiers, pricing-faq and enterprise-faq. The 1-sm and 2-md ones were untouched, because the desktop nav is hidden at those widths. If your change only moves hrefs, the pixels should hold; if it also changes visible text, expect the same ten.


Generated by Claude Code

@benjcooley

Copy link
Copy Markdown
Collaborator

Superseded by #19320, which now contains this PR's current head together with Mar's complete Hub/Cinematic design pass. The aggregate was rebased onto current main and audited bidirectionally before this PR was closed.

@benjcooley benjcooley closed this Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

Closing: this change already lives in #19320, so keeping it open only costs a second CI run for the same line.

The whole of what this branch adds to apps/website/src is one entry — 'nav.workshop': { en: 'Hub', 'zh-CN': 'Hub' } — and it is present in #19320's translations.ts today. Checked against #19320 at 243e730792, line by line over this branch's own diff from its merge base, ignoring tests.

Reopen if #19320 is split up and the nav name does not travel with it.


Generated by Claude Code

benjcooley added a commit that referenced this pull request Sep 29, 2026
## Summary

Lands Mar's ten current Hub and Cinematic Studio PRs together so they
can be reviewed and merged as one coherent design pass. Mar's look,
feel, CSS, copy, and layout decisions are preserved. The integration
changes only reconcile her presentation with work already on main and
fix confirmed functional defects.

This PR supersedes:

* #19313 — app-page “View on GitHub”
* #19322 — Hub navigation label
* #19383 — video example poster frame
* #19403 — mobile polish for Re-shoot, outputs, tabs, and source
previews
* #19384 — numbered Workflow API steps
* #19319 — take naming and removal of the non-functional progress bar
* #19329 — real Cinematic option preview frames
* #19416 — Cinematic output card aligned with model output presentation
* #19387 — Hub feedback round
* #19320 — final Hub design pass, including the latest Comfy API card
marker

## Integration notes

* Rebased onto current main at 25c2685, including Rob's Cinematic
stack (#19326 and #19370), workflow audit (#19391), analytics (#19451),
and SDK API snippets (#19323).
* Keeps #19323's Python, TypeScript, and cURL tabs while retaining Mar's
numbered key/download controls and collapsible steps. Manual upload and
polling steps remain cURL-only.
* Preserves Rob's image/video rendering paths and video thumbnails while
applying Mar's final card, status, preview, and responsive presentation.
* Preserves all four audited Change a material examples from #19391
while applying Mar's revised first-example wording; a regression test
pins them.
* Corrects the confirmed tall-workflow graph fit bug by calculating
initial scale from both panel dimensions.
* No unrelated product or visual changes were added.

## Validation

On final head 6c0c446:

* Website typecheck: 0 errors
* Formatting: clean
* Focused API, graph, and content suite: 153 tests passed
* Source containment: all 150 files from the ten source PRs represented;
only three expected Rob-integration files added
* Structured data sweep: 331/331 slugs; no example-count, sample-count,
or input-key regression
* Pre-push Fallow audit: no introduced issues in 153 changed files
* Commit hook stylelint, type-aware oxlint, and ESLint: clean for
changed files

## Review focus

Please review actual functional or integration defects. Mar owns the
visual design and layout. In particular, verify that:

* Cinematic image and video generation behavior from #19370 remains
intact.
* Mobile and source-preview behavior remains accessible.
* Workflow catalogue, filters, and back-navigation state stay coherent.
* API and example presentation remains correct without changing Mar's
layout.
* SDK tab switching and cURL-only manual steps are correctly reconciled.

---------

Co-authored-by: benjcooley <benjcooley@gmail.com>
Co-authored-by: GitHub Action <action@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants