Skip to content

feat(website): link the model catalogue from the footer on every page - #19400

Closed
MaanilVerma wants to merge 5 commits into
mariana/hub-nav-namefrom
maanil/fe-2975-hub-footer-nav-link
Closed

MaanilVerma wants to merge 5 commits into
mariana/hub-nav-namefrom
maanil/fe-2975-hub-footer-nav-link

Conversation

@MaanilVerma

@MaanilVerma MaanilVerma commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Every page now has a plain footer link to the model catalogue at /models/, in the server HTML, so crawlers can reach the Hub from anywhere on the site. Before this, only /platform/router/ and its zh-CN twin linked to it, and without the trailing slash.

Stacked on #19322.

Changes

  • What:
    • The footer's Models column opens with "ComfyUI Models" (zh-CN "ComfyUI 模型"), linking to routes.workshop. It shows on every page and locale and doesn't depend on the flag.
    • routes.workshop is now /models/, and it's the only place the catalogue URL lives. I folded modelsShowcase (the same URL) into it, so FE-2972 PR B moves the catalogue to /hub/models/ by changing that one line.
    • Locale-invariant route matching now ignores the trailing slash, so /models/<slug> still never gets a /zh-CN prefix.
    • Consumers that add a query now produce /models/?q=.... The apps back link lost a doubled slash.

Review Focus

  • The nav tab stays behind the flag and only renders after mount, per FE-2914. It isn't in the server HTML with the flag on or off, so the footer is the always-crawlable path. When the flag is on, the tab now links to /models/.
  • Changed from the ticket: I skipped the dist build-check script, since scripts/check-models-html.ts doesn't exist. A raw-HTML e2e over /, /pricing/, /zh-CN/ and /zh-CN/pricing/ covers the same thing, and follows the existing workshop-visibility.spec.ts pattern.
  • Changed from the ticket: the anchor text is Title Case, "ComfyUI Models", to match the column's other links. The ticket's "Hub" label only applies to the nav, which isn't touched here.

Fixes FE-2975
https://linear.app/comfyorg/issue/FE-2975/link-to-models-from-the-site-footer-and-nav

@MaanilVerma MaanilVerma added the cursor-review Trigger multi-model Cursor agent review on this PR label Sep 29, 2026
@MaanilVerma MaanilVerma self-assigned this Sep 29, 2026
@vercel

vercel Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 29, 2026 9:56am UTC
billing-web-test Ignored Ignored Sep 29, 2026 9:56am UTC

Request Review

@MaanilVerma

MaanilVerma commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator Author

QA

Local astro build (WORKSHOP_IN_BUILD default, i.e. on) and astro preview, before (base 3d971baf63) and after (ffb1032513).

Check Proof Result
Footer link to the catalogue in raw HTML on /, /pricing/, zh-CN, ja, a launch page and supported-models grep -c 'href="/models/"' dist/<page>/index.html: before 0 on all 7 pages, after 1 on each Pass
Same as a crawler, JS off curl -s -A "$UA" localhost:4321$P | grep -c 'href="/models/"' with Googlebot smartphone and GPTBot UAs for / /pricing/ /zh-CN/ /zh-CN/pricing/ /ja/ /seedance-2.5/ /p/supported-models/: 1 on all 14. Prod today: 0 on / /pricing/ /zh-CN/ Pass
Footer landmark, JS disabled Playwright javaScriptEnabled: false, getByRole('contentinfo').getByRole('link', { name }): / and /pricing/ "ComfyUI Models" → /models/, /zh-CN/ "ComfyUI 模型" → /models/ Pass
No internal link to /models without the slash grep -rlE 'href="/models["?]' dist --include='*.html' | wc -l: before 2 (/platform/router/, /zh-CN/platform/router/), after 0. Every page with the site footer (911 of 1155 HTML files; the one other <footer> is the auth shell on /forgot-password/) links /models/ Pass
Nav tab, flag off or JS off Server HTML of / has no "Hub" link (the tab renders after mount, behind the flag). workshop-visibility.spec.ts "keeps the public site when PostHog is unavailable" passes (Hub count 0) Pass, unchanged
Nav tab, flag on header-models-navigation.spec.ts at 390, 1024 and 1440: the Hub link's href is /models/ Pass
zh-CN model pages stay unprefixed routes.test.ts "leaves the default locale unprefixed" (/models/seedance-2/ in zh-CN) fails without the slash-insensitive matching and passes with it Pass
Red → green unit tests vitest run SiteFooter.test.ts routes.test.ts: base source 3 failed (footer en/zh-CN, workshop route), after 30/30 pass Pass
Affected e2e playwright test on workshop-visibility, header-models-navigation, homepage, router, workshop-workflows, workshop: 72 passed, 3 failed. The failures are environment-only: the local build points at staging (stagingcloud/stagingapi where the spec expects testcloud/testapi), and "Sign in to run" is missing before any navigation. CI builds against the test env. Pass (3 env-bound)
CI website-unit fix (5fd6c90844) Three tests still expected the old unslashed /models: mainNavigation.test.ts, ModelsApiHero.test.ts and RouterProviderCoverageSection.test.ts. The nav test now asserts the real behaviour: with the flag on, both entries (the top-level Hub tab and Products → Browse Models) link to routes.workshop = /models/; with it off, neither does. vitest run on those 3 plus the 6 touched test files: 9 files, 81/81 pass Pass
Gates pnpm typecheck (website) 0 errors; eslint and oxfmt clean on the changed files; pnpm knip clean; pre-push fallow "No issues in 33 changed files" Pass
Diff scope git diff origin/mariana/hub-nav-name --stat: 19 files, +53/-34, only routes, footer, one translation key, 4 route consumers, tests Pass

With WORKSHOP_IN_BUILD=0 the build still has /models/ (the showcase), so the footer link never points at a 404.

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: d18085a8-6f81-487f-9881-bd43e17c44bf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

📦 Bundle Size

⏳ Size data collection in progress…

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 3d971baf634e75e8957cbb84e4fd1560d46abea8

Full docs: ADR-DEVEX-LINT-0015

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-19400.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-1t90oh8em-comfyui.vercel.app

Last updated: 2026-09-29T09:58:32Z for 8d72f1b

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 29, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @MaanilVerma.

Found 6 finding(s).

Severity Count
🟠 High 3
🟡 Medium 1
🟢 Low 2

Panel: 8/8 reviewers contributed findings.

Comment thread apps/website/src/config/routes.ts Resolved
Comment thread apps/website/src/config/routes.ts Resolved
@codecov

codecov Bot commented Sep 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                   Coverage Diff                    @@
##           mariana/hub-nav-name   #19400      +/-   ##
========================================================
- Coverage                 84.20%   84.18%   -0.03%     
========================================================
  Files                      3189     3180       -9     
  Lines                    155895   155734     -161     
  Branches                  42282    42263      -19     
========================================================
- Hits                     131276   131098     -178     
+ Misses                    22982    22981       -1     
- Partials                   1637     1655      +18     
Flag Coverage Δ
website-unit 78.48% <100.00%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/website/src/components/common/SiteFooter.vue 95.23% <ø> (ø)
...ponents/workshop/cinematic-studio/AppsBackLink.vue 100.00% <100.00%> (ø)
apps/website/src/config/routes.ts 100.00% <100.00%> (ø)
apps/website/src/i18n/translations.ts 100.00% <ø> (ø)
...s/website/src/templates/platform/ModelsApiHero.vue 100.00% <ø> (ø)
...mplates/platform/RouterProviderCoverageSection.vue 100.00% <ø> (ø)

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

Replaced by #19419: rebuilt on main without #19322's Hub rename, per owner. The nav stays 'Models'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant