Repository navigation
feat(website): link the model catalogue from the footer on every page - #19400
MaanilVerma wants to merge 5 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
QALocal
With |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌐 Website E2ETip All tests passed.
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3d971baf634e75e8957cbb84e4fd1560d46abea8
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19400.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-1t90oh8em-comfyui.vercel.app Last updated: 2026-09-29T09:58:32Z for |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @MaanilVerma.
Found 6 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 3 |
| 🟡 Medium | 1 |
| 🟢 Low | 2 |
Panel: 8/8 reviewers contributed findings.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## mariana/hub-nav-name #19400 +/- ##
========================================================
- Coverage 84.20% 84.18% -0.03%
========================================================
Files 3189 3180 -9
Lines 155895 155734 -161
Branches 42282 42263 -19
========================================================
- Hits 131276 131098 -178
+ Misses 22982 22981 -1
- Partials 1637 1655 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 39 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Every page now has a plain footer link to the model catalogue at
/models/, in the server HTML, so crawlers can reach the Hub from anywhere on the site. Before this, only/platform/router/and its zh-CN twin linked to it, and without the trailing slash.Stacked on #19322.
Changes
routes.workshop. It shows on every page and locale and doesn't depend on the flag.routes.workshopis now/models/, and it's the only place the catalogue URL lives. I foldedmodelsShowcase(the same URL) into it, so FE-2972 PR B moves the catalogue to/hub/models/by changing that one line./models/<slug>still never gets a/zh-CNprefix./models/?q=.... The apps back link lost a doubled slash.Review Focus
/models/.distbuild-check script, sincescripts/check-models-html.tsdoesn't exist. A raw-HTML e2e over/,/pricing/,/zh-CN/and/zh-CN/pricing/covers the same thing, and follows the existingworkshop-visibility.spec.tspattern.Fixes FE-2975
https://linear.app/comfyorg/issue/FE-2975/link-to-models-from-the-site-footer-and-nav