Repository navigation
[backport cloud/1.54] fix(workspace): restore invite-link i18n strings - #19300
dante01yoon wants to merge 2 commits into
Conversation
The pending-invite row menu rendered the raw key workspacePanel.members.actions.copyInviteLink instead of "Copy invite link". #17315 added the components and their locale strings in one commit on main, but only the components reached this release line, so every string that PR introduced is absent from src/locales here: - workspacePanel.members.actions.copyInviteLink - workspacePanel.inviteLinks.{sentTitle,sentLead,copyLink,copied,copyAll} The inviteLinks keys back the invite-confirmation step, which leaked the same raw keys. Values are copied verbatim from main for en and all 14 translated locales, so non-English users get translations rather than an English fallback. Adds a regression test that renders the menu against the shipped en bundle and fails on any accessible name starting with "workspacePanel.".
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
No code changes from this — the review was skipped, not failed, and the skip is intentional repo policy rather than something wrong with this PR.
That said, this isn't a pure cherry-pick — the locale entries were placed by hand and there's a new regression test that has never been reviewed on @coderabbitai review |
🎭 Playwright: ✅ 1960 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-28T22:29:21.867Z",
"gitSha": "c71ffd0de2ba3308ea319a1bd2c344cb88853434",
"branch": "glary/fix-invite-link-i18n-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2053.5500000000297,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.6419999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.509,
"heapDeltaBytes": -11815752,
"heapUsedBytes": 58721404,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.776000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2033.6960000000204,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.7059999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.53999999999996,
"heapDeltaBytes": 10374152,
"heapUsedBytes": 81279916,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.949000000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1737.2689999999693,
"styleRecalcs": 74,
"styleRecalcDurationMs": 18.955,
"layouts": 14,
"layoutDurationMs": 2.5709999999999997,
"taskDurationMs": 712.361,
"heapDeltaBytes": -12295864,
"heapUsedBytes": 58530460,
"domNodes": -283,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 113.53099999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1722.1289999999954,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.714000000000002,
"layouts": 14,
"layoutDurationMs": 2.314,
"taskDurationMs": 627.567,
"heapDeltaBytes": 3897760,
"heapUsedBytes": 74846140,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 97.677,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1669.3169999999782,
"styleRecalcs": 30,
"styleRecalcDurationMs": 11.536000000000001,
"layouts": 6,
"layoutDurationMs": 0.8659999999999999,
"taskDurationMs": 275.737,
"heapDeltaBytes": 4324168,
"heapUsedBytes": 74885072,
"domNodes": 79,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7.727000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1675.2060000000029,
"styleRecalcs": 29,
"styleRecalcDurationMs": 10.445999999999998,
"layouts": 6,
"layoutDurationMs": 0.828,
"taskDurationMs": 278.63300000000004,
"heapDeltaBytes": 4250972,
"heapUsedBytes": 74866420,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7.7,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 514.9230000000102,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.9239999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 320.64799999999997,
"heapDeltaBytes": 18678840,
"heapUsedBytes": 89201904,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 108.35600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 512.8399999999829,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.214,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 318.05800000000005,
"heapDeltaBytes": 18620088,
"heapUsedBytes": 89224916,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 107.366,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2021.6949999999656,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.687000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.116,
"heapDeltaBytes": 11318952,
"heapUsedBytes": 87975448,
"domNodes": -267,
"jsHeapTotalBytes": -2985984,
"scriptDurationMs": 19.060000000000002,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2007.6419999999757,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.983999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.063,
"heapDeltaBytes": 2379040,
"heapUsedBytes": 78841432,
"domNodes": -282,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 24.423999999999996,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2148.590000000013,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.772000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1191.6390000000001,
"heapDeltaBytes": 6929252,
"heapUsedBytes": 84272256,
"domNodes": -268,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 552.763,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2143.9170000000445,
"styleRecalcs": 67,
"styleRecalcDurationMs": 7.028999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1203.075,
"heapDeltaBytes": 9266176,
"heapUsedBytes": 86885568,
"domNodes": -246,
"jsHeapTotalBytes": 909312,
"scriptDurationMs": 563.767,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3070.779000000016,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.008000000000001,
"layouts": 60,
"layoutDurationMs": 7.674,
"taskDurationMs": 1189.9679999999998,
"heapDeltaBytes": 10410508,
"heapUsedBytes": 75924272,
"domNodes": -278,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 503.40399999999994,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3153.6290000000236,
"styleRecalcs": 66,
"styleRecalcDurationMs": 9.777999999999999,
"layouts": 60,
"layoutDurationMs": 8.231,
"taskDurationMs": 1286.8210000000001,
"heapDeltaBytes": -7931672,
"heapUsedBytes": 70539420,
"domNodes": -288,
"jsHeapTotalBytes": 4091904,
"scriptDurationMs": 531.521,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2234.8910000000046,
"styleRecalcs": 42,
"styleRecalcDurationMs": 3.760999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1322.3000000000002,
"heapDeltaBytes": 16192512,
"heapUsedBytes": 84203684,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 631.6089999999999,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2256.90800000001,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.235000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1373.9470000000001,
"heapDeltaBytes": 2884604,
"heapUsedBytes": 83812524,
"domNodes": -246,
"jsHeapTotalBytes": 315392,
"scriptDurationMs": 651.518,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2016.7109999999866,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.018000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.644,
"heapDeltaBytes": 2068308,
"heapUsedBytes": 82218272,
"domNodes": -274,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 23.385999999999996,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2031.4620000000332,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.7810000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.379,
"heapDeltaBytes": 5812684,
"heapUsedBytes": 83589428,
"domNodes": -272,
"jsHeapTotalBytes": -2461696,
"scriptDurationMs": 21.453999999999994,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 495.1489999999694,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.860000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 289.06299999999993,
"heapDeltaBytes": 14875412,
"heapUsedBytes": 88111200,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 92.77199999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 497.49700000000985,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.897000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 290.585,
"heapDeltaBytes": 14364140,
"heapUsedBytes": 87028748,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 93.71499999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.3480000000027,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.9030000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.63599999999997,
"heapDeltaBytes": 6630520,
"heapUsedBytes": 79976780,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.120999999999998,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2009.3259999999873,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.631,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.28200000000004,
"heapDeltaBytes": 5218476,
"heapUsedBytes": 78087876,
"domNodes": -296,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 6.227999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1676.7320000000154,
"styleRecalcs": 78,
"styleRecalcDurationMs": 16.93,
"layouts": 18,
"layoutDurationMs": 2.6069999999999998,
"taskDurationMs": 591.8209999999999,
"heapDeltaBytes": -9652576,
"heapUsedBytes": 62991812,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 65.76400000000001,
"eventListeners": -238,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.7389999999746,
"styleRecalcs": 77,
"styleRecalcDurationMs": 17.177999999999997,
"layouts": 18,
"layoutDurationMs": 2.6,
"taskDurationMs": 593.6400000000001,
"heapDeltaBytes": -10774660,
"heapUsedBytes": 62081536,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 65.704,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 883.0009999999788,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.027000000000005,
"layouts": 16,
"layoutDurationMs": 9.930000000000001,
"taskDurationMs": 678.9000000000001,
"heapDeltaBytes": 21970764,
"heapUsedBytes": 106410416,
"domNodes": 13831,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 20.178,
"eventListeners": 2385,
"totalBlockingTimeMs": 111,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8152.973999999972,
"styleRecalcs": 248,
"styleRecalcDurationMs": 19.806000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4109.554,
"heapDeltaBytes": 13709240,
"heapUsedBytes": 90190752,
"domNodes": -271,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 1807.7810000000002,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8182.038999999975,
"styleRecalcs": 249,
"styleRecalcDurationMs": 23.709999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4312.071,
"heapDeltaBytes": 20391232,
"heapUsedBytes": 97094672,
"domNodes": -266,
"jsHeapTotalBytes": 385024,
"scriptDurationMs": 1960.736,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10624.662,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10234.978000000001,
"heapDeltaBytes": -39057420,
"heapUsedBytes": 178704684,
"domNodes": -8068,
"jsHeapTotalBytes": -10219520,
"scriptDurationMs": 140.35999999999999,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10760.44499999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10355.865,
"heapDeltaBytes": -39402568,
"heapUsedBytes": 183395888,
"domNodes": -8068,
"jsHeapTotalBytes": -9736192,
"scriptDurationMs": 140.77200000000002,
"eventListeners": -14937,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13351.454000000047,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.900999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12835.059999999998,
"heapDeltaBytes": -32194056,
"heapUsedBytes": 186527288,
"domNodes": -8068,
"jsHeapTotalBytes": -9039872,
"scriptDurationMs": 604.3909999999998,
"eventListeners": -14931,
"totalBlockingTimeMs": 8,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13843.009999999937,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.067999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13110.239999999998,
"heapDeltaBytes": -39849392,
"heapUsedBytes": 177667748,
"domNodes": -8068,
"jsHeapTotalBytes": -14938112,
"scriptDurationMs": 651.9710000000001,
"eventListeners": -14933,
"totalBlockingTimeMs": 36,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 3953.895999999986,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.46500000000002,
"layouts": 20,
"layoutDurationMs": 17.591999999999995,
"taskDurationMs": 3842.7830000000004,
"heapDeltaBytes": -35218040,
"heapUsedBytes": 183268916,
"domNodes": -8068,
"jsHeapTotalBytes": 15745024,
"scriptDurationMs": 53.851,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4014.805000000024,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.87300000000001,
"layouts": 20,
"layoutDurationMs": 18.516000000000005,
"taskDurationMs": 3899.6130000000003,
"heapDeltaBytes": -35122792,
"heapUsedBytes": 182944548,
"domNodes": -8068,
"jsHeapTotalBytes": 13328384,
"scriptDurationMs": 63.88100000000001,
"eventListeners": -14933,
"totalBlockingTimeMs": 77,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5337.8999999999905,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5186.923,
"heapDeltaBytes": 8895596,
"heapUsedBytes": 180145416,
"domNodes": 0,
"jsHeapTotalBytes": -14417920,
"scriptDurationMs": 60.838,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5340.135000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5213.69,
"heapDeltaBytes": -5494840,
"heapUsedBytes": 165976588,
"domNodes": 0,
"jsHeapTotalBytes": -21495808,
"scriptDurationMs": 57.143,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 432.69599999996444,
"styleRecalcs": 18,
"styleRecalcDurationMs": 14.452,
"layouts": 3,
"layoutDurationMs": 1.106,
"taskDurationMs": 84.52699999999999,
"heapDeltaBytes": 4997624,
"heapUsedBytes": 73570252,
"domNodes": 147,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.023000000000001,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 437.0529999999917,
"styleRecalcs": 18,
"styleRecalcDurationMs": 14.721000000000002,
"layouts": 3,
"layoutDurationMs": 1.2049999999999998,
"taskDurationMs": 78.339,
"heapDeltaBytes": 4908720,
"heapUsedBytes": 74329940,
"domNodes": 144,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.836,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
docs/guidance/testing-principles.md forbids loops in a test body: a loop over outputs is one assertion on the whole collection. Matches the queryAllByRole+toHaveLength form already used earlier in this file. Still fails with the locale entries reverted.
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 3 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: a5cd119 | Docs | View more details | Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #19300 +/- ##
=============================================
Coverage ? 66.85%
=============================================
Files ? 1677
Lines ? 75771
Branches ? 0
=============================================
Hits ? 50655
Misses ? 25116
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
huang47
left a comment
There was a problem hiding this comment.
e2e failed which might need some rework, let me know when it's ready for review
PR Created by the Glary-Bot Agent
The pending-invite row menu in Workspace > Members renders the raw key
workspacePanel.members.actions.copyInviteLinkinstead of "Copy invite link" on the currently deployed release line.Root cause
#17315 added the invite-link components and their locale strings in a single commit on
main. Only the components reached this release line —PendingInvitesList.vuereferences the key three times here, butsrc/locales/never contained it oncloud/1.54(git log -S copyInviteLink origin/cloud/1.54 -- src/locales/en/main.jsonis empty). Since the key is absent from the English bundle, theenfallback insrc/i18n.tscannot rescue it, so every locale shows the raw key.Auditing all 154
workspacePanel.*keys referenced by code on this branch found exactly 6 missing — the full set #17315 introduced:workspacePanel.members.actions.copyInviteLink— pending-invite row menu (the reported bug)workspacePanel.inviteLinks.{sentTitle,sentLead,copyLink,copied,copyAll}— invite-confirmation step (InviteMemberDialogContent.vue,InviteLinkList.vue), which leaked the same raw keysChanges
enand all 14 translated locales. Every value is copied verbatim frommain— nothing is hand-written — so non-English users get real translations rather than an English fallback. Key ordering matchesmainexactly, and all 15 files stay byte-identical toserializeLocaleoutput, so a laterpnpm localerun won't reshuffle them.enbundle and fails on any accessible name starting withworkspacePanel.. Verified it fails on the unfixed tree withReceived: workspacePanel.members.actions.copyInviteLink, and passes after.No runtime code is touched.
mainandcloud/1.55already carry these keys, so this is release-line-only.Note for the next 1.54 version bump
.source-manifest.jsonis intentionally left alone (advancing it needsOPENAI_API_KEY, and on this line it only moves in version-bump commits). Editingenmarks these keys invalidated, sopnpm locale:checklists them as pending — expected after any en edit here. At the next bump the i18n run may reword them; that is a re-translation, not a lost backport, since the committed values came straight frommain.Verification
PendingInvitesList+InviteMemberDialogContent+inviteLinks+i18nsuites pass (89 tests)typecheck:app,oxfmt,oxlint --type-aware,eslint— all cleanpnpm locale:checkexits 0; the 84 prunable keys it reports are pre-existingagent.*orphans, identical before and after this commit — this change newly orphans zero keysvue-i18ninstance inenandzh, including thesentTitle/copyAllplural formsPendingInvitesListvia Storybook with the real bundle, reproduced the raw key, then confirmed the fix (screenshots below)Follow-ups filed separately
subscription.preview.billingAddressis missing on this branch the same way (present onmainas "Billing address", rendered unconditionally atUnifiedStripePaymentSelector.vue:27) — a raw key in a payment flow. Filed as a separate ticket; not folded in here to keep this PR focused.@intlify/vue-i18n/no-missing-keysis not enabled ineslint.config.ts(onlyno-raw-textis), which is why this class of dropped-key backport reaches production silently.Screenshots