Repository navigation
[backport cloud/1.55] FE-3046 refactor(design-system): move buttonVariants into @comfyorg/design-system - #19232
Conversation
…esign-system (#19098) - Linear: FE-3046 **Merge order:** #19096 (ADR 0034 amendment) merges first. Until it does, ADR 0034 rule 4 still forbids account-ui from using the design system, which B does. ## Why `buttonVariants` lived in `src/components/ui/button/button.variants.ts`, inside the private root package, so a workspace package could not render a button with the app's exact classes. PR B (`@comfyorg/account-ui` checkout surfaces) needs those classes to render the embedded checkout identically in the cloud app and in billing-web. No visual change. ## How - `git mv` of `button.variants.ts` into `packages/design-system/src/`, content unchanged. - `packages/design-system/package.json`: new export `./button.variants`, a `files` entry, and `cva` (`catalog:`) as a dependency. - Every importer in `src/` (Button.vue, Button.stories.ts, CloudSocialAuthButtons.vue, InlinePromptEditor.vue, and the ten components that import the `ButtonVariants` type) now reads from `@comfyorg/design-system/button.variants`. The old path is deleted, no re-export shim. `apps/website` keeps its own copy. ## Review Focus The file content is byte-identical (rename only). The only decision is the entry name `./button.variants`, mirroring `./workspaceAvatar`. ## Stack | PR | branch | base | title | |---|---|---|---| | #19097 | `jaewon/billing-web-remove-plan-grid` | `main` | `FE-3045 refactor(billing-web): drop the billing-web plan grid; hosts own plan selection` | | **A #19098 (this PR)** | **`jaewon/design-system-button-variants`** | **#19097** | **`FE-3046 refactor(design-system): move buttonVariants into @comfyorg/design-system`** | | B #19099 | `jaewon/account-ui-checkout-surfaces` | A | `FE-3046 feat(account-ui): shared checkout confirm, saved-method selector, card form and success` | | C #19100 | `jaewon/workspace-adopt-account-ui-checkout` | B | `FE-3046 refactor(workspace): render the subscription checkout steps from account-ui` | | D #19101 | `jaewon/billing-web-shared-checkout` | C | `FE-3046 feat(billing-web): render the shared embedded checkout` | | E #19104 | `jaewon/billing-web-success-invite` | D | `FE-3046 feat(billing-web): invite your team from the checkout success step` | | F #19105 | `jaewon/checkout-3ds-failure-copy` | E | `FE-3047 fix(account-ui): clear decline toasts once a retry succeeds` | | G #19106 | `jaewon/billing-web-return-close-tab` | F | `FE-3048 fix(billing-web): return to the host by closing the checkout tab` | | H #19115 | `jaewon/checkout-cta-reachable` | G | `FE-3050 fix(account-ui): keep the checkout CTA reachable when notices grow the confirm step` | ```mermaid graph LR P0[#19097: remove plan grid] --> A[A: design-system buttonVariants] A --> B[B: account-ui checkout surfaces] B --> C[C: workspace adopts account-ui] C --> D[D: billing-web shared checkout] D --> E[E: billing-web success invite] E --> F[F: stale decline toasts] F --> G[G: close the billing tab] G --> H[H: reachable checkout CTA] style A fill:#f9d71c,stroke:#333,color:#000 ``` ## AS IS / TO BE Rename only, no rendered change, so no screenshots. | AS IS | TO BE | | --- | --- | | `@/components/ui/button/button.variants` | `@comfyorg/design-system/button.variants` | --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
🌐 Website E2ETip All tests passed.
🎭 Playwright: ✅ 2121 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 45f2da1b0310dc6fa6ca360b899526cd0902257e
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-28T11:32:53.321Z",
"gitSha": "778d42b6b447828162e80c71a3cc5d70afb0c8d6",
"branch": "backport-19098-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1991.3729999999532,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.393,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.50100000000003,
"heapDeltaBytes": -5322968,
"heapUsedBytes": 62367584,
"domNodes": -259,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.450000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1990.9870000000183,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.243,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.926,
"heapDeltaBytes": 9928032,
"heapUsedBytes": 77529708,
"domNodes": -257,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.713999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.601000000036,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.217999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 781.2699999999999,
"heapDeltaBytes": -6034400,
"heapUsedBytes": 61434116,
"domNodes": -259,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 158.74,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1743.7820000000102,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.955,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 712.2969999999999,
"heapDeltaBytes": 5221568,
"heapUsedBytes": 67871176,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 164.637,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1681.6289999999867,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.709000000000001,
"layouts": 6,
"layoutDurationMs": 1.0140000000000002,
"taskDurationMs": 313.76599999999996,
"heapDeltaBytes": 3043032,
"heapUsedBytes": 70551500,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.271999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.7360000000308,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.859000000000002,
"layouts": 6,
"layoutDurationMs": 1.0579999999999998,
"taskDurationMs": 313.853,
"heapDeltaBytes": 3169856,
"heapUsedBytes": 70680276,
"domNodes": 78,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.402999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 642.4899999999525,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.744999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.3589999999999,
"heapDeltaBytes": 18919040,
"heapUsedBytes": 86865132,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 170.566,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 626.529000000005,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.343000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.179,
"heapDeltaBytes": 18568912,
"heapUsedBytes": 86277172,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 169.02800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1222.7249999999685,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 884.9979999999999,
"heapDeltaBytes": 12525908,
"heapUsedBytes": 102691068,
"domNodes": -266,
"jsHeapTotalBytes": 22171648,
"scriptDurationMs": 65.82099999999998,
"eventListeners": -195,
"totalBlockingTimeMs": 594,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1204.1939999999158,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 852.8990000000001,
"heapDeltaBytes": 38527064,
"heapUsedBytes": 106590788,
"domNodes": 0,
"jsHeapTotalBytes": 18247680,
"scriptDurationMs": 71.20700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 590,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.9300000000098,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.9089999999995,
"heapDeltaBytes": 14318520,
"heapUsedBytes": 90884252,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.30899999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 236,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.8389999999317,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.4610000000001,
"heapDeltaBytes": 14945528,
"heapUsedBytes": 90495164,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.087,
"eventListeners": 0,
"totalBlockingTimeMs": 230,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10416.205999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9536.733,
"heapDeltaBytes": 11879256,
"heapUsedBytes": 93899244,
"domNodes": -18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 7889.262000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1117,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10069.420000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9233.967999999999,
"heapDeltaBytes": 12548924,
"heapUsedBytes": 94612000,
"domNodes": -14,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 7624.099,
"eventListeners": 0,
"totalBlockingTimeMs": 854,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10652.539999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9824.565,
"heapDeltaBytes": -6774968,
"heapUsedBytes": 75100392,
"domNodes": -10,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 8225.504999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 1343,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10879.125000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10057.532,
"heapDeltaBytes": 11814528,
"heapUsedBytes": 94101356,
"domNodes": -14,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 8397.859999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1283,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2037.7920000000245,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.833999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 587.0920000000001,
"heapDeltaBytes": -7367324,
"heapUsedBytes": 79585556,
"domNodes": -248,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 32.483,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2016.8659999999363,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.847999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 537.715,
"heapDeltaBytes": -3096768,
"heapUsedBytes": 83713300,
"domNodes": -246,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 34.742,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2228.7340000000313,
"styleRecalcs": 68,
"styleRecalcDurationMs": 15.272999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1615.144,
"heapDeltaBytes": 20176200,
"heapUsedBytes": 84270796,
"domNodes": -246,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 831.3770000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2273.6149999999498,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.366000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1623.2930000000003,
"heapDeltaBytes": 20228960,
"heapUsedBytes": 84440140,
"domNodes": -245,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 855.8939999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3480.062000000032,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.79,
"layouts": 60,
"layoutDurationMs": 12.771999999999998,
"taskDurationMs": 1650.2120000000002,
"heapDeltaBytes": 8453820,
"heapUsedBytes": 74282636,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 772.122,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3505.1999999999452,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.143,
"layouts": 60,
"layoutDurationMs": 12.656,
"taskDurationMs": 1650.9590000000003,
"heapDeltaBytes": 8417852,
"heapUsedBytes": 74525464,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 777.548,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3068.6399999999594,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.461999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1874.472,
"heapDeltaBytes": 23591140,
"heapUsedBytes": 89777440,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 973.6220000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3100.6830000000036,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.127000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1813.882,
"heapDeltaBytes": 22526120,
"heapUsedBytes": 88957512,
"domNodes": 8,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1042.743,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2050.68,
"styleRecalcs": 8,
"styleRecalcDurationMs": 11.147,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 564.708,
"heapDeltaBytes": -5626244,
"heapUsedBytes": 83115780,
"domNodes": -246,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 35.611000000000004,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2032.8320000000986,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.418000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 568.189,
"heapDeltaBytes": -4784280,
"heapUsedBytes": 83838920,
"domNodes": -248,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 32.455999999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 571.8469999999911,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.498,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.904,
"heapDeltaBytes": 14055976,
"heapUsedBytes": 83629032,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 141.97,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 582.1200000000317,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.401999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.74699999999996,
"heapDeltaBytes": 14023140,
"heapUsedBytes": 83652056,
"domNodes": 21,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 142.29500000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2014.5729999999844,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.472000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.39399999999995,
"heapDeltaBytes": -6286280,
"heapUsedBytes": 64009400,
"domNodes": -278,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.805,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2003.6039999999957,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.093000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.685,
"heapDeltaBytes": -14847332,
"heapUsedBytes": 55054176,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.105999999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.411000000036,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.513000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 739.662,
"heapDeltaBytes": 1505728,
"heapUsedBytes": 71410516,
"domNodes": -277,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 106.41499999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.3299999999617,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.071,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 736.411,
"heapDeltaBytes": -13119416,
"heapUsedBytes": 56089160,
"domNodes": -276,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 105.167,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.3880000000581,
"styleRecalcs": 16,
"styleRecalcDurationMs": 28.359,
"layouts": 5,
"layoutDurationMs": 13.049999999999999,
"taskDurationMs": 854.2149999999999,
"heapDeltaBytes": -6257668,
"heapUsedBytes": 81978764,
"domNodes": 13667,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 29.805999999999994,
"eventListeners": 2383,
"totalBlockingTimeMs": 140,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8270.711000000007,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.315,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5644.639,
"heapDeltaBytes": -10264024,
"heapUsedBytes": 76474400,
"domNodes": -240,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 2714.087,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8332.117999999922,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.50399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5711.03,
"heapDeltaBytes": -10776040,
"heapUsedBytes": 76183924,
"domNodes": -243,
"jsHeapTotalBytes": 745472,
"scriptDurationMs": 2755.0600000000004,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 16652.649999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16030.045999999998,
"heapDeltaBytes": -37242964,
"heapUsedBytes": 177283904,
"domNodes": -8060,
"jsHeapTotalBytes": -10731520,
"scriptDurationMs": 244.08800000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12660.716999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12013.725999999999,
"heapDeltaBytes": -59421900,
"heapUsedBytes": 170329860,
"domNodes": -8062,
"jsHeapTotalBytes": -16748544,
"scriptDurationMs": 252.38,
"eventListeners": -14928,
"totalBlockingTimeMs": 1,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 19967.47400000004,
"styleRecalcs": 158,
"styleRecalcDurationMs": 15.598,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19609.263,
"heapDeltaBytes": -43038888,
"heapUsedBytes": 180627644,
"domNodes": -8062,
"jsHeapTotalBytes": -15376384,
"scriptDurationMs": 872.442,
"eventListeners": -14928,
"totalBlockingTimeMs": 9,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20162.08400000005,
"styleRecalcs": 155,
"styleRecalcDurationMs": 16.266000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19859.262000000002,
"heapDeltaBytes": -33668532,
"heapUsedBytes": 191821640,
"domNodes": -8065,
"jsHeapTotalBytes": -18952192,
"scriptDurationMs": 853.124,
"eventListeners": -14928,
"totalBlockingTimeMs": 52,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4620.227,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.53400000000002,
"layouts": 20,
"layoutDurationMs": 23.164999999999992,
"taskDurationMs": 4478.726000000001,
"heapDeltaBytes": -40798688,
"heapUsedBytes": 179728024,
"domNodes": -8062,
"jsHeapTotalBytes": 19005440,
"scriptDurationMs": 89.174,
"eventListeners": -14928,
"totalBlockingTimeMs": 46,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6164.395000000013,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.954,
"layouts": 20,
"layoutDurationMs": 22.434999999999995,
"taskDurationMs": 6060.923000000001,
"heapDeltaBytes": -43424924,
"heapUsedBytes": 182090688,
"domNodes": -8061,
"jsHeapTotalBytes": 15458304,
"scriptDurationMs": 108.579,
"eventListeners": -14928,
"totalBlockingTimeMs": 416,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8342.038000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7952.511000000001,
"heapDeltaBytes": 37779392,
"heapUsedBytes": 194640472,
"domNodes": 0,
"jsHeapTotalBytes": -5242880,
"scriptDurationMs": 117.97199999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6306.761000000051,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5844.998000000002,
"heapDeltaBytes": 8857436,
"heapUsedBytes": 200422500,
"domNodes": 0,
"jsHeapTotalBytes": -27525120,
"scriptDurationMs": 97.14900000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 456.42799999995987,
"styleRecalcs": 20,
"styleRecalcDurationMs": 31.251,
"layouts": 5,
"layoutDurationMs": 1.9980000000000002,
"taskDurationMs": 136.249,
"heapDeltaBytes": 5154848,
"heapUsedBytes": 67271864,
"domNodes": 153,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.101,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 474.2740000000367,
"styleRecalcs": 20,
"styleRecalcDurationMs": 25.351,
"layouts": 5,
"layoutDurationMs": 2.21,
"taskDurationMs": 126.59400000000001,
"heapDeltaBytes": 5025480,
"heapUsedBytes": 70585016,
"domNodes": 146,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 12.232999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #19232 +/- ##
=============================================
Coverage ? 83.72%
=============================================
Files ? 3026
Lines ? 149784
Branches ? 40637
=============================================
Hits ? 125403
Misses ? 23058
Partials ? 1323
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Verified against #19098: exact file list, no conflict markers, and all required checks pass. The package/lockfile change is scoped to adding the existing catalog cva dependency to the internal design-system importer; it does not refresh versions or transitive dependencies.
…19099, #19100, #19101, #19104) (#19443) ## Why Backport of the FE-3046 billing-web shared-checkout stack to `cloud/1.55`. The auto-backport bot hit cherry-pick conflicts on each of these. The 1.55 release needs billing-web to render the same checkout as the app, including the team invite on success. ## How ### Cherry-picked (in order, `-x`) | PR | main squash | | |---|---|---| | #19098 (A) | | skipped: already on `cloud/1.55` via #19232 | | #19099 (B) | | skipped: already on `cloud/1.55` via #19309 | | #19100 (C) | `4bfdc8a68c` | render the subscription checkout steps from account-ui | | #19101 (D) | `d5cf71ce27` | billing-web renders the shared embedded checkout | | #19104 (E) | `592588bdd6` | team invite on the checkout success step (squash includes #19105, #19106, #19115) | No other prerequisite was cherry-picked. ### Conflicts and resolutions - **C, `SubscriptionAddPaymentPreviewWorkspace.stripe.test.ts`** (renamed from `UnifiedStripePaymentSelector.test.ts`). 1.55 mocks telemetry with an explicit factory because it lacks #18497; main automocks it. Took C's file as is. `src/platform/telemetry/__mocks__/index.ts` exists on 1.55, so the automock resolves and the test passes. - **D, `apps/billing-web/src/views/CheckoutView.vue`**. 1.55 has #19304 (backport of #19185, show the server's refusal reason), which main does not have yet. Kept D's checkout and kept 1.55's `refusal()` on the subscribe failure and the quote-failure panel. Also used `refusal()` for D's new promotion-code re-quote failure, as the upstream `jaewon/checkout-quote-stale-recovery` stack does. Dropped the now-unused `coded`. - **E, `apps/billing-web/src/session/billingWebAuth.ts`** (modify/delete). The file does not exist on 1.55 because the unified web session work (#18880, #18881) is not backported. Deleted it and applied E's change to what 1.55 has: `billingWebClient.ts` gains the `BillingWebClient` type (`BillingClient & { invites }`) and `invites: createWorkspaceInviteCommands({ transport })` on its single `createBillingWebClient`. - **E, `BillingShell.vue`**. Kept 1.55's `createBillingWebClient(billingWebSessionClient())` and added E's `provideWorkspaceInvites(client.invites)`. - **E, `HostedSurface.vue`**. Kept 1.55's `useBillingWebSession` and added E's `returnToHost` import (the return link now closes the tab, from #19106). - **E, `CheckoutView.vue`**. Kept `refusal` as above and took E's `inviteCopy` and `useWorkspaceInvites()`. - **E, `useSubscriptionCheckout.ts`**. Kept 1.55's `useEventListener` import and added E's `watch` and `ToastMessageOptions`. 1.55 does not use `onScopeDispose`, so it is not imported. - **E, `useSubscriptionCheckout.test.ts`**. The toast mock gains E's `remove`. 1.55 has no `removeGroup` usage, so `mockToastRemoveGroup` is not added. The cloud branch takes the same resolved commits from the core backport; they applied without further conflicts. One extra commit updates a #19304 test case. For a refused subscribe with `OPERATION_ALREADY_PENDING`, it expected the generic failure copy because 1.55 had no copy for that code. D adds that copy, so the case now expects billing-web's own wording, matching the upstream stack. ## Verification - `pnpm typecheck` (app, account-core, billing-web, account-ui, billing-contract): pass - billing-web unit tests: 277/277 - account-ui unit tests: 224/224 - account-core unit tests: 1226/1226 - `src/platform/workspace` + `src/platform/cloud/subscription`: 2325 passed, 1 expected fail - oxfmt, oxlint and eslint on the changed files: clean ## AS IS / TO BE Same UI as the original PRs; see the AS IS / TO BE media in #19101 and #19104. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Backport of #19098 to
cloud/1.55Automatically created by backport workflow.