Repository navigation
[chore] Update Ingest API types from cloud@6d1e6b7 - #19212
Conversation
🎭 Playwright: ✅ 2156 passed, 0 failed · 2 flaky📊 Browser Reports
🌐 Website E2ETip All tests passed.
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since be3e1a1308cda85b371ff800a65c4eaf97f35263
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 10 MB gzipDetailsSummary
Category Glance App Entry Points — 3.77 kBMain entry bundles and manifests
Status: 1 added Graph Workspace — 1.45 MBGraph editor runtime, canvas, workflow orchestration
Status: 3 added Views & Navigation — 133 kBTop-level views, pages, and routed surfaces
Status: 18 added Panels & Settings — 643 kBConfiguration panels, inspectors, and settings screens
Status: 28 added User & Accounts — 39.4 kBAuthentication, profile, and account management bundles
Status: 11 added Editors & Dialogs — 126 kBModals, dialogs, drawers, and in-app editors
Status: 8 added UI Components — 125 kBReusable component library chunks
Status: 16 added Data & Services — 4.06 MBStores, services, APIs, and repositories
Status: 15 added Utilities & Hooks — 582 kBHelpers, composables, and utility bundles
Status: 37 added Vendor & Third-Party — 17.4 MBExternal libraries and shared vendor chunks
Status: 18 added Other — 17.9 MBBundles that do not match a named category
Status: 300 added ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-29T06:25:22.405Z",
"gitSha": "2b4b7acf2d7d012e0b15a073a395d254d9f96417",
"branch": "update-ingest-types",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2043.4750000000008,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.4190000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.66300000000007,
"heapDeltaBytes": -36649640,
"heapUsedBytes": 62037376,
"domNodes": -228,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 9.45,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622944,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2035.5350000000954,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.663,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.846,
"heapDeltaBytes": -17540160,
"heapUsedBytes": 61191760,
"domNodes": -228,
"jsHeapTotalBytes": -1048576,
"scriptDurationMs": 9.629999999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1779.375000000016,
"styleRecalcs": 71,
"styleRecalcDurationMs": 17.886,
"layouts": 12,
"layoutDurationMs": 4.6,
"taskDurationMs": 802.343,
"heapDeltaBytes": -37996544,
"heapUsedBytes": 60603600,
"domNodes": -228,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 183.418,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018691,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1780.1789999999755,
"styleRecalcs": 70,
"styleRecalcDurationMs": 17.735,
"layouts": 12,
"layoutDurationMs": 5.278,
"taskDurationMs": 780.089,
"heapDeltaBytes": -43240992,
"heapUsedBytes": 55308904,
"domNodes": -228,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 186.62499999999997,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.2870000000235,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.780999999999999,
"layouts": 6,
"layoutDurationMs": 1.3220000000000003,
"taskDurationMs": 346.082,
"heapDeltaBytes": -18526332,
"heapUsedBytes": 79969372,
"domNodes": 53,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 12.101999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.4109999999846,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.049,
"layouts": 6,
"layoutDurationMs": 1.242,
"taskDurationMs": 334.245,
"heapDeltaBytes": -18697764,
"heapUsedBytes": 79560944,
"domNodes": 53,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 11.431999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 665.0349999999889,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.8860000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.39000000000004,
"heapDeltaBytes": -1636556,
"heapUsedBytes": 96532560,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 173.716,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6625,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 680.2069999999958,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.3219999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.20799999999997,
"heapDeltaBytes": -1829196,
"heapUsedBytes": 96790948,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 161.72799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1158.2010000000196,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 821.532,
"heapDeltaBytes": 6465676,
"heapUsedBytes": 82208928,
"domNodes": 0,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 66.23299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 547,
"frameDurationMs": 35.351515151515166,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1160.541999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 835.6080000000001,
"heapDeltaBytes": 6355940,
"heapUsedBytes": 83738860,
"domNodes": 0,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 65.03500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 540,
"frameDurationMs": 34.31176470588236,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 857.6049999999782,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.32400000000064,
"heapDeltaBytes": 15800468,
"heapUsedBytes": 90245940,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 167.835,
"eventListeners": 0,
"totalBlockingTimeMs": 239,
"frameDurationMs": 25.491176470588204,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.6639999999952,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.6780000000003,
"heapDeltaBytes": 11948960,
"heapUsedBytes": 93145596,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 171.07700000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 237,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10312.90200000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9365.666999999998,
"heapDeltaBytes": -10837120,
"heapUsedBytes": 70530700,
"domNodes": 0,
"jsHeapTotalBytes": -12845056,
"scriptDurationMs": 7902.913,
"eventListeners": 0,
"totalBlockingTimeMs": 1438,
"frameDurationMs": 35.03265306122449,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10544.783000000052,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9599.214,
"heapDeltaBytes": 2369228,
"heapUsedBytes": 82766168,
"domNodes": 0,
"jsHeapTotalBytes": -13107200,
"scriptDurationMs": 7921.985000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1029,
"frameDurationMs": 31.535928143712574,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11488.606000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10464.562000000002,
"heapDeltaBytes": 13025524,
"heapUsedBytes": 93954284,
"domNodes": 0,
"jsHeapTotalBytes": -3145728,
"scriptDurationMs": 8723.772,
"eventListeners": 0,
"totalBlockingTimeMs": 1628,
"frameDurationMs": 33.380232558139525,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10590.192000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9603.759,
"heapDeltaBytes": -8856220,
"heapUsedBytes": 66139096,
"domNodes": 0,
"jsHeapTotalBytes": -11534336,
"scriptDurationMs": 7896.947,
"eventListeners": 0,
"totalBlockingTimeMs": 1104,
"frameDurationMs": 31.034897360703813,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2043.3980000000247,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.871000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 553.9010000000001,
"heapDeltaBytes": -35777048,
"heapUsedBytes": 82895992,
"domNodes": -228,
"jsHeapTotalBytes": -360448,
"scriptDurationMs": 33.303,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2067.6999999999452,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.262000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.154,
"heapDeltaBytes": -35642200,
"heapUsedBytes": 82604752,
"domNodes": -228,
"jsHeapTotalBytes": -1146880,
"scriptDurationMs": 33.97599999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2182.6369999999997,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.373000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1440.5430000000001,
"heapDeltaBytes": 19859980,
"heapUsedBytes": 83140992,
"domNodes": -228,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 834.255,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.924031007751935,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2495.679999999993,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.415,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1630.1960000000001,
"heapDeltaBytes": 24731104,
"heapUsedBytes": 88241508,
"domNodes": -228,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 850.782,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.778378378378385,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3757.216000000028,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.527999999999999,
"layouts": 60,
"layoutDurationMs": 14.059,
"taskDurationMs": 1737.9539999999997,
"heapDeltaBytes": 8555776,
"heapUsedBytes": 73302236,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 801.489,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66592920353982,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3514.8080000000164,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.546,
"layouts": 60,
"layoutDurationMs": 13.492,
"taskDurationMs": 1503.385,
"heapDeltaBytes": 9475460,
"heapUsedBytes": 73399800,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 772.073,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66619047619048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3147.559000000001,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.7219999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1906.754,
"heapDeltaBytes": 22953412,
"heapUsedBytes": 88108624,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 980.1099999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84438502673797,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3139.7289999999884,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.769,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1936.6539999999998,
"heapDeltaBytes": 683592,
"heapUsedBytes": 66213456,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 985.279,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75537634408602,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2027.494000000047,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.189,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.2849999999999,
"heapDeltaBytes": 21020256,
"heapUsedBytes": 84229264,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.43599999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2046.0879999999406,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.384000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.8289999999998,
"heapDeltaBytes": -36966300,
"heapUsedBytes": 84149088,
"domNodes": -228,
"jsHeapTotalBytes": -360448,
"scriptDurationMs": 33.038,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.7729999999515,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.926000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.007,
"heapDeltaBytes": 13142160,
"heapUsedBytes": 93588724,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 145.88299999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 626.9810000000007,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.958000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.18299999999994,
"heapDeltaBytes": 12712488,
"heapUsedBytes": 94019388,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 155.143,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.127777777777787,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2041.061999999954,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.172000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.69599999999997,
"heapDeltaBytes": -18806404,
"heapUsedBytes": 61900492,
"domNodes": -244,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 8.851999999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2040.3479999999945,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.134,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.01199999999994,
"heapDeltaBytes": -27348692,
"heapUsedBytes": 53745096,
"domNodes": -244,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 8.806000000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1758.0480000000307,
"styleRecalcs": 74,
"styleRecalcDurationMs": 17.565,
"layouts": 16,
"layoutDurationMs": 8.999,
"taskDurationMs": 771.227,
"heapDeltaBytes": -5556168,
"heapUsedBytes": 75721852,
"domNodes": -244,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 111.398,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.7140000000918,
"styleRecalcs": 74,
"styleRecalcDurationMs": 19.776000000000003,
"layouts": 16,
"layoutDurationMs": 5.769,
"taskDurationMs": 770.351,
"heapDeltaBytes": -23098724,
"heapUsedBytes": 58184276,
"domNodes": -244,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 114.35100000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.827184466019414,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1402.8819999999769,
"styleRecalcs": 17,
"styleRecalcDurationMs": 30.945,
"layouts": 5,
"layoutDurationMs": 13.401999999999997,
"taskDurationMs": 941.8470000000001,
"heapDeltaBytes": 21474452,
"heapUsedBytes": 98508432,
"domNodes": 13667,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 40.862,
"eventListeners": 2383,
"totalBlockingTimeMs": 136,
"frameDurationMs": 19.675000000000004,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8656.668999999965,
"styleRecalcs": 249,
"styleRecalcDurationMs": 32.72,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5510.811000000001,
"heapDeltaBytes": -37153560,
"heapUsedBytes": 80541412,
"domNodes": -228,
"jsHeapTotalBytes": -167936,
"scriptDurationMs": 2976.6569999999997,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.730308880308883,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8357.70100000002,
"styleRecalcs": 250,
"styleRecalcDurationMs": 33.737,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5662.936000000001,
"heapDeltaBytes": -39302868,
"heapUsedBytes": 79889552,
"domNodes": -228,
"jsHeapTotalBytes": -430080,
"scriptDurationMs": 2742.043,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6994,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16643.60499999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16257.117,
"heapDeltaBytes": -41721120,
"heapUsedBytes": 162573536,
"domNodes": -3045,
"jsHeapTotalBytes": 5779456,
"scriptDurationMs": 274.634,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.99891891891892,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 12675.495999999952,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12010.597,
"heapDeltaBytes": -39667280,
"heapUsedBytes": 183368704,
"domNodes": -8044,
"jsHeapTotalBytes": 9543680,
"scriptDurationMs": 211.30700000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.83810344827586,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 20450.122999999963,
"styleRecalcs": 148,
"styleRecalcDurationMs": 16.850000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20232.986,
"heapDeltaBytes": -38562724,
"heapUsedBytes": 190557988,
"domNodes": -3045,
"jsHeapTotalBytes": 3805184,
"scriptDurationMs": 974.793,
"eventListeners": -14915,
"totalBlockingTimeMs": 78,
"frameDurationMs": 39.63003875968992,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20249.56199999997,
"styleRecalcs": 155,
"styleRecalcDurationMs": 16.686000000000035,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19962.155,
"heapDeltaBytes": -17949268,
"heapUsedBytes": 179446800,
"domNodes": -3046,
"jsHeapTotalBytes": 9392128,
"scriptDurationMs": 892.1510000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 76,
"frameDurationMs": 38.685277246653925,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6168.769999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.56700000000001,
"layouts": 20,
"layoutDurationMs": 22.745,
"taskDurationMs": 6075.364,
"heapDeltaBytes": 876192,
"heapUsedBytes": 225502264,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 109.04700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 467,
"frameDurationMs": 38.78238993710691,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6142.641000000026,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.29599999999998,
"layouts": 20,
"layoutDurationMs": 22.254999999999995,
"taskDurationMs": 6032.349,
"heapDeltaBytes": -12379480,
"heapUsedBytes": 212062940,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 107.395,
"eventListeners": 0,
"totalBlockingTimeMs": 439,
"frameDurationMs": 36.94638554216866,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8701.056999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8438.942000000001,
"heapDeltaBytes": -23168168,
"heapUsedBytes": 179634008,
"domNodes": -3046,
"jsHeapTotalBytes": 12115968,
"scriptDurationMs": 134.93399999999994,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.57359154929578,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8618.910999999913,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8411.707000000002,
"heapDeltaBytes": -14131516,
"heapUsedBytes": 183266196,
"domNodes": 0,
"jsHeapTotalBytes": -28573696,
"scriptDurationMs": 155.18300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.964111498257843,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "workflow-execution",
"durationMs": 524.4390000000294,
"styleRecalcs": 24,
"styleRecalcDurationMs": 26.305000000000003,
"layouts": 6,
"layoutDurationMs": 2.6870000000000003,
"taskDurationMs": 175.13500000000005,
"heapDeltaBytes": -14843436,
"heapUsedBytes": 82242904,
"domNodes": 133,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 18.967,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 477.64199999994617,
"styleRecalcs": 14,
"styleRecalcDurationMs": 14.902999999999999,
"layouts": 3,
"layoutDurationMs": 0.8980000000000001,
"taskDurationMs": 125.18200000000002,
"heapDeltaBytes": -14510208,
"heapUsedBytes": 82213984,
"domNodes": 101,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 10.564999999999998,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241396,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 863.5860000000548,
"styleRecalcs": 78,
"styleRecalcDurationMs": 107.19800000000001,
"layouts": 76,
"layoutDurationMs": 21.576,
"taskDurationMs": 828.975,
"heapDeltaBytes": 17647784,
"heapUsedBytes": 87578596,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 335.961,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66346153846154,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 887.8639999999223,
"styleRecalcs": 78,
"styleRecalcDurationMs": 105.136,
"layouts": 76,
"layoutDurationMs": 21.862,
"taskDurationMs": 847.811,
"heapDeltaBytes": 18078856,
"heapUsedBytes": 88602308,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 346.544,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584904,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1329.6100000000024,
"styleRecalcs": 78,
"styleRecalcDurationMs": 236.035,
"layouts": 76,
"layoutDurationMs": 23.485,
"taskDurationMs": 1316.5980000000002,
"heapDeltaBytes": 8814632,
"heapUsedBytes": 116336244,
"domNodes": -7945,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 442.9789999999999,
"eventListeners": -1226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.875949367088616,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1427.7910000000702,
"styleRecalcs": 78,
"styleRecalcDurationMs": 253.73499999999999,
"layouts": 76,
"layoutDurationMs": 25.416999999999998,
"taskDurationMs": 1401.65,
"heapDeltaBytes": 8995284,
"heapUsedBytes": 120996816,
"domNodes": -7943,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 490.561,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.931645569620258,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #19212 +/- ##
==========================================
- Coverage 84.25% 84.24% -0.01%
==========================================
Files 3236 3237 +1
Lines 157143 157399 +256
Branches 40718 42722 +2004
==========================================
+ Hits 132395 132603 +208
- Misses 23044 23069 +25
- Partials 1704 1727 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 37 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
bcb77a0 to
718fbbf
Compare
718fbbf to
77dfb2e
Compare
77dfb2e to
97d6eed
Compare
97d6eed to
40df6e0
Compare
The synced ingest types add an optional int64 `credits` to Plan, which the generated zod schema decodes as a bigint. projectPlan spread the decoded plan into the number-typed Plan, so typecheck failed. The grant is now read back through asSafeNumber like every other catalog int64: absent stays absent, and a value a number cannot hold refuses the plan.
|
Pushed |
…log (Comfy-Org#18873) ## Summary The pricing cards read the plan's raw credit grant from the backend (`Plan.credits`, added in Comfy-Org/cloud#10703) instead of the hardcoded `TIER_PRICING` figure. They fall back to the static grant only when the field is absent. - Follows Comfy-Org#18867 (the FE-3013 hotfix). Part of FE-3013. - Comfy-Org/cloud#10703 is merged and live on test-v2. The generated `Plan.credits` type and its SDK projection landed on `main` through Comfy-Org#19212, so this PR is now only the pricing surfaces reading it. Until prod serves the field, both tables fall back to the static grant. ## Why The hotfix Comfy-Org#18867 stops misreading `credits_cents` by going back to a static grant. A static grant cannot follow a catalog change. Converting `credits_cents` cannot produce the real grant either, because the backend rounds it to whole cents: 23,887¢ → 50,402, while the catalog grants 50,400. The backend now sends the grant itself. ## Root cause `Plan` exposed the grant only as `credits_cents`. The raw count the subscription actually receives, the catalog's `credit_grant`, never reached the client. ## How - `Plan.credits` (generated types) and its safe-number projection in `billingPlansView.ts` are on `main` via Comfy-Org#19212. - `UnifiedPricingTable.vue` / `PricingTableWorkspace.vue`: `plan.credits ?? amountForBillingCycle(static)`. The value is read straight off the server; nothing is derived. - Tests: the catalog grant wins over the static figure on the matching cycle only. The Comfy-Org#18867 tests still pin the fallback (field absent) to the static grant. ## Screenshots Both builds run locally against the Comfy-Org/cloud#10703 preview backend (`pr-10703.testenvs.comfy.org`). The page's own `GET /api/billing/plans` response already carries `credits`: | slug | `credits_cents` | `credits` | | --- | --- | --- | | standard-monthly | 1,991 | 4,200 | | standard-annual | 23,887 | 50,400 | | creator-monthly | 3,508 | 7,400 | | creator-annual | 42,086 | 88,800 | | pro-monthly | 10,000 | 21,100 | | pro-annual | 120,000 | 253,200 | AS IS (Comfy-Org#18867, `86fba0349b`, static grant): Yearly 50,400 / 88,800 / 253,200; Monthly 4,200 / 7,400 / 21,100. | Yearly | Monthly | | --- | --- | | <img width="480" alt="asis-yearly" src="https://github.com/user-attachments/assets/a790c178-0acd-4a1f-9f38-b1925ddbddc2" /> | <img width="480" alt="asis-monthly" src="https://github.com/user-attachments/assets/3dfb46e7-f7cc-486b-98af-8f49a15265ef" /> | TO BE (`a7270257f7`, reads `plan.credits`): same figures, Yearly 50,400 / 88,800 / 253,200; Monthly 4,200 / 7,400 / 21,100. The numbers now come from the API instead of the static table. | Yearly | Monthly | | --- | --- | | <img width="480" alt="tobe-yearly" src="https://github.com/user-attachments/assets/94eafd26-f717-4d31-a6c6-8d2e861617fe" /> | <img width="480" alt="tobe-monthly" src="https://github.com/user-attachments/assets/6e7733e0-71d1-44ee-9b43-b5f318dbcbe7" /> |
…t only when a send is refused (Comfy-Org#18967) Tracks [FE-3033](https://linear.app/comfyorg/issue/FE-3033/bug-agent-paywall-card-not-shown-when-credits-run-out-card-is-only) (the Agent paywall visibility bug and effective-funds contract). ## The problem Before this change, the Agent panel exposes the paywall only as an inline card created from a refused send. There is no standing recovery surface driven by the workspace's current Agent-effective funds state, so the panel can remain actionable-looking after that state becomes exhausted. ## The change The workspace billing adapter maps `scoped_effective_has_funds["agent"]` to `subscription.agentHasFunds`, with `has_funds` as the older-server fallback. `AgentPanelRoot` uses that value in both directions: becoming *true* clears inline paywalls, while becoming *false* renders the existing `AgentPaywallCard` in the panel footer beside the composer. After an observed active-to-idle Agent turn transition, the panel requests fresh workspace billing status. Separately, the persistent dock host watches for funds recovery even while the panel is closed and clears the stored exhaustion identity, so a later exhaustion episode can report a new impression. **It is non-modal and disables nothing.** The composer stays live and a send still goes through to be answered by the server. Guards: - Gated on the billing capability read having **settled** — the same gate the existing impression already used. An unsettled read cannot say which remediation is right, and a card naming the wrong one is worse than no card. - Hidden when the presentation resolves to `unavailable`, which renders no action at all. - Hidden while `agentHasFunds` is `null` — that is "not loaded", not "no funds". - **Suppressed while the latest transcript entry is an unresolved inline card**, so the two never render the same copy twice. Older inline cards may remain in the transcript alongside the standing surface after a later reply. - **One impression per exhaustion episode**, reset when funds return. A standing surface reported per render would make impressions a function of session length. - **Workspace billing only.** Legacy billing does not drive the standing surface. ## Telemetry contract change — please read `app:agent_paywall_shown` and `app:agent_paywall_cta_clicked` now carry a **required** `surface: 'refused_send' | 'credits_exhausted'`. This is deliberately required rather than optional. Without it, `app:agent_paywall_shown` cannot distinguish the existing refusal-anchored card from the new standing exhaustion card. Optional would have silently defaulted existing call sites into an unlabelled bucket and recreated that ambiguity, so this fails at compile time instead. It reaches two concrete providers plus `TelemetryRegistry`; **happy to make it optional if you'd rather not take the contract break.** Any existing dashboard on those two events should split by `surface`. ## How to tell if it worked Evaluate `app:agent_paywall_shown` and `app:agent_paywall_cta_clicked` by the required `surface` property. For the standing path, report the `credits_exhausted` impression count, its named eligible population and denominator, and the `reason=unknown` share. Total impressions without the surface split, a cross-stream person join without an approved identity contract, or a single rendered session do not establish the population-level result. ## Tests At exact head `7f22a90177`, this focused command passes **571/571 tests across seven files**: ```sh pnpm test:unit src/platform/workspace/composables/useWorkspaceBilling.test.ts src/composables/billing/useBillingContext.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.ts src/workbench/extensions/agent/components/agent/DockedAgentPanel.test.ts src/workbench/extensions/agent/composables/useAgentDockMount.test.ts src/workbench/extensions/agent/stores/agent/agentPanelStoreId.test.ts src/extensions/core/agentPanel.test.ts ``` `pnpm typecheck`, `pnpm typecheck:browser`, scoped ESLint, and Oxfmt also pass. The retained cloud Playwright lifecycle covers accepted-turn exhaustion, active-to-idle refresh, closed-panel recovery, a second exhaustion episode, and final funded recovery; this orb cannot execute that body because it has no authenticated Cloud backend. Selected cases from the 29-case `describe('AgentPanelRoot standing credits-exhausted paywall')` block include: shows with no refusal first · allows a new turn while visible · reports `surface: 'credits_exhausted'` · CTA attribution and credits flow · hidden when funded · hidden while billing is unknown · hidden until capabilities settle · yields to the latest inline card · returns after an older inline card · reports a new billing identity only when its card is shown · one impression per episode and identity. The two pre-existing paywall describes are about the *inline* card, and their queries were unscoped (`getByRole('button', { name: 'Subscribe' })`), which is now ambiguous between two surfaces rendering the same component. They are scoped to the transcript via `data-testid="agent-conversation"`, which makes each one say what it always meant. **No assertion was weakened** — `shows only a new denial after funds run out again` still holds in substance, since the inline card genuinely does not reappear without a new denial. `paywall telemetry`'s fixture is now `hasFunds = true` to isolate the refusal-driven surface, with a comment pointing at the new describe. ## Effective-funds dependency [Cloud PR Comfy-Org#10868](Comfy-Org/cloud#10868) supplies product-keyed `scoped_effective_has_funds`; the billing adapter consumes `scoped_effective_has_funds["agent"]` and falls back to the existing shared `has_funds` value only for older-server rollout compatibility. The four fallback/override combinations are table-tested. The generated billing-status fields now match the automated frontend sync in [PR Comfy-Org#19212](Comfy-Org#19212), generated from `cloud@4c75dea`. --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
…log (#18873) ## Summary The pricing cards read the plan's raw credit grant from the backend (`Plan.credits`, added in Comfy-Org/cloud#10703) instead of the hardcoded `TIER_PRICING` figure. They fall back to the static grant only when the field is absent. - Follows #18867 (the FE-3013 hotfix). Part of FE-3013. - Comfy-Org/cloud#10703 is merged and live on test-v2. The generated `Plan.credits` type and its SDK projection landed on `main` through #19212, so this PR is now only the pricing surfaces reading it. Until prod serves the field, both tables fall back to the static grant. ## Why The hotfix #18867 stops misreading `credits_cents` by going back to a static grant. A static grant cannot follow a catalog change. Converting `credits_cents` cannot produce the real grant either, because the backend rounds it to whole cents: 23,887¢ → 50,402, while the catalog grants 50,400. The backend now sends the grant itself. ## Root cause `Plan` exposed the grant only as `credits_cents`. The raw count the subscription actually receives, the catalog's `credit_grant`, never reached the client. ## How - `Plan.credits` (generated types) and its safe-number projection in `billingPlansView.ts` are on `main` via #19212. - `UnifiedPricingTable.vue` / `PricingTableWorkspace.vue`: `plan.credits ?? amountForBillingCycle(static)`. The value is read straight off the server; nothing is derived. - Tests: the catalog grant wins over the static figure on the matching cycle only. The #18867 tests still pin the fallback (field absent) to the static grant. ## Screenshots Both builds run locally against the Comfy-Org/cloud#10703 preview backend (`pr-10703.testenvs.comfy.org`). The page's own `GET /api/billing/plans` response already carries `credits`: | slug | `credits_cents` | `credits` | | --- | --- | --- | | standard-monthly | 1,991 | 4,200 | | standard-annual | 23,887 | 50,400 | | creator-monthly | 3,508 | 7,400 | | creator-annual | 42,086 | 88,800 | | pro-monthly | 10,000 | 21,100 | | pro-annual | 120,000 | 253,200 | AS IS (#18867, `86fba0349b`, static grant): Yearly 50,400 / 88,800 / 253,200; Monthly 4,200 / 7,400 / 21,100. | Yearly | Monthly | | --- | --- | | <img width="480" alt="asis-yearly" src="https://github.com/user-attachments/assets/a790c178-0acd-4a1f-9f38-b1925ddbddc2" /> | <img width="480" alt="asis-monthly" src="https://github.com/user-attachments/assets/3dfb46e7-f7cc-486b-98af-8f49a15265ef" /> | TO BE (`a7270257f7`, reads `plan.credits`): same figures, Yearly 50,400 / 88,800 / 253,200; Monthly 4,200 / 7,400 / 21,100. The numbers now come from the API instead of the static table. | Yearly | Monthly | | --- | --- | | <img width="480" alt="tobe-yearly" src="https://github.com/user-attachments/assets/94eafd26-f717-4d31-a6c6-8d2e861617fe" /> | <img width="480" alt="tobe-monthly" src="https://github.com/user-attachments/assets/6e7733e0-71d1-44ee-9b43-b5f318dbcbe7" /> |
…log (#18873) ## Summary The pricing cards read the plan's raw credit grant from the backend (`Plan.credits`, added in Comfy-Org/cloud#10703) instead of the hardcoded `TIER_PRICING` figure. They fall back to the static grant only when the field is absent. - Follows #18867 (the FE-3013 hotfix). Part of FE-3013. - Comfy-Org/cloud#10703 is merged and live on test-v2. The generated `Plan.credits` type and its SDK projection landed on `main` through #19212, so this PR is now only the pricing surfaces reading it. Until prod serves the field, both tables fall back to the static grant. ## Why The hotfix #18867 stops misreading `credits_cents` by going back to a static grant. A static grant cannot follow a catalog change. Converting `credits_cents` cannot produce the real grant either, because the backend rounds it to whole cents: 23,887¢ → 50,402, while the catalog grants 50,400. The backend now sends the grant itself. ## Root cause `Plan` exposed the grant only as `credits_cents`. The raw count the subscription actually receives, the catalog's `credit_grant`, never reached the client. ## How - `Plan.credits` (generated types) and its safe-number projection in `billingPlansView.ts` are on `main` via #19212. - `UnifiedPricingTable.vue` / `PricingTableWorkspace.vue`: `plan.credits ?? amountForBillingCycle(static)`. The value is read straight off the server; nothing is derived. - Tests: the catalog grant wins over the static figure on the matching cycle only. The #18867 tests still pin the fallback (field absent) to the static grant. ## Screenshots Both builds run locally against the Comfy-Org/cloud#10703 preview backend (`pr-10703.testenvs.comfy.org`). The page's own `GET /api/billing/plans` response already carries `credits`: | slug | `credits_cents` | `credits` | | --- | --- | --- | | standard-monthly | 1,991 | 4,200 | | standard-annual | 23,887 | 50,400 | | creator-monthly | 3,508 | 7,400 | | creator-annual | 42,086 | 88,800 | | pro-monthly | 10,000 | 21,100 | | pro-annual | 120,000 | 253,200 | AS IS (#18867, `86fba0349b`, static grant): Yearly 50,400 / 88,800 / 253,200; Monthly 4,200 / 7,400 / 21,100. | Yearly | Monthly | | --- | --- | | <img width="480" alt="asis-yearly" src="https://github.com/user-attachments/assets/a790c178-0acd-4a1f-9f38-b1925ddbddc2" /> | <img width="480" alt="asis-monthly" src="https://github.com/user-attachments/assets/3dfb46e7-f7cc-486b-98af-8f49a15265ef" /> | TO BE (`a7270257f7`, reads `plan.credits`): same figures, Yearly 50,400 / 88,800 / 253,200; Monthly 4,200 / 7,400 / 21,100. The numbers now come from the API instead of the static table. | Yearly | Monthly | | --- | --- | | <img width="480" alt="tobe-yearly" src="https://github.com/user-attachments/assets/94eafd26-f717-4d31-a6c6-8d2e861617fe" /> | <img width="480" alt="tobe-monthly" src="https://github.com/user-attachments/assets/6e7733e0-71d1-44ee-9b43-b5f318dbcbe7" /> |
…log (#18873) ## Summary The pricing cards read the plan's raw credit grant from the backend (`Plan.credits`, added in Comfy-Org/cloud#10703) instead of the hardcoded `TIER_PRICING` figure. They fall back to the static grant only when the field is absent. - Follows #18867 (the FE-3013 hotfix). Part of FE-3013. - Comfy-Org/cloud#10703 is merged and live on test-v2. The generated `Plan.credits` type and its SDK projection landed on `main` through #19212, so this PR is now only the pricing surfaces reading it. Until prod serves the field, both tables fall back to the static grant. ## Why The hotfix #18867 stops misreading `credits_cents` by going back to a static grant. A static grant cannot follow a catalog change. Converting `credits_cents` cannot produce the real grant either, because the backend rounds it to whole cents: 23,887¢ → 50,402, while the catalog grants 50,400. The backend now sends the grant itself. ## Root cause `Plan` exposed the grant only as `credits_cents`. The raw count the subscription actually receives, the catalog's `credit_grant`, never reached the client. ## How - `Plan.credits` (generated types) and its safe-number projection in `billingPlansView.ts` are on `main` via #19212. - `UnifiedPricingTable.vue` / `PricingTableWorkspace.vue`: `plan.credits ?? amountForBillingCycle(static)`. The value is read straight off the server; nothing is derived. - Tests: the catalog grant wins over the static figure on the matching cycle only. The #18867 tests still pin the fallback (field absent) to the static grant. ## Screenshots Both builds run locally against the Comfy-Org/cloud#10703 preview backend (`pr-10703.testenvs.comfy.org`). The page's own `GET /api/billing/plans` response already carries `credits`: | slug | `credits_cents` | `credits` | | --- | --- | --- | | standard-monthly | 1,991 | 4,200 | | standard-annual | 23,887 | 50,400 | | creator-monthly | 3,508 | 7,400 | | creator-annual | 42,086 | 88,800 | | pro-monthly | 10,000 | 21,100 | | pro-annual | 120,000 | 253,200 | AS IS (#18867, `86fba0349b`, static grant): Yearly 50,400 / 88,800 / 253,200; Monthly 4,200 / 7,400 / 21,100. | Yearly | Monthly | | --- | --- | | <img width="480" alt="asis-yearly" src="https://github.com/user-attachments/assets/a790c178-0acd-4a1f-9f38-b1925ddbddc2" /> | <img width="480" alt="asis-monthly" src="https://github.com/user-attachments/assets/3dfb46e7-f7cc-486b-98af-8f49a15265ef" /> | TO BE (`a7270257f7`, reads `plan.credits`): same figures, Yearly 50,400 / 88,800 / 253,200; Monthly 4,200 / 7,400 / 21,100. The numbers now come from the API instead of the static table. | Yearly | Monthly | | --- | --- | | <img width="480" alt="tobe-yearly" src="https://github.com/user-attachments/assets/94eafd26-f717-4d31-a6c6-8d2e861617fe" /> | <img width="480" alt="tobe-monthly" src="https://github.com/user-attachments/assets/6e7733e0-71d1-44ee-9b43-b5f318dbcbe7" /> |
Automated Ingest API Type Update
This PR updates the Ingest API TypeScript types and Zod schemas from the latest cloud OpenAPI specification.
These types cover the FE-facing ingest API (workspaces, billing, secrets, assets, tasks, etc.).
Cloud's internal / machine-to-machine surface —
x-internaloperations and the/admin/,/api/internal/,/api/webhooks/rails — is stripped before generation(BE-2669), so it is not code-generated into this public package.